GNU bug report logs - #77928
[PATCH] use-package :custom-face is meant to behave like custom-set-face

Previous Next

Full log

View this message in rfc822 format

From: Michael Shields <shields <at> msrl.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77928 <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces
Date: Sat, 17 May 2025 17:39:04 -0700

[Message part 1 (text/plain, inline)]

I can take a look at this tomorrow.

On Sat, May 17, 2025 at 1:02 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> Ping!  Michael, could you please chime in?
>
> > Cc: 77928 <at> debbugs.gnu.org
> > Date: Thu, 01 May 2025 20:43:28 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > > Date: Wed, 30 Apr 2025 14:26:34 -0700
> > > From:  Steven Allen via "Bug reports for GNU Emacs,
> > >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> > >
> > >
> > > ebcde0f90f6 (bug#77928) makes it impossible to override themed faces
> with
> > > :custom-face. This can be reproduced by:
> > >
> > > 1. Applying a theme (tested with modus).
> > > 2. Then attempt to override a themed face with ":custom-face".
> > >
> > > E.g., put the following into a scratch buffer and eval it.
> > >
> > >     (load-theme 'modus-vivendi)
> > >     (use-package emacs :custom-face (font-lock-keyword-face ((t
> :italic t))))
> > >
> > > I'd expect my keywords to become italic but nothing happens (tested
> with
> > > `emacs -Q`).
> > >
> > > Additionally, this patch (as it was intended, as far as I can tell)
> > > makes the :custom-face feature much less useful for tweaking faces.
> > > Previously, it was possible to achieve both behaviors (override or
> > > merge), now it's only possible to override faces entirely which isn't
> > > nearly as useful.
> > >
> > > (I posted a comment on
> > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77928#28 but the bug was
> > > already closed)
> >
> > Thanks.
> >
> > Michael, could you please look into this regression?
> >
> >
> >
> >
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.