GNU bug report logs - #77928
[PATCH] use-package :custom-face is meant to behave like custom-set-face

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Shields <shields <at> msrl.com>
Subject: bug#77928: closed (Re: bug#77928: [PATCH] use-package
 :custom-face is meant to behave like custom-set-face)
Date: Sun, 27 Apr 2025 07:52:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77928 <at> debbugs.gnu.org.

-- 
77928: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77928
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Shields <shields <at> msrl.com>
Cc: 77928-done <at> debbugs.gnu.org, johnw <at> gnu.org
Subject: Re: bug#77928: [PATCH] use-package :custom-face is meant to behave
 like custom-set-face
Date: Sun, 27 Apr 2025 10:50:50 +0300

> From: Michael Shields <shields <at> msrl.com>
> Date: Sat, 26 Apr 2025 13:35:42 -0700
> Cc: John Wiegley <johnw <at> gnu.org>, 77928 <at> debbugs.gnu.org
> 
> Attached is a combined patch with an updated commit message.
> 
> I cannot reproduce those test failures. I see 167/167 tests pass when I run `make -C test
> check-lisp-use-package'. I'm testing commit be4819b, plus the attached patch, on macOS 15.4.1.

Thanks, installed on the master branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Michael Shields <shields <at> msrl.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] use-package :custom-face is meant to behave like
 custom-set-face
Date: Sat, 19 Apr 2025 13:41:01 -0700

[Message part 4 (text/plain, inline)]

The attached patch fixes a bug where migrating a face spec from custom.el
to use-package :custom-face results in a surprising behavior change: the
new spec is overlaid on the default value instead of replacing it. This
seems to have been an unintended consequence of
https://github.com/jwiegley/use-package/issues/934.

[Message part 5 (text/html, inline)]

[0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.