Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces

From: Eli Zaretskii <[email-masked]>
Date: Sun, 08 Jun 2025 22:04:17 +0300

> From: John Wiegley <[email-masked]>
> Cc: Eli Zaretskii <[email-masked]>,  [email-masked],  [email-masked]
> Date: Sun, 08 Jun 2025 10:46:14 -0700
> 
> >>>>> Steven Allen <[email-masked]> writes:
> 
> > - Should customizations made via :custom-face be merged with the original
> >   face definition (as with `custom-set-faces') or should they completely
> >   replace the underlying face.
> 
> I would expect the behavior to be whatever `custom-set-faces' does. Since
> use-package is only intended to expand to “best practice” Emacs Lisp, it
> shouldn’t add any new behavior in my opinion.

Then IMO :custom-face should expand into a call to custom-set-faces.