From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face Resent-From: Michael Shields Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Apr 2025 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 77928@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174509528820270 (code B ref -1); Sat, 19 Apr 2025 20:42:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Apr 2025 20:41:28 +0000 Received: from localhost ([127.0.0.1]:38479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6F0A-0005GV-34 for submit@debbugs.gnu.org; Sat, 19 Apr 2025 16:41:27 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6F06-0005FG-Oo for submit@debbugs.gnu.org; Sat, 19 Apr 2025 16:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6F00-0008Sr-FX for bug-gnu-emacs@gnu.org; Sat, 19 Apr 2025 16:41:16 -0400 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u6Ezy-0003sF-Ms for bug-gnu-emacs@gnu.org; Sat, 19 Apr 2025 16:41:16 -0400 Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-e589c258663so2352301276.1 for ; Sat, 19 Apr 2025 13:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1745095272; x=1745700072; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=CZ8T0EIOa2QrXylL6G7C7KEFgk6IMWnam6Tnf8dHgi4=; b=NqoEJw3IIVMgvyMeQEIfHhl+SJanfuDDDXX9wdWfkS2fZ8eboGxhNoUgjgm5nCtDsp INlGBxDBZmrD2VuOY7IOv5O+i3ol6Ai2CIExSYu4OxM9dkHPvCs9Q/QDgpqc010W8PiC 4bDnkbjbS5bsEboBcbNHRTPLRWI6Yhn5ISCSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745095272; x=1745700072; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CZ8T0EIOa2QrXylL6G7C7KEFgk6IMWnam6Tnf8dHgi4=; b=xDQz1daKG16Ce4usxJeTKGuxK22p2DbMXYnNTNiF+0VCEN23KpPox4xHMpYhgVz6pS aamtC13oddX7HSmaajop4q4B4esCFcWcRA/SlN/J/NtMJ2TPx5hnsNJTEe9AUWmZGC4P fp1qMCjoUS7qSjqcJ6V8Bz9d4aYBokQkFXqOaNU+lR+gj7Uug3NamKGttH4HNPWqbtZp BSB0sTEDedg+kTCvOtsyAls7Eu8H/LtJPgH3v14jTQF9Sb0lA8Y7GPk2akVD6VaVNyM4 ncmqlwgkfezCOUPLv39uuAqAyb8aRBgd7Z2hn5ivFJoemAGAt1e6GaKrspTN9NGRl+Xn oeRQ== X-Gm-Message-State: AOJu0YwZUCDjoJyargAylJ1co1cymOi8lxjSUAJjDWZa5lw+YRgi3hMd 8+Plr3ybwaL9DKvNm5AuViu3ZuIXDaTS23PZvroMxzaHJVJZNtSRNqFftv5c4KDZ5j9Sfk1pnpv /IFuUeK+hQAFa7DWTvWNgNSvolzlDxHMzC0SF1Ce/9QOgtLZXkdM2 X-Gm-Gg: ASbGnctoNyrI1k0X2m6p1DOqx1Z3nBw+/wZgfh6I1GpNPLIgsaXC0tD89+xMEjnEJwG GBJQurXpSvDQStCTFDEhntOFzy8iPhCq2EsbAE73cAWbss431VTA5O5D0nAm+SsPwHXpfgNxdVx MmBaHOg+dvORFVwkSEQ5sQI5j7/ka0m1QMSarTXeOvv/mX10+PLBtUGyoe X-Google-Smtp-Source: AGHT+IGXoq3zP+nkr610GawSgLthEAAPjL4lHfKOnRxVxxdiY2rgrt1O9XelkfXg50LEHMS3AAydTOwX1s41hHErQz0= X-Received: by 2002:a05:6902:e8b:b0:e72:81e5:1ea with SMTP id 3f1490d57ef6-e7297ee525bmr9571914276.41.1745095272214; Sat, 19 Apr 2025 13:41:12 -0700 (PDT) MIME-Version: 1.0 From: Michael Shields Date: Sat, 19 Apr 2025 13:41:01 -0700 X-Gm-Features: ATxdqUGMEs_Hqzp4eHTx-Tp2yp9csKGPaw871S9iJoDaN9KWRLga0nljtDHJN9g Message-ID: Content-Type: multipart/mixed; boundary="000000000000cd024b063327a735" Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=shields@msrl.com; helo=mail-yb1-xb32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000cd024b063327a735 Content-Type: multipart/alternative; boundary="000000000000cd024a063327a733" --000000000000cd024a063327a733 Content-Type: text/plain; charset="UTF-8" The attached patch fixes a bug where migrating a face spec from custom.el to use-package :custom-face results in a surprising behavior change: the new spec is overlaid on the default value instead of replacing it. This seems to have been an unintended consequence of https://github.com/jwiegley/use-package/issues/934. --000000000000cd024a063327a733 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The attached patch fixes a bug where migrating a face spec= from custom.el to use-package :custom-face results in a surprising=C2=A0be= havior change: the new spec is overlaid on the default value instead of rep= lacing it. This seems to have been an unintended consequence of=C2=A0https://github.com= /jwiegley/use-package/issues/934.
--000000000000cd024a063327a733-- --000000000000cd024b063327a735 Content-Type: application/octet-stream; name="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Disposition: attachment; filename="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9ooamej0 RnJvbSA3NDhlNjIwZmUyZDI4NmE4NTNmNDAzMGJiYTE2Yzk5NDcwMzg3YTFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWVsZHMgPHNoaWVsZHNAbXNybC5jb20+CkRh dGU6IFNhdCwgMTkgQXByIDIwMjUgMTI6NTg6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXgg dXNlLXBhY2thZ2UgOmN1c3RvbS1mYWNlIHRvIHNldCBmYWNlLWRlZmZhY2Utc3BlYwoKQnkgZGVm YXVsdCwgYGZhY2Utc2V0LXNwZWMnIHNldHMgdGhlIG92ZXJyaWRlIGZhY2Ugc3BlYywgc28gdGhl IHN1cHBsaWVkCmZhY2UgYXR0cmlidXRlcyBhcmUgY29tYmluZWQgd2l0aCB0aGUgZGVmYXVsdCwg cmF0aGVyIHRoYW4gcmVwbGFjaW5nCnRoZW0uICBUaGlzIHdhcyBhIGJlaGF2aW9yIGNoYW5nZSB0 aGF0IHdhcyBhbiBhcHBhcmVudGx5IHVuaW50ZW5kZWQKY29uc2VxdWVuY2Ugb2YgY29tbWl0IDZi MzQ0YTkuCgpBbHNvIHNldCB0aGUgYGZhY2UtbW9kaWZpZWQnIHByb3BlcnR5LCB3aGljaCBjYXVz ZXMgQ3VzdG9taXplIHRvIGZsYWcKdGhlIGZhY2UgYXMgY2hhbmdlZCBvdXRzaWRlIEN1c3RvbWl6 ZS4KCiogZG9jL21pc2MvdXNlLXBhY2thZ2UudGV4aSAoRmFjZXMpOgoqIGxpc3AvdXNlLXBhY2th Z2UvdXNlLXBhY2thZ2UtY29yZS5lbCAodXNlLXBhY2thZ2UtaGFuZGxlci86Y3VzdG9tLWZhY2Up OgoodXNlLXBhY2thZ2UpOgoqIHRlc3QvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS10ZXN0 cy5lbCAodXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtMSk6Cih1c2UtcGFja2FnZS10ZXN0 LzpjdXN0b20tZmFjZS0yKToKKHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTMpOgoodXNl LXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtNCk6Ci0tLQogZG9jL21pc2MvdXNlLXBhY2thZ2Uu dGV4aSAgICAgICAgICAgICAgICAgIHwgIDUgKysrCiBsaXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNr YWdlLWNvcmUuZWwgICAgICAgfCAgOCArKystLQogdGVzdC9saXNwL3VzZS1wYWNrYWdlL3VzZS1w YWNrYWdlLXRlc3RzLmVsIHwgNDAgKysrKysrKysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFu Z2VkLCA0NSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9t aXNjL3VzZS1wYWNrYWdlLnRleGkgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCmluZGV4IGMx NGU3Yjc3ZDIzLi5jZGFlOGQ2ZTY2MiAxMDA2NDQKLS0tIGEvZG9jL21pc2MvdXNlLXBhY2thZ2Uu dGV4aQorKysgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCkBAIC0xNDU3LDYgKzE0NTcsMTEg QEAgRmFjZXMKIEBlbmQgZ3JvdXAKIEBlbmQgbGlzcAogCitTaW1pbGFybHkgdG8gQGNvZGV7OmN1 c3RvbX0gKEBweHJlZntVc2VyIG9wdGlvbnN9KSwgdGhpcyBhbGxvd3MKK2NvbmZpZ3VyaW5nIGN1 c3RvbWl6YWJsZSBmYWNlcyBvdXRzaWRlIG9mIEN1c3RvbWl6ZSAoQHB4cmVme1NhdmluZworQ3Vz dG9taXphdGlvbnMsLCwgZW1hY3MsIEdOVSBFbWFjcyBNYW51YWx9KS4gIFVzaW5nIGJvdGggc3lz dGVtcyB0bworY29uZmlndXJlIHRoZSBzYW1lIGZhY2UgY2FuIGxlYWQgdG8gY29uZnVzaW5nIHJl c3VsdHMuCisKIEBub2RlIEhpZGluZyBtaW5vciBtb2RlcwogQHNlY3Rpb24gSGlkaW5nIG1pbm9y IG1vZGVzIHdpdGggZGltaW5pc2ggYW5kIGRlbGlnaHQKIEBjaW5kZXggaGlkaW5nIG1pbm9yIG1v ZGVzCmRpZmYgLS1naXQgYS9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwgYi9s aXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwKaW5kZXggYzA0MDUzYzIyYWMuLjRi NjNkOTg1NjA0IDEwMDY0NAotLS0gYS9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUu ZWwKKysrIGIvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS1jb3JlLmVsCkBAIC0xNTg0LDcg KzE1ODQsMTEgQEAgdXNlLXBhY2thZ2Utbm9ybWFsaXplLzpjdXN0b20tZmFjZQogKGRlZnVuIHVz ZS1wYWNrYWdlLWhhbmRsZXIvOmN1c3RvbS1mYWNlIChuYW1lIF9rZXl3b3JkIGFyZ3MgcmVzdCBz dGF0ZSkKICAgIkdlbmVyYXRlIHVzZS1wYWNrYWdlIGN1c3RvbS1mYWNlIGtleXdvcmQgY29kZS4i CiAgICh1c2UtcGFja2FnZS1jb25jYXQKLSAgIChtYXBjYXIgIycobGFtYmRhIChkZWYpIGAoYXBw bHkgIydmYWNlLXNwZWMtc2V0IChiYWNrcXVvdGUgLGRlZikpKSBhcmdzKQorICAgKG1hcGNhciAj JyhsYW1iZGEgKGRlZikKKyAgICAgICAgICAgICAgIGAocHJvZ24KKyAgICAgICAgICAgICAgICAg IChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQgKGFwcGVuZCAoYmFja3F1b3RlICxkZWYpICcoZmFjZS1k ZWZmYWNlLXNwZWMpKSkKKyAgICAgICAgICAgICAgICAgIChwdXQgJywoY2FyIGRlZikgJ2ZhY2Ut bW9kaWZpZWQgdCkpKQorICAgICAgICAgICBhcmdzKQogICAgKHVzZS1wYWNrYWdlLXByb2Nlc3Mt a2V5d29yZHMgbmFtZSByZXN0IHN0YXRlKSkpCiAKIDs7OzsgOmluaXQKQEAgLTE4NDgsNyArMTg1 Miw3IEBAIHVzZS1wYWNrYWdlCiA6Y3VzdG9tICAgICAgICAgIENhbGwgYEN1c3RvbS1zZXQnIG9y IGBzZXQtZGVmYXVsdCcgd2l0aCBlYWNoIHZhcmlhYmxlCiAgICAgICAgICAgICAgICAgIGRlZmlu aXRpb24gd2l0aG91dCBtb2RpZnlpbmcgdGhlIEVtYWNzIGBjdXN0b20tZmlsZScuCiAgICAgICAg ICAgICAgICAgIChjb21wYXJlIHdpdGggYGN1c3RvbS1zZXQtdmFyaWFibGVzJykuCi06Y3VzdG9t LWZhY2UgICAgIENhbGwgYGN1c3RvbS1zZXQtZmFjZXMnIHdpdGggZWFjaCBmYWNlIGRlZmluaXRp b24uCis6Y3VzdG9tLWZhY2UgICAgIENhbGwgYGZhY2Utc3BlYy1zZXQnIHdpdGggZWFjaCBmYWNl IGRlZmluaXRpb24uCiA6ZW5zdXJlICAgICAgICAgIExvYWRzIHRoZSBwYWNrYWdlIHVzaW5nIHBh Y2thZ2UuZWwgaWYgbmVjZXNzYXJ5LgogOnBpbiAgICAgICAgICAgICBQaW4gdGhlIHBhY2thZ2Ug dG8gYW4gYXJjaGl2ZS4KIDp2YyAgICAgICAgICAgICAgSW5zdGFsbCB0aGUgcGFja2FnZSBkaXJl Y3RseSBmcm9tIGEgdmVyc2lvbiBjb250cm9sIHN5c3RlbQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNw L3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsIGIvdGVzdC9saXNwL3VzZS1wYWNrYWdl L3VzZS1wYWNrYWdlLXRlc3RzLmVsCmluZGV4IDg1NTRiMzdkNWI4Li5iMjIxYzVkZTVjMSAxMDA2 NDQKLS0tIGEvdGVzdC9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS10ZXN0cy5lbApAQCAtMTE1Myw3ICsx MTUzLDEyIEBAIHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTEKICAgKG1hdGNoLWV4cGFu c2lvbgogICAgKHVzZS1wYWNrYWdlIGZvbyA6Y3VzdG9tLWZhY2UgKGZvbyAoKHQgKDpiYWNrZ3Jv dW5kICIjZTRlZGZjIikpKSkpCiAgICBgKHByb2duCi0gICAgICAoYXBwbHkgIydmYWNlLXNwZWMt c2V0IChiYWNrcXVvdGUgKGZvbyAoKHQgKDpiYWNrZ3JvdW5kICIjZTRlZGZjIikpKSkpKQorICAg ICAgKHByb2duCisgICAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKKyAgICAgICAgICAgICAg IChhcHBlbmQgKGJhY2txdW90ZSAoZm9vICgodCAoOmJhY2tncm91bmQgIiNlNGVkZmMiKSkpKSkK KyAgICAgICAgICAgICAgICAgICAgICAgJyhmYWNlLWRlZmZhY2Utc3BlYykpCisgICAgICAgICAg ICAgICApCisgICAgICAgIChwdXQgJ2ZvbyAnZmFjZS1tb2RpZmllZCB0KSkKICAgICAgIChyZXF1 aXJlICdmb28gbmlsIG5pbCkpKSkKIAogKGVydC1kZWZ0ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmN1 c3RvbS1mYWNlLTIgKCkKQEAgLTExNjMsMTkgKzExNjgsNDIgQEAgdXNlLXBhY2thZ2UtdGVzdC86 Y3VzdG9tLWZhY2UtMgogICAgICAoZXhhbXBsZS0xLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGln aHRQaW5rIikpKSkKICAgICAgKGV4YW1wbGUtMi1mYWNlICgodCAoOmZvcmVncm91bmQgIkxpZ2h0 R3JlZW4iKSkpKSkKICAgIGAocHJvZ24KLSAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKLSAg ICAgICAgICAgICAoYmFja3F1b3RlIChleGFtcGxlLTEtZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJM aWdodFBpbmsiKSkpKSkpCi0gICAgICAoYXBwbHkgIydmYWNlLXNwZWMtc2V0Ci0gICAgICAgICAg ICAgKGJhY2txdW90ZSAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRHcmVl biIpKSkpKSkKKyAgICAgIChwcm9nbgorICAgICAgICAoYXBwbHkgIydmYWNlLXNwZWMtc2V0Cisg ICAgICAgICAgICAgICAoYXBwZW5kIChiYWNrcXVvdGUgKGV4YW1wbGUtMS1mYWNlICgodCAoOmZv cmVncm91bmQgIkxpZ2h0UGluayIpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAnKGZhY2Ut ZGVmZmFjZS1zcGVjKSkpCisgICAgICAgIChwdXQgJ2V4YW1wbGUtMS1mYWNlICdmYWNlLW1vZGlm aWVkIHQpKQorICAgICAgKHByb2duCisgICAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKKyAg ICAgICAgICAgICAgIChhcHBlbmQgKGJhY2txdW90ZSAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9y ZWdyb3VuZCAiTGlnaHRHcmVlbiIpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAnKGZhY2Ut ZGVmZmFjZS1zcGVjKSkpCisgICAgICAgIChwdXQgJ2V4YW1wbGUtMi1mYWNlICdmYWNlLW1vZGlm aWVkIHQpKQogICAgICAgKHJlcXVpcmUgJ2V4YW1wbGUgbmlsIG5pbCkpKSkKIAogKGVydC1kZWZ0 ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTMgKCkKICAgKG1hdGNoLWV4cGFuc2lv bgogICAgKHVzZS1wYWNrYWdlIGZvbyA6Y3VzdG9tLWZhY2UgKGZvbyAoKHQgKDpiYWNrZ3JvdW5k ICIjZTRlZGZjIikpKSBmYWNlLWRlZnNwZWMtc3BlYykpCiAgICBgKHByb2duCi0gICAgICAoYXBw bHkgIydmYWNlLXNwZWMtc2V0IChiYWNrcXVvdGUgKGZvbyAoKHQgKDpiYWNrZ3JvdW5kICIjZTRl ZGZjIikpKSBmYWNlLWRlZnNwZWMtc3BlYykpKQorICAgICAgKHByb2duCisgICAgICAgIChhcHBs eSAjJ2ZhY2Utc3BlYy1zZXQKKyAgICAgICAgICAgICAgIChhcHBlbmQgKGJhY2txdW90ZSAoZm9v ICgodCAoOmJhY2tncm91bmQgIiNlNGVkZmMiKSkpIGZhY2UtZGVmc3BlYy1zcGVjKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgJyhmYWNlLWRlZmZhY2Utc3BlYykpKQorICAgICAgICAocHV0ICdm b28gJ2ZhY2UtbW9kaWZpZWQgdCkpCiAgICAgICAocmVxdWlyZSAnZm9vIG5pbCBuaWwpKSkpCiAK KyhlcnQtZGVmdGVzdCB1c2UtcGFja2FnZS10ZXN0LzpjdXN0b20tZmFjZS00ICgpCisgIChkZWZm YWNlIHVzZS1wYWNrYWdlLXRlc3QvYmFzZS1mYWNlICcoKHQgKDpiYWNrZ3JvdW5kICJncmVlbiIp KSkgIiIpCisgIChkZWZmYWNlIHVzZS1wYWNrYWdlLXRlc3QvZmFjZSAnKCh0ICg6aW5oZXJpdCB1 c2UtcGFja2FnZS10ZXN0L2Jhc2UtZmFjZSkpKSAiIikKKyAgKHVzZS1wYWNrYWdlIGVtYWNzCisg ICAgOmN1c3RvbS1mYWNlCisgICAgKHVzZS1wYWNrYWdlLXRlc3QvZmFjZSAoKHQgKDpmb3JlZ3Jv dW5kICJibHVlIikpKSkpCisgIChzaG91bGQgKGVxdWFsIChmYWNlLWZvcmVncm91bmQgJ3VzZS1w YWNrYWdlLXRlc3QvZmFjZSBuaWwgdCkKKyAgICAgICAgICAgICAgICAgImJsdWUiKSkKKyAgKHNo b3VsZCAoZXF1YWwgKGZhY2UtYmFja2dyb3VuZCAndXNlLXBhY2thZ2UtdGVzdC9mYWNlIG5pbCB0 KQorICAgICAgICAgICAgICAgICBuaWwpKQorICAoc2hvdWxkIChlcXVhbCAoZ2V0ICd1c2UtcGFj a2FnZS10ZXN0L2ZhY2UgJ2ZhY2UtbW9kaWZpZWQpCisgICAgICAgICAgICAgICAgIHQpKSkKKwog KGVydC1kZWZ0ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmluaXQtMSAoKQogICAobWF0Y2gtZXhwYW5z aW9uCiAgICAodXNlLXBhY2thZ2UgZm9vIDppbml0IChpbml0KSkKLS0gCjIuNDkuMAoK --000000000000cd024b063327a735-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 06:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields , John Wiegley Cc: 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17451294612883 (code B ref 77928); Sun, 20 Apr 2025 06:12:01 +0000 Received: (at 77928) by debbugs.gnu.org; 20 Apr 2025 06:11:01 +0000 Received: from localhost ([127.0.0.1]:43678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6NtM-0000kI-Qy for submit@debbugs.gnu.org; Sun, 20 Apr 2025 02:11:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46074) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6NtJ-0000k2-SN for 77928@debbugs.gnu.org; Sun, 20 Apr 2025 02:10:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6NtD-0006zM-PY; Sun, 20 Apr 2025 02:10:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LacbFMTzflWo6KLbw6ZuVVlIkrh5Nj+7fQWKM0T42DQ=; b=q7lHjAz0rQVf 1MNmp+g6nWLZi+Ny1SWe3tRQwfeNCRdmZDlyZCLag3TenLWprUgmXNWVQdDKYnElKeEfIS1cn2kc7 MGoNwawZ6Wd4sW6nGq9Xl+6Y6jytrMhMCWK3htSc7R2s1tiubqlXlzSb3QvCr5WEpbZrKLFWgpwbG 3Dh2DAyUtzflWWfGvWOF1weTxZFvILjK557FoxVpYO3n4VlN0jyPvEGUL5z1gsuDASPYLyIhrk9ZX 74fPiDpUfVIRCgf3D8afJq5N5hvkyqSvxb9VP8GCqTV5qh3kobTvMLEZaT8CWyIpn/Hmk0IknbmEs PnpYNEKRJicraPVzPxprhQ==; Date: Sun, 20 Apr 2025 09:10:47 +0300 Message-Id: <86ldrv747s.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Michael Shields on Sat, 19 Apr 2025 13:41:01 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Shields > Date: Sat, 19 Apr 2025 13:41:01 -0700 > > The attached patch fixes a bug where migrating a face spec from custom.el to use-package :custom-face > results in a surprising behavior change: the new spec is overlaid on the default value instead of replacing it. > This seems to have been an unintended consequence of > https://github.com/jwiegley/use-package/issues/934. John, any comments? > From 748e620fe2d286a853f4030bba16c99470387a1b Mon Sep 17 00:00:00 2001 > From: Michael Shields > Date: Sat, 19 Apr 2025 12:58:26 -0700 > Subject: [PATCH] Fix use-package :custom-face to set face-defface-spec > > By default, `face-set-spec' sets the override face spec, so the supplied > face attributes are combined with the default, rather than replacing > them. This was a behavior change that was an apparently unintended > consequence of commit 6b344a9. > > Also set the `face-modified' property, which causes Customize to flag > the face as changed outside Customize. > > * doc/misc/use-package.texi (Faces): > * lisp/use-package/use-package-core.el (use-package-handler/:custom-face): > (use-package): > * test/lisp/use-package/use-package-tests.el (use-package-test/:custom-face-1): > (use-package-test/:custom-face-2): > (use-package-test/:custom-face-3): > (use-package-test/:custom-face-4): > --- > doc/misc/use-package.texi | 5 +++ > lisp/use-package/use-package-core.el | 8 +++-- > test/lisp/use-package/use-package-tests.el | 40 ++++++++++++++++++---- > 3 files changed, 45 insertions(+), 8 deletions(-) > > diff --git a/doc/misc/use-package.texi b/doc/misc/use-package.texi > index c14e7b77d23..cdae8d6e662 100644 > --- a/doc/misc/use-package.texi > +++ b/doc/misc/use-package.texi > @@ -1457,6 +1457,11 @@ Faces > @end group > @end lisp > > +Similarly to @code{:custom} (@pxref{User options}), this allows > +configuring customizable faces outside of Customize (@pxref{Saving > +Customizations,,, emacs, GNU Emacs Manual}). Using both systems to > +configure the same face can lead to confusing results. > + > @node Hiding minor modes > @section Hiding minor modes with diminish and delight > @cindex hiding minor modes > diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el > index c04053c22ac..4b63d985604 100644 > --- a/lisp/use-package/use-package-core.el > +++ b/lisp/use-package/use-package-core.el > @@ -1584,7 +1584,11 @@ use-package-normalize/:custom-face > (defun use-package-handler/:custom-face (name _keyword args rest state) > "Generate use-package custom-face keyword code." > (use-package-concat > - (mapcar #'(lambda (def) `(apply #'face-spec-set (backquote ,def))) args) > + (mapcar #'(lambda (def) > + `(progn > + (apply #'face-spec-set (append (backquote ,def) '(face-defface-spec))) > + (put ',(car def) 'face-modified t))) > + args) > (use-package-process-keywords name rest state))) > > ;;;; :init > @@ -1848,7 +1852,7 @@ use-package > :custom Call `Custom-set' or `set-default' with each variable > definition without modifying the Emacs `custom-file'. > (compare with `custom-set-variables'). > -:custom-face Call `custom-set-faces' with each face definition. > +:custom-face Call `face-spec-set' with each face definition. > :ensure Loads the package using package.el if necessary. > :pin Pin the package to an archive. > :vc Install the package directly from a version control system > diff --git a/test/lisp/use-package/use-package-tests.el b/test/lisp/use-package/use-package-tests.el > index 8554b37d5b8..b221c5de5c1 100644 > --- a/test/lisp/use-package/use-package-tests.el > +++ b/test/lisp/use-package/use-package-tests.el > @@ -1153,7 +1153,12 @@ use-package-test/:custom-face-1 > (match-expansion > (use-package foo :custom-face (foo ((t (:background "#e4edfc"))))) > `(progn > - (apply #'face-spec-set (backquote (foo ((t (:background "#e4edfc")))))) > + (progn > + (apply #'face-spec-set > + (append (backquote (foo ((t (:background "#e4edfc"))))) > + '(face-defface-spec)) > + ) > + (put 'foo 'face-modified t)) > (require 'foo nil nil)))) > > (ert-deftest use-package-test/:custom-face-2 () > @@ -1163,19 +1168,42 @@ use-package-test/:custom-face-2 > (example-1-face ((t (:foreground "LightPink")))) > (example-2-face ((t (:foreground "LightGreen"))))) > `(progn > - (apply #'face-spec-set > - (backquote (example-1-face ((t (:foreground "LightPink")))))) > - (apply #'face-spec-set > - (backquote (example-2-face ((t (:foreground "LightGreen")))))) > + (progn > + (apply #'face-spec-set > + (append (backquote (example-1-face ((t (:foreground "LightPink"))))) > + '(face-defface-spec))) > + (put 'example-1-face 'face-modified t)) > + (progn > + (apply #'face-spec-set > + (append (backquote (example-2-face ((t (:foreground "LightGreen"))))) > + '(face-defface-spec))) > + (put 'example-2-face 'face-modified t)) > (require 'example nil nil)))) > > (ert-deftest use-package-test/:custom-face-3 () > (match-expansion > (use-package foo :custom-face (foo ((t (:background "#e4edfc"))) face-defspec-spec)) > `(progn > - (apply #'face-spec-set (backquote (foo ((t (:background "#e4edfc"))) face-defspec-spec))) > + (progn > + (apply #'face-spec-set > + (append (backquote (foo ((t (:background "#e4edfc"))) face-defspec-spec)) > + '(face-defface-spec))) > + (put 'foo 'face-modified t)) > (require 'foo nil nil)))) > > +(ert-deftest use-package-test/:custom-face-4 () > + (defface use-package-test/base-face '((t (:background "green"))) "") > + (defface use-package-test/face '((t (:inherit use-package-test/base-face))) "") > + (use-package emacs > + :custom-face > + (use-package-test/face ((t (:foreground "blue"))))) > + (should (equal (face-foreground 'use-package-test/face nil t) > + "blue")) > + (should (equal (face-background 'use-package-test/face nil t) > + nil)) > + (should (equal (get 'use-package-test/face 'face-modified) > + t))) > + > (ert-deftest use-package-test/:init-1 () > (match-expansion > (use-package foo :init (init)) > -- > 2.49.0 > From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Apr 2025 01:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, Michael Shields Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17455438375857 (code B ref 77928); Fri, 25 Apr 2025 01:18:02 +0000 Received: (at 77928) by debbugs.gnu.org; 25 Apr 2025 01:17:17 +0000 Received: from localhost ([127.0.0.1]:43303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u87gr-0001WP-4p for submit@debbugs.gnu.org; Thu, 24 Apr 2025 21:17:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u87go-0001WC-NZ for 77928@debbugs.gnu.org; Thu, 24 Apr 2025 21:17:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u87gj-0002wK-48; Thu, 24 Apr 2025 21:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Kq1bc5qBTHBa5Qg1QFSiazbkUFTqeVtaURgRAhVnQOs=; b=jrDg8PYBYGF4OxFG0eg5 Dc5VRrwzaJY7g8piZSesRLfuK/pK1XExcrhZ0riBH5SoB1Dl3f2Ysw3cOk+V6nm4VJsb1QratJo04 hFFfged+KCpA0p3qtB8WKkGB/MMvfddZ84bRkZMMtFHgcg618YIwbLWvdLuE8ScRXqnPa2WsNERTH NHt7+lATmD2cY9+eUFic3fBci4ADGEJAMb046q9tTf5+tZoOJSoFnQEvXyMKncrTaH0p0v75yygxD n0BfFQIEqqTZxlCmvJ1W7ydC3qPbUleaP82uGmKsqlR/djwcWbt9B2/9GuhSW2rKRoxpphNBrqBu3 lhMUS49BTjhc3Q==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvhedtleelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddt reejnecuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorh hgqeenucggtffrrghtthgvrhhnpedtgefhheejveffteekkeeuhefggedvhfetgfekudev tdfhudffgfefuedvffekieenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhnvgifrg hrthhishgrnhhsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhohhhnfidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthi dqieekjeektdelgeegqddujeejheefkeduiedqjhhohhhnfieppehgnhhurdhorhhgsehn vgifrghrthhishgrnhhsrdgtohhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmth hpohhuthdprhgtphhtthhopeejjeelvdekseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpthhtohepvghlihiise hgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: <86ldrv747s.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Apr 2025 09:10:47 +0300") References: <86ldrv747s.fsf@gnu.org> Date: Thu, 24 Apr 2025 18:17:06 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: >> The attached patch fixes a bug where migrating a face spec from custom.el >> to use-package :custom-face results in a surprising behavior change: the >> new spec is overlaid on the default value instead of replacing it. This >> seems to have been an unintended consequence of >> https://github.com/jwiegley/use-package/issues/934. > John, any comments? Well, this patch would invalidate the current documentation: (use-package example :custom-face (example-1-face ((t (:foreground "LightPink")))) (example-2-face ((t (:foreground "LightGreen"))) face-defspec-spec)) It will remove the ability to specify a SPEC-TYPE argument in the declarati= on, and instead would force it to always be `face-defface-spec', no? At the mom= ent the default uses `face-override-spec', when no such argument is provided. If face-defface-spec is the desired default behaivor =E2=80=94 while droppi= ng the current ability to customize that behavior in the declaration =E2=80=94 I h= ave no objection, but the Texinfo example will need to be updated as well. --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face Resent-From: Michael Shields Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Apr 2025 02:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley Cc: Eli Zaretskii , 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17455477144454 (code B ref 77928); Fri, 25 Apr 2025 02:22:02 +0000 Received: (at 77928) by debbugs.gnu.org; 25 Apr 2025 02:21:54 +0000 Received: from localhost ([127.0.0.1]:43767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u88hO-00019m-61 for submit@debbugs.gnu.org; Thu, 24 Apr 2025 22:21:54 -0400 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]:55700) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u88hK-00019T-S1 for 77928@debbugs.gnu.org; Thu, 24 Apr 2025 22:21:52 -0400 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-6feab7c5f96so18436497b3.3 for <77928@debbugs.gnu.org>; Thu, 24 Apr 2025 19:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1745547705; x=1746152505; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D6LbqZ+ts4A7TALnxSgAqGLOvZ028zZ9mmREHWKRgzU=; b=MMYDHJ8yhxTaFOwL6uI3IMPBznPCP8jA27tc+oK6jhzbONPTgCKtdRNtDJcYfoHczf /TD0KVSr+8FIjQssJqfqDmcrwlc0xizJ4F6Zty7QCnKWRdRwN5GkL86HkOqus9+z0v5V MGz1xseYZjtCeH8k23pYi99K2buwQEwvPdNnY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745547705; x=1746152505; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D6LbqZ+ts4A7TALnxSgAqGLOvZ028zZ9mmREHWKRgzU=; b=am++SXBfJcg7AMcta2/CAyhHpbAP/+oCYNp8LSPXhGI0XtvH++8xpWxS415VZ66weI Gc/cTxNa1Zs2nLMHcL+hW0z0dMfg2chC36tiyXsz6TBo82vj7bbXgdaqiibjjpHKNoq1 VSyX/+M/kZKz4Ht73cGlcL99v+p43tpHDwWhSS1sp1Xdz3r+kbKLEPlgNHqI3DoKfIjp o6z/KPpRNN7HydkVSEfWUDRxVht5xJwrXh3O6cbIcKVQCwmCwmPSlMi7t+QI6faHPqlj TOCtV3KCLnGmIF+VBDL5cnKozLYdQBg2lSLyQM7fwcjZtwmCY5TogHrz1TEXDMUgZtcc YtQw== X-Forwarded-Encrypted: i=1; AJvYcCWBJptkF/sLQepLm1I9pknbzyxmI+Q1MVEo4ACZvxxBlv+XBAmgFuhKnw3TdRqNHKQMEGfa+A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw2O/6vIK3n07JMIStQkII7q1cxV78CVo7wIZn/MdwOz2zLFguz j9eCZV6OttWiwAAr1hvHh5iPjmWEmsNmkYZu/jSFMEPO7J4NPZ6d51w3BD+vZbb/VCtDjTZUsok JTFB1PmgFAK4i7DWrW7gGo/8JIbGtExK6/sIYk3WoFnfq0whadYcC X-Gm-Gg: ASbGnctenTrqAKNuY15R0wT7wM9zr8BMPY/9jy6Vs0LOyMFDG8wi8rLcMcVg8929Njo NqALaqDHlXFMfAfvgM+NlbJQkmepYh7sGo3UXNq6bWr7cauO6UblObuNiyxIOOQRsxabVEGwjTq dH0EH2c1d+t3JvoTmd4pXFt+pY4x1fBoci5fq6V6t4d72yItSKFITAWIeo X-Google-Smtp-Source: AGHT+IE9QJD8r1t8os1iYvBRkhQAyQ+rJCVBoJyHwfCfl1U+EzIQmYKFcWhPINx3KOjzNLHR5EXkMQOlXEjnXJX5SVg= X-Received: by 2002:a05:690c:67c3:b0:6ef:69b2:eac with SMTP id 00721157ae682-708540dc239mr7082977b3.4.1745547705055; Thu, 24 Apr 2025 19:21:45 -0700 (PDT) MIME-Version: 1.0 References: <86ldrv747s.fsf@gnu.org> In-Reply-To: From: Michael Shields Date: Thu, 24 Apr 2025 19:21:33 -0700 X-Gm-Features: ATxdqUHoN_15VsdLzrxI8MGecQaDEAz9zqKN_7K8xWjc7Rk-R1BFw2S_zTrXMYI Message-ID: Content-Type: multipart/mixed; boundary="000000000000e6a094063390fe4d" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e6a094063390fe4d Content-Type: multipart/alternative; boundary="000000000000e6a092063390fe4b" --000000000000e6a092063390fe4b Content-Type: text/plain; charset="UTF-8" Ok, documentation updated. It looks like the only reason a SPEC-TYPE argument is accepted was that someone else was caught out by the unintended change to partial inheritance: https://github.com/jwiegley/use-package/issues/1008 --000000000000e6a092063390fe4b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, documentation updated.

It looks lik= e the only reason a SPEC-TYPE argument=C2=A0is accepted was that someone el= se was caught out by the unintended change to partial inheritance:
https://g= ithub.com/jwiegley/use-package/issues/1008
--000000000000e6a092063390fe4b-- --000000000000e6a094063390fe4d Content-Type: application/octet-stream; name="0002-Update-documentation.patch" Content-Disposition: attachment; filename="0002-Update-documentation.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9w5y0mw0 RnJvbSBhNzJiMjNlM2EyYjRmNjcyZDVkZWY3N2U3ZWZhN2IzYWFmMmM5ZmY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWVsZHMgPHNoaWVsZHNAbXNybC5jb20+CkRh dGU6IFRodSwgMjQgQXByIDIwMjUgMTk6MTE6NTkgLTA3MDAKU3ViamVjdDogW1BBVENIIDIvMl0g VXBkYXRlIGRvY3VtZW50YXRpb24KCi0tLQogZG9jL21pc2MvdXNlLXBhY2thZ2UudGV4aSB8IDIg Ky0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL2RvYy9taXNjL3VzZS1wYWNrYWdlLnRleGkgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50 ZXhpCmluZGV4IGNkYWU4ZDZlNjYyLi4zNDFiNmRhODdkOSAxMDA2NDQKLS0tIGEvZG9jL21pc2Mv dXNlLXBhY2thZ2UudGV4aQorKysgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCkBAIC0xNDQy LDcgKzE0NDIsNyBAQCBGYWNlcwogKHVzZS1wYWNrYWdlIGV4YW1wbGUKICAgOmN1c3RvbS1mYWNl CiAgIChleGFtcGxlLTEtZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJMaWdodFBpbmsiKSkpKQotICAo ZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRHcmVlbiIpKSkgZmFjZS1kZWZz cGVjLXNwZWMpKQorICAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRHcmVl biIpKSkpKQogQGVuZCBncm91cAogCiBAZ3JvdXAKLS0gCjIuNDkuMAoK --000000000000e6a094063390fe4d-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Apr 2025 12:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields , John Wiegley Cc: 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17456719743920 (code B ref 77928); Sat, 26 Apr 2025 12:53:02 +0000 Received: (at 77928) by debbugs.gnu.org; 26 Apr 2025 12:52:54 +0000 Received: from localhost ([127.0.0.1]:59270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8f1Z-00011A-I9 for submit@debbugs.gnu.org; Sat, 26 Apr 2025 08:52:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36560) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8f1W-00010p-JM for 77928@debbugs.gnu.org; Sat, 26 Apr 2025 08:52:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8f1Q-0000s0-84; Sat, 26 Apr 2025 08:52:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=C50BKK4Llk9qGXp6nvzHBP0V8EK0Ncohjmj3wAJxobY=; b=DNZZJQEGyfqO jvolO+Mra6kkHr9wOyibPoYX9xANLH6+CUrcbzyXg8Lj40InbzvchzZveUpa21Rf6W+my1zYhBL/R QhgsPcJv/5GHx7eZAdXB/tJIHZFTUIIRg70V6Q13dxBZu4zM8KzPJhimh/Zd4tYj2UWJxAg8nRxVG aS/N8EGQ4M0btClvDLnViVTrwwjOdt3wVKr/yVJkJh8yN967k6xISJbSAnV23QuWboDJA3nW/1+7B 8n9yCbs6Quj73wKuoKsQVLvyZRVzhw/+qdBV8Fm3baXvGzHiJplUmcnG+r6ns9x8xcq2ajWDx0avl dywS6O94fZ8Ek/ijnOIh1w==; Date: Sat, 26 Apr 2025 15:52:32 +0300 Message-Id: <86tt6bt78v.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Michael Shields on Sat, 19 Apr 2025 13:41:01 -0700) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Shields > Date: Sat, 19 Apr 2025 13:41:01 -0700 > > The attached patch fixes a bug where migrating a face spec from custom.el to use-package :custom-face > results in a surprising behavior change: the new spec is overlaid on the default value instead of replacing it. > This seems to have been an unintended consequence of > https://github.com/jwiegley/use-package/issues/934. Thanks. I wanted to install this, but it causes failures in the tests: the 3 that you amended and the new 4th one, see the details below. Could you please fix that? Also, please include the followup change for the documentation in the next patch submittal, and also please observe our conventions for log messages. In particular, too long lines there are rejected by our git-commit-hooks. Please also mention the bug number in the commit log message. Here are the errors from the tests: Test use-package-test/:custom-face-1 backtrace: signal(ert-test-failed (((should (pcase (expand-minimally (use-packa ert-fail(((should (pcase (expand-minimally (use-package foo :custom- (if (unwind-protect (setq value-665 (let* ((val (let (... ...) (macr (let (form-description-666) (if (unwind-protect (setq value-665 (let (let ((value-665 (gensym "ert-form-evaluation-aborted-"))) (let (for #f(lambda () [t] (let ((value-665 (gensym "ert-form-evaluation-abort #f(compiled-function () #)() handler-bind-1(#f(compiled-function () #)() handler-bind-1(#f(compiled-function () #)() handler-bind-1(#f(compiled-function () #)() handler-bind-1(#f(compiled-function () # Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Apr 2025 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, John Wiegley Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174569976228317 (code B ref 77928); Sat, 26 Apr 2025 20:37:02 +0000 Received: (at 77928) by debbugs.gnu.org; 26 Apr 2025 20:36:02 +0000 Received: from localhost ([127.0.0.1]:35476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8mFm-0007Ma-6f for submit@debbugs.gnu.org; Sat, 26 Apr 2025 16:36:02 -0400 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:44314) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8mFj-0007M2-Ft for 77928@debbugs.gnu.org; Sat, 26 Apr 2025 16:36:00 -0400 Received: by mail-yb1-xb30.google.com with SMTP id 3f1490d57ef6-e53a91756e5so3120435276.1 for <77928@debbugs.gnu.org>; Sat, 26 Apr 2025 13:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1745699754; x=1746304554; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qEIaLe6Id305tKyGs2mwe68OxEerAPvRYupty5K++Rs=; b=LrTXlF3dxIR41jdV/UB7a7/ESi9UxrV5oadfUD2NSwa+9pKd+e/HjU98mwVChOW1mK ukwd3n+DWuXT1VaY1FJfQfliu0GWAa/+FnQHOguSQIlg0HS/Rs7NudAdC9079cFxKPwX IHgniayTOGfZwHuccmb4d0ieoFcuE+qOWkMcc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745699754; x=1746304554; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qEIaLe6Id305tKyGs2mwe68OxEerAPvRYupty5K++Rs=; b=wFwRh5GPczHDo+aAL5Xl16oq0PXbpema4xfTRtQWnMSb8IxxX/Mmn8pTmVonIQPVFu LtY2r7JozELU0PrdhY54v88pTpNhVbaOGmisxtf0d5jet8EAtllCiOqvLFRYkI5sQoPa ODjn1Bsu7q0Ua/n3L9NrhCBweXFTGFSBwFjIt7ea7Zw1DzWfxbpcXaWANnVJGXj9vmMX 6ssJB2bkQhmARy+jgn5G1ua4ZkgtjCgeCfgfnN2fuga6CGY+Uxtt3imxjksy8RLZe1Q0 3C5oEQ6RKPfpy5IO/3uzhZ0ACgUIxG760Hg1oYVpO5NrMpcSUYhJ3C+oAYGV573lI8Fi GHOg== X-Forwarded-Encrypted: i=1; AJvYcCV8VFqaPGcQz0o0GW1go6QueyMc74v0wa8nKaAzHiMbNx+/St9C5IcJn16daXgKOGwqLXPOJQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwoMx8HR5jWz8aTUPgwg740juANA2wVPZTrFiTjkJsyKDFeliJA 2+fxc6pApt92Ei+dRxJVTNXjYmBAZ+3RX4CbtdldM9D+toY52HbomI7D0/FxBaM6ewelPCEx+MY K0ljatn0oef+zqsXbRc7x6JlJN6lTt6qMhbGC X-Gm-Gg: ASbGncsdKBxhh3iKLJ40iDhURR34yHOnNxy2dKYxC1Vf2l/RHUzCJHlyzZEzCb1jZWz PO7bqqXWR2nA50WW1WLWrfCWctV8Vih3DCe1g/cw5o03Wqbh2YU8fbE1y56RqyVek/SbwrfnXY7 purZaRSLVS5aR2AwRN0tg13ClzW6yRr/89L0vHaeErveEM1r7V9c5+H0Bu X-Google-Smtp-Source: AGHT+IHlpxd6g99x26gtiEax/MFwo41dT3kTUoV4E8InlXBsgaEIRhUVSUey7YmypjBu+s7QP1jT6YJ34aO6wmsvpv4= X-Received: by 2002:a05:6902:4401:b0:e72:a1b8:3b0d with SMTP id 3f1490d57ef6-e7316b73606mr7853488276.37.1745699753617; Sat, 26 Apr 2025 13:35:53 -0700 (PDT) MIME-Version: 1.0 References: <86tt6bt78v.fsf@gnu.org> In-Reply-To: <86tt6bt78v.fsf@gnu.org> From: Michael Shields Date: Sat, 26 Apr 2025 13:35:42 -0700 X-Gm-Features: ATxdqUGFCM7RaUJKb9JlmaevLTOeEGEkgJgveVJGsXsFeTVx-eKcACis0v1kTDE Message-ID: Content-Type: multipart/mixed; boundary="000000000000b399590633b4654f" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b399590633b4654f Content-Type: multipart/alternative; boundary="000000000000b399560633b4654d" --000000000000b399560633b4654d Content-Type: text/plain; charset="UTF-8" Attached is a combined patch with an updated commit message. I cannot reproduce those test failures. I see 167/167 tests pass when I run `make -C test check-lisp-use-package'. I'm testing commit be4819b, plus the attached patch, on macOS 15.4.1. --000000000000b399560633b4654d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Attached is a combined patch with an updated commit messag= e.

I cannot reproduce those test failures. I see 167/167= tests pass when I run `make -C test check-lisp-use-package'. I'm t= esting commit be4819b, plus the attached patch, on macOS 15.4.1.
--000000000000b399560633b4654d-- --000000000000b399590633b4654f Content-Type: application/octet-stream; name="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Disposition: attachment; filename="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9yoiygt0 RnJvbSA2MzZkZmQ1NzFhYzQ1MDUxNTRmZTRjM2U5NjE5N2RjYjBkN2E2NzZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWVsZHMgPHNoaWVsZHNAbXNybC5jb20+CkRh dGU6IFNhdCwgMTkgQXByIDIwMjUgMTI6NTg6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXgg dXNlLXBhY2thZ2UgOmN1c3RvbS1mYWNlIHRvIHNldCBmYWNlLWRlZmZhY2Utc3BlYwogKGJ1ZyM3 NzkyOCkKCkJ5IGRlZmF1bHQsIGBmYWNlLXNldC1zcGVjJyBzZXRzIHRoZSBvdmVycmlkZSBmYWNl IHNwZWMsIHNvIGZhY2UKYXR0cmlidXRlcyBhcmUgY29tYmluZWQgd2l0aCBkZWZhdWx0cyByYXRo ZXIgdGhhbiByZXBsYWNpbmcgdGhlbS4KVGhpcyB3YXMgYSBiZWhhdmlvciBjaGFuZ2UgdGhhdCB3 YXMgYW4gYXBwYXJlbnRseSB1bmludGVuZGVkCmNvbnNlcXVlbmNlIG9mIGNvbW1pdCA2YjM0NGE5 LgoKQWxzbyBzZXQgdGhlIGBmYWNlLW1vZGlmaWVkJyBwcm9wZXJ0eSwgd2hpY2ggY2F1c2VzIEN1 c3RvbWl6ZSB0bwpmbGFnIHRoZSBmYWNlIGFzIGNoYW5nZWQgb3V0c2lkZSBDdXN0b21pemUuCgoq IGRvYy9taXNjL3VzZS1wYWNrYWdlLnRleGkgKEZhY2VzKTogRG9jdW1lbnQgdGhlIGJlaGF2aW9y LgoqIGxpc3AvdXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtY29yZS5lbCAodXNlLXBhY2thZ2UtaGFu ZGxlci86Y3VzdG9tLWZhY2UpOgoodXNlLXBhY2thZ2UpOiBJbXByb3ZlIGRvY3N0cmluZyB0byBy ZWZsZWN0IGltcGxlbWVudGF0aW9uLgoqIHRlc3QvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2Fn ZS10ZXN0cy5lbAoodXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtMSk6ICh1c2UtcGFja2Fn ZS10ZXN0LzpjdXN0b20tZmFjZS0yKToKKHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTMp OiAodXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtNCk6CkFkZCB0ZXN0cy4KLS0tCiBkb2Mv bWlzYy91c2UtcGFja2FnZS50ZXhpICAgICAgICAgICAgICAgICAgfCAgNyArKystCiBsaXNwL3Vz ZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwgICAgICAgfCAgOCArKystLQogdGVzdC9saXNw L3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsIHwgNDAgKysrKysrKysrKysrKysrKysr LS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL2RvYy9taXNjL3VzZS1wYWNrYWdlLnRleGkgYi9kb2MvbWlzYy91c2UtcGFj a2FnZS50ZXhpCmluZGV4IGMxNGU3Yjc3ZDIzLi4zNDFiNmRhODdkOSAxMDA2NDQKLS0tIGEvZG9j L21pc2MvdXNlLXBhY2thZ2UudGV4aQorKysgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCkBA IC0xNDQyLDcgKzE0NDIsNyBAQCBGYWNlcwogKHVzZS1wYWNrYWdlIGV4YW1wbGUKICAgOmN1c3Rv bS1mYWNlCiAgIChleGFtcGxlLTEtZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJMaWdodFBpbmsiKSkp KQotICAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRHcmVlbiIpKSkgZmFj ZS1kZWZzcGVjLXNwZWMpKQorICAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGln aHRHcmVlbiIpKSkpKQogQGVuZCBncm91cAogCiBAZ3JvdXAKQEAgLTE0NTcsNiArMTQ1NywxMSBA QCBGYWNlcwogQGVuZCBncm91cAogQGVuZCBsaXNwCiAKK1NpbWlsYXJseSB0byBAY29kZXs6Y3Vz dG9tfSAoQHB4cmVme1VzZXIgb3B0aW9uc30pLCB0aGlzIGFsbG93cworY29uZmlndXJpbmcgY3Vz dG9taXphYmxlIGZhY2VzIG91dHNpZGUgb2YgQ3VzdG9taXplIChAcHhyZWZ7U2F2aW5nCitDdXN0 b21pemF0aW9ucywsLCBlbWFjcywgR05VIEVtYWNzIE1hbnVhbH0pLiAgVXNpbmcgYm90aCBzeXN0 ZW1zIHRvCitjb25maWd1cmUgdGhlIHNhbWUgZmFjZSBjYW4gbGVhZCB0byBjb25mdXNpbmcgcmVz dWx0cy4KKwogQG5vZGUgSGlkaW5nIG1pbm9yIG1vZGVzCiBAc2VjdGlvbiBIaWRpbmcgbWlub3Ig bW9kZXMgd2l0aCBkaW1pbmlzaCBhbmQgZGVsaWdodAogQGNpbmRleCBoaWRpbmcgbWlub3IgbW9k ZXMKZGlmZiAtLWdpdCBhL2xpc3AvdXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtY29yZS5lbCBiL2xp c3AvdXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtY29yZS5lbAppbmRleCBjMDQwNTNjMjJhYy4uNGI2 M2Q5ODU2MDQgMTAwNjQ0Ci0tLSBhL2xpc3AvdXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtY29yZS5l bAorKysgYi9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwKQEAgLTE1ODQsNyAr MTU4NCwxMSBAQCB1c2UtcGFja2FnZS1ub3JtYWxpemUvOmN1c3RvbS1mYWNlCiAoZGVmdW4gdXNl LXBhY2thZ2UtaGFuZGxlci86Y3VzdG9tLWZhY2UgKG5hbWUgX2tleXdvcmQgYXJncyByZXN0IHN0 YXRlKQogICAiR2VuZXJhdGUgdXNlLXBhY2thZ2UgY3VzdG9tLWZhY2Uga2V5d29yZCBjb2RlLiIK ICAgKHVzZS1wYWNrYWdlLWNvbmNhdAotICAgKG1hcGNhciAjJyhsYW1iZGEgKGRlZikgYChhcHBs eSAjJ2ZhY2Utc3BlYy1zZXQgKGJhY2txdW90ZSAsZGVmKSkpIGFyZ3MpCisgICAobWFwY2FyICMn KGxhbWJkYSAoZGVmKQorICAgICAgICAgICAgICAgYChwcm9nbgorICAgICAgICAgICAgICAgICAg KGFwcGx5ICMnZmFjZS1zcGVjLXNldCAoYXBwZW5kIChiYWNrcXVvdGUgLGRlZikgJyhmYWNlLWRl ZmZhY2Utc3BlYykpKQorICAgICAgICAgICAgICAgICAgKHB1dCAnLChjYXIgZGVmKSAnZmFjZS1t b2RpZmllZCB0KSkpCisgICAgICAgICAgIGFyZ3MpCiAgICAodXNlLXBhY2thZ2UtcHJvY2Vzcy1r ZXl3b3JkcyBuYW1lIHJlc3Qgc3RhdGUpKSkKIAogOzs7OyA6aW5pdApAQCAtMTg0OCw3ICsxODUy LDcgQEAgdXNlLXBhY2thZ2UKIDpjdXN0b20gICAgICAgICAgQ2FsbCBgQ3VzdG9tLXNldCcgb3Ig YHNldC1kZWZhdWx0JyB3aXRoIGVhY2ggdmFyaWFibGUKICAgICAgICAgICAgICAgICAgZGVmaW5p dGlvbiB3aXRob3V0IG1vZGlmeWluZyB0aGUgRW1hY3MgYGN1c3RvbS1maWxlJy4KICAgICAgICAg ICAgICAgICAgKGNvbXBhcmUgd2l0aCBgY3VzdG9tLXNldC12YXJpYWJsZXMnKS4KLTpjdXN0b20t ZmFjZSAgICAgQ2FsbCBgY3VzdG9tLXNldC1mYWNlcycgd2l0aCBlYWNoIGZhY2UgZGVmaW5pdGlv bi4KKzpjdXN0b20tZmFjZSAgICAgQ2FsbCBgZmFjZS1zcGVjLXNldCcgd2l0aCBlYWNoIGZhY2Ug ZGVmaW5pdGlvbi4KIDplbnN1cmUgICAgICAgICAgTG9hZHMgdGhlIHBhY2thZ2UgdXNpbmcgcGFj a2FnZS5lbCBpZiBuZWNlc3NhcnkuCiA6cGluICAgICAgICAgICAgIFBpbiB0aGUgcGFja2FnZSB0 byBhbiBhcmNoaXZlLgogOnZjICAgICAgICAgICAgICBJbnN0YWxsIHRoZSBwYWNrYWdlIGRpcmVj dGx5IGZyb20gYSB2ZXJzaW9uIGNvbnRyb2wgc3lzdGVtCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Av dXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtdGVzdHMuZWwgYi90ZXN0L2xpc3AvdXNlLXBhY2thZ2Uv dXNlLXBhY2thZ2UtdGVzdHMuZWwKaW5kZXggODU1NGIzN2Q1YjguLmIyMjFjNWRlNWMxIDEwMDY0 NAotLS0gYS90ZXN0L2xpc3AvdXNlLXBhY2thZ2UvdXNlLXBhY2thZ2UtdGVzdHMuZWwKKysrIGIv dGVzdC9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsCkBAIC0xMTUzLDcgKzEx NTMsMTIgQEAgdXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtMQogICAobWF0Y2gtZXhwYW5z aW9uCiAgICAodXNlLXBhY2thZ2UgZm9vIDpjdXN0b20tZmFjZSAoZm9vICgodCAoOmJhY2tncm91 bmQgIiNlNGVkZmMiKSkpKSkKICAgIGAocHJvZ24KLSAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1z ZXQgKGJhY2txdW90ZSAoZm9vICgodCAoOmJhY2tncm91bmQgIiNlNGVkZmMiKSkpKSkpCisgICAg ICAocHJvZ24KKyAgICAgICAgKGFwcGx5ICMnZmFjZS1zcGVjLXNldAorICAgICAgICAgICAgICAg KGFwcGVuZCAoYmFja3F1b3RlIChmb28gKCh0ICg6YmFja2dyb3VuZCAiI2U0ZWRmYyIpKSkpKQor ICAgICAgICAgICAgICAgICAgICAgICAnKGZhY2UtZGVmZmFjZS1zcGVjKSkKKyAgICAgICAgICAg ICAgICkKKyAgICAgICAgKHB1dCAnZm9vICdmYWNlLW1vZGlmaWVkIHQpKQogICAgICAgKHJlcXVp cmUgJ2ZvbyBuaWwgbmlsKSkpKQogCiAoZXJ0LWRlZnRlc3QgdXNlLXBhY2thZ2UtdGVzdC86Y3Vz dG9tLWZhY2UtMiAoKQpAQCAtMTE2MywxOSArMTE2OCw0MiBAQCB1c2UtcGFja2FnZS10ZXN0Lzpj dXN0b20tZmFjZS0yCiAgICAgIChleGFtcGxlLTEtZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJMaWdo dFBpbmsiKSkpKQogICAgICAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRH cmVlbiIpKSkpKQogICAgYChwcm9nbgotICAgICAgKGFwcGx5ICMnZmFjZS1zcGVjLXNldAotICAg ICAgICAgICAgIChiYWNrcXVvdGUgKGV4YW1wbGUtMS1mYWNlICgodCAoOmZvcmVncm91bmQgIkxp Z2h0UGluayIpKSkpKSkKLSAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKLSAgICAgICAgICAg ICAoYmFja3F1b3RlIChleGFtcGxlLTItZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJMaWdodEdyZWVu IikpKSkpKQorICAgICAgKHByb2duCisgICAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKKyAg ICAgICAgICAgICAgIChhcHBlbmQgKGJhY2txdW90ZSAoZXhhbXBsZS0xLWZhY2UgKCh0ICg6Zm9y ZWdyb3VuZCAiTGlnaHRQaW5rIikpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICcoZmFjZS1k ZWZmYWNlLXNwZWMpKSkKKyAgICAgICAgKHB1dCAnZXhhbXBsZS0xLWZhY2UgJ2ZhY2UtbW9kaWZp ZWQgdCkpCisgICAgICAocHJvZ24KKyAgICAgICAgKGFwcGx5ICMnZmFjZS1zcGVjLXNldAorICAg ICAgICAgICAgICAgKGFwcGVuZCAoYmFja3F1b3RlIChleGFtcGxlLTItZmFjZSAoKHQgKDpmb3Jl Z3JvdW5kICJMaWdodEdyZWVuIikpKSkpCisgICAgICAgICAgICAgICAgICAgICAgICcoZmFjZS1k ZWZmYWNlLXNwZWMpKSkKKyAgICAgICAgKHB1dCAnZXhhbXBsZS0yLWZhY2UgJ2ZhY2UtbW9kaWZp ZWQgdCkpCiAgICAgICAocmVxdWlyZSAnZXhhbXBsZSBuaWwgbmlsKSkpKQogCiAoZXJ0LWRlZnRl c3QgdXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtMyAoKQogICAobWF0Y2gtZXhwYW5zaW9u CiAgICAodXNlLXBhY2thZ2UgZm9vIDpjdXN0b20tZmFjZSAoZm9vICgodCAoOmJhY2tncm91bmQg IiNlNGVkZmMiKSkpIGZhY2UtZGVmc3BlYy1zcGVjKSkKICAgIGAocHJvZ24KLSAgICAgIChhcHBs eSAjJ2ZhY2Utc3BlYy1zZXQgKGJhY2txdW90ZSAoZm9vICgodCAoOmJhY2tncm91bmQgIiNlNGVk ZmMiKSkpIGZhY2UtZGVmc3BlYy1zcGVjKSkpCisgICAgICAocHJvZ24KKyAgICAgICAgKGFwcGx5 ICMnZmFjZS1zcGVjLXNldAorICAgICAgICAgICAgICAgKGFwcGVuZCAoYmFja3F1b3RlIChmb28g KCh0ICg6YmFja2dyb3VuZCAiI2U0ZWRmYyIpKSkgZmFjZS1kZWZzcGVjLXNwZWMpKQorICAgICAg ICAgICAgICAgICAgICAgICAnKGZhY2UtZGVmZmFjZS1zcGVjKSkpCisgICAgICAgIChwdXQgJ2Zv byAnZmFjZS1tb2RpZmllZCB0KSkKICAgICAgIChyZXF1aXJlICdmb28gbmlsIG5pbCkpKSkKIAor KGVydC1kZWZ0ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTQgKCkKKyAgKGRlZmZh Y2UgdXNlLXBhY2thZ2UtdGVzdC9iYXNlLWZhY2UgJygodCAoOmJhY2tncm91bmQgImdyZWVuIikp KSAiIikKKyAgKGRlZmZhY2UgdXNlLXBhY2thZ2UtdGVzdC9mYWNlICcoKHQgKDppbmhlcml0IHVz ZS1wYWNrYWdlLXRlc3QvYmFzZS1mYWNlKSkpICIiKQorICAodXNlLXBhY2thZ2UgZW1hY3MKKyAg ICA6Y3VzdG9tLWZhY2UKKyAgICAodXNlLXBhY2thZ2UtdGVzdC9mYWNlICgodCAoOmZvcmVncm91 bmQgImJsdWUiKSkpKSkKKyAgKHNob3VsZCAoZXF1YWwgKGZhY2UtZm9yZWdyb3VuZCAndXNlLXBh Y2thZ2UtdGVzdC9mYWNlIG5pbCB0KQorICAgICAgICAgICAgICAgICAiYmx1ZSIpKQorICAoc2hv dWxkIChlcXVhbCAoZmFjZS1iYWNrZ3JvdW5kICd1c2UtcGFja2FnZS10ZXN0L2ZhY2UgbmlsIHQp CisgICAgICAgICAgICAgICAgIG5pbCkpCisgIChzaG91bGQgKGVxdWFsIChnZXQgJ3VzZS1wYWNr YWdlLXRlc3QvZmFjZSAnZmFjZS1tb2RpZmllZCkKKyAgICAgICAgICAgICAgICAgdCkpKQorCiAo ZXJ0LWRlZnRlc3QgdXNlLXBhY2thZ2UtdGVzdC86aW5pdC0xICgpCiAgIChtYXRjaC1leHBhbnNp b24KICAgICh1c2UtcGFja2FnZSBmb28gOmluaXQgKGluaXQpKQotLSAKMi40OS4wCgo= --000000000000b399590633b4654f-- From unknown Mon Aug 18 06:57:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Michael Shields Subject: bug#77928: closed (Re: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face) Message-ID: References: <8634durqjp.fsf@gnu.org> X-Gnu-PR-Message: they-closed 77928 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 77928@debbugs.gnu.org Date: Sun, 27 Apr 2025 07:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1745740322-22723-1" This is a multi-part message in MIME format... ------------=_1745740322-22723-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77928: [PATCH] use-package :custom-face is meant to behave like custom-set= -face which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77928@debbugs.gnu.org. --=20 77928: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77928 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745740322-22723-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77928-done) by debbugs.gnu.org; 27 Apr 2025 07:51:10 +0000 Received: from localhost ([127.0.0.1]:38671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8wn6-0005ok-3D for submit@debbugs.gnu.org; Sun, 27 Apr 2025 03:51:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55728) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8wmw-0005mT-JC for 77928-done@debbugs.gnu.org; Sun, 27 Apr 2025 03:51:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8wmq-0003IR-Ig; Sun, 27 Apr 2025 03:50:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pfyx77tDVd0qrYVsMMk9nLIP95PUKmhGRCV9SLUPM14=; b=I+El+i23fjXv b2B1E+X1SMuBaKtooQG4564tlg1krZbSHHmja6yKsZjtnBrDKONOecFxlwJ05WP98pTFOaMiJuOsS Vw2YEWWMh5ctMNFAVcbct+42ISTBy/r1NEvWUOhzFaEyoO1UJBVZalIV7lFTN7LEjIqZeczdEQWGl cbaGnE5SwcooLF4UVhujIT9BlGaBVMaMTEEnWWWk2obvLWNnuu17KBWqUOvC6ugD/kqHutRbghFN3 5nD2D9g7JmaxMu8qJ0r9BkNcZ82MSsyhlo0aFYSxgMIGf5JYnPk2ieRwmpVDTmc4P3mHLiKaK8ey4 GLmlRKsRtdyH1VYqkCYlfA==; Date: Sun, 27 Apr 2025 10:50:50 +0300 Message-Id: <8634durqjp.fsf@gnu.org> From: Eli Zaretskii To: Michael Shields In-Reply-To: (message from Michael Shields on Sat, 26 Apr 2025 13:35:42 -0700) Subject: Re: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face References: <86tt6bt78v.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77928-done Cc: 77928-done@debbugs.gnu.org, johnw@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Shields > Date: Sat, 26 Apr 2025 13:35:42 -0700 > Cc: John Wiegley , 77928@debbugs.gnu.org > > Attached is a combined patch with an updated commit message. > > I cannot reproduce those test failures. I see 167/167 tests pass when I run `make -C test > check-lisp-use-package'. I'm testing commit be4819b, plus the attached patch, on macOS 15.4.1. Thanks, installed on the master branch, and closing the bug. ------------=_1745740322-22723-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Apr 2025 20:41:28 +0000 Received: from localhost ([127.0.0.1]:38479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6F0A-0005GV-34 for submit@debbugs.gnu.org; Sat, 19 Apr 2025 16:41:27 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53080) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6F06-0005FG-Oo for submit@debbugs.gnu.org; Sat, 19 Apr 2025 16:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6F00-0008Sr-FX for bug-gnu-emacs@gnu.org; Sat, 19 Apr 2025 16:41:16 -0400 Received: from mail-yb1-xb32.google.com ([2607:f8b0:4864:20::b32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u6Ezy-0003sF-Ms for bug-gnu-emacs@gnu.org; Sat, 19 Apr 2025 16:41:16 -0400 Received: by mail-yb1-xb32.google.com with SMTP id 3f1490d57ef6-e589c258663so2352301276.1 for ; Sat, 19 Apr 2025 13:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1745095272; x=1745700072; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=CZ8T0EIOa2QrXylL6G7C7KEFgk6IMWnam6Tnf8dHgi4=; b=NqoEJw3IIVMgvyMeQEIfHhl+SJanfuDDDXX9wdWfkS2fZ8eboGxhNoUgjgm5nCtDsp INlGBxDBZmrD2VuOY7IOv5O+i3ol6Ai2CIExSYu4OxM9dkHPvCs9Q/QDgpqc010W8PiC 4bDnkbjbS5bsEboBcbNHRTPLRWI6Yhn5ISCSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745095272; x=1745700072; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CZ8T0EIOa2QrXylL6G7C7KEFgk6IMWnam6Tnf8dHgi4=; b=xDQz1daKG16Ce4usxJeTKGuxK22p2DbMXYnNTNiF+0VCEN23KpPox4xHMpYhgVz6pS aamtC13oddX7HSmaajop4q4B4esCFcWcRA/SlN/J/NtMJ2TPx5hnsNJTEe9AUWmZGC4P fp1qMCjoUS7qSjqcJ6V8Bz9d4aYBokQkFXqOaNU+lR+gj7Uug3NamKGttH4HNPWqbtZp BSB0sTEDedg+kTCvOtsyAls7Eu8H/LtJPgH3v14jTQF9Sb0lA8Y7GPk2akVD6VaVNyM4 ncmqlwgkfezCOUPLv39uuAqAyb8aRBgd7Z2hn5ivFJoemAGAt1e6GaKrspTN9NGRl+Xn oeRQ== X-Gm-Message-State: AOJu0YwZUCDjoJyargAylJ1co1cymOi8lxjSUAJjDWZa5lw+YRgi3hMd 8+Plr3ybwaL9DKvNm5AuViu3ZuIXDaTS23PZvroMxzaHJVJZNtSRNqFftv5c4KDZ5j9Sfk1pnpv /IFuUeK+hQAFa7DWTvWNgNSvolzlDxHMzC0SF1Ce/9QOgtLZXkdM2 X-Gm-Gg: ASbGnctoNyrI1k0X2m6p1DOqx1Z3nBw+/wZgfh6I1GpNPLIgsaXC0tD89+xMEjnEJwG GBJQurXpSvDQStCTFDEhntOFzy8iPhCq2EsbAE73cAWbss431VTA5O5D0nAm+SsPwHXpfgNxdVx MmBaHOg+dvORFVwkSEQ5sQI5j7/ka0m1QMSarTXeOvv/mX10+PLBtUGyoe X-Google-Smtp-Source: AGHT+IGXoq3zP+nkr610GawSgLthEAAPjL4lHfKOnRxVxxdiY2rgrt1O9XelkfXg50LEHMS3AAydTOwX1s41hHErQz0= X-Received: by 2002:a05:6902:e8b:b0:e72:81e5:1ea with SMTP id 3f1490d57ef6-e7297ee525bmr9571914276.41.1745095272214; Sat, 19 Apr 2025 13:41:12 -0700 (PDT) MIME-Version: 1.0 From: Michael Shields Date: Sat, 19 Apr 2025 13:41:01 -0700 X-Gm-Features: ATxdqUGMEs_Hqzp4eHTx-Tp2yp9csKGPaw871S9iJoDaN9KWRLga0nljtDHJN9g Message-ID: Subject: [PATCH] use-package :custom-face is meant to behave like custom-set-face To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000cd024b063327a735" Received-SPF: pass client-ip=2607:f8b0:4864:20::b32; envelope-from=shields@msrl.com; helo=mail-yb1-xb32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --000000000000cd024b063327a735 Content-Type: multipart/alternative; boundary="000000000000cd024a063327a733" --000000000000cd024a063327a733 Content-Type: text/plain; charset="UTF-8" The attached patch fixes a bug where migrating a face spec from custom.el to use-package :custom-face results in a surprising behavior change: the new spec is overlaid on the default value instead of replacing it. This seems to have been an unintended consequence of https://github.com/jwiegley/use-package/issues/934. --000000000000cd024a063327a733 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The attached patch fixes a bug where migrating a face spec= from custom.el to use-package :custom-face results in a surprising=C2=A0be= havior change: the new spec is overlaid on the default value instead of rep= lacing it. This seems to have been an unintended consequence of=C2=A0https://github.com= /jwiegley/use-package/issues/934.
--000000000000cd024a063327a733-- --000000000000cd024b063327a735 Content-Type: application/octet-stream; name="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Disposition: attachment; filename="0001-Fix-use-package-custom-face-to-set-face-defface-spec.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9ooamej0 RnJvbSA3NDhlNjIwZmUyZDI4NmE4NTNmNDAzMGJiYTE2Yzk5NDcwMzg3YTFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIFNoaWVsZHMgPHNoaWVsZHNAbXNybC5jb20+CkRh dGU6IFNhdCwgMTkgQXByIDIwMjUgMTI6NTg6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXgg dXNlLXBhY2thZ2UgOmN1c3RvbS1mYWNlIHRvIHNldCBmYWNlLWRlZmZhY2Utc3BlYwoKQnkgZGVm YXVsdCwgYGZhY2Utc2V0LXNwZWMnIHNldHMgdGhlIG92ZXJyaWRlIGZhY2Ugc3BlYywgc28gdGhl IHN1cHBsaWVkCmZhY2UgYXR0cmlidXRlcyBhcmUgY29tYmluZWQgd2l0aCB0aGUgZGVmYXVsdCwg cmF0aGVyIHRoYW4gcmVwbGFjaW5nCnRoZW0uICBUaGlzIHdhcyBhIGJlaGF2aW9yIGNoYW5nZSB0 aGF0IHdhcyBhbiBhcHBhcmVudGx5IHVuaW50ZW5kZWQKY29uc2VxdWVuY2Ugb2YgY29tbWl0IDZi MzQ0YTkuCgpBbHNvIHNldCB0aGUgYGZhY2UtbW9kaWZpZWQnIHByb3BlcnR5LCB3aGljaCBjYXVz ZXMgQ3VzdG9taXplIHRvIGZsYWcKdGhlIGZhY2UgYXMgY2hhbmdlZCBvdXRzaWRlIEN1c3RvbWl6 ZS4KCiogZG9jL21pc2MvdXNlLXBhY2thZ2UudGV4aSAoRmFjZXMpOgoqIGxpc3AvdXNlLXBhY2th Z2UvdXNlLXBhY2thZ2UtY29yZS5lbCAodXNlLXBhY2thZ2UtaGFuZGxlci86Y3VzdG9tLWZhY2Up OgoodXNlLXBhY2thZ2UpOgoqIHRlc3QvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS10ZXN0 cy5lbCAodXNlLXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtMSk6Cih1c2UtcGFja2FnZS10ZXN0 LzpjdXN0b20tZmFjZS0yKToKKHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTMpOgoodXNl LXBhY2thZ2UtdGVzdC86Y3VzdG9tLWZhY2UtNCk6Ci0tLQogZG9jL21pc2MvdXNlLXBhY2thZ2Uu dGV4aSAgICAgICAgICAgICAgICAgIHwgIDUgKysrCiBsaXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNr YWdlLWNvcmUuZWwgICAgICAgfCAgOCArKystLQogdGVzdC9saXNwL3VzZS1wYWNrYWdlL3VzZS1w YWNrYWdlLXRlc3RzLmVsIHwgNDAgKysrKysrKysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFu Z2VkLCA0NSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9t aXNjL3VzZS1wYWNrYWdlLnRleGkgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCmluZGV4IGMx NGU3Yjc3ZDIzLi5jZGFlOGQ2ZTY2MiAxMDA2NDQKLS0tIGEvZG9jL21pc2MvdXNlLXBhY2thZ2Uu dGV4aQorKysgYi9kb2MvbWlzYy91c2UtcGFja2FnZS50ZXhpCkBAIC0xNDU3LDYgKzE0NTcsMTEg QEAgRmFjZXMKIEBlbmQgZ3JvdXAKIEBlbmQgbGlzcAogCitTaW1pbGFybHkgdG8gQGNvZGV7OmN1 c3RvbX0gKEBweHJlZntVc2VyIG9wdGlvbnN9KSwgdGhpcyBhbGxvd3MKK2NvbmZpZ3VyaW5nIGN1 c3RvbWl6YWJsZSBmYWNlcyBvdXRzaWRlIG9mIEN1c3RvbWl6ZSAoQHB4cmVme1NhdmluZworQ3Vz dG9taXphdGlvbnMsLCwgZW1hY3MsIEdOVSBFbWFjcyBNYW51YWx9KS4gIFVzaW5nIGJvdGggc3lz dGVtcyB0bworY29uZmlndXJlIHRoZSBzYW1lIGZhY2UgY2FuIGxlYWQgdG8gY29uZnVzaW5nIHJl c3VsdHMuCisKIEBub2RlIEhpZGluZyBtaW5vciBtb2RlcwogQHNlY3Rpb24gSGlkaW5nIG1pbm9y IG1vZGVzIHdpdGggZGltaW5pc2ggYW5kIGRlbGlnaHQKIEBjaW5kZXggaGlkaW5nIG1pbm9yIG1v ZGVzCmRpZmYgLS1naXQgYS9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwgYi9s aXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUuZWwKaW5kZXggYzA0MDUzYzIyYWMuLjRi NjNkOTg1NjA0IDEwMDY0NAotLS0gYS9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLWNvcmUu ZWwKKysrIGIvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS1jb3JlLmVsCkBAIC0xNTg0LDcg KzE1ODQsMTEgQEAgdXNlLXBhY2thZ2Utbm9ybWFsaXplLzpjdXN0b20tZmFjZQogKGRlZnVuIHVz ZS1wYWNrYWdlLWhhbmRsZXIvOmN1c3RvbS1mYWNlIChuYW1lIF9rZXl3b3JkIGFyZ3MgcmVzdCBz dGF0ZSkKICAgIkdlbmVyYXRlIHVzZS1wYWNrYWdlIGN1c3RvbS1mYWNlIGtleXdvcmQgY29kZS4i CiAgICh1c2UtcGFja2FnZS1jb25jYXQKLSAgIChtYXBjYXIgIycobGFtYmRhIChkZWYpIGAoYXBw bHkgIydmYWNlLXNwZWMtc2V0IChiYWNrcXVvdGUgLGRlZikpKSBhcmdzKQorICAgKG1hcGNhciAj JyhsYW1iZGEgKGRlZikKKyAgICAgICAgICAgICAgIGAocHJvZ24KKyAgICAgICAgICAgICAgICAg IChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQgKGFwcGVuZCAoYmFja3F1b3RlICxkZWYpICcoZmFjZS1k ZWZmYWNlLXNwZWMpKSkKKyAgICAgICAgICAgICAgICAgIChwdXQgJywoY2FyIGRlZikgJ2ZhY2Ut bW9kaWZpZWQgdCkpKQorICAgICAgICAgICBhcmdzKQogICAgKHVzZS1wYWNrYWdlLXByb2Nlc3Mt a2V5d29yZHMgbmFtZSByZXN0IHN0YXRlKSkpCiAKIDs7OzsgOmluaXQKQEAgLTE4NDgsNyArMTg1 Miw3IEBAIHVzZS1wYWNrYWdlCiA6Y3VzdG9tICAgICAgICAgIENhbGwgYEN1c3RvbS1zZXQnIG9y IGBzZXQtZGVmYXVsdCcgd2l0aCBlYWNoIHZhcmlhYmxlCiAgICAgICAgICAgICAgICAgIGRlZmlu aXRpb24gd2l0aG91dCBtb2RpZnlpbmcgdGhlIEVtYWNzIGBjdXN0b20tZmlsZScuCiAgICAgICAg ICAgICAgICAgIChjb21wYXJlIHdpdGggYGN1c3RvbS1zZXQtdmFyaWFibGVzJykuCi06Y3VzdG9t LWZhY2UgICAgIENhbGwgYGN1c3RvbS1zZXQtZmFjZXMnIHdpdGggZWFjaCBmYWNlIGRlZmluaXRp b24uCis6Y3VzdG9tLWZhY2UgICAgIENhbGwgYGZhY2Utc3BlYy1zZXQnIHdpdGggZWFjaCBmYWNl IGRlZmluaXRpb24uCiA6ZW5zdXJlICAgICAgICAgIExvYWRzIHRoZSBwYWNrYWdlIHVzaW5nIHBh Y2thZ2UuZWwgaWYgbmVjZXNzYXJ5LgogOnBpbiAgICAgICAgICAgICBQaW4gdGhlIHBhY2thZ2Ug dG8gYW4gYXJjaGl2ZS4KIDp2YyAgICAgICAgICAgICAgSW5zdGFsbCB0aGUgcGFja2FnZSBkaXJl Y3RseSBmcm9tIGEgdmVyc2lvbiBjb250cm9sIHN5c3RlbQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNw L3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsIGIvdGVzdC9saXNwL3VzZS1wYWNrYWdl L3VzZS1wYWNrYWdlLXRlc3RzLmVsCmluZGV4IDg1NTRiMzdkNWI4Li5iMjIxYzVkZTVjMSAxMDA2 NDQKLS0tIGEvdGVzdC9saXNwL3VzZS1wYWNrYWdlL3VzZS1wYWNrYWdlLXRlc3RzLmVsCisrKyBi L3Rlc3QvbGlzcC91c2UtcGFja2FnZS91c2UtcGFja2FnZS10ZXN0cy5lbApAQCAtMTE1Myw3ICsx MTUzLDEyIEBAIHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTEKICAgKG1hdGNoLWV4cGFu c2lvbgogICAgKHVzZS1wYWNrYWdlIGZvbyA6Y3VzdG9tLWZhY2UgKGZvbyAoKHQgKDpiYWNrZ3Jv dW5kICIjZTRlZGZjIikpKSkpCiAgICBgKHByb2duCi0gICAgICAoYXBwbHkgIydmYWNlLXNwZWMt c2V0IChiYWNrcXVvdGUgKGZvbyAoKHQgKDpiYWNrZ3JvdW5kICIjZTRlZGZjIikpKSkpKQorICAg ICAgKHByb2duCisgICAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKKyAgICAgICAgICAgICAg IChhcHBlbmQgKGJhY2txdW90ZSAoZm9vICgodCAoOmJhY2tncm91bmQgIiNlNGVkZmMiKSkpKSkK KyAgICAgICAgICAgICAgICAgICAgICAgJyhmYWNlLWRlZmZhY2Utc3BlYykpCisgICAgICAgICAg ICAgICApCisgICAgICAgIChwdXQgJ2ZvbyAnZmFjZS1tb2RpZmllZCB0KSkKICAgICAgIChyZXF1 aXJlICdmb28gbmlsIG5pbCkpKSkKIAogKGVydC1kZWZ0ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmN1 c3RvbS1mYWNlLTIgKCkKQEAgLTExNjMsMTkgKzExNjgsNDIgQEAgdXNlLXBhY2thZ2UtdGVzdC86 Y3VzdG9tLWZhY2UtMgogICAgICAoZXhhbXBsZS0xLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGln aHRQaW5rIikpKSkKICAgICAgKGV4YW1wbGUtMi1mYWNlICgodCAoOmZvcmVncm91bmQgIkxpZ2h0 R3JlZW4iKSkpKSkKICAgIGAocHJvZ24KLSAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKLSAg ICAgICAgICAgICAoYmFja3F1b3RlIChleGFtcGxlLTEtZmFjZSAoKHQgKDpmb3JlZ3JvdW5kICJM aWdodFBpbmsiKSkpKSkpCi0gICAgICAoYXBwbHkgIydmYWNlLXNwZWMtc2V0Ci0gICAgICAgICAg ICAgKGJhY2txdW90ZSAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9yZWdyb3VuZCAiTGlnaHRHcmVl biIpKSkpKSkKKyAgICAgIChwcm9nbgorICAgICAgICAoYXBwbHkgIydmYWNlLXNwZWMtc2V0Cisg ICAgICAgICAgICAgICAoYXBwZW5kIChiYWNrcXVvdGUgKGV4YW1wbGUtMS1mYWNlICgodCAoOmZv cmVncm91bmQgIkxpZ2h0UGluayIpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAnKGZhY2Ut ZGVmZmFjZS1zcGVjKSkpCisgICAgICAgIChwdXQgJ2V4YW1wbGUtMS1mYWNlICdmYWNlLW1vZGlm aWVkIHQpKQorICAgICAgKHByb2duCisgICAgICAgIChhcHBseSAjJ2ZhY2Utc3BlYy1zZXQKKyAg ICAgICAgICAgICAgIChhcHBlbmQgKGJhY2txdW90ZSAoZXhhbXBsZS0yLWZhY2UgKCh0ICg6Zm9y ZWdyb3VuZCAiTGlnaHRHcmVlbiIpKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAnKGZhY2Ut ZGVmZmFjZS1zcGVjKSkpCisgICAgICAgIChwdXQgJ2V4YW1wbGUtMi1mYWNlICdmYWNlLW1vZGlm aWVkIHQpKQogICAgICAgKHJlcXVpcmUgJ2V4YW1wbGUgbmlsIG5pbCkpKSkKIAogKGVydC1kZWZ0 ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmN1c3RvbS1mYWNlLTMgKCkKICAgKG1hdGNoLWV4cGFuc2lv bgogICAgKHVzZS1wYWNrYWdlIGZvbyA6Y3VzdG9tLWZhY2UgKGZvbyAoKHQgKDpiYWNrZ3JvdW5k ICIjZTRlZGZjIikpKSBmYWNlLWRlZnNwZWMtc3BlYykpCiAgICBgKHByb2duCi0gICAgICAoYXBw bHkgIydmYWNlLXNwZWMtc2V0IChiYWNrcXVvdGUgKGZvbyAoKHQgKDpiYWNrZ3JvdW5kICIjZTRl ZGZjIikpKSBmYWNlLWRlZnNwZWMtc3BlYykpKQorICAgICAgKHByb2duCisgICAgICAgIChhcHBs eSAjJ2ZhY2Utc3BlYy1zZXQKKyAgICAgICAgICAgICAgIChhcHBlbmQgKGJhY2txdW90ZSAoZm9v ICgodCAoOmJhY2tncm91bmQgIiNlNGVkZmMiKSkpIGZhY2UtZGVmc3BlYy1zcGVjKSkKKyAgICAg ICAgICAgICAgICAgICAgICAgJyhmYWNlLWRlZmZhY2Utc3BlYykpKQorICAgICAgICAocHV0ICdm b28gJ2ZhY2UtbW9kaWZpZWQgdCkpCiAgICAgICAocmVxdWlyZSAnZm9vIG5pbCBuaWwpKSkpCiAK KyhlcnQtZGVmdGVzdCB1c2UtcGFja2FnZS10ZXN0LzpjdXN0b20tZmFjZS00ICgpCisgIChkZWZm YWNlIHVzZS1wYWNrYWdlLXRlc3QvYmFzZS1mYWNlICcoKHQgKDpiYWNrZ3JvdW5kICJncmVlbiIp KSkgIiIpCisgIChkZWZmYWNlIHVzZS1wYWNrYWdlLXRlc3QvZmFjZSAnKCh0ICg6aW5oZXJpdCB1 c2UtcGFja2FnZS10ZXN0L2Jhc2UtZmFjZSkpKSAiIikKKyAgKHVzZS1wYWNrYWdlIGVtYWNzCisg ICAgOmN1c3RvbS1mYWNlCisgICAgKHVzZS1wYWNrYWdlLXRlc3QvZmFjZSAoKHQgKDpmb3JlZ3Jv dW5kICJibHVlIikpKSkpCisgIChzaG91bGQgKGVxdWFsIChmYWNlLWZvcmVncm91bmQgJ3VzZS1w YWNrYWdlLXRlc3QvZmFjZSBuaWwgdCkKKyAgICAgICAgICAgICAgICAgImJsdWUiKSkKKyAgKHNo b3VsZCAoZXF1YWwgKGZhY2UtYmFja2dyb3VuZCAndXNlLXBhY2thZ2UtdGVzdC9mYWNlIG5pbCB0 KQorICAgICAgICAgICAgICAgICBuaWwpKQorICAoc2hvdWxkIChlcXVhbCAoZ2V0ICd1c2UtcGFj a2FnZS10ZXN0L2ZhY2UgJ2ZhY2UtbW9kaWZpZWQpCisgICAgICAgICAgICAgICAgIHQpKSkKKwog KGVydC1kZWZ0ZXN0IHVzZS1wYWNrYWdlLXRlc3QvOmluaXQtMSAoKQogICAobWF0Y2gtZXhwYW5z aW9uCiAgICAodXNlLXBhY2thZ2UgZm9vIDppbml0IChpbml0KSkKLS0gCjIuNDkuMAoK --000000000000cd024b063327a735-- ------------=_1745740322-22723-1-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: [PATCH] use-package :custom-face is meant to behave like custom-set-face References: Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Apr 2025 14:51:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 77928@debbugs.gnu.org Cc: johnw@gnu.org, Michael Shields Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174576542322294 (code B ref 77928); Sun, 27 Apr 2025 14:51:03 +0000 Received: (at 77928) by debbugs.gnu.org; 27 Apr 2025 14:50:23 +0000 Received: from localhost ([127.0.0.1]:43324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u93Ko-0005nT-Lf for submit@debbugs.gnu.org; Sun, 27 Apr 2025 10:50:23 -0400 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:55037) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u93Kk-0005mv-Bf for 77928@debbugs.gnu.org; Sun, 27 Apr 2025 10:50:19 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 6879A11401FC; Sun, 27 Apr 2025 10:50:12 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Sun, 27 Apr 2025 10:50:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1745765412; x=1745851812; bh=tN YxfieSSb3egTeK4igtJo3pceKgkZkgc7XZP5gXo+Y=; b=VquvOZgEZPIlI12C2u qUlM+MMKFMjxGLD40vHtGYT/0kOy+ZDEPS+nlrH9W5JBg8VAkO3nEuFuP/OXWqGv LWINm9DoWDF694sieZ+vQB20/sl8SJp1D1jJquEVn6NQa0Qps9m9RrMMOe5zuXVb Rled/eY5i98rpcd1VfeOTQIUVrGDnh5ylc/O0jyh4ectrflWZo2fRvJdaaJPyLCn g7j+BnH8cVbcX9aY3/5DNR9FrRGzww+I1TzR942CDMcgJyOh0LSe/LIUQu4zi2Y7 liMUYwk8oDOpqsSdXFMMezV4DA56Sle49n0gNb8QzIKlxYeMmU8Qcgce2/kHtbyS Vc9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1745765412; x=1745851812; bh=tNYxfieSSb3egTeK4igtJo3pceKgkZkgc7X ZP5gXo+Y=; b=rrI6eNoyLKWXxgcSntPd1eJJl7LdFGzKtEgx0PgiyExKRdzF5tv 6sgb5wYrdnbiwnh9DumGJzT68gSsAo5k+6Ih67EtrqrSsWlvu2Im/BTRagFMHZrB 94ZejwUL1GRoHRs/R0W23ySFhu6bpOGyBTMyZ23JcIMSokUyyEV9dsYoI5PWh5Ib PyGpMqEi7RIGFnLT4b0H9OlSbO6K2Uq/x1trzoL8fOP/mITrWocVCaiDy47hYK2R MyEiJzeq1OS7YJ0deM1z/yTxyUhvIbQtUJuE5L/ieeAW8ShFV5IuYR07IbWOqK8U Plaeea4Ua4iXVVsUwoKzQ8cTrfl2JLIlDwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvheekfeehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefujgffkfggtgesthdtredttddttden ucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivg hnrdgtohhmqeenucggtffrrghtthgvrhhnpedtheffheehtdfgtdeuheffffffheettdek tefhtdfhfedvgfevheevffetvedvheenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgs pghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjeejledvke esuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehjohhhnhifsehgnhhurdho rhhgpdhrtghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhm X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Apr 2025 10:50:11 -0400 (EDT) From: Steven Allen In-Reply-To: <8634durqjp.fsf@gnu.org> Date: Sun, 27 Apr 2025 07:50:07 -0700 Message-ID: <87plgx3bhc.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >From my testing, this makes it impossible to override themed faces with :custom-face. This can be reproduced by applying a theme then attempting to override a themed face with :custom-face. Additionally, this patch makes the feature much less useful for tweaking faces. Previously, it was possible to achieve both behaviors (override or merge), now it's only possible to override. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces References: In-Reply-To: Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Apr 2025 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 77928@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174604841830525 (code B ref -1); Wed, 30 Apr 2025 21:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Apr 2025 21:26:58 +0000 Received: from localhost ([127.0.0.1]:46065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAExE-0007wG-F9 for submit@debbugs.gnu.org; Wed, 30 Apr 2025 17:26:58 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40088) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAExA-0007vx-4v for submit@debbugs.gnu.org; Wed, 30 Apr 2025 17:26:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAEx3-000729-Oi for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2025 17:26:46 -0400 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAEwz-0006gG-JL for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2025 17:26:45 -0400 Received: from phl-compute-08.internal (phl-compute-08.phl.internal [10.202.2.48]) by mailfout.stl.internal (Postfix) with ESMTP id AE32D11401C4 for ; Wed, 30 Apr 2025 17:26:38 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Wed, 30 Apr 2025 17:26:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:subject:subject:to:to; s=fm2; t=1746048398; x=1746134798; bh=EYKTpUYbPs96gNZTlU4txIJKl5vuT1mM 6s5qsE3/4WU=; b=Rw1frLNQHx6+KVqHQVG4IbZfYFU/FSKLkAE1lPROrhkzOEvO 4pUJU7OyKLvzcinOlyrEPkPa0+8NhF9O6lS/fB6tCWfpCCEctDd+21v+jGMG3m2m nhrNcxMU6z7gqOB4Xm1FIJLmfHmrjvvPD84TRLQzCFAAhM9aiZTyWa11nJyDfenU xpLZMU6G26bm4rfBLd01jhE/zPZqmKWUZGKbR7LuKrj2U3Vg305yTzJTvgy9xBMm 98sbEMCS7JPdcMZdX8VutebzpsmabU4q3F4Lihtz6wqqmUxCOHWX3pgLEzurf+vU 6gOXCESUlb4aobVdoBienZvcFxXCdOhB+ZydNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1746048398; x= 1746134798; bh=EYKTpUYbPs96gNZTlU4txIJKl5vuT1mM6s5qsE3/4WU=; b=Q A+cYAXG+Sjlwfdl5sKrNLhzHo3ro+NJddkOE0uwWta8/34FYAb8wRjFylAHouCeN 7gLlX0tveaGHinq7bIdmN6GQyd30gwrpNqu7NqjgC4dI0icHe19Dca2UCAQnL8qu G7OhyadRNGLE53phTRuHfusGoeqCEAqom4LjUzhlV1VIxUP2g1G9n4NAmRFkDbl7 elNlmsvdZhOiqrkGVcqGi8iRJ7udRv5CIotUj6d31UfQWwOP7Pcb9yCSAXEPHwzr GOzHahAfA4VSTJ0o+hjjHge1WTEwbahruAoMiEDh42GeistaDRjF1haLcMYL2aBH VU4DWbhIVGvMN9TOTukSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvieejjeejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvf fufffkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehs thgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrthhtvghrnheplefhve fhffdufedvhfekhfduveelkeefjeeuteeijeetfeegjedtteegueeuveeknecuffhomhgr ihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggprhgtphht thhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqdhgnhhuqdgvmh grtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 30 Apr 2025 17:26:37 -0400 (EDT) From: Steven Allen Date: Wed, 30 Apr 2025 14:26:34 -0700 Message-ID: <87y0vhwdbp.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=202.12.124.149; envelope-from=steven@stebalien.com; helo=fout-b6-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) ebcde0f90f6 (bug#77928) makes it impossible to override themed faces with :custom-face. This can be reproduced by: 1. Applying a theme (tested with modus). 2. Then attempt to override a themed face with ":custom-face". E.g., put the following into a scratch buffer and eval it. (load-theme 'modus-vivendi) (use-package emacs :custom-face (font-lock-keyword-face ((t :italic t)))) I'd expect my keywords to become italic but nothing happens (tested with `emacs -Q`). Additionally, this patch (as it was intended, as far as I can tell) makes the :custom-face feature much less useful for tweaking faces. Previously, it was possible to achieve both behaviors (override or merge), now it's only possible to override faces entirely which isn't nearly as useful. (I posted a comment on https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77928#28 but the bug was already closed) In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.18.4) of 2025-04-30 built on Laptop Repository revision: 1108523eb03d62eea10ece284594a862f0a62bcb Repository branch: merged Windowing system distributor 'The X.Org Foundation', version 11.0.12101016 System Description: Arch Linux Configured using: 'configure 'CPPFLAGS=-I/run/user/1000/build/emacs-git/src/mps-git/build/include ' 'LDFLAGS=-L/run/user/1000/build/emacs-git/src/mps-git/build/lib -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z,relro -Wl,-z,now -Wl,-z,pack-relative-relocs -flto=auto' --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games --with-modules --without-m17n-flt --without-selinux --without-pop --without-gconf --disable-gc-mark-trace --with-mps=yes --enable-link-time-optimization --with-native-compilation=yes --with-xinput2 --with-x-toolkit=no --without-toolkit-scroll-bars --without-xft --without-xaw3d --without-gsettings --with-cairo-xcb --with-sound=no --with-tree-sitter --without-gpm --without-compress-install '--program-transform-name=s/\([ec]tags\)/\1.emacs/' 'CFLAGS=-march=native -mtune=native -O3 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security -fstack-clash-protection -fcf-protection -fomit-frame-pointer -fno-math-errno -fno-trapping-math -fno-math-errno -fno-trapping-math -flto=auto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES MPS NATIVE_COMP NOTIFY INOTIFY OLDXMENU PDUMPER PNG RSVG SECCOMP SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: EXWM Minor modes in effect: notmuch-bookmarks-mode: t windmove-mode: t global-atomic-chrome-edit-mode: t iwd-agent-mode: t i3bar-mode: t ednc-mode: t exwm-xsettings-mode: t exwm-background-mode: t exwm-systemtray-mode: t exwm-randr-mode: t compile-angel-on-load-mode: t save-place-mode: t savehist-mode: t global-org-modern-mode: t eat-eshell-mode: t magit-todos-mode: t global-git-commit-mode: t server-mode: t llama-fontify-mode: t dired-async-mode: t yas-global-mode: t yas-minor-mode: t ultra-scroll-mode: t pixel-scroll-precision-mode: t global-hl-todo-mode: t marginalia-mode: t nerd-icons-completion-mode: t global-jinx-mode: t visual-replace-global-mode: t vertico-mode: t corfu-popupinfo-mode: t global-corfu-mode: t corfu-mode: t isearch-mb-mode: t evil-goggles-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-collection-unimpaired-mode: t evil-collection-unimpaired-mode: t recentf-mode: t editorconfig-mode: t global-auto-revert-mode: t minibuffer-depth-indicate-mode: t minibuffer-electric-default-mode: t evil-mode: t desktop-environment-mode: t elpaca-use-package-mode: t override-global-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-history-mode: t tab-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t window-divider-mode: t minibuffer-regexp-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/steb/.config/emacs/elpaca/builds/package-lint-flymake/package-lint-flymake hides /home/steb/.config/emacs/elpaca/builds/package-lint/package-lint-flymake /home/steb/.config/emacs/elpaca/builds/transient/transient hides /usr/share/emacs/31.0.50/lisp/transient /home/steb/.config/emacs/elpaca/builds/org/ox hides /usr/share/emacs/31.0.50/lisp/org/ox /home/steb/.config/emacs/elpaca/builds/org/ox-texinfo hides /usr/share/emacs/31.0.50/lisp/org/ox-texinfo /home/steb/.config/emacs/elpaca/builds/org/ox-publish hides /usr/share/emacs/31.0.50/lisp/org/ox-publish /home/steb/.config/emacs/elpaca/builds/org/ox-org hides /usr/share/emacs/31.0.50/lisp/org/ox-org /home/steb/.config/emacs/elpaca/builds/org/ox-odt hides /usr/share/emacs/31.0.50/lisp/org/ox-odt /home/steb/.config/emacs/elpaca/builds/org/ox-md hides /usr/share/emacs/31.0.50/lisp/org/ox-md /home/steb/.config/emacs/elpaca/builds/org/ox-man hides /usr/share/emacs/31.0.50/lisp/org/ox-man /home/steb/.config/emacs/elpaca/builds/org/ox-latex hides /usr/share/emacs/31.0.50/lisp/org/ox-latex /home/steb/.config/emacs/elpaca/builds/org/ox-koma-letter hides /usr/share/emacs/31.0.50/lisp/org/ox-koma-letter /home/steb/.config/emacs/elpaca/builds/org/ox-icalendar hides /usr/share/emacs/31.0.50/lisp/org/ox-icalendar /home/steb/.config/emacs/elpaca/builds/org/ox-html hides /usr/share/emacs/31.0.50/lisp/org/ox-html /home/steb/.config/emacs/elpaca/builds/org/ox-beamer hides /usr/share/emacs/31.0.50/lisp/org/ox-beamer /home/steb/.config/emacs/elpaca/builds/org/ox-ascii hides /usr/share/emacs/31.0.50/lisp/org/ox-ascii /home/steb/.config/emacs/elpaca/builds/org/org hides /usr/share/emacs/31.0.50/lisp/org/org /home/steb/.config/emacs/elpaca/builds/org/org-version hides /usr/share/emacs/31.0.50/lisp/org/org-version /home/steb/.config/emacs/elpaca/builds/org/org-timer hides /usr/share/emacs/31.0.50/lisp/org/org-timer /home/steb/.config/emacs/elpaca/builds/org/org-tempo hides /usr/share/emacs/31.0.50/lisp/org/org-tempo /home/steb/.config/emacs/elpaca/builds/org/org-table hides /usr/share/emacs/31.0.50/lisp/org/org-table /home/steb/.config/emacs/elpaca/builds/org/org-src hides /usr/share/emacs/31.0.50/lisp/org/org-src /home/steb/.config/emacs/elpaca/builds/org/org-refile hides /usr/share/emacs/31.0.50/lisp/org/org-refile /home/steb/.config/emacs/elpaca/builds/org/org-protocol hides /usr/share/emacs/31.0.50/lisp/org/org-protocol /home/steb/.config/emacs/elpaca/builds/org/org-plot hides /usr/share/emacs/31.0.50/lisp/org/org-plot /home/steb/.config/emacs/elpaca/builds/org/org-persist hides /usr/share/emacs/31.0.50/lisp/org/org-persist /home/steb/.config/emacs/elpaca/builds/org/org-pcomplete hides /usr/share/emacs/31.0.50/lisp/org/org-pcomplete /home/steb/.config/emacs/elpaca/builds/org/org-num hides /usr/share/emacs/31.0.50/lisp/org/org-num /home/steb/.config/emacs/elpaca/builds/org/org-mouse hides /usr/share/emacs/31.0.50/lisp/org/org-mouse /home/steb/.config/emacs/elpaca/builds/org/org-mobile hides /usr/share/emacs/31.0.50/lisp/org/org-mobile /home/steb/.config/emacs/elpaca/builds/org/org-macs hides /usr/share/emacs/31.0.50/lisp/org/org-macs /home/steb/.config/emacs/elpaca/builds/org/org-macro hides /usr/share/emacs/31.0.50/lisp/org/org-macro /home/steb/.config/emacs/elpaca/builds/org/org-loaddefs hides /usr/share/emacs/31.0.50/lisp/org/org-loaddefs /home/steb/.config/emacs/elpaca/builds/org/org-list hides /usr/share/emacs/31.0.50/lisp/org/org-list /home/steb/.config/emacs/elpaca/builds/org/org-lint hides /usr/share/emacs/31.0.50/lisp/org/org-lint /home/steb/.config/emacs/elpaca/builds/org/org-keys hides /usr/share/emacs/31.0.50/lisp/org/org-keys /home/steb/.config/emacs/elpaca/builds/org/org-inlinetask hides /usr/share/emacs/31.0.50/lisp/org/org-inlinetask /home/steb/.config/emacs/elpaca/builds/org/org-indent hides /usr/share/emacs/31.0.50/lisp/org/org-indent /home/steb/.config/emacs/elpaca/builds/org/org-id hides /usr/share/emacs/31.0.50/lisp/org/org-id /home/steb/.config/emacs/elpaca/builds/org/org-habit hides /usr/share/emacs/31.0.50/lisp/org/org-habit /home/steb/.config/emacs/elpaca/builds/org/org-goto hides /usr/share/emacs/31.0.50/lisp/org/org-goto /home/steb/.config/emacs/elpaca/builds/org/org-footnote hides /usr/share/emacs/31.0.50/lisp/org/org-footnote /home/steb/.config/emacs/elpaca/builds/org/org-fold hides /usr/share/emacs/31.0.50/lisp/org/org-fold /home/steb/.config/emacs/elpaca/builds/org/org-fold-core hides /usr/share/emacs/31.0.50/lisp/org/org-fold-core /home/steb/.config/emacs/elpaca/builds/org/org-feed hides /usr/share/emacs/31.0.50/lisp/org/org-feed /home/steb/.config/emacs/elpaca/builds/org/org-faces hides /usr/share/emacs/31.0.50/lisp/org/org-faces /home/steb/.config/emacs/elpaca/builds/org/org-entities hides /usr/share/emacs/31.0.50/lisp/org/org-entities /home/steb/.config/emacs/elpaca/builds/org/org-element hides /usr/share/emacs/31.0.50/lisp/org/org-element /home/steb/.config/emacs/elpaca/builds/org/org-element-ast hides /usr/share/emacs/31.0.50/lisp/org/org-element-ast /home/steb/.config/emacs/elpaca/builds/org/org-duration hides /usr/share/emacs/31.0.50/lisp/org/org-duration /home/steb/.config/emacs/elpaca/builds/org/org-datetree hides /usr/share/emacs/31.0.50/lisp/org/org-datetree /home/steb/.config/emacs/elpaca/builds/org/org-cycle hides /usr/share/emacs/31.0.50/lisp/org/org-cycle /home/steb/.config/emacs/elpaca/builds/org/org-ctags hides /usr/share/emacs/31.0.50/lisp/org/org-ctags /home/steb/.config/emacs/elpaca/builds/org/org-crypt hides /usr/share/emacs/31.0.50/lisp/org/org-crypt /home/steb/.config/emacs/elpaca/builds/org/org-compat hides /usr/share/emacs/31.0.50/lisp/org/org-compat /home/steb/.config/emacs/elpaca/builds/org/org-colview hides /usr/share/emacs/31.0.50/lisp/org/org-colview /home/steb/.config/emacs/elpaca/builds/org/org-clock hides /usr/share/emacs/31.0.50/lisp/org/org-clock /home/steb/.config/emacs/elpaca/builds/org/org-capture hides /usr/share/emacs/31.0.50/lisp/org/org-capture /home/steb/.config/emacs/elpaca/builds/org/org-attach hides /usr/share/emacs/31.0.50/lisp/org/org-attach /home/steb/.config/emacs/elpaca/builds/org/org-attach-git hides /usr/share/emacs/31.0.50/lisp/org/org-attach-git /home/steb/.config/emacs/elpaca/builds/org/org-archive hides /usr/share/emacs/31.0.50/lisp/org/org-archive /home/steb/.config/emacs/elpaca/builds/org/org-agenda hides /usr/share/emacs/31.0.50/lisp/org/org-agenda /home/steb/.config/emacs/elpaca/builds/org/ol hides /usr/share/emacs/31.0.50/lisp/org/ol /home/steb/.config/emacs/elpaca/builds/org/ol-w3m hides /usr/share/emacs/31.0.50/lisp/org/ol-w3m /home/steb/.config/emacs/elpaca/builds/org/ol-rmail hides /usr/share/emacs/31.0.50/lisp/org/ol-rmail /home/steb/.config/emacs/elpaca/builds/org/ol-mhe hides /usr/share/emacs/31.0.50/lisp/org/ol-mhe /home/steb/.config/emacs/elpaca/builds/org/ol-man hides /usr/share/emacs/31.0.50/lisp/org/ol-man /home/steb/.config/emacs/elpaca/builds/org/ol-irc hides /usr/share/emacs/31.0.50/lisp/org/ol-irc /home/steb/.config/emacs/elpaca/builds/org/ol-info hides /usr/share/emacs/31.0.50/lisp/org/ol-info /home/steb/.config/emacs/elpaca/builds/org/ol-gnus hides /usr/share/emacs/31.0.50/lisp/org/ol-gnus /home/steb/.config/emacs/elpaca/builds/org/ol-eww hides /usr/share/emacs/31.0.50/lisp/org/ol-eww /home/steb/.config/emacs/elpaca/builds/org/ol-eshell hides /usr/share/emacs/31.0.50/lisp/org/ol-eshell /home/steb/.config/emacs/elpaca/builds/org/ol-doi hides /usr/share/emacs/31.0.50/lisp/org/ol-doi /home/steb/.config/emacs/elpaca/builds/org/ol-docview hides /usr/share/emacs/31.0.50/lisp/org/ol-docview /home/steb/.config/emacs/elpaca/builds/org/ol-bibtex hides /usr/share/emacs/31.0.50/lisp/org/ol-bibtex /home/steb/.config/emacs/elpaca/builds/org/ol-bbdb hides /usr/share/emacs/31.0.50/lisp/org/ol-bbdb /home/steb/.config/emacs/elpaca/builds/org/oc hides /usr/share/emacs/31.0.50/lisp/org/oc /home/steb/.config/emacs/elpaca/builds/org/oc-natbib hides /usr/share/emacs/31.0.50/lisp/org/oc-natbib /home/steb/.config/emacs/elpaca/builds/org/oc-csl hides /usr/share/emacs/31.0.50/lisp/org/oc-csl /home/steb/.config/emacs/elpaca/builds/org/oc-bibtex hides /usr/share/emacs/31.0.50/lisp/org/oc-bibtex /home/steb/.config/emacs/elpaca/builds/org/oc-biblatex hides /usr/share/emacs/31.0.50/lisp/org/oc-biblatex /home/steb/.config/emacs/elpaca/builds/org/oc-basic hides /usr/share/emacs/31.0.50/lisp/org/oc-basic /home/steb/.config/emacs/elpaca/builds/org/ob hides /usr/share/emacs/31.0.50/lisp/org/ob /home/steb/.config/emacs/elpaca/builds/org/ob-tangle hides /usr/share/emacs/31.0.50/lisp/org/ob-tangle /home/steb/.config/emacs/elpaca/builds/org/ob-table hides /usr/share/emacs/31.0.50/lisp/org/ob-table /home/steb/.config/emacs/elpaca/builds/org/ob-sqlite hides /usr/share/emacs/31.0.50/lisp/org/ob-sqlite /home/steb/.config/emacs/elpaca/builds/org/ob-sql hides /usr/share/emacs/31.0.50/lisp/org/ob-sql /home/steb/.config/emacs/elpaca/builds/org/ob-shell hides /usr/share/emacs/31.0.50/lisp/org/ob-shell /home/steb/.config/emacs/elpaca/builds/org/ob-sed hides /usr/share/emacs/31.0.50/lisp/org/ob-sed /home/steb/.config/emacs/elpaca/builds/org/ob-screen hides /usr/share/emacs/31.0.50/lisp/org/ob-screen /home/steb/.config/emacs/elpaca/builds/org/ob-scheme hides /usr/share/emacs/31.0.50/lisp/org/ob-scheme /home/steb/.config/emacs/elpaca/builds/org/ob-sass hides /usr/share/emacs/31.0.50/lisp/org/ob-sass /home/steb/.config/emacs/elpaca/builds/org/ob-ruby hides /usr/share/emacs/31.0.50/lisp/org/ob-ruby /home/steb/.config/emacs/elpaca/builds/org/ob-ref hides /usr/share/emacs/31.0.50/lisp/org/ob-ref /home/steb/.config/emacs/elpaca/builds/org/ob-python hides /usr/share/emacs/31.0.50/lisp/org/ob-python /home/steb/.config/emacs/elpaca/builds/org/ob-processing hides /usr/share/emacs/31.0.50/lisp/org/ob-processing /home/steb/.config/emacs/elpaca/builds/org/ob-plantuml hides /usr/share/emacs/31.0.50/lisp/org/ob-plantuml /home/steb/.config/emacs/elpaca/builds/org/ob-perl hides /usr/share/emacs/31.0.50/lisp/org/ob-perl /home/steb/.config/emacs/elpaca/builds/org/ob-org hides /usr/share/emacs/31.0.50/lisp/org/ob-org /home/steb/.config/emacs/elpaca/builds/org/ob-octave hides /usr/share/emacs/31.0.50/lisp/org/ob-octave /home/steb/.config/emacs/elpaca/builds/org/ob-ocaml hides /usr/share/emacs/31.0.50/lisp/org/ob-ocaml /home/steb/.config/emacs/elpaca/builds/org/ob-maxima hides /usr/share/emacs/31.0.50/lisp/org/ob-maxima /home/steb/.config/emacs/elpaca/builds/org/ob-matlab hides /usr/share/emacs/31.0.50/lisp/org/ob-matlab /home/steb/.config/emacs/elpaca/builds/org/ob-makefile hides /usr/share/emacs/31.0.50/lisp/org/ob-makefile /home/steb/.config/emacs/elpaca/builds/org/ob-lua hides /usr/share/emacs/31.0.50/lisp/org/ob-lua /home/steb/.config/emacs/elpaca/builds/org/ob-lob hides /usr/share/emacs/31.0.50/lisp/org/ob-lob /home/steb/.config/emacs/elpaca/builds/org/ob-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-lisp /home/steb/.config/emacs/elpaca/builds/org/ob-lilypond hides /usr/share/emacs/31.0.50/lisp/org/ob-lilypond /home/steb/.config/emacs/elpaca/builds/org/ob-latex hides /usr/share/emacs/31.0.50/lisp/org/ob-latex /home/steb/.config/emacs/elpaca/builds/org/ob-julia hides /usr/share/emacs/31.0.50/lisp/org/ob-julia /home/steb/.config/emacs/elpaca/builds/org/ob-js hides /usr/share/emacs/31.0.50/lisp/org/ob-js /home/steb/.config/emacs/elpaca/builds/org/ob-java hides /usr/share/emacs/31.0.50/lisp/org/ob-java /home/steb/.config/emacs/elpaca/builds/org/ob-haskell hides /usr/share/emacs/31.0.50/lisp/org/ob-haskell /home/steb/.config/emacs/elpaca/builds/org/ob-groovy hides /usr/share/emacs/31.0.50/lisp/org/ob-groovy /home/steb/.config/emacs/elpaca/builds/org/ob-gnuplot hides /usr/share/emacs/31.0.50/lisp/org/ob-gnuplot /home/steb/.config/emacs/elpaca/builds/org/ob-fortran hides /usr/share/emacs/31.0.50/lisp/org/ob-fortran /home/steb/.config/emacs/elpaca/builds/org/ob-forth hides /usr/share/emacs/31.0.50/lisp/org/ob-forth /home/steb/.config/emacs/elpaca/builds/org/ob-exp hides /usr/share/emacs/31.0.50/lisp/org/ob-exp /home/steb/.config/emacs/elpaca/builds/org/ob-eval hides /usr/share/emacs/31.0.50/lisp/org/ob-eval /home/steb/.config/emacs/elpaca/builds/org/ob-eshell hides /usr/share/emacs/31.0.50/lisp/org/ob-eshell /home/steb/.config/emacs/elpaca/builds/org/ob-emacs-lisp hides /usr/share/emacs/31.0.50/lisp/org/ob-emacs-lisp /home/steb/.config/emacs/elpaca/builds/org/ob-dot hides /usr/share/emacs/31.0.50/lisp/org/ob-dot /home/steb/.config/emacs/elpaca/builds/org/ob-ditaa hides /usr/share/emacs/31.0.50/lisp/org/ob-ditaa /home/steb/.config/emacs/elpaca/builds/org/ob-css hides /usr/share/emacs/31.0.50/lisp/org/ob-css /home/steb/.config/emacs/elpaca/builds/org/ob-core hides /usr/share/emacs/31.0.50/lisp/org/ob-core /home/steb/.config/emacs/elpaca/builds/org/ob-comint hides /usr/share/emacs/31.0.50/lisp/org/ob-comint /home/steb/.config/emacs/elpaca/builds/org/ob-clojure hides /usr/share/emacs/31.0.50/lisp/org/ob-clojure /home/steb/.config/emacs/elpaca/builds/org/ob-calc hides /usr/share/emacs/31.0.50/lisp/org/ob-calc /home/steb/.config/emacs/elpaca/builds/org/ob-awk hides /usr/share/emacs/31.0.50/lisp/org/ob-awk /home/steb/.config/emacs/elpaca/builds/org/ob-R hides /usr/share/emacs/31.0.50/lisp/org/ob-R /home/steb/.config/emacs/elpaca/builds/org/ob-C hides /usr/share/emacs/31.0.50/lisp/org/ob-C Features: (shadow sort mail-extr hippie-exp misearch multi-isearch emacsql-sqlite-builtin eshell-syntax-highlighting em-elecslash em-ls em-glob em-extpipe em-dirs em-basic em-alias emacsbug lisp-mnt help-fns radix-tree mule-util vertico-sort tramp-cmds rainbow-mode evil-collection-flymake flymake rainbow-delimiters evil-collection-vc-git vc-git vc-dispatcher vertico-repeat evil-collection-consult consult magit-bookmark org-bookmark-heading notmuch-bookmarks evil-collection-bookmark bookmark windmove tramp-cache time-stamp filechooser pinentry evil-collection-atomic-chrome atomic-chrome websocket bindat iwd i3bar ednc dbus xml exwm-xsettings xcb-xsettings exwm-background exwm-systemtray xcb-systemtray xcb-xembed exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug posframe face-remap visual-fill-column ligature cape org-appear stripspace oc-basic bibtex ol-man ol-info ol-docview evil-collection-doc-view doc-view jka-compr evil-collection-image image-mode exif compile-angel saveplace savehist show-font org-protocol evil-org org-element org-persist org-id org-refile avl-tree org-modern ob-dot ob-latex ob-python evil-collection-python python ob-gnuplot ob-calc calc-store calc-trail calc-ext evil-collection-calc calc calc-loaddefs calc-macs ob-shell evil-collection-org org-crypt org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src evil-collection-sh-script sh-script smie executable ob-comint org-element-ast inline org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-compat org-version org-macs notmuch-addr evil-collection-eat eat term/xterm xterm tramp-sh tramp trampver tramp-integration tramp-message tramp-compat tramp-loaddefs evil-collection-term term ehelp evil-collection-forge forge-repos forge-tablist forge-topics forge-commands forge-semi forge-bitbucket buck forge-gogs gogs forge-gitea gtea forge-gitlab glab forge-github ghub-graphql treepy gsexp ghub url-http url-gw nsm url-auth let-alist forge-forgejo forge-notify forge-revnote forge-pullreq forge-issue forge-discussion forge-topic yaml parse-time iso8601 eieio-custom bug-reference forge-post evil-collection-markdown-mode markdown-mode edit-indirect evil-collection-outline noutline outline forge-repo forge forge-core forge-db closql emacsql-sqlite emacsql emacsql-compiler eieio-base evil-collection-magit-todos magit-todos pcre2el rxt advice re-builder f s dash evil-collection-grep grep evil-collection-compile compile evil-collection-magit magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit evil-collection-package-menu package url-handlers evil-collection-magit-repos magit-repos magit-apply magit-wip magit-log which-func evil-collection-imenu imenu magit-diff evil-collection-smerge-mode smerge-mode diff git-commit evil-collection-log-edit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process evil-collection-with-editor with-editor shell server magit-mode transient browse-url benchmark magit-git magit-base evil-collection-magit-section magit-section cursor-sensor llama dired-async async dired-aux yasnippet evil-collection-ultra-scroll ultra-scroll pixel-scroll cua-base hl-todo marginalia nerd-icons-corfu nerd-icons-completion nerd-icons nerd-icons-faces nerd-icons-data nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon nerd-icons-data-pomicon nerd-icons-data-ipsicon jinx visual-replace evil-collection-which-key which-key vertico corfu-popupinfo evil-collection-corfu corfu orderless isearch-mb evil-goggles pulse color evil-textobj-tree-sitter evil-textobj-tree-sitter-thing-at-point evil-textobj-tree-sitter-core treesit evil-args evil-surround cus-start evil-collection-unimpaired evil-collection-tabulated-list evil-collection-tab-bar evil-collection-simple evil-collection-replace evil-collection-process-menu evil-collection-notmuch evil-collection-kmacro evil-collection-indent evil-collection-help evil-collection-epa evil-collection-elisp-mode evil-collection-eldoc evil-collection-elpaca evil-collection-dired evil-collection-custom evil-collection-comint evil-collection-calendar evil-collection-buff-menu evil-collection annalist ednc-autoloads i3bar-autoloads discomfort-autoloads debase-autoloads iwd-autoloads bluetooth-autoloads app-launcher-autoloads atomic-chrome-autoloads websocket-autoloads pinentry-autoloads playerctl-autoloads exwm-autoloads xelb-autoloads ol-notmuch-autoloads microdata-autoloads notmuch-addr-autoloads eshell-syntax-highlighting-autoloads eat-autoloads git-link-autoloads pr-review-autoloads igist-autoloads magit-todos-autoloads wgrep-autoloads watch-autoloads tmr-autoloads syncthing-autoloads pcre2el-autoloads qrencode-autoloads password-store-menu-autoloads password-store-autoloads named-pipe-autoloads info-colors-autoloads helpful-autoloads elisp-refs-autoloads devdocs-autoloads whisper-autoloads gptel-autoloads copilot-autoloads tzc-autoloads journalctl-autoloads systemctl-autoloads proced-narrow-autoloads show-font-autoloads dbus-explore-autoloads disk-usage-autoloads dired-filter-autoloads dired-hacks-utils-autoloads f-autoloads s-autoloads dash-autoloads diredfl-autoloads org-bookmark-heading-autoloads notmuch-bookmarks-autoloads pdf-tools-autoloads tablist-autoloads nov-autoloads esxml-autoloads calibre-autoloads orgit-forge-autoloads forge-autoloads closql-autoloads emacsql-autoloads ghub-autoloads treepy-autoloads yaml-autoloads orgit-autoloads magit-autoloads magit-section-autoloads with-editor-autoloads evil-org-autoloads org-download-autoloads async-autoloads org-appear-autoloads org-modern-autoloads org-loaddefs edit-indirect-autoloads markdown-mode-autoloads web-mode-autoloads wat-ts-mode-autoloads solidity-mode-autoloads comint-mime-autoloads mathjax-autoloads flymake-ruff-autoloads evm-mode-autoloads package-lint-flymake-autoloads package-lint-autoloads eff-autoloads pkgbuild-mode-autoloads gnuplot-autoloads graphviz-dot-mode-autoloads csv-mode-autoloads udev-mode-autoloads systemd-autoloads ssh-config-mode-autoloads nftables-mode-autoloads git-modes-autoloads rmsbolt-autoloads rust-playground-autoloads consult-eglot-autoloads dape-autoloads casual-autoloads notmuch-transient-autoloads transient-autoloads bash-completion-autoloads cape-autoloads yasnippet-autoloads iwindow-autoloads consult-project-extra-autoloads ultra-scroll-autoloads ligature-autoloads hl-todo-autoloads rainbow-mode-autoloads marginalia-autoloads posframe-autoloads rainbow-delimiters-autoloads visual-fill-column-autoloads nerd-icons-corfu-autoloads nerd-icons-ibuffer-autoloads nerd-icons-completion-autoloads nerd-icons-dired-autoloads nerd-icons-autoloads link-hint-autoloads avy-autoloads snapshot-timemachine-autoloads stripspace-autoloads vundo-autoloads jinx-autoloads visual-replace-autoloads vertico-autoloads corfu-autoloads orderless-autoloads isearch-mb-autoloads embark-consult-autoloads consult-autoloads embark-autoloads evil-goggles-autoloads evil-nerd-commenter-autoloads evil-textobj-tree-sitter-autoloads evil-args-autoloads evil-surround-autoloads evil-collection-autoloads annalist-autoloads filechooser-autoloads notmuch notmuch-tree notmuch-jump notmuch-hello notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company notmuch-parser format-spec notmuch-wash diff-mode track-changes coolj goto-addr icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs notmuch-tag crm notmuch-lib notmuch-compat hl-line message sendmail yank-media dired dired-loaddefs rfc822 mml mailabbrev mail-utils gmm-utils mailheader mm-view mml-smime mml-sec epa epg rfc6068 epg-config gnus-util time-date smime gnutls puny dig mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr em-prompt text-property-search em-hist em-unix em-pred esh-mode esh-var eshell esh-cmd generator esh-ext esh-proc esh-opt esh-io esh-arg pcomplete comint ansi-osc ansi-color esh-module esh-module-loaddefs esh-util files-x recentf tree-widget editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch project disp-table modus-operandi-theme modus-themes derived pcase autorevert filenotify mb-depth minibuf-eldef elpaca-menu-elpa evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core comp-run evil-common thingatpt rect evil-vars ring edmacro kmacro evil-autoloads goto-chg-autoloads general general-autoloads llama-autoloads compile-angel-autoloads mode-local find-func no-littering compat no-littering-autoloads elpaca-menu-melpa elpaca-menu-org elpaca-use-package use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core elpaca-use-package-autoloads elpaca-log elpaca-ui url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source eieio eieio-core cl-macs password-cache json map byte-opt url-vars mailcap elpaca elpaca-process elpaca-autoloads notmuch-version comp cl-seq comp-cstr cl-extra help-mode comp-common warnings subr-x rx gv bytecomp byte-compile xdg cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo xinput2 x multi-tty move-toolbar make-network-process tty-child-frames native-compile mps emacs) Memory information: ((conses 24 0 0) (symbols 56 0 0) (strings 40 0 0) (string-bytes 1 0) (vectors 24 0) (vector-slots 8 0 0) (floats 24 0 0) (intervals 64 0 0) (buffers 1000 0)) From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 May 2025 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen , Michael Shields Cc: 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17461214203582 (code B ref 77928); Thu, 01 May 2025 17:44:02 +0000 Received: (at 77928) by debbugs.gnu.org; 1 May 2025 17:43:40 +0000 Received: from localhost ([127.0.0.1]:52936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAXwi-0000vh-Cx for submit@debbugs.gnu.org; Thu, 01 May 2025 13:43:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33592) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAXwf-0000vN-MT for 77928@debbugs.gnu.org; Thu, 01 May 2025 13:43:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uAXwY-0006Io-Cq; Thu, 01 May 2025 13:43:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LL+pjn1dENKuOPcs4HbvU++uY/W7afj6H6tGnIzIQZE=; b=l2JiGKWpxf/A tA1s+j9NMq6XoHMMo+WHnPMVOU7pYma13ZGWmyEfa5PppEoQUSEloJfAa9PlMBlJLtEt5A8lJwR3v nFG+wwmL/LCpnIqSyAh9loVxS0MO3I64Z3rdiyqKozSFJtDdfZXMil1LJ5CDvyf9TBFG402NTJzX3 eVxvvJalQKGTLrgqlTlwfAuGYmUXlBwWB33y8q6kNZH5FnIbETqqrKieaFOGLXdjGuXiZ+0TbC6yR 6gqjgjrFA3yGSjK6aXDdsPJJ6xzvDRUd2I2VA0+z+y49N0H5HNeE+8bk39KlgcX9IJBYdZMq6wK9s C5irrLGDAsGPF0CaB7uTCQ==; Date: Thu, 01 May 2025 20:43:28 +0300 Message-Id: <86ikmkmdkv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87y0vhwdbp.fsf@stebalien.com> (bug-gnu-emacs@gnu.org) References: <87y0vhwdbp.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 30 Apr 2025 14:26:34 -0700 > From: Steven Allen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > ebcde0f90f6 (bug#77928) makes it impossible to override themed faces with > :custom-face. This can be reproduced by: > > 1. Applying a theme (tested with modus). > 2. Then attempt to override a themed face with ":custom-face". > > E.g., put the following into a scratch buffer and eval it. > > (load-theme 'modus-vivendi) > (use-package emacs :custom-face (font-lock-keyword-face ((t :italic t)))) > > I'd expect my keywords to become italic but nothing happens (tested with > `emacs -Q`). > > Additionally, this patch (as it was intended, as far as I can tell) > makes the :custom-face feature much less useful for tweaking faces. > Previously, it was possible to achieve both behaviors (override or > merge), now it's only possible to override faces entirely which isn't > nearly as useful. > > (I posted a comment on > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77928#28 but the bug was > already closed) Thanks. Michael, could you please look into this regression? From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 May 2025 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: steven@stebalien.com, shields@msrl.com Cc: 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174746896114082 (code B ref 77928); Sat, 17 May 2025 08:03:01 +0000 Received: (at 77928) by debbugs.gnu.org; 17 May 2025 08:02:41 +0000 Received: from localhost ([127.0.0.1]:45092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGCVE-0003ez-2Z for submit@debbugs.gnu.org; Sat, 17 May 2025 04:02:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60200) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uGCV9-0003dA-3T for 77928@debbugs.gnu.org; Sat, 17 May 2025 04:02:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uGCV3-0006Ue-EU; Sat, 17 May 2025 04:02:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+QA3oCiAN5qvcPqkUEdTRIyANrJuRF6TjvkKK4frMHE=; b=lz6HDp1lNyhh Q9iz1+wht7VB/Hsc2oRehg96LYUfLl8AmM59SZBpMa7PI4MyOlKxMuDHHXm6kqPCatHzef3kg98YK Xj0OtrCRa0mz7Lspr6zo8PxP1pqJPT0FYuXNkUfnGYQy/IVFX360lBPwlkHHX8OLBFICJ7qJpGSFG tF2YrpjX80sy1uRM634/ukYu+2+R5u7mtDELDhKZmZpIxlfea9MMA2cOR8CNxdFBUkDKLPJh/8b/r niFaP2OCut0rGlERmRzyGpLZ/4pULXWREsjykq6lPaN9sR0j3wZdU20/muTT18To29VsHqM7Q+GW/ qCw4s/W+Mtuo1AiVCK4OoA==; Date: Sat, 17 May 2025 11:02:25 +0300 Message-Id: <86tt5jwtpq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86ikmkmdkv.fsf@gnu.org> (message from Eli Zaretskii on Thu, 01 May 2025 20:43:28 +0300) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Michael, could you please chime in? > Cc: 77928@debbugs.gnu.org > Date: Thu, 01 May 2025 20:43:28 +0300 > From: Eli Zaretskii > > > Date: Wed, 30 Apr 2025 14:26:34 -0700 > > From: Steven Allen via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > > > ebcde0f90f6 (bug#77928) makes it impossible to override themed faces with > > :custom-face. This can be reproduced by: > > > > 1. Applying a theme (tested with modus). > > 2. Then attempt to override a themed face with ":custom-face". > > > > E.g., put the following into a scratch buffer and eval it. > > > > (load-theme 'modus-vivendi) > > (use-package emacs :custom-face (font-lock-keyword-face ((t :italic t)))) > > > > I'd expect my keywords to become italic but nothing happens (tested with > > `emacs -Q`). > > > > Additionally, this patch (as it was intended, as far as I can tell) > > makes the :custom-face feature much less useful for tweaking faces. > > Previously, it was possible to achieve both behaviors (override or > > merge), now it's only possible to override faces entirely which isn't > > nearly as useful. > > > > (I posted a comment on > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77928#28 but the bug was > > already closed) > > Thanks. > > Michael, could you please look into this regression? > > > > From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Michael Shields Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 May 2025 00:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, steven@stebalien.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174752876519046 (code B ref 77928); Sun, 18 May 2025 00:40:01 +0000 Received: (at 77928) by debbugs.gnu.org; 18 May 2025 00:39:25 +0000 Received: from localhost ([127.0.0.1]:52602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uGS3o-0004x6-Br for submit@debbugs.gnu.org; Sat, 17 May 2025 20:39:24 -0400 Received: from mail-yb1-xb34.google.com ([2607:f8b0:4864:20::b34]:59741) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uGS3l-0004wm-8q for 77928@debbugs.gnu.org; Sat, 17 May 2025 20:39:22 -0400 Received: by mail-yb1-xb34.google.com with SMTP id 3f1490d57ef6-e75668006b9so3386895276.3 for <77928@debbugs.gnu.org>; Sat, 17 May 2025 17:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1747528755; x=1748133555; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+zUqMThQMWDgT/Oa3DfR8hu3879hhghfts2rspMbN/8=; b=iIqT8XK+ww5X1boQB51oqkfG87pf1DvtP4kp1bRnb4i+OHfIqtouVJjk723715MnIo NroKSk1SyVIRlMB8mn0pRubXQlC55SphuEHf1YX6LHrYfh2pyTsg+rpmCR/Zradrng3O oxhbb3wHK7etphWnXlmChebMaQaLqcDMbvDrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747528755; x=1748133555; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+zUqMThQMWDgT/Oa3DfR8hu3879hhghfts2rspMbN/8=; b=Pn6IjSYQFaluZIQ0/qNzWGnwEQ4Zt/nzhRssx45UvDxsL8Jq4VPihN9xJa0y8Gwrhj j7wa9SriT50qZHtVhIP8jZSJaQ03ew7a469dhGhaKNDB4i81oikx7mxAb7Sg/USO/0iB cFf374kPf0HRj//reJOKYaC33ltTSF3xzKNyg9fVZRhhGijiudxRdpc8Om7IJqXKc8kX lyRzdasdEtF9HZvfSECVFVX1j0OqqqON6wyGNFBoIRvAtuZeW3rlH08dHGByNMS04fzx hvMz+prvHFJtMnDu/cPkeT0kbFQBoiY4YoVTMY+z1mVYjF7DhBUh/i72u//LagSsoHdD TrJQ== X-Forwarded-Encrypted: i=1; AJvYcCUo3IURsCfKjB/aREC/cBrjpIrlQggYtnD+ZXmKkSLoGY2JQlsOE4TXy/0o6hFSutndDO2IQg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzdOykZ/eiL+ykt8pKPpMQ/2XaPCt8pB/U2YuOQ4Tm2LQDCBuVu KkgOlK2Zfo47qB9MXFO8W0/q3Ez66dGWPNryJCzYaXBsBUvU9T7CWpn3DP2h13RSomTVvCRYxGd 6CqzlA1+5OS+M5O+3eQ/n6nb589Lx5/ucS+0R4GBu X-Gm-Gg: ASbGncu8iY/rfJwprclA1x9aZsxPtRr/88SUdyj0s/Hq5EWFnLJBNZKTALG+uq8DWeZ joQBgbOcT84MGYuApHOVTCXmnl/M0Lcp9DmzbG54/4Yn00VpD3faiMtUau0DSAnWdWZoB1lv8Ld tXUdof7ccdMINdjm4bmJ2mR9qibVRz2K4BUGxbAhidlHaPVex3vxKPgSK1zth4Ldnp9iE= X-Google-Smtp-Source: AGHT+IE1XqVaPzWtMVrOjEY/12OD3Benf5Q/x9VTNEoiNh3g7y2ajvABF4suvp1fJl5K5LK+ds8uXPHW2FcJZ4QFtH0= X-Received: by 2002:a05:690c:316:b0:705:750e:851 with SMTP id 00721157ae682-70ca7bc3436mr138636117b3.37.1747528755354; Sat, 17 May 2025 17:39:15 -0700 (PDT) MIME-Version: 1.0 References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> In-Reply-To: <86tt5jwtpq.fsf@gnu.org> From: Michael Shields Date: Sat, 17 May 2025 17:39:04 -0700 X-Gm-Features: AX0GCFtVt1G5mh33kBR8_alZKKNVi_QUTMJoxKB_BFtwDVmtDsFWD0oTPM4fJCo Message-ID: Content-Type: multipart/alternative; boundary="000000000000b2bc6d06355e3ea3" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000b2bc6d06355e3ea3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I can take a look at this tomorrow. On Sat, May 17, 2025 at 1:02=E2=80=AFAM Eli Zaretskii wrote: > Ping! Michael, could you please chime in? > > > Cc: 77928@debbugs.gnu.org > > Date: Thu, 01 May 2025 20:43:28 +0300 > > From: Eli Zaretskii > > > > > Date: Wed, 30 Apr 2025 14:26:34 -0700 > > > From: Steven Allen via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" > > > > > > > > > ebcde0f90f6 (bug#77928) makes it impossible to override themed faces > with > > > :custom-face. This can be reproduced by: > > > > > > 1. Applying a theme (tested with modus). > > > 2. Then attempt to override a themed face with ":custom-face". > > > > > > E.g., put the following into a scratch buffer and eval it. > > > > > > (load-theme 'modus-vivendi) > > > (use-package emacs :custom-face (font-lock-keyword-face ((t > :italic t)))) > > > > > > I'd expect my keywords to become italic but nothing happens (tested > with > > > `emacs -Q`). > > > > > > Additionally, this patch (as it was intended, as far as I can tell) > > > makes the :custom-face feature much less useful for tweaking faces. > > > Previously, it was possible to achieve both behaviors (override or > > > merge), now it's only possible to override faces entirely which isn't > > > nearly as useful. > > > > > > (I posted a comment on > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77928#28 but the bug = was > > > already closed) > > > > Thanks. > > > > Michael, could you please look into this regression? > > > > > > > > > --000000000000b2bc6d06355e3ea3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I can take a look at this tomorrow.

O= n Sat, May 17, 2025 at 1:02=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
Ping!=C2=A0 Michael, could you please chime in?
> Cc: 77928@d= ebbugs.gnu.org
> Date: Thu, 01 May 2025 20:43:28 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Date: Wed, 30 Apr 2025 14:26:34 -0700
> > From:=C2=A0 Steven Allen via "Bug reports for GNU Emacs,
> >=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>= ;
> >
> >
> > ebcde0f90f6 (bug#77928) makes it impossible to override themed fa= ces with
> > :custom-face. This can be reproduced by:
> >
> > 1. Applying a theme (tested with modus).
> > 2. Then attempt to override a themed face with ":custom-face= ".
> >
> > E.g., put the following into a scratch buffer and eval it.
> >
> >=C2=A0 =C2=A0 =C2=A0(load-theme 'modus-vivendi)
> >=C2=A0 =C2=A0 =C2=A0(use-package emacs :custom-face (font-lock-key= word-face ((t :italic t))))
> >
> > I'd expect my keywords to become italic but nothing happens (= tested with
> > `emacs -Q`).
> >
> > Additionally, this patch (as it was intended, as far as I can tel= l)
> > makes the :custom-face feature much less useful for tweaking face= s.
> > Previously, it was possible to achieve both behaviors (override o= r
> > merge), now it's only possible to override faces entirely whi= ch isn't
> > nearly as useful.
> >
> > (I posted a comment on
> > https://debbugs.gnu.org/cgi/bugrep= ort.cgi?bug=3D77928#28 but the bug was
> > already closed)
>
> Thanks.
>
> Michael, could you please look into this regression?
>
>
>
>
--000000000000b2bc6d06355e3ea3-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Michael Shields Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 May 2025 05:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, steven@stebalien.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17477203107295 (code B ref 77928); Tue, 20 May 2025 05:52:02 +0000 Received: (at 77928) by debbugs.gnu.org; 20 May 2025 05:51:50 +0000 Received: from localhost ([127.0.0.1]:52017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uHFtF-0001tZ-P4 for submit@debbugs.gnu.org; Tue, 20 May 2025 01:51:50 -0400 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]:47108) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uHFtC-0001sE-J6 for 77928@debbugs.gnu.org; Tue, 20 May 2025 01:51:47 -0400 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-e7b3178473eso4852596276.2 for <77928@debbugs.gnu.org>; Mon, 19 May 2025 22:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1747720300; x=1748325100; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8tUlTmUdOEKk5uh6sZPl1iS7uu+AptiZwMZ1BYN3VoQ=; b=Zo3oZiTO8m1DZ5RvjmMtSCY/R/H+86phYQLJOuQP7oAmp5m4NGAfwcl8/7NUk2Stdb QdUunhmRQSxkkiSupsBH1BxoWjMDO5r7IUSsymAXrMKs/5Sz5hq73gpcrzlIoNELvszs vJroFdffuw+SWS5apMhddH1g0BxNOMVo36O3E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747720300; x=1748325100; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8tUlTmUdOEKk5uh6sZPl1iS7uu+AptiZwMZ1BYN3VoQ=; b=vynlBbzqnTMuulyyFfhSjNFlR6ampKHLEHRqT4mFZI/V8ESPGpBOI3wsf/oVFsAnhC wH0RLrgapLe6f87gUZt7FvvJVA3NrfO5fY9h2h87ghdgWe3aHxydzfNPhNGFAzuNcJSo oa5+XEDyfvQ4qgqlYZicHbiyagk3Ku3zUz9McCcq0lfHW4OG1gLj03MC+vJlk6SBHQMJ M+lmFjaT9E7CmD40i0rOCGj1eDdQOWW6horIGS5rVUawbGcRz6hdpZOsOXOsHnEyjSqZ ujZSKqeeoGqloORLpuouiX34SLaPu4TtoqxUe5Ncu+xR4I0W5mQemtdijfPbmQZXPuwj osAw== X-Forwarded-Encrypted: i=1; AJvYcCWeBcenxStvL+uVpR/Onb+UoFCBiYRycKQdJpWI2QhIENIJerZc0EEYGax61FZh2/JYwKABLQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw1g6B3I2dQ7v8OlPt8ppyx+uogjY3FOZeKDazORTJGAUuMvWyr wddCnX+g6RWI3N42le2hO3Ws4mCU0aN6iNxKV4R4JALQY7L0jhh56vhuQ79V8H9eWrKa2wVwL5o N9bzc+QluZ95ev8CZroEGadbbaBpk0+vvQeKivkTh X-Gm-Gg: ASbGncu09yHt0IOiFeGR9SBM7sh+N/yNR6BUrp2d1VYIScgP7gpzzCVXFLo5j6Tvrg2 Mp57oTqnjI8nN9Z4HN9tLChl418eBFT0n0J5h48fbnFSgvatK+5jSphVS8PCQI+Axu61/4AFi/V Zb6BBby51iCt8sYLgVVXHlGbaHWX20CL/FbtKd+qrnZAsmjLzG8oRXZUOJO8sHE4wkob8= X-Google-Smtp-Source: AGHT+IH5ch+NYmwV04fPOP4XZboJtIP6g/vQhi1KtdLfiO8RXKNY7mDjlIuqCFHKXKYGp3/Rxf7ovB3nMCn5oulTbXE= X-Received: by 2002:a05:690c:39c:b0:6ef:5097:5daa with SMTP id 00721157ae682-70ca7c5437bmr204373167b3.34.1747720300559; Mon, 19 May 2025 22:51:40 -0700 (PDT) MIME-Version: 1.0 References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> In-Reply-To: From: Michael Shields Date: Mon, 19 May 2025 22:51:29 -0700 X-Gm-Features: AX0GCFvrBpFeLyJvHJI81VEp4Gws2yxRphzirEIFtU8U2aoyvA0u7i-YROuC32k Message-ID: Content-Type: multipart/alternative; boundary="000000000000aea07e06358ad7f3" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000aea07e06358ad7f3 Content-Type: text/plain; charset="UTF-8" I think I understand the issue, but not its solution. There are more or less three standard ways to change faces now: Customize, themes, and use-package :custom-face. But there is no clear way to resolve the ordering between them, or whether they replace or inherit at each level. The behavior I was surprised by, and that has been reported previously, is that there was no way to specify a replacement for face settings. But Steven is surprised by the fact that things now happen at a level below theme application, and the theme replaces instead of inherits the defface spec. --000000000000aea07e06358ad7f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I think I understand the issue, but not its solution. Ther= e are more or less three standard ways to change faces now: Customize, them= es, and use-package :custom-face. But there is no clear way to resolve the = ordering between them, or whether they replace or inherit at each level. Th= e behavior I was surprised by, and that has been reported previously, is th= at there was no way to specify a replacement for face settings. But Steven = is surprised by the fact that things now happen at a level below theme appl= ication, and the theme replaces instead of inherits the defface spec.
--000000000000aea07e06358ad7f3-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 May 2025 09:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields , John Wiegley Cc: 77928@debbugs.gnu.org, steven@stebalien.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17480790334163 (code B ref 77928); Sat, 24 May 2025 09:31:01 +0000 Received: (at 77928) by debbugs.gnu.org; 24 May 2025 09:30:33 +0000 Received: from localhost ([127.0.0.1]:57177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIlD6-000155-RE for submit@debbugs.gnu.org; Sat, 24 May 2025 05:30:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45074) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIlD3-00014V-Vs for 77928@debbugs.gnu.org; Sat, 24 May 2025 05:30:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIlCx-0003tA-TJ; Sat, 24 May 2025 05:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UJc7lHR2k0AY8+K07X9ycN8kL16opYI5eNnVi2uQUts=; b=Uvt2Y11StgsD wDhrSXX8fgR8Xkft5BDoKdOhbV9uRVrGutaRdbAugogiYueL6LvJSeMx6/xXUrvoUYv77cuXqfN0a R30/oPB2pYDBLaqqjSGSpIigYuneoDLGcTUUSGpsrT9BuJSjVtZJff5cet5eVS5/xvWsE7HoEK2aT 6GrLQMTbF+ktMDaaxyspCEa2LNvL6aUhIu+K49N89nDzT1RUoaWOFe9KLnrR1BfyB6F0LU+9wYVKH 7+ydEAMCaGgtbN6vWg+ID83W5W7JI9W9rKKOZe0GNfvSL1FfzBBUrHp/UYECVujHHx1rmWNDy1N0m q9nql6kJNrAUvXgQqc0hKA==; Date: Sat, 24 May 2025 12:30:17 +0300 Message-Id: <86ldqm1hli.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Michael Shields on Mon, 19 May 2025 22:51:29 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Shields > Date: Mon, 19 May 2025 22:51:29 -0700 > Cc: steven@stebalien.com, 77928@debbugs.gnu.org > > I think I understand the issue, but not its solution. There are more or less three standard ways to change > faces now: Customize, themes, and use-package :custom-face. But there is no clear way to resolve the > ordering between them, or whether they replace or inherit at each level. The behavior I was surprised by, > and that has been reported previously, is that there was no way to specify a replacement for face settings. > But Steven is surprised by the fact that things now happen at a level below theme application, and the theme > replaces instead of inherits the defface spec. John, could you perhaps help us out here? Bug#77928 was about :custom-face, which is a use-package feature. I don't really understand how this feature is supposed to work, given that use-package produces macros whose effect happens when a package is loaded, and given that other methods of face definition are available. It seems like the original patch installed in this bug fixed one (mis)behavior but introduced another. The documentation of :custom-face in the use-package manual is completely silent regarding its interaction with themes and defface's. Could you perhaps explain the intent of this feature, and what should users expect in the two use cases described in this bug? Thanks. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 May 2025 23:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, Michael Shields , steven@stebalien.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174830064513656 (code B ref 77928); Mon, 26 May 2025 23:05:01 +0000 Received: (at 77928) by debbugs.gnu.org; 26 May 2025 23:04:05 +0000 Received: from localhost ([127.0.0.1]:33333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJgrU-0003YC-Sd for submit@debbugs.gnu.org; Mon, 26 May 2025 19:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47758) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJgrR-0003XV-Hd for 77928@debbugs.gnu.org; Mon, 26 May 2025 19:04:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJgrL-0005l4-Pw; Mon, 26 May 2025 19:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HfkDUPcmuolmAwwvY9CimR7Wzzmy+SFmAQ9yvllgkQI=; b=RGon/7KFJ4V7zUxK9cq2 K8X+1K1yeOHc3dpzmSpC7XqFxm4eahjlbbo6H4z+rYlXQMyMNR81sozxKzJxNPynZmAm1w0qgMVnl S70/+YPV/gYSa95hnrmOFWSP7JSz5EAORcOexXR7HiIqJ74iUS6TmEVTHyKZj3IhhnVNz5Q3mWHBT 8xK5iOkgdaG7Q5DQPOGjvQaQ0N0WFwxJoQo/moL5rcWoPJ4a/oVaCDwKRrcuPmVq9fL5zTJZ57PZI xck/uLZY4p5Wbz3WACwuCRq3B3G9+veuw3pp/vnyuXc/Wz7x6vxHoL8BIrVr75Mrbr1818A5nBY6p LXi28qMw3/Z+gg==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddukeejleculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhff kfgfgggtgfesthhqredttderjeenucfhrhhomheplfhohhhnucghihgvghhlvgihuceojh hohhhnfiesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepiefftdehvdeivddtffef ffffveekledujeeiledtudefheefhffhfeegjeetfeegnecuffhomhgrihhnpehnvgifrg hrthhishgrnhhsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhohhhnfidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthi dqieekjeektdelgeegqddujeejheefkeduiedqjhhohhhnfieppehgnhhurdhorhhgsehn vgifrghrthhishgrnhhsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmth hpohhuthdprhgtphhtthhopeejjeelvdekseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhrtghpthhtohepsh hhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: <86ldqm1hli.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 May 2025 12:30:17 +0300") References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> Date: Mon, 26 May 2025 16:03:51 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: >> From: Michael Shields >> Date: Mon, 19 May 2025 22:51:29 -0700 >> Cc: steven@stebalien.com, 77928@debbugs.gnu.org >>=20 >> I think I understand the issue, but not its solution. There are more or = less three standard ways to change >> faces now: Customize, themes, and use-package :custom-face. But there is= no clear way to resolve the >> ordering between them, or whether they replace or inherit at each level.= The behavior I was surprised by, >> and that has been reported previously, is that there was no way to speci= fy a replacement for face settings. >> But Steven is surprised by the fact that things now happen at a level be= low theme application, and the theme >> replaces instead of inherits the defface spec. > John, could you perhaps help us out here? Bug#77928 was about > :custom-face, which is a use-package feature. I don't really > understand how this feature is supposed to work, given that > use-package produces macros whose effect happens when a package is > loaded, and given that other methods of face definition are available. All that use-package is doing here is expanding the =E2=80=98:custom-face= =E2=80=98 declaration into this call: (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) Should it be calling something other than `face-spec-set' now? --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 May 2025 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley , Eli Zaretskii Cc: 77928@debbugs.gnu.org, Michael Shields Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174830919722908 (code B ref 77928); Tue, 27 May 2025 01:27:02 +0000 Received: (at 77928) by debbugs.gnu.org; 27 May 2025 01:26:37 +0000 Received: from localhost ([127.0.0.1]:34464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJj5Q-0005xQ-M7 for submit@debbugs.gnu.org; Mon, 26 May 2025 21:26:37 -0400 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]:45855) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJj5N-0005x1-4A for 77928@debbugs.gnu.org; Mon, 26 May 2025 21:26:34 -0400 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.stl.internal (Postfix) with ESMTP id 3279D25400D6; Mon, 26 May 2025 21:26:27 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Mon, 26 May 2025 21:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1748309187; x=1748395587; bh=/q/vwyQuYTO1zQu++Bo/wSPH7KrTreyA +LawXGJiwX8=; b=L8ojKGWmv8rs3lUpjbrRKufAba6FFIfvcfzM8mavq3ZmRG8P ZVN9qwtEy0a9iXfG27Lpxt3bT9pQMVsRawwY4O4sDscsZXVBBjI7bWSD6RPNxeUc 4+noo7Ht0vfmYd7gJHDAprYM/CiarfKuVB8FNhj1lZuaA4GoNKTGhwZQO/mZ76cO yhLOhJJIK6XctqBVP1Quta5d8pCa9bxIS/hbCc0qUspjFNHUJbpV+X2bjiFaKmsO 4UQKU5BqiUTvVJtdI7GWExTZsEG9LHgLLQn0od65V/15bI5FwJ0PTjafwyLvQKjJ WprY8ll15XvUblt977kvVHrvN0HzLtK4MTg3qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748309187; x= 1748395587; bh=/q/vwyQuYTO1zQu++Bo/wSPH7KrTreyA+LawXGJiwX8=; b=D HcNqRg3yCJW1D7/u8POiEm8gRQC7tgZUNYWwKNeBQvNJE7p0m16eMFEl9Q5oQecI 3QcMgc9Mae+FH1srzpB2L593g6KqTCi7FsUO/rglKNnzOEJN4gjdvDRBiv7GEdwC a1lsH6DxieRNqm2E+HUGX7jq6iP6L7tN4FyQnHgZJuik4qKQdpFUTCCF7VgKpQrH ksIK6zsffCLJSb+wtRtJvl0/OazuK6G1W0SZqdx+oZnWZecKOewTUtnsyJxzweuQ z1hM0COIs2d2l5rPTzh+9bUbXEE7Tx8iGePJpCobs0d+gZUMgOD8ptMvOd5v8fuR Cpcnipv0HSBFr4U8rKb6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdduledtjeculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhff kfggtgfgsehtqhertddttdejnecuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsth gvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrthhtvghrnhepfedvudeh feeuvdetveetieevjeegtdetgefhlefggeeuheevhfffleeivdetiedunecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgv sggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopehjohhhnhifsehgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehg nhhurdhorhhgpdhrtghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpth htohepjeejledvkeesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 May 2025 21:26:25 -0400 (EDT) From: Steven Allen In-Reply-To: References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> Date: Mon, 26 May 2025 18:26:24 -0700 Message-ID: <87y0uialof.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) John Wiegley writes: >>>>>> Eli Zaretskii writes: > >>> From: Michael Shields >>> Date: Mon, 19 May 2025 22:51:29 -0700 >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org >>>=20 >>> I think I understand the issue, but not its solution. There are more or= less three standard ways to change >>> faces now: Customize, themes, and use-package :custom-face. But there i= s no clear way to resolve the >>> ordering between them, or whether they replace or inherit at each level= . The behavior I was surprised by, >>> and that has been reported previously, is that there was no way to spec= ify a replacement for face settings. >>> But Steven is surprised by the fact that things now happen at a level b= elow theme application, and the theme >>> replaces instead of inherits the defface spec. > >> John, could you perhaps help us out here? Bug#77928 was about >> :custom-face, which is a use-package feature. I don't really >> understand how this feature is supposed to work, given that >> use-package produces macros whose effect happens when a package is >> loaded, and given that other methods of face definition are available. > > All that use-package is doing here is expanding the =E2=80=98:custom-face= =E2=80=98 declaration > into this call: > > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) > > Should it be calling something other than `face-spec-set' now? That's what it used to be before the change in question. Now it expands to: (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) face-d= efface-spec)) The issue here is that the themed face spec has a higher priority than the "defface" spec. IMO, this should be reverted to just: (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) (leaving the part of the patch that marks the face as "modified" intact). >From what I can tell, the patch in question was attempting to solve an issue where overriding faces get "merged" with "lower" priority face specs but, IMO, that isn't really a bug. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 May 2025 11:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174834500314837 (code B ref 77928); Tue, 27 May 2025 11:24:01 +0000 Received: (at 77928) by debbugs.gnu.org; 27 May 2025 11:23:23 +0000 Received: from localhost ([127.0.0.1]:39336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJsOw-0003rE-NY for submit@debbugs.gnu.org; Tue, 27 May 2025 07:23:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54492) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJsOt-0003qe-5T for 77928@debbugs.gnu.org; Tue, 27 May 2025 07:23:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJsOm-0000E8-Ds; Tue, 27 May 2025 07:23:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=goN6GXAchzPbjP7cA6v2dgQ+GgKTo1zlIcQZQLMoCf8=; b=Kh2cnrki022Fl+HmTbSU f5uXCWgxJ8JpnkKe3vWxcbo9dH6Z5/hcdLG798NQpvs7UmS9FUKx48AmOXH7qWiBlCllCslFOEpNj Bbo8oq1pclbAdRt9vODAjp30ws03jwrOWE9YleO+WCtA2To/r/obEIQoVuwnI+Qz1Fp6jr1lBspCO XmegxadMGXvThZTxC1H2tOx5g7eqXHAGAR/B9st5DaJktQlmyPTI0eaPGlQxFIJAd0+lSeYrkjCz+ h/Jjbs26zaENajlDghFTWCttQagOVGOfOBUujAeE7vUfAN2WgknRNBdCM6ED93BFMHr2xHXQ2Vuhn /ktIumkLVNbAlg==; Date: Tue, 27 May 2025 14:23:08 +0300 Message-Id: <86iklmxppf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87y0uialof.fsf@stebalien.com> (message from Steven Allen on Mon, 26 May 2025 18:26:24 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: Michael Shields , 77928@debbugs.gnu.org > Date: Mon, 26 May 2025 18:26:24 -0700 > > John Wiegley writes: > > >>>>>> Eli Zaretskii writes: > > > >>> From: Michael Shields > >>> Date: Mon, 19 May 2025 22:51:29 -0700 > >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org > >>> > >>> I think I understand the issue, but not its solution. There are more or less three standard ways to change > >>> faces now: Customize, themes, and use-package :custom-face. But there is no clear way to resolve the > >>> ordering between them, or whether they replace or inherit at each level. The behavior I was surprised by, > >>> and that has been reported previously, is that there was no way to specify a replacement for face settings. > >>> But Steven is surprised by the fact that things now happen at a level below theme application, and the theme > >>> replaces instead of inherits the defface spec. > > > >> John, could you perhaps help us out here? Bug#77928 was about > >> :custom-face, which is a use-package feature. I don't really > >> understand how this feature is supposed to work, given that > >> use-package produces macros whose effect happens when a package is > >> loaded, and given that other methods of face definition are available. > > > > All that use-package is doing here is expanding the ‘:custom-face‘ declaration > > into this call: > > > > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) > > > > Should it be calling something other than `face-spec-set' now? > > That's what it used to be before the change in question. Now it expands > to: > > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) face-defface-spec)) > > The issue here is that the themed face spec has a higher priority than > the "defface" spec. But AFAIU, face-defface-spec records the theme customizations of the face as well, no? I'm afraid I don't quite understand what you are saying here, could you please explain and elaborate? > IMO, this should be reverted to just: > > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) > > (leaving the part of the patch that marks the face as "modified" intact). > > >From what I can tell, the patch in question was attempting to solve an > issue where overriding faces get "merged" with "lower" priority face > specs but, IMO, that isn't really a bug. Why don't you consider that a bug? From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 May 2025 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174836392030891 (code B ref 77928); Tue, 27 May 2025 16:39:01 +0000 Received: (at 77928) by debbugs.gnu.org; 27 May 2025 16:38:40 +0000 Received: from localhost ([127.0.0.1]:43121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJxK3-000824-FA for submit@debbugs.gnu.org; Tue, 27 May 2025 12:38:40 -0400 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]:57493) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJxK0-00081b-IP for 77928@debbugs.gnu.org; Tue, 27 May 2025 12:38:37 -0400 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.stl.internal (Postfix) with ESMTP id C2BB81140128; Tue, 27 May 2025 12:38:30 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 27 May 2025 12:38:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1748363910; x=1748450310; bh=WSPuDLBPtLHsWZt82eXmg5c0Bu3QC2+V 7Zkxeg2mpmQ=; b=beK9ZXFjHbcX9D5llQohTp++xgQfHnwWDiTUrn/O0o4i3uBW oJAe3/RtMOTmKhasuoH2ms5sBu7U4wMUbss5B8Oyvc8oapa0OQ4VLCBMAMuzE/pn TM0D1BsHy3IdElU3rl04POUVNTQRhH199g9N7gi7QiwhmFCBSKWmhkOLsWCGdk5n VNexapoy4T7yjnAPRRTYEda7TED+IJKFFYG3e6SkdHpMj0WHTcrc3Kg3IyQ0EYKx Dv5aMqcOu/Ic48KypbZnUaOBPxE4cyvj1FlLFccHy5ynXy7CFDHJL0PVyarx+5Xm wx8sBjBAB2+ALb+ACRhDrGGjeXSTkrN5LWuX2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748363910; x= 1748450310; bh=WSPuDLBPtLHsWZt82eXmg5c0Bu3QC2+V7Zkxeg2mpmQ=; b=n QflSESSAzRuIABw9uKxM91UCx65vblCrTZg+o35qpdJJ4AVX7jtFpNzWstflwTS1 Kz2rt/eI6ShgDiSUZhZr9ZOCsKh+w29Oe2LqwCafOmKivSXCc25E4oz8lhYXaffp +2cp9KUH0/7mV5l+pYqAUdYndn5D0P+F1vOmp2MbylLnZlaRlzoMc8Eto1Y5TU8p DLCcy9h2SATDMQ5UCrydyrqP/mlJVoS5OL7fiQDu0bghp59o2v07QpQP8a2EL3yG N5Zy4V2y1lNuk2j85+c/dfziCd8ETNES2GuxTFrItG3BkjKVAG2sr8L6MxQaI3zC 62uvWyefUt1mTiF5K9agQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvtdekkeculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhff kfggtgfgsehtqhertddttdejnecuhfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsth gvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrthhtvghrnhepfedvudeh feeuvdetveetieevjeegtdetgefhlefggeeuheevhfffleeivdetiedunecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgv sggrlhhivghnrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuth dprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopehjohhhnhifsehg nhhurdhorhhgpdhrtghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpth htohepjeejledvkeesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 May 2025 12:38:29 -0400 (EDT) From: Steven Allen In-Reply-To: <86iklmxppf.fsf@gnu.org> References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> Date: Tue, 27 May 2025 09:38:28 -0700 Message-ID: <87msayc8l7.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Steven Allen >> Cc: Michael Shields , 77928@debbugs.gnu.org >> Date: Mon, 26 May 2025 18:26:24 -0700 >> >> John Wiegley writes: >> >> >>>>>> Eli Zaretskii writes: >> > >> >>> From: Michael Shields >> >>> Date: Mon, 19 May 2025 22:51:29 -0700 >> >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org >> >>> >> >>> I think I understand the issue, but not its solution. There are more= or less three standard ways to change >> >>> faces now: Customize, themes, and use-package :custom-face. But ther= e is no clear way to resolve the >> >>> ordering between them, or whether they replace or inherit at each le= vel. The behavior I was surprised by, >> >>> and that has been reported previously, is that there was no way to s= pecify a replacement for face settings. >> >>> But Steven is surprised by the fact that things now happen at a leve= l below theme application, and the theme >> >>> replaces instead of inherits the defface spec. >> > >> >> John, could you perhaps help us out here? Bug#77928 was about >> >> :custom-face, which is a use-package feature. I don't really >> >> understand how this feature is supposed to work, given that >> >> use-package produces macros whose effect happens when a package is >> >> loaded, and given that other methods of face definition are available. >> > >> > All that use-package is doing here is expanding the =E2=80=98:custom-f= ace=E2=80=98 declaration >> > into this call: >> > >> > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> > >> > Should it be calling something other than `face-spec-set' now? >> >> That's what it used to be before the change in question. Now it expands >> to: >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) fac= e-defface-spec)) >> >> The issue here is that the themed face spec has a higher priority than >> the "defface" spec. > > But AFAIU, face-defface-spec records the theme customizations of the > face as well, no? I'm afraid I don't quite understand what you are > saying here, could you please explain and elaborate? face-defface-spec is only used when declaring faces, not when customizing/theming them. The theme-face property is used to store the themed face, customized-face is used to store customizations through the "custom" system, and face-override-spec is used otherwise. You can look at a face's plist to get a better idea of how this works: (symbol-plist 'default) Also look at the documentation for facep-spec-recalc: theme and/or user customizations override the "defface" spec, causing the bug I'm seeing here. >> IMO, this should be reverted to just: >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> >> (leaving the part of the patch that marks the face as "modified" intact). >> >> >From what I can tell, the patch in question was attempting to solve an >> issue where overriding faces get "merged" with "lower" priority face >> specs but, IMO, that isn't really a bug. > > Why don't you consider that a bug? That's how face customization works. E.g.: (custom-set-faces '(font-lock-keyword-face ((t :italic t)) t)) Will make keywords italic but won't override the theme/defaults unless requested. E.g.: (custom-set-faces '(font-lock-keyword-face ((t :italic t :foreground unspecified)) t)) Will "unset" the foreground (it'll inherit from the face's parent). And: (custom-set-faces '(font-lock-keyword-face ((t :italic t :foreground reset)) t)) Will "reset" the foreground to the default face's foreground. This makes it possible to compose/modify faces without completely overriding them. E.g., if you want a specific face to be bold/italic but otherwise want the underlying theme to apply. This makes it possible to, e.g., customize certain aspects of faces across themes. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 May 2025 11:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174843064827608 (code B ref 77928); Wed, 28 May 2025 11:11:03 +0000 Received: (at 77928) by debbugs.gnu.org; 28 May 2025 11:10:48 +0000 Received: from localhost ([127.0.0.1]:51428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKEgJ-0007BC-W0 for submit@debbugs.gnu.org; Wed, 28 May 2025 07:10:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58498) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKEgI-0007Ae-4s for 77928@debbugs.gnu.org; Wed, 28 May 2025 07:10:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKEgB-0002AI-TF; Wed, 28 May 2025 07:10:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3/mPVPUlh6apJtBTlz4RFdK+NWvQ2h2p6an1ipHAlXM=; b=DdBgOWljcvBael6Trr8s GstQY2J+1dGNvPpyzgGSe+buITK4mdmQzf59Kf15qXvVEaee9zoEdjolDu8RF+JbE3CbDALXqNLc6 zLgA2Q8xNKsSBEo8HI78aBcc6v/BaXIc89SLMdQvF411ABRx0KJ7zmHJ87vKkyq4fw0rtf3KD+D3e DXQsIIBhEf8KVTq22kR2TiLgObktfctbTJ8dtCKdYmzZqBLUBAdUfqTgRi+dn2+WfnR7bkwBfmTJL sQfSIDxqZ3K16CZmsZ27MkrLyLbxNystUPj7/QDIOjh+hOCztClwoCtCeTcl4F9b/VOMuiTbiLZ3Q PTHtza3mABQVDg==; Date: Wed, 28 May 2025 14:10:37 +0300 Message-Id: <86v7plvvma.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87msayc8l7.fsf@stebalien.com> (message from Steven Allen on Tue, 27 May 2025 09:38:28 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org > Date: Tue, 27 May 2025 09:38:28 -0700 > > Eli Zaretskii writes: > > >> From: Steven Allen > >> Cc: Michael Shields , 77928@debbugs.gnu.org > >> Date: Mon, 26 May 2025 18:26:24 -0700 > >> > >> John Wiegley writes: > >> > >> >>>>>> Eli Zaretskii writes: > >> > > >> >>> From: Michael Shields > >> >>> Date: Mon, 19 May 2025 22:51:29 -0700 > >> >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org > >> >>> > >> >>> I think I understand the issue, but not its solution. There are more or less three standard ways to change > >> >>> faces now: Customize, themes, and use-package :custom-face. But there is no clear way to resolve the > >> >>> ordering between them, or whether they replace or inherit at each level. The behavior I was surprised by, > >> >>> and that has been reported previously, is that there was no way to specify a replacement for face settings. > >> >>> But Steven is surprised by the fact that things now happen at a level below theme application, and the theme > >> >>> replaces instead of inherits the defface spec. > >> > > >> >> John, could you perhaps help us out here? Bug#77928 was about > >> >> :custom-face, which is a use-package feature. I don't really > >> >> understand how this feature is supposed to work, given that > >> >> use-package produces macros whose effect happens when a package is > >> >> loaded, and given that other methods of face definition are available. > >> > > >> > All that use-package is doing here is expanding the ‘:custom-face‘ declaration > >> > into this call: > >> > > >> > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) > >> > > >> > Should it be calling something other than `face-spec-set' now? > >> > >> That's what it used to be before the change in question. Now it expands > >> to: > >> > >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) face-defface-spec)) > >> > >> The issue here is that the themed face spec has a higher priority than > >> the "defface" spec. > > > > But AFAIU, face-defface-spec records the theme customizations of the > > face as well, no? I'm afraid I don't quite understand what you are > > saying here, could you please explain and elaborate? > > face-defface-spec is only used when declaring faces, not when > customizing/theming them. The theme-face property is used to store the > themed face, customized-face is used to store customizations through the > "custom" system, and face-override-spec is used otherwise. > > You can look at a face's plist to get a better idea of how this works: > > (symbol-plist 'default) > > Also look at the documentation for facep-spec-recalc: theme and/or user > customizations override the "defface" spec, causing the bug I'm seeing here. > > >> IMO, this should be reverted to just: > >> > >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) > >> > >> (leaving the part of the patch that marks the face as "modified" intact). > >> > >> >From what I can tell, the patch in question was attempting to solve an > >> issue where overriding faces get "merged" with "lower" priority face > >> specs but, IMO, that isn't really a bug. > > > > Why don't you consider that a bug? > > That's how face customization works. E.g.: > > (custom-set-faces '(font-lock-keyword-face ((t :italic t)) t)) > > Will make keywords italic but won't override the theme/defaults unless > requested. E.g.: > > (custom-set-faces > '(font-lock-keyword-face ((t :italic t :foreground unspecified)) t)) > > Will "unset" the foreground (it'll inherit from the face's parent). And: > > (custom-set-faces > '(font-lock-keyword-face ((t :italic t :foreground reset)) t)) > > Will "reset" the foreground to the default face's foreground. > > This makes it possible to compose/modify faces without completely > overriding them. E.g., if you want a specific face to be bold/italic but > otherwise want the underlying theme to apply. This makes it possible to, > e.g., customize certain aspects of faces across themes. Thanks. Unfortunately, what you say above seems to assume the level of detailed knowledge in themes, use-package, and their interactions with Customize that I don't have. I think I know how faces work and how face merging works, but after reading your explanations and examples several times I'm sorry to say that I'm utterly confused by what you say and don't have any clear idea about the problem, its consequences, and your analysis of the original issue and its fix. So either someone explains this to me in terms I can understand and reason about, or we will need to wait for someone more knowledgeable in this stuff to pick up the gauntlet. Alternatively, if you convince John and Michael that the changes you think should be done are indeed the way to go, I will gladly delegate the decision to you three. Sorry I couldn't be of more help. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 May 2025 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, Steven Allen , shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174845167626978 (code B ref 77928); Wed, 28 May 2025 17:02:02 +0000 Received: (at 77928) by debbugs.gnu.org; 28 May 2025 17:01:16 +0000 Received: from localhost ([127.0.0.1]:55752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKK9U-000714-3p for submit@debbugs.gnu.org; Wed, 28 May 2025 13:01:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54780) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKK9Q-00070K-P8 for 77928@debbugs.gnu.org; Wed, 28 May 2025 13:01:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uKK9K-0001NE-Ty; Wed, 28 May 2025 13:01:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=5sI0X17hJU1ZuzYK/z5YZfI/DksWYfJDMruATG4kM9g=; b=E2JD/yvp3BblxSoZY9nI WU3HFO0QplvPvfg1Fb5Z4Xy3Qvk0/Bkne2pJwnmmoAS/pR9EujUT9lcA6iTyK9ErD5syvU7oIljEf Z2VnreUvqSMMKj0frHQeAD3ac0ov81oQPRwegcSsWEcVpm/3r2vtj8cy/cnBAbn0a0zXqQxqECHmt ip1CwfdDD06iESN6bkHZXa9ANiTfOwiu1+yLrIr5eDF29QGIZUBkg6KXSzJzh5VnbZ1jDu1f5Un1N IekQCxEzrSKoRoY1pYTaXi1un/3c9Rs70UPEZakJgrllbnbd67YgaDbkm/+jOeDM30khK3bZPCZ1r Fgcc7M9BgLyLqw==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfeekudculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjfhff kfgfgggtgfesthhqredttderjeenucfhrhhomheplfhohhhnucghihgvghhlvgihuceojh hohhhnfiesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepiefftdehvdeivddtffef ffffveekledujeeiledtudefheefhffhfeegjeetfeegnecuffhomhgrihhnpehnvgifrg hrthhishgrnhhsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhohhhnfidomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthi dqieekjeektdelgeegqddujeejheefkeduiedqjhhohhhnfieppehgnhhurdhorhhgsehn vgifrghrthhishgrnhhsrdgtohhmpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmth hpohhuthdprhgtphhtthhopeejjeelvdekseguvggssghughhsrdhgnhhurdhorhhgpdhr tghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpthhtohepshhtvghvvg hnsehsthgvsggrlhhivghnrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: <86v7plvvma.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 May 2025 14:10:37 +0300") References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> Date: Wed, 28 May 2025 10:01:03 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: > So either someone explains this to me in terms I can understand and reason > about, or we will need to wait for someone more knowledgeable in this stu= ff > to pick up the gauntlet. > Alternatively, if you convince John and Michael that the changes you think > should be done are indeed the way to go, I will gladly delegate the decis= ion > to you three. I=E2=80=99m not an expert in face customization either, so I really can=E2= =80=99t weigh in on the merits of this change. I=E2=80=99d love a deep explanation also! --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 May 2025 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 77928@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17486294446691 (code B ref -1); Fri, 30 May 2025 18:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 May 2025 18:24:04 +0000 Received: from localhost ([127.0.0.1]:50604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uL4Oe-0001jT-2F for submit@debbugs.gnu.org; Fri, 30 May 2025 14:24:04 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52864) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uL4Ob-0001j6-1Q for submit@debbugs.gnu.org; Fri, 30 May 2025 14:23:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uL4OV-000380-67 for bug-gnu-emacs@gnu.org; Fri, 30 May 2025 14:23:51 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uL4OS-0000UN-HG for bug-gnu-emacs@gnu.org; Fri, 30 May 2025 14:23:49 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1uL4OP-0007z6-LF for bug-gnu-emacs@gnu.org; Fri, 30 May 2025 20:23:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Andy Moreton Date: Fri, 30 May 2025 19:23:38 +0100 Message-ID: <86r006rm8l.fsf@gmail.com> References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:yUyRngEJU7ADcrCwhPscjpfSVrg= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed 28 May 2025, Eli Zaretskii wrote: >> From: Steven Allen >> Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org >> Date: Tue, 27 May 2025 09:38:28 -0700 >> >> Eli Zaretskii writes: >> >> >> From: Steven Allen >> >> Cc: Michael Shields , 77928@debbugs.gnu.org >> >> Date: Mon, 26 May 2025 18:26:24 -0700 >> >> >> >> John Wiegley writes: >> >> >> >> >>>>>> Eli Zaretskii writes: >> >> > >> >> >>> From: Michael Shields >> >> >>> Date: Mon, 19 May 2025 22:51:29 -0700 >> >> >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org >> >> >>> >> >> >>> I think I understand the issue, but not its solution. There are more or less three standard ways to change >> >> >>> faces now: Customize, themes, and use-package :custom-face. But there is no clear way to resolve the >> >> >>> ordering between them, or whether they replace or inherit at each level. The behavior I was surprised by, >> >> >>> and that has been reported previously, is that there was no way to specify a replacement for face settings. >> >> >>> But Steven is surprised by the fact that things now happen at a level below theme application, and the theme >> >> >>> replaces instead of inherits the defface spec. >> >> > >> >> >> John, could you perhaps help us out here? Bug#77928 was about >> >> >> :custom-face, which is a use-package feature. I don't really >> >> >> understand how this feature is supposed to work, given that >> >> >> use-package produces macros whose effect happens when a package is >> >> >> loaded, and given that other methods of face definition are available. >> >> > >> >> > All that use-package is doing here is expanding the :custom-face declaration >> >> > into this call: >> >> > >> >> > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> >> > >> >> > Should it be calling something other than `face-spec-set' now? >> >> >> >> That's what it used to be before the change in question. Now it expands >> >> to: >> >> >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) face-defface-spec)) >> >> >> >> The issue here is that the themed face spec has a higher priority than >> >> the "defface" spec. >> > >> > But AFAIU, face-defface-spec records the theme customizations of the >> > face as well, no? I'm afraid I don't quite understand what you are >> > saying here, could you please explain and elaborate? >> >> face-defface-spec is only used when declaring faces, not when >> customizing/theming them. The theme-face property is used to store the >> themed face, customized-face is used to store customizations through the >> "custom" system, and face-override-spec is used otherwise. >> >> You can look at a face's plist to get a better idea of how this works: >> >> (symbol-plist 'default) >> >> Also look at the documentation for facep-spec-recalc: theme and/or user >> customizations override the "defface" spec, causing the bug I'm seeing here. >> >> >> IMO, this should be reverted to just: >> >> >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> >> >> >> (leaving the part of the patch that marks the face as "modified" intact). >> >> >> >> >From what I can tell, the patch in question was attempting to solve an >> >> issue where overriding faces get "merged" with "lower" priority face >> >> specs but, IMO, that isn't really a bug. >> > >> > Why don't you consider that a bug? >> >> That's how face customization works. E.g.: >> >> (custom-set-faces '(font-lock-keyword-face ((t :italic t)) t)) >> >> Will make keywords italic but won't override the theme/defaults unless >> requested. E.g.: >> >> (custom-set-faces >> '(font-lock-keyword-face ((t :italic t :foreground unspecified)) t)) >> >> Will "unset" the foreground (it'll inherit from the face's parent). And: >> >> (custom-set-faces >> '(font-lock-keyword-face ((t :italic t :foreground reset)) t)) >> >> Will "reset" the foreground to the default face's foreground. >> >> This makes it possible to compose/modify faces without completely >> overriding them. E.g., if you want a specific face to be bold/italic but >> otherwise want the underlying theme to apply. This makes it possible to, >> e.g., customize certain aspects of faces across themes. > > Thanks. > > Unfortunately, what you say above seems to assume the level of > detailed knowledge in themes, use-package, and their interactions with > Customize that I don't have. I think I know how faces work and how > face merging works, but after reading your explanations and examples > several times I'm sorry to say that I'm utterly confused by what you > say and don't have any clear idea about the problem, its consequences, > and your analysis of the original issue and its fix. > > So either someone explains this to me in terms I can understand and > reason about, or we will need to wait for someone more knowledgeable > in this stuff to pick up the gauntlet. > > Alternatively, if you convince John and Michael that the changes you > think should be done are indeed the way to go, I will gladly delegate > the decision to you three. > > Sorry I couldn't be of more help. I'm not at all expert, but this effect is easily reproducible. Using the mingw64 build on Windows: a) build from master, and start with "runemacs.exe -Q" b) in the scratch buffer, evaluate: (use-package faces :custom-face (default ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85"))) (variable-pitch ((((class color)) :font "Liberation Sans-10"))) ) c) Display a tooltip e.g. from moving the mouse over the major mode indicator on the modeline. The tooltip is shown using a monospaced font, even though the tooltip face inherits from variable-pitch. d) "M-x describe-face RET tooltip RET" shows the tooltip face as expected, with the sample text in a variable pitch font. e) Repeat all steps, but instead of (b), evaluate: (use-package faces :init (apply #'face-spec-set '(variable-pitch ((((class color)) :font "Liberation Sans-11")))) :custom-face (default ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85"))) ) That produces the expected variable pitch font for the tooltip. Thus this is not working properly, even without interaction with themes. AndyM From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 May 2025 06:45:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andy Moreton Cc: 77928@debbugs.gnu.org, Steven Allen , shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17486738781409 (code B ref 77928); Sat, 31 May 2025 06:45:03 +0000 Received: (at 77928) by debbugs.gnu.org; 31 May 2025 06:44:38 +0000 Received: from localhost ([127.0.0.1]:54765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uLFxL-0000MG-3V for submit@debbugs.gnu.org; Sat, 31 May 2025 02:44:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57194) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uLFxI-0000Kp-5K for 77928@debbugs.gnu.org; Sat, 31 May 2025 02:44:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLFxC-0002NC-11; Sat, 31 May 2025 02:44:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KCD5TsUEeCKuuGz69dveQ8p4+9XOMa6ckelXHjJlZnw=; b=K/1b3hZ717s9 mHPX0utzzf2XccnKoPtdjBXj2lsDl8au9TXNRsvi20y3mkhp7r5HjnDyFQyZMVVazOrc58PqYKIwh FxdbAhCQjxA55ei8vTIcYJFxXviWtT6CcdCThBi+Fo9UCeK9EKKBgzbFgj2SolA2bWo2o/1SKt+yg Eh0O8/qWWcdNYzj53pq5muwhURbysCtgjp0dg8voaEVgIziDF6ZXf9r83KftgdeuW/atx/nZshsgj qsFVe2U4xZVHnsjSmPy7ZCgh6RLyW0soHAaw4vBWODiqQL2ApE9OQez6CKJWJnsrT25NuuXofKD3F CtJyyLb9GBlKxSGO6oHzCw==; Date: Sat, 31 May 2025 09:44:23 +0300 Message-Id: <8634clth2w.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86r006rm8l.fsf@gmail.com> (message from Andy Moreton on Fri, 30 May 2025 19:23:38 +0100) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <86r006rm8l.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andy Moreton > Date: Fri, 30 May 2025 19:23:38 +0100 > > On Wed 28 May 2025, Eli Zaretskii wrote: > > > Unfortunately, what you say above seems to assume the level of > > detailed knowledge in themes, use-package, and their interactions with > > Customize that I don't have. I think I know how faces work and how > > face merging works, but after reading your explanations and examples > > several times I'm sorry to say that I'm utterly confused by what you > > say and don't have any clear idea about the problem, its consequences, > > and your analysis of the original issue and its fix. > > > > So either someone explains this to me in terms I can understand and > > reason about, or we will need to wait for someone more knowledgeable > > in this stuff to pick up the gauntlet. > > > > Alternatively, if you convince John and Michael that the changes you > > think should be done are indeed the way to go, I will gladly delegate > > the decision to you three. > > > > Sorry I couldn't be of more help. > > I'm not at all expert, but this effect is easily reproducible. > Using the mingw64 build on Windows: > > a) build from master, and start with "runemacs.exe -Q" > b) in the scratch buffer, evaluate: > (use-package faces > :custom-face > (default > ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85"))) > (variable-pitch > ((((class color)) :font "Liberation Sans-10"))) ) > > c) Display a tooltip e.g. from moving the mouse over the major mode > indicator on the modeline. The tooltip is shown using a monospaced > font, even though the tooltip face inherits from variable-pitch. > > d) "M-x describe-face RET tooltip RET" shows the tooltip face as > expected, with the sample text in a variable pitch font. > > e) Repeat all steps, but instead of (b), evaluate: > (use-package faces > :init > (apply #'face-spec-set > '(variable-pitch > ((((class color)) :font "Liberation Sans-11")))) > :custom-face > (default > ((((class color)) :font "DejaVu Sans Mono-9" :background "gray85"))) > ) > > That produces the expected variable pitch font for the tooltip. > > > Thus this is not working properly, even without interaction with themes. Thanks. Unfortunately, I'm not a bit wiser after reading your recipe for several times (I don't have the Liberation Sans font here to fully reproduce it). You are showing the results using use-package, which I don't use and know very little about, and John did agree with the original patch back when it was proposed. So I'm still unable to decide what to do with this, because I don't understands well enough what is going on and what is being claimed. But maybe someone else of the participants (whom you elided, and I added back now) could understand better what you said, and explain it or suggest a solution. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Jun 2025 19:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174906404516419 (code B ref 77928); Wed, 04 Jun 2025 19:08:02 +0000 Received: (at 77928) by debbugs.gnu.org; 4 Jun 2025 19:07:25 +0000 Received: from localhost ([127.0.0.1]:52627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uMtSN-0004Gb-IY for submit@debbugs.gnu.org; Wed, 04 Jun 2025 15:07:24 -0400 Received: from fhigh-b4-smtp.messagingengine.com ([202.12.124.155]:45429) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uMtSL-0004Fy-GO for 77928@debbugs.gnu.org; Wed, 04 Jun 2025 15:07:22 -0400 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id A704A254012D; Wed, 4 Jun 2025 15:07:15 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Wed, 04 Jun 2025 15:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1749064035; x=1749150435; bh=o7MrzXcTeeHIrD1Gf9FUqBWz3KoEs5Wc MF39DjN+8Ts=; b=pLNLA/4HBjOd8/nHuhho+3J5bc/ML4p3u2Ly7F/Svagnh9zu 3B1IyW0hKTvXjhUe8U1x0LAyGXLVIsDXdwWIEHAk6aRs7cKNM5oEVofXxVESr5n0 xORbhbI/vgYLRQ60qRbbBoNnsW4g2g6gpEtnE3cYv3DAak3z9xnpQ0kKhOMFa5mg LhgN46xC7h7R8SQjM07Ivi/ZPDcjmPeQ0XFnjH5Wcm4Bqk9/LpI2rbyreulL4T15 YoLmQk+pVuCqOoFmMF1SzGMnDvFd6xR6KlcW4WCZ03eaiAtnRB1y1RFahwJU8HNx AWlUncMrJsQ23iKO+cECOn16/DkPqHaNiLGRZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1749064035; x= 1749150435; bh=o7MrzXcTeeHIrD1Gf9FUqBWz3KoEs5WcMF39DjN+8Ts=; b=B ZirQKygjcLsPaEDqF1Vop/zdnvWkXet+FwO+sERnTNNNCYxPepDBaYksHjKAxjlS ZxK/VebD716l+nKJi8gLPy+Yud1qJ3gFi8b0zCii2a/Gv7vlSE7UnqiOZpUf1RO5 jxDXnUUzbBLr6t850KYl+5g3p3x41Zi+PWiO8Y9QEJGFydZ4695S9Wno8nop2lDH ewhUv0pXrW1xVd5Cmx7c7revT9pUZgnHdfKHTuhyz5B+Kiu1c/0VehdtaDSU+RBq GHOYr1Juayyz3Y0h2mR/jmpf4NRJFyzsisnRDaas/WQLK0knbPBqy36J0pEjzdPU rjEZG3ceuNUjRBzI4lBPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugddvheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtgfesthhqredttddtjeen ucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivg hnrdgtohhmqeenucggtffrrghtthgvrhhnpeefvdduheefuedvteevteeiveejgedtteeg hfelgfegueehvefhffeliedvteeiudenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgs pghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepvghlihiise hgnhhurdhorhhgpdhrtghpthhtohepjhhohhhnfiesghhnuhdrohhrghdprhgtphhtthho pehshhhivghlughssehmshhrlhdrtghomhdprhgtphhtthhopeejjeelvdekseguvggssg hughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Jun 2025 15:07:14 -0400 (EDT) From: Steven Allen In-Reply-To: <86v7plvvma.fsf@gnu.org> References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> Date: Wed, 04 Jun 2025 12:07:12 -0700 Message-ID: <875xhbgwbj.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Steven Allen >> Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org >> Date: Tue, 27 May 2025 09:38:28 -0700 >> >> Eli Zaretskii writes: >> >> >> From: Steven Allen >> >> Cc: Michael Shields , 77928@debbugs.gnu.org >> >> Date: Mon, 26 May 2025 18:26:24 -0700 >> >> >> >> John Wiegley writes: >> >> >> >> >>>>>> Eli Zaretskii writes: >> >> > >> >> >>> From: Michael Shields >> >> >>> Date: Mon, 19 May 2025 22:51:29 -0700 >> >> >>> Cc: steven@stebalien.com, 77928@debbugs.gnu.org >> >> >>> >> >> >>> I think I understand the issue, but not its solution. There are m= ore or less three standard ways to change >> >> >>> faces now: Customize, themes, and use-package :custom-face. But t= here is no clear way to resolve the >> >> >>> ordering between them, or whether they replace or inherit at each= level. The behavior I was surprised by, >> >> >>> and that has been reported previously, is that there was no way t= o specify a replacement for face settings. >> >> >>> But Steven is surprised by the fact that things now happen at a l= evel below theme application, and the theme >> >> >>> replaces instead of inherits the defface spec. >> >> > >> >> >> John, could you perhaps help us out here? Bug#77928 was about >> >> >> :custom-face, which is a use-package feature. I don't really >> >> >> understand how this feature is supposed to work, given that >> >> >> use-package produces macros whose effect happens when a package is >> >> >> loaded, and given that other methods of face definition are availa= ble. >> >> > >> >> > All that use-package is doing here is expanding the =E2=80=98:custo= m-face=E2=80=98 declaration >> >> > into this call: >> >> > >> >> > (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> >> > >> >> > Should it be calling something other than `face-spec-set' now? >> >> >> >> That's what it used to be before the change in question. Now it expan= ds >> >> to: >> >> >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)) = face-defface-spec)) >> >> >> >> The issue here is that the themed face spec has a higher priority than >> >> the "defface" spec. >> > >> > But AFAIU, face-defface-spec records the theme customizations of the >> > face as well, no? I'm afraid I don't quite understand what you are >> > saying here, could you please explain and elaborate? >> >> face-defface-spec is only used when declaring faces, not when >> customizing/theming them. The theme-face property is used to store the >> themed face, customized-face is used to store customizations through the >> "custom" system, and face-override-spec is used otherwise. >> >> You can look at a face's plist to get a better idea of how this works: >> >> (symbol-plist 'default) >> >> Also look at the documentation for facep-spec-recalc: theme and/or user >> customizations override the "defface" spec, causing the bug I'm seeing h= ere. >> >> >> IMO, this should be reverted to just: >> >> >> >> (apply #'face-spec-set '(font-lock-keyword-face ((t :italic t)))) >> >> >> >> (leaving the part of the patch that marks the face as "modified" inta= ct). >> >> >> >> >From what I can tell, the patch in question was attempting to solve = an >> >> issue where overriding faces get "merged" with "lower" priority face >> >> specs but, IMO, that isn't really a bug. >> > >> > Why don't you consider that a bug? >> >> That's how face customization works. E.g.: >> >> (custom-set-faces '(font-lock-keyword-face ((t :italic t)) t)) >> >> Will make keywords italic but won't override the theme/defaults unless >> requested. E.g.: >> >> (custom-set-faces >> '(font-lock-keyword-face ((t :italic t :foreground unspecified)) t= )) >> >> Will "unset" the foreground (it'll inherit from the face's parent). And: >> >> (custom-set-faces >> '(font-lock-keyword-face ((t :italic t :foreground reset)) t)) >> >> Will "reset" the foreground to the default face's foreground. >> >> This makes it possible to compose/modify faces without completely >> overriding them. E.g., if you want a specific face to be bold/italic but >> otherwise want the underlying theme to apply. This makes it possible to, >> e.g., customize certain aspects of faces across themes. > > Thanks. > > Unfortunately, what you say above seems to assume the level of > detailed knowledge in themes, use-package, and their interactions with > Customize that I don't have. I think I know how faces work and how > face merging works, but after reading your explanations and examples > several times I'm sorry to say that I'm utterly confused by what you > say and don't have any clear idea about the problem, its consequences, > and your analysis of the original issue and its fix. > > So either someone explains this to me in terms I can understand and > reason about, or we will need to wait for someone more knowledgeable > in this stuff to pick up the gauntlet. > > Alternatively, if you convince John and Michael that the changes you > think should be done are indeed the way to go, I will gladly delegate > the decision to you three. > > Sorry I couldn't be of more help. Unfortunately, my understanding is also very limited. Instead of trying to explain the code (which I barely understand) I'll focus on explaining the symptoms and my expectations. There are two parts to this report: 1. Bug: use-package's ":custom-face" no longer overrides themed faces. 2. Opinion: ":custom-face" SHOULD merge the user-specified face spec with the underlying face spec (contrary to the original report). **First Part (the clear bug)** Before the commit in question, the :custom-face use-package keyword (effectively=E2=80=A0) expanded to: (face-spec-set face spec) Now, it (effectively=E2=80=A1) expands to: (face-spec-set face spec 'face-defface-spec) This is a problem because this new code sets the DEFAULT spec for the face while themes override the default spec. This means user customizations via ":custom-face" fail to override the theme. =E2=80=A0 Technically, it used to expand to (where "def" is `(FACE SPEC)'): (apply #'face-spec-set (backquote ,def)) =E2=80=A1 Technically, it now expands to: (progn (apply #'face-spec-set (append (backquote ,def) '(face-defface-spec)= )) (put ',(car def) 'face-modified t)) **Second Part** IMO, :custom-face SHOULD behave like "custom-set-faces". Faces specs applied via "custom-set-faces" are MERGED with the underlying face (as use-package's ":custom-face" used to do behave). You can test this behavior by opening any syntax-highlighted code and evaluating: (custom-set-faces '(font-lock-keyword-face ((t :italic t)) t)) All keywords will be made italic but will otherwise retain their coloring. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jun 2025 09:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174928976314038 (code B ref 77928); Sat, 07 Jun 2025 09:50:01 +0000 Received: (at 77928) by debbugs.gnu.org; 7 Jun 2025 09:49:23 +0000 Received: from localhost ([127.0.0.1]:46980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uNqB1-0003eM-9a for submit@debbugs.gnu.org; Sat, 07 Jun 2025 05:49:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55710) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uNqAz-0003e6-1h for 77928@debbugs.gnu.org; Sat, 07 Jun 2025 05:49:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNqAt-0003fG-0z; Sat, 07 Jun 2025 05:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=X1641dOh4mLL/Iva98I6j3iSE9wcDxbxPV4SnfrUyw8=; b=lPrlL7gQvKMK eWR+hpaWfVvgji2sT+sEDy6aGAnqXdHoUxxcKEQIs6hju0V0zrvZJsuUTenN+Z/E9qnlRaM+f08oB ounJW8Vt7QDEnypb/2HDXu1GTHLtgTDeEWjkgkqqqlDRS/DVODqXv41EnjcGgkfwVDsyX6izpAMeS JP3XIy5MYnmBFR7PWsVVrq/o/gs/W86ApI92lawEIrQKHZGHahd5lt7plEi+Ga1xF7/te5RL1j4Bj kSsz1+Tj/oCMpd8WM2X78pMhW1dfmn9EkYe1kAbeH+PvuBO/7wca6gh2r+OFrsTlP2iTmNiVFZC7/ Pe8ERrrpsweaumj8j0aA6w==; Date: Sat, 07 Jun 2025 12:49:12 +0300 Message-Id: <868qm3j2zr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <875xhbgwbj.fsf@stebalien.com> (message from Steven Allen on Wed, 04 Jun 2025 12:07:12 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org > Date: Wed, 04 Jun 2025 12:07:12 -0700 > > There are two parts to this report: > > 1. Bug: use-package's ":custom-face" no longer overrides themed > faces. > 2. Opinion: ":custom-face" SHOULD merge the user-specified face spec > with the underlying face spec (contrary to the original report). I'm not sure I agree. I think the concept is that themes override any other face definitions, otherwise themes couldn't have done their main job. > IMO, :custom-face SHOULD behave like "custom-set-faces". Not sure I agree, but maybe John could state his opinions on that? From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jun 2025 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174931255426554 (code B ref 77928); Sat, 07 Jun 2025 16:10:02 +0000 Received: (at 77928) by debbugs.gnu.org; 7 Jun 2025 16:09:14 +0000 Received: from localhost ([127.0.0.1]:49373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uNw6b-0006uC-Eq for submit@debbugs.gnu.org; Sat, 07 Jun 2025 12:09:13 -0400 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:41401) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uNw6Y-0006tv-VI for 77928@debbugs.gnu.org; Sat, 07 Jun 2025 12:09:12 -0400 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 3ED75254011D; Sat, 7 Jun 2025 12:09:05 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sat, 07 Jun 2025 12:09:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1749312545; x= 1749398945; bh=O7tv2TYiBGRmGwNOoeF8gN37T/yDIzQF7pcadxR+Azk=; b=A oJbqlpt3f2/XXPf6LKblmQQ5V2KeeViBCWILZpW9ZYnoIpPUSkPX4RUq3XnP9kWt Hq35zKmqAOM6QHh0kDL39QW82/jYemcKeoeuM4Di9j1w8VqG7AbFtnMieVrnxibW EhlKzGVmJ6I2kHp1oqSO89Tclub/wvVqbehkGQsvyFjsw1Yz3hle1PKZEuuP6lxg 6QZBiqx73tqM3hNNK5ASsHj5nNCjNsVGzNtGAAfOrxMplUSQ0GgfVd/XuEnguwVX EBH8f2mj5Xn3W2Kz/NcDpP7oKt1ktF4INv6g3r4uoonqcjOhhY+Evq3HNvEObCPs 2NUHvDzFc723QEklfDpuA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1749312545; x=1749398945; bh=O7tv2TYiBGRmGwNOoeF8gN37T/yDIzQF7pc adxR+Azk=; b=CFjyrWgTlZO04/WSF1V6u47h2Z3VYPiQIiRYctvDJdOmG356YZQ 3VEjWxBV4h51JRHF9CAAnacm/Mch+26StN0c2IBJAjhmkn1uNRvagR7WDx66ZH5F wGoA7r+LRVhDpZ76Jx4IwRZNkNjTeDa0p6gS4tHWAvAnn3FZcV0iXmRyhLSO9wUd /E2U+E0+qyrk0JHTTTpIRf3YCpkV0980n5oFU5DqaTAPkvjJ7vdaVc5ymfgz60+P 8SKPXqnDsoBZmggtk7PxFa+zzo5mCwDeFarzrI/hVhlcMWKg7Ul9CI3kda59WnY4 W2QnjVjLu8YZtTHISXf3F9BWIqXsy+Zhe4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdeijeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepvdekheekgeelheehgefgudelkeethffhgfeu ffetkeegtddvfeduuddttdejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesgh hnuhdrohhrghdprhgtphhtthhopehjohhhnhifsehgnhhurdhorhhgpdhrtghpthhtohep shhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpthhtohepjeejledvkeesuggvsggsuh hgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Jun 2025 12:09:04 -0400 (EDT) From: Steven Allen In-Reply-To: <868qm3j2zr.fsf@gnu.org> References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> Date: Sat, 07 Jun 2025 09:09:03 -0700 Message-ID: <875xh7lejk.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Steven Allen >> Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org >> Date: Wed, 04 Jun 2025 12:07:12 -0700 >> >> There are two parts to this report: >> >> 1. Bug: use-package's ":custom-face" no longer overrides themed >> faces. >> 2. Opinion: ":custom-face" SHOULD merge the user-specified face spec >> with the underlying face spec (contrary to the original report). > > I'm not sure I agree. I think the concept is that themes override any > other face definitions, otherwise themes couldn't have done their main > job. But this is the user's config. The theme should (and does) override the default face definitions, but the user should always have the last say. For example, if a user customizes a face via the "Easy Customization" interface, said customizations always override the theme. :custom-face is supposed to be the use-package equivalent of the "Easy Customization" system. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jun 2025 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen Cc: 77928@debbugs.gnu.org, johnw@gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17493165576557 (code B ref 77928); Sat, 07 Jun 2025 17:16:02 +0000 Received: (at 77928) by debbugs.gnu.org; 7 Jun 2025 17:15:57 +0000 Received: from localhost ([127.0.0.1]:49454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uNx9B-0001hh-7i for submit@debbugs.gnu.org; Sat, 07 Jun 2025 13:15:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34862) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uNx98-0001hB-8t for 77928@debbugs.gnu.org; Sat, 07 Jun 2025 13:15:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNx92-0007jT-Gu; Sat, 07 Jun 2025 13:15:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BduRBD/0yvihqUIHnVHbiCC0PhroJPd7kttB0WwgfpA=; b=qIGAvjTP4FVm MCi/Dr8sVSj7xPg9nwsm8eP07qDpO2KelMCRMbuOAWOrqano4bTEFzSrr7bI9Kct952Oae+MXHaxw 4xxoA+N+gSn+vXlHdpwDvmEtUlfUY6ZrfgHNTB27kIQPTDdcwGqQugXBk5Ecppn2JfjK/h8/rea1m pK/S0vY7kRGNYNekSiK78L9pQnTXcGw+2z7oUrDVnfqgyHW0R2W++YDX3MLxdYrBJ/HYBehmtwQNI gs5cq2FHM4QT6pFuig/+4TuaHz0ntL4knVBX74O+BmxLfFNIc6xqSRkf743qzjI6i6y4p0yk0kLR6 Bbf+p7z/Xd20mb/HBcyO9w==; Date: Sat, 07 Jun 2025 20:15:46 +0300 Message-Id: <86qzzvh3r1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <875xh7lejk.fsf@stebalien.com> (message from Steven Allen on Sat, 07 Jun 2025 09:09:03 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Steven Allen > Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org > Date: Sat, 07 Jun 2025 09:09:03 -0700 > > Eli Zaretskii writes: > > >> From: Steven Allen > >> Cc: johnw@gnu.org, shields@msrl.com, 77928@debbugs.gnu.org > >> Date: Wed, 04 Jun 2025 12:07:12 -0700 > >> > >> There are two parts to this report: > >> > >> 1. Bug: use-package's ":custom-face" no longer overrides themed > >> faces. > >> 2. Opinion: ":custom-face" SHOULD merge the user-specified face spec > >> with the underlying face spec (contrary to the original report). > > > > I'm not sure I agree. I think the concept is that themes override any > > other face definitions, otherwise themes couldn't have done their main > > job. > > But this is the user's config. The theme should (and does) override the > default face definitions, but the user should always have the last say. Loading a theme is also a user configuration. Customizing a face directly (via "M-x customize-face") should indeed take precedence, but use-package's :custom-face isn't that, AFAIU, because it doesn't expand to a custom-set-faces form. In fact, I'm not sure I understand the semantics of use-package's :custom-face attribute. And what is supposed to happen if a theme is loaded _after_ :custom-face was processed? > For example, if a user customizes a face via the "Easy Customization" > interface, said customizations always override the theme. :custom-face > is supposed to be the use-package equivalent of the "Easy > Customization" system. I'm not sure this is what :custom-face is, because it expands to something else. Maybe John could help us understand what was the intent, and why this is the expansion. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 07:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 77928@debbugs.gnu.org, Steven Allen , shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174936942927875 (code B ref 77928); Sun, 08 Jun 2025 07:58:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 07:57:09 +0000 Received: from localhost ([127.0.0.1]:50586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOAtx-0007FX-CN for submit@debbugs.gnu.org; Sun, 08 Jun 2025 03:57:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43756) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOAtu-0007Ev-Ak for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 03:57:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOAtk-0005Xm-PZ; Sun, 08 Jun 2025 03:56:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=uapOTDg1PfqCdLFzJ063jS3zYbvi05VEIi9weKPLDzM=; b=JpKBs2po+Jxc/yaWbfVU 16+SI8n/t0h0P5mmpZHW7Bo5a6XCg5n3d+ZNGUyLdX2SFh8nFQZYPA6tkoCGrtorh6yl21OVKmQ1J 9B60Sj9G6/yRzbRnYxOYUmzUz20JcZ5sNhu20PWDM19kAw+XwB5xm0129T6eA2G76ersIWIr3nA+L 5W3IxIuELCo3nQueENhT6SjQ9yQjzra/gV1nLjnZ2RdwHY01BFkTK1rTLEblsy0TLQIlP05k1JFSI 10qVlBRoqGk//05qOfqeBaSJQzXNhr3WwDjQgDMIhybh8Km8I8X8cPEX9hHwN6x1p5wvwpN6bCrPD iGb8zY7eyzCS5w==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdejheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje ejledvkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehshhhivghlughs sehmshhrlhdrtghomhdprhgtphhtthhopehsthgvvhgvnhesshhtvggsrghlihgvnhdrtg homhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: <86qzzvh3r1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Jun 2025 20:15:46 +0300") References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> Date: Sun, 08 Jun 2025 00:56:32 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Eli Zaretskii writes: >> For example, if a user customizes a face via the "Easy Customization" >> interface, said customizations always override the theme. :custom-face is >> supposed to be the use-package equivalent of the "Easy Customization" >> system. > I'm not sure this is what :custom-face is, because it expands to something > else. Maybe John could help us understand what was the intent, and why th= is > is the expansion. This is no deep answer, I=E2=80=99m afraid. I think I just looked at what g= ets called in settings.el when you save a face customization (`custom-set-faces'), and= so this is what I used. --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 16:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley , Eli Zaretskii Cc: 77928@debbugs.gnu.org, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174939943326321 (code B ref 77928); Sun, 08 Jun 2025 16:18:01 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 16:17:13 +0000 Received: from localhost ([127.0.0.1]:52689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOIhs-0006qT-Nm for submit@debbugs.gnu.org; Sun, 08 Jun 2025 12:17:13 -0400 Received: from fout-a1-smtp.messagingengine.com ([103.168.172.144]:38483) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOIhp-0006qG-UN for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 12:17:11 -0400 Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfout.phl.internal (Postfix) with ESMTP id A3FD31380180; Sun, 8 Jun 2025 12:17:04 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Sun, 08 Jun 2025 12:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm3; t=1749399424; x=1749485824; bh=jxFP9TMDRfeBdCUFU5K1aNYJYlkNhpRd pn1okjzTJHQ=; b=RXwG5TI4E/HDd1TLYAP3m6p01NrsWKE2d/CLFgdg4ujg7yoA +0bN9T9EAZQSbXIIYo46/sUI+H6O+LO0bqqOG+ckjqiKTiSWxoaNorPQtSQq8UB3 HWfgrDeCco6Fx8gAmy5wfx78P98+Kcll7yZs29JefN8LIWjOaDIoYP9sUA8Bo4PV YbjwGpEaK6ptY6mJuZOnLMmIliJOCEyDzG22LA6MXQewtMX7uA/xqbggAN+MFslf YZSZ7aeRmH3gJWO4tG0UsAWEsQb0gj9OAFPNoyjcefulcnGWwizpAYZZaH9xX6Rt WTRtr/JChxfLqS7jS+baYLYCB7t+wQCCG41iWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1749399424; x= 1749485824; bh=jxFP9TMDRfeBdCUFU5K1aNYJYlkNhpRdpn1okjzTJHQ=; b=Q o9iElJAD82k9SCXqJ4cQ7nIvbgZeqCyKpNsG2ta7BKKQefi6lOnhN6Kb2H7oj/MN WiR17s7JlBDWMNWixhy/bI91d+TmAbE+6vF/oSNXAek02Ti3GpXOhMDcA9du7dS9 UkpmCTDaDkEyC4vZ0yZiGMMa5pRUNGBskrjhqpEY5CQbTIuXtUdqzaiPqqyDvOxq k9djXBVWN2blgsWOQLOftRe6ZrypmxDFD26v2l6hU3nFKkJ67kX2lehSjkyKEMON LexHGFh6MUCdk9/U+90njon8kp3PVR1Ot4g39wSaPUnPfyMpmNuOlQMLbVv0YKw7 rIPgImTyIsoSVyjmXtD4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdektdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtgfesthhqredttddtjeen ucfhrhhomhepufhtvghvvghnucetlhhlvghnuceoshhtvghvvghnsehsthgvsggrlhhivg hnrdgtohhmqeenucggtffrrghtthgvrhhnpeefvdduheefuedvteevteeiveejgedtteeg hfelgfegueehvefhffeliedvteeiudenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdpnhgs pghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepjhhohhhnfi esghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthho pehshhhivghlughssehmshhrlhdrtghomhdprhgtphhtthhopeejjeelvdekseguvggssg hughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Jun 2025 12:17:03 -0400 (EDT) From: Steven Allen In-Reply-To: References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> Date: Sun, 08 Jun 2025 09:17:02 -0700 Message-ID: <871prufbsx.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) John Wiegley writes: >>>>>> Eli Zaretskii writes: > >>> For example, if a user customizes a face via the "Easy Customization" >>> interface, said customizations always override the theme. :custom-face = is >>> supposed to be the use-package equivalent of the "Easy Customization" >>> system. > >> I'm not sure this is what :custom-face is, because it expands to somethi= ng >> else. Maybe John could help us understand what was the intent, and why t= his >> is the expansion. > > This is no deep answer, I=E2=80=99m afraid. I think I just looked at what= gets called > in settings.el when you save a face customization (`custom-set-faces'), a= nd so > this is what I used. It would help to better understand how it was intended to behave: - Should :custom-face override the theme or should the theme override :custom-face? - Should customizations made via :custom-face be merged with the original face definition (as with `custom-set-faces') or should they completely replace the underlying face. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Steven Allen Cc: Eli Zaretskii , shields@msrl.com, 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940479310737 (code B ref 77928); Sun, 08 Jun 2025 17:47:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 17:46:33 +0000 Received: from localhost ([127.0.0.1]:52818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOK6K-0002n6-Hp for submit@debbugs.gnu.org; Sun, 08 Jun 2025 13:46:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39192) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOK6H-0002mr-MB for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 13:46:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOK6B-0005hM-Rw; Sun, 08 Jun 2025 13:46:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=a8kczrIhL3hPTrxiU4KxIHkg7YaF5i6TON04BvCkPss=; b=BrVavT4fpYnptUaZ+oRO A+lV4CmQqgbEeQ9hZ4nDdN+LnuqO5Lr3fKpwYN2ftLRNKrW4As2es0hTv9ggKLCytqHGIrxnmRNXS xHb4wqMCzkmslqXOvDXw+YEiaZ9ehbmvePXNFDOJvgRqtWa7GqRLX5Atf82g91ZCOXGJGB4ZQ4oBY MJhPLOgRkAYyh0VCa3H/vFpweO1IdcS4lyGFuELa0fOYQ5psI95P7tfFjH9K7Hv/UQ5WdbpblS+Yc K1zZAxIOW3uP+6lswHqmhNfZZHj2uqoKKw1toKEQACy3+RO18bKB21tG+Kxd7xZbPnytwfN7NYD0z oJz4eFBfDEbO3w==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje ejledvkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehshhhivghlughs sehmshhrlhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtth hopehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: <871prufbsx.fsf@stebalien.com> (Steven Allen's message of "Sun, 08 Jun 2025 09:17:02 -0700") References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> Date: Sun, 08 Jun 2025 10:46:14 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Steven Allen writes: > It would help to better understand how it was intended to behave: > - Should :custom-face override the theme or should the theme override > :custom-face? I=E2=80=99ve never used themes before, so I wasn=E2=80=99t thinking of them= at all when the feature was added. Someone who uses themes a lot, and customizes them, shou= ld be asked this question. > - Should customizations made via :custom-face be merged with the original > face definition (as with `custom-set-faces') or should they completely > replace the underlying face. I would expect the behavior to be whatever `custom-set-faces' does. Since use-package is only intended to expand to =E2=80=9Cbest practice=E2=80=9D E= macs Lisp, it shouldn=E2=80=99t add any new behavior in my opinion. --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Michael Shields Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley Cc: Eli Zaretskii , Steven Allen , 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940727717741 (code B ref 77928); Sun, 08 Jun 2025 18:28:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 18:27:57 +0000 Received: from localhost ([127.0.0.1]:52884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOKkO-0004c5-Rh for submit@debbugs.gnu.org; Sun, 08 Jun 2025 14:27:57 -0400 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]:43388) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uOKkM-0004bq-B3 for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 14:27:55 -0400 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-70f94fe1e40so46724767b3.1 for <77928@debbugs.gnu.org>; Sun, 08 Jun 2025 11:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=msrl.com; s=google; t=1749407268; x=1750012068; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Q0lNPwhWEapXoxtdvlJmNxm7vgMrlI4ywtGEFVhFfcc=; b=DLZxmwnx8RyBCSpz34wifAc5ixoUcVPoJTAh4bktPbgnL0uVgXFvN7280HV38QFLU5 m2sQtEJLpkqLxC7EE7HjMaMPJr/fFpR05ntEjXlSXOgSmZ/tkZ2mJlnkKR47Wg4REh89 Oh/jeOPHm39JmYZIL9zoPCT7QowXwMfhi8FNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749407268; x=1750012068; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q0lNPwhWEapXoxtdvlJmNxm7vgMrlI4ywtGEFVhFfcc=; b=tqzjL40Nol10kZDYifjv3BnZcDU2US27RVkO7juH+JyBtkANvA6GCtdhVDal3umd/S KhAGupOwUrpiMIsa2X9Eb6K3ENYip93VLoPPwX0piqPJP4yXCacBXlFD1PvibahHZMz1 IwbigZKZh8mFeMRJ0Gu0GvQIKYQy1zmUCn0WHpU0BKw6bHkZyVtcOdO4qptR78fV2bfF 34+cvoSRmGAlia6Gza40taDqVdrl516T5KdVGDOfxumXH97TtPdzRndPPVA4jKrUYGdQ hY0F746nXIPA71kfzRcCk/EI4N/ehhBMRhf8bOoDAcogvVcVDKoSGj8pB/9fN8T8Ap9N 3D/A== X-Forwarded-Encrypted: i=1; AJvYcCUxOe7BxvjWtM3d08EdTXZC9kke3SYhyvq3i0WkwIpTIA/4liV6be8i8HD2Hh3niXZwK0jrCQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzREAX6TnZ8X4szqbK0d3uF27PlMFcUOsXwGiQwzdvgVrVl3GkD inI66mmnjVh9uHFOL20bsBtocmxzl9lNQnJAstb7P7XY2T27e0MWB3ci90I2yuWFy+Nv6XIXbwK xcqDeLIIz5mgOpMSsufHtyv0T8TB793iBY1fdfwSJ X-Gm-Gg: ASbGnct/HU6EFlfLhWGy/uqJLhksGoC2I+jtowKiewZWfqovq15MfThR1HdbZj4daQD gFdrJuPdOxbES3ldC6vSkvaN2HUd2dTNzEKMhw18lNqN9HUzX99ArsISMfYh2QtQDiPuj8991bC YXNP6d+r3BZ1TqYsGpZ5gQkYm6vbw6b1RvF2gkDlfg9vfHd7Ry1cwUGCrxunvr4Nw/z/9KXhdcH SBjVzD/iAURFBI3 X-Google-Smtp-Source: AGHT+IEz6kEytSp5qlUOH+CqwNe5Q7Nm7NBNsQVoUOTwe39PMRnbY04/BSfEJQBCO6Ej/r26DVziWLtVN4zOPOVWKEk= X-Received: by 2002:a05:690c:4881:b0:70e:4b30:c207 with SMTP id 00721157ae682-711085756f8mr79152467b3.4.1749407268342; Sun, 08 Jun 2025 11:27:48 -0700 (PDT) MIME-Version: 1.0 References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> In-Reply-To: From: Michael Shields Date: Sun, 8 Jun 2025 11:27:37 -0700 X-Gm-Features: AX0GCFtIdSsQSRsI6p8SOdN5UoNvmNWGFo-SEDnK_AU1DCLqPhzOqM4-PpJJ3Qs Message-ID: Content-Type: multipart/alternative; boundary="000000000000cc20f80637139e35" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000cc20f80637139e35 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I don't use themes either, but I can describe my use case. I refactored much of my Emacs config into use-package. Most of that went straightforwardly into :init, :bind, :hook, etc. Custom variables moved to :custom, and custom faces moved to :custom-face. But this caused some faces to change, because custom-set-faces effectively replaces the face definition, while :custom-face overlaid it. If I understand the history, :custom-face initially called custom-set-faces, so it behaved identically to having custom-set-faces in custom.el. But this confusingly resulted in :custom-face definitions being written to custom.el as if the user had configured them through M-x customize. https://github.com/jwiegley/use-package/pull/1004 fixed that, unintentionally also changing the semantics of :custom-face. With my patch applied, :custom-face should be equivalent in behavior to custom-set-faces, but without the settings appearing as if they were user-set. I don't know how this should interact with themes. Maybe the right approach there is to define a new personal theme and configure faces there instead of using :custom-face. Or maybe it is simplest to call face-spec-set explicitly from :config. On Sun, Jun 8, 2025 at 10:46=E2=80=AFAM John Wiegley wrote: > >>>>> Steven Allen writes: > > > It would help to better understand how it was intended to behave: > > > - Should :custom-face override the theme or should the theme override > > :custom-face? > > I=E2=80=99ve never used themes before, so I wasn=E2=80=99t thinking of th= em at all when the > feature was added. Someone who uses themes a lot, and customizes them, > should > be asked this question. > > > - Should customizations made via :custom-face be merged with the origin= al > > face definition (as with `custom-set-faces') or should they completel= y > > replace the underlying face. > > I would expect the behavior to be whatever `custom-set-faces' does. Since > use-package is only intended to expand to =E2=80=9Cbest practice=E2=80=9D= Emacs Lisp, it > shouldn=E2=80=99t add any new behavior in my opinion. > > -- > John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80= F > http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 > --000000000000cc20f80637139e35 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I don't use themes=C2=A0either, but I can describe my = use case.

I refactored much of my Emacs config into use-= package. Most of that went straightforwardly into :init, :bind, :hook, etc.= Custom variables moved to :custom, and custom faces moved to :custom-face.= But this caused some faces to change, because custom-set-faces effectively= replaces=C2=A0the face definition, while :custom-face overlaid it.=C2=A0

If I understand the history, :custom-face initially= called custom-set-faces, so it behaved identically to having custom-set-fa= ces in custom.el. But this confusingly resulted in :custom-face definitions= being written to custom.el as if the user had configured them through M-x = customize.=C2=A0https://github.com/jwiegley/use-package/pull/1004 fixed that, uninte= ntionally also changing the semantics of :custom-face.

=
With my patch applied, :custom-face should be equivalent in behavior t= o custom-set-faces, but without the settings appearing as if they were user= -set.

I don't know how this should interact wi= th themes. Maybe the right approach there is to define a new personal theme= and configure faces there instead of using :custom-face. Or maybe it is si= mplest to call face-spec-set explicitly from :config.

<= /div>
On Sun, Jun 8, 2025 at 10:46=E2=80=AFAM John Wiegley &= lt;johnw@gnu.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">>>>>> Steve= n Allen <steve= n@stebalien.com> writes:

> It would help to better understand how it was intended to behave:

> - Should :custom-face override the theme or should the theme override<= br> >=C2=A0 =C2=A0:custom-face?

I=E2=80=99ve never used themes before, so I wasn=E2=80=99t thinking of them= at all when the
feature was added. Someone who uses themes a lot, and customizes them, shou= ld
be asked this question.

> - Should customizations made via :custom-face be merged with the origi= nal
>=C2=A0 =C2=A0face definition (as with `custom-set-faces') or should= they completely
>=C2=A0 =C2=A0replace the underlying face.

I would expect the behavior to be whatever `custom-set-faces' does. Sin= ce
use-package is only intended to expand to =E2=80=9Cbest practice=E2=80=9D E= macs Lisp, it
shouldn=E2=80=99t add any new behavior in my opinion.

--
John Wiegley=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = GPG fingerprint =3D 4710 CF98 AF9B 327B B80F
htt= p://newartisans.com=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 60E1 46C4 BD1A 7AC1 4BA2
--000000000000cc20f80637139e35-- From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: John Wiegley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields Cc: Eli Zaretskii , Steven Allen , 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940750818581 (code B ref 77928); Sun, 08 Jun 2025 18:32:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 18:31:48 +0000 Received: from localhost ([127.0.0.1]:52898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOKo8-0004pd-DK for submit@debbugs.gnu.org; Sun, 08 Jun 2025 14:31:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37404) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOKo6-0004pP-Et for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 14:31:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOKo0-0001iM-TJ; Sun, 08 Jun 2025 14:31:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=PO4D8XSc1ckZbDuIqvzzKKANoFyoh3IuKaY5IRMPIE4=; b=KoXOUtHZdfO33oN7kvho gXVTDqKreU/Uh80REwsVtU5nzH37fshDwD63SdxY6kUeC6hbaosAvc/LFFQRNOINOzIcybEebM5C/ mUFQBbzOLqvLF27ITsXPmMCZ17NvjdthLdwNqH8gYoK2ySumJ/Nugj/PmjY5hp7RqvbQpYrQUxw44 O1ZTq8oOyjsYoGTucSYy+/hjTnGMRXdFNKWawOrmvuIjeGkPvw2rWqzpNWAcYPuFHvqJo3UgXa79G BWGgGwqzxV4XMRG5bwauoJ7ueyEAFHL+ENzucGUq5Ih2lJJyI86eQ146qADnbQO/I7PH8/IJk1Jvq 5EXgwpDRIIPSWA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkfgggtgfgsehtqhertddtreej necuhfhrohhmpeflohhhnhcuhghivghglhgvhicuoehjohhhnhifsehgnhhurdhorhhgqe enucggtffrrghtthgvrhhnpeeiffdthedviedvtdfffeffffevkeeludejieeltddufeeh fefhhfefgeejteefgeenucffohhmrghinhepnhgvfigrrhhtihhsrghnshdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhhnhif odhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdeikeejkedtleeggedqudejje ehfeekudeiqdhjohhhnhifpeepghhnuhdrohhrghesnhgvfigrrhhtihhsrghnshdrtgho mhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepje ejledvkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhn uhdrohhrghdprhgtphhtthhopehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomhdprh gtphhtthhopehshhhivghlughssehmshhrlhdrtghomh X-ME-Proxy: Feedback-ID: ib64945b7:Fastmail From: John Wiegley In-Reply-To: (Michael Shields's message of "Sun, 8 Jun 2025 11:27:37 -0700") References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> Date: Sun, 08 Jun 2025 11:31:38 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> Michael Shields writes: > With my patch applied, :custom-face should be equivalent in behavior to > custom-set-faces, but without the settings appearing as if they were > user-set. > I don't know how this should interact with themes. Maybe the right approa= ch > there is to define a new personal theme and configure faces there instead= of > using :custom-face. Or maybe it is simplest to call face-spec-set explici= tly > from :config. This description certainly sounds like it expresses the right approach of use-package being as =E2=80=9Cminimal=E2=80=9D a wrapper around standard be= havior as possible. --=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Kristoffer Balintona Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley , Steven Allen Cc: Eli Zaretskii , shields@msrl.com, 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940806720198 (code B ref 77928); Sun, 08 Jun 2025 18:42:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 18:41:07 +0000 Received: from localhost ([127.0.0.1]:52913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOKx8-0005Fi-Iy for submit@debbugs.gnu.org; Sun, 08 Jun 2025 14:41:06 -0400 Received: from mail-lj1-x232.google.com ([2a00:1450:4864:20::232]:56660) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uOKx5-0005F4-8E for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 14:41:04 -0400 Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-32addf54a00so22062321fa.1 for <77928@debbugs.gnu.org>; Sun, 08 Jun 2025 11:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749408057; x=1750012857; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=rGUFv7sG+289eBiJdaO9gfeIk2IkCadaNw4bVzC6pBg=; b=M+9P7dmqoVUeqcuDJL4ZmOjoiSbJHoyT/QkNcTvOFHbLO4Q7aAz0AD1gVRZn0GxoXZ 0pQwfw41L0tUsLv6rCiqjiarAZLFRxZ096vSZDHZrLPTG4T+DPtsLudOQWBg9VdJu6Dv HMaXWxomqMVeqbsRTN2xGVqyefwgVg91HsB8ABWa8+/rR6jESoVDWSbV/Bb0sRe3d1Uz 1qCm4wiBCv0tyYkK75THyklIaoKxW7PPvVfhUtkzMagj+viSDaquztSyKGWADqBwtCAd jRQvic4aCd2T99nFmVh4/dLyRcbzV52xNol0+YupK7x7KwlWfS7gVYrWsoKvV/yGVL1M jSfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749408057; x=1750012857; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rGUFv7sG+289eBiJdaO9gfeIk2IkCadaNw4bVzC6pBg=; b=Y7Y4D9JzsJUJAuJR9ITzf1cWkY8flEppr7d6QX5/KJWpXmX9NESsVOUdyYzMfCDKLj 2PkZiXPbslcbZjiWolOhFcWfkJuSRz634qAzydhAKHAQ2v2DbY0ECmbMToLNaIR3+05y RN+BCY9IjTfmhL4byoUNvqXh0mNt/xvH6YnriI9Ba8XcN7Iyu0S74+8UH1BB1OpqATk9 aP8D4k5jpnI68C/e/8fgjGN6YFXnyxj2Dk6+oafOdgrpRJdH0nA+18bkgIGz7qu1v0U3 w+GbB9Nm5OBAWwXnazGhqENIwJsdz4yU3D3wth5XlVpaeA/aphMX8VF+FAPl/7L1xydN UVWw== X-Forwarded-Encrypted: i=1; AJvYcCUr+qNB0u9M0Df2PQlfMti69bIyCS4KqOPkH8LG4xPStNWID/5OtsvbKebw69uOhL3wtI2Veg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxL2dTuQuPKpfuTBxhGfMZfQTMkU4kyQvQLTDOTjqFiCjelZdIj DFcQhLWLrf34Ik4AQnzn1KANnp5G2VCsTpvw+y5fz/Z7tEEmZPwDkFcx/dncV7ICLK04cLT9Ov8 GZk4ON6urCQ9vRwZkHN6uNSQnwQ/IHf8= X-Gm-Gg: ASbGncvbHSo8fkobYYCJ/8B79xV4W/vSXNtxgk9nbMUYqYzuEnIFXn1EDJtcagOojI/ advYssBaBKxBnKV73uWWNzyF9J6SmpWxsZ9BAXzBg9U3uYHwnbT/+xNFTTiCtF12ViQ64s+RlfW nlpSqa6w1h6mkbaZW3d0MdMY8PRBRExW79DFqxPY0liPQ0mJeHHrPKzA== X-Google-Smtp-Source: AGHT+IEfaO4prbYoS7nq2EOb2olSc8KUI40cMrve8r1FLOr/Iw21rCwbQAiWpHEgd+o8wCoRg9yWPWB5605Q5oEK1lY= X-Received: by 2002:a2e:8183:0:b0:32a:6312:bfc1 with SMTP id 38308e7fff4ca-32adfb894camr17345101fa.24.1749408056402; Sun, 08 Jun 2025 11:40:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 8 Jun 2025 11:40:55 -0700 Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 8 Jun 2025 11:40:55 -0700 From: Kristoffer Balintona In-Reply-To: References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> MIME-Version: 1.0 Date: Sun, 8 Jun 2025 11:40:55 -0700 X-Gm-Features: AX0GCFvdGvUyW9bt8KuK_ZHcXIQuZ2fm3YzYxrJrYR_sddPE7W7o70u46RN4hWM Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 08 2025, John Wiegley wrote: >>>>>> Steven Allen writes: > >> It would help to better understand how it was intended to behave: > >> - Should :custom-face override the theme or should the theme override >> :custom-face? > > I=E2=80=99ve never used themes before, so I wasn=E2=80=99t thinking of th= em at all when the > feature was added. Someone who uses themes a lot, and customizes them, sh= ould > be asked this question. FWIW, I haven=E2=80=99t been following this thread closely, but as a user w= ho hadn=E2=80=99t thought at all about the technical sides of things, what I s= imply expected of :custom-face was that it be applied on top of any existing theme customizations, not that it override them. Again, that=E2=80=99s my un-technical, naive expectation as a user. Just throwing in my experience. --=20 Kind regards, Kristoffer From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: John Wiegley Cc: 77928@debbugs.gnu.org, steven@stebalien.com, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940946923919 (code B ref 77928); Sun, 08 Jun 2025 19:05:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 19:04:29 +0000 Received: from localhost ([127.0.0.1]:52933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOLJl-0006Dj-A9 for submit@debbugs.gnu.org; Sun, 08 Jun 2025 15:04:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56322) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOLJi-0006DT-AH for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 15:04:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOLJc-0004gx-F4; Sun, 08 Jun 2025 15:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+vCFfDQ6itoESng/7yvCfO0JmR8CpQXhdmcaN0cLAho=; b=G0W2CgJqaBFj1eXZ4PmG luv9RHvH38U+0/Qqg5eii9IvbbJtihCdcZQZvzE5nxrx3diyepVUkTKQ7/zibETXrZQQrXmcgdQ9o MBx/wCOfDqO1fdCk251qkj8VullRY3THFXJHMjtOI3Dr3DMNz1zpVwBkFLraQMWk4x3iIRYfPQ10p R7ejjmgDvHIYLaNg1epD8owrxKUiWh9NbIHCDUDKBy3fDW1VWUGm8YUA4BkjMpr8jjXXFp6ti4c7e FkpDMx6XmBU8dxc8MtRBEDZDEy++aV6ubtH8/e4PuLCOohSjkb5gF7sTN7lCBNUYw/9cN1eAZ+75z As9LuOFf1KucUA==; Date: Sun, 08 Jun 2025 22:04:17 +0300 Message-Id: <86wm9mf426.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from John Wiegley on Sun, 08 Jun 2025 10:46:14 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: John Wiegley > Cc: Eli Zaretskii , shields@msrl.com, 77928@debbugs.gnu.org > Date: Sun, 08 Jun 2025 10:46:14 -0700 > > >>>>> Steven Allen writes: > > > - Should customizations made via :custom-face be merged with the original > > face definition (as with `custom-set-faces') or should they completely > > replace the underlying face. > > I would expect the behavior to be whatever `custom-set-faces' does. Since > use-package is only intended to expand to “best practice” Emacs Lisp, it > shouldn’t add any new behavior in my opinion. Then IMO :custom-face should expand into a call to custom-set-faces. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kristoffer Balintona Cc: 77928@debbugs.gnu.org, johnw@gnu.org, steven@stebalien.com, shields@msrl.com Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174940982525180 (code B ref 77928); Sun, 08 Jun 2025 19:11:02 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 19:10:25 +0000 Received: from localhost ([127.0.0.1]:52944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOLPU-0006Y4-Io for submit@debbugs.gnu.org; Sun, 08 Jun 2025 15:10:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59100) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOLPR-0006Xn-L8 for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 15:10:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uOLPL-0005fq-Ji; Sun, 08 Jun 2025 15:10:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=A0hxVky+DzYWmXar6PmpZCjsf6H4tR1vrjZeQlYY6HQ=; b=pLF+rVqwHME4NNnhEdTz fdUcwN43dUvJJEY02d9+SGUVBeIjNNZvSK+1TY+7t22aAsllmAwc7vUN6NXBA/bf7LhD2IYGA2hMY XrYXlp6ZzCPlT9h47yW2XWCUMaqpG9IzjTJ5C1Hu2VHYvmr2+leRmAUPRmVxRdNm+SRANUcQOQ5mg Krw1JfQiazAFfPzE0hJvBmOhWM05/uYTuJ6Uv2BBTrK1w6PD64hzBf4zahM3+xGtVIeqUWt+F4X6E PUHKnEXuo8gZbif7AoUTkOecyxdDR5A40sGGoIbdUAXNn717CPewoB60DOqDe7Bv8mxkrOPnz/qRh vLbJLT4WMdwIRg==; Date: Sun, 08 Jun 2025 22:10:03 +0300 Message-Id: <86v7p6f3sk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Kristoffer Balintona on Sun, 8 Jun 2025 11:40:55 -0700) References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Kristoffer Balintona > Date: Sun, 8 Jun 2025 11:40:55 -0700 > Cc: Eli Zaretskii , shields@msrl.com, 77928@debbugs.gnu.org > > On Sun, Jun 08 2025, John Wiegley wrote: > > >>>>>> Steven Allen writes: > > > >> It would help to better understand how it was intended to behave: > > > >> - Should :custom-face override the theme or should the theme override > >> :custom-face? > > > > I’ve never used themes before, so I wasn’t thinking of them at all when the > > feature was added. Someone who uses themes a lot, and customizes them, should > > be asked this question. > > FWIW, I haven’t been following this thread closely, but as a user who > hadn’t thought at all about the technical sides of things, what I simply > expected of :custom-face was that it be applied on top of any existing > theme customizations, not that it override them. Thanks, but what is your mental model of "applied on top" vs "override", in the context of face settings? Unless you explain that, I cannot understand what are your expectations, because "applied on top" and "override" are not useful descriptions when talking about faces, due to the fact that a face has quite a few attributes, and some of them could be inherited from other faces. From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields , John Wiegley Cc: Eli Zaretskii , 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.174941074027707 (code B ref 77928); Sun, 08 Jun 2025 19:26:01 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 19:25:40 +0000 Received: from localhost ([127.0.0.1]:52963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOLeG-0007Cp-7X for submit@debbugs.gnu.org; Sun, 08 Jun 2025 15:25:40 -0400 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:59977) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOLeC-0007Ca-Rj for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 15:25:38 -0400 Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfout.stl.internal (Postfix) with ESMTP id 39EA1114016F; Sun, 8 Jun 2025 15:25:31 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sun, 08 Jun 2025 15:25:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1749410731; x= 1749497131; bh=Vsa/kjCuhXJ/6fCeHcuRj+CBxU4/2TcLE86F/XqXWTk=; b=Z +yKBWQJuoSNHFC52bZilB1yzSam8iuXlYLH+cW3F7imT4Dagv3gOZ5xVGuY2km6s wGjgquvelRI71b8DUFLMVrY5pKEJI0VbaNaW98qnKQNlfT1NhXVUv7fpGrFTjuOL QSi2KatIqALx64Q4beDy6cndYMAJ4YLFVuqF2dzgz40+dH0ca5tUqafCN8r+e71T 8EZoGkU/GS4CpYYK0nHFzNHnrBvc57vfKg5QYbxN6dzTO3rf8OlFN7YtHJ75ZZtr DDuBnyWigR9JtKQLgXJNgfk8CyQtMyPi6u/ABuMG2/oHt/gGsbVkT6+hhnhxkba7 9PJpQ7E8EiPQbUiJRxo6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1749410731; x=1749497131; bh=Vsa/kjCuhXJ/6fCeHcuRj+CBxU4/2TcLE86 F/XqXWTk=; b=TXZT0W8pcm/O1pYdr9eY2ZBQEKrSuyWLQC5CNWtA0R1CikmMwqU u2TKJ4AFu+Wm3FOLhCQe0EkOmjMjCxGYlm3xuNO/0qHjUeX/dV6QyaXvjhMBkDzr 0/PGKm0PxnPrxVhwGfK3dSKaw1GWZJUH07JBZFYkGrbAZ9iuxxJ7gbO7Ys+4UpBW Zq1Kh8wQeHgLmkbB5osnviW+YE9L6cCLdLfmBBK/v+tw8/chVX9j+A4/f9hwBL4I cOa28nUokuaDU0jrJZgP+wZAYh7kER+L0AzvKvzGsrhXZMQ34QhT73qWgnTlKpsf ByKj5iLp2S3HIxa0jWLZybJyTUfoG0VBeSw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepjefgueeuuedtieekffeuveffjeeuffegkeet hfehvdffhfegtddvgeeiheegjeevnecuffhomhgrihhnpehgihhthhhusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgv nhesshhtvggsrghlihgvnhdrtghomhdpnhgspghrtghpthhtohepgedpmhhouggvpehsmh htphhouhhtpdhrtghpthhtohepshhhihgvlhgushesmhhsrhhlrdgtohhmpdhrtghpthht ohepjhhohhhnfiesghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopeejjeelvdekseguvggssghughhsrdhgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Jun 2025 15:25:30 -0400 (EDT) From: Steven Allen In-Reply-To: References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> Date: Sun, 08 Jun 2025 12:25:28 -0700 Message-ID: <87o6uyyr13.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Shields writes: > I don't use themes either, but I can describe my use case. > > I refactored much of my Emacs config into use-package. Most of that went straightforwardly into :init, :bind, :hook, etc. Custom variables moved to :custom, and custom faces moved to :custom-face. But this caused some faces to change, because custom-set-faces effectively replaces the face definition, while :custom-face overlaid it. > > If I understand the history, :custom-face initially called custom-set-faces, so it behaved identically to having custom-set-faces in custom.el. But this confusingly resulted in :custom-face definitions being written to custom.el as if the user had configured them through M-x customize. https://github.com/jwiegley/use-package/pull/1004 fixed that, unintentionally also changing the semantics of :custom-face. > > With my patch applied, :custom-face should be equivalent in behavior to custom-set-faces, but without the settings appearing as if they were user-set. I think I've found one of source of confusion: `custom-set-faces' DOES overlay/merge faces, but only for themed faces. For unthemed (default) faces, it resets the entire face spec (as you describe). > I don't know how this should interact with themes. Maybe the right approach there is to define a new personal theme and configure faces there instead of using :custom-face. Or maybe it is simplest to call face-spec-set explicitly from :config. The former (custom theme) sounds like what use-package does with :custom (it defines a use-package theme). Maybe just implement :custom-face the same way :custom is implemented? I.e.: (defun use-package-handler/:custom-face (name _keyword args rest state) (use-package-concat (if (bound-and-true-p use-package-use-theme) `((let ((custom--inhibit-theme-enable nil)) ;; Declare the theme here so use-package can be required inside ;; eval-and-compile without warnings about unknown theme. (unless (memq 'use-package custom-known-themes) (deftheme use-package) (enable-theme 'use-package) (setq custom-enabled-themes (remq 'use-package custom-enabled-themes))) (custom-theme-set-faces 'use-package ,@(mapcar #'(lambda (def) (let ((face (nth 0 def)) (spec (nth 1 def)) (comment (nth 2 def))) (unless (and comment (stringp comment)) (setq comment (format "Customized with use-package %s" name))) `(backquote (,face ,spec nil ,comment)))) args)))) (mapcar #'(lambda (def) (let ((face (nth 0 def)) (spec (nth 1 def)) (comment (nth 2 def))) (unless (and comment (stringp comment)) (setq comment (format "Customized with use-package %s" name))) `(custom-set-faces (backquote (,face ,spec t ,comment))))) args)) (use-package-process-keywords name rest state))) From unknown Mon Aug 18 06:57:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77928: 31.0.50; ebcde0f90f6 (bug#77928) breaks :custom-face for themed faces Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Jun 2025 22:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Shields , John Wiegley Cc: Eli Zaretskii , 77928@debbugs.gnu.org Received: via spool by 77928-submit@debbugs.gnu.org id=B77928.17494228107750 (code B ref 77928); Sun, 08 Jun 2025 22:47:01 +0000 Received: (at 77928) by debbugs.gnu.org; 8 Jun 2025 22:46:50 +0000 Received: from localhost ([127.0.0.1]:53200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uOOmw-00020v-0p for submit@debbugs.gnu.org; Sun, 08 Jun 2025 18:46:50 -0400 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]:38201) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uOOms-00020e-LB for 77928@debbugs.gnu.org; Sun, 08 Jun 2025 18:46:47 -0400 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id AFF152540103; Sun, 8 Jun 2025 18:46:40 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Sun, 08 Jun 2025 18:46:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1749422800; x= 1749509200; bh=ZVLsM7HHcdY4YzpcoNC3e6ozDfjxjFQpERPbsEXGogw=; b=p 5g06LDiprMqWoojHKj+7IcF/kBIJ894Q6PGptuPROi+846w+QT8kZdZjxoMvx7op jb0b61HlDRo3GYwurukPw4mqG9M7/AzrTUc/mK17sxwzR3BUL+jM3tkaX/wYsXZZ m8PFu1xqQY3BLGeUZn3f35r45Zjp179OZHQAQ055kNS8WCt/iIigaE9ny5oIK7h2 Iw14KS/5Bpw5ibT0vSexnfrHc1Moqi4yC7TznRjgbQYoX1gXTO1SIsaWBKa6lerT gwqJICJIRIRLYlhQlsq+tVrDkzx6jYGXXHJEDGJ4k1+yDObZWYcAPW4iNaClJmoP tIy7UxObJKRsD240bEqwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1749422800; x=1749509200; bh=ZVLsM7HHcdY4YzpcoNC3e6ozDfjxjFQpERP bsEXGogw=; b=TA9Mln7MbCSnR5tZjBPhIeAPTFTFiYM9hDhJ6rd21uoFhG7mIq3 c2XyOk62vN8xxMsENnnj90ec/8FvcRxP6PVcFr7MubuQiUdonprx1BhFJ4ZFtGQX f64auab1P5f7iyCt71lmHxuToPe1a75WYQ+lJ7eSjxdrh+QXYSYhD9/PP8GTzehx meK40G0sSE03wolp/pIhhThlxit5kjao4zHhK78t1q3901aNABBcfc9sc1mbuQhu vDGfKieP6FB9RbIwyxLMnRod8RHZiCUpcmCfhcVwyxxUpuXfKmoHLcuT7Z7aDMBT Z+Ee2OTjnvvfyzG0XA1GIfmo4YysxKgH7nQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddugdekgeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepvdekheekgeelheehgefgudelkeethffhgfeu ffetkeegtddvfeduuddttdejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehshhhivghlug hssehmshhrlhdrtghomhdprhgtphhtthhopehjohhhnhifsehgnhhurdhorhhgpdhrtghp thhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepjeejledvkeesuggvsggsuh hgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Jun 2025 18:46:39 -0400 (EDT) From: Steven Allen In-Reply-To: <87o6uyyr13.fsf@stebalien.com> References: <87y0vhwdbp.fsf@stebalien.com> <86ikmkmdkv.fsf@gnu.org> <86tt5jwtpq.fsf@gnu.org> <86ldqm1hli.fsf@gnu.org> <87y0uialof.fsf@stebalien.com> <86iklmxppf.fsf@gnu.org> <87msayc8l7.fsf@stebalien.com> <86v7plvvma.fsf@gnu.org> <875xhbgwbj.fsf@stebalien.com> <868qm3j2zr.fsf@gnu.org> <875xh7lejk.fsf@stebalien.com> <86qzzvh3r1.fsf@gnu.org> <871prufbsx.fsf@stebalien.com> <87o6uyyr13.fsf@stebalien.com> Date: Sun, 08 Jun 2025 15:46:38 -0700 Message-ID: <87bjqxsvg1.fsf@stebalien.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Steven Allen writes: > The former (custom theme) sounds like what use-package does with :custom > (it defines a use-package theme). Maybe just implement :custom-face the same way :custom is > implemented? I.e.: > > > (defun use-package-handler/:custom-face (name _keyword args rest state) > (use-package-concat > (if (bound-and-true-p use-package-use-theme) > `((let ((custom--inhibit-theme-enable nil)) > ;; Declare the theme here so use-package can be required inside > ;; eval-and-compile without warnings about unknown theme. > (unless (memq 'use-package custom-known-themes) > (deftheme use-package) > (enable-theme 'use-package) > (setq custom-enabled-themes (remq 'use-package custom-enabled-themes))) > (custom-theme-set-faces > 'use-package > ,@(mapcar > #'(lambda (def) > (let ((face (nth 0 def)) > (spec (nth 1 def)) > (comment (nth 2 def))) > (unless (and comment (stringp comment)) > (setq comment (format "Customized with use-package %s" name))) > `(backquote (,face ,spec nil ,comment)))) > args)))) > (mapcar > #'(lambda (def) > (let ((face (nth 0 def)) > (spec (nth 1 def)) > (comment (nth 2 def))) > (unless (and comment (stringp comment)) > (setq comment (format "Customized with use-package %s" name))) > `(custom-set-faces (backquote (,face ,spec t ,comment))))) > args)) > (use-package-process-keywords name rest state))) This version has a bug: if a new theme is enabled (e.g., the user switches themes at runtime), that new theme will take precedence over this "use-package" theme. This differs from the behavior of `custom-set-faces' which ALWAYS takes precedence. If there's a way to use `custom-set-faces' with no custom themes, that would be better. I CAN fix (hack) this with a hook to reapply the theme as follows: (defun use-package--reapply-theme (theme) (unless (or (memq theme '(use-package user)) ;; prevents recursion (memq 'use-package custom-enabled-themes)) (enable-theme 'use-package) (setq custom-enabled-themes (remq 'use-package custom-enabled-themes)))) (add-hook 'enable-theme-functions #'use-package--reapply-theme) This mimic's the behavior of the "user" theme (the theme used by `custom-set-faces') in `enable-theme' (reproduced below): (defun enable-theme (theme) ... (unless (eq theme 'user) (setq custom-enabled-themes (cons theme (remq theme custom-enabled-themes))) ;; Give the `user' theme the highest priority. (enable-theme 'user)) ;; Allow callers to react to the enabling. (run-hook-with-args 'enable-theme-functions theme)) HOWEVER, it will cause the "user" theme to be applied twice (because we're calling `enable-theme' from within `enable-theme'), which isn't great.