GNU bug report logs - #77924
31.0.50; [Feature branch] Change marker implementation

Previous Next

Full log

Message #65 received at 77924 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: monnier <at> iro.umontreal.ca, gerd.moellmann <at> gmail.com
Cc: stefankangas <at> gmail.com, 77924 <at> debbugs.gnu.org
Subject: Re: bug#77924: 31.0.50; [Feature branch] Change marker implementation
Date: Wed, 23 Apr 2025 17:47:24 +0300

> Cc: gerd.moellmann <at> gmail.com, stefankangas <at> gmail.com, 77924 <at> debbugs.gnu.org
> Date: Wed, 23 Apr 2025 17:41:18 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> > Cc: Eli Zaretskii <eliz <at> gnu.org>,  stefankangas <at> gmail.com,
> >   77924 <at> debbugs.gnu.org
> > Date: Wed, 23 Apr 2025 10:34:11 -0400
> > 
> > FWIW, I'm not a great fan of rebasing either.  I did rebase the branch
> > last night not for rebasing's sake but because I felt there was a need
> > for more detailed commit messages.
> > 
> > In any case, any objection to merging the branch?
> 
> I'd like to have a closer review of it first, so please wait for a
> while.  When I skimmed it, I remember having several, hopefully minor,
> aspects that stood out, and I want to take a closer look.

Btw, did I miss some benchmarks?  I presume that the main motivation
for this branch is to speed up markers and charpos-to-bytepos
conversions, is that right?  If so, the only benchmark I saw shows only
a very mild speed-up, but maybe I missed something?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.