Subject: Re: [bug#77922] [PATCH] services: pounce: New service.

From: Ludovic Courtès <[email-masked]>
Date: Sat, 19 Apr 2025 22:50:02 +0200

Hello,

Maxim Cournoyer <[email-masked]> writes:

> * gnu/services/messaging.scm (pounce-serialize-boolean):
> (pounce-serialize-string, pounce-serialize-list-of-strings)
> (pounce-serialize-pair, power-of-two?)
> (pounce-serialize-number, pounce-serialize-power-of-two)
> (pounce-serialize-port, pounce-serialize-maybe-boolean)
> (pounce-serialize-maybe-number, pounce-serialize-maybe-pair)
> (pounce-serialize-maybe-port, pounce-serialize-maybe-port
> (pounce-maybe-power-of-two, pounce-serialize-maybe-string)
> (pounce-serialize-maybe-list-of-strings): New procedures.
> (pounce-configuration): New configuration.
> (pounce-activation): New procedure.
> (serialize-pounce-configuration, pounce-wrapper): Likewise.
> (pounce-service-type): New service type.
> * gnu/tests/messaging.scm (ngircd-tls-cert-service-type): New variable.
> (%pounce-os): Likewise.
> (run-pounce-test): New procedure.
> (%test-pounce): New test.
> * doc/guix.texi (Messaging Services): Document it.
>
> Change-Id: I4bbd2bc4821072a93c2c4017b86df329c4b240cb

I had a quick look and this looks great to me.

Minor issues:

> +@item @code{local-ca} (type: maybe-string)
> +Require clients to authenticate using a TLS client certificate either
> +contained in or signed by a certificate in the file loaded from
> +@{local-ca

There’s a bug here: the line is truncated and markup is bogus.

Also maybe “local-certificate-authorities”?

> +@item @code{local-cert} (type: maybe-string)

“local-certificate”?

> +@item @code{local-priv} (type: maybe-string)

“local-private-key”

> +@item @code{client-cert} (type: maybe-string)

[...]

> +@item @code{client-priv} (type: maybe-string)

Likewise.

Thanks,
Ludo’.