GNU bug report logs - #77917
31.0.50; [PATCH] Stop using the "stop" sign for all warning levels

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 77917 <at> debbugs.gnu.org, Ihor Radchenko <yantar92 <at> posteo.net>, prot <at> protesilaos.com
Subject: bug#77917: 31.0.50; [PATCH] Stop using the "stop" sign for all warning levels
Date: Wed, 07 May 2025 09:57:11 +0300

> I conclude from that that we should use U+26A0 U+FE0F ⚠️ as the symbol
> to insert. Right clicking does not necessarily come easy to Emacs
> users, so I still think a text button is needed.

Ok, based on the feedback from everyone here is the patch
that should satisfy all requirements:

diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 6c77d57a6ba..f3baa019ad2 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -216,7 +216,7 @@ warning-suppress-p
     some-match))
 
 (define-icon warnings-suppress button
-  `((emoji "⛔")
+  `((emoji "⚠️")
     ;; Many MS-Windows console fonts don't have good glyphs for U+25A0.
     (symbol ,(if (and (eq system-type 'windows-nt)
                       (null window-system))
@@ -333,6 +333,14 @@ display-warning
 	      (insert (format (nth 1 level-info)
 			      (format warning-type-format typename))
 		      message)
+              ;; Don't output the buttons when doing batch compilation
+              ;; and similar.
+              (unless (or noninteractive (eq type 'bytecomp))
+                (insert " " (buttonize (propertize
+                                        "[Suppress]" 'face
+                                        '(variable-pitch (:height 0.9)))
+                                       #'warnings-suppress type)
+                        " "))
               (funcall newline)
 	      (when (and warning-fill-prefix
                          (not (string-search "\n" message))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.