Subject: Re: bug#77917: 31.0.50; [PATCH] Stop using the "stop" sign for all warning levels

From: Juri Linkov <[email-masked]>
Date: Thu, 08 May 2025 20:20:01 +0300

>>  (define-icon warnings-suppress button
>> -  `((emoji "⛔")
>> -    ;; Many MS-Windows console fonts don't have good glyphs for U+25A0.
>> +  `((emoji "⚠️")
>> +    ;; Many MS-Windows console fonts don't have good glyphs for symbols.
>>      (symbol ,(if (and (eq system-type 'windows-nt)
>>                        (null window-system))
>>                   " » "
>> -               " ■ "))
>> -    (text " stop "))
>> -  "Suppress warnings."
>> -  :version "29.1"
>> +               " ⚠ "))
>> +    (text " warning "))
>
> Since the 'symbol' value was changed to express "warning" rather than
> "suppress", the symbol used for terminals on MS-Windows needs to be
> also modified, since the previous one has nothing in common with
> "warning".

⚠️ contains an exclamation mark, so the symbol could be just '!' or '!!'
like in flymake's margin/fringe.

> Also, are you sure that show U+26A0 ⚠ is a good idea for the 'symbol'
> preference?  At least on TTY frames, that character has problems
> because its glyph is wide, and many terminal emulators have trouble
> showing it in an Emacs window.

I tried ⚠ on a tty, and it looks very poor, barely recognizable.
So need to find a new symbol.

> Btw, since this icon is called "warning-suppress", did anyone think
> about showing a cross or a strike-through over the icon/symbol?
> Because using ⚠ as "warning-suppress" is at least strange, IMO.

Since the general preference is to have the [Suppress] link at the end,
we need to use a new name "warning" for the icon.

Therefore I retract my patch in favor of Kévin's patch from
https://debbugs.gnu.org/61413#108 that added the new icon "warning"
with a nice svg image.  When installed, it should be tweaked
for further improvements (including FIXME).