From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 08:32:13 2025 Received: (at submit) by debbugs.gnu.org; 18 Apr 2025 12:32:14 +0000 Received: from localhost ([127.0.0.1]:50566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5kt2-0007Pg-Fe for submit@debbugs.gnu.org; Fri, 18 Apr 2025 08:32:13 -0400 Received: from lists.gnu.org ([2001:470:142::17]:48686) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5kss-0007Lw-5B for submit@debbugs.gnu.org; Fri, 18 Apr 2025 08:32:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5ksb-0000ZY-Qv for bug-gnu-emacs@gnu.org; Fri, 18 Apr 2025 08:31:41 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5ksJ-0003qt-9y for bug-gnu-emacs@gnu.org; Fri, 18 Apr 2025 08:31:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1744979467; bh=gbW0k5u6xC0RdwnLNsWckyCOXUujkD0sqDl9b0HakyA=; h=Content-Type:Message-ID:Date:User-Agent:From:Content-Language:To: Subject:From; b=oDUQygbQK76R4e8CDxBsXfm6gtywzZevjWNPXemqWInYxtrQXrHFwUqfPM4RIif6+ MHz2Sp4XWaTnsRkAOYK/h54tdjDzmxMvclaQoy07PAOc+5PNOyqVyT7FTO6XYUMSID 6jtZAD98NDWbmQTTy+7rL8EbbVWOIDxzQMyhqRgU= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4ZfDdR1rSvz1xxW for ; Fri, 18 Apr 2025 12:31:07 +0000 (UTC) Received: from [192.168.178.41] (port-83-236-5-224.dynamic.as20676.net [83.236.5.224]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4ZfDdL6RqGz904q for ; Fri, 18 Apr 2025 12:30:59 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------D7WBYNU3PDAzh9pvkApl3rCo" Message-ID: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> Date: Fri, 18 Apr 2025 14:30:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Jens Schmidt Content-Language: de-DE-frami, en-US To: bug-gnu-emacs@gnu.org Subject: 31.0.50; arc-mode: Split PKZIP archive signature not recognized X-purgate-server: smtpa03 X-purgate-type: clean X-purgate: clean X-purgate-size: 7222 X-purgate-ID: 155817::1744979463-7B42076E-2B78920F/0/0 Received-SPF: pass client-ip=145.253.228.166; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr6.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------D7WBYNU3PDAzh9pvkApl3rCo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit The attached zip file is a "real" one, in the sense that it has been created in the wild. It is a stripped down "terraform stack" generated by one of the cloud providers. InfoZIP's unzip can handle that file without problems: [emacs-master]$ unzip -v UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP. [...] [emacs-master]$ unzip -l tf-stack.zip Archive: tf-stack.zip Length Date Time Name --------- ---------- ----- ---- 38 2025-04-01 08:43 provider.tf --------- ------- 38 1 file However, "./src/emacs -Q tf-stack.zip" fails on it with: File mode specification error: (error "Buffer format not recognized") It turns out that the zip file starts with a special marker 0x08074b50 for spanned or split archives, as defined in the pseudo zip file specification "APPNOTE.txt" by PKWARE. See section 8.5 "Capacities and Markers" of that document for more details. The attached patch provides support for the aforementioned special marker, alongside with the already present "temporary spanning marker" 0x30304b50. The patch itself is trivial, but I tried to provide above information also in the commit message for future reference. WDYT? Thanks! In GNU Emacs 31.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2025-04-18 built on sappc2 Repository revision: 9f0c43a3d1b38c93bf21bf25db0f5dd489338d7c Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201009 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --with-native-compilation --with-mailutils' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR GTK3 ZLIB Important settings: value of $LC_COLLATE: POSIX value of $LC_TIME: POSIX value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug lisp-mnt message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils compile text-property-search comint subr-x ansi-osc ansi-color ring comp-run bytecomp byte-compile comp-common rx arc-mode archive-mode rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process tty-child-frames native-compile emacs) Memory information: ((conses 16 72011 11711) (symbols 48 7037 0) (strings 32 18600 1457) (string-bytes 1 583099) (vectors 16 11590) (vector-slots 8 158155 10743) (floats 8 23 12) (intervals 56 264 0) (buffers 984 13)) --------------D7WBYNU3PDAzh9pvkApl3rCo Content-Type: application/zip; name="tf-stack.zip" Content-Disposition: attachment; filename="tf-stack.zip" Content-Transfer-Encoding: base64 UEsHCFBLAwQUAAAICABjRYFaK5UFUyMAAAAmAAAACwAAAHByb3ZpZGVyLnRmKyjKL8tMSS1S yE/OVKjm4ixKTc/Mz1OwVShLLNKDcLhquQBQSwECMwMUAAAICABjRYFaK5UFUyMAAAAmAAAA CwAAAAAAAAAAAAAApIEEAAAAcHJvdmlkZXIudGZQSwUGAAAAAAEAAQA5AAAAUAAAAAAA --------------D7WBYNU3PDAzh9pvkApl3rCo Content-Type: text/x-patch; charset=UTF-8; name="0001-Detect-more-types-of-split-zip-archives.patch" Content-Disposition: attachment; filename="0001-Detect-more-types-of-split-zip-archives.patch" Content-Transfer-Encoding: base64 RnJvbSBkNmRlZWI2NzI0YjVkMjJhMTVhZjY3YzczZTBhNTc1MmI3Y2ViYjQ2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IEZyaSwgMTggQXByIDIwMjUgMTQ6MTY6MTcgKzAyMDAKU3Vi amVjdDogW1BBVENIXSBEZXRlY3QgbW9yZSB0eXBlcyBvZiBzcGxpdCB6aXAgYXJjaGl2ZXMK CkFjY29yZGluZyB0byB0aGUgaW5vZmZpY2lhbCB6aXAgZmlsZSBzcGVjaWZpY2F0aW9uIEFQ UE5PVEUudHh0IGJ5ClBLV0FSRSwgemlwIGZpbGVzIGNhbiBjb21lIHdpdGggZXh0cmEgc2ln bmF0dXJlcyAweDA4MDc0YjUwIG9yCjB4MzAzMDRiNTAgYmVmb3JlIHRoZSBsb2NhbCBoZWFk ZXIuICBTZWUgU2VjdGlvbiAiQ2FwYWNpdGllcyBhbmQKTWFya2VycyIgb2YgdGhhdCBkb2N1 bWVudC4KCiogbGlzcC9hcmMtbW9kZS5lbCAoYXJjaGl2ZS1maW5kLXR5cGUpOiBEZXRlY3Qg bW9yZSB0eXBlcyBvZiBzcGxpdCB6aXAKYXJjaGl2ZXMuICAoQnVnIFhYWFhYKQotLS0KIGxp c3AvYXJjLW1vZGUuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL2FyYy1tb2RlLmVsIGIvbGlzcC9h cmMtbW9kZS5lbAppbmRleCAyOGJlMWU5YzYxNy4uYjRjNDUzMTgwMjggMTAwNjQ0Ci0tLSBh L2xpc3AvYXJjLW1vZGUuZWwKKysrIGIvbGlzcC9hcmMtbW9kZS5lbApAQCAtNzkyLDcgKzc5 Miw3IEBAIGFyY2hpdmUtZmluZC10eXBlCiAgIDs7IFRoZSBmdW5ueSBbXSBoZXJlIG1ha2Ug aXQgdW5saWtlbHkgdGhhdCB0aGUgLmVsYyBmaWxlIHdpbGwgYmUgdHJlYXRlZAogICA7OyBh cyBhbiBhcmNoaXZlIGJ5IG90aGVyIHNvZnR3YXJlLgogICAobGV0IChjYXNlLWZvbGQtc2Vh cmNoKQotICAgIChjb25kICgobG9va2luZy1hdCAiXFwoUEswMFxcKT9bUF1LXDAwM1wwMDQi KSAnemlwKQorICAgIChjb25kICgobG9va2luZy1hdCAiXFwoPzpQSzAwXFx8UEtcMDA3XDAx MFxcKT9bUF1LXDAwM1wwMDQiKSAnemlwKQogCSAgKChsb29raW5nLWF0ICIuLi1sW2h6XVsw LTlkc10tIikgJ2x6aCkKIAkgICgobG9va2luZy1hdCAiLi4uLi4uLi4uLi4uLi4uLi4uLi5b XDMzNF1cMjQ3XDMwNFwzNzUiKSAnem9vKQogCSAgKChhbmQgKGxvb2tpbmctYXQgIlxDLXoi KQk7IHNpZ25hdHVyZSB0b28gc2ltcGxlLCBJTUhPCi0tCjIuMzkuNQo= --------------D7WBYNU3PDAzh9pvkApl3rCo-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 08:40:26 2025 Received: (at 77898) by debbugs.gnu.org; 18 Apr 2025 12:40:27 +0000 Received: from localhost ([127.0.0.1]:50582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5l14-0000Zj-8I for submit@debbugs.gnu.org; Fri, 18 Apr 2025 08:40:26 -0400 Received: from mr5.vodafonemail.de ([145.253.228.165]:59832) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5l0x-0000Sq-Ba for 77898@debbugs.gnu.org; Fri, 18 Apr 2025 08:40:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1744980004; bh=fFVyAu/o3wSd4lX+xT5Qa0T2jn3WVIz1EqHNQxALsBs=; h=Message-ID:Date:User-Agent:Subject:To:References:From: Content-Language:In-Reply-To:Content-Type:From; b=YJDO1cVan1LjvLnnwQvTu8Q/O54Yz4zHPwy940kvlqLigp0UkaaI3bTujkvpnyWNj jvDCRkmIJ+MvO9udxN7Sr4CkFlrlPWpXofdbnFKd/lsXjeK0cnVchD8rFIfWNkkKi5 w9rOUVaF5atPRcC2u6m0vLLo5D6JPuXLKmj/SLLk= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4ZfDqm499Sz201v for <77898@debbugs.gnu.org>; Fri, 18 Apr 2025 12:40:04 +0000 (UTC) Received: from [192.168.178.41] (port-83-236-5-224.dynamic.as20676.net [83.236.5.224]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4ZfDqh1KWsz918d for <77898@debbugs.gnu.org>; Fri, 18 Apr 2025 12:39:57 +0000 (UTC) Message-ID: <0cf9b5c3-1630-436c-8eed-6222b3540b30@vodafonemail.de> Date: Fri, 18 Apr 2025 14:39:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77898: Acknowledgement (31.0.50; arc-mode: Split PKZIP archive signature not recognized) To: 77898@debbugs.gnu.org References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-server: smtpa02 X-purgate-type: clean X-purgate: clean X-purgate-size: 339 X-purgate-ID: 155817::1744980000-C6C5D98B-C45926F4/0/0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77898 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) For a simpler reproducer, I just noticed that zip -s1000000 split.zip README with InfoZIP's zip 3.0 [emacs-master]$ zip -v Copyright (c) 1990-2008 Info-ZIP - Type 'zip "-L"' for software license. This is Zip 3.0 (July 5th 2008), by Info-ZIP. also creates such zip files that Emacs (without my patch) cannot grok. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 08:51:48 2025 Received: (at 77898) by debbugs.gnu.org; 18 Apr 2025 12:51:49 +0000 Received: from localhost ([127.0.0.1]:50598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5lC4-0002ew-KI for submit@debbugs.gnu.org; Fri, 18 Apr 2025 08:51:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52486) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5lBw-0002ca-D2 for 77898@debbugs.gnu.org; Fri, 18 Apr 2025 08:51:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5lBn-0005cS-V3; Fri, 18 Apr 2025 08:51:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KjiMsm2f2NORyUKT40ku4ga3oipOrVW7LgIWbFhJvCQ=; b=Ji2qxHfJvA6L w8w1bHAybxFaMEgZWV1EGF244qyx3CWpz3/hUiXFZ/Hbda8J4MGie69n/pBq0q4IUhC/84Na8v9X5 2roJvS8jwwihQ8JbsVmuJny1ZZpnsICtk/8KFJgnMJ0W9/ntkAv3Kt1UMpnrbxE0RKCoT4SWz/NyI XPS6OJRuWjfJulvhxMvBK3PqyCc78FGx3SVoyrzP2ABSuTVG/d8Bik1fjmYVa4EfZQR5f4jIE4nqe ZTT03u7ehIixB2MQ8DGSzyQ1Hyur+k2uQJrPOskHUyU/9lEbItla5vzeU0X5m3WgPqX/QQ0kjNugQ SYIU2hZOWEQpABY1OCVRcQ==; Date: Fri, 18 Apr 2025 15:51:13 +0300 Message-Id: <86wmbhab0e.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 18 Apr 2025 14:30:59 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > The attached zip file is a "real" one, in the sense that it has been > created in the wild. It is a stripped down "terraform stack" generated > by one of the cloud providers. > > InfoZIP's unzip can handle that file without problems: > > [emacs-master]$ unzip -v > UnZip 6.00 of 20 April 2009, by Debian. Original by Info-ZIP. > [...] > > [emacs-master]$ unzip -l tf-stack.zip > Archive: tf-stack.zip > Length Date Time Name > --------- ---------- ----- ---- > 38 2025-04-01 08:43 provider.tf > --------- ------- > 38 1 file > > However, "./src/emacs -Q tf-stack.zip" fails on it with: > > File mode specification error: (error "Buffer format not recognized") > > It turns out that the zip file starts with a special marker 0x08074b50 > for spanned or split archives, as defined in the pseudo zip file > specification "APPNOTE.txt" by PKWARE. See section 8.5 "Capacities and > Markers" of that document for more details. > > The attached patch provides support for the aforementioned special > marker, alongside with the already present "temporary spanning marker" > 0x30304b50. The patch itself is trivial, but I tried to provide above > information also in the commit message for future reference. > > WDYT? Please add comments describing the possible signatures, with pointers to specific sections of APPNOTE.txt. Also, is it possible to add some tests for this? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 08:32:14 2025 Received: (at 77898) by debbugs.gnu.org; 19 Apr 2025 12:32:14 +0000 Received: from localhost ([127.0.0.1]:59616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u67Mj-0002qh-MH for submit@debbugs.gnu.org; Sat, 19 Apr 2025 08:32:13 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:37698) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u67Mh-0002q5-1Z for 77898@debbugs.gnu.org; Sat, 19 Apr 2025 08:32:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1745065925; bh=jXngbwccpnAfVAPKmc4l51PmN39J5HqRLiU2/aX3PIM=; h=Message-ID:Date:User-Agent:Subject:To:References:From: Content-Language:In-Reply-To:Content-Type:From; b=UWovwUtyElht0Q9EgZcqg6XL0ECZpNw7mqOD1q3dYc4XbdGdxvmAwpOJkHzwrcynX /MYLfwUtj8xnmhdIWAH/tWxPfqhlq0e6ziY3njO9vOW1FkfOhbJm94+E47C/znFsQ5 fVli0iG8WXAJBfxg/qF135i1RRDN/nDmZqcgXOjI= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4Zfrc426Cgz1y21; Sat, 19 Apr 2025 12:32:03 +0000 (UTC) Received: from [192.168.0.74] (p54a6d2f4.dip0.t-ipconnect.de [84.166.210.244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Zfrbv66yCz8slq; Sat, 19 Apr 2025 12:31:52 +0000 (UTC) Message-ID: <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> Date: Sat, 19 Apr 2025 14:31:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized To: Eli Zaretskii References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: <86wmbhab0e.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-purgate-server: smtpa06 X-purgate-type: clean X-purgate: clean X-purgate-size: 1065 X-purgate-ID: 155817::1745065919-90F82BDC-1D8807F4/0/0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2025-04-18 14:51, Eli Zaretskii wrote: > Please add comments describing the possible signatures, with pointers > to specific sections of APPNOTE.txt. As an aside, how would you add a comment to the first branch of a `cond' if you would like to keep the branches aligned to the *end* of the `cond' keyword? I usually do these as follows: (cond ;; See APPNOTE.txt (version 6.3.10) from PKWARE for the zip ;; file signatures: ;; - PK\003\004 == 0x04034b50: local file header signature ;; (section 4.3.7) ;; - PK\007\010 == 0x08074b50 (followed by local header): ;; spanned/split archive signature (section 8.5.3) ;; - PK00 == 0x30304b50 (followed by local header): temporary ;; spanned/split archive signature (section 8.5.4) ((looking-at "\\(?:PK\007\010\\|PK00\\)?[P]K\003\004") 'zip) But the Emacs indentation machinery clearly disagrees on that and I'm not sure to what extent Emacs's indentation is normative in its own sources. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 09:08:13 2025 Received: (at 77898) by debbugs.gnu.org; 19 Apr 2025 13:08:13 +0000 Received: from localhost ([127.0.0.1]:59997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u67vY-0000UQ-RW for submit@debbugs.gnu.org; Sat, 19 Apr 2025 09:08:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51146) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u67vV-0000U4-46 for 77898@debbugs.gnu.org; Sat, 19 Apr 2025 09:08:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u67vO-0003IX-E0; Sat, 19 Apr 2025 09:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XNoD4FxO4qqabKUF72Y/OM8GUJJT29lOizn+F7q2ms8=; b=cK91YmGU0LJd LPz8ZXr/R8QjDEaGhmoQQTZZnanWHvO4kXcYeeRTfraUZEVBAtVikhiHfRxNcko8XbW1432EBekv8 VLQfxiB1OGdbrRf/16bwZrJ9HnTx5YiereA++fIoG3AO1FW+c+zY7z9UTpVLq01IlFlX3LSBCJDF1 L8ihdpNseJp0r2zh2tedv7T1q3jOU3I8Hz9efB4a56eCattilaFd0BicUAMhsvYUHq8AwzqQwPBGi sxfhKsO80BVgN5fXW3GHMcYOp0zZ3diC53BOTblBYyI15lOGvuFzaqnaEKXZFCgnXd1Z9FfRVNNs+ 6V7On8CpxxL2FrSDcRCewg==; Date: Sat, 19 Apr 2025 16:07:59 +0300 Message-Id: <86o6ws8fkg.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> (message from Jens Schmidt on Sat, 19 Apr 2025 14:31:27 +0200) Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Apr 2025 14:31:27 +0200 > Cc: 77898@debbugs.gnu.org > From: Jens Schmidt > > As an aside, how would you add a comment to the first branch of a > `cond' if you would like to keep the branches aligned to the *end* > of the `cond' keyword? I usually do these as follows: > > (cond ;; See APPNOTE.txt (version 6.3.10) from PKWARE for the zip > ;; file signatures: > ;; - PK\003\004 == 0x04034b50: local file header signature > ;; (section 4.3.7) > ;; - PK\007\010 == 0x08074b50 (followed by local header): > ;; spanned/split archive signature (section 8.5.3) > ;; - PK00 == 0x30304b50 (followed by local header): temporary > ;; spanned/split archive signature (section 8.5.4) > ((looking-at "\\(?:PK\007\010\\|PK00\\)?[P]K\003\004") 'zip) Something like below, perhaps? (cond (looking-at ;; Comment "PATTERN" Or even ;; See APPNOTE.txt (cond ((looking-at "\\(?:PK\007\010\\|PK00\\)?[P]K\003\004") 'zip) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 15:08:49 2025 Received: (at 77898) by debbugs.gnu.org; 19 Apr 2025 19:08:49 +0000 Received: from localhost ([127.0.0.1]:37534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6DYW-0002Sd-GU for submit@debbugs.gnu.org; Sat, 19 Apr 2025 15:08:49 -0400 Received: from mr4.vodafonemail.de ([145.253.228.164]:54306) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6DYS-0002Rl-Gd for 77898@debbugs.gnu.org; Sat, 19 Apr 2025 15:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1745089718; bh=4VUe41O3Kq5PG2lBOC6TVwupxnQNs7lEidIWzT639tQ=; h=Content-Type:Message-ID:Date:User-Agent:Subject:To:References: From:Content-Language:In-Reply-To:From; b=ICftCw7jCv8ZCgQe7uhWF/yIoUFBJ7ML5C0/VwtBnjT6pfIiSBC8+5Q57vGxBauJi DNfzRz6adV4TtGbxe998Mny0ekDiIpKbiCRf+Dk5Bb19NdpKmUG0QM1qljzBFbwkgM Cxr45jF2ukY+Bb1SYpwQ4vlrX3CjrvB/2a9hFmQY= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr4.vodafonemail.de (Postfix) with ESMTPS id 4Zg1Pf58D4z1yHq; Sat, 19 Apr 2025 19:08:37 +0000 (UTC) Received: from [192.168.0.74] (p54a6d2f4.dip0.t-ipconnect.de [84.166.210.244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Zg1PP26KGz8sXc; Sat, 19 Apr 2025 19:08:22 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------2jdc13pIf0A9owmTb0VqRL03" Message-ID: Date: Sat, 19 Apr 2025 21:08:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized To: Eli Zaretskii References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> <86o6ws8fkg.fsf@gnu.org> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: <86o6ws8fkg.fsf@gnu.org> X-purgate-server: smtpa05 X-purgate-type: clean X-purgate: clean X-purgate-size: 10790 X-purgate-ID: 155817::1745089713-76F85F4E-63107164/0/0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------2jdc13pIf0A9owmTb0VqRL03 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2025-04-19 15:07, Eli Zaretskii wrote: > Or even > > ;; See APPNOTE.txt > (cond ((looking-at "\\(?:PK\007\010\\|PK00\\)?[P]K\003\004") 'zip) Thanks, I went for that. Please find attached the next version of the patch. I added tests not only for zip and split zip detection, but also for all archivers that follow the calling pattern ARCHIVER PARAMETER... ARCHIVE FILE... and that I could easily install on my GNU/Linux system. Which were surprisingly many. Of course, such tests are highly OS-dependent any have the potential of causing a lot of failures, even though I tried to code them in a defensive manner. WDYT? Thanks. --------------2jdc13pIf0A9owmTb0VqRL03 Content-Type: text/x-patch; charset=UTF-8; name="0001-Detect-more-types-of-split-zip-archives.patch" Content-Disposition: attachment; filename="0001-Detect-more-types-of-split-zip-archives.patch" Content-Transfer-Encoding: base64 RnJvbSAxMGM3MWI1MjlhNjc0MzQxZDVlMDBjNjk5Mjg0NGYwYmI4NmJjMGFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IEZyaSwgMTggQXByIDIwMjUgMTQ6MTY6MTcgKzAyMDAKU3Vi amVjdDogW1BBVENIXSBEZXRlY3QgbW9yZSB0eXBlcyBvZiBzcGxpdCB6aXAgYXJjaGl2ZXMK CiogbGlzcC9hcmMtbW9kZS5lbCAoYXJjaGl2ZS1maW5kLXR5cGUpOiBEZXRlY3QgbW9yZSB0 eXBlcyBvZiBzcGxpdCB6aXAKYXJjaGl2ZXMuCiogdGVzdC9saXNwL2FyYy1tb2RlLXRlc3Rz LmVsIChhcmMtbW9kZS10ZXN0LW1ha2UtZmlsZSkKKGFyYy1tb2RlLXRlc3QtbWFrZS1hcmNo aXZlKTogRmFjdG9yIG91dCBmdW5jdGlvbnMgZnJvbSAuLi4KKGFyYy1tb2RlLXRlc3Qtemlw LWVuc3VyZS1leHQpOiAuLi4gdGhpcyB0ZXN0LgooZGVmaW5lLWFyYy1tb2RlLXRlc3Qtb24t dHlwZSk6IEFkZCBtYWNybyB0byB0ZXN0IGZ1bmN0aW9uCmBhcmNoaXZlLWZpbmQtdHlwZScg YW5kIHVzZSB0aGUgbWFjcm8gdG8gdGVzdCBkZXRlY3Rpb24gb2YgdmFyaW91cwphcmNoaXZl IHR5cGVzLiAgKEJ1ZyA3Nzg5OCkKLS0tCiBsaXNwL2FyYy1tb2RlLmVsICAgICAgICAgICAg fCAxMCArKystCiB0ZXN0L2xpc3AvYXJjLW1vZGUtdGVzdHMuZWwgfCA5MiArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDg4IGluc2Vy dGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvYXJjLW1vZGUu ZWwgYi9saXNwL2FyYy1tb2RlLmVsCmluZGV4IDI4YmUxZTljNjE3Li42NDZkZjc3MGRlMiAx MDA2NDQKLS0tIGEvbGlzcC9hcmMtbW9kZS5lbAorKysgYi9saXNwL2FyYy1tb2RlLmVsCkBA IC03OTIsNyArNzkyLDE1IEBAIGFyY2hpdmUtZmluZC10eXBlCiAgIDs7IFRoZSBmdW5ueSBb XSBoZXJlIG1ha2UgaXQgdW5saWtlbHkgdGhhdCB0aGUgLmVsYyBmaWxlIHdpbGwgYmUgdHJl YXRlZAogICA7OyBhcyBhbiBhcmNoaXZlIGJ5IG90aGVyIHNvZnR3YXJlLgogICAobGV0IChj YXNlLWZvbGQtc2VhcmNoKQotICAgIChjb25kICgobG9va2luZy1hdCAiXFwoUEswMFxcKT9b UF1LXDAwM1wwMDQiKSAnemlwKQorICAgIDs7ICAgICAgIFNlZSBBUFBOT1RFLnR4dCAodmVy c2lvbiA2LjMuMTApIGZyb20gUEtXQVJFIGZvciB0aGUgemlwCisgICAgOzsgICAgICAgZmls ZSBzaWduYXR1cmVzOgorICAgIDs7ICAgICAgIC0gUEtcMDAzXDAwNCA9PSAweDA0MDM0YjUw OiBsb2NhbCBmaWxlIGhlYWRlciBzaWduYXR1cmUKKyAgICA7OyAgICAgICAgIChzZWN0aW9u IDQuMy43KQorICAgIDs7ICAgICAgIC0gUEtcMDA3XDAxMCA9PSAweDA4MDc0YjUwIChmb2xs b3dlZCBieSBsb2NhbCBoZWFkZXIpOgorICAgIDs7ICAgICAgICAgc3Bhbm5lZC9zcGxpdCBh cmNoaXZlIHNpZ25hdHVyZSAoc2VjdGlvbiA4LjUuMykKKyAgICA7OyAgICAgICAtIFBLMDAg PT0gMHgzMDMwNGI1MCAoZm9sbG93ZWQgYnkgbG9jYWwgaGVhZGVyKTogdGVtcG9yYXJ5Cisg ICAgOzsgICAgICAgICBzcGFubmVkL3NwbGl0IGFyY2hpdmUgc2lnbmF0dXJlIChzZWN0aW9u IDguNS40KQorICAgIChjb25kICgobG9va2luZy1hdCAiXFwoPzpQS1wwMDdcMDEwXFx8UEsw MFxcKT9bUF1LXDAwM1wwMDQiKSAnemlwKQogCSAgKChsb29raW5nLWF0ICIuLi1sW2h6XVsw LTlkc10tIikgJ2x6aCkKIAkgICgobG9va2luZy1hdCAiLi4uLi4uLi4uLi4uLi4uLi4uLi5b XDMzNF1cMjQ3XDMwNFwzNzUiKSAnem9vKQogCSAgKChhbmQgKGxvb2tpbmctYXQgIlxDLXoi KQk7IHNpZ25hdHVyZSB0b28gc2ltcGxlLCBJTUhPCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Av YXJjLW1vZGUtdGVzdHMuZWwgYi90ZXN0L2xpc3AvYXJjLW1vZGUtdGVzdHMuZWwKaW5kZXgg ZjBiYjQ2ZDczNGYuLmY2Yzg0ZGIxYWQ4IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvYXJjLW1v ZGUtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL2FyYy1tb2RlLXRlc3RzLmVsCkBAIC02Miw2 ICs2Miw3OSBAQCBhcmMtbW9kZS10ZXN0LXppcC1leHRyYWN0LXRhci1hbmQtZ3oKICAgICAg ICh3aGVuIChidWZmZXItbGl2ZS1wIHRhci1idWZmZXIpIChraWxsLWJ1ZmZlciB0YXItYnVm ZmVyKSkKICAgICAgICh3aGVuIChidWZmZXItbGl2ZS1wIGd6LWJ1ZmZlcikgKGtpbGwtYnVm ZmVyIGd6LWJ1ZmZlcikpKSkpCiAKKyhkZWZ1biBhcmMtbW9kZS10ZXN0LW1ha2UtZmlsZSAo bmFtZSkKKyAgIkNyZWF0ZSBmaWxlIE5BTUUgaW4gZGVmYXVsdCBkaXJlY3Rvcnkgd2l0aCBj b250ZW50IE5BTUUuCitSZXR1cm4gTkFNRS4iCisgICh3aXRoLXRlbXAtYnVmZmVyCisgICAg KGluc2VydCBuYW1lKQorICAgICh3cml0ZS1maWxlIG5hbWUpKQorICBuYW1lKQorCisoZGVm dW4gYXJjLW1vZGUtdGVzdC1tYWtlLWFyY2hpdmUgKGNvbW1hbmQgYXJjIGZpbGVzKQorICAi Q2FsbCBDT01NQU5EIHRvIGNyZWF0ZSBhcmNoaXZlIEFSQyBjb250YWluaW5nIEZJTEVTLgor UmV0dXJuIGEgY29ucyAoQVJDIC4gRVhJVC1TVEFUVVMpLiIKKyAgKHVubGVzcyAobGlzdHAg Y29tbWFuZCkKKyAgICAoc2V0cSBjb21tYW5kIChsaXN0IGNvbW1hbmQpKSkKKyAgKGRlbGV0 ZS1maWxlIGFyYyBuaWwpCisgIChjb25zIGFyYyAoZnVuY2FsbCAoYXJjaGl2ZS0tYWN0LWZp bGVzIGNvbW1hbmQgZmlsZXMpIGFyYykpKQorCisoZGVmbWFjcm8gZGVmaW5lLWFyYy1tb2Rl LXRlc3Qtb24tdHlwZSAobmFtZSBjb21tYW5kIGV4dGVuc2lvbiB0eXBlKQorICAiRGVmaW5l IGFuZCBleGVjdXRlIGEgdGVzdCB0aGF0IHRlc3RzIGZ1bmN0aW9uIGBhcmNoaXZlLWZpbmQt dHlwZScuCitOYW1lIHRoZSB0ZXN0IGJhc2VkIG9uIE5BTUUuICBUaGUgZ2VuZXJhdGVkIHRl c3QgZmlyc3QgY2FsbHMKKworICAoY2FsbC1wcm9jZXNzIChjYXIgQ09NTUFORCkgbmlsIG5p bCBuaWwKKyAgICAgICAgICAgICAgICAoYXBwZW5kIENPTU1BTkQgKGxpc3QgQVJDSElWRSBN RU1CRVIpKSkKKwordG8gY3JlYXRlIGZpbGUgQVJDSElWRSB3aXRoIGV4dGVuc2lvbiBFWFRF TlNJT04gYW5kIGNvbnRhaW5pbmcgYSBzaW5nbGUKK21lbWJlciBNRU1CRVIuICBUaGVuIHRo ZSB0ZXN0IGZpbmRzIEFSQ0hJVkUgYW5kIGVuc3VyZXMgdGhhdCBmdW5jdGlvbgorYGFyY2hp dmUtZmluZC10eXBlJyBkZXRlY3RzIGl0IGFzIGFuIGFyY2hpdmUgaGF2aW5nIHR5cGUgVFlQ RS4iCisgIChsZXQqICgoY29tbWFuZCAoZXZhbCBjb21tYW5kKSkKKyAgICAgICAgIChhcmd2 MCAgIChjYXIgY29tbWFuZCkpCisgICAgICAgICAodHlwZSAgICAoZXZhbCB0eXBlKSkpCisg ICAgYChlcnQtZGVmdGVzdCAsKGludGVybiAoZm9ybWF0ICJhcmMtbW9kZS10ZXN0LXR5cGUt JXMiIG5hbWUpKSAoKQorICAgICAgIChza2lwLXVubGVzcyAoZXhlY3V0YWJsZS1maW5kICxh cmd2MCkpCisgICAgICAgKGxldCAoKGRlZmF1bHQtZGlyZWN0b3J5IGFyYy1tb2RlLXRlc3Rz LWRhdGEtZGlyZWN0b3J5KQorICAgICAgICAgICAgIChtZW1iZXIgbmlsKSAoYXJjaGl2ZSBu aWwpIChidWZmZXIgbmlsKQorICAgICAgICAgICAgIHJlc3VsdCBleGl0LXN0YXR1cyB0eXBl KQorICAgICAgICAgKHVud2luZC1wcm90ZWN0CisgICAgICAgICAgICAgKHByb2duCisgICAg ICAgICAgICAgICAoc2V0cSBtZW1iZXIgKGFyYy1tb2RlLXRlc3QtbWFrZS1maWxlICJtZW1i ZXIiKQorICAgICAgICAgICAgICAgICAgICAgcmVzdWx0IChhcmMtbW9kZS10ZXN0LW1ha2Ut YXJjaGl2ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocXVvdGUgLGNvbW1hbmQp ICwoZm9ybWF0ICJhcmMuJXMiIGV4dGVuc2lvbikgKGxpc3QgbWVtYmVyKSkKKyAgICAgICAg ICAgICAgICAgICAgIGFyY2hpdmUgKGNhciByZXN1bHQpCisgICAgICAgICAgICAgICAgICAg ICBleGl0LXN0YXR1cyAoY2RyIHJlc3VsdCkpCisgICAgICAgICAgICAgICA7OyBkbyBub3Qg Y291bnQgYXJjaGl2ZXIgZXJyb3JzIGFzIHRlc3QgZmFpbHVyZXMKKyAgICAgICAgICAgICAg IChza2lwLXVubGVzcyAoZXEgZXhpdC1zdGF0dXMgMCkpCisgICAgICAgICAgICAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlcgorICAgICAgICAgICAgICAgICAgIChzZXRxIGJ1ZmZlciAoZmlu ZC1maWxlLWxpdGVyYWxseSBhcmNoaXZlKSkKKyAgICAgICAgICAgICAgICAgKHNldHEgdHlw ZSAoY29uZGl0aW9uLWNhc2UgZXJyCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChhcmNoaXZlLWZpbmQtdHlwZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChl cnJvcgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDs7IHR1cm4gdGhlIG1vc3Qg bGlrZWx5IGVycm9yIGludG8gYSBuaWNlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgOzsgYW5kIHNlbGYtZXhwbGFpbmluZyBzeW1ib2wgdGhhdCBjYW4gYmUKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICA7OyBjb21wYXJlZCBpbiBhIGBzaG91bGQnCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlmIChzdHJpbmc9IChjYWRyIGVycikgIkJ1 ZmZlciBmb3JtYXQgbm90IHJlY29nbml6ZWQiKQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAnc2lnbmF0dXJlLW5vdC1yZWNvZ25pemVkCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc2lnbmFsIChjYXIgZXJyKSAoY2RyIGVycikpKSkpKQorICAg ICAgICAgICAgICAgICAoc2hvdWxkIChlcSB0eXBlIChxdW90ZSAsdHlwZSkpKSkpCisgICAg ICAgICAgICh3aGVuIGJ1ZmZlciAoa2lsbC1idWZmZXIgYnVmZmVyKSkKKyAgICAgICAgICAg KGRvbGlzdCAoZmlsZSAobGlzdCBtZW1iZXIgYXJjaGl2ZSkpCisgICAgICAgICAgICAgKHdo ZW4gZmlsZSAoaWdub3JlLWVycm9ycyAoZGVsZXRlLWZpbGUgZmlsZSkpKSkpKSkpKQorCiso ZGVmaW5lLWFyYy1tb2RlLXRlc3Qtb24tdHlwZSAiemlwIiAnKCJ6aXAiKSAiemlwIiAnemlw KQorCisoZGVmaW5lLWFyYy1tb2RlLXRlc3Qtb24tdHlwZSAic3BsaXQtemlwIiAnKCJ6aXAi ICItczEiKSAiemlwIiAnemlwKQorCisoZGVmaW5lLWFyYy1tb2RlLXRlc3Qtb24tdHlwZSAi YXJjIiAnKCJhcmMiICJhIikgImFyYyIgJ2FyYykKKworKGRlZmluZS1hcmMtbW9kZS10ZXN0 LW9uLXR5cGUgImxoYSIgJygibGhhIiAiYSIpICJsemgiICdsemgpCisKKyhkZWZpbmUtYXJj LW1vZGUtdGVzdC1vbi10eXBlICJyYXIiICcoInJhciIgImEiKSAicmFyIiAncmFyKQorCiso ZGVmaW5lLWFyYy1tb2RlLXRlc3Qtb24tdHlwZSAiYXIiICcoImFyIiAicSIpICJhIiAnYXIp CisKKyhkZWZpbmUtYXJjLW1vZGUtdGVzdC1vbi10eXBlICI3eiIgJygiN3phIiAiYSIpICI3 eiIgJzd6KQorCiAoZXJ0LWRlZnRlc3QgYXJjLW1vZGUtdGVzdC16aXAtZW5zdXJlLWV4dCAo KQogICAiUmVncmVzc2lvbiB0ZXN0IGZvciBidWcjNjEzMjYuIgogICAoc2tpcC11bmxlc3Mg KGV4ZWN1dGFibGUtZmluZCAiemlwIikpCkBAIC03MSwxNiArMTQ0LDYgQEAgYXJjLW1vZGUt dGVzdC16aXAtZW5zdXJlLWV4dAogICAgICAgICAgKGJhc2UtemlwLTIgImJhc2UtMi56aXAi KQogICAgICAgICAgKGNvbnRlbnQtMSAnKCIxIiAiMiIpKQogICAgICAgICAgKGNvbnRlbnQt MiAnKCIzIiAiNCIpKQotICAgICAgICAgKG1ha2UtZmlsZSAobGFtYmRhIChuYW1lKQotICAg ICAgICAgICAgICAgICAgICAgIChwdXNoIG5hbWUgY3JlYXRlZC1maWxlcykKLSAgICAgICAg ICAgICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgotICAgICAgICAgICAgICAgICAgICAg ICAgKGluc2VydCBuYW1lKQotICAgICAgICAgICAgICAgICAgICAgICAgKHdyaXRlLWZpbGUg bmFtZSkpKSkKLSAgICAgICAgIChtYWtlLXppcAotICAgICAgICAgIChsYW1iZGEgKHppcCBm aWxlcykKLSAgICAgICAgICAgIChkZWxldGUtZmlsZSB6aXAgbmlsKQotICAgICAgICAgICAg KHB1c2ggemlwIGNyZWF0ZWQtZmlsZXMpCi0gICAgICAgICAgICAoZnVuY2FsbCAoYXJjaGl2 ZS0tYWN0LWZpbGVzICcoInppcCIpIGZpbGVzKSB6aXApKSkKICAgICAgICAgICh1cGRhdGUt Zm4KICAgICAgICAgICAobGFtYmRhICh6aXAtbm9uZW1wdHkpCiAgICAgICAgICAgICAod2l0 aC1jdXJyZW50LWJ1ZmZlciAoZmluZC1maWxlLW5vc2VsZWN0IHppcC1ub25lbXB0eSkKQEAg LTEyMyw5ICsxODYsMTIgQEAgYXJjLW1vZGUtdGVzdC16aXAtZW5zdXJlLWV4dAogICAgICh1 bndpbmQtcHJvdGVjdAogICAgICAgICAocHJvZ24KICAgICAgICAgICA7OyBzZXR1cDogbWFr ZSB0d28gemlwIGZpbGVzIHdpdGggZGlmZmVyZW50IGNvbnRlbnRzCi0gICAgICAgICAgKG1h cGMgbWFrZS1maWxlIChhcHBlbmQgY29udGVudC0xIGNvbnRlbnQtMikpCi0gICAgICAgICAg KGZ1bmNhbGwgbWFrZS16aXAgYmFzZS16aXAtMSBjb250ZW50LTEpCi0gICAgICAgICAgKGZ1 bmNhbGwgbWFrZS16aXAgYmFzZS16aXAtMiBjb250ZW50LTIpCisgICAgICAgICAgKGRvbGlz dCAoZmlsZSAoYXBwZW5kIGNvbnRlbnQtMSBjb250ZW50LTIpKQorICAgICAgICAgICAgKHB1 c2ggKGFyYy1tb2RlLXRlc3QtbWFrZS1maWxlIGZpbGUpIGNyZWF0ZWQtZmlsZXMpKQorICAg ICAgICAgIChwdXNoIChjYXIgKGFyYy1tb2RlLXRlc3QtbWFrZS1hcmNoaXZlICJ6aXAiIGJh c2UtemlwLTEgY29udGVudC0xKSkKKyAgICAgICAgICAgICAgICBjcmVhdGVkLWZpbGVzKQor ICAgICAgICAgIChwdXNoIChjYXIgKGFyYy1tb2RlLXRlc3QtbWFrZS1hcmNoaXZlICJ6aXAi IGJhc2UtemlwLTIgY29udGVudC0yKSkKKyAgICAgICAgICAgICAgICBjcmVhdGVkLWZpbGVz KQogCiAgICAgICAgICAgOzsgdGVzdCAxOiB3aXRoICJ0ZXN0LXVwZGF0ZSIgYW5kICJ0ZXN0 LXVwZGF0ZS56aXAiLCB1cGRhdGUKICAgICAgICAgICA7OyAidGVzdC11cGRhdGUiOiAoMSkg ZW5zdXJlIG9ubHkgInRlc3QtdXBkYXRlIiBpcyBtb2RpZmllZCwgKDIpCi0tIAoyLjM5LjUK Cg== --------------2jdc13pIf0A9owmTb0VqRL03-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 09:10:09 2025 Received: (at 77898-done) by debbugs.gnu.org; 24 Apr 2025 13:10:09 +0000 Received: from localhost ([127.0.0.1]:37263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7wLB-0004oI-9t for submit@debbugs.gnu.org; Thu, 24 Apr 2025 09:10:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53690) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7wL7-0004nX-R1 for 77898-done@debbugs.gnu.org; Thu, 24 Apr 2025 09:10:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7wL2-0000II-7E; Thu, 24 Apr 2025 09:10:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Gebm8TMJexPUlTKZe1R1hEQqeBBjwDg9qi2IGEZgNfY=; b=ZVSjpH0qF5om 5wkKvdq0UWuSLIoNG8g4IPcyMIivmiNUJgdeQHU5c+qO9JyTSnpZ76/x8va0ypUkdNycJUN084DUf KqLuSMDIOzP8v5E9G1YHkUcitYzK3Gx1sRl+u5VZYmDQH3X1WQbVVv8hu/xyXWOkcSVRidt1sK31W VV/16nY2Fuue+Mu3JCeLA9Fcz7pAe8BpgC9JWOm08J1LhBHYRckVY9kAlthp1GWpjx4iZoujdnT9b AakNumTQz1xhRj1jP0eN9BADpwZrbO6XdQZPzNQsj2mrV6vreZR6lXl8KaxOEUFpvaEYHK4S++QjF vlQagaaZKybN4ZzbLYyE9g==; Date: Thu, 24 Apr 2025 16:09:54 +0300 Message-Id: <861pthzowt.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: (message from Jens Schmidt on Sat, 19 Apr 2025 21:08:21 +0200) Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> <86o6ws8fkg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77898-done Cc: 77898-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 19 Apr 2025 21:08:21 +0200 > Cc: 77898@debbugs.gnu.org > From: Jens Schmidt > > On 2025-04-19 15:07, Eli Zaretskii wrote: > > > Or even > > > > ;; See APPNOTE.txt > > (cond ((looking-at "\\(?:PK\007\010\\|PK00\\)?[P]K\003\004") 'zip) > > Thanks, I went for that. > > Please find attached the next version of the patch. I added tests not > only for zip and split zip detection, but also for all archivers that > follow the calling pattern > > ARCHIVER PARAMETER... ARCHIVE FILE... > > and that I could easily install on my GNU/Linux system. Which were > surprisingly many. > > Of course, such tests are highly OS-dependent any have the potential > of causing a lot of failures, even though I tried to code them in a > defensive manner. > > WDYT? LGTM, and the tests succeeded on my system, so I've now installed this on master, and I'm closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 17:42:02 2025 Received: (at 77898) by debbugs.gnu.org; 24 Apr 2025 21:42:03 +0000 Received: from localhost ([127.0.0.1]:42196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u84KY-0007CA-BR for submit@debbugs.gnu.org; Thu, 24 Apr 2025 17:42:02 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:39322) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u84KV-0007BP-SN for 77898@debbugs.gnu.org; Thu, 24 Apr 2025 17:42:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1745530913; bh=WdL5wcpAhkqVQJd8K+5w/zHXj6N/JZPSANVrrlxDcAw=; h=Content-Type:Message-ID:Date:User-Agent:Subject:To:References: From:Content-Language:In-Reply-To:From; b=jmUmYmjK94ApPQCzgSd+nx94nLUGj2lex54B6s4EaXV1RoawAzbzKbDMRwlIHr7+y FTrExdtlLoKYtMH4ief9JjWLS3AsmMbz7d3XDSPG1rOl5v51OiI2OevZcsHIdYzb8y cAQD0ZOP9VYk9f9gjYrCyKWUjq2K+6Amy/kTUGtU= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4Zk8Z9302Xz1yLY; Thu, 24 Apr 2025 21:41:53 +0000 (UTC) Received: from [192.168.178.41] (port-83-236-14-40.dynamic.as20676.net [83.236.14.40]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Zk8Z056Vfz90q9; Thu, 24 Apr 2025 21:41:40 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------nG5Q0HU7HcFzNXYau6suJJJX" Message-ID: Date: Thu, 24 Apr 2025 23:41:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized To: Eli Zaretskii References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> <86o6ws8fkg.fsf@gnu.org> <861pthzowt.fsf@gnu.org> From: Jens Schmidt Content-Language: de-DE-frami, en-US In-Reply-To: <861pthzowt.fsf@gnu.org> X-purgate-server: smtpa07 X-purgate-type: clean X-purgate: clean X-purgate-size: 3890 X-purgate-ID: 155817::1745530909-FD5A2B0D-FCBAFA54/0/0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------nG5Q0HU7HcFzNXYau6suJJJX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2025-04-24 15:09, Eli Zaretskii wrote: > LGTM, and the tests succeeded on my system, so I've now installed this > on master, and I'm closing the bug. Thanks. Two follow-up nits, not sure whether and how you'd like to handle them: - Your windows-nt-specific follow-up commit e38401e7 isn't at all windows-nt-specific, as I learned after I noticed it. On Debian GNU/Linux I have both executables "7z" and "7za" available with 7z(1) saying: 7z uses plugins to handle archives, so it might be slightly slower than 7za(1) but can handle more archive formats. So using executable "7z" for all ports seems to be TRT. (And yes, I have tested using (define-arc-mode-test-on-type "7z" '("7z" "a") "7z" '7z) on GNU/Linux successfully.) - And that part of my doc string of macro `define-arc-mode-test-on-type' is incorrect: "Define and execute a test that tests function `archive-find-type'. ^^ wrong ^^ Since the macro, strictly speaking, only *defines* a test, IIUC. Execution happens when command `ert' (or one of its derivatives) runs. Attached is a patch that fixes both of these. Please let me know what you think. Thanks again. --------------nG5Q0HU7HcFzNXYau6suJJJX Content-Type: text/x-patch; charset=UTF-8; name="0001-Fix-previous-arc-mode-test-commit.patch" Content-Disposition: attachment; filename="0001-Fix-previous-arc-mode-test-commit.patch" Content-Transfer-Encoding: base64 RnJvbSA2YWU2OWFkOGYyOGRmYjM0MWU5MzcxMTBhNDBiNWZiMWE4ZTgzMjU4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFRodSwgMjQgQXByIDIwMjUgMjM6MzI6NDUgKzAyMDAKU3Vi amVjdDogW1BBVENIXSA7IEZpeCBwcmV2aW91cyBhcmMtbW9kZS10ZXN0IGNvbW1pdAoKKiB0 ZXN0L2xpc3AvYXJjLW1vZGUtdGVzdHMuZWwgKGRlZmluZS1hcmMtbW9kZS10ZXN0LW9uLXR5 cGUpOiBEb2MgZml4LgooIjd6Iik6IFVzZSBhcmNoaXZlciBleGVjdXRhYmxlICI3eiIgb24g YWxsIHBvcnRzLgotLS0KIHRlc3QvbGlzcC9hcmMtbW9kZS10ZXN0cy5lbCB8IDkgKysrKy0t LS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9hcmMtbW9kZS10ZXN0cy5lbCBiL3Rlc3QvbGlzcC9h cmMtbW9kZS10ZXN0cy5lbAppbmRleCA1MWU4YTVlYmEzZi4uZGQ4ZmRmOWUwYmMgMTAwNjQ0 Ci0tLSBhL3Rlc3QvbGlzcC9hcmMtbW9kZS10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvYXJj LW1vZGUtdGVzdHMuZWwKQEAgLTc5LDcgKzc5LDcgQEAgYXJjLW1vZGUtdGVzdC1tYWtlLWFy Y2hpdmUKICAgKGNvbnMgYXJjIChmdW5jYWxsIChhcmNoaXZlLS1hY3QtZmlsZXMgY29tbWFu ZCBmaWxlcykgYXJjKSkpCiAKIChkZWZtYWNybyBkZWZpbmUtYXJjLW1vZGUtdGVzdC1vbi10 eXBlIChuYW1lIGNvbW1hbmQgZXh0ZW5zaW9uIHR5cGUpCi0gICJEZWZpbmUgYW5kIGV4ZWN1 dGUgYSB0ZXN0IHRoYXQgdGVzdHMgZnVuY3Rpb24gYGFyY2hpdmUtZmluZC10eXBlJy4KKyAg IkRlZmluZSBhIHRlc3QgdGhhdCB0ZXN0cyBmdW5jdGlvbiBgYXJjaGl2ZS1maW5kLXR5cGUn LgogTmFtZSB0aGUgdGVzdCBiYXNlZCBvbiBOQU1FLiAgVGhlIGdlbmVyYXRlZCB0ZXN0IGZp cnN0IGNhbGxzCiAKICAgKGNhbGwtcHJvY2VzcyAoY2FyIENPTU1BTkQpIG5pbCBuaWwgbmls CkBAIC0xMzMsMTAgKzEzMyw5IEBAICJyYXIiCiAKIChkZWZpbmUtYXJjLW1vZGUtdGVzdC1v bi10eXBlICJhciIgJygiYXIiICJxIikgImEiICdhcikKIAotKGRlZmluZS1hcmMtbW9kZS10 ZXN0LW9uLXR5cGUgIjd6IiAobGlzdCAoaWYgKGVxIHN5c3RlbS10eXBlICd3aW5kb3dzLW50 KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjd6IiAi N3phIikKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImEiKQot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjd6IiAnN3opCis7OyBwcmVmZXIgZXhl Y3V0YWJsZSAiN3oiIHRvICI3emEiLCBzaW5jZSB0aGUgZm9ybWVyIHNlZW1zIGJlIHN1cHBv cnRlZAorOzsgb24gYSBicm9hZGVyIHJhbmdlIG9mIHBvcnRzCisoZGVmaW5lLWFyYy1tb2Rl LXRlc3Qtb24tdHlwZSAiN3oiICcoIjd6IiAiYSIpICI3eiIgJzd6KQogCiAoZXJ0LWRlZnRl c3QgYXJjLW1vZGUtdGVzdC16aXAtZW5zdXJlLWV4dCAoKQogICAiUmVncmVzc2lvbiB0ZXN0 IGZvciBidWcjNjEzMjYuIgotLSAKMi4zOS41Cgo= --------------nG5Q0HU7HcFzNXYau6suJJJX-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 26 10:10:29 2025 Received: (at 77898) by debbugs.gnu.org; 26 Apr 2025 14:10:29 +0000 Received: from localhost ([127.0.0.1]:33743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8gEf-0004Yy-4c for submit@debbugs.gnu.org; Sat, 26 Apr 2025 10:10:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40776) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8gEc-0004Ye-0S for 77898@debbugs.gnu.org; Sat, 26 Apr 2025 10:10:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8gEV-0002F2-8D; Sat, 26 Apr 2025 10:10:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=J32kNtb02ezPtzY/b4Tco51QhTL2w7qjJ/Vb++AoxYI=; b=J3MpKlKfFouH P1XvvgIdOHUDVjtxXxwui7JOQAt7Q03E+a+vBbdiPzt4VxU77rUnBGbe5pVLs7CI2yaOM7XxFt6E3 w9MLYJzRj2mDtYPo4yRWJqOA9b4eaxXbGraN8BvvrksKmAmAYzJ9SVu37zh8qUHdOhFyFqP/ftuUY IMuYl1/Ro80ZYIZkvlQE8lIjJM/CnZSEQpG0wlhBJQJef8dyRhWtACSnvBTDC+Mall0QxUEbdm7CM ne/Tr3KuRMv6BSsq9idakdAfYo68xFlqqUoIletKbo8CI6WmVZ+SEMgnihJcvOarRRSHnMHXuoDD3 4IMaDFJ9Qh45y8LXyY3c1Q==; Date: Sat, 26 Apr 2025 17:10:16 +0300 Message-Id: <868qnnt3nb.fsf@gnu.org> From: Eli Zaretskii To: Jens Schmidt In-Reply-To: (message from Jens Schmidt on Thu, 24 Apr 2025 23:41:39 +0200) Subject: Re: bug#77898: 31.0.50; arc-mode: Split PKZIP archive signature not recognized References: <8233d762-1070-4a32-88b2-428c75bedacc@vodafonemail.de> <86wmbhab0e.fsf@gnu.org> <85fcc180-c932-496e-8d3a-83fd46c75aee@vodafonemail.de> <86o6ws8fkg.fsf@gnu.org> <861pthzowt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77898 Cc: 77898@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 24 Apr 2025 23:41:39 +0200 > Cc: 77898@debbugs.gnu.org > From: Jens Schmidt > > On 2025-04-24 15:09, Eli Zaretskii wrote: > > > LGTM, and the tests succeeded on my system, so I've now installed this > > on master, and I'm closing the bug. > > Thanks. Two follow-up nits, not sure whether and how you'd like to > handle them: > > - Your windows-nt-specific follow-up commit e38401e7 isn't at all > windows-nt-specific, as I learned after I noticed it. On Debian > GNU/Linux I have both executables "7z" and "7za" available with > 7z(1) saying: > > 7z uses plugins to handle archives, so it might be slightly slower than > 7za(1) but can handle more archive formats. > > So using executable "7z" for all ports seems to be TRT. > > (And yes, I have tested using > > (define-arc-mode-test-on-type "7z" '("7z" "a") "7z" '7z) > > on GNU/Linux successfully.) > > - And that part of my doc string of macro `define-arc-mode-test-on-type' > is incorrect: > > "Define and execute a test that tests function `archive-find-type'. > ^^ wrong ^^ > > Since the macro, strictly speaking, only *defines* a test, IIUC. > Execution happens when command `ert' (or one of its derivatives) > runs. > > Attached is a patch that fixes both of these. Please let me know what > you think. Thanks again. Thanks, I installed these on master. From unknown Wed Jun 18 23:17:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 May 2025 11:24:30 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator