From unknown Tue Jun 17 01:43:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77887: libparted detects ext4 without journal as ext2 Resent-From: Pascal Hambourg Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Fri, 18 Apr 2025 04:51:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77887 X-GNU-PR-Package: parted X-GNU-PR-Keywords: easy patch To: 77887@debbugs.gnu.org X-Debbugs-Original-To: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174495184421173 (code B ref -1); Fri, 18 Apr 2025 04:51:13 +0000 Received: (at submit) by debbugs.gnu.org; 18 Apr 2025 04:50:44 +0000 Received: from localhost ([127.0.0.1]:49222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5dgV-0005Uc-0S for submit@debbugs.gnu.org; Fri, 18 Apr 2025 00:50:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5VVW-0003kR-M4 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 16:06:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5VVQ-0000kF-SV for bug-parted@gnu.org; Thu, 17 Apr 2025 16:06:41 -0400 Received: from zenith.ipv6.plouf.fr.eu.org ([2001:7a8:6d23:1::1] helo=zenith.plouf.fr.eu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5VVO-0004vG-Gy for bug-parted@gnu.org; Thu, 17 Apr 2025 16:06:40 -0400 Received: from [192.168.0.247] by zenith.plouf.fr.eu.org with esmtp (Exim 4.89) (envelope-from ) id 1u5VVI-0004Lg-Pb for bug-parted@gnu.org; Thu, 17 Apr 2025 22:06:32 +0200 Content-Type: multipart/mixed; boundary="------------Wk2tTdeuI0L5QDDFH60gWqdN" Message-ID: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> Date: Thu, 17 Apr 2025 22:06:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Pascal Hambourg Organization: Plouf ! Received-SPF: pass client-ip=2001:7a8:6d23:1::1; envelope-from=pascal@plouf.fr.eu.org; helo=zenith.plouf.fr.eu.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Fri, 18 Apr 2025 00:50:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Wk2tTdeuI0L5QDDFH60gWqdN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Package: parted Version: 3.6 Severity: minor Tags: patch easy Reference: Dear maintainers, libparted wrongly detects ext4 without journal as ext2 instead of ext4. Steps to reproduce: truncate -s 1G blob mkfs.ext4 -O ^has_journal blob blkid blob -> ext4 parted blob print -> ext2 mount -t ext2 blob /mnt -> "couldn't mount as ext2 due to feature incompatibilities" mount -t ext4 blob /mnt -> ok In libparted/fs/ext2/interface.c, _ext2_generic_probe() considers ext4 as a subset of ext3 which is ext2 with journal. IMO this is wrong because ext4 without journal may have other incompatible features. Please consider the attached trivial patch (untested). --------------Wk2tTdeuI0L5QDDFH60gWqdN Content-Type: text/x-patch; charset=UTF-8; name="detect-ext4-nojournal.patch" Content-Disposition: attachment; filename="detect-ext4-nojournal.patch" Content-Transfer-Encoding: base64 RnJvbSBhMjdkYjhkMzE3YzcxZGJhYWNkNTE0NzU3MjEzNjFiZmI0MDQxNTJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXNjYWwgSGFtYm91cmcgPHBhc2NhbEBwbG91Zi5m ci5ldS5vcmc+CkRhdGU6IFRodSwgMTcgQXByIDIwMjUgMTg6NDI6MzMgKzAyMDAKU3ViamVj dDogW1BBVENIXSBsaWJwYXJ0ZWQ6IERvIG5vdCBkZXRlY3QgZXh0NCB3aXRob3V0IGpvdXJu YWwgYXMgZXh0MgoKZXh0NCBtYXkgaGF2ZSBvdGhlciBpbmNvbXBhdGlibGUgZmVhdHVyZXMg dGhhbiBqb3VybmFsIGFuZCBjYW5ub3QgYmUKbW91bnRlZCBhcyBleHQyIGJ5IGxpbnV4LCBz byBkZXRlY3QgaXQgYXMgZXh0NCBldmVuIHdpdGhvdXQgam91cm5hbAppZiBpdCBoYXMgb3Ro ZXIgaW5jb21wYXRpYmxlIGZlYXR1cmVzLgotLS0KIGxpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jIHwgMzMgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlicGFydGVkL2ZzL2V4dDIvaW50ZXJmYWNlLmMgYi9saWJwYXJ0ZWQvZnMvZXh0Mi9p bnRlcmZhY2UuYwppbmRleCA3ZTBiMTk3NC4uNWY2NGFiMzcgMTAwNjQ0Ci0tLSBhL2xpYnBh cnRlZC9mcy9leHQyL2ludGVyZmFjZS5jCisrKyBiL2xpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jCkBAIC01MiwyNCArNTIsMjEgQEAgX2V4dDJfZ2VuZXJpY19wcm9iZSAoUGVkR2Vv bWV0cnkqIGdlb20sIGludCBleHBlY3RfZXh0X3ZlcikKIAkJaW50IGlzX2V4dDMgPSAwOwog CQlpbnQgaXNfZXh0NCA9IDA7CiAKLQkJaXNfZXh0MyA9IChFWFQyX1NVUEVSX0ZFQVRVUkVf Q09NUEFUICgqc2IpCi0JCQkgICAmIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwp ICE9IDA7Ci0JCWlmIChpc19leHQzKSB7Ci0JCQlpc19leHQ0ID0gKChFWFQyX1NVUEVSX0ZF QVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBB VF9IVUdFX0ZJTEUpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQg KCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQot CQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAg ICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBBVF9ESVJfTkxJTkspCi0JCQkJICAgfHwgKEVY VDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJCSAgICAgICAmIEVYVDRfRkVB VFVSRV9JTkNPTVBBVF9FWFRFTlRTKQotCQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVf SU5DT01QQVQgKCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRC SVQpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJ CSAgICAgICAmIEVYVDRfRkVBVFVSRV9JTkNPTVBBVF9GTEVYX0JHKSk7Ci0JCQlpZiAoaXNf ZXh0NCkKLQkJCQlpc19leHQzID0gMDsKLQkJfQorCQlpc19leHQ0ID0gKChFWFQyX1NVUEVS X0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCisJCQkgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09N UEFUX0hVR0VfRklMRSkKKwkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFU ICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQor CQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQgKCpzYikKKwkJCSAgICAg ICAmIEVYVDRfRkVBVFVSRV9ST19DT01QQVRfRElSX05MSU5LKQorCQkJICAgfHwgKEVYVDJf U1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQorCQkJICAgICAgICYgRVhUNF9GRUFUVVJF X0lOQ09NUEFUX0VYVEVOVFMpCisJCQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09N UEFUICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRCSVQpCisJ CQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09NUEFUICgqc2IpCisJCQkgICAgICAg JiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfRkxFWF9CRykpOworCQlpZiAoIWlzX2V4dDQpCisJ CQlpc19leHQzID0gKEVYVDJfU1VQRVJfRkVBVFVSRV9DT01QQVQgKCpzYikKKwkJCQkgICAm IEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwpICE9IDA7CiAJCWlmIChleHBlY3Rf ZXh0X3ZlciA9PSAyICYmIChpc19leHQzIHx8IGlzX2V4dDQpKQogCQkJcmV0dXJuIE5VTEw7 CiAJCWlmIChleHBlY3RfZXh0X3ZlciA9PSAzICYmICFpc19leHQzKQotLSAKMi4zOS41Cgo= --------------Wk2tTdeuI0L5QDDFH60gWqdN-- From unknown Tue Jun 17 01:43:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77887: libparted detects ext4 without journal as ext2 Resent-From: Pascal Hambourg Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Fri, 18 Apr 2025 16:04:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77887 X-GNU-PR-Package: parted X-GNU-PR-Keywords: easy patch To: 77887@debbugs.gnu.org Received: via spool by 77887-submit@debbugs.gnu.org id=B77887.174499220221546 (code B ref 77887); Fri, 18 Apr 2025 16:04:05 +0000 Received: (at 77887) by debbugs.gnu.org; 18 Apr 2025 16:03:22 +0000 Received: from localhost ([127.0.0.1]:52598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5oBT-0005b9-H4 for submit@debbugs.gnu.org; Fri, 18 Apr 2025 12:03:21 -0400 Received: from zenith.ipv6.plouf.fr.eu.org ([2001:7a8:6d23:1::1]:38288 helo=zenith.plouf.fr.eu.org) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5oBO-0005ZX-5L for 77887@debbugs.gnu.org; Fri, 18 Apr 2025 12:03:16 -0400 Received: from [192.168.0.247] by zenith.plouf.fr.eu.org with esmtp (Exim 4.89) (envelope-from ) id 1u5oBL-0006L7-2T for 77887@debbugs.gnu.org; Fri, 18 Apr 2025 18:03:11 +0200 Message-ID: <4fb0e2f4-fd20-403c-9f35-129bf13e56b9@plouf.fr.eu.org> Date: Fri, 18 Apr 2025 18:03:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US References: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> From: Pascal Hambourg Organization: Plouf ! In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) FWIW I did very basic testing with the patch applied on Debian, now parted detects ext* filesystems as expected: mkfs.ext2 -> ext2 mkfs.ext3 -> ext3 mkfs.ext4 -> ext4 mkfs.ext4 -O ^has_journal -> ext4 From unknown Tue Jun 17 01:43:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Pascal Hambourg Subject: bug#77887: closed (Re: bug#77887: libparted detects ext4 without journal as ext2) Message-ID: References: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> X-Gnu-PR-Message: they-closed 77887 X-Gnu-PR-Package: parted X-Gnu-PR-Keywords: easy patch Reply-To: 77887@debbugs.gnu.org Date: Wed, 28 May 2025 20:59:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1748465942-10931-1" This is a multi-part message in MIME format... ------------=_1748465942-10931-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77887: libparted detects ext4 without journal as ext2 which was filed against the parted package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77887@debbugs.gnu.org. --=20 77887: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77887 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1748465942-10931-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77887-done) by debbugs.gnu.org; 28 May 2025 20:58:53 +0000 Received: from localhost ([127.0.0.1]:57451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKNrR-0002pl-0k for submit@debbugs.gnu.org; Wed, 28 May 2025 16:58:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:31443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKNrO-0002pb-Mt for 77887-done@debbugs.gnu.org; Wed, 28 May 2025 16:58:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748465930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hNUuzS8j5wSpugXQyAyVn/eacI/8KDWHiBgZGux4cJw=; b=ZLoFUx6N6bt91JhbTR7eTUofdwLo/AxaJxbXLD8vmIowGOwbeoTpbkILsBYKxUf6zUah+D sBhm1xfPPZEK2iu38Lqs2nk96J98nScF9j8ve8B5URgj7ZwFZn4wdpMcJhFbOIybIAumzw XdjI7iMpkevDh8QkTI3pR5+2G19YvxA= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-Dk8jkQdwNO6ODbLRfUNHYg-1; Wed, 28 May 2025 16:58:48 -0400 X-MC-Unique: Dk8jkQdwNO6ODbLRfUNHYg-1 X-Mimecast-MFC-AGG-ID: Dk8jkQdwNO6ODbLRfUNHYg_1748465928 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2344968d712so443185ad.0 for <77887-done@debbugs.gnu.org>; Wed, 28 May 2025 13:58:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748465927; x=1749070727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hNUuzS8j5wSpugXQyAyVn/eacI/8KDWHiBgZGux4cJw=; b=KnhClZMZt70r1x9Qe+WUsBcYVoXOYHLjIcP8SL9S0fJ75tD8r36TbT/cjuHQnEdrxI ZtOA/61VxBBEGTnrRs1ug5l1zvjFQRLEc3NMlGYGxR4/ZeZTATJiK8qIRodPmUzVGSKV Q7/PAwzPsFEj1+Jz54AEjrJPlIv+lY7hovjG0937djl6mvdCZqfYxNSZVrDXFX4wrG95 yzA7Kvivqu7RM+WPQ5gjOEh7/O3mLzA1eHvtnYTbACenZakamQ2vtGWTRy1MjxQPuaCL s/EtOI0wro8WTkiCd1XvtDc6OlLsshKj1UMoxI+DqoThB2btQkCcerKmDVtJzYKnO2Ew dGOg== X-Gm-Message-State: AOJu0YxULYlQ/sHMCgw7mwJybARWkP5NhA0k0m7G1U0msvcWyiFuZy/9 YERLL/AmrfUHFhAfAArP/B5Nl93BLy8QR8PzMSBnbf+CFVMbGkgnVYolNT2HuCfuUTOTjRDwaC0 LPg9y2In6C/IzkZgcu0j4mttEwx76tmRY6vsd9DnRZcZ4zS4Nugx1n/EfoDbDk+ldNNxYh1fwWw +dI/sCj2RCKPZeumgXl8g1sBZ4MD9Uky9tm03V5qEm X-Gm-Gg: ASbGncvbBsSqQhaJx/kXTtUwsy3d4dPG53GV/W353YPnTl45V3Tc/YhDw6cz9tOyp4o 0QjkEnnObF7OmM4Cy2YDCN4YocaQ0SGJMsun2cQKKu8XZ8/dn7kJBH8S0a1ymaVT2WyOfs596me MzHhlIbQXHqE9n7rySdSED64TxtLGWgqmrMq8irnuxkPoNLa1vD0P/ijTrTqcSB5a96BAfu9y0C +WdxCNNKfrQKr+pCoeAc3/sbGsxJmINLGE+idiIF+/cAcwqKNE9huirL+F8kNjTO5hSJ2c2iQjX hGHByiKqI9TdiHhhf/p72JJtaVnzqz6GpXUN/oapo2Lve0rs8W4= X-Received: by 2002:a17:902:e744:b0:223:5124:ee7f with SMTP id d9443c01a7336-234cc15fc99mr24577065ad.12.1748465922197; Wed, 28 May 2025 13:58:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF16lcPF5kRZe63R8G0qEcff6HeKWWA9lFBWggcYfgmkBdg5xBMHyWe4wrZD/bS3npUTdhMqQ== X-Received: by 2002:a17:902:e744:b0:223:5124:ee7f with SMTP id d9443c01a7336-234cc15fc99mr24575925ad.12.1748465916494; Wed, 28 May 2025 13:58:36 -0700 (PDT) Received: from ohop.brianlane.com (c-24-16-250-124.hsd1.wa.comcast.net. [24.16.250.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506bc89e9sm263525ad.40.2025.05.28.13.58.35 for <77887-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 May 2025 13:58:36 -0700 (PDT) Date: Wed, 28 May 2025 13:58:34 -0700 From: "Brian C. Lane" To: 77887-done@debbugs.gnu.org Subject: Re: bug#77887: libparted detects ext4 without journal as ext2 Message-ID: References: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> MIME-Version: 1.0 In-Reply-To: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hpy5hallgfnIUT2C_mOOjCS6PpvsLGFeXLyR-c43I54_1748465928 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77887-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted - pykickstart ------------=_1748465942-10931-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Apr 2025 04:50:44 +0000 Received: from localhost ([127.0.0.1]:49222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5dgV-0005Uc-0S for submit@debbugs.gnu.org; Fri, 18 Apr 2025 00:50:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:59666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5VVW-0003kR-M4 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 16:06:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5VVQ-0000kF-SV for bug-parted@gnu.org; Thu, 17 Apr 2025 16:06:41 -0400 Received: from zenith.ipv6.plouf.fr.eu.org ([2001:7a8:6d23:1::1] helo=zenith.plouf.fr.eu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5VVO-0004vG-Gy for bug-parted@gnu.org; Thu, 17 Apr 2025 16:06:40 -0400 Received: from [192.168.0.247] by zenith.plouf.fr.eu.org with esmtp (Exim 4.89) (envelope-from ) id 1u5VVI-0004Lg-Pb for bug-parted@gnu.org; Thu, 17 Apr 2025 22:06:32 +0200 Content-Type: multipart/mixed; boundary="------------Wk2tTdeuI0L5QDDFH60gWqdN" Message-ID: <3711e3c0-bba4-4767-9aa8-0d1d4561686f@plouf.fr.eu.org> Date: Thu, 17 Apr 2025 22:06:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: bug-parted@gnu.org Content-Language: en-US From: Pascal Hambourg Subject: libparted detects ext4 without journal as ext2 Organization: Plouf ! Received-SPF: pass client-ip=2001:7a8:6d23:1::1; envelope-from=pascal@plouf.fr.eu.org; helo=zenith.plouf.fr.eu.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 18 Apr 2025 00:50:28 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Wk2tTdeuI0L5QDDFH60gWqdN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Package: parted Version: 3.6 Severity: minor Tags: patch easy Reference: Dear maintainers, libparted wrongly detects ext4 without journal as ext2 instead of ext4. Steps to reproduce: truncate -s 1G blob mkfs.ext4 -O ^has_journal blob blkid blob -> ext4 parted blob print -> ext2 mount -t ext2 blob /mnt -> "couldn't mount as ext2 due to feature incompatibilities" mount -t ext4 blob /mnt -> ok In libparted/fs/ext2/interface.c, _ext2_generic_probe() considers ext4 as a subset of ext3 which is ext2 with journal. IMO this is wrong because ext4 without journal may have other incompatible features. Please consider the attached trivial patch (untested). --------------Wk2tTdeuI0L5QDDFH60gWqdN Content-Type: text/x-patch; charset=UTF-8; name="detect-ext4-nojournal.patch" Content-Disposition: attachment; filename="detect-ext4-nojournal.patch" Content-Transfer-Encoding: base64 RnJvbSBhMjdkYjhkMzE3YzcxZGJhYWNkNTE0NzU3MjEzNjFiZmI0MDQxNTJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXNjYWwgSGFtYm91cmcgPHBhc2NhbEBwbG91Zi5m ci5ldS5vcmc+CkRhdGU6IFRodSwgMTcgQXByIDIwMjUgMTg6NDI6MzMgKzAyMDAKU3ViamVj dDogW1BBVENIXSBsaWJwYXJ0ZWQ6IERvIG5vdCBkZXRlY3QgZXh0NCB3aXRob3V0IGpvdXJu YWwgYXMgZXh0MgoKZXh0NCBtYXkgaGF2ZSBvdGhlciBpbmNvbXBhdGlibGUgZmVhdHVyZXMg dGhhbiBqb3VybmFsIGFuZCBjYW5ub3QgYmUKbW91bnRlZCBhcyBleHQyIGJ5IGxpbnV4LCBz byBkZXRlY3QgaXQgYXMgZXh0NCBldmVuIHdpdGhvdXQgam91cm5hbAppZiBpdCBoYXMgb3Ro ZXIgaW5jb21wYXRpYmxlIGZlYXR1cmVzLgotLS0KIGxpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jIHwgMzMgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvbGlicGFydGVkL2ZzL2V4dDIvaW50ZXJmYWNlLmMgYi9saWJwYXJ0ZWQvZnMvZXh0Mi9p bnRlcmZhY2UuYwppbmRleCA3ZTBiMTk3NC4uNWY2NGFiMzcgMTAwNjQ0Ci0tLSBhL2xpYnBh cnRlZC9mcy9leHQyL2ludGVyZmFjZS5jCisrKyBiL2xpYnBhcnRlZC9mcy9leHQyL2ludGVy ZmFjZS5jCkBAIC01MiwyNCArNTIsMjEgQEAgX2V4dDJfZ2VuZXJpY19wcm9iZSAoUGVkR2Vv bWV0cnkqIGdlb20sIGludCBleHBlY3RfZXh0X3ZlcikKIAkJaW50IGlzX2V4dDMgPSAwOwog CQlpbnQgaXNfZXh0NCA9IDA7CiAKLQkJaXNfZXh0MyA9IChFWFQyX1NVUEVSX0ZFQVRVUkVf Q09NUEFUICgqc2IpCi0JCQkgICAmIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwp ICE9IDA7Ci0JCWlmIChpc19leHQzKSB7Ci0JCQlpc19leHQ0ID0gKChFWFQyX1NVUEVSX0ZF QVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBB VF9IVUdFX0ZJTEUpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQg KCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQot CQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCi0JCQkJICAg ICAgICYgRVhUNF9GRUFUVVJFX1JPX0NPTVBBVF9ESVJfTkxJTkspCi0JCQkJICAgfHwgKEVY VDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJCSAgICAgICAmIEVYVDRfRkVB VFVSRV9JTkNPTVBBVF9FWFRFTlRTKQotCQkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVf SU5DT01QQVQgKCpzYikKLQkJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRC SVQpCi0JCQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQotCQkJ CSAgICAgICAmIEVYVDRfRkVBVFVSRV9JTkNPTVBBVF9GTEVYX0JHKSk7Ci0JCQlpZiAoaXNf ZXh0NCkKLQkJCQlpc19leHQzID0gMDsKLQkJfQorCQlpc19leHQ0ID0gKChFWFQyX1NVUEVS X0ZFQVRVUkVfUk9fQ09NUEFUICgqc2IpCisJCQkgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09N UEFUX0hVR0VfRklMRSkKKwkJCSAgIHx8IChFWFQyX1NVUEVSX0ZFQVRVUkVfUk9fQ09NUEFU ICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfUk9fQ09NUEFUX0dEVF9DU1VNKQor CQkJICAgfHwgKEVYVDJfU1VQRVJfRkVBVFVSRV9ST19DT01QQVQgKCpzYikKKwkJCSAgICAg ICAmIEVYVDRfRkVBVFVSRV9ST19DT01QQVRfRElSX05MSU5LKQorCQkJICAgfHwgKEVYVDJf U1VQRVJfRkVBVFVSRV9JTkNPTVBBVCAoKnNiKQorCQkJICAgICAgICYgRVhUNF9GRUFUVVJF X0lOQ09NUEFUX0VYVEVOVFMpCisJCQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09N UEFUICgqc2IpCisJCQkgICAgICAgJiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfNjRCSVQpCisJ CQkgICB8fCAoRVhUMl9TVVBFUl9GRUFUVVJFX0lOQ09NUEFUICgqc2IpCisJCQkgICAgICAg JiBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfRkxFWF9CRykpOworCQlpZiAoIWlzX2V4dDQpCisJ CQlpc19leHQzID0gKEVYVDJfU1VQRVJfRkVBVFVSRV9DT01QQVQgKCpzYikKKwkJCQkgICAm IEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwpICE9IDA7CiAJCWlmIChleHBlY3Rf ZXh0X3ZlciA9PSAyICYmIChpc19leHQzIHx8IGlzX2V4dDQpKQogCQkJcmV0dXJuIE5VTEw7 CiAJCWlmIChleHBlY3RfZXh0X3ZlciA9PSAzICYmICFpc19leHQzKQotLSAKMi4zOS41Cgo= --------------Wk2tTdeuI0L5QDDFH60gWqdN-- ------------=_1748465942-10931-1--