GNU bug report logs - #77875
[PATCH 0/2] Use 'graph-descendant?' from Guile-Git instead of custom code

Previous Next

Full log

Message #34 received at 77875-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 77875-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 1/2] git: Use ‘graph-descendant?’ from Guile-Git >= 0.10.0 when available.
Date: Wed, 23 Apr 2025 12:30:56 +0200

Tomas Volf <~@wolfsden.cz> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Fixes <https://issues.guix.gnu.org/66268>.
>>
>> Fixes a bug whereby ‘commit-relation’ and ‘commit-descendant?’ would
>> provide an incorrect result when two distinct <commit> objects would
>> exist for the same commit, which happens when the commit’s metadata is
>> beyond 4 KiB at least as of libgit2 1.8/1.9.
>>
>> This, in turn, would lead ‘guix pull’ & co. to wrongfully report an
>> attempt to downgrade and pull to an unrelated commit.
>>
>> * guix/git.scm (commit-relation): When (guix graph) is available,
>
> You forgot to switch to (git graph) here.

Oops.  Fixed and pushed as ee6d2a77a3f07c4b81fd31bc7aa5d07accc317bd.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.