GNU bug report logs - #77875
[PATCH 0/2] Use 'graph-descendant?' from Guile-Git instead of custom code

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Subject: bug#77875: closed (Re: [PATCH v2 1/2] git: Use ‘graph-descendant?’
 from Guile-Git >= 0.10.0 when available.)
Date: Wed, 23 Apr 2025 10:33:16 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77875: [PATCH 0/2] Use 'graph-descendant?' from Guile-Git instead of custom code

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77875 <at> debbugs.gnu.org.

-- 
77875: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77875
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 77875-done <at> debbugs.gnu.org
Subject: Re: [PATCH v2 1/2] git: Use ‘graph-descendant?’ from Guile-Git >= 0.10.0 when available.
Date: Wed, 23 Apr 2025 12:30:56 +0200

Tomas Volf <~@wolfsden.cz> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Fixes <https://issues.guix.gnu.org/66268>.
>>
>> Fixes a bug whereby ‘commit-relation’ and ‘commit-descendant?’ would
>> provide an incorrect result when two distinct <commit> objects would
>> exist for the same commit, which happens when the commit’s metadata is
>> beyond 4 KiB at least as of libgit2 1.8/1.9.
>>
>> This, in turn, would lead ‘guix pull’ & co. to wrongfully report an
>> attempt to downgrade and pull to an unrelated commit.
>>
>> * guix/git.scm (commit-relation): When (guix graph) is available,
>
> You forgot to switch to (git graph) here.

Oops.  Fixed and pushed as ee6d2a77a3f07c4b81fd31bc7aa5d07accc317bd.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 0/2] Use 'graph-descendant?' from Guile-Git instead of custom
 code
Date: Thu, 17 Apr 2025 22:19:58 +0200

Hello,

This is a bug fix and potentially a performance improvement (I didn’t
attempt to benchmark it but if someone wants to do it, I’m curious!).

Note that the existing code is kept around for now.  We can remove it
in a couple of months when Guile-Git 0.10.0 is considered widespread
enough.  This is a convenience for developers since in practice Guix
itself will have switched to Guile-Git 0.10.0 within a few hours.

Thanks,
Ludo’.

Ludovic Courtès (2):
  git: Use ‘graph-descendant?’ from Guile-Git >= 0.10.0 when available.
  git: Remove compatibility shim for Guile-Git <= 0.5.2.

 guix/git.scm | 90 ++++++++++++++++++++++++++++++----------------------
 1 file changed, 52 insertions(+), 38 deletions(-)


base-commit: 4bd2949cfa7a8bf5dfe66adad1a76472af09708d
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.