GNU bug report logs - #77873
[PATCH] gnu: git-repo: Update to 2.54.

Previous Next

Full log

Message #20 received at 77873 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Jakob Kirsch <jakob.kirsch <at> web.de>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 77873 <at> debbugs.gnu.org
Subject: Re: [bug#77873] [PATCH] gnu: git-repo: Update to 2.54.
Date: Tue, 27 May 2025 09:04:17 +0900

Hi,

Jakob Kirsch <jakob.kirsch <at> web.de> writes:

>> Did this become unnecessary?
>> 
>> > +      #~(modify-phases %standard-phases
>> > +          (add-before 'build 'set-executable-paths
>> > +            (lambda* (#:key inputs outputs #:allow-other-keys)
>> > +              (begin
>
> Yes as there is now an environment variable named REPO_SKIP_SELF_UPDATE that is set in the 'install phase.

I don't think that's sufficient.  Repo will then update at runtime.  We
should wrap the repo binary with REPO_SKIP_SELF_UPDATE=1.  Guix packages
should not mutate themselves like git-repo does out of the box.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.