From unknown Mon Aug 18 14:26:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77871 <77871@debbugs.gnu.org> To: bug#77871 <77871@debbugs.gnu.org> Subject: Status: [PATCH 2/2] term: don't translate undercurl to plain underline Reply-To: bug#77871 <77871@debbugs.gnu.org> Date: Mon, 18 Aug 2025 21:26:33 +0000 retitle 77871 [PATCH 2/2] term: don't translate undercurl to plain underline reassign 77871 emacs submitter 77871 Johannes Altmanninger severity 77871 normal tag 77871 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 17 14:49:01 2025 Received: (at submit) by debbugs.gnu.org; 17 Apr 2025 18:49:02 +0000 Received: from localhost ([127.0.0.1]:48384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5UIF-00077U-U3 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 14:49:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50204) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5UIA-00074o-Nh for submit@debbugs.gnu.org; Thu, 17 Apr 2025 14:48:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5UHg-0007Xf-Rl for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 14:48:31 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u5UHf-0004ls-7C for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 14:48:24 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43cf680d351so13342365e9.0 for ; Thu, 17 Apr 2025 11:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744915699; x=1745520499; darn=gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qtpASJ9e8qU87TWTPwiuJl0S976HQuqfqJErON9ejKM=; b=cKr5ItL4qn6Yfxi5ihZF47a5MT10rnOAkFMa0wBh4OJEHfIYVowGADkP0JFPs/sn/c 6AiDZqguSQCA7ptoKlOqr2O1VmyRpfSSQLPbyuLp051CM03nrCHVJfj6geJefdpbRsiS Ln9DDztJ60tJ3qjCIoNNGwJK4dl+2wDW7sO2weWzw9ULw5EdIDrH+PssDwLPyebNWP2g wQR+FcbfDobAAmuSIzvYGSTYpWgIq7ubtKFABQq/y/t5iRIog9A8GwqYd/olyNJ46JFk RyOkxQJcALuCS1Nk5c8YCRWPpxBMwwb6cjxYBzgKLaNGQdkj8SA+0fsomAapxjjSRsg6 HRqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744915699; x=1745520499; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qtpASJ9e8qU87TWTPwiuJl0S976HQuqfqJErON9ejKM=; b=HFVKVhwHU4rZLYumh4tp4UD8T9pnN9DsD73D4dffI1OKGmI5RGL5mEXuNyU7E3tDea SuuWwb8Pc65kb4MTJ7gqVsUBssnBOe2C3IAmFsOOhxOG+TIjbBWrB5IfPcsYZBtKbRHv JJaTM/9VMwC2w7EV96f4pj2rzvW1IgydqFuQzP2CDk4POkfaA1qMkUcTN1MYEAUN0qPb n9KxHn54BH0u7Dq3qBKDrfYUyOqB3DIo3G0jyDgWSgNoEedrT5stUPHjF5eYLyfvpJeY C8+HuOl8zGn3Qf5/4MKH8jsnNqOPDPO0AH1lPNzpwmoq+TMQTQAlnCCmGLg+IRQjfcGc 7TsA== X-Gm-Message-State: AOJu0Yxi6R6A5qp64iEevf6JSC6jlQqqCXKNaGRpoFLgEcOVUKI9SwkH Df2UptVw1kvIzgZRWm27EPE4F1kSe6zks0CAstAkb7RGVQcP7eHEGCifRw== X-Gm-Gg: ASbGncvKqiRO3Rpv8fxJWa+chLZtKqyGIroL7mv+04nnXhri2A/NWpdNH2WMYPwB1tc lVJ8OYAMeurcVrxoVBTB2SnC/FSO7a9Z7uw2HPO9f4Si+uCWITHwm+4XMBh/QIAOfn9iTOzUEuv KxMGraQZXaPH+aG0UHUO+wsxT27tHO9gIqfiq7lC8srLepx4ZYjGWhhDmdM9Mi21fomdACYhvbD 2whaOALZWJZXNIyJBBPA1Yv7dNgXNEJKPlBTxvpDpl9KktZmRpvn8ZDyl97AV25zJJfy2gARxoG bgVrd1c3bIpwOw== X-Google-Smtp-Source: AGHT+IF5sFPqH3sxPXOlma8f0o9Yu76U5svqDD6PAMPMLw1vZGhAzH6xM816s9eft9hMZwBnvEfAyQ== X-Received: by 2002:a05:600c:468e:b0:43c:f509:2bbf with SMTP id 5b1f17b1804b1-440697c12f7mr8858875e9.15.1744915699120; Thu, 17 Apr 2025 11:48:19 -0700 (PDT) Received: from e15.. ([2001:4bc9:1f9b:112c::5b4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa420816sm460988f8f.15.2025.04.17.11.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Apr 2025 11:48:18 -0700 (PDT) From: Johannes Altmanninger To: bug-gnu-emacs@gnu.org Subject: [PATCH 2/2] term: don't translate undercurl to plain underline Date: Thu, 17 Apr 2025 20:46:33 +0200 Message-ID: <20250417184749.725897-2-aclopte@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250417184749.725897-1-aclopte@gmail.com> References: <20250417184749.725897-1-aclopte@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=aclopte@gmail.com; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Johannes Altmanninger X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * src/term.c (turn_on_face): given a underline face such as FACE_UNDERLINE_WAVE, do not automagically translate it to single underline if terminfo does not declare support for the desired underline style. Instead, add no underline. I have not yet figured out how to test this change. In doubt we should drop it. But I included it here anyway, since it tries to do the same as the previous commit, so it should at least serve to point out another instance of this problem. I know almost nothing about Emacs faces; maybe this change would break themes that rely on this automatic translation. --- src/term.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/term.c b/src/term.c index 8aa47322d19..ef93ccfbef8 100644 --- a/src/term.c +++ b/src/term.c @@ -2050,8 +2050,7 @@ turn_on_face (struct frame *f, struct face *face) if (face->underline && MAY_USE_WITH_COLORS_P (tty, NC_UNDERLINE)) { - if (face->underline == FACE_UNDERLINE_SINGLE - || !tty->TF_set_underline_style) + if (face->underline == FACE_UNDERLINE_SINGLE) OUTPUT1_IF (tty, tty->TS_enter_underline_mode); else if (tty->TF_set_underline_style) { -- 2.49.0