From unknown Fri Jun 20 20:10:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point Resent-From: Christian Sattler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Apr 2025 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 77859@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174488068332555 (code B ref -1); Thu, 17 Apr 2025 09:05:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Apr 2025 09:04:43 +0000 Received: from localhost ([127.0.0.1]:45776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5LAp-0008T1-Be for submit@debbugs.gnu.org; Thu, 17 Apr 2025 05:04:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34902) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5LAm-0008SY-KI for submit@debbugs.gnu.org; Thu, 17 Apr 2025 05:04:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5LAe-0007RT-Cp for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 05:04:33 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u5LAc-0001Mr-IZ for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 05:04:32 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso5216905e9.1 for ; Thu, 17 Apr 2025 02:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744880668; x=1745485468; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=uZYNTMkoz1bHCGfSo2PsilvpzMT++D/bN9Fa5Wm1LTI=; b=QSzZhxyfOhyBmWkbQFs84RnNmT5OmEuUyVYIRWGAVQB3XiqH3jzCPo5JrB/QamuPF5 jut2Lw59eV8fucDVGZdh0KIetPFnFnVPKP0e9UnepnE/UgyASnbsfXlhhWCXO8E0w9// W9knzJd9xRiYzKGOw3lEoOPpePiNbB5ksUc9+SVJVvYVoVDmjmdo4LnhFHlvsPMBvL9M usdWrd6CoPiVxHGBeK585qBmGuqG2Wl1QI4U7qnJ7FrR/mUeNgcavmKHkUyoP9CDKwrh gosZzRoFzTxC8sluT6LoiYdOkwbRte83jhlsOVKW6+UXBjLmQRKcBNKBjhizvqGTVLXv RUcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744880668; x=1745485468; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uZYNTMkoz1bHCGfSo2PsilvpzMT++D/bN9Fa5Wm1LTI=; b=rYqgDNgx0pbFYZ5IbStxVYFVm6CRLGj+k09DuuOgnkHAbQULIhgtMqIEqLTb7WBVx7 Q24kLv5ssrrcIMGV6pudSJA8Yu9m41/6a+VIYmAdk3j5NKQASpITu8H7jEKd5duUs5je Kl+OQ2uRnSssnMk53+WzwG7drLNxxyoWf+3j+4pljsfKl6VXsl0zQzbuDoaHROpkhRI0 xy/U68nDdoE2e3z0/A7TS8Ye75EutGC242i4f7GSchqBLwaoUmwK00dCgbKZCofIP3c/ NZ1326QbnfNoW3Nk14L3TnOxcgWepWVQrlYAsu7IZCuG33b6OLMet6C1G05WZY/R4YQv qLyg== X-Gm-Message-State: AOJu0Yw2DGluamJsrnPnJDwUWyT5QkNVmCqtC31/KKEYjvCS+fs7yeXT BY6rOVkdAMNLKo/DhbwPkd0Qh/ZXKWOXGQUEl5L4XIg//DR6fj/ac11GdxKeiJI1Sv424gYUnML uN0oNlYD5kdmkm5iOIJkotN0/FBVjxTca5p0= X-Gm-Gg: ASbGncudqrf8gnc/BQmgzsv+2TNIPkuOdnIp7WTX9u+diYDWtDoehbtp7i174hJsG8T iv6enEhtT7iUQoTGy+z8T09voXO0lhgVGjBuRT8h5WDUrZMbdR0z+n5vrHf4qeesB1gT9nxKuwv o30dD5PaY+cceG4ARkyd7ebA== X-Google-Smtp-Source: AGHT+IE6YespfZKrdBmAu7AYln5/ZEKNV1rsD72IkpRhpUU+XN1tYOkYtm08VnoQMBai4IwFeo/zYrh7Gbqdo2tSTVA= X-Received: by 2002:a05:6000:144f:b0:39c:1257:ccae with SMTP id ffacd0b85a97d-39ee5ba01e5mr4913770f8f.57.1744880668159; Thu, 17 Apr 2025 02:04:28 -0700 (PDT) MIME-Version: 1.0 From: Christian Sattler Date: Thu, 17 Apr 2025 11:04:16 +0200 X-Gm-Features: ATxdqUHxLeX9gBhCWcQ7OePyqg4zf_RTiOpqpLrdF2lQs4Sb5IGFZNGpAV5_AEA Message-ID: Content-Type: multipart/mixed; boundary="00000000000066e5170632f5b015" Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=sattler.christian@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --00000000000066e5170632f5b015 Content-Type: text/plain; charset="UTF-8" Fixes regression bug#77853. --00000000000066e5170632f5b015 Content-Type: text/x-patch; charset="US-ASCII"; name="Handle-empty-cancidates-in-python-shell-completion-at-point.patch" Content-Disposition: attachment; filename="Handle-empty-cancidates-in-python-shell-completion-at-point.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9l4tuik0 RnJvbSBiZmQ5OThlZjIxYWNjZjY1OGU5OTM4YjUzMDg2OTI1ZjUwZWM5ZGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gU2F0dGxlciA8c2F0dGxlci5jaHJpc3RpYW5A Z21haWwuY29tPgpEYXRlOiBXZWQsIDE2IEFwciAyMDI1IDIyOjAzOjQ2ICswMjAwClN1YmplY3Q6 IFtQQVRDSF0gSGFuZGxlIGVtcHR5IGNhbmNpZGF0ZXMgaW4gcHl0aG9uLXNoZWxsLWNvbXBsZXRp b24tYXQtcG9pbnQuCgpUaGlzIGZpeGVzIGEgcmVncmVzc2lvbiAoYnVnIzc3ODUzKSBpbnRyb2R1 Y2VkIGJ5IDBiOWM3MTQ6CjIwMjQtMDItMDggIlJlc3BlY3QgdGhlIGRlbGltaXRlciBvZiBjb21w bGV0ZXIgaW4gUHl0aG9uIHNoZWxsIGNvbXBsZXRpb24iCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0 aG9uLmVsIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwgYi9saXNwL3Byb2dt b2Rlcy9weXRob24uZWwKaW5kZXggNmZiYWJlOTljYjAuLmVkODdhNjdhZDMwIDEwMDY0NAotLS0g YS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVs CkBAIC00ODk0LDcgKzQ4OTQsOCBAQCBweXRob24tc2hlbGwtY29tcGxldGlvbi1hdC1wb2ludAog ICAgICAgICAgICAgICA6YW5ub3RhdGlvbi1mdW5jdGlvbgogICAgICAgICAgICAgICAobGFtYmRh IChjKSAoY29uY2F0ICIgIiAobnRoIDMgKGFzc29jIGMgY2FuZHMpKSkpCiAgICAgICAgICAgICAg IDpjb21wYW55LWRvY3NpZwotICAgICAgICAgICAgICAobGFtYmRhIChjKSAobnRoIDQgKGFzc29j IGMgY2FuZHMpKSkpKSkpKSkKKyAgICAgICAgICAgICAgKGxhbWJkYSAoYykgKG50aCA0IChhc3Nv YyBjIGNhbmRzKSkpKSkKKyAgICAgICAodCAobGlzdCBzdGFydCBlbmQgKGNkZHIgcHl0aG9uLXNo ZWxsLS1jYXBmLWNhY2hlKSkpKSkpKQogCiAoZGVmaW5lLW9ic29sZXRlLWZ1bmN0aW9uLWFsaWFz CiAgICdweXRob24tc2hlbGwtY29tcGxldGlvbi1jb21wbGV0ZS1hdC1wb2ludAotLSAKMi40OC4x Cgo= --00000000000066e5170632f5b015-- From unknown Fri Jun 20 20:10:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Apr 2025 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Christian Sattler , kobarity Cc: 77859@debbugs.gnu.org Received: via spool by 77859-submit@debbugs.gnu.org id=B77859.174566897924638 (code B ref 77859); Sat, 26 Apr 2025 12:03:02 +0000 Received: (at 77859) by debbugs.gnu.org; 26 Apr 2025 12:02:59 +0000 Received: from localhost ([127.0.0.1]:59002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8eFH-0006PJ-0M for submit@debbugs.gnu.org; Sat, 26 Apr 2025 08:02:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55768) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8eFE-0006P1-SA for 77859@debbugs.gnu.org; Sat, 26 Apr 2025 08:02:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8eF9-0003pD-GI; Sat, 26 Apr 2025 08:02:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=D6Fut4THrI/ODgmf/xMuGhfPHviyhrxkWUmw9OQrjm4=; b=INYkah0yH5/X xrDdE4UO/eK9GW2xrDuLnmgqKZSMp5hK3ZK265k37PjHQA9MTZ3GchD7Rv8lh8/u9t3yJvZSHql/s jLXDvBIght7WxDVGh9w10Vz/cyold8UA3xtjxA/mPp1RLsJjp0MSdD8Xau8sixKoJhPIWMALk9F0K Xp0LvWZdClUgCvWKXvxcq8bHplhj1Jg3zedA/8dGpx963KcatzTBLtZrV7K4OPv7XOokzXYc9uKbG slrK1HGAKsguQioQl0x6ZJA1xNC+0trt4FcMupmh/1iusSByaIKP7V5YkUGPGCwI3QquzL4+JoQcC 3hTWrJYiAEWzDE3wpIn/dg==; Date: Sat, 26 Apr 2025 15:02:47 +0300 Message-Id: <86zfg3t9js.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Christian Sattler on Thu, 17 Apr 2025 11:04:16 +0200) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Christian Sattler > Date: Thu, 17 Apr 2025 11:04:16 +0200 > > Fixes regression bug#77853. > > From bfd998ef21accf658e9938b53086925f50ec9ddf Mon Sep 17 00:00:00 2001 > From: Christian Sattler > Date: Wed, 16 Apr 2025 22:03:46 +0200 > Subject: [PATCH] Handle empty cancidates in python-shell-completion-at-point. > > This fixes a regression (bug#77853) introduced by 0b9c714: > 2024-02-08 "Respect the delimiter of completer in Python shell completion" > --- > lisp/progmodes/python.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > index 6fbabe99cb0..ed87a67ad30 100644 > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -4894,7 +4894,8 @@ python-shell-completion-at-point > :annotation-function > (lambda (c) (concat " " (nth 3 (assoc c cands)))) > :company-docsig > - (lambda (c) (nth 4 (assoc c cands))))))))) > + (lambda (c) (nth 4 (assoc c cands))))) > + (t (list start end (cddr python-shell--capf-cache))))))) > > (define-obsolete-function-alias > 'python-shell-completion-complete-at-point > -- > 2.48.1 > Should this be installed, or did the fix for bug#77853 fix this as well? From unknown Fri Jun 20 20:10:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point Resent-From: kobarity Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Apr 2025 13:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Liu Hui , Christian Sattler , 77859@debbugs.gnu.org Received: via spool by 77859-submit@debbugs.gnu.org id=B77859.174567346832661 (code B ref 77859); Sat, 26 Apr 2025 13:18:01 +0000 Received: (at 77859) by debbugs.gnu.org; 26 Apr 2025 13:17:48 +0000 Received: from localhost ([127.0.0.1]:59420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8fPg-0008Uj-0A for submit@debbugs.gnu.org; Sat, 26 Apr 2025 09:17:48 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:51422) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u8fPd-0008US-KW for 77859@debbugs.gnu.org; Sat, 26 Apr 2025 09:17:46 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-301c4850194so2650929a91.2 for <77859@debbugs.gnu.org>; Sat, 26 Apr 2025 06:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745673459; x=1746278259; darn=debbugs.gnu.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=Fe4v86JGxUCKN+7ex1cjBeW0y9Vf5XM41gIbuPMPmoA=; b=QRqO4Jfo2iZAPv/FKt7p0sYhuEctz98TYExfIq1PuN6MCKIYSuZEINYQOEJ/3uLPmo u3uMDVYda3hdTTCa37iqurfMfcECWMSVxaHfTglIE6dFotLXWbZv8J47k9qME36535cI 4byhZIUl7Dv1jvOIw6KVGUjsonj5zglENSoZHNi3UgDOj80rSkk/jqEn3Lc0aBgGusQe 2K84FbSo4IlzpV5OWqU0jbNj/gZBugj3gZGBgmwej3sULYd3VkD4vLXbvENn04ugLRbf zPBcm+xI0KJWGCn9ZQiRbbURYm3PLbdcQjw2D2PPh3VVdCymapRQhby/1B3StN8CURID mwHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745673459; x=1746278259; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fe4v86JGxUCKN+7ex1cjBeW0y9Vf5XM41gIbuPMPmoA=; b=RbUyscjZcFcle26axH1oG3OpdpxCKlIHuJDMzgH2hdEixSoKdjofUYW82EHCLIdkR7 /XvD64VktnirzIe/XyYoKWlI9Dul1QunleCiFVpqGqR8xaJrNkjIQ3isara5HenPPBwL 4Jyaa1Fn1Z8lJ6B+EIf737o7+SCs2o2EtI13BEcZCdA0zQbJmxlEfwPX6x/aBoxr0VmS jYyP+tOCLABcup3Giy3Ar4A6zkbM5CYmzlJm4ioWvMzeBEInbVWcFgJB5X3zJpUBfYie IH+apVpHv4+gE5LwK97k928RHsvfKfQqZQ/rbeQjNGMs4NLqU6QuSTm208P3ioYbglZI HX+g== X-Forwarded-Encrypted: i=1; AJvYcCXJAZn8kZ9W69BmHMIqhD/jw1E9VjnFvOenFOeyJnuLBZK9N9klpp5261Ic7Zs32DllAvUt5g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx7OtqPtate0pqv6KQGVQOtrjSlQFVrPRzPkrMTXVqs5M7xfOkW AQ1Voi74AuGzfn4lWjB8NeSprH1b+78A7MLKyHEiSJZ0u2fXpj0h X-Gm-Gg: ASbGncvJx1ZjTWz0bPDwcQWB1D2D+sVPa5SCTnHgZSx0XCbZBb11dSz+TKe1rp+D0LF YRGryqAK3tYufZ8fF1VJEFs7UH9+6jBEzMzJuMPg4kdNBxr86+1/IQNJhw32ZwicITF6IjYcyDx wI0SQHWC5Jswmtjop4Mndj3506aCQCucbwxpWfNdOpECbi966P3nKB0mavZDFdlEIZ1XIxzI+qt 7yeqy6o26zNHywRxRYvGR6VJEmPJRaSIkchdSQ715CIf9KDnYXvJemXJuU90/UaSSbS5oGABp8H MNzckRZV1O+qnMs1u1sGZaiIC3oLbNQPL65QZJqYxaCCQSDbC5ZTu/q3aYduH1wkiiKSFVA= X-Google-Smtp-Source: AGHT+IFPri+m4vEI3eamSHwgnAC4B1WI8wvfPZ6clLVVa7z+FBn7WtdDGPQfvBeDQcItYoSkMiJnZg== X-Received: by 2002:a17:90b:4d09:b0:2ee:e113:815d with SMTP id 98e67ed59e1d1-30a0130599bmr4168344a91.8.1745673459452; Sat, 26 Apr 2025 06:17:39 -0700 (PDT) Received: from localhost (58x12x133x161.ap58.ftth.ucom.ne.jp. [58.12.133.161]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309f7763edbsm3527572a91.22.2025.04.26.06.17.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Apr 2025 06:17:39 -0700 (PDT) Date: Sat, 26 Apr 2025 22:17:35 +0900 Message-ID: From: kobarity In-Reply-To: <86zfg3t9js.fsf@gnu.org> References: <86zfg3t9js.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii wrote: > > > From: Christian Sattler > > Date: Thu, 17 Apr 2025 11:04:16 +0200 > > > > Fixes regression bug#77853. > > > > From bfd998ef21accf658e9938b53086925f50ec9ddf Mon Sep 17 00:00:00 2001 > > From: Christian Sattler > > Date: Wed, 16 Apr 2025 22:03:46 +0200 > > Subject: [PATCH] Handle empty cancidates in python-shell-completion-at-point. > > > > This fixes a regression (bug#77853) introduced by 0b9c714: > > 2024-02-08 "Respect the delimiter of completer in Python shell completion" > > --- > > lisp/progmodes/python.el | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > index 6fbabe99cb0..ed87a67ad30 100644 > > --- a/lisp/progmodes/python.el > > +++ b/lisp/progmodes/python.el > > @@ -4894,7 +4894,8 @@ python-shell-completion-at-point > > :annotation-function > > (lambda (c) (concat " " (nth 3 (assoc c cands)))) > > :company-docsig > > - (lambda (c) (nth 4 (assoc c cands))))))))) > > + (lambda (c) (nth 4 (assoc c cands))))) > > + (t (list start end (cddr python-shell--capf-cache))))))) > > > > (define-obsolete-function-alias > > 'python-shell-completion-complete-at-point > > -- > > 2.48.1 > > > > Should this be installed, or did the fix for bug#77853 fix this as > well? Liu's fix for bug#77853 already fixed it. At first I was going to fix it the same way as Christian, but I think Liu's patch is better. If `python-shell-completion-at-point' returns nil when there are no completion candidates, as is currently the case, the next completion function may be able to provide appropriate completion candidates. The problem with bug#77853 is that the default setting includes an inappropriate completion function for inferior Python mode, so it would be better to remove the inappropriate completion function `comint-filename-completion' from `comint-dynamic-complete-functions' as in Liu's patch. From unknown Fri Jun 20 20:10:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christian Sattler Subject: bug#77859: closed (Re: bug#77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point) Message-ID: References: <865xirt2tq.fsf@gnu.org> X-Gnu-PR-Message: they-closed 77859 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 77859@debbugs.gnu.org Date: Sat, 26 Apr 2025 14:29:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1745677742-21539-1" This is a multi-part message in MIME format... ------------=_1745677742-21539-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77859@debbugs.gnu.org. --=20 77859: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77859 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745677742-21539-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77859-done) by debbugs.gnu.org; 26 Apr 2025 14:28:14 +0000 Received: from localhost ([127.0.0.1]:33837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u8gVp-0005Zj-BT for submit@debbugs.gnu.org; Sat, 26 Apr 2025 10:28:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41680) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u8gVn-0005ZI-1P for 77859-done@debbugs.gnu.org; Sat, 26 Apr 2025 10:28:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u8gVh-0004Uf-M8; Sat, 26 Apr 2025 10:28:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VxpeUJ67t/xpCwFhrl+gP0NlquQJkipd5l3dohRfc9o=; b=auYJQUDNgzL7 FZDI3uYdtWzxfqOwnG6h4urArTubY0KxuSyUD1KyQ+SDC7iU/AxHfnM/29gPY2g/Ogsj4/2szFykF GIpBMJf64XGDWwTJaWSsfMH1iF28MPgCzZADSRLS5BTcAJ1TAh5HT6u1PGomGhWOYl61c3Z1IRLkF zQchQKGv8xTV6mEOQommbo9CdW1Zz4e7Y17Mx3U7H65upMNz/1cO2IBkc4w9+QZnKAcd1mDIkxrKD bpdk6oVPfxt9h7k9nIJIp5tE632vjJEXyHdF4BfvKiGS+/PhXuDXnKAtwkhEpLRC4bAtIQdjZfCcn M8O4056Ukz4B6ALrDduHfg==; Date: Sat, 26 Apr 2025 17:28:01 +0300 Message-Id: <865xirt2tq.fsf@gnu.org> From: Eli Zaretskii To: kobarity In-Reply-To: (message from kobarity on Sat, 26 Apr 2025 22:17:35 +0900) Subject: Re: bug#77859: [PATCH] Handle empty cancidates in python-shell-completion-at-point References: <86zfg3t9js.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77859-done Cc: liuhui1610@gmail.com, sattler.christian@gmail.com, 77859-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 26 Apr 2025 22:17:35 +0900 > From: kobarity > Cc: Christian Sattler , > Liu Hui , > 77859@debbugs.gnu.org > > Eli Zaretskii wrote: > > > > > From: Christian Sattler > > > Date: Thu, 17 Apr 2025 11:04:16 +0200 > > > > > > Fixes regression bug#77853. > > > > > > From bfd998ef21accf658e9938b53086925f50ec9ddf Mon Sep 17 00:00:00 2001 > > > From: Christian Sattler > > > Date: Wed, 16 Apr 2025 22:03:46 +0200 > > > Subject: [PATCH] Handle empty cancidates in python-shell-completion-at-point. > > > > > > This fixes a regression (bug#77853) introduced by 0b9c714: > > > 2024-02-08 "Respect the delimiter of completer in Python shell completion" > > > --- > > > lisp/progmodes/python.el | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el > > > index 6fbabe99cb0..ed87a67ad30 100644 > > > --- a/lisp/progmodes/python.el > > > +++ b/lisp/progmodes/python.el > > > @@ -4894,7 +4894,8 @@ python-shell-completion-at-point > > > :annotation-function > > > (lambda (c) (concat " " (nth 3 (assoc c cands)))) > > > :company-docsig > > > - (lambda (c) (nth 4 (assoc c cands))))))))) > > > + (lambda (c) (nth 4 (assoc c cands))))) > > > + (t (list start end (cddr python-shell--capf-cache))))))) > > > > > > (define-obsolete-function-alias > > > 'python-shell-completion-complete-at-point > > > -- > > > 2.48.1 > > > > > > > Should this be installed, or did the fix for bug#77853 fix this as > > well? > > Liu's fix for bug#77853 already fixed it. > > At first I was going to fix it the same way as Christian, but I think > Liu's patch is better. If `python-shell-completion-at-point' returns > nil when there are no completion candidates, as is currently the case, > the next completion function may be able to provide appropriate > completion candidates. > > The problem with bug#77853 is that the default setting includes an > inappropriate completion function for inferior Python mode, so it > would be better to remove the inappropriate completion function > `comint-filename-completion' from `comint-dynamic-complete-functions' > as in Liu's patch. Thanks, I'm therefore closing this one. ------------=_1745677742-21539-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Apr 2025 09:04:43 +0000 Received: from localhost ([127.0.0.1]:45776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5LAp-0008T1-Be for submit@debbugs.gnu.org; Thu, 17 Apr 2025 05:04:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34902) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5LAm-0008SY-KI for submit@debbugs.gnu.org; Thu, 17 Apr 2025 05:04:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5LAe-0007RT-Cp for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 05:04:33 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u5LAc-0001Mr-IZ for bug-gnu-emacs@gnu.org; Thu, 17 Apr 2025 05:04:32 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-43cf3192f3bso5216905e9.1 for ; Thu, 17 Apr 2025 02:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744880668; x=1745485468; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=uZYNTMkoz1bHCGfSo2PsilvpzMT++D/bN9Fa5Wm1LTI=; b=QSzZhxyfOhyBmWkbQFs84RnNmT5OmEuUyVYIRWGAVQB3XiqH3jzCPo5JrB/QamuPF5 jut2Lw59eV8fucDVGZdh0KIetPFnFnVPKP0e9UnepnE/UgyASnbsfXlhhWCXO8E0w9// W9knzJd9xRiYzKGOw3lEoOPpePiNbB5ksUc9+SVJVvYVoVDmjmdo4LnhFHlvsPMBvL9M usdWrd6CoPiVxHGBeK585qBmGuqG2Wl1QI4U7qnJ7FrR/mUeNgcavmKHkUyoP9CDKwrh gosZzRoFzTxC8sluT6LoiYdOkwbRte83jhlsOVKW6+UXBjLmQRKcBNKBjhizvqGTVLXv RUcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744880668; x=1745485468; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uZYNTMkoz1bHCGfSo2PsilvpzMT++D/bN9Fa5Wm1LTI=; b=rYqgDNgx0pbFYZ5IbStxVYFVm6CRLGj+k09DuuOgnkHAbQULIhgtMqIEqLTb7WBVx7 Q24kLv5ssrrcIMGV6pudSJA8Yu9m41/6a+VIYmAdk3j5NKQASpITu8H7jEKd5duUs5je Kl+OQ2uRnSssnMk53+WzwG7drLNxxyoWf+3j+4pljsfKl6VXsl0zQzbuDoaHROpkhRI0 xy/U68nDdoE2e3z0/A7TS8Ye75EutGC242i4f7GSchqBLwaoUmwK00dCgbKZCofIP3c/ NZ1326QbnfNoW3Nk14L3TnOxcgWepWVQrlYAsu7IZCuG33b6OLMet6C1G05WZY/R4YQv qLyg== X-Gm-Message-State: AOJu0Yw2DGluamJsrnPnJDwUWyT5QkNVmCqtC31/KKEYjvCS+fs7yeXT BY6rOVkdAMNLKo/DhbwPkd0Qh/ZXKWOXGQUEl5L4XIg//DR6fj/ac11GdxKeiJI1Sv424gYUnML uN0oNlYD5kdmkm5iOIJkotN0/FBVjxTca5p0= X-Gm-Gg: ASbGncudqrf8gnc/BQmgzsv+2TNIPkuOdnIp7WTX9u+diYDWtDoehbtp7i174hJsG8T iv6enEhtT7iUQoTGy+z8T09voXO0lhgVGjBuRT8h5WDUrZMbdR0z+n5vrHf4qeesB1gT9nxKuwv o30dD5PaY+cceG4ARkyd7ebA== X-Google-Smtp-Source: AGHT+IE6YespfZKrdBmAu7AYln5/ZEKNV1rsD72IkpRhpUU+XN1tYOkYtm08VnoQMBai4IwFeo/zYrh7Gbqdo2tSTVA= X-Received: by 2002:a05:6000:144f:b0:39c:1257:ccae with SMTP id ffacd0b85a97d-39ee5ba01e5mr4913770f8f.57.1744880668159; Thu, 17 Apr 2025 02:04:28 -0700 (PDT) MIME-Version: 1.0 From: Christian Sattler Date: Thu, 17 Apr 2025 11:04:16 +0200 X-Gm-Features: ATxdqUHxLeX9gBhCWcQ7OePyqg4zf_RTiOpqpLrdF2lQs4Sb5IGFZNGpAV5_AEA Message-ID: Subject: [PATCH] Handle empty cancidates in python-shell-completion-at-point To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000066e5170632f5b015" Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=sattler.christian@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --00000000000066e5170632f5b015 Content-Type: text/plain; charset="UTF-8" Fixes regression bug#77853. --00000000000066e5170632f5b015 Content-Type: text/x-patch; charset="US-ASCII"; name="Handle-empty-cancidates-in-python-shell-completion-at-point.patch" Content-Disposition: attachment; filename="Handle-empty-cancidates-in-python-shell-completion-at-point.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m9l4tuik0 RnJvbSBiZmQ5OThlZjIxYWNjZjY1OGU5OTM4YjUzMDg2OTI1ZjUwZWM5ZGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaHJpc3RpYW4gU2F0dGxlciA8c2F0dGxlci5jaHJpc3RpYW5A Z21haWwuY29tPgpEYXRlOiBXZWQsIDE2IEFwciAyMDI1IDIyOjAzOjQ2ICswMjAwClN1YmplY3Q6 IFtQQVRDSF0gSGFuZGxlIGVtcHR5IGNhbmNpZGF0ZXMgaW4gcHl0aG9uLXNoZWxsLWNvbXBsZXRp b24tYXQtcG9pbnQuCgpUaGlzIGZpeGVzIGEgcmVncmVzc2lvbiAoYnVnIzc3ODUzKSBpbnRyb2R1 Y2VkIGJ5IDBiOWM3MTQ6CjIwMjQtMDItMDggIlJlc3BlY3QgdGhlIGRlbGltaXRlciBvZiBjb21w bGV0ZXIgaW4gUHl0aG9uIHNoZWxsIGNvbXBsZXRpb24iCi0tLQogbGlzcC9wcm9nbW9kZXMvcHl0 aG9uLmVsIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwgYi9saXNwL3Byb2dt b2Rlcy9weXRob24uZWwKaW5kZXggNmZiYWJlOTljYjAuLmVkODdhNjdhZDMwIDEwMDY0NAotLS0g YS9saXNwL3Byb2dtb2Rlcy9weXRob24uZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHl0aG9uLmVs CkBAIC00ODk0LDcgKzQ4OTQsOCBAQCBweXRob24tc2hlbGwtY29tcGxldGlvbi1hdC1wb2ludAog ICAgICAgICAgICAgICA6YW5ub3RhdGlvbi1mdW5jdGlvbgogICAgICAgICAgICAgICAobGFtYmRh IChjKSAoY29uY2F0ICIgIiAobnRoIDMgKGFzc29jIGMgY2FuZHMpKSkpCiAgICAgICAgICAgICAg IDpjb21wYW55LWRvY3NpZwotICAgICAgICAgICAgICAobGFtYmRhIChjKSAobnRoIDQgKGFzc29j IGMgY2FuZHMpKSkpKSkpKSkKKyAgICAgICAgICAgICAgKGxhbWJkYSAoYykgKG50aCA0IChhc3Nv YyBjIGNhbmRzKSkpKSkKKyAgICAgICAodCAobGlzdCBzdGFydCBlbmQgKGNkZHIgcHl0aG9uLXNo ZWxsLS1jYXBmLWNhY2hlKSkpKSkpKQogCiAoZGVmaW5lLW9ic29sZXRlLWZ1bmN0aW9uLWFsaWFz CiAgICdweXRob24tc2hlbGwtY29tcGxldGlvbi1jb21wbGV0ZS1hdC1wb2ludAotLSAKMi40OC4x Cgo= --00000000000066e5170632f5b015-- ------------=_1745677742-21539-1--