From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 14:25:33 2025 Received: (at submit) by debbugs.gnu.org; 16 Apr 2025 18:25:33 +0000 Received: from localhost ([127.0.0.1]:41833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u57S0-00079i-M6 for submit@debbugs.gnu.org; Wed, 16 Apr 2025 14:25:32 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49060) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u57Ru-00075b-Cc for submit@debbugs.gnu.org; Wed, 16 Apr 2025 14:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u57RU-00073Q-PU for bug-gnu-emacs@gnu.org; Wed, 16 Apr 2025 14:25:07 -0400 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u57RS-0005I0-80 for bug-gnu-emacs@gnu.org; Wed, 16 Apr 2025 14:25:00 -0400 Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfout.stl.internal (Postfix) with ESMTP id A8C951140254 for ; Wed, 16 Apr 2025 14:24:56 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 16 Apr 2025 14:24:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1744827896; x=1744914296; bh=Lm5sIjixAH p1KFYLjNmqM6zsmpvBuXqXYyK4Wh5ACNI=; b=LFxq2WaJ1LO3Ax9/gPfPVJTxX6 uAiDCKZNaHCohBy6sgmsjFaAYvqWRI0wVASMARplqsgPUS1/2z5uI9ffKfoV+8xx K9DV3cahHlToseoGO61MzEXr1CeHs705jckQ5YQE2oL7Y7Gb7zAXA/P9a04Kmdde oE5eOork/tuFJZy/3UroMgBFjeKLZkSgzmSXq/UbepwhEh1zHN0wOhbLaITsDi61 3mx+35wBx3BjYwXt80xLNwkWKV4YWrRc+Xg+M8VqCpKtYxJgd7yAlO1tZ7sToKD5 JWGbDJ9VdhMXTod110NRKr1ygOzxqAPH1YGyRJ3BGjVvMDFWFnSiSXHxuQWQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1744827896; x= 1744914296; bh=Lm5sIjixAHp1KFYLjNmqM6zsmpvBuXqXYyK4Wh5ACNI=; b=l qpaeuCN8xPomsprHgx/85066aifv+/9YhLSJKaObVFRdVhBBptsmY3pV8sg7YbcF 4eMxPceVyiq24RyFBPFLqt5roZ+wf+WW80ycbZnl7O6zo0pgsGFLnKorRn5e52pG t8ZU4pRUG+8wLszbJKlXmnAF/Iux23eAMG1cSnNpAWYwf5GOdWEr/WtSaOZXewaD DQjCPhlRWh1etYTjSXf9i9On/qvAmAt14fwEQ+kEudAOXVEdDaPgKbanoZ7JHpU9 y7tQId4yCStDGRE6ZN0f1+GnX4/oZeC2j9zRa0WlQacpk7UMCkN2VElHGxy+TiB1 ydtF3eSfyOW/rZEUkj1Aw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdejtdekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhtg gguffkfffvofesrgdtmherhhdtjeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhg shgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqne cuggftrfgrthhtvghrnhepffdtieegteeggffhkefgtdelffdufffgffefvdefffeghedu vdejvdfhvdffveeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhn sggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsuhhgqd hgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 16 Apr 2025 14:24:55 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Content-Type: multipart/alternative; boundary="Apple-Mail=_5316262A-FFC0-4975-8D05-4C17194BFA3C" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode Message-Id: <4EC63677-D8D5-4966-A3C0-0DE5A1637149@secure.kjonigsen.net> Date: Wed, 16 Apr 2025 20:24:44 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3826.400.131.1.6) Received-SPF: pass client-ip=202.12.124.149; envelope-from=jostein@secure.kjonigsen.net; helo=fout-b6-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) --Apple-Mail=_5316262A-FFC0-4975-8D05-4C17194BFA3C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hey everyone. When using Emacs to compile a modern C# project, one uses the dotnet CLI = to do so (dotnet build). The output from recent dotnet CLI versions are (unfortunately) optmized = for "fancyness" these days, which means it contains various escape = sequences. The current regexp in compilation-mode incorrectly includes this escape = sequence for the first error reported, making navigation to the first = error found fail. Attached is a patch which excludes this escape sequence from the = captured value, fixing navigation again. =E2=80=94 Kind Regards Jostein Kj=C3=B8nigsen =EF=BF=BC= --Apple-Mail=_5316262A-FFC0-4975-8D05-4C17194BFA3C Content-Type: multipart/mixed; boundary="Apple-Mail=_4794B13F-F741-49E8-8F1A-BCD060DA299C" --Apple-Mail=_4794B13F-F741-49E8-8F1A-BCD060DA299C Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
Hey = everyone.

When using Emacs to compile a modern = C# project, one uses the dotnet CLI to do so (dotnet = build).

The output from recent dotnet CLI = versions are (unfortunately) optmized for "fancyness" these days, which = means it contains various escape sequences.

The = current regexp in compilation-mode incorrectly includes this escape = sequence for the first error reported, making navigation to the first = error found fail.

Attached is a patch which = excludes this escape sequence from the captured value, fixing navigation = again.

=E2=80=94
Kind Regards
Jostein = Kj=C3=B8nigsen

= --Apple-Mail=_4794B13F-F741-49E8-8F1A-BCD060DA299C Content-Disposition: attachment; filename=0001-compile.el-Handle-dotnet-compiler-escape-sequences.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-compile.el-Handle-dotnet-compiler-escape-sequences.patch" Content-Transfer-Encoding: quoted-printable =46rom=205aeeb99079482f47652897fd364daf80c11ec806=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D=20= =0ADate:=20Mon,=2024=20Mar=202025=2011:51:19=20= +0100=0ASubject:=20[PATCH]=20compile.el:=20Handle=20dotnet=20compiler=20= escape=20sequences.=0A=0Acompilation-error-regexp-alist-alist:=20Exclude=20= known=20escape=20sequences=0Afrom=20filename.=0A---=0A=20= lisp/progmodes/compile.el=20|=202=20++=0A=201=20file=20changed,=202=20= insertions(+)=0A=0Adiff=20--git=20a/lisp/progmodes/compile.el=20= b/lisp/progmodes/compile.el=0Aindex=201ca58b3ac7d..5f3bc606287=20100644=0A= ---=20a/lisp/progmodes/compile.el=0A+++=20b/lisp/progmodes/compile.el=0A= @@=20-717,8=20+717,10=20@@=20compilation-error-regexp-alist-alist=0A=20=0A= =20=20=20=20=20;;=20Typescript=20compilation=20prior=20to=20tsc=20= version=202.7,=20"plain"=20format:=0A=20=20=20=20=20;;=20= greeter.ts(30,12):=20error=20TS2339:=20Property=20'foo'=20does=20not=20= exist.=0A+=20=20=20=20;;=20Also=20used=20by=20"dotnet=20build"=0A=20=20=20= =20=20(typescript-tsc-plain=0A=20=20=20=20=20=20,(rx=20bol=0A+=20=20=20=20= =20=20=20=20=20=20(optional=20(seq=20"=1B=3D"))=20;=20escape=20sequence=20= sometimes=20found=20on=20first=20line=20of=20output=0A=20=20=20=20=20=20=20= =20=20=20=20(group=20(not=20(in=20"=20\t\n()"))=20=20=20;=201:=20file=0A=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(*=20(not=20(in=20= "\n()"))))=0A=20=20=20=20=20=20=20=20=20=20=20"("=0A--=20=0A2.49.0=0A=0A= --Apple-Mail=_4794B13F-F741-49E8-8F1A-BCD060DA299C Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii --Apple-Mail=_4794B13F-F741-49E8-8F1A-BCD060DA299C-- --Apple-Mail=_5316262A-FFC0-4975-8D05-4C17194BFA3C-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 17 01:52:55 2025 Received: (at 77846) by debbugs.gnu.org; 17 Apr 2025 05:52:55 +0000 Received: from localhost ([127.0.0.1]:45452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5IBD-0004Uc-Dk for submit@debbugs.gnu.org; Thu, 17 Apr 2025 01:52:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57604) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5IBA-0004U2-7f for 77846@debbugs.gnu.org; Thu, 17 Apr 2025 01:52:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5IB4-0000zi-Sz; Thu, 17 Apr 2025 01:52:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=NJA8cmoLVMFmn1298JeuUhNhhwxYCTVgkwp5nGDm4iU=; b=MVXs1Q+EcIIsUkvcRfNJ 4HnDQ73SNvPE/EOPHDJXPTUgmjME2TchzpNRnxa/sS+fRE0wis2LGYTKPKCld6yKgW/xsze7C3bid fvpDAoqNZplallO7FK07M080Lcf9yIQnaF/1PLsPWCqdSSH6z3L/xu4I0qluk4iS6Qul24dwiTuX+ Qp0eBGpSR3Sukk/7DdoNAO1u1VGg5ZV/2BBvXgH7VYIw2RbVxW/dik/Ql5QgYl5KliabHuQZbzCUd oD+VkVjcaOdR2ls+0Iu0RENXaKfbcJaDeSYfmYSh3m14B3ioGWOzN+loFgpIxWp1GAcxu3E5MNrl/ i8af7gDJK/1PVA==; Date: Thu, 17 Apr 2025 08:52:42 +0300 Message-Id: <8634e7fi6t.fsf@gnu.org> From: Eli Zaretskii To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <4EC63677-D8D5-4966-A3C0-0DE5A1637149@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Wed, 16 Apr 2025 20:24:44 +0200) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode References: <4EC63677-D8D5-4966-A3C0-0DE5A1637149@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77846 Cc: 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jostein Kjønigsen > Date: Wed, 16 Apr 2025 20:24:44 +0200 > > When using Emacs to compile a modern C# project, one uses the dotnet CLI to do so (dotnet build). > > The output from recent dotnet CLI versions are (unfortunately) optmized for "fancyness" these days, which means it contains various escape sequences. > > The current regexp in compilation-mode incorrectly includes this escape sequence for the first error reported, making navigation to the first error found fail. > > Attached is a patch which excludes this escape sequence from the captured value, fixing navigation again. Thanks, but please also update etc/compilation.txt accordingly. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 11:15:26 2025 Received: (at 77846) by debbugs.gnu.org; 18 Apr 2025 15:15:26 +0000 Received: from localhost ([127.0.0.1]:52487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5nR5-0001m2-Vb for submit@debbugs.gnu.org; Fri, 18 Apr 2025 11:15:26 -0400 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:44045) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u5nQp-0001cF-Bg for 77846@debbugs.gnu.org; Fri, 18 Apr 2025 11:15:12 -0400 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-30c2d427194so17988681fa.0 for <77846@debbugs.gnu.org>; Fri, 18 Apr 2025 08:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744989296; x=1745594096; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=KHfY7krQx+AwioUMhxqg+DkSheyAjpAVZcsTl4MiyF4=; b=NqVHjb23LLouyvEw1RXCo8VRtH1lvce7yRbpDJLKflXrZbCkufen+IZtsfwSJ3yn5K v98tMT+TwDT0t7GJjMG1HQBKilsIjnYZzBZyofdMbqUjXJUtt0tO/JCJzENUwvF9sN2T icj0kRtYW8+96sBwwgDNT2f2uvZlH2b6m0QPkYtrCIVnyRmLY1jvcYy+RN3vxm73Twqj BzxBDu+9xkFdkg+gDWl30vu8XOiRoPyPR10N59usManeridQ2Xhmb+q+sTPyvWAZZXne JYvJmyIBIedy+N6rIphB7+p+P+L0dKmgO1Yq/hzexOKiuQhD5sCYFfaQFskE1ANSJG0p 4FMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744989296; x=1745594096; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHfY7krQx+AwioUMhxqg+DkSheyAjpAVZcsTl4MiyF4=; b=Rf0L9rHKBUyW/Vjg+NtXjA5vCXw5plAyU9IVBM5J0S10VeWASQjVsX0Ma/53RdxRfC rP4pZePSkNes1rS0TBfp3NPm8RsCiInF5y05uX/Iw587tbZqvhBgNq0HufVXy10Jsszd 5kakrYzEOAFGlfr/19mARv2CwhMVWcIok4G4HdqdEzPocy6lCARMZPk8nC01NNHBgeGL 9V04CUxkrQhVJS1VgWUOtdyp9sC5p3PDhlDrXf+UtvB4UjnGp6EcyO9GE4QA7njfh+5P jmohHRIjM1HVg6jHNrnQkWqQbEDuDD+GhgiRmY4izFglBThzBWwZyMRGMxzTanVcxv5t AsBw== X-Forwarded-Encrypted: i=1; AJvYcCVXoRaJVv/1xXHllAq0ScI1AcMWDAm2yXB5iB2+PueeRT2xMz6my4JKtRGUzwSEmymKlpEBSw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzCEuWInYZgbDfbvOAT9IjxAYADSEXDYUEr8rsGUEkkoC8AmSo2 jcaWT4hMwxQxxKiOSkW4ccT+xkgt0bifocFeqrsrjCdLn/j3KdI2 X-Gm-Gg: ASbGnctZaUDoN5WjC/oSS+PQSpNWVD4vJ/KJM/qySNtz7Rq4HBg+4w0VAKGTlr97PcZ pPXRbV25NkSqTC4Rd6ru7wQw3ccfBpTnuQom4qrvURocpmO1gO1ZfYLNxhLqrFUdxI15Tdv3p/H MH+H1DNUeHB6lFObaUd9+jc+j30NHyMEVZs/AuHI6mA80VRwM+BarqySIhUIgth+ZzlEecvrvx+ 5o5VTDo+g3JcyopComFaZ0CL4Mn1TJYtNwmGVKrxFyWnFOFuaroZilk5oGbcFIh+7CCDdJ3MUWz U1y8Dc5DVxlQnftRLAYDJ3YCV4sktDecr9fuRJTVgcR82dFRf0JPq1elvUxUiTObOVwyU21Pgvb 84LbOgD+lNKIXdtOmsuFy7zE75RsepYc= X-Google-Smtp-Source: AGHT+IHf0NUrM6E9+NX+wUCBm7M8G2h6cOq8dL7xlu1U/DMitu6JwxdBmuciffl+Q+bukhYEvJg23A== X-Received: by 2002:a05:651c:883:b0:30b:aabf:fa8 with SMTP id 38308e7fff4ca-3109055407bmr14383451fa.28.1744989296180; Fri, 18 Apr 2025 08:14:56 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-31090782fc4sm2528801fa.35.2025.04.18.08.14.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Apr 2025 08:14:55 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode Message-Id: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> Date: Fri, 18 Apr 2025 17:14:54 +0200 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77846 Cc: Eli Zaretskii , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) + (optional (seq "{ESC}=1B=3D")) ; escape sequence sometimes = found on first line of output Please keep lines within 80 columns, and don't put actual control chars = in source code; use escape sequences. You don't need the `seq`. Something like + (opt "\e=3D") ; sequence sometimes found on first line of = output perhaps. As Eli remarked we'd like to see an example in compilation.txt, and just = as important is adding a test case in compile-tests.el. It would also be useful to know precisely what that escape sequence is = supposed to be doing. As far as I can tell, `ESC =3D` is the DECKPAM = sequence that puts the keypad in application mode, which makes no sense = at all in this context. Perhaps it's compilation-filter-hook that really should be used to = filter it out, and other sequences like it? From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 12:57:57 2025 Received: (at 77846) by debbugs.gnu.org; 18 Apr 2025 16:57:57 +0000 Received: from localhost ([127.0.0.1]:52711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5p2I-0007gx-2a for submit@debbugs.gnu.org; Fri, 18 Apr 2025 12:57:57 -0400 Received: from fhigh-b2-smtp.messagingengine.com ([202.12.124.153]:44795) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5p2B-0007eu-Tf for 77846@debbugs.gnu.org; Fri, 18 Apr 2025 12:57:50 -0400 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.stl.internal (Postfix) with ESMTP id 7796F25401A1; Fri, 18 Apr 2025 12:57:42 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-04.internal (MEProxy); Fri, 18 Apr 2025 12:57:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1744995462; x=1745081862; bh=pb4kU1wKK/0lOL8iq6u+sXrjyGiIEFfLmlzQUTDJ/4o=; b= ZPBdaEVZP11rzyPLd4dsaG71RE+QCtLUPc41tdT8CyhNuK7uuP5uqwdIjP/L5pvh ovi9aFRy36agZT0QZNA+wDCZ33wurl5JsHgmlIn46AJSNiH8LNIap3yZQRah6C6h iGYNci+K8auiz+IAPqbsJrWxutUR/25X1ZkDyyDzYihpvvpuaC9GEv3fXEbCHYx0 5CtPewfha3plit55XhZTGrVKjPiB/nzCOyZWbjzcho6tntkZ/N0hF7BhDgkdOpWz D9YLJ8tbfaZSFmPvIft6PC46BMbaqhaio5TMoNtRlsiVNpB5/29q2em5/PGqS5NZ 0BLudAgFnH6Kl0vX9GeKJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1744995462; x=1745081862; bh=pb4kU1wKK/0lOL8iq6u+sXrjyGiIEFfLmlz QUTDJ/4o=; b=Aqhwt9c5v0Lfbp2M02zqXB8+PN1+n9y0QT3p2eIwP1KnbLTJkVA eMljNfSkosDQ+ZYlayiMql5VVtlfsBB5sL3ANwc59peVDpoZJljXtUJSqEYX/Yeh qVgmsIL1/IGBjcr0oKuNwjhR3BAEaOTYNwctwY8o+5crm1TxobL93Uj4R1xnWlXE LH89phoYQ9/QE7+Wmek7jC7cwO0g+mYUMX+NHPKY32ofUyQOGA9TctpMsu6rAWUJ rVbW8Miup0CRpIP9SYjn4y0hVtqj8ykB1ttqUNkE90zm+7hGRs3F9eFPqEnEMsPK VYKgeos5chYHSOlOEQic72iqVz3NXX8aveg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvfedvieelucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdt jeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnse hsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvefh fedvvdehieeufeelvefftddtkedvteduhefhudeffefhffejieffhfetheejnecuffhomh grihhnpehgihhthhhusgdrtghomhdpnhgrthhivhgvmhgvthhhohgushdrtghsnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinh esshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopeefpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehmrghtthhirghsrdgvnhhguggvghgrrh gusehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghp thhtohepjeejkeegieesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Apr 2025 12:57:41 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> Content-Type: multipart/alternative; boundary="Apple-Mail=_66588DAA-FE47-4151-9CE8-F4E873BBB631" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode Date: Fri, 18 Apr 2025 18:57:39 +0200 In-Reply-To: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77846 Cc: Eli Zaretskii , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_66588DAA-FE47-4151-9CE8-F4E873BBB631 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 18 Apr 2025, at 17:14, Mattias Engdeg=C3=A5rd = wrote: >=20 > + (optional (seq "{ESC}=1B=3D")) ; escape sequence sometimes = found on first line of output >=20 > Please keep lines within 80 columns, and don't put actual control = chars in source code; use escape sequences. You don't need the `seq`. > Something like >=20 > + (opt "\e=3D") ; sequence sometimes found on first line of = output >=20 > perhaps. >=20 I've made some changes like that, and that seems to work fine. > As Eli remarked we'd like to see an example in compilation.txt Done. Didn't know about this one. > , and just as important is adding a test case in compile-tests.el. I'll defer that slightly based on comment below. >=20 > It would also be useful to know precisely what that escape sequence is = supposed to be doing. As far as I can tell, `ESC =3D` is the DECKPAM = sequence that puts the keypad in application mode, which makes no sense = at all in this context. I'll admit to not know too much in depth stuff about escape codes and = how they're used. =46rom trying to read the MSBuild source code, my best guess so far is = that the escape-code seems to be used in an elaborate output-mode = detection process: = https://github.com/dotnet/msbuild/blob/a9d68ab58eab3c25b6378a90be8060dd142= 9a6ef/src/Framework/NativeMethods.cs#L1588-L1642 Someone else might know more about this, or are better able to parse = this code. >=20 > Perhaps it's compilation-filter-hook that really should be used to = filter it out, and other sequences like it? >=20 That also seems like an appropriate solution. Is there precedence for solution like in place already? -- Jostein= --Apple-Mail=_66588DAA-FE47-4151-9CE8-F4E873BBB631 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On 18 Apr = 2025, at 17:14, Mattias Engdeg=C3=A5rd = <mattias.engdegard@gmail.com> wrote:

+ =          (optional (seq = "{ESC}=1B=3D")) ; escape sequence sometimes found on first line of = output

Please keep lines within 80 columns, and don't put actual = control chars in source code; use escape sequences. You don't need the = `seq`.
Something like

+ =          (opt "\e=3D") =  ; sequence sometimes found on first line of = output

perhaps.


I've made some changes like that, and that seems to work = fine.

As Eli = remarked we'd like to see an example in = compilation.txt

Done. Didn't = know about this one.

, and = just as important is adding a test case in = compile-tests.el.

I'll defer = that slightly based on comment below.


It would also be useful to know precisely = what that escape sequence is supposed to be doing. As far as I can tell, = `ESC =3D` is the DECKPAM sequence that puts the keypad in application = mode, which makes no sense at all in this = context.

I'll admit to = not know too much in depth stuff about escape codes and how they're = used.

=46rom trying to read the MSBuild source = code, my best guess so far is that the escape-code seems to be used in = an elaborate output-mode detection process:


Someone = else might know more about this, or are better able to parse this = code.


Perhaps it's compilation-filter-hook that = really should be used to filter it out, and other sequences like = it?


That also seems like = an appropriate solution.

Is there precedence = for solution like in place = already?

--
Jostein
= --Apple-Mail=_66588DAA-FE47-4151-9CE8-F4E873BBB631-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 15:28:35 2025 Received: (at 77846) by debbugs.gnu.org; 19 Apr 2025 19:28:35 +0000 Received: from localhost ([127.0.0.1]:37718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6Dre-0004Vy-G6 for submit@debbugs.gnu.org; Sat, 19 Apr 2025 15:28:35 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:60698) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u6Dra-0004UD-Ra for 77846@debbugs.gnu.org; Sat, 19 Apr 2025 15:28:32 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5497590ffbbso2556070e87.1 for <77846@debbugs.gnu.org>; Sat, 19 Apr 2025 12:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745090904; x=1745695704; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=RoTOHi8cnf4ksdt3feA64ZY2Bp8lzy1Sf2dTXrgeVGM=; b=in3tKhaYE2+paEmfzkiQXTrrQnytXwFtG3tHzl4Bdfmt6yDYWH19KhLscPXaHu1+jE 1D4iNFqGsc1i7JyHRlmE1iutmfuD4oul2y76OHCWTB4+hWkhdgxq3599f0KomVlHmXMx Wi8bWnix5yUDvooyA9iLQwExb03iM345BwPhWioxVks+SKyljOqsxb67sqAYq25wf4ZP IxFY2OEhK54gHPumAoMx2Jy8Mlvl1j6cOlsmJtYtUI9E/iPskLhCHEAgh8bZc3Jwh8io qlAKUSCN7rbSB2/lcx+tdbHfiBUSRgdaOEmuhTi0ICRQqeHaN8BqQjVNgAc1yUciVOQV g0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745090904; x=1745695704; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=RoTOHi8cnf4ksdt3feA64ZY2Bp8lzy1Sf2dTXrgeVGM=; b=FQlSbcVrx10mXTrOWCWAnIoYoZkm+LXz8D9ollljwHOkxe2iKqpN1lMxoJsLY6Q+gT o3kVDHTnWUUNlcHHiY5bcxstxUyjQl+HnCpE9I+TJG8uUsCHgcoWqlDtLTaW/0kSweFd d7kW6zLqjvhOb38Akzp2t8vy1GlKqc/DH110HGlgU8x15iKU91jJZ3zybpwhtK4mNPeW f9fdhzesJKiNemIB184L2RUB357+OEVhqswB3wqYZa4MFwjYZYfS0Rb5Uelh5aeHykdC JlJnGZfj5xEPhlX4br+J4edYL6o80qB37MhgRJMegZXdvVBNBETHpNuGj95hwZM9rES+ 8txw== X-Forwarded-Encrypted: i=1; AJvYcCWN4kXCW2fnvsl0jyoPG8fuVsDPE0rCm/tT27Oc3CMsxPPEI3OABXTkxv17romo9tLAvWK03g==@debbugs.gnu.org X-Gm-Message-State: AOJu0Ywd67ilRRYkDSoyxRopGdjQ7H0RdygCXbO12l84aGt4BIpy5tgj vCvbCGvzaXG/SIp6k0dizvPrP++6L9+cf1Ls6qNDqZfnK4wsa1+waniZLg== X-Gm-Gg: ASbGnct7NwsiqsM1d1o+xqX5xrRICmecvSmzRH/mrqYIVJr7EY3JEqgOIg5pZk0oHUS lt8AAWJDhh5W6A3n1jjz4NFV8NCDW0/wBW7pIlZUAaWjf2x5PstQAnBffq2/+vIKLmMPGDFnOG1 9zHN2aUHOwgG16rmBPA4FOemqwLuTXZ+5c+zrfIPufOheJ64vdpgxkw9af2P2H8N6VsiPL77jys MJkjg4MEgi/YwMoZJMsKVhlCSSuC+ZM4BI39/UWTVCSfoEV1pWYwqKtoB2nYRfmE/Vrxt1LM3oA LUTGOT67vZdF9dYgxSxNN6LDMbEdgCKPG9ahB+gaVpHol3aiqBMTRIizJpEeVNaehNKG9/TT6mT JdutHlRxHFOgWWoVtaVEDf22/5daoz1U= X-Google-Smtp-Source: AGHT+IFRBs0nhtxdlYcVrLEyMkrvd00VKW4xtZezmKrvkE+DhhWtHBBjAh62r00uRdeP3kfViHbfHQ== X-Received: by 2002:a05:6512:2313:b0:547:6733:b5a3 with SMTP id 2adb3069b0e04-54d6e634034mr2138313e87.28.1745090904017; Sat, 19 Apr 2025 12:28:24 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54d6e52482esm499191e87.1.2025.04.19.12.28.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Apr 2025 12:28:23 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> Date: Sat, 19 Apr 2025 21:28:22 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77846 Cc: Eli Zaretskii , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 18 apr. 2025 kl. 18.57 skrev Jostein Kj=C3=B8nigsen = : > =46rom trying to read the MSBuild source code, my best guess so far is = that the escape-code seems to be used in an elaborate output-mode = detection process: >=20 > = https://github.com/dotnet/msbuild/blob/a9d68ab58eab3c25b6378a90be8060dd142= 9a6ef/src/Framework/NativeMethods.cs#L1588-L1642 Not sure if that particular piece of code is relevant but you probably = know MSBuild (and C#) better. I spent all of five minutes searching the = msbuild project for insertion or detection of ` =3D` but nothing = obvious showed up, so there is probably something we don't quite = understand here. It makes no sense to emit that sequence from a non-interactive program = to a terminal because it doesn't affect the output in any way. Does it = come from the C# compiler proper, from MSBuild, or some other software = component (no idea how this all fits together, as you can tell). >> Perhaps it's compilation-filter-hook that really should be used to = filter it out, and other sequences like it? >=20 > That also seems like an appropriate solution. >=20 > Is there precedence for solution like in place already? This hook would be the most obvious thing to use if the stray sequence = is emitted by a different layer and risks appearing in different = contexts. For example, one could write something like > (defun stray-msbuild-seq-compilation-filter () > (defvar compilation-filter-start) > (let ((begin compilation-filter-start) > (end (point)) > (inhibit-read-only t)) > (save-excursion > (goto-char begin) > (while (re-search-forward (rx bol "\e=3D") end t) > (delete-region (match-beginning 0) (match-end 0)))))) and then add that function to compilation-filter-hook. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 23 02:30:00 2025 Received: (at 77846) by debbugs.gnu.org; 23 Apr 2025 06:30:01 +0000 Received: from localhost ([127.0.0.1]:52058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7TcM-0005r1-KA for submit@debbugs.gnu.org; Wed, 23 Apr 2025 02:30:00 -0400 Received: from fout-a8-smtp.messagingengine.com ([103.168.172.151]:45637) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7TcI-0005pt-2c for 77846@debbugs.gnu.org; Wed, 23 Apr 2025 02:29:56 -0400 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfout.phl.internal (Postfix) with ESMTP id 82D8813800DE; Wed, 23 Apr 2025 02:29:48 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Wed, 23 Apr 2025 02:29:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1745389788; x=1745476188; bh=svPSthkjm7UVSkPmmk5GkAuWhGHoGGVYmsYNcH2ZcDc=; b= CoNDjrcl20Ep+OUMtwHuNzHTpI99TLzb7iybrxh0MMeLnB9mdzV4WiMKwUFQ+tbs e19jc9MMgNjYaXBm9cVO3YslMnUF+6Yc8G7MospVLW1xHyae8LpNHn8Q5qoHbpsc vHplZyR5+IP+vWx7r7VPrVWn+ejglBrO9Pgcokq2YkIffhq9n3eadvibqStdiSBA FASsajJPWzBlegWExkcUxG36jI7RZDlQiDjteS4g0wJDo+tDPK2bXHtGJkKst4cc FBXDybNXQNnFuqFGfvEVLkoun1yHr/oh+mMMdqFESsqLLWMPMeJ9b09LcILb64qy i8e9mA8/BCtGP6zCw/g0rA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1745389788; x=1745476188; bh=svPSthkjm7UVSkPmmk5GkAuWhGHoGGVYmsY NcH2ZcDc=; b=j6TFforKLEnWoyW38cGThKKA5deMEEriiEnBcWtPW+sZb5xOG2d FX6Hnd0Kkzrr991trZH0fC3rmtYe6PsJGdgvUfnqnml57PznUPSgi9jJUrXHTaI6 PlD0F+H3p5fGNaw6HGXK3PPYTIHIWYQlSvaQAWDISBNVzbMP7QQB+liK7Y4RjVA6 nwY/rb9SXMvqE1+NplflEQhlO5rh/xcUJog0CmzRYnWwlpWY2/DPjypjG34x26xr N2u7GUJwgLA96eS/p43bU9+jVKSsiG37gYtxlO38PtkdVSzufFcikZgkIu23BT3Q zzlbjTpEka1QY7Mpc8tZ9RDhkOhcCiw2+Ag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeehkeekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdt jeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnse hsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdei tdeuheelfeefteejgfegvdevleduveekffefhffgjeekteejheetffegueegnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhes shgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsggprhgtphhtthhopeefpdhmoh guvgepshhmthhpohhuthdprhgtphhtthhopehmrghtthhirghsrdgvnhhguggvghgrrhgu sehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpth htohepjeejkeegieesuggvsggsuhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Apr 2025 02:29:47 -0400 (EDT) From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Message-Id: <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> Content-Type: multipart/alternative; boundary="Apple-Mail=_06CE0700-68C2-4A6F-8452-8FBFE21BAECA" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode Date: Wed, 23 Apr 2025 08:29:36 +0200 In-Reply-To: <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77846 Cc: Eli Zaretskii , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_06CE0700-68C2-4A6F-8452-8FBFE21BAECA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 19 Apr 2025, at 21:28, Mattias Engdeg=C3=A5rd = wrote: >=20 >=20 >>> Perhaps it's compilation-filter-hook that really should be used to = filter it out, and other sequences like it? >>=20 >> That also seems like an appropriate solution. >>=20 >> Is there precedence for solution like in place already? >=20 > This hook would be the most obvious thing to use if the stray sequence = is emitted by a different layer and risks appearing in different = contexts. For example, one could write something like >=20 >> (defun stray-msbuild-seq-compilation-filter () >> (defvar compilation-filter-start) >> (let ((begin compilation-filter-start) >> (end (point)) >> (inhibit-read-only t)) >> (save-excursion >> (goto-char begin) >> (while (re-search-forward (rx bol "\e=3D") end t) >> (delete-region (match-beginning 0) (match-end 0)))))) >=20 > and then add that function to compilation-filter-hook. >=20 Just to be clear and to make sure I understand: Do you suggest I test = that hook locally and if it works, propose that as a patch? If so, = should I add it to compile.el? Or were you suggesting something else? I see that in the entirety of the current Emacs code-base, there are = only 4 implemented hooks of this kind, and they are kinda spread around = all over (follow.el, grep.el, so-long.el). -- Jostein= --Apple-Mail=_06CE0700-68C2-4A6F-8452-8FBFE21BAECA Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8


On 19 Apr 2025, at 21:28, = Mattias Engdeg=C3=A5rd <mattias.engdegard@gmail.com> = wrote:


Perhaps it's compilation-filter-hook that really should be = used to filter it out, and other sequences like = it?

That also seems like an appropriate = solution.

Is there precedence for solution like in place = already?

This hook would be the most obvious thing = to use if the stray sequence is emitted by a different layer and risks = appearing in different contexts. For example, one could write something = like

(defun = stray-msbuild-seq-compilation-filter ()
 (defvar = compilation-filter-start)
 (let ((begin = compilation-filter-start)
=        (end (point))
=        (inhibit-read-only t))
=    (save-excursion
=      (goto-char begin)
=      (while (re-search-forward (rx bol "\e=3D") = end t)
       (delete-region = (match-beginning 0) (match-end 0))))))

and then add = that function to = compilation-filter-hook.


Ju= st to be clear and to make sure I understand: Do you suggest I test that = hook locally and if it works, propose that as a patch? If so, should I = add it to compile.el? Or were you suggesting something = else?

I see that in the entirety of the current = Emacs code-base, there are only 4 implemented hooks of this kind, and = they are kinda spread around all over (follow.el, grep.el, = so-long.el).

--
Jostein
= --Apple-Mail=_06CE0700-68C2-4A6F-8452-8FBFE21BAECA-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 10 05:15:40 2025 Received: (at 77846) by debbugs.gnu.org; 10 May 2025 09:15:40 +0000 Received: from localhost ([127.0.0.1]:43734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uDgJ1-0004Nf-Sq for submit@debbugs.gnu.org; Sat, 10 May 2025 05:15:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37892) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uDgIz-0004NE-0n for 77846@debbugs.gnu.org; Sat, 10 May 2025 05:15:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uDgIt-0007ue-11; Sat, 10 May 2025 05:15:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XRIHkpEM7DMuFHfeBsXAxIzfEzN22fyD7l3HTck2NjE=; b=C5S2lSAvN0QqqmQublyC jSIriZTI+0AWCEjTlqKSgIfb9AqALjuM7GqrCE/sZC1haoRJwU79GL0kV2hH5rt4gffOtlHNqcIqd rVowIS93eQsQCYdZzpIOiOoFt0i1PagflfY5K8yIxCW8Jg8TpzGGPyYTB/fKxjONgP+K3INVJHquw 73OSVdugsdS1L2g/D8F/wKyEwyvJPPpTGAgBPy+SpHJZy5TDyYytO65BDvRgibEJq6ymYHxDokzJH yEKIwWcJNOqFSAFVZDDfuR2UsLtKc1VLKGlGaCfExwtW9SizXs2xQXNZIA0+tMBfJidyaqeUuJ4Ov /D5LkfWaXODlkg==; Date: Sat, 10 May 2025 12:15:27 +0300 Message-Id: <86selcbzdc.fsf@gnu.org> From: Eli Zaretskii To: mattias.engdegard@gmail.com, Jostein =?utf-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Wed, 23 Apr 2025 08:29:36 +0200) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77846 Cc: 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Mattias, could you please answer Jostein's question? > From: Jostein Kjønigsen > Date: Wed, 23 Apr 2025 08:29:36 +0200 > Cc: Eli Zaretskii , > 77846@debbugs.gnu.org > > > On 19 Apr 2025, at 21:28, Mattias Engdegård wrote: > > Perhaps it's compilation-filter-hook that really should be used to filter it out, and other sequences > like it? > > That also seems like an appropriate solution. > > Is there precedence for solution like in place already? > > This hook would be the most obvious thing to use if the stray sequence is emitted by a different layer > and risks appearing in different contexts. For example, one could write something like > > (defun stray-msbuild-seq-compilation-filter () > (defvar compilation-filter-start) > (let ((begin compilation-filter-start) > (end (point)) > (inhibit-read-only t)) > (save-excursion > (goto-char begin) > (while (re-search-forward (rx bol "\e=") end t) > (delete-region (match-beginning 0) (match-end 0)))))) > > and then add that function to compilation-filter-hook. > > Just to be clear and to make sure I understand: Do you suggest I test that hook locally and if it works, > propose that as a patch? If so, should I add it to compile.el? Or were you suggesting something else? > > I see that in the entirety of the current Emacs code-base, there are only 4 implemented hooks of this kind, > and they are kinda spread around all over (follow.el, grep.el, so-long.el). From debbugs-submit-bounces@debbugs.gnu.org Thu May 15 13:04:14 2025 Received: (at 77846) by debbugs.gnu.org; 15 May 2025 17:04:14 +0000 Received: from localhost ([127.0.0.1]:55586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uFc0E-0003tw-1M for submit@debbugs.gnu.org; Thu, 15 May 2025 13:04:14 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:56708) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uFc0A-0003tW-Tn for 77846@debbugs.gnu.org; Thu, 15 May 2025 13:04:11 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-54b09cb06b0so1412288e87.1 for <77846@debbugs.gnu.org>; Thu, 15 May 2025 10:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747328644; x=1747933444; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=hKMlMADtVaIFRyE165xMrGfjZegpj/v5hY83amPMxh8=; b=DgMnRq0rYAViO68hqPDqwMWgYsKuYvMM9dOugEmLTQD0JLNu2aqxKU2RgLuds0hfOZ ezSeFILWqp8/Mx7ER4zwK3Dlni8Pros4ok0tM5N3gGVys1RhgW5Bjp61K97Uvts+FZOv EBXYPA9yctrG7GatbMbbv9goyLurYl2vWjH96P5lpt3fxW9B6oF08wh+M6153+uBQsta uNp4eU5uk0KVSLKAyffFnYwWZAz6uNaNifcVs6QRAYk06zJC62n0fzBgxBI79ISC1kFI VxZHbVHdTprxH0l4vvXyzm3bYZRcqGsx7Q8UhPUJPS85amsIbEMh3hU1V9kiR3MOC8+k bNYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747328644; x=1747933444; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hKMlMADtVaIFRyE165xMrGfjZegpj/v5hY83amPMxh8=; b=IQWCi4xSemfXyw7e2ArCa0RPF168NoHKAWQ6ug/fsG9if+0dsj9Kqq6VvXg6uN/V4G by0XxbqsuXuZkFHfkH3CiCayqDd313HgqQ07wsyLSaY0BhE2sxpzOMwcser0E1VqUG20 3CtdW2EHh+SxJtB7LM6tNduNSClivCDdRa8OE4q+pLQ2F+WaiDd6s3IuY/78fNPCkxz4 bkql1dkcZOqmVl45D5W4sR+hewxc1kIW6rWkzPNR+rSWNT1GyleHtmphSn2Otvh3DN1p uayFTPyiDJYVmW6qXXb7hI86TGp7mP9tYvvjhS3v6UJO19Mt3CDgB/RLEZZaRmi8GR5y S2WA== X-Forwarded-Encrypted: i=1; AJvYcCUtzw5++vtmTZ6Znjc6yyQNIekAOWceEooeACyTxzHHbfYthsem3meQAbFLecXe23OBTqCXZw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxjQ8YIFDdaldr05PN1azkA7jVZotnKUPGTIMr8X0j29e1IpM6G 7wCNo3u0x3ilzDHKJvpWdPq4barc2/ElEKKOrnDgQpmGx6LFFsiZzT1l X-Gm-Gg: ASbGnctnGKC/CGyuqCaU3a2CRo8xc5ltrP7Ln6InjyxjrU/ImZ4JbCdF9w6ZAlfgMCh Po2rVJhxArDo/AIis3MM2m9/bv6MJtDKp3PlVhYGnGWA2PSWK8AjPvFPaIjGzCPKaNnp0FIM88i KAOzO+lnpJ5RXbDDIaO4tjTKpXNRCuvcqy8OfNsJGfHHZISH4ryZdoxbYF/+QeWkqdJEA73QPii bQc8czUopVg7GlSLXgvXbFAuTCXanelKtNZbKeEQsmaHWdjO+NM2fUGr3VA2Awi1WAXDw4bVA/e 25/5MfCaHAOSwnp+/UhLfjBbW/g7I7Lo/oSaJ6Co5O3MEZCNjrlvb4j3wW9EnobNAUJYF8MEhfp PYgXc6YrNxoraB5UtccvULb0Xk/jhfAa2QRYDfeq2BQ== X-Google-Smtp-Source: AGHT+IHMnV/+mUO98J8W3eTb5PwIuwWe2O/Nl/MVLuTYBFFI1RUPASijukyi/sNB3qaNHoPJHF9+kQ== X-Received: by 2002:a05:6512:650e:b0:549:887b:253f with SMTP id 2adb3069b0e04-550e72456f1mr47988e87.51.1747328644032; Thu, 15 May 2025 10:04:04 -0700 (PDT) Received: from smtpclient.apple (c188-150-186-155.bredband.tele2.se. [188.150.186.155]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e702dd6esm27162e87.194.2025.05.15.10.04.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 May 2025 10:04:03 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> Date: Thu, 15 May 2025 19:04:02 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9243B053-3D89-4A03-A7C5-9F9CD37BE711@gmail.com> References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77846 Cc: Eli Zaretskii , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein and Eli, sorry about the delay. 23 apr. 2025 kl. 08.29 skrev Jostein Kj=C3=B8nigsen = : > Just to be clear and to make sure I understand: Do you suggest I test = that hook locally and if it works, propose that as a patch? If so, = should I add it to compile.el? Or were you suggesting something else? What I meant is that `compilation-filter-hook` seems to be the proper = level for filtering out stuff that isn't part of the messages emitted by = a compiler, or in-band signalling common to otherwise unrelated tools. = An example of the former would be unwanted annotation by the build = system or terminal emulation, of the latter is SGR escape sequences for = colouring the output. I just don't understand where the 'ESC =3D' sequence comes from (the C# = compiler?) or what it means. You said it was for 'fanciness', but I = can't find any reference to it anywhere. Could it be the result of Emacs mutilating the message somehow? What = happens if you send the compiler errors to a file and visit it with = Emacs in fundamental-mode? From debbugs-submit-bounces@debbugs.gnu.org Sat May 24 05:11:25 2025 Received: (at 77846) by debbugs.gnu.org; 24 May 2025 09:11:25 +0000 Received: from localhost ([127.0.0.1]:57011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uIkua-0007yc-Pj for submit@debbugs.gnu.org; Sat, 24 May 2025 05:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41718) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uIkuY-0007yL-7V for 77846@debbugs.gnu.org; Sat, 24 May 2025 05:11:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIkuS-0001PF-QD; Sat, 24 May 2025 05:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hwRsKTzKogiU5T39Igzz15DWTxgns+QIKK6Tu3Vsax8=; b=Y/7dY8no5FQqx3ohuuPG fFGzDMetgRaKseT03x0CKo+R5niNRYF3HleBYFjE4xHAQoPv2ds1Pus/K6h7yFRYhYeZz7BKxWA5V Dc7v1rnUydbSxXmHibCzMA6qndMw0yXgq6bMmDVK3dmrmAPVz3Yo/EFlOTV7VpsFViXF2xiEEzXWz KDX+M8g7CkVRCHPb+yDgvtb+E35/Lqo6fAUXt4t2UveHpfcn1WAGU9Fbg927AvxhxruIwbywQ/m/6 JL0bBsevac4DayOSCxZwK8W+PpfSSbpsSNaWO+QPCJAwKQgtRMr+2tOqYIyniKkNlnPRuf0wQ5hR0 /9jfz5wNnrru5A==; Date: Sat, 24 May 2025 12:11:14 +0300 Message-Id: <86seku1ih9.fsf@gnu.org> From: Eli Zaretskii To: jostein@secure.kjonigsen.net In-Reply-To: <9243B053-3D89-4A03-A7C5-9F9CD37BE711@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 15 May 2025 19:04:02 +0200) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> <9243B053-3D89-4A03-A7C5-9F9CD37BE711@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77846 Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Thu, 15 May 2025 19:04:02 +0200 > Cc: Eli Zaretskii , > 77846@debbugs.gnu.org > > Jostein and Eli, sorry about the delay. > > 23 apr. 2025 kl. 08.29 skrev Jostein Kjønigsen : > > > Just to be clear and to make sure I understand: Do you suggest I test that hook locally and if it works, propose that as a patch? If so, should I add it to compile.el? Or were you suggesting something else? > > What I meant is that `compilation-filter-hook` seems to be the proper level for filtering out stuff that isn't part of the messages emitted by a compiler, or in-band signalling common to otherwise unrelated tools. An example of the former would be unwanted annotation by the build system or terminal emulation, of the latter is SGR escape sequences for colouring the output. > > I just don't understand where the 'ESC =' sequence comes from (the C# compiler?) or what it means. You said it was for 'fanciness', but I can't find any reference to it anywhere. > > Could it be the result of Emacs mutilating the message somehow? What happens if you send the compiler errors to a file and visit it with Emacs in fundamental-mode? Jostein, any followups or comments? From debbugs-submit-bounces@debbugs.gnu.org Mon May 26 04:11:31 2025 Received: (at 77846) by debbugs.gnu.org; 26 May 2025 08:11:31 +0000 Received: from localhost ([127.0.0.1]:53747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uJSvj-0008Um-9k for submit@debbugs.gnu.org; Mon, 26 May 2025 04:11:31 -0400 Received: from fout-b3-smtp.messagingengine.com ([202.12.124.146]:46235) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uJSvg-0008UN-89 for 77846@debbugs.gnu.org; Mon, 26 May 2025 04:11:28 -0400 Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.stl.internal (Postfix) with ESMTP id 80DAA1140147; Mon, 26 May 2025 04:11:22 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Mon, 26 May 2025 04:11:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1748247082; x=1748333482; bh=BGt9gPV1rB r0mXB7ru/BQ7bSpVpTPXpKSkBT6Yb7SYE=; b=M0hht5FA4XBpWy/vzOeJHBdAVq 3nHQKnBJc2Ed27j223asq+0IxEIYCdqJ5ZKui3J8klHsmsew/hNDVdKbDlD6aoCk 3juBY1mWuL6bR4j3aUpPJhBkzDG1h9OHqhfngKp6nhE+OjTiXTU7X2dH2GHKLGdd fCRA/hpaK1rtxujimwt55rULNsyDsbB2kBnskhOyQik07zfv4ac5El2qnUYwMMFW 8D+8mm5VJTikp+/N63DdgT8em2o5/2I23Kj4W5BeNsOpchOtrh6FWd/w6HUgtyhC lX2CouFdpia5Rr3tjORjW4mHnuQh9Eslykyh+0kBqn8aD5BDsJTs7OxgeUvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748247082; x= 1748333482; bh=BGt9gPV1rBr0mXB7ru/BQ7bSpVpTPXpKSkBT6Yb7SYE=; b=M chXKy2Ft+dlFotewHSVh2pWqN6L8ygu89L6RUmyYmMfA1uoJg+tMJ3qhlDZab1IQ qdx5dkxjhkIU01SYS6i+e5aqq2a+blklK+nbGGF3QRTnwUrLmKQdBFALJELfOg89 oIwt3LsJfqOlVYnkF0TzN/9oz2Dp43szgoGoHIipRiu16vyDJlZjl0BUN+Uz3y4O rMus+O8asoShlowMD0kE98mPrbYV8pRB9BpRRV0CMAq5QMnYXcQtRSTdRm8AyH0A bZLBmo1IReWLYmjR64y+ZV52ymlMAAx+Clshe72folITDo/PlgBHYm3zwPXSCHfq wrqui/2iP2Boq9+413FXg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddujedtudculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffev gffkfhfvofesthhqmhdthhdtjeenucfhrhhomheplfhoshhtvghinhcumfhjpphnihhgsh gvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvtheqnecu ggftrfgrthhtvghrnhepveeuffehieeltddtgedugeevfeettdehleetteejvdeijefhvd dtffdvudehhedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtpdhnsg gprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiies ghhnuhdrohhrghdprhgtphhtthhopehmrghtthhirghsrdgvnhhguggvghgrrhgusehgmh grihhlrdgtohhmpdhrtghpthhtohepjeejkeegieesuggvsggsuhhgshdrghhnuhdrohhr gh X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 May 2025 04:11:21 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: bug#77846: [PATCH ]31.0.50; C# dotnet compiler output incorrectly handled by compilation-mode From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= In-Reply-To: <86seku1ih9.fsf@gnu.org> Date: Mon, 26 May 2025 10:11:10 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86BC72DE-B99A-4F33-9FD1-331D01AB30E0@gmail.com> <8056190C-ED5F-46CA-ABD3-86CB72AD725D@secure.kjonigsen.net> <4D91B204-862F-4F8E-951A-6B120A607120@gmail.com> <14087831-13B4-4347-BFB7-9752F39D7646@secure.kjonigsen.net> <9243B053-3D89-4A03-A7C5-9F9CD37BE711@gmail.com> <86seku1ih9.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3826.600.51.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77846 Cc: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= , 77846@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 24 May 2025, at 11:11, Eli Zaretskii wrote: >=20 >> From: Mattias Engdeg=C3=A5rd >> Date: Thu, 15 May 2025 19:04:02 +0200 >> Cc: Eli Zaretskii , >> 77846@debbugs.gnu.org >>=20 >> Jostein and Eli, sorry about the delay. >>=20 >> 23 apr. 2025 kl. 08.29 skrev Jostein Kj=C3=B8nigsen = : >>=20 >>> Just to be clear and to make sure I understand: Do you suggest I = test that hook locally and if it works, propose that as a patch? If so, = should I add it to compile.el? Or were you suggesting something else? >>=20 >> What I meant is that `compilation-filter-hook` seems to be the proper = level for filtering out stuff that isn't part of the messages emitted by = a compiler, or in-band signalling common to otherwise unrelated tools. = An example of the former would be unwanted annotation by the build = system or terminal emulation, of the latter is SGR escape sequences for = colouring the output. >>=20 >> I just don't understand where the 'ESC =3D' sequence comes from (the = C# compiler?) or what it means. You said it was for 'fanciness', but I = can't find any reference to it anywhere. >>=20 >> Could it be the result of Emacs mutilating the message somehow? What = happens if you send the compiler errors to a file and visit it with = Emacs in fundamental-mode? >=20 > Jostein, any followups or comments? I'm afraid not. The feedback so far has been not as straightforward as it usually is = when there's a bug which needs fixing. I'm still on the fence on what I think is the best solution for me = personally & locally only, vs what is a good fix to push upstream for = all Emacs-users to consume. If open bugs in the tracker is an issue (administrative noise, etc) It's = OK for me to close/suspend this bug as it is, while I work around it = locally until I have a proper lightbulb-moment. Right now, I have other more important fixes I'd rather put my attention = instead ;) -- Jostein