Subject: [bug#77836] [PATCH emacs-team] gnu: emacs-ws-butler: Update to 1.3.

From: Liliana Marie Prikler <[email-masked]>
Date: Thu, 17 Apr 2025 20:19:54 +0200

Am Donnerstag, dem 17.04.2025 um 10:51 +0200 schrieb Cayetano Santos:
> 
> > mer. 16 avril 2025 at 21:49, Liliana Marie Prikler
> > <[email-masked]> wrote:
> 
> > >      (source
> > >       (origin
> > >         (method url-fetch)
> > >         (uri (string-append
> > > "https://elpa.nongnu.org/nongnu/ws-butler-" version
> > >                             ".tar"))
> > >         (sha256
> > > -        (base32
> > > "1vy7g2ryg1drcz9zpn011d36zcd9a5b5yny5hwpjrllqj5dg73jx"))))
> > > +        (base32
> > > "14q19rvps5jcshyls3aa55pxmqbbkhhbdlchnl7ybxwkvvmig9zh"))))
> > >      (build-system emacs-build-system)
> > > +    (arguments
> > > +     (list
> > > +      #:tests? #f ; no Makefile in tar file
> > > +      #:test-command #~(list "make" "test")))
> > Why do you use "make" for a test command, when there's no Makefile?
> 
> There is a Makefile in the repo, including a target for tests:
> 
>    
> https://git.savannah.gnu.org/cgit/emacs/nongnu.git/tree/?h=elpa/ws-butler
> 
> Except that the Makefile is removed from elpa .tar file.
> 
> Similar to other packages, we disable tests, specifying the reason,
> while we provide the recipe to run them, once the issue fixed.
> 
> Not sure what is the right option with elpa .tar files, cloning
> nongnu instead ? remove test-command ?
Looking at the Makefile, I think it's actually preferable to spell out
the Emacs command for testing (including "--batch", which upstream does
not appear to use), in which case we only need the tests themselves
preserved in the archive.

Cheers