GNU bug report logs - #77832
[PATCH] news: Add entry for the node-build-system API change.

Previous Next

Package: guix-patches;

Reported by: Jelle Licht <jlicht <at> fsfe.org>

Date: Tue, 15 Apr 2025 20:58:02 UTC

Severity: normal

Tags: patch

Done: Jelle Licht <jlicht <at> fsfe.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jelle Licht <jlicht <at> fsfe.org>
Subject: bug#77832: closed (Re: [bug#77832] [PATCH] news: Add entry for
 the node-build-system API change.)
Date: Fri, 18 Apr 2025 13:07:06 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#77832: [PATCH] news: Add entry for the node-build-system API change.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77832 <at> debbugs.gnu.org.

-- 
77832: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77832
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jelle Licht <jlicht <at> fsfe.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Julien Lepiller <julien <at> lepiller.eu>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>, 77832-done <at> debbugs.gnu.org
Subject: Re: [bug#77832] [PATCH] news: Add entry for the node-build-system
 API change.
Date: Fri, 18 Apr 2025 15:06:18 +0200
Ludovic Courtès <ludo <at> gnu.org> writes:

> Jelle Licht <jlicht <at> fsfe.org> writes:
>
>> * etc/news.scm: Add entry.
>>
>> Change-Id: I11b33fef997764f661e03a4b527c7610c48940f0
>
> LGTM, thanks. :-)
Merged into master and pushed[*] including Florian's suggested edits as a4a7ff0319.


Thanks one and all!
- Jelle

[*]: After 10+ times of getting a 502 error

[Message part 3 (message/rfc822, inline)]
From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] news: Add entry for the node-build-system API change.
Date: Tue, 15 Apr 2025 22:52:48 +0200
* etc/news.scm: Add entry.

Change-Id: I11b33fef997764f661e03a4b527c7610c48940f0
---
 etc/news.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/etc/news.scm b/etc/news.scm
index 4b3da44540..7e9f41736d 100644
--- a/etc/news.scm
+++ b/etc/news.scm
@@ -28,6 +28,7 @@
 ;; Copyright © 2024 Nicolas Graves <ngraves <at> ngraves.fr>
 ;; Copyright © 2024 Sebastian Dümcke <code <at> sam-d.com>
 ;; Copyright © 2025 Roman Scherer <roman <at> burningswell.com>
+;; Copyright © 2025 Jelle Licht <jlicht <at> fsfe.org>
 
 ;;
 ;; Copying and distribution of this file, with or without modification, are
@@ -36,6 +37,23 @@
 
 (channel-news
  (version 0)
+ (entry (commit "3e9e164154af6245389af5a1781473b36263ad20")
+        (title
+         (en "Incompatible changes in the @code{node-build-system}"))
+        (body
+         (en "The @code{node-build-system} has been modified to work with the new
+@code{modify-json} API.
+
+Note that if you used @code{delete-dependencies} or
+@code{with-atomic-json-file-replacement} in your own packages previously, you now
+have to wrap these in @code{modify-json}.  For example:
+
+@lisp
+(modify-json (delete-dependencies '(\"tslint\")))
+@end lisp
+
+The @code{npm-binary} importer generates package expressions using the new
+@{modify-json} API.")))
 
  (entry (commit "0e51c6547ffdaf91777f7383da4a52a1a07b7286")
         (title

base-commit: 12a6dd40a7b88454cc8a8c930c22681fcee5b1ea
-- 
2.49.0





This bug report was last modified 30 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.