From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: eg642616@gmail.com, eliz@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Apr 2025 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77823@debbugs.gnu.org Cc: eg642616@gmail.com, eliz@gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: eg642616@gmail.com, eliz@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17447164859310 (code B ref -1); Tue, 15 Apr 2025 11:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Apr 2025 11:28:05 +0000 Received: from localhost ([127.0.0.1]:50939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4eST-0002Q4-Ai for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:05 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42764) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4eSR-0002PX-81 for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSI-0002F1-TD for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:57 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSF-00083V-AK for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:54 -0400 DKIM-Signature: a=rsa-sha256; b=AS0KH3IqgU5XlMmVSjVcpnPPEIcoAuu1D7zr1njT+3AO5MVYnrGotcCkPlweunnl9xVdRtkoZLhR0RMH2V/xVZ6YdNB486OST2r5ewSZGIcTNiSD9eWx7SUdvk9Nis5Vo5U8M3P/9q6UbACD9eInwCaI3TtsADS7NBOIEz4JGxZGIdmhItbG+hA4NBFkU9GMlmXxH6ejD0LzzhTKY4nlp3PRPROaKkM9bG1/euddHnkpYC+YJwhmpjSl6gClObtvkIt7t8nKdiAfKPQV1ARp3Pv2IC+4w5mouoUr015YPFHb8DY6a1/c57buYOMltAxZtrxzt0FO1O6I63tIg28biw==; s=purelymail3; d=spwhitton.name; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=V3koxIjNnuH8uoJ0wmgQ9CSlyFRkWgONxBkcTfP8vnwZtj4MoINVKyeQA9uDJhWpvdrUklnGAxYT2uataxoqk2H9Zu5QJsGroBxXtEVEHahC8n6WjKWF2eva9O/ph8I6hVR5A9OXDzL3ey3tP4sH8Ul/O6n5aGu78gv92+2OJohNsnZUvURrAs/cmjgE2SIW6JAv2XFZpBDVIX/0AaiZ+vwpud/26mgQxB0Mw7VrLjDnOVs2BnGjdvSVmBUi07ATfWwqmdZ4Ti/VcCuXYxbYP8hGWX4g/OBBfcQpDusz0pXDAmRYfGme56ZxWU5XKk85Qf/R/e6NlbY8dNEXFt/vHQ==; s=purelymail3; d=purelymail.com; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -2113166126 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Apr 2025 11:27:48 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id CE2A97E6BB8; Tue, 15 Apr 2025 19:27:44 +0800 (CST) From: Sean Whitton Date: Tue, 15 Apr 2025 19:27:44 +0800 Message-ID: <87v7r5slzj.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) X-debbugs-cc: eg642616@gmail.com, eliz@gnu.org 1. emacs -q 2. C-x b foo RET 3. M-x emacs-lisp-mode RET 4. ;;;; hello M-j Result is: --8<---------------cut here---------------start------------->8--- ;;;; hello|# #| --8<---------------cut here---------------end--------------->8--- but it should be --8<---------------cut here---------------start------------->8--- ;;;; hello ;;;; --8<---------------cut here---------------end--------------->8--- My first thought is that since multiline comments of this style are not valid Emacs Lisp, we should just set block-comment-start and block-comment-end to nil for emacs-lisp-mode. However, the recipe provided above works if you do 'M-x lisp-mode RET' instead. Even though Common Lisp supports these block comments, if you are already writing a semicolon-delimited comment, then M-j should continue it, rather than starting a #| |# comment. -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sean Whitton Subject: bug#77823: closed (Re: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d) Message-ID: References: <86bjsxh8gw.fsf@gnu.org> <87v7r5slzj.fsf@melete.silentflame.com> X-Gnu-PR-Message: they-closed 77823 X-Gnu-PR-Package: emacs Reply-To: 77823@debbugs.gnu.org Date: Tue, 15 Apr 2025 13:16:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1744722962-8653-1" This is a multi-part message in MIME format... ------------=_1744722962-8653-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77823: 31.0.50; M-j regression since commit 4c6b1712a4d which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77823@debbugs.gnu.org. --=20 77823: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77823 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1744722962-8653-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77823-done) by debbugs.gnu.org; 15 Apr 2025 13:15:26 +0000 Received: from localhost ([127.0.0.1]:51171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4g8L-0002Eb-VJ for submit@debbugs.gnu.org; Tue, 15 Apr 2025 09:15:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4g8I-0002EC-PJ for 77823-done@debbugs.gnu.org; Tue, 15 Apr 2025 09:15:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4g8D-0005Ii-7B; Tue, 15 Apr 2025 09:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bMzBKWSw2rifbQW8QaOxa1fnJXDl4VzABJ3BznGovas=; b=bRL2acoznW24 k4zOExQ2c9F22i5O8oNg3BOo3p6vBA/UH9MuQYQ3bwYTVK3SKjzhSBjHBDbQKvkvs4MLMtbXKONdh MeDx+2uJqJ8gAl5YEntc9uIkGs3a3NLS4dZ5/AivbiRyAatNAe/AoFp++zfXX7YoV7SFk/1H6tZaf jnQ0ANFmkiiZmvlRuki+sXeK4Bk7wfyVc/AeaGX19LiBqRK0XP2Tp31VImqoQ0VO3OPlcgIVmO71L qGgI7s3PNUq23tHbUSxIgGyQlnD69m0SnLRTCFuq8AsHQYf2pDe0ODSnLiu6Qg98/yEu9fi801Fze jpFjP6DJHs5G8YT4+4r6cQ==; Date: Tue, 15 Apr 2025 16:15:11 +0300 Message-Id: <86bjsxh8gw.fsf@gnu.org> From: Eli Zaretskii To: Sean Whitton In-Reply-To: <87v7r5slzj.fsf@melete.silentflame.com> (message from Sean Whitton on Tue, 15 Apr 2025 19:27:44 +0800) Subject: Re: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d References: <87v7r5slzj.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77823-done Cc: eg642616@gmail.com, 77823-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: eg642616@gmail.com, eliz@gnu.org > From: Sean Whitton > Date: Tue, 15 Apr 2025 19:27:44 +0800 > > 1. emacs -q > 2. C-x b foo RET > 3. M-x emacs-lisp-mode RET > 4. ;;;; hello M-j > > Result is: > > --8<---------------cut here---------------start------------->8--- > ;;;; hello|# > #| > --8<---------------cut here---------------end--------------->8--- > > but it should be > > --8<---------------cut here---------------start------------->8--- > ;;;; hello > ;;;; > --8<---------------cut here---------------end--------------->8--- This has been fixed by a followup changeset that Elijah sent. So I'm closing this bug. ------------=_1744722962-8653-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Apr 2025 11:28:05 +0000 Received: from localhost ([127.0.0.1]:50939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4eST-0002Q4-Ai for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:05 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42764) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4eSR-0002PX-81 for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSI-0002F1-TD for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:57 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSF-00083V-AK for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:54 -0400 DKIM-Signature: a=rsa-sha256; b=AS0KH3IqgU5XlMmVSjVcpnPPEIcoAuu1D7zr1njT+3AO5MVYnrGotcCkPlweunnl9xVdRtkoZLhR0RMH2V/xVZ6YdNB486OST2r5ewSZGIcTNiSD9eWx7SUdvk9Nis5Vo5U8M3P/9q6UbACD9eInwCaI3TtsADS7NBOIEz4JGxZGIdmhItbG+hA4NBFkU9GMlmXxH6ejD0LzzhTKY4nlp3PRPROaKkM9bG1/euddHnkpYC+YJwhmpjSl6gClObtvkIt7t8nKdiAfKPQV1ARp3Pv2IC+4w5mouoUr015YPFHb8DY6a1/c57buYOMltAxZtrxzt0FO1O6I63tIg28biw==; s=purelymail3; d=spwhitton.name; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=V3koxIjNnuH8uoJ0wmgQ9CSlyFRkWgONxBkcTfP8vnwZtj4MoINVKyeQA9uDJhWpvdrUklnGAxYT2uataxoqk2H9Zu5QJsGroBxXtEVEHahC8n6WjKWF2eva9O/ph8I6hVR5A9OXDzL3ey3tP4sH8Ul/O6n5aGu78gv92+2OJohNsnZUvURrAs/cmjgE2SIW6JAv2XFZpBDVIX/0AaiZ+vwpud/26mgQxB0Mw7VrLjDnOVs2BnGjdvSVmBUi07ATfWwqmdZ4Ti/VcCuXYxbYP8hGWX4g/OBBfcQpDusz0pXDAmRYfGme56ZxWU5XKk85Qf/R/e6NlbY8dNEXFt/vHQ==; s=purelymail3; d=purelymail.com; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -2113166126 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Apr 2025 11:27:48 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id CE2A97E6BB8; Tue, 15 Apr 2025 19:27:44 +0800 (CST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 31.0.50; M-j regression since commit 4c6b1712a4d Date: Tue, 15 Apr 2025 19:27:44 +0800 Message-ID: <87v7r5slzj.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) X-debbugs-cc: eg642616@gmail.com, eliz@gnu.org 1. emacs -q 2. C-x b foo RET 3. M-x emacs-lisp-mode RET 4. ;;;; hello M-j Result is: --8<---------------cut here---------------start------------->8--- ;;;; hello|# #| --8<---------------cut here---------------end--------------->8--- but it should be --8<---------------cut here---------------start------------->8--- ;;;; hello ;;;; --8<---------------cut here---------------end--------------->8--- My first thought is that since multiline comments of this style are not valid Emacs Lisp, we should just set block-comment-start and block-comment-end to nil for emacs-lisp-mode. However, the recipe provided above works if you do 'M-x lisp-mode RET' instead. Even though Common Lisp supports these block comments, if you are already writing a semicolon-delimited comment, then M-j should continue it, rather than starting a #| |# comment. -- Sean Whitton ------------=_1744722962-8653-1-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Apr 2025 00:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77823@debbugs.gnu.org, eliz@gnu.org, eg642616@gmail.com Cc: control@debbugs.gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174476362811087 (code B ref 77823); Wed, 16 Apr 2025 00:34:03 +0000 Received: (at 77823) by debbugs.gnu.org; 16 Apr 2025 00:33:48 +0000 Received: from localhost ([127.0.0.1]:58439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4qip-0002sf-BL for submit@debbugs.gnu.org; Tue, 15 Apr 2025 20:33:48 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:52018) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4qij-0002qS-3v for 77823@debbugs.gnu.org; Tue, 15 Apr 2025 20:33:43 -0400 DKIM-Signature: a=rsa-sha256; b=yWwV7TKgSUK/cSXvLKE3I5WbbgRNwY6jcc6drx70UyAzqKRCFYu2sOUU7u+d3712iOoQv4f9XuPg3F0crgTJz3uceD9OD7O2REvK1sSiEFD6YfYN/hb/ubxlz+0f8wmeCcduUvPQBYwFlkI9V2qr71TxZn/qX6E69j22dTuMnCT8iiQxkk9tBBiLRbCBynhA5Kw+qM6fPbdPUQu4qQPU2yySwciLsbrTjUrFQzS2PxZB1RVWBesvqBAQ44CyGxvMSyo+Kv2ccShoHFMrdt4KiqkCC/vpQ4fnRs5DoyaXgy0gsQM23LeK5aWeqrRYvktBbb8GOtyPIQKpIerllYpG4w==; s=purelymail3; d=spwhitton.name; v=1; bh=dE1TeFr5RdTTgpKiJa937wXjx9lBjTpHKU5QWXXTKOY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=MD2L4FolxQJvUKUdA4EeoyMbhjdcBC6/rzOwGZSsRUz+bfFV2i8Stn/eGFi2z+dXndoEEb+iLMxHG8VkKfFywvoY8JQwR8TstQ95Wh62KJnNgHcpoVzJ/IHsq4VcIeC2mXuEg7PKWjpMPYub+94EEwcJdMXMjjUGCVc+SD0UgxP9nXWU8cQeQICBph9Nda9NH4tZPoUmgfhmWagdLW9KTIPFCQz0eqb3m3qZI6NvUHaLjKWDcZajmF2BgI7+NP7D9LBAc97EMzXnFP/1epllFvoQIGmfXWJeil44iDOTjM1jBMF9oHgaSXpwDdoYJ8mutpAqAxSJdLKbG/MGCIwP1Q==; s=purelymail3; d=purelymail.com; v=1; bh=dE1TeFr5RdTTgpKiJa937wXjx9lBjTpHKU5QWXXTKOY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1176146218; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 16 Apr 2025 00:33:32 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 086877EE3B8; Wed, 16 Apr 2025 08:33:30 +0800 (CST) From: Sean Whitton In-Reply-To: <86bjsxh8gw.fsf@gnu.org> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> Date: Wed, 16 Apr 2025 08:33:30 +0800 Message-ID: <87fri9rllx.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) reopen 77823 thanks Hello, On Tue 15 Apr 2025 at 04:15pm +03, Eli Zaretskii wrote: > This has been fixed by a followup changeset that Elijah sent. > > So I'm closing this bug. It's still present, just replace 'M-x emacs-lisp-mode' with 'M-x lisp-mode' in my recipe. M-j for editing Common Lisp is broken. Possibly Elijah's original commit has just uncovered an existing problem, but either way it's a bug. Elijah, can you take a look at the lisp-mode issue, please? -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Apr 2025 00:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: eliz@gnu.org, 77823@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17447649651337 (code B ref 77823); Wed, 16 Apr 2025 00:57:03 +0000 Received: (at 77823) by debbugs.gnu.org; 16 Apr 2025 00:56:05 +0000 Received: from localhost ([127.0.0.1]:58681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4r4P-0000LV-7X for submit@debbugs.gnu.org; Tue, 15 Apr 2025 20:56:05 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:42337) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u4r4I-0000JN-DX; Tue, 15 Apr 2025 20:55:58 -0400 Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3fea0363284so123238b6e.1; Tue, 15 Apr 2025 17:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744764952; x=1745369752; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8Fj8Qf/m80xPQF6RSS6VKFVstc8nYUBxaD5LgdE+GK8=; b=fX5bFWKXsRn/a4U5tpVHNm1IdD2g5Bnv3P3MEja6WHj0qSWb9yYuNXdF3RsCYcYuu7 j8B06ehnaEjWkpK6lOZeWOY9JBWTkYBTqN+gzHNPix8Q53xR3cgKXkPeZXPtXtWAcQim wWNsApu4f68KUjjR/lL8oCgmtNHn573b0ArzrMX1sUILcx6SR61nqsiDSAgcvQmKY8bm i2prjj7auyPCPURRtu5jQzPWZzMw7b82/NnClm6IKJA3CSqib4iTlagp12GBp5itxRmT Q/vyNc386webhA05f6ZigN3/bWnIfrIhg9FJNP67IJ9ZyoF1GgWxdIyBzq3ytx4s/cyk EWlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744764952; x=1745369752; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Fj8Qf/m80xPQF6RSS6VKFVstc8nYUBxaD5LgdE+GK8=; b=fF3ciEy+NW/PUZNApezqgd2PyZO7rcndsMzfZCa03x1VeP4sGICXoIJ5/AGVhCfcSg NxB4BTeSRAqLd5ZtPe+TlyYQgtzLpuzTZXb5qOtZKwcUKwnkYSRypf1xoFj9/q5nGJQq J9asr0IS9JLFWJNfw0rMllGbZf/H4gfsR/ZRG+REfxmpKzbAmyRERZBkTsvb1V/DMxTH 81LH/A4J+F+TOsYfI5Xu2VHn0Bm/ODU/uXKeaGuhXgefh6WlhqwHBoHzjSqzIYjOkklW oJHeuCBxTpzlUOeBMJXzd0PYUslry5yVY73d7Z9rTwy2AYQQk9AlO6YhWTiqmMD92BsN ubKQ== X-Forwarded-Encrypted: i=1; AJvYcCVR4cHsGFkH6hXVb+5ADj6Jkt42BJkiyeL/AtXPOC6K2w0JXbkI50QIrz1PJGF5YnZKwasOEBt7@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy1qRXRjZgvwX9ekPVXFR9Xlv5A9M4QbKInnEX7JWniv6rggcjt xxA++s3wxr7x85ls3Sw92mpxsL2shygRGO6PtBuzoBxs02YcWhoFhtgXE4Wz X-Gm-Gg: ASbGnctSsJvHZTgzZmThhxfaXuMgtUUhPXO1m2xSPqAGJddxvVm9U+wqozIyIXUvMNp sPpdxmaizIIcItB8ihiYwxdBIh0s+AOftVW/Ukk4x7rF09F5B7yGC0VX9h5aNYuOvMrZ+lx8igl gGXpGCnGQE+BKpH5lwe+Ft14Jwq7VBEeViomRAamcdap99P+GNLyyl5RKfBHtQoRG96goSN45rD XeTFsIXo9WjozeLz4E0qsPnKsGsxDggQxGNjKWkVfEJQa0M5CWMmfIFGyeKhAIZK78XmVENo1Cq FSj+7BiW X-Google-Smtp-Source: AGHT+IGIZODt4Oaikp53e6xDtR/JHZ47FSO5sBr3x9/5vJ6kY7VGQvsSWyAbynEBqgNQyK++Px8qWQ== X-Received: by 2002:a05:6808:2388:b0:3f6:abd2:8bf9 with SMTP id 5614622812f47-400a4343fc5mr3209595b6e.19.1744764952399; Tue, 15 Apr 2025 17:55:52 -0700 (PDT) Received: from fedora ([2806:10ae:e:7566::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72e73d714d1sm2609258a34.19.2025.04.15.17.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 17:55:51 -0700 (PDT) From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= In-Reply-To: <87fri9rllx.fsf@melete.silentflame.com> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> Date: Tue, 15 Apr 2025 18:55:50 -0600 Message-ID: <87mscgkjqh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Sean Whitton writes: > reopen 77823 > thanks > > Hello, > > On Tue 15 Apr 2025 at 04:15pm +03, Eli Zaretskii wrote: > >> This has been fixed by a followup changeset that Elijah sent. >> >> So I'm closing this bug. > > It's still present, just replace 'M-x emacs-lisp-mode' with > 'M-x lisp-mode' in my recipe. M-j for editing Common Lisp is broken. > > Possibly Elijah's original commit has just uncovered an existing > problem, but either way it's a bug. > > Elijah, can you take a look at the lisp-mode issue, please? I found the issue, `comment-indent' was using both block-comment variables first than `comment-start' and `comment-end', this must fix it. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=fixpatch.patch diff --git a/lisp/newcomment.el b/lisp/newcomment.el index eb36f91104d..3e20da816b9 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -722,9 +722,9 @@ comment-indent (let* ((empty (save-excursion (beginning-of-line) (looking-at "[ \t]*$"))) (starter (or (and continue comment-continue) - (and empty block-comment-start) comment-start)) + comment-start (and empty block-comment-start))) (ender (or (and continue comment-continue "") - (and empty block-comment-end) comment-end))) + comment-end (and empty block-comment-end)))) (unless starter (error "No comment syntax defined")) (beginning-of-line) (let* ((eolpos (line-end-position)) --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Apr 2025 01:51:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17447682126501 (code B ref 77823); Wed, 16 Apr 2025 01:51:05 +0000 Received: (at 77823) by debbugs.gnu.org; 16 Apr 2025 01:50:12 +0000 Received: from localhost ([127.0.0.1]:59180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4ruc-0001f4-OV for submit@debbugs.gnu.org; Tue, 15 Apr 2025 21:50:09 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:57404) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4ruR-0001e4-TU for 77823@debbugs.gnu.org; Tue, 15 Apr 2025 21:49:58 -0400 DKIM-Signature: a=rsa-sha256; b=0hYBVTGHowMGYDA4UOg6bSiaCIS2aFt7gCI5PFlKXeb/PebJVrFecGImubczEhuHhjN8toZvTHTqFcNkIdwjSY41z2uoiDnHmTMWNXqNWMAHuMh0rAAQ4jXCE5SN1FzClhE0dWnNCbwnX+HThuaOSk+ihWtEVutMcF5kG+dDL0dCZ0mF1FURdaguGy55VBtoGrz89JBzJGXO4fCNHOrurB328W1bjuBArF+ct4H12oscu3vXy79P0ZmqWqzBD5iQu7ND50GJLsQZxcqfKSEtQWWxHQTaViiRML0/Z0wp4VtbMZu0KYAC52tjAgXRxHHsWXNtYeiNyU+1JWe1E8ytbw==; s=purelymail3; d=spwhitton.name; v=1; bh=qJJLP2x3tOwZ393OhxUCTllciwn5LiXYDvJPgDRjZVY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=NCn5VcMz65B0MVItK6CFkKTiJHWxXzxm6NNnCYFH5A9qKDf7mFl7Q+4HqYN3Wd/o5FBGmj+hYt2al0eQkzr8v2Ys30Wo13lkKhKso3gK0o+gXK966V2NsQGimDPPAjy6U2a5YTP8ZXKdgSAKLcDrSLw+7fqFFtFXjCxyVN7sQy/H1a2wRbPH8HVEpJFEGgBMWqTNlIJIykDglSh/G6tgVfLSz1qAz3CmwUQ2ycdcelwPWFdQOq8OF+DQgZkcbgqecuYz4t8vwcUm9BGctb+A/BBIOz9z3mKNnsCa64OSOV3e1A/Aja0MlK5WellO9yO/7Tf9Ce0NyIBs6xo3C5qXVQ==; s=purelymail3; d=purelymail.com; v=1; bh=qJJLP2x3tOwZ393OhxUCTllciwn5LiXYDvJPgDRjZVY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -468566417; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 16 Apr 2025 01:49:45 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id B24477E020D; Wed, 16 Apr 2025 09:49:42 +0800 (CST) From: Sean Whitton In-Reply-To: <87mscgkjqh.fsf@gmail.com> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> Date: Wed, 16 Apr 2025 09:49:42 +0800 Message-ID: <87lds0ri2x.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Tue 15 Apr 2025 at 06:55pm -06, Elijah Gabe P=C3=A9rez wrote: > I found the issue, `comment-indent' was using both block-comment > variables first than `comment-start' and `comment-end', this must fix it. > > diff --git a/lisp/newcomment.el b/lisp/newcomment.el > index eb36f91104d..3e20da816b9 100644 > --- a/lisp/newcomment.el > +++ b/lisp/newcomment.el > @@ -722,9 +722,9 @@ comment-indent > (let* ((empty (save-excursion (beginning-of-line) > (looking-at "[ \t]*$"))) > (starter (or (and continue comment-continue) > - (and empty block-comment-start) comment-start)) > + comment-start (and empty block-comment-start))) > (ender (or (and continue comment-continue "") > - (and empty block-comment-end) comment-end))) > + comment-end (and empty block-comment-end)))) > (unless starter (error "No comment syntax defined")) > (beginning-of-line) > (let* ((eolpos (line-end-position)) Thanks! I don't know the comment code well; Stefan, would you mind giving this a quick look? --=20 Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Apr 2025 00:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174485015529489 (code B ref 77823); Thu, 17 Apr 2025 00:36:03 +0000 Received: (at 77823) by debbugs.gnu.org; 17 Apr 2025 00:35:55 +0000 Received: from localhost ([127.0.0.1]:45096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5DEQ-0007fS-C6 for submit@debbugs.gnu.org; Wed, 16 Apr 2025 20:35:55 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7520) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5DEO-0007ev-53 for 77823@debbugs.gnu.org; Wed, 16 Apr 2025 20:35:52 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7BC3E1000BC; Wed, 16 Apr 2025 20:35:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744850140; bh=VJ+iiNveMvywHTeytkjPormgC+IVq3AO+3oNNKGnJYw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oiGZcAZTRlgw7pK4Okze0jWVzdY8fFDvoo8cT9Wh4G9TthHnb7UCwxGuXyd3dltZb rPGPR3nELq8UwOCE9hcI2+0fIMrV7Qg1oDQFL1Rp/fb/dNUfCHGYC0oz796NevIaNk EtmJnCIzIo/C8RvhHavcDodHWLw8CiWkSvypWKTowbWyMLjruad/LAy56fm+FrE575 jNw4oUmkKHRw7Cm7np7Deekefy/gff3aU/1nOqoul8bFzr/UCuqHagGuJpLQ7qN8qo faTU6vpOjBobKbdGP3fqN2bK/k9bKGOZewWeo0mBbJ5fE6VVEQZmxCkJvybOn/V68A NSBKojgUb4DTw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9D7B8100029; Wed, 16 Apr 2025 20:35:40 -0400 (EDT) Received: from alfajor (104-195-239-180.cpe.teksavvy.com [104.195.239.180]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 64D2A120331; Wed, 16 Apr 2025 20:35:40 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87lds0ri2x.fsf@melete.silentflame.com> Message-ID: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> Date: Wed, 16 Apr 2025 20:35:41 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.881 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain FROM_FMBLA_NEWDOM 1.499 From domain was registered in last 7 days X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I found the issue, `comment-indent' was using both block-comment >> variables first than `comment-start' and `comment-end', this must fix it. >> >> diff --git a/lisp/newcomment.el b/lisp/newcomment.el >> index eb36f91104d..3e20da816b9 100644 >> --- a/lisp/newcomment.el >> +++ b/lisp/newcomment.el >> @@ -722,9 +722,9 @@ comment-indent >> (let* ((empty (save-excursion (beginning-of-line) >> (looking-at "[ \t]*$"))) >> (starter (or (and continue comment-continue) >> - (and empty block-comment-start) comment-start)) >> + comment-start (and empty block-comment-start))) >> (ender (or (and continue comment-continue "") >> - (and empty block-comment-end) comment-end))) >> + comment-end (and empty block-comment-end)))) >> (unless starter (error "No comment syntax defined")) >> (beginning-of-line) >> (let* ((eolpos (line-end-position)) > > Thanks! I don't know the comment code well; Stefan, would you mind > giving this a quick look? My understanding is that the `newcomment.el` code (and its predecessor which lived in `simple.el`) never really knew what `block-comment-start/end` were for so it's used inconsistently and I'd be surprised if there aren't more misbehaviors linked to them, Of course, maybe the `simple.el` code did know and it's the guy who rewrote it into `newcomment.el` who messed it all up. =F0=9F=99=82 In any case, the above is equivalent to just removing the `(and empty block-comment-start/end)` because `comment-start/end` should never be nil anyway, so it's probably worthwhile thinking about what we want to do with `block-comment-start/end` here. Maybe "nothing" is the right answer, of course. Stefan "really not a fan of `block-comment-start/end`" From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Apr 2025 04:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 77823@debbugs.gnu.org, Sean Whitton Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174486411716139 (code B ref 77823); Thu, 17 Apr 2025 04:29:02 +0000 Received: (at 77823) by debbugs.gnu.org; 17 Apr 2025 04:28:37 +0000 Received: from localhost ([127.0.0.1]:45344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5Grd-0004CD-5V for submit@debbugs.gnu.org; Thu, 17 Apr 2025 00:28:37 -0400 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]:48359) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u5GrY-0004Bn-VX for 77823@debbugs.gnu.org; Thu, 17 Apr 2025 00:28:34 -0400 Received: by mail-qv1-xf44.google.com with SMTP id 6a1803df08f44-6e8fb83e137so3633366d6.0 for <77823@debbugs.gnu.org>; Wed, 16 Apr 2025 21:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744864107; x=1745468907; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FfizdpXv0llRrLDO+pT9AF6DuXXvAYlIat28QFIh3T4=; b=VqG+MkxMIWotAeiKw4WMoKNS2gm82ZTrYBcRv2GetPP6e0k/8ZmS1hSGQLahSXkFRP QPpewku0xe/QLxdgiqeM1J4gdjzJOTXUhxftdx5Sza+qkVY3xQrA6ggWd+l877QAjdWp M3LAGageKimrHMOn51wewtxdwJIk+CochC17/Yg+3AAqsTtBngMgWX2IHVHiweC+yQTk CPbN43Xd58/ka7eNlR0ug7CPB1l2UjrNIzSORobS0K6IbElBDcGLdoK/necmRS4w3z0o 3t8I6FPBBeUxMJJilRvqz2OxIgxnMzYqE/Pk4Pw0maZdZuNehv1uf27cmv7Bqe1Y1U+8 MamA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744864107; x=1745468907; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FfizdpXv0llRrLDO+pT9AF6DuXXvAYlIat28QFIh3T4=; b=gFJKzMr/SrpyJVudpPVRpDsgH8ax/KLj9HzeluKrfLSu4MVhTFVuHeWhsnhuc1OruX N5KxLaoOgpfhSicI5p0CAK+9mGndYqOIdFMOq9lBK2JecAJ098vrKRpsPQobZxKGL1yV rT7pZhKDKShECr75fu727xdC55kI+OgJf7BF8b+33MK2YvpEmJQ/zsqBy3Ft3eWlpX0f NmuCigHeE1QJm8tKIvzlbdbDU88tqTkNFBGVXLMevGzCoI1VG+m5EaOgAZSoS55hI3Tb GmzjcC4dK1KsyOwsil6jsEfBWUGK6fIhJBxaOv0rIOF40N6LiA2ozDZlXICTx0hoUmwE bxvQ== X-Forwarded-Encrypted: i=1; AJvYcCVs7BiU9NM+cFTXQKJEate56q1M83IjJ3vsQw5rDvUJE/KhRjc53VGSpk4EGSFDiq+zFrrlMA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyQmJ48tZnZcND9VJqFpHdCuLMUR/t/WegOS8PlMcEpgDg1yjhm xCZiHs+j/rZsJ+sURa/N86pBAewoMPESqANmD99m4Gim4EprT1RTwvJ5jLXzIixVpr7H4yU13pk AWn+KSU+SIoKQ7dllZ43fF19RUDc= X-Gm-Gg: ASbGncvkDohKUFromPbahVRvVq/Lkekn3PX3g4S3/E1pLnw7GuoioK/yTCj7FgrIgc5 4hDABrRKx4vc50ShywgSr3Y5sBE+0VM2yjBfOpzlLBBcNhuBLfd4hDEIJaIFXaHXS33rCUEDHDm et3OtpOgEX8TV3pjsgCL+3aAEipwFyApL448YxhDv5qdaIsKxQoQ== X-Google-Smtp-Source: AGHT+IHQ1+oYrC2YcFxRd/5TgUbmskFyUMRUsStn7i/PFvMzvosEvdHRwwGCZxmUy6icAo5BJXtjOoCKXeizOy8LYR0= X-Received: by 2002:a05:6214:f0f:b0:6f2:a537:f47e with SMTP id 6a1803df08f44-6f2b30837b0mr69085906d6.42.1744864106977; Wed, 16 Apr 2025 21:28:26 -0700 (PDT) MIME-Version: 1.0 References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> In-Reply-To: From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Date: Wed, 16 Apr 2025 22:28:15 -0600 X-Gm-Features: ATxdqUHYifGRWTeZBUsE6Bbs_WTBGyWQCC2QHSYDXf0xJoSXzORUMm8Q3F5NDIY Message-ID: Content-Type: multipart/alternative; boundary="0000000000004720550632f1d597" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000004720550632f1d597 Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: > In any case, the above is equivalent to just removing the `(and empty > block-comment-start/end)` because `comment-start/end` should never be > nil anyway, so it's probably worthwhile thinking about what we want to > do with `block-comment-start/end` here. > Maybe "nothing" is the right answer, of course. block-comment-start/end have been unused for almost 20 years, comment-start/end had already replaced them ofc. So, I think block-comment variables should no longer be used to indent comments (as it seems that it was planned), instead use them for other purposes, give them a "new life". --0000000000004720550632f1d597 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Monnier writes:
In any case, the above is equivalent to just removing the `(and empty
block-comment-start/end)` because `comment-start/end` should never be
nil anyway, so it's probably worthwhile thinking about what we want to<= br> do with `block-comment-start/end` here.
Maybe "nothing" is the right answer, of course.

block-comment-start/en= d have been unused for almost 20 years, comment-start/end had already repla= ced them ofc.=C2=A0 So, I think block-comment variables should no longer be= used to indent comments (as it seems that it was planned), instead use the= m for other purposes, give them a "new life".
--0000000000004720550632f1d597-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Apr 2025 07:09:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: eliz@gnu.org, 77823@debbugs.gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174496008426305 (code B ref 77823); Fri, 18 Apr 2025 07:09:03 +0000 Received: (at 77823) by debbugs.gnu.org; 18 Apr 2025 07:08:04 +0000 Received: from localhost ([127.0.0.1]:49469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5fpR-0006pr-Kp for submit@debbugs.gnu.org; Fri, 18 Apr 2025 03:08:03 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:60980) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5fpM-0006nk-2R for 77823@debbugs.gnu.org; Fri, 18 Apr 2025 03:07:59 -0400 DKIM-Signature: a=rsa-sha256; b=RnhFpC1dqVrxJstZvQZmWpa6IiJlzUdbMslg4XOlB5s+GW0hRjr9WOlHZvPQoYc4WXtcds6cH6P4r10YFwq6pths6n2dkn9j2acdzU95rVm9LLvnh7WFil8g6l/lul+LgLCluBWVuuYSe/561d9TytzbPmYG6mfeetUoIFJxz3tz2pA9NZK3mN23mXYUwUENzYJlqy+0914YJkxsk8ePI41eGJJttcJhqNzVdFt885Lb9ZWj2e7dCX433jRcSs5NbOFLVMCSbFY0YaS6ZznOU15XzCK3t0xSve26zDMrUf6/Wji50dMfd/fK1UZzU8SxMlmsVEETusFFz8yt5LSJ2A==; s=purelymail3; d=spwhitton.name; v=1; bh=EnEbZoscMeJSIcW64aY7JQspq3k6aEXrFedV/mgluB8=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Wuj9oqs8GzjNud9csx7bJqvJegIj8N4gf1LCngJf0BxXMtW7VZUdIme6hhiVRHpl+Ob66J7bwMy0K1X1hYw1Mm9+iM2vSsRNUr4nqCBVyzEZcowJ/ejjOthJNyzrysJtNcGU0shzwPDwNgXRBYIOOl82AVR++pSoR+M4DazNfn/liUXOJbGslAVYO7GJC80MEAeD+1wrbKOV3hSg2EF/DYxz+c1Caa4WxPMendPuLSu5L6v+oy4UrLFIInVizyoqLU04cEbuQv3wx82nflQwXeG9lqPuMqy4kGONk5zuzXaFHMYLSGWjY4CipXu0VUjqpUNexzunWNx9ZKDXVhc5Zg==; s=purelymail3; d=purelymail.com; v=1; bh=EnEbZoscMeJSIcW64aY7JQspq3k6aEXrFedV/mgluB8=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2071918987; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 18 Apr 2025 07:07:48 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id A3BA67E0345; Fri, 18 Apr 2025 15:07:43 +0800 (CST) From: Sean Whitton In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> Date: Fri, 18 Apr 2025 15:07:43 +0800 Message-ID: <87ldryq75s.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thanks for commenting, Stefan. Indeed, this change as it is can't be right, because comment-start and comment-end will always be defined. The intent of the code seems to be that block comment is used if the user types M-; on an empty line, such that comment-indent wants to insert a new comment. But that's definitely wrong for Common Lisp. As #| |# comments are rarely used at all, M-; on an empty line with no active region ought to behave just like it does in Emacs Lisp mode. In other modes, block comments might be the most common form of comment, however. So I think we need a new mode-specific variable which says which to prefer in the case where the context does not determine it? -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Apr 2025 13:12:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= , 77823@debbugs.gnu.org, eliz@gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174498192024519 (code B ref 77823); Fri, 18 Apr 2025 13:12:04 +0000 Received: (at 77823) by debbugs.gnu.org; 18 Apr 2025 13:12:00 +0000 Received: from localhost ([127.0.0.1]:50640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5lVb-0006Mj-Dx for submit@debbugs.gnu.org; Fri, 18 Apr 2025 09:11:59 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54168) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5lUb-0006Aj-5B for 77823@debbugs.gnu.org; Fri, 18 Apr 2025 09:10:56 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0EFDE807BC; Fri, 18 Apr 2025 09:10:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744981838; bh=DJkBlO/zv8k1t37K7sj+3NvcriM/PWiw90mlXeTUCMs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JP0o0Gxhd6jDablsy0MPZ7nThisI8p8hPbVDkqEyMEuRBIQUSxMX5dUV+JSmDU7++ smZskBdW4OAlDYEIJ819Jfi9EJ2723X4C9skfY5Z0iGlr3RkV9yi1HlR3OEhDanrLg 3JVcv3/8Br0vtPD6zN+2NjeM9cg+p+c27pwmJUEkNRI/2bvugfTZg1pET1+0Ww/eRN eRxY8U9cygFrk8vS3DLtMtO4b3U8r3twUqL9koe9n7PTQGJVKbItSEIV1zncWdgNwT aVhPBK6dDNLzjlL/79EFA9xu21bsyzaN7ZCgbc5U9jqQan1N1AUOUJBRIa2b1RyZpC Q+NID5/Bx/OqA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C09258029E; Fri, 18 Apr 2025 09:10:38 -0400 (EDT) Received: from pastel (104-195-239-180.cpe.teksavvy.com [104.195.239.180]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8D4671204E6; Fri, 18 Apr 2025 09:10:38 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87ldryq75s.fsf@melete.silentflame.com> Message-ID: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> Date: Fri, 18 Apr 2025 09:10:37 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > In other modes, block comments might be the most common form of comment, > however. AFAIK "the most common form of comment" is what `comment-start/end` is for. Stefan "who still doesn't know what block-comment-start/end is for" From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Apr 2025 00:27:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= , 77823@debbugs.gnu.org, eliz@gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17450224014807 (code B ref 77823); Sat, 19 Apr 2025 00:27:04 +0000 Received: (at 77823) by debbugs.gnu.org; 19 Apr 2025 00:26:41 +0000 Received: from localhost ([127.0.0.1]:53479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5w2Y-0001FB-OI for submit@debbugs.gnu.org; Fri, 18 Apr 2025 20:26:40 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:55874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5w2U-0001DD-0H for 77823@debbugs.gnu.org; Fri, 18 Apr 2025 20:26:35 -0400 DKIM-Signature: a=rsa-sha256; b=EhBT9vnQq1g2PTXgwcjM3JCZXiaf+bhOWxT+qAb2D8dCpF89E4G1ky4ZTmE9eW6TRJr5uihLAyFrVZHZOGB83o+KWI+N5THRMxzc8FpxjvLJiivBip1dimynB9CyadCQJldXGAoOHl5F5ROvEF63TGHXCGjwRg5PZkHrCvVbwAGA9gbs0tnyiD7E/yQDSLrDxNirn2V16GDe17G8nQox9DzqRk3O+Y1Ynowml1DA0N3oH1FS42LkGIuPhEEJaOj46S5F+Tx1RG8p/5VS6TBWGsLxwNpfCniTZWI7Lvn8qZ/iwLmr5h+bDiPQUnykhD3+wWv24qv8EzfwepYAbkPBZg==; s=purelymail3; d=spwhitton.name; v=1; bh=sk2rjpJhA2H2XHRbJ55z/lbdLzlRM4hSTN4VHcSIm2U=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=3CfFZ8S6sSafnQWQMAk0rTeTzFf0s7/orZMivCNfUzdKUFHe/h7sVQ/OGY3cZFHn0/cGx+7y0gJED+NC0NbK8SY//jACYWgw7r2Bl60mEXTW4GC1zEfJHer9LTZUbJYOrbp8OueNjm5RzqR5QMiwG6Or3mw8II3cPACbp/5QnQkAXqRXy3EZTxIIPU9VNNvu9znp7pumALc1mvfFUF4DiLS28d3pfuMobQOAryuolmucn3aYYxDdFOZIGVd6DqDmnCPQSKpRYu9zVmyS9GH87bdxAAhI962u+gbUcTdiYRePqQ7q/8i/sS3tBC4hm+jebgcgI0s+e6k4+MY9bd0Kdw==; s=purelymail3; d=purelymail.com; v=1; bh=sk2rjpJhA2H2XHRbJ55z/lbdLzlRM4hSTN4VHcSIm2U=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -291033596; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 19 Apr 2025 00:26:27 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id AAD767E04A6; Sat, 19 Apr 2025 08:26:23 +0800 (CST) From: Sean Whitton In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> Date: Sat, 19 Apr 2025 08:26:23 +0800 Message-ID: <87ecxpm1xs.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Fri 18 Apr 2025 at 09:10am -04, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >> In other modes, block comments might be the most common form of comment, >> however. > > AFAIK "the most common form of comment" is what `comment-start/end` > is for. > > > Stefan "who still doesn't know what block-comment-start/end is for" I'm not sure either. Maybe we should back out Elijah's change and implement the actual user functionality he wants (the new minor mode) in some other way? -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Apr 2025 03:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174503441213624 (code B ref 77823); Sat, 19 Apr 2025 03:47:01 +0000 Received: (at 77823) by debbugs.gnu.org; 19 Apr 2025 03:46:52 +0000 Received: from localhost ([127.0.0.1]:54771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5zAG-0003XE-DQ for submit@debbugs.gnu.org; Fri, 18 Apr 2025 23:46:51 -0400 Received: from mail-oo1-xc41.google.com ([2607:f8b0:4864:20::c41]:57643) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u5zAA-0003VL-Pp for 77823@debbugs.gnu.org; Fri, 18 Apr 2025 23:46:45 -0400 Received: by mail-oo1-xc41.google.com with SMTP id 006d021491bc7-6049acb776bso1090935eaf.3 for <77823@debbugs.gnu.org>; Fri, 18 Apr 2025 20:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745034397; x=1745639197; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=JNfrRUGS9+V++li/QsYCGB24Uj270PDHrLzDcaZL5xM=; b=EGcKm/O89V9GQOKpQjbzPuah9xa1383DHO3Rda1sAqrXG715mbDzIrRt9/XSDolY4t CDk3BqXooaNr4D46kgW4Uw8ByA7OgO8PK0+MOwJCDto6L0Y0AtiELReC9PIsX766gi8i 5OrNnPSuT8udtKZYoGK2udWFVr0Pcyviqslw5M5PFknPp9FJHZsXS9kiupCLKEV/i5qh 4udg27sbfT87Up7sTnNXaMsrhIMrGGLVMO0/wA/Lyn6Rt7YKr5e7wZAT3MKM+uaLAQd2 mIti3XpYf9l89oH2qhtBjEH4Cvu48XKP9QgCs/Fj2VDRpwY38n6CnMKc4QatTYXipEkA SC/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745034397; x=1745639197; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JNfrRUGS9+V++li/QsYCGB24Uj270PDHrLzDcaZL5xM=; b=UPzWGtQz//Ux4ccVGKiMXUUFUOn25NzdaogTK6RR5VYg2VRcddwy9kX+burPnssJYq IIskKD1TGWuZ8yxgm17+yKHg8thrFw66NkfYiRDcHCOEJW5ikeHcGsFBevcMFCL3++lg Fc1Nce7rA7TI/wAdLvUhSsjyzaI5gc9eRoS6eqOVv3ukHTGkRos9VFLMRFW6VJCv3yAu 0zZ+Hk+WrNkFj0xTaf882+8ep0pPMSOR2Qz0OzlquDuEgm6myjF4HpQt1axcwMTKpOam qbzlVrU3zTh7ulH3hAvN+h3jrUNEBlucN/br0jsw8JPlo/dd1kJ4iSO+wzuSf1os9v4e rlFA== X-Forwarded-Encrypted: i=1; AJvYcCVxjeH9XwoM64kis5JEvey/7RTdt3v2f4pHD/v3J9vUrH+utGC+GGok4huMuA4kYxIdN2NV6w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzCnEsgj0ExvSCkhRL+RaU7pibESSGhDoA0gSF+NdD4r/50TFPP G5lhNMoX2rh3LaBTZSxXBuO6DSQ7Rqo1Cp++SW6511jRylGodJFO X-Gm-Gg: ASbGncuwWZhB49vGTNRdptCQUATv/GPVVG8z1RBoQx0DmbxP5uz3qzY5FaX5vtKNi2Z W4sPGZEvpRNCB41Tg1oqNcDavA4Zjmsc93gPxXRHNVlGD/RExts+/pGcFQ5KlJYTLTlDI+c/gPu 42F2M2XRXL0uB4yil29aeZbsmZUGOVuwVDe0BXhQeeaJfpr6Gt9tgfdVD1qkGpto3qZG/Ol1SQT apMlMwZ/D+ItC2jNBTSvOkyAO/LxH7Hcw7FOENQ6aTeggGsQzumsx7vW1pZE+Z8oj5IAtvZMJTk bsw9mC9h X-Google-Smtp-Source: AGHT+IF4E+RPcn20WDUlLd2/oQg++spVk+EDXquUnDWk+7g5V6zCmdOpR4DT/729azSnMtKS+/SSRQ== X-Received: by 2002:a4a:e911:0:b0:603:f9b2:e2e9 with SMTP id 006d021491bc7-606005e0351mr2842231eaf.7.1745034396602; Fri, 18 Apr 2025 20:46:36 -0700 (PDT) Received: from fedora ([2806:10ae:e:7566::1]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-605ff5ec0a2sm621869eaf.11.2025.04.18.20.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 20:46:36 -0700 (PDT) From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= In-Reply-To: <87ecxpm1xs.fsf@melete.silentflame.com> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> Date: Fri, 18 Apr 2025 21:46:34 -0600 Message-ID: <87ecxog6ed.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Sean Whitton writes: >>> In other modes, block comments might be the most common form of comment, >>> however. >> >> AFAIK "the most common form of comment" is what `comment-start/end` >> is for. >> >> >> Stefan "who still doesn't know what block-comment-start/end is for" > > I'm not sure either. Maybe we should back out Elijah's change and > implement the actual user functionality he wants (the new minor mode) in > some other way? In that case, I've written a patch for that: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Revert-block-comments-settings-and-use-a-different-v.patch >From 38d5b5db88651bbfcb443e207ea83b9414f3598d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Fri, 18 Apr 2025 21:27:29 -0600 Subject: [PATCH] ; Revert block comments settings and use a different variable. --- lisp/electric.el | 24 ++++++++++++++---------- lisp/emacs-lisp/lisp-mode.el | 3 +-- lisp/newcomment.el | 9 ++++----- lisp/nxml/nxml-mode.el | 3 +-- lisp/progmodes/c-ts-common.el | 6 ++---- lisp/progmodes/go-ts-mode.el | 3 +-- lisp/progmodes/js.el | 3 +-- lisp/progmodes/json-ts-mode.el | 3 +-- lisp/progmodes/lua-ts-mode.el | 3 +-- lisp/progmodes/opascal.el | 3 +-- lisp/progmodes/pascal.el | 3 +-- lisp/progmodes/typescript-ts-mode.el | 3 +-- lisp/textmodes/css-mode.el | 5 +---- lisp/textmodes/sgml-mode.el | 3 +-- 14 files changed, 31 insertions(+), 43 deletions(-) diff --git a/lisp/electric.el b/lisp/electric.el index da5fa973757..c8c1756b5be 100644 --- a/lisp/electric.el +++ b/lisp/electric.el @@ -733,31 +733,35 @@ electric-quote-local-mode ;;; Electric comment block +(defvar-local electric-block-comments nil + "List which contains block comment to insert `electric-block-comment-mode'. +Must be in the form: + (START . END) +Where START and END are respectively block comment start and end.") + (defun electric-block-comment-post-self-insert-function () "Function that `electric-block-comment' adds to `post-self-insert-hook'. -This closes block comment with `block-comment-end' when `block-comment-start' -is typed." - (when (and block-comment-start block-comment-end - ;; Check if we are exactly behind a `block-comment-start' +This closes block comments according to `electric-block-comments'." + (when (and ;; Check if we are exactly behind the block comment start (save-excursion (save-match-data - (re-search-backward (regexp-quote block-comment-start) - (- (point) (length block-comment-start)) + (re-search-backward (regexp-quote (car electric-block-comments)) + (- (point) (length (car electric-block-comments))) t))) ;; And if there is not anything front us (looking-at-p (concat "[^[:space:]]"))) (insert " ") (save-excursion - (insert (concat " " block-comment-end))))) + (insert (concat " " (cdr electric-block-comments)))))) (define-minor-mode electric-block-comment-mode "Toggle automatic closing of block comments (Electric Block Comment mode). -When enabled, typing `block-comment-start' closes it inserting their -corresponding `block-comment-end'." +When enabled, typing the beginning of a block comment closes it inserting their +corresponding block comment end." :group 'electricity :version "31.1" - (if electric-block-comment-mode + (if (and electric-block-comment-mode (consp electric-block-comments)) (add-hook 'post-self-insert-hook #'electric-block-comment-post-self-insert-function 10 t) (remove-hook 'post-self-insert-hook diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index f27baae1b36..4c856338a64 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -828,8 +828,7 @@ lisp-mode "\\(\\(^\\|[^\\\n]\\)\\(\\\\\\\\\\)*\\)\\(;+\\|#|\\) *") (setq-local comment-end-skip "[ \t]*\\(\\s>\\||#\\)") (setq-local font-lock-comment-end-skip "|#") - (setq-local block-comment-start "#|") - (setq-local block-comment-end "|#") + (setq-local electric-block-comments '("#|" . "|#")) (setq imenu-case-fold-search t)) (defun lisp-find-tag-default () diff --git a/lisp/newcomment.el b/lisp/newcomment.el index eb36f91104d..945187e863f 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -56,6 +56,7 @@ ;; - spill auto-fill of comments onto the end of the next line. ;; - uncomment-region with a consp (for blocks) or somehow make the ;; deletion of continuation markers less dangerous. +;; - drop block-comment- unless it's really used. ;; - uncomment-region on a subpart of a comment. ;; - support gnu-style "multi-line with space in continue". ;; - somehow allow comment-dwim to use the region even if transient-mark-mode @@ -182,11 +183,9 @@ uncomment-region-function Applicable at least in modes for languages like fixed-format Fortran where comments always start in column zero.") -(defvar block-comment-start nil - "String to insert to start a new block comment, or nil if no supported.") - -(defvar block-comment-end nil - "String to insert to end a new block comment, or nil if no supported.") +;; ?? never set +(defvar block-comment-start nil) +(defvar block-comment-end nil) (defvar comment-quote-nested t "Non-nil if nested comments should be quoted. diff --git a/lisp/nxml/nxml-mode.el b/lisp/nxml/nxml-mode.el index 994b2779d1a..66a1e82ec27 100644 --- a/lisp/nxml/nxml-mode.el +++ b/lisp/nxml/nxml-mode.el @@ -529,8 +529,7 @@ nxml-mode (setq-local comment-start-skip "") (setq-local comment-end-skip "[ \t\r\n]*-->") - (setq-local block-comment-start "") + (setq-local electric-block-comments '("")) (setq-local comment-line-break-function #'nxml-newline-and-indent) (setq-local comment-quote-nested-function #'nxml-comment-quote-nested) (setq-local comment-continue "") ; avoid double-hyphens as a padding diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el index 56c8ae49000..409277696a7 100644 --- a/lisp/progmodes/c-ts-common.el +++ b/lisp/progmodes/c-ts-common.el @@ -282,8 +282,7 @@ c-ts-common-comment-setup - `comment-end' - `comment-start-skip' - `comment-end-skip' - - `block-comment-start' - - `block-comment-end' + - `electric-block-comments' - `adaptive-fill-mode' - `adaptive-fill-first-line-regexp' - `paragraph-start' @@ -300,8 +299,7 @@ c-ts-common-comment-setup (rx (* (syntax whitespace)) (group (or (syntax comment-end) (seq (+ "*") "/"))))) - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) (setq-local adaptive-fill-mode t) (setq-local adaptive-fill-function #'c-ts-common--adaptive-fill-prefix) ;; Always accept * or | as prefix, even if there's only one line in diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el index e1736fe9208..17c7b19f3be 100644 --- a/lisp/progmodes/go-ts-mode.el +++ b/lisp/progmodes/go-ts-mode.el @@ -692,8 +692,7 @@ go-work-ts-mode (setq-local comment-start "// ") (setq-local comment-end "") (setq-local comment-start-skip (rx "//" (* (syntax whitespace)))) - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) ;; Indent. (setq-local indent-tabs-mode t diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 243329de7ae..2a19be0df56 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3781,8 +3781,7 @@ js--mode-setup (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) (setq-local fill-paragraph-function #'js-fill-paragraph) (setq-local normal-auto-fill-function #'js-do-auto-fill) diff --git a/lisp/progmodes/json-ts-mode.el b/lisp/progmodes/json-ts-mode.el index 9d374119810..a5d0c6ce8ba 100644 --- a/lisp/progmodes/json-ts-mode.el +++ b/lisp/progmodes/json-ts-mode.el @@ -142,8 +142,7 @@ json-ts-mode (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) ;; Electric (setq-local electric-indent-chars diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index dc129277778..553072e72f2 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -673,8 +673,7 @@ lua-ts-mode (setq-local comment-start "--") (setq-local comment-start-skip "--\\s-*") (setq-local comment-end "") - (setq-local block-comment-start "--[[" ) - (setq-local block-comment-end "]]") + (setq-local electric-block-comments '("--[[" . "]]")) ;; Font-lock. (setq-local treesit-font-lock-settings lua-ts--font-lock-settings) diff --git a/lisp/progmodes/opascal.el b/lisp/progmodes/opascal.el index 9dcaff9645e..08458afa29c 100644 --- a/lisp/progmodes/opascal.el +++ b/lisp/progmodes/opascal.el @@ -1768,8 +1768,7 @@ opascal-mode (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://\\|(\\*\\|{\\)[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*)\\|}\\)") - (setq-local block-comment-start "(*") - (setq-local block-comment-end "*)")) + (setq-local electric-block-comments '("(*" . "*)"))) (provide 'opascal) ;;; opascal.el ends here diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index 113cf68c8d6..901e2e0cc47 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -348,8 +348,7 @@ pascal-mode (setq-local comment-start "{") (setq-local comment-start-skip "(\\*+ *\\|{ *") (setq-local comment-end "}") - (setq-local block-comment-start "(*") - (setq-local block-comment-end "*)") + (setq-local electric-block-comments '("(*" . "*)")) (add-hook 'completion-at-point-functions 'pascal-completions-at-point nil t) ;; Font lock support (setq-local font-lock-defaults '(pascal-font-lock-keywords nil t)) diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el index a2049ba2d64..476fb952131 100644 --- a/lisp/progmodes/typescript-ts-mode.el +++ b/lisp/progmodes/typescript-ts-mode.el @@ -665,8 +665,7 @@ tsx-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) (seq "/" (+ "*"))) (* (syntax whitespace)))) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e3f295c3412..2cfe199da38 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1858,8 +1858,7 @@ css-base-mode (setq-local comment-start-skip "/\\*+[ \t]*") (setq-local comment-end "*/") (setq-local comment-end-skip "[ \t]*\\*+/") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") + (setq-local electric-block-comments '("/*" . "*/")) (setq-local electric-indent-chars (append css-electric-keys electric-indent-chars)) ;; The default "." creates ambiguity with class selectors. @@ -2083,8 +2082,6 @@ scss-mode "Major mode to edit \"Sassy CSS\" files." (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local comment-continue " *") (setq-local comment-start-skip "/[*/]+[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)") diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el index 4dbc6839c68..f4737e28afa 100644 --- a/lisp/textmodes/sgml-mode.el +++ b/lisp/textmodes/sgml-mode.el @@ -622,8 +622,7 @@ sgml-mode (setq-local indent-line-function #'sgml-indent-line) (setq-local comment-start "") - (setq-local block-comment-start "") + (setq-local electric-block-comments '("")) (setq-local comment-indent-function #'sgml-comment-indent) (setq-local comment-line-break-function #'sgml-comment-indent-new-line) (setq-local skeleton-further-elements '((completion-ignore-case t))) -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Apr 2025 04:42:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Sean Whitton Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17450376807232 (code B ref 77823); Sat, 19 Apr 2025 04:42:06 +0000 Received: (at 77823) by debbugs.gnu.org; 19 Apr 2025 04:41:20 +0000 Received: from localhost ([127.0.0.1]:55207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6012-0001sR-1k for submit@debbugs.gnu.org; Sat, 19 Apr 2025 00:41:20 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3696) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u600w-0001ru-7i for 77823@debbugs.gnu.org; Sat, 19 Apr 2025 00:41:17 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CF9C710006B; Sat, 19 Apr 2025 00:41:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745037663; bh=pbWmB6YSAJ4GJpv/rUcXSFA48JJgU4rL9tUnqxuWraY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HgfRwymKHXLv+yzSK+jsxaEqrWQCKv+YaTxYMAYC6g0JWJi/7zXqKDNUTkTkJA7vB 0kRwOzfKb8IJljQ+6uLhUq8DKkrAOWnW62TwEjaF6yU+qNYmIKeRZZmZ96BfYG/Cvv tESYnfcKIneJbhsRL6Tqi6EHdm0yvWuvxpwSWQNxQDK0Gukk2WjC8BDKzhafI67DII jj4i0BrZs83UdrDxnBTUp7gbvhP6pdLYqTELH7mKuvn6O6UcyESBDjJKYDWrBbL4vM yfy0NSns891FFI28ZlYG/JMls6oq5T9M1IB1+GqWnfloAAx9MAyIr6dTaA7+YOFfqJ GS+l0QkBjGUCA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C60C2100027; Sat, 19 Apr 2025 00:41:03 -0400 (EDT) Received: from pastel (unknown [104.195.239.180]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7BD6D1201F3; Sat, 19 Apr 2025 00:41:03 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87ecxog6ed.fsf@gmail.com> Message-ID: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> Date: Sat, 19 Apr 2025 00:41:01 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > lisp/electric.el | 24 ++++++++++++++---------- > lisp/emacs-lisp/lisp-mode.el | 3 +-- > lisp/newcomment.el | 9 ++++----- > lisp/nxml/nxml-mode.el | 3 +-- > lisp/progmodes/c-ts-common.el | 6 ++---- > lisp/progmodes/go-ts-mode.el | 3 +-- > lisp/progmodes/js.el | 3 +-- > lisp/progmodes/json-ts-mode.el | 3 +-- > lisp/progmodes/lua-ts-mode.el | 3 +-- > lisp/progmodes/opascal.el | 3 +-- > lisp/progmodes/pascal.el | 3 +-- > lisp/progmodes/typescript-ts-mode.el | 3 +-- > lisp/textmodes/css-mode.el | 5 +---- > lisp/textmodes/sgml-mode.el | 3 +-- > 14 files changed, 31 insertions(+), 43 deletions(-) IIRC, the recent changes also added setting to `block-comment-start/end` in CC-modes, so there may need to be more reversals. > (define-minor-mode electric-block-comment-mode > "Toggle automatic closing of block comments (Electric Block Comment mode). > > +When enabled, typing the beginning of a block comment closes it inserting their > +corresponding block comment end." So, IIUC what is meant by "block comment" here is a comment that's not closed by the next EOL but by some other sequence of characters. Interesting cases to consider: - In SNMP mode, IIRC, comments take the shape of -- a comment -- so you have to check `syntax-ppss` to figure out if the `--` that was just inserted was a comment starter or ender. - In OPascal mode there is more than one kind of "block comment": { a comment } (* another comment *) /* yet another comment */ so your `electric-block-comments` should probably support not just a single pair but a list of pairs. - It might make sense to extend this to related constructs and/or to merge it into `electric-pair-mode`. By related constructs, I'm thinking of things like [OCaml's quotations](https://caml.inria.fr/pub/docs/tutorial-camlp4/tutorial004.html) that take the form `<:FOO<...>>` or [OCaml's quoted strings](https://ocaml.org/manual/5.2/lex.html#quoted-string-id) that look like `{FOO|...|FOO}`. Stefan From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Apr 2025 10:03:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174505696929403 (code B ref 77823); Sat, 19 Apr 2025 10:03:04 +0000 Received: (at 77823) by debbugs.gnu.org; 19 Apr 2025 10:02:49 +0000 Received: from localhost ([127.0.0.1]:58317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6526-0007dm-CQ for submit@debbugs.gnu.org; Sat, 19 Apr 2025 06:02:48 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:49556) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6521-0007c5-Ow for 77823@debbugs.gnu.org; Sat, 19 Apr 2025 06:02:43 -0400 DKIM-Signature: a=rsa-sha256; b=ACmTku5K//VI+cUjBXbNaxWszS8mhgSRh14SbXKmsFsdRyq2lFWUdE0qraHazjvKXtCuWgxzGtzH/JCFYXdP1ZnCJPsesLN7hTyBbQ4KZ7SRNFeIlg7D4L+8C/ihwPKMgcs/Z4POYQiAYhWVxjDxQDQ3iOGGGu8nB3NHQnxdST2Efu7/UyDappQEFKGG6ex9XnPv+XKirWHy1vK8ToKHibMhmtgfZIOpi23fCc0HEa8anclY14RcFnOzS2um7tWOlV38tWJ4MQ+Q/B4vysb0qCZg4TfG8b5PEwfHNLl/pZUtreKND91+fl8y84V9e42u5zpiHL409tF6KRvxpqLWbw==; s=purelymail3; d=spwhitton.name; v=1; bh=M1juAE+N+8s48tH5rxYvNfrXObRCNNk8AKjSd4dXUGA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=E4xY2THzoJ4WWjA06JgazzHmCa59OfE11S1+PX6EgPkPyHPe0EyHDa69H/MbuGb8gKuN+jkiQ/TREcVzTtFR4SATbZeKpqR7Hc8slsjhsr6qkYH7eFFeXOPSDzn2w3PsyAAK6thYTBPyT1pX/WjuSM84qPu85MLryitkeRnIdXsOKqTJ8NX/GHol8hS3kVUKemLqjeqBwluFlQ/BacuA4YJ7bGaTAnV+Cg+aPvBRqjNnpZgydjTcpovmMTjYNXDTgWzaT3gphOGy9CDrHsnPguge+DOUk8nXQzALcZjPmxZfZGobdxHkeVVMpl38byfS/EGZffFGgJMLvn3W447LkQ==; s=purelymail3; d=purelymail.com; v=1; bh=M1juAE+N+8s48tH5rxYvNfrXObRCNNk8AKjSd4dXUGA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1653244833; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 19 Apr 2025 10:02:33 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7E4037F28D4; Sat, 19 Apr 2025 18:02:29 +0800 (CST) From: Sean Whitton In-Reply-To: <87ecxog6ed.fsf@gmail.com> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> Date: Sat, 19 Apr 2025 18:02:29 +0800 Message-ID: <87tt6kjwp6.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Elijah, Thank you very much for working on a revised approach. Would it be possible for you to separate this two diffs? One patch reverting the previously installed changes, and a patch with the new approach. We don't have to actually install them as two separate git commits, but given that Stefan and I didn't review the original change, it would probably make things much more approachable for us to see these separated. -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 05:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77823@debbugs.gnu.org Cc: eliz@gnu.org, monnier@iro.umontreal.ca, spwhitton@spwhitton.name X-Debbugs-Original-To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Stefan Monnier , Sean Whitton Received: via spool by submit@debbugs.gnu.org id=B.174512592112410 (code B ref -1); Sun, 20 Apr 2025 05:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Apr 2025 05:12:01 +0000 Received: from localhost ([127.0.0.1]:43057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6MyG-0003E3-Fi for submit@debbugs.gnu.org; Sun, 20 Apr 2025 01:12:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36410) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6My8-0003DF-Hi for submit@debbugs.gnu.org; Sun, 20 Apr 2025 01:11:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u6My1-0001Bo-ID for bug-gnu-emacs@gnu.org; Sun, 20 Apr 2025 01:11:45 -0400 Received: from mail-oa1-x41.google.com ([2001:4860:4864:20::41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u6Mxz-0000kl-Kt; Sun, 20 Apr 2025 01:11:45 -0400 Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-2d071fcd89bso741061fac.3; Sat, 19 Apr 2025 22:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745125901; x=1745730701; darn=gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wk+TfXGU2Q+BT+GflJy7Xhwq3o5r6kW/lxx7imu9TtQ=; b=bzQ4pk9eze+EYqGISSn/sunYjEZoZxTHQWuh5wiT0Tgg31+arCMCaSDH5X3LEOFZYh 8u0uUfl996DlE+6PCd5klOiPORUyE2hCRCCe+ATVwyFpdLVBZ4QjVCZ7PlmnX1APQBe1 xEVFVm5j5xCR7VN637ifyiQa5ZXz43KUTaJqFlir3HwEWZr/xgp9aICz8ALl+ptgKLeo vmdML1stQh62M1oirwd3KFd6rPbE1HsFW/D+BGJSEsR/AnM7ywOoKfns7zOJZ0vF2C9F fuSB9RKZQH7jaqunbaMKU16SMTDV6eUVjwfrhM10O4chz77JUDLzQ0My/9BT8TkX0X4d WDMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745125901; x=1745730701; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wk+TfXGU2Q+BT+GflJy7Xhwq3o5r6kW/lxx7imu9TtQ=; b=Ofv35wwFtT53okA9fgfu0NbhvQKLbyHIWJH+cB7AJgx6h2i7Fb26bIWbk5CxoDFICk QhOZD0vX5L3B2bnA0rbi6QKERxhKi5uo9s3s8wgrLQB2Lj5b5biORicvcqDbmgQ/0nIY /00DdroFfSpOVEL9wCFhfSS7YyQ5eOGTJvmR4xQjYyr4Lpc02FUgGdl+OKOQfHqJvhij eNM68ilJu2JBB1x446wNl0g9QwraVfRBvvvaJXW/hfTKEJDwdn5Mh4xghd+s6oLFStDM B1TEwB3gF9OoORg6287uCxugSWBi3dA7B9XAph1jQQ7tQqCVkUT+oGotU/3E9oEoTgsf xi0w== X-Forwarded-Encrypted: i=1; AJvYcCWysaAW7D9OTnKyDreP1kovg8GzfRLo4b5z6zpdqMQO4q+Dzq3QvXeqAmeot5DrgO9h09fU@gnu.org X-Gm-Message-State: AOJu0Yzk6aFAXE8MsxU7e6HB/5xHUTm6ZX8+Ah3AlOhA79yRffonPhrz 01yk+f69/ODlKumNBDKsPWFb3eQ7xftycBQAJUQF/qkG5Vl55i3v X-Gm-Gg: ASbGncvbdUb3bpq5X8agPhELUAmPxkF3DaTZ7E5d+uX3RdwefWJHFypYs6wvsHR2KD4 kZBGTDug5GXjaKP5KvN52BUGtJb7ZaQgn7B+nrDQcK0fKEGH3RhdaH9ZDB28XvCiDNoimmv5ba6 CmpokGRA2QmSU81YbgRiylSOmL+t6cTA8X69yDrSXfMGQqOwdC2Xm37ST6DX+TzCZH36XTGsNgU tl4NUSA6oN5ruQUBAyh1RbCHqI/76RUthi4tD0TOnOKuZsPcSHRKUYk0IIM85asAYskiSYGwad0 VvLm2IH09NJHA3i2a8o= X-Google-Smtp-Source: AGHT+IFm/FEte1t4d/RIb2NG4dV1GWusr8HD3Qv+NdLxUQEBzxcrK2hWUlrQ/A7zd8jn2axCv3gmUg== X-Received: by 2002:a05:6820:2226:b0:603:f903:c85a with SMTP id 006d021491bc7-606005462acmr4058886eaf.4.1745125900717; Sat, 19 Apr 2025 22:11:40 -0700 (PDT) Received: from fedora ([2806:10ae:e:b268::1]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-605ff5ee0fasm1035801eaf.15.2025.04.19.22.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Apr 2025 22:11:40 -0700 (PDT) From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> Date: Sat, 19 Apr 2025 23:11:38 -0600 Message-ID: <87ecxne7sl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:4860:4864:20::41; envelope-from=eg642616@gmail.com; helo=mail-oa1-x41.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> lisp/electric.el | 24 ++++++++++++++ >> lisp/emacs-lisp/lisp-mode.el | 3 +-- >> lisp/newcomment.el | 9 ++++----- >> lisp/nxml/nxml-mode.el | 3 +-- >> lisp/progmodes/c-ts-common.el | 6 ++- [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eg642616[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (eg642616[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: >> lisp/electric.el | 24 ++++++++++++++---------- >> lisp/emacs-lisp/lisp-mode.el | 3 +-- >> lisp/newcomment.el | 9 ++++----- >> lisp/nxml/nxml-mode.el | 3 +-- >> lisp/progmodes/c-ts-common.el | 6 ++---- >> lisp/progmodes/go-ts-mode.el | 3 +-- >> lisp/progmodes/js.el | 3 +-- >> lisp/progmodes/json-ts-mode.el | 3 +-- >> lisp/progmodes/lua-ts-mode.el | 3 +-- >> lisp/progmodes/opascal.el | 3 +-- >> lisp/progmodes/pascal.el | 3 +-- >> lisp/progmodes/typescript-ts-mode.el | 3 +-- >> lisp/textmodes/css-mode.el | 5 +---- >> lisp/textmodes/sgml-mode.el | 3 +-- >> 14 files changed, 31 insertions(+), 43 deletions(-) > > IIRC, the recent changes also added setting to > `block-comment-start/end` in CC-modes, so there may need to be more reversals. Oops, i forgot it. >> (define-minor-mode electric-block-comment-mode >> "Toggle automatic closing of block comments (Electric Block Comment mode). >> >> +When enabled, typing the beginning of a block comment closes it inserting their >> +corresponding block comment end." > > So, IIUC what is meant by "block comment" here is a comment that's not > closed by the next EOL but by some other sequence of characters. > > Interesting cases to consider: > > - In SNMP mode, IIRC, comments take the shape of > > -- a comment -- > > so you have to check `syntax-ppss` to figure out if the `--` that was > just inserted was a comment starter or ender. I didn't know that were possible. > - In OPascal mode there is more than one kind of "block > comment": > > { a comment } > (* another comment *) > /* yet another comment */ > > so your `electric-block-comments` should probably support not just > a single pair but a list of pairs. Yeah, i realized when i made the changes. > - It might make sense to extend this to related constructs and/or to > merge it into `electric-pair-mode`. I originally planned to merge it with electric-pair, but electric-pair is something complex for this little feature (and also electric-pair uses characters, not strings), so I decided to make it standalone. > By related constructs, I'm thinking of things like [OCaml's > quotations](https://caml.inria.fr/pub/docs/tutorial-camlp4/tutorial004.html) > that take the form `<:FOO<...>>` or [OCaml's quoted > strings](https://ocaml.org/manual/5.2/lex.html#quoted-string-id) > that look like `{FOO|...|FOO}`. It looks outside the purpose of this minor mode, but I have nothing against implementing it, it can handle it. Honestly, if that were the case, I don't know what name to give this mode. -- - E.G via GNU Emacs and Org. From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 13:24:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Sean Whitton Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174515540127557 (code B ref 77823); Sun, 20 Apr 2025 13:24:04 +0000 Received: (at 77823) by debbugs.gnu.org; 20 Apr 2025 13:23:21 +0000 Received: from localhost ([127.0.0.1]:47586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6Udg-00079q-0g for submit@debbugs.gnu.org; Sun, 20 Apr 2025 09:23:19 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62411) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6UdO-00076f-Mc for 77823@debbugs.gnu.org; Sun, 20 Apr 2025 09:23:09 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0E337100034; Sun, 20 Apr 2025 09:22:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745155368; bh=8s6XxEA8a626G6URWLHF3El959530g6M9lUa6ygPVec=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IVeoWzrDYroiIgvwHrj/U3BDoaKJiaJIstCvGExnhIFhO2ql208QOovw1kWXu+549 5FWkyP8orq1LCoYiQnfCUxwDrr2G0AGT23Xy3JxQSqdk2M9mi84Z1CQm5Ec4EUSJNd oaPPxQVEmEzJF+RoI+XPZUTmW85A4OnOY1Ai2+6p8clVcDAxtMx2cOyYwg1V9SLGq8 oI+MIDwV94wWvg7CH/xkZIr2tO9wveHp0r+6XnRwxcuaUrxZuRvaSm2Kk1a8uBvKFF nBIJkoDMDeSCFgjij6pwf4K+ZvE31saoDvv1S8zYqNpC0CqFvUHgJ8kIfvCXlTKKxr IkQR5nj3cKK7w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B82B8100027; Sun, 20 Apr 2025 09:22:48 -0400 (EDT) Received: from pastel (104-195-239-180.cpe.teksavvy.com [104.195.239.180]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8425A1202F4; Sun, 20 Apr 2025 09:22:48 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87ecxne7sl.fsf@gmail.com> Message-ID: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> Date: Sun, 20 Apr 2025 09:22:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> - It might make sense to extend this to related constructs and/or to >> merge it into `electric-pair-mode`. > > I originally planned to merge it with electric-pair, but electric-pair > is something complex for this little feature (and also electric-pair > uses characters, not strings), so I decided to make it standalone. I understand it's a non-trivial change, but extending support for multi-character delimiters would be nice. This could cover things like ``...'' in LaTeX. >> By related constructs, I'm thinking of things like [OCaml's >> quotations](https://caml.inria.fr/pub/docs/tutorial-camlp4/tutorial004= .html) >> that take the form `<:FOO<...>>` or [OCaml's quoted >> strings](https://ocaml.org/manual/5.2/lex.html#quoted-string-id) >> that look like `{FOO|...|FOO}`. > > It looks outside the purpose of this minor mode, but I have nothing > against implementing it, it can handle it. Honestly, if that were the > case, I don't know what name to give this mode. `electric-multichar-pair-mode`? =F0=9F=99=82 Stefan From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Apr 2025 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier , Sean Whitton Cc: eliz@gnu.org, 77823@debbugs.gnu.org Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174518162417407 (code B ref 77823); Sun, 20 Apr 2025 20:41:02 +0000 Received: (at 77823) by debbugs.gnu.org; 20 Apr 2025 20:40:24 +0000 Received: from localhost ([127.0.0.1]:54225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6bSe-0004WG-89 for submit@debbugs.gnu.org; Sun, 20 Apr 2025 16:40:23 -0400 Received: from mail-oa1-x41.google.com ([2001:4860:4864:20::41]:44204) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u6bSZ-0004Uu-A5 for 77823@debbugs.gnu.org; Sun, 20 Apr 2025 16:40:18 -0400 Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-2b8e2606a58so1961758fac.0 for <77823@debbugs.gnu.org>; Sun, 20 Apr 2025 13:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745181608; x=1745786408; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IQPGADLZ/SlZ/HinZOIK7F8vqsgIaqMFm4BTkP8XbS4=; b=h1Gi4KYC8Je1rnwhlQNJYvIGvmBF1x7mGKX6FhqlYH+ejz7ej+hUpgRHC4yxWaX+sB wyoNf/SpqPxPz8LTiGycEadXdyZnekVVfH+OYkyhW6qxVqxjzZ8GiUj9WPow6jkixj1G qpz3KGrGW7eUpyf/vjpcUT/AdeAvCgAc5TivDd5v3RjWjM5g2ia3t+qz8bSNdQnmDyfY 09i5HVRUa8OVz7DlKNd4vNA8h78Ji0HJpRf7NYZdfVxrYiygSrBssK3GHKmGsM3t7P1Y qe3/1Z7mytP1tSFPq0YvfcBD/zsbYxJKgmYbEvFw9draVO7HBZAHbQTv8WX4bb/iEfeI 3w8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745181608; x=1745786408; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IQPGADLZ/SlZ/HinZOIK7F8vqsgIaqMFm4BTkP8XbS4=; b=Pw7Oz6iOiyrG8GHHtiqLZDGGWYiJX07pckLiowRJpP62Joy0gDgRfyLUE0/T5QAnSc MSIWiOBSjdQ/4wVzqrp9+BWOdYxFu5t1tx/0AXpEH4ajxnrM5JsqbGpWsGYlMGlwEXJL MugoiqmrHxNLnD4Ns4xZezYL+mNubfOARVfNtnJ5LqTQq7yjRhx3fBnFPSOp2rL4O/K+ q03CMjNN+2gs40eCxmTHabSSpYCrGuFmZybgc1dwrx8LY8TFRt1pB+3P1QKiVLIMazBg wY2DxOgK9WVgakzxOkpmRH0T3JVFRCJ7e7E7YVPSMfsERX4ag+gmSD/kzFwmebA2bwvF kmLw== X-Forwarded-Encrypted: i=1; AJvYcCVBouGYgjXXlHh9k6YCl8vUf/+fJV/iWhC8gbXnTcyRxXErG5fEg4vXUVt55aIGxe+KT2hdiw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yzxd/uzIGVuTAVN4x+atQ6KuJaWIv0+DlhxvRECSZjDjg9nZaVx skUJ1zn9Icawcy/dMrxZ1cBxebvqmsr2WHjqZXW8CjFYtlC/BEDh4PhuDqsB X-Gm-Gg: ASbGncsv3Fkr+7x/+siSiGGXzIu56n9/jv7vAPx/qmyYBixlP1mqhgRfGU/ZcbnEcr5 zLGtjWNWfcg88aOJKckHFvneKcOkyssl9XsEK5E7z7fTexYT07bT6AOnX20zESfMGjTjfgIxE55 ymuSYxjAW8MPyKjxgWC77vriHzAViiHcXy3I7+4hGysA1DXYw1wMS3YOTwGwlBCedJbJYpaKCrp 8DfqKopJwqbsws78ItsCeqojUefyjvc5mzSQgxEBY2Uj5cFgMgm6Sj0AkcPmJkXfhCxYH/9iXgN 4BG7Dzcw X-Google-Smtp-Source: AGHT+IGNJk3Aw2dtvosLDQTB3pWmCDrkRG1HuzxSy0IQWuzrvyiDqdDHAEIfF/qBrjdlotuZmvT3bQ== X-Received: by 2002:a05:6870:ab12:b0:2d4:d9d6:c8d7 with SMTP id 586e51a60fabf-2d526d6f95emr6209025fac.31.1745181608030; Sun, 20 Apr 2025 13:40:08 -0700 (PDT) Received: from fedora ([2806:10ae:e:b268::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2d52139cbb1sm1573870fac.20.2025.04.20.13.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 13:40:07 -0700 (PDT) From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> Date: Sun, 20 Apr 2025 14:40:05 -0600 Message-ID: <87fri2fty2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Fine, I'm sending here 2 patches: For revert the previous commits: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Revert-commits-74842b4cb2c-and-4c6b1712a4d.patch >From 43ffcb0c9f079e0916194c74b13c4b40b5706749 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Fri, 18 Apr 2025 21:27:29 -0600 Subject: [PATCH 1/2] Revert commits 74842b4cb2c and 4c6b1712a4d. --- lisp/emacs-lisp/lisp-mode.el | 2 -- lisp/newcomment.el | 9 ++++----- lisp/nxml/nxml-mode.el | 2 -- lisp/progmodes/c-ts-common.el | 4 ---- lisp/progmodes/cc-cmds.el | 1 - lisp/progmodes/cc-mode.el | 2 -- lisp/progmodes/go-ts-mode.el | 2 -- lisp/progmodes/js.el | 2 -- lisp/progmodes/json-ts-mode.el | 2 -- lisp/progmodes/lua-ts-mode.el | 2 -- lisp/progmodes/opascal.el | 4 +--- lisp/progmodes/pascal.el | 2 -- lisp/progmodes/typescript-ts-mode.el | 2 -- lisp/textmodes/css-mode.el | 4 ---- lisp/textmodes/sgml-mode.el | 2 -- 15 files changed, 5 insertions(+), 37 deletions(-) diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index f27baae1b36..006b713ae6e 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -828,8 +828,6 @@ lisp-mode "\\(\\(^\\|[^\\\n]\\)\\(\\\\\\\\\\)*\\)\\(;+\\|#|\\) *") (setq-local comment-end-skip "[ \t]*\\(\\s>\\||#\\)") (setq-local font-lock-comment-end-skip "|#") - (setq-local block-comment-start "#|") - (setq-local block-comment-end "|#") (setq imenu-case-fold-search t)) (defun lisp-find-tag-default () diff --git a/lisp/newcomment.el b/lisp/newcomment.el index eb36f91104d..945187e863f 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -56,6 +56,7 @@ ;; - spill auto-fill of comments onto the end of the next line. ;; - uncomment-region with a consp (for blocks) or somehow make the ;; deletion of continuation markers less dangerous. +;; - drop block-comment- unless it's really used. ;; - uncomment-region on a subpart of a comment. ;; - support gnu-style "multi-line with space in continue". ;; - somehow allow comment-dwim to use the region even if transient-mark-mode @@ -182,11 +183,9 @@ uncomment-region-function Applicable at least in modes for languages like fixed-format Fortran where comments always start in column zero.") -(defvar block-comment-start nil - "String to insert to start a new block comment, or nil if no supported.") - -(defvar block-comment-end nil - "String to insert to end a new block comment, or nil if no supported.") +;; ?? never set +(defvar block-comment-start nil) +(defvar block-comment-end nil) (defvar comment-quote-nested t "Non-nil if nested comments should be quoted. diff --git a/lisp/nxml/nxml-mode.el b/lisp/nxml/nxml-mode.el index 994b2779d1a..7acc19b9058 100644 --- a/lisp/nxml/nxml-mode.el +++ b/lisp/nxml/nxml-mode.el @@ -529,8 +529,6 @@ nxml-mode (setq-local comment-start-skip "") (setq-local comment-end-skip "[ \t\r\n]*-->") - (setq-local block-comment-start "") (setq-local comment-line-break-function #'nxml-newline-and-indent) (setq-local comment-quote-nested-function #'nxml-comment-quote-nested) (setq-local comment-continue "") ; avoid double-hyphens as a padding diff --git a/lisp/progmodes/c-ts-common.el b/lisp/progmodes/c-ts-common.el index 56c8ae49000..5f9d485538a 100644 --- a/lisp/progmodes/c-ts-common.el +++ b/lisp/progmodes/c-ts-common.el @@ -282,8 +282,6 @@ c-ts-common-comment-setup - `comment-end' - `comment-start-skip' - `comment-end-skip' - - `block-comment-start' - - `block-comment-end' - `adaptive-fill-mode' - `adaptive-fill-first-line-regexp' - `paragraph-start' @@ -300,8 +298,6 @@ c-ts-common-comment-setup (rx (* (syntax whitespace)) (group (or (syntax comment-end) (seq (+ "*") "/"))))) - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local adaptive-fill-mode t) (setq-local adaptive-fill-function #'c-ts-common--adaptive-fill-prefix) ;; Always accept * or | as prefix, even if there's only one line in diff --git a/lisp/progmodes/cc-cmds.el b/lisp/progmodes/cc-cmds.el index 06397d23321..9230faa56da 100644 --- a/lisp/progmodes/cc-cmds.el +++ b/lisp/progmodes/cc-cmds.el @@ -5015,7 +5015,6 @@ c-indent-new-comment-line (setq comment-start "/* " comment-end " */")) (unless (string-match "[ \t]*//" comment-start) (setq comment-start "// " comment-end ""))) - (setq block-comment-start "/*" block-comment-end "*/") (setq col (save-excursion (back-to-indentation) (current-column))) diff --git a/lisp/progmodes/cc-mode.el b/lisp/progmodes/cc-mode.el index fa3788ba383..efeb6c1005a 100644 --- a/lisp/progmodes/cc-mode.el +++ b/lisp/progmodes/cc-mode.el @@ -610,8 +610,6 @@ c-basic-common-init (make-local-variable 'comment-start) (make-local-variable 'comment-end) (make-local-variable 'comment-start-skip) - (make-local-variable 'block-comment-start) - (make-local-variable 'block-comment-end) (make-local-variable 'paragraph-start) (make-local-variable 'paragraph-separate) diff --git a/lisp/progmodes/go-ts-mode.el b/lisp/progmodes/go-ts-mode.el index e1736fe9208..8cabaa9f34d 100644 --- a/lisp/progmodes/go-ts-mode.el +++ b/lisp/progmodes/go-ts-mode.el @@ -692,8 +692,6 @@ go-work-ts-mode (setq-local comment-start "// ") (setq-local comment-end "") (setq-local comment-start-skip (rx "//" (* (syntax whitespace)))) - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") ;; Indent. (setq-local indent-tabs-mode t diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 243329de7ae..498ce955c44 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3781,8 +3781,6 @@ js--mode-setup (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local fill-paragraph-function #'js-fill-paragraph) (setq-local normal-auto-fill-function #'js-do-auto-fill) diff --git a/lisp/progmodes/json-ts-mode.el b/lisp/progmodes/json-ts-mode.el index 9d374119810..11ec5d5c079 100644 --- a/lisp/progmodes/json-ts-mode.el +++ b/lisp/progmodes/json-ts-mode.el @@ -142,8 +142,6 @@ json-ts-mode (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") ;; Electric (setq-local electric-indent-chars diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el index dc129277778..8c2ff2ae7e0 100644 --- a/lisp/progmodes/lua-ts-mode.el +++ b/lisp/progmodes/lua-ts-mode.el @@ -673,8 +673,6 @@ lua-ts-mode (setq-local comment-start "--") (setq-local comment-start-skip "--\\s-*") (setq-local comment-end "") - (setq-local block-comment-start "--[[" ) - (setq-local block-comment-end "]]") ;; Font-lock. (setq-local treesit-font-lock-settings lua-ts--font-lock-settings) diff --git a/lisp/progmodes/opascal.el b/lisp/progmodes/opascal.el index 9dcaff9645e..bd6bc3b28ac 100644 --- a/lisp/progmodes/opascal.el +++ b/lisp/progmodes/opascal.el @@ -1767,9 +1767,7 @@ opascal-mode (setq-local comment-start "// ") (setq-local comment-start-skip "\\(?://\\|(\\*\\|{\\)[ \t]*") - (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*)\\|}\\)") - (setq-local block-comment-start "(*") - (setq-local block-comment-end "*)")) + (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*)\\|}\\)")) (provide 'opascal) ;;; opascal.el ends here diff --git a/lisp/progmodes/pascal.el b/lisp/progmodes/pascal.el index 113cf68c8d6..b6316d4dfe1 100644 --- a/lisp/progmodes/pascal.el +++ b/lisp/progmodes/pascal.el @@ -348,8 +348,6 @@ pascal-mode (setq-local comment-start "{") (setq-local comment-start-skip "(\\*+ *\\|{ *") (setq-local comment-end "}") - (setq-local block-comment-start "(*") - (setq-local block-comment-end "*)") (add-hook 'completion-at-point-functions 'pascal-completions-at-point nil t) ;; Font lock support (setq-local font-lock-defaults '(pascal-font-lock-keywords nil t)) diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el index a2049ba2d64..e914dabfd16 100644 --- a/lisp/progmodes/typescript-ts-mode.el +++ b/lisp/progmodes/typescript-ts-mode.el @@ -665,8 +665,6 @@ tsx-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) (seq "/" (+ "*"))) (* (syntax whitespace)))) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e3f295c3412..b48c98efa02 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1858,8 +1858,6 @@ css-base-mode (setq-local comment-start-skip "/\\*+[ \t]*") (setq-local comment-end "*/") (setq-local comment-end-skip "[ \t]*\\*+/") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local electric-indent-chars (append css-electric-keys electric-indent-chars)) ;; The default "." creates ambiguity with class selectors. @@ -2083,8 +2081,6 @@ scss-mode "Major mode to edit \"Sassy CSS\" files." (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local block-comment-start "/*") - (setq-local block-comment-end "*/") (setq-local comment-continue " *") (setq-local comment-start-skip "/[*/]+[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)") diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el index 4dbc6839c68..2accd31bc36 100644 --- a/lisp/textmodes/sgml-mode.el +++ b/lisp/textmodes/sgml-mode.el @@ -622,8 +622,6 @@ sgml-mode (setq-local indent-line-function #'sgml-indent-line) (setq-local comment-start "") - (setq-local block-comment-start "") (setq-local comment-indent-function #'sgml-comment-indent) (setq-local comment-line-break-function #'sgml-comment-indent-new-line) (setq-local skeleton-further-elements '((completion-ignore-case t))) -- 2.49.0 --=-=-= Content-Type: text/plain And the new feature implementation: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Change-electric-block-comment-mode-to-electric-multi.patch >From 5305a92c89ce37d44ac01dd273933418a43dd92f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sat, 19 Apr 2025 23:17:45 -0600 Subject: [PATCH] Change electric-block-comment-mode to electric-multichar-pair-mode. * etc/NEWS: Change `electric-block-comment-mode' entry to `electric-multichar-pair-mode'. * lisp/electric.el (electric-block-comment-post-self-insert-function) (electric-block-comment-mode): Move and rename code... * lisp/elec-pair.el (electric-multichar-pair-post-self-insert-function) (electric-multichar-pair-mode): ... To this. (electric-multichar-pairs): New buffer-local variable. --- etc/NEWS | 11 +++-------- lisp/elec-pair.el | 44 ++++++++++++++++++++++++++++++++++++++++++++ lisp/electric.el | 32 -------------------------------- 3 files changed, 47 insertions(+), 40 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 98f8e703013..53c68cb9045 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1959,14 +1959,9 @@ A major mode based on the tree-sitter library for editing "go.work" files. If tree-sitter is properly set-up by the user, it can be enabled for files named "go.work". -** New minor mode 'electric-block-comment-mode'. -This mode automatically closes block comments. Typing the value of -'block-comment-start' closes it inserting the corresponding -'block-comment-end'. Thus, allows closing block comments for major -modes that support it, such as: 'c-mode', 'c++-mode', 'java-mode', -'js-mode', 'css-mode', and derived: 'html-mode', 'mhtml-mode', -'xml-mode' and 'nxml-mode', 'pascal-mode', 'lua-ts-mode', 'lisp-mode' -and 'common-lisp-mode'. +** New minor mode 'electric-multichar-pair-mode'. +This minor mode provides automatic pairing for multi-character pairs. +The pairs are defined via the variable `electric-multichar-pairs'. * Incompatible Lisp Changes in Emacs 31.1 diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el index aa2577300fd..db25a9ddb23 100644 --- a/lisp/elec-pair.el +++ b/lisp/elec-pair.el @@ -700,6 +700,50 @@ electric-pair-local-mode (setq-default electric-pair-mode nil) ; But keep it globally disabled. ))) +;;; Electric multichar pairing. + +;; `electric-multichar-pair-post-self-insert-function' +(defvar-local electric-multichar-pairs nil + "Alist which contains multichar pairs to insert `electric-multichar-pair-mode'. +Each element must be in the form: + (START . END) +Where START and END are respectively pair start and end.") + +(defun electric-multichar-pair-post-self-insert-function () + "Function that `electric-multichar-pair' adds to `post-self-insert-hook'. +This closes pairs according to `electric-multichar-pairs'." + (when-let* ((pair-ender ; Check if we are in any pair starter from `electric-multichar-pairs' ... + (cl-loop for pairs in electric-multichar-pairs + do + (if (save-excursion + (save-match-data + (re-search-backward + (regexp-quote (car pairs)) + (- (point) (length (car pairs))) + t))) + (cl-return (cdr pairs))))) + ;; ... and if there is not anything front us. + ((null (looking-at-p (concat "[[:space:]]\\|" + (regexp-quote pair-ender)))))) + (let (electric-pair-mode ; Avoid conflicts with other electric modes + electric-quote-mode) + (insert " ") + (save-excursion + (insert (concat " " pair-ender)))))) + +(define-minor-mode electric-multichar-pair-mode + "Toggle automatic pairing of multicharacter pairs (Electric Multichar mode). + +When enabled, typing the beginning of any pair in `electric-multichar-pairs' +closes it inserting their corresponding ender." + :group 'electricity + :version "31.1" + (if (and electric-multichar-pair-mode (consp electric-multichar-pairs)) + (add-hook 'post-self-insert-hook + #'electric-multichar-pair-post-self-insert-function 10 t) + (remove-hook 'post-self-insert-hook + #'electric-multichar-pair-post-self-insert-function t))) + (provide 'elec-pair) ;;; elec-pair.el ends here diff --git a/lisp/electric.el b/lisp/electric.el index da5fa973757..39e13e1ca0c 100644 --- a/lisp/electric.el +++ b/lisp/electric.el @@ -731,38 +731,6 @@ electric-quote-local-mode (setq-default electric-quote-mode nil) ; But keep it globally disabled. ))) -;;; Electric comment block - -(defun electric-block-comment-post-self-insert-function () - "Function that `electric-block-comment' adds to `post-self-insert-hook'. -This closes block comment with `block-comment-end' when `block-comment-start' -is typed." - (when (and block-comment-start block-comment-end - ;; Check if we are exactly behind a `block-comment-start' - (save-excursion - (save-match-data - (re-search-backward (regexp-quote block-comment-start) - (- (point) (length block-comment-start)) - t))) - ;; And if there is not anything front us - (looking-at-p (concat "[^[:space:]]"))) - (insert " ") - (save-excursion - (insert (concat " " block-comment-end))))) - -(define-minor-mode electric-block-comment-mode - "Toggle automatic closing of block comments (Electric Block Comment mode). - -When enabled, typing `block-comment-start' closes it inserting their -corresponding `block-comment-end'." - :group 'electricity - :version "31.1" - (if electric-block-comment-mode - (add-hook 'post-self-insert-hook - #'electric-block-comment-post-self-insert-function 10 t) - (remove-hook 'post-self-insert-hook - #'electric-block-comment-post-self-insert-function t))) - (provide 'electric) ;;; electric.el ends here -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 12:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: eliz@gnu.org, 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174532439630714 (code B ref 77823); Tue, 22 Apr 2025 12:20:02 +0000 Received: (at 77823) by debbugs.gnu.org; 22 Apr 2025 12:19:56 +0000 Received: from localhost ([127.0.0.1]:46640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7CbT-0007zK-TU for submit@debbugs.gnu.org; Tue, 22 Apr 2025 08:19:56 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:34504) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7CbP-0007z2-Sr for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 08:19:53 -0400 DKIM-Signature: a=rsa-sha256; b=G9rB5Po80xSGpkftmWbWXiMJtJACZ7/VNEFYHIQ/aBWBHRIvA8tHPIRndTCoJRg+YsQTkVZcQPOw9+WM3QztciE+QIbngc2wTOaPLxCYlpd5+fkWcZmudfNFDg7/WFX/W4tbdgnGhBxGGMHmRFzVgd93lci/dzg9clBNuhtkuPCH7XynvJ6kuSE/XsO5YPbMdgM5m2oWdqJ7ab2Cpz51P6TrTi7lnif1iVEWpfVEZ60P4RZ2kpC+CtwudnhTcKlVx++PjTXBqa+ftnGTC73/BLp6M0g4xLzlidhnZ6XFB45kbHmkV4qWud2ZYSWhQwHeBN79rAVc/dgoJf++87w+vg==; s=purelymail1; d=spwhitton.name; v=1; bh=nCnUAys7eB9yTU/GRQURFBlKecIkynqIyHHCgtdkeUY=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=QwYA63towpK7lgPYH/HypZEcaWHsQ3Jb96HXIE+Vcv4aJjWW4tm5HvElxuuW2m0lqXJG+cqyJ8z4uuBCfbfyW2R6lnoKniMqCIUXZ2gnVy3Ujx8js4ZcPoyqUKLkn2eITgGp3h0ljXRSpKRExN6FWPDE2TrqEwmZB8J7hV7ZQ9J6IpUpJpT8dkzr11qcYzKlgzNDsWzg/K0/1Ta7PFQjorSSnaWN3Rz4rxhbOyPjMEpaumHkXFVSAMqoY7aI332AKgaaYR1GOKBEoF5c33l4KOW7BVfH/XOsIg1cOxzFBKABNKabkpFg4dcEzpg1p+CVGlTdXlS91ALp8Vbdh34J7w==; s=purelymail1; d=purelymail.com; v=1; bh=nCnUAys7eB9yTU/GRQURFBlKecIkynqIyHHCgtdkeUY=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2135550198; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 22 Apr 2025 12:19:44 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 774397E2219; Tue, 22 Apr 2025 20:19:38 +0800 (CST) From: Sean Whitton In-Reply-To: <87fri2fty2.fsf@gmail.com> References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> Date: Tue, 22 Apr 2025 20:19:38 +0800 Message-ID: <871ptkgzhh.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Okay, thanks, I understand better now what you're trying to accomplish. This isn't fundamentally about comments at all. For example, these multichar pairs could include the opening "case" and closing "esac" in a shell script, right? If that's right, then I'm not sure a new electric minor mode is the right thing. We already have abbrevs and skeletons which work for this sort of thing. Indeed, this is exactly how sh-case is already implemented. -- Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= , 77823@debbugs.gnu.org, eliz@gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174533886214095 (code B ref 77823); Tue, 22 Apr 2025 16:22:01 +0000 Received: (at 77823) by debbugs.gnu.org; 22 Apr 2025 16:21:02 +0000 Received: from localhost ([127.0.0.1]:49599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7GMo-0003f2-2F for submit@debbugs.gnu.org; Tue, 22 Apr 2025 12:21:02 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:50497) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7GMl-0003ec-AP for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 12:21:00 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 43820438CE; Tue, 22 Apr 2025 16:20:49 +0000 (UTC) From: Juri Linkov In-Reply-To: <871ptkgzhh.fsf@melete.silentflame.com> Organization: LINKOV.NET References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> Date: Tue, 22 Apr 2025 19:20:12 +0300 Message-ID: <87jz7c9nql.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgeegudelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrgdprhgtphhtthhopeejjeekvdefseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhmpdhrtghpthhtohepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > This isn't fundamentally about comments at all. For example, these > multichar pairs could include the opening "case" and closing "esac" in a > shell script, right? Maybe 'electric-pair-mode' should support string delimiters in addition to characters, e.g. (setopt electric-pair-pairs `(("case" . "esac"))) From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: Eli Zaretskii , 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174535061017512 (code B ref 77823); Tue, 22 Apr 2025 19:37:02 +0000 Received: (at 77823) by debbugs.gnu.org; 22 Apr 2025 19:36:50 +0000 Received: from localhost ([127.0.0.1]:49978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7JQI-0004YO-95 for submit@debbugs.gnu.org; Tue, 22 Apr 2025 15:36:50 -0400 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]:53261) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u7JQE-0004Y3-Rk for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 15:36:48 -0400 Received: by mail-qv1-xf43.google.com with SMTP id 6a1803df08f44-6ecfa716ec1so53876106d6.2 for <77823@debbugs.gnu.org>; Tue, 22 Apr 2025 12:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745350601; x=1745955401; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qagz9EJSt5KVMsiYmz/kKwkQsK3D0d3wByzmvwNhbTQ=; b=hSMBVf/ZrAvB9tMF6RXzQe+l19iyg81FpxWfnzR7HT9q6Xmc1DBdpjqfNOFU53HAAO BhyKEpyAVO/cmlrcGugXS8Er74QRDObn02Sf9myklzIqUa3yBRnQE/o120JM/cgIuQA3 5c4Q5buyjv5QI1Wdq3jYGf4x3ASW0gqiRHLVdHf5I23KBlAeaBN03J7BuaDmT7eXjhjH YnXRn7xWDFlQpi3GfmjbK9LcLEHcr27p0CnqHtcYjYbZ8B5tlUjuoMXydFYqGbTpqJju rBHkIDNBbAkzbCSeMOPoz67b+Pps5D1iQKck/dqlsTH6ytI6vyXShZDQ9xtzeB4G5BdO hUtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745350601; x=1745955401; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qagz9EJSt5KVMsiYmz/kKwkQsK3D0d3wByzmvwNhbTQ=; b=nta80rRvbEVn12rvGf4876IDJgUoNyEGxayl07vc76TmB8mRkEidkrMClQdotWECH7 tCHvW3F9JRolpWWB8VXd2t5AZ/AyNfaS4Ht1L4Hh3/M/lci+YxEaADII6dRlCUH1k/XZ wLaxo5kzytlCwiN5wQkZQwGqZW4/KfzknGbShVGlUDUoeODhZFak5CffdR8zEfP7XwOj PuQFGXctpTQPnSeK1aEG5pw+IOwjW5lMK0+ylvt2jGcaVKW/AwUTIJjiQKf05eRDrv29 vH9FeqAYz9ZghYxWJDtW8khHvWHgq0og+32f7fAHYOEkhEfDB/UQ+tVFRMqMjF6mobaN z2sA== X-Forwarded-Encrypted: i=1; AJvYcCWGNjJrfZD8ql6rJdsfbanj8hCUyNhXcarX3Xf5tYmOx1IR0lVS8LaROqWGZjghXhwwoTPILQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YytGEEZjFdymqk4QTFA7REc6NIdQ5MKCLVG3Wkj6WBk6tFXEgok NtBL++5+5Jry+FuThmJlt5dLVdmlwkuaQORmMTUFggXIAWR1c+SrrNxnq64wet7xVhnZIP+s4CM sAV5p2u1vHG56dtPTbGjZTarGdyM= X-Gm-Gg: ASbGncva31vSK4apDRc0BWxznWDID/yqqHOidj6IHj4cMLwrJn7vTmoQaP4OUZ6S/tC YGZMoxP+gX2DciQ1ROxzcevdm4ueRpviVwqmoHtA2vGZok7G0oyRuRGxT0JXo0iS+70UWEEY5Rg ujgrYGEtFN8hB9MujoQ4Zr X-Google-Smtp-Source: AGHT+IFOyQukBkRNIWVs0T2kr5LqCVbepzkW2eFGJnzYSWDsEDk31isr9ACXDjP30/39JfYePZk4ln4afhc4vaFf0Gw= X-Received: by 2002:a05:6214:5785:b0:6f0:e2e1:52a7 with SMTP id 6a1803df08f44-6f2c4688120mr305179696d6.42.1745350601236; Tue, 22 Apr 2025 12:36:41 -0700 (PDT) MIME-Version: 1.0 References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> In-Reply-To: <871ptkgzhh.fsf@melete.silentflame.com> From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Date: Tue, 22 Apr 2025 13:36:09 -0600 X-Gm-Features: ATxdqUGWX6nyd73zTJY10itSUYTgFw9b6kwtr2_1N5y6JrXAIzU-2GYtOJSIxsA Message-ID: Content-Type: multipart/alternative; boundary="0000000000009866df0633631a89" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000009866df0633631a89 Content-Type: text/plain; charset="UTF-8" Sean Whitton writes: > Hello, > > Okay, thanks, I understand better now what you're trying to accomplish. > > This isn't fundamentally about comments at all. For example, these > multichar pairs could include the opening "case" and closing "esac" in a > shell script, right? > Honestly, I always had in mind that it would be for comments. So if your type /*, it will automatically insert /* */ ^ cursor in middle both spaces (including spaces an maybe newlines) It was similar to what I saw in the cc modes and smartparens-mode If that's right, then I'm not sure a new electric minor mode is the > right thing. We already have abbrevs and skeletons which work for this > sort of thing. Indeed, this is exactly how sh-case is already > implemented. But those do not expand immediately AFAIK; like if you type "{" --0000000000009866df0633631a89 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sean Whitton writes:
H= ello,

Okay, thanks, I understand better now what you're trying to accomplish.=

This isn't fundamentally about comments at all.=C2=A0 For example, thes= e
multichar pairs could include the opening "case" and closing &quo= t;esac" in a
shell script, right?

Honestly, I always had in mind that it would be for com= ments.

So if your type /= *, it will automatically insert
/*=C2=A0 */
=C2=A0 ^ cursor in middle both spaces

(including spaces an maybe newlines)

It was similar to what I saw in t= he cc modes and smartparens-mode

If that's right, then I'm not sure a new electric minor mode is the=
right thing.=C2=A0 We already have abbrevs and skeletons which work for thi= s
sort of thing.=C2=A0 Indeed, this is exactly how sh-case is already
implemented.

But those do not expand immediately AFAIK; like if you type "= ;{"
--0000000000009866df0633631a89-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 19:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 77823@debbugs.gnu.org, Stefan Monnier , Sean Whitton Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174535157120702 (code B ref 77823); Tue, 22 Apr 2025 19:53:02 +0000 Received: (at 77823) by debbugs.gnu.org; 22 Apr 2025 19:52:51 +0000 Received: from localhost ([127.0.0.1]:50038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7Jfm-0005No-Ra for submit@debbugs.gnu.org; Tue, 22 Apr 2025 15:52:51 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:56552) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u7Jfk-0005NV-LN for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 15:52:49 -0400 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6ecfc7fb2aaso51244546d6.0 for <77823@debbugs.gnu.org>; Tue, 22 Apr 2025 12:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745351563; x=1745956363; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3ykrULicif7nPcYg7OwmU0CFnxAcrDNWrufqEi5BOc0=; b=ifI0I7leLTfU8Kj6EDKQ9yv4CIpR5DBf9nbV4+xE+Srq5i6AbAL/az+YqjxxkzPNWm g8hTWbO9vWH2znkwWCfVoH87PEPQnYPY7jCVtjUQgs5jPCyDQlFV5xl0Ieg1Tdjgd3Rd FgfvnE30mAuHN0fgrF92mi7Kvf6F04SV5FzdCyx+1pFCHaSg9Ieryksp5cxW4a60WMCy U7NHo6yaxi3MFxTyhiPZ2qK0UXVb2gB33y/gIFisldt2uNmTJCIvfUoxaa4ale7NrQ1I sVJTXNXy6DWB86LGstWWtoysGXnqX5oHISotaNW6Ymxv6qZT6Q1gTMjlgN9ty0FNq9Rc WiJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745351563; x=1745956363; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3ykrULicif7nPcYg7OwmU0CFnxAcrDNWrufqEi5BOc0=; b=B4LhevBxkKOq8oJMk0S2DMrgWZBztzHwPRp66ATDVXAGLE3YEJb3KLms5/2Aa8kJnF am+XrmPiSYn6ntGSOWAX5htFa5aeOuBUJ7GrsXnbl+VV4PnNB7u/NJmq0AJaWO5FjOeB anUSnQXIXfOlwMoyOTv8QlSwYrdVNB0lX57SYIJVBCdZzXBNSYT65Naw59DXwnpxm7Vk va0NDYtIo23g/k73rgvZ73PLK95Ns7bE/R0L80tDeJXVn68RmL7SifXo8xpBXdtaGzj2 yDtdeHFDwnc30Hvba17dnCX10hk0HvFAMtAF9T52iB7x3LgeC3SvyWY7uFloNJt4iZLO Un2Q== X-Forwarded-Encrypted: i=1; AJvYcCWvDSyhcoxx3RArIeSXa7mX6+6bKNTPWaVsQcOYYphEhBr/106CK6FlVajDN9e4gmIz4umyPQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxfifnwJYydWvvouB004yX5NsOGKWrBt8VvxJJe1PFyEutBA+Hr wJYARWj33FP4cxRm/oEHqVJ3obFx1vKOvXswhyZo4Qbzhb4Qv7cCbV+0k8NiV154DsRbmhN++6e KYIu5mw+mQdrdrG4cON3vEUsx5AU4DAOB X-Gm-Gg: ASbGncsT1++A34EQvf7VZdZ+A38JLG6YGz5XC9gjg9oD8Izj5QTS1FUIJd0z+ZTyger QXvNff2HNupZ0VqI+lXBIQOEDuGwiVNaElBjrVHwaDkFD7LC7b6fAcf4Pc4ke5Wb2QcFbrF/xjN 6WbwnjhejwocRT/Fw9BNyR X-Google-Smtp-Source: AGHT+IH0JqWiBJ5yXyWQB1FdMFNw52jFqb8JblTxYsgDoFdTdn513enKLCjlOX87VUpJa3wFa2G5XxF/X4m6salxAmg= X-Received: by 2002:a05:6214:5009:b0:6eb:2fd4:30bd with SMTP id 6a1803df08f44-6f2c46787f4mr215522606d6.30.1745351563041; Tue, 22 Apr 2025 12:52:43 -0700 (PDT) MIME-Version: 1.0 References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> <87jz7c9nql.fsf@mail.linkov.net> In-Reply-To: <87jz7c9nql.fsf@mail.linkov.net> From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Date: Tue, 22 Apr 2025 13:52:31 -0600 X-Gm-Features: ATxdqUGXZIr8NheKglYIDa4BCUZPpDHUPLOKPuUHzFQkLlzojTKsvRLhf2auR_s Message-ID: Content-Type: multipart/alternative; boundary="000000000000ec651a063363538d" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000ec651a063363538d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Juri Linkov escribi=C3=B3: > > This isn't fundamentally about comments at all. For example, these > > multichar pairs could include the opening "case" and closing "esac" in = a > > shell script, right? > > Maybe 'electric-pair-mode' should support string delimiters > in addition to characters, e.g. > > (setopt electric-pair-pairs `(("case" . "esac"))) > Right, but using case for this would be a downside from my POV, if you write `case' in a comment for documentation it will auto insert `esac', another idea is define a variable in electric-pairs for this kind of pairs which specifies if a pair can be expanded in comments/strings. > --000000000000ec651a063363538d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Juri Linkov <juri@linkov= .net> escribi=C3=B3:
> Th= is isn't fundamentally about comments at all.=C2=A0 For example, these<= br> > multichar pairs could include the opening "case" and closing= "esac" in a
> shell script, right?

Maybe 'electric-pair-mode' should support string delimiters
in addition to characters, e.g.

=C2=A0 (setopt electric-pair-pairs `(("case" . "esac"))= )

Right, but using case for this would be a downside from my POV, if you wri= te `case' in a comment for documentation it will auto insert `esac'= , another idea is define a variable in electric-pairs for this kind of pair= s which specifies if a pair can be expanded in comments/strings.
--000000000000ec651a063363538d-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Apr 2025 21:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: Eli Zaretskii , Sean Whitton , 77823@debbugs.gnu.org, Juri Linkov Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17453571376039 (code B ref 77823); Tue, 22 Apr 2025 21:26:01 +0000 Received: (at 77823) by debbugs.gnu.org; 22 Apr 2025 21:25:37 +0000 Received: from localhost ([127.0.0.1]:50258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7L7Y-0001ZK-JX for submit@debbugs.gnu.org; Tue, 22 Apr 2025 17:25:36 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23733) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7L7W-0001Z5-I1 for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 17:25:35 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5F681100034; Tue, 22 Apr 2025 17:25:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745357127; bh=+4FUx5nq/FiNhcAJYRw3ME9pngQrCWjIhXpmc+pjD88=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=h8cnkVUWxtv74vaDbvWmKo5XmCjmM3/pG2z7taaYhtlMsUjgTojb1ZZYyqh1daqu5 SrCesQZ1DZOFV1m1in4MtTZhlMqhvQt/4abmMLHie20pA8kUbUPUU+tYmamRhxpxe2 W8ojQ7g4S10EQnuEkO3JPt3+SEjRwO43FzQB78ZIb7lNbTIeo/R/k63RVAjMCgA6yO 1fJ6/V9+pN8C5thOyq476LDhQsm8GW9QMUxW7Q+QlBPCtqPCyYxzgIDoBT+vndmqki 2qUvzW8qMlL9y/mDfDqPZcVGxy7PValOBEO43PN/UPzhEHL6m0TkAnFDCrcnptiRze 6G/fS3nOcBXJQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7FBAB100027; Tue, 22 Apr 2025 17:25:27 -0400 (EDT) Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 55AA212023C; Tue, 22 Apr 2025 17:25:27 -0400 (EDT) From: Stefan Monnier In-Reply-To: Message-ID: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> <87jz7c9nql.fsf@mail.linkov.net> Date: Tue, 22 Apr 2025 17:25:26 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.204 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> (setopt electric-pair-pairs `(("case" . "esac"))) > > Right, but using case for this would be a downside from my POV, if you > write `case' in a comment for documentation it will auto insert `esac', > another idea is define a variable in electric-pairs for this kind of pairs > which specifies if a pair can be expanded in comments/strings. That's why there is both `electric-pair-pairs' and `electric-pair-text-pairs'. Another issue if we want to expand the scope of electric-pair is that when the users type `case` maybe they're just yping `case` but cases they're actually on their way to typing `cases` or `cased` or `case_nb` or god knows what else: for those matched thingies that can be prefixes of arbitrary identifiers, we'd probably want to wait for the user to hit SPC (like abbrev does) before inserting the closing element. Stefan From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2025 02:12:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Cc: Eli Zaretskii , 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174537426321476 (code B ref 77823); Wed, 23 Apr 2025 02:12:05 +0000 Received: (at 77823) by debbugs.gnu.org; 23 Apr 2025 02:11:03 +0000 Received: from localhost ([127.0.0.1]:51047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7PZn-0005aK-FV for submit@debbugs.gnu.org; Tue, 22 Apr 2025 22:11:03 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:36160) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7PZi-0005ZI-31 for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 22:10:59 -0400 DKIM-Signature: a=rsa-sha256; b=GTK7aSn9+Wp0lC62LU9TiC+CoDMnDvTxpbUMMHEEklm5jReuxPWxnRwXEWM8O3nWwWsvvVzz/xzoonNRKnSnhqarpv5WJoNIpnbMdi+3aveV3QKEAI6dnJPgdE3KFjrMrUJQBxtAe9AIZeKmN3MkFNZkzsTzRge3FLGi8BH3jMBSdmqi5sC/SpFWwG5ZzXywJ1pU8O+EFNEF0N0oiJxZDU50VCvtLlgvalg5grCRtbz5Sy6zf0/LyULjMiQqQdfIMqvjEc/Qvh/RZjbH2inrXe71pz1IehGZDBXpQMTgPnQcZTyj4yj6fVfzWZCFq9OppgxNWvs1URsNbzST3+X8iw==; s=purelymail1; d=spwhitton.name; v=1; bh=OZQrMkFwycKvShz30jh6q47XoKC1DNSN9RFUkrspxy0=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=BAFerUaOp2zyl3UntBm/mefZGEWzMNrdn/jmnpMX9imhWzxdg3PCwmDsnXGc5cbVsegIWm/OV4txrQAfzKt6v/cZ905rxW6wDkjqx2It9d8g+K2jsR7MLOk8qa3pkkI3aSOsIhn4Cnoekc/WRsxoTzDWJMp2UKsHMwx58/W0K3rO8otKLwpWBgeYo0C5BZ/NTSPsrbtWFDAq+Osdsb/kh7hODYf8ztxKH8CY6y4AsExv7WkVto5NxTVE1YU9b2b5dquXPwexDKwis0BOcZ1fgGWF2tgnH4aRCvhHaDEP91DTWe8KNi/CATzRyYMN/IGFwMGsJ/h3DUGcFA6S5v7thg==; s=purelymail1; d=purelymail.com; v=1; bh=OZQrMkFwycKvShz30jh6q47XoKC1DNSN9RFUkrspxy0=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -718638747; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 23 Apr 2025 02:10:49 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id D8E477F2FB0; Wed, 23 Apr 2025 10:10:45 +0800 (CST) From: Sean Whitton In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> Date: Wed, 23 Apr 2025 10:10:45 +0800 Message-ID: <8734dzfx0a.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Tue 22 Apr 2025 at 01:36pm -06, Elijah Gabe P=C3=A9rez wrote: > But those do not expand immediately AFAIK; like if you type "{" I think that's specifically how abbrev and abbrev-based skeletons don't trigger if you only type characters that aren't word constituents. Good point -- that probably renders them unsuitable for this. ISTM that a combination of the suggestions from Juri and Stefan would work well. It would be great if you could expand the functionality of electric-pair-mode to handle these cases. --=20 Sean Whitton From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2025 03:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: Eli Zaretskii , 77823@debbugs.gnu.org, Stefan Monnier Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.174538009932433 (code B ref 77823); Wed, 23 Apr 2025 03:49:01 +0000 Received: (at 77823) by debbugs.gnu.org; 23 Apr 2025 03:48:19 +0000 Received: from localhost ([127.0.0.1]:51443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7R5v-0008R2-EI for submit@debbugs.gnu.org; Tue, 22 Apr 2025 23:48:19 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:54501) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u7R5p-0008Qd-NT for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 23:48:16 -0400 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6ecfbf8fa76so69447056d6.0 for <77823@debbugs.gnu.org>; Tue, 22 Apr 2025 20:48:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745380088; x=1745984888; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4fD7sx8Chi8JHV1pftCAzqxeKLjxdJHFmi+oBlsMw2Q=; b=STyFWYKv7+Y9TZ9BPoaCJNPoAYIzN3CN4KYTzgJpVCaYGZ0Ck8dSF3Bl5BuGumVS7g uC45kpgcSw0hw7HlSlS3yNDSNfkGCCdBiNfL7Av8MVgnQkpfDpb2mm9gHVMQyTo7ay26 W5DGVtkm+I9DfFm6yROkYpdfInK8KbAWLaJhETfmxRWKDPFUu5O0HmK2k3NJDYtaQL2I M1KWgfq3h9GrMSHJ2Chfl33f94CT5Sg8IcysLVJ3uJg/M4+G8L3v3KRx6ba8DnOC1hRx K8Dsd/X0Jq0G2xu/63vWJ1UUzLc5370rougZqxqxKSiRZOl064KfxN36uMXccWNU9tzP vG1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745380088; x=1745984888; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4fD7sx8Chi8JHV1pftCAzqxeKLjxdJHFmi+oBlsMw2Q=; b=iQY57XfMTzB28PA51TUQig7zBg6XYPlCsfcxSskkdZXn0ceVYbnY5pSuTu09luCJLm 2bTQ4+txJOHTTSF8IU582PsehRwzQpgY95GbHXwX4cFTyac5hluN0Yd7na4KBV7GGcE7 bNGCjxaKZ+hEcgKNy+1FRdoP7a0YzczmzUELm674UwidMENjwWhIWfnzYjxznYtAVoxD W4+k9o6lxxNd9iEM3JPqISnqqyt1c685v/gIboLrudCpaf28gdHtYpuBOT6h9Hdkp3ck 1Hy/PLjqpU/ghP5uC8UxW0rRQXbYheHgjIKtZowgW+hUq3vqP606tjlpz21K8+TIlwyw zEDQ== X-Forwarded-Encrypted: i=1; AJvYcCWG0xnaGJ1ieOqMZTvrfcyUPzPaGfO5UkNvKlHin7v5SUGbpChGVkl+cJCyVytvqjR7kfjXmw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw6/dYjSG4/r4GtMeBNbOzdCoDcRUMvLEb0BCQqt7htZt2MomWz nZ0PUUy4LQcc00spLvXpVsnFW6DhJDu18mIDneepRw6X3a69NtP0XFTuY9JWlA59OK6s53GRkM8 HIX0QM+eEHjm8ZVnqddnWEM3Y92w= X-Gm-Gg: ASbGnctwssAkV7p2EBq7L2oc5eHa4v2XZlt/PCdz02tmibIj8GyScTvY6xxQ9eTYTwt p9FIn8GBYF2xOzVMoNXNqh8E0XUA9btUBfRfLU3H6bV0rRGbyK/HzlMUN1C/rcyjxGwSMJKuLP7 kAo0OuEyAn4zPkoJMhVS7roRazGeZxPBCNXt7nYeTWhS5CsOJ36L1H X-Google-Smtp-Source: AGHT+IFMQ8rQAfC4OJdV5hlvk1zB1ois4IsCnfYGIAB2t0w2YqkFO+TLsJH5Blwz9Rrw+sDBFwb1HT6Um7NXeB27F/M= X-Received: by 2002:a05:6214:c64:b0:6ea:d393:9634 with SMTP id 6a1803df08f44-6f2c44e6184mr317309706d6.3.1745380087717; Tue, 22 Apr 2025 20:48:07 -0700 (PDT) MIME-Version: 1.0 References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> <8734dzfx0a.fsf@melete.silentflame.com> In-Reply-To: <8734dzfx0a.fsf@melete.silentflame.com> From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Date: Tue, 22 Apr 2025 21:47:55 -0600 X-Gm-Features: ATxdqUF20DSkVWDI0JfV9hqWjDeCk27SGbE11WeNQyC6ydiUIZAKQtREuIkZ67o Message-ID: Content-Type: multipart/alternative; boundary="0000000000002062af063369f8c9" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000002062af063369f8c9 Content-Type: text/plain; charset="UTF-8" Sean Whitton writes: > ISTM that a combination of the suggestions from Juri and Stefan would > work well. It would be great if you could expand the functionality of > electric-pair-mode to handle these cases. > Yeah, at least support strings and specify if a paren should be expanded after a space (for do not conflict with others parens)(?), I will work on that, at this point it would be to make it similar to smartparens. Ofc, some built-in major modes should set which parens to use. > --0000000000002062af063369f8c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sean Whitton writes:
ISTM that a combination of the suggestions from Juri and Stefan would
work well.=C2=A0 It would be great if you could expand the functionality of=
electric-pair-mode to handle these cases.

Yeah, at least support strings and= specify if a paren should be expanded after a space (for do not conflict w= ith others parens)(?), I will work on that, at this point it would be to ma= ke it similar to smartparens.

Ofc, some built-in major modes should set which parens to use.
<= div dir=3D"auto">
--0000000000002062af063369f8c9-- From unknown Sat Jun 14 03:56:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sean Whitton Subject: bug#77823: closed (Re: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d) Message-ID: References: <87o6wnedjv.fsf@melete.silentflame.com> <87v7r5slzj.fsf@melete.silentflame.com> X-Gnu-PR-Message: they-closed 77823 X-Gnu-PR-Package: emacs Reply-To: 77823@debbugs.gnu.org Date: Wed, 23 Apr 2025 03:57:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1745380624-1850-1" This is a multi-part message in MIME format... ------------=_1745380624-1850-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77823: 31.0.50; M-j regression since commit 4c6b1712a4d which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77823@debbugs.gnu.org. --=20 77823: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77823 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1745380624-1850-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77823-done) by debbugs.gnu.org; 23 Apr 2025 03:56:42 +0000 Received: from localhost ([127.0.0.1]:51472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7RE1-0000Su-MO for submit@debbugs.gnu.org; Tue, 22 Apr 2025 23:56:42 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:37708) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7RDs-0000SQ-HV for 77823-done@debbugs.gnu.org; Tue, 22 Apr 2025 23:56:38 -0400 DKIM-Signature: a=rsa-sha256; b=BtIwsGtucvjMj5v5y/DP0Cel/4RP0hUzLE6NIWb3HG0RHBZLpyUXCt8gDGHpgtjO9JpdJ1RMEsMXu/UpjlNnMkzdEayh4FauYlwKdesJ6LdYuTMSQwKjg48JhMzTbSQVq+/XqvxmwFNUaih7J4zqqaLmFRXLMFkoiBtf+6MqyIK8t83XTTnEGe7NVGBfWpKquAbwzx+5q1wQgAcWZT4HRZTdsthWaZbnJKCwwU0oWDRfpIs5SR+kIO7hcP3/hNOeh+finUPBtuWDV8QF32ZL2XqFjvn6Hix62SHEPomCTuxcpiBjO725aomB9aLFZtY2frWv03dqYBTvIWy+XRM4KQ==; s=purelymail1; d=spwhitton.name; v=1; bh=uncLpZAl2uEe4QraCrabbRccLLMa/8JqomvM/GkNaMM=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=BtcdGDIMl5fWbPW1hfjJOx1oTy9qYG/F0TWh/FILchAQZ1l2WaL6ganz7PFWUQdwDhFK6aqLj/dYrkBu5laCwyb9KORmJTfvyteQvb79+VGPzyG7m/31B3bFAPKIR8Xazej3hRpChCD1OfsdexmQE6i+F9Glr+U4NUPQAmzBpZh7jNiXPEnEa0YDjZljZ+mCtoAYs603E8D2FQ4gl+gVfKE65ePTdjYPkbSj+gGKPf/RDctdo7Ujc02bApqKvW/1pUrMFam+lddxmWhbZByRwSneCfPkaywqKfDIG1Ecjisn732N098x8zg38RbWZE47b6B1UtI4IDrNKua+Cyz8JA==; s=purelymail1; d=purelymail.com; v=1; bh=uncLpZAl2uEe4QraCrabbRccLLMa/8JqomvM/GkNaMM=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77823-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 544473961; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 23 Apr 2025 03:56:24 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 570F67F2EE9; Wed, 23 Apr 2025 11:56:20 +0800 (CST) From: Sean Whitton To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d In-Reply-To: References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> <8734dzfx0a.fsf@melete.silentflame.com> Date: Wed, 23 Apr 2025 11:56:20 +0800 Message-ID: <87o6wnedjv.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77823-done Cc: Eli Zaretskii , 77823-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Tue 22 Apr 2025 at 09:47pm -06, Elijah Gabe P=C3=A9rez wrote: > Sean Whitton writes: > > ISTM that a combination of the suggestions from Juri and Stefan would > work well. It would be great if you could expand the functionality of > electric-pair-mode to handle these cases. > > Yeah, at least support strings and specify if a paren should be expanded = after a space (for do not > conflict with others parens)(?), I will work on that, at this point it wo= uld be to make it similar to > smartparens. I'm not really familiar with smartparens but those seem like relevant considerations. > Ofc, some built-in major modes should set which parens to use. Right. I'll close this bug since the regression is fixed. You could post your new patch to a new bug, perhaps. --=20 Sean Whitton ------------=_1745380624-1850-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Apr 2025 11:28:05 +0000 Received: from localhost ([127.0.0.1]:50939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4eST-0002Q4-Ai for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:05 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42764) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4eSR-0002PX-81 for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSI-0002F1-TD for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:57 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4eSF-00083V-AK for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2025 07:27:54 -0400 DKIM-Signature: a=rsa-sha256; b=AS0KH3IqgU5XlMmVSjVcpnPPEIcoAuu1D7zr1njT+3AO5MVYnrGotcCkPlweunnl9xVdRtkoZLhR0RMH2V/xVZ6YdNB486OST2r5ewSZGIcTNiSD9eWx7SUdvk9Nis5Vo5U8M3P/9q6UbACD9eInwCaI3TtsADS7NBOIEz4JGxZGIdmhItbG+hA4NBFkU9GMlmXxH6ejD0LzzhTKY4nlp3PRPROaKkM9bG1/euddHnkpYC+YJwhmpjSl6gClObtvkIt7t8nKdiAfKPQV1ARp3Pv2IC+4w5mouoUr015YPFHb8DY6a1/c57buYOMltAxZtrxzt0FO1O6I63tIg28biw==; s=purelymail3; d=spwhitton.name; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=V3koxIjNnuH8uoJ0wmgQ9CSlyFRkWgONxBkcTfP8vnwZtj4MoINVKyeQA9uDJhWpvdrUklnGAxYT2uataxoqk2H9Zu5QJsGroBxXtEVEHahC8n6WjKWF2eva9O/ph8I6hVR5A9OXDzL3ey3tP4sH8Ul/O6n5aGu78gv92+2OJohNsnZUvURrAs/cmjgE2SIW6JAv2XFZpBDVIX/0AaiZ+vwpud/26mgQxB0Mw7VrLjDnOVs2BnGjdvSVmBUi07ATfWwqmdZ4Ti/VcCuXYxbYP8hGWX4g/OBBfcQpDusz0pXDAmRYfGme56ZxWU5XKk85Qf/R/e6NlbY8dNEXFt/vHQ==; s=purelymail3; d=purelymail.com; v=1; bh=Kpaz7x9i/mEEawoXD9ri4daTyV/3LHM6ZGajEeDEwLE=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -2113166126 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 15 Apr 2025 11:27:48 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id CE2A97E6BB8; Tue, 15 Apr 2025 19:27:44 +0800 (CST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 31.0.50; M-j regression since commit 4c6b1712a4d Date: Tue, 15 Apr 2025 19:27:44 +0800 Message-ID: <87v7r5slzj.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) X-debbugs-cc: eg642616@gmail.com, eliz@gnu.org 1. emacs -q 2. C-x b foo RET 3. M-x emacs-lisp-mode RET 4. ;;;; hello M-j Result is: --8<---------------cut here---------------start------------->8--- ;;;; hello|# #| --8<---------------cut here---------------end--------------->8--- but it should be --8<---------------cut here---------------start------------->8--- ;;;; hello ;;;; --8<---------------cut here---------------end--------------->8--- My first thought is that since multiline comments of this style are not valid Emacs Lisp, we should just set block-comment-start and block-comment-end to nil for emacs-lisp-mode. However, the recipe provided above works if you do 'M-x lisp-mode RET' instead. Even though Common Lisp supports these block comments, if you are already writing a semicolon-delimited comment, then M-j should continue it, rather than starting a #| |# comment. -- Sean Whitton ------------=_1745380624-1850-1-- From unknown Sat Jun 14 03:56:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77823: 31.0.50; M-j regression since commit 4c6b1712a4d Resent-From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Apr 2025 04:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , Sean Whitton , 77823@debbugs.gnu.org, Juri Linkov Received: via spool by 77823-submit@debbugs.gnu.org id=B77823.17453807442179 (code B ref 77823); Wed, 23 Apr 2025 04:00:03 +0000 Received: (at 77823) by debbugs.gnu.org; 23 Apr 2025 03:59:04 +0000 Received: from localhost ([127.0.0.1]:51494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7RGK-0000Z2-6W for submit@debbugs.gnu.org; Tue, 22 Apr 2025 23:59:04 -0400 Received: from mail-qv1-xf42.google.com ([2607:f8b0:4864:20::f42]:47285) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u7RGG-0000YG-Gr for 77823@debbugs.gnu.org; Tue, 22 Apr 2025 23:59:01 -0400 Received: by mail-qv1-xf42.google.com with SMTP id 6a1803df08f44-6eaf1b6ce9aso67859136d6.2 for <77823@debbugs.gnu.org>; Tue, 22 Apr 2025 20:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745380735; x=1745985535; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=656WZrBz+FIpAR6KZtZCDALi5NK0NjR44Tl6eTvLanM=; b=IIYWTqp7ZTmQU8UWjLP8vMUTj0ITohVjG4nRaHhoHLzyfkJL5vNBDJTr8W8vfHhKQS cTqqMKq+qxdRCjfzmegOK+u8jBQMm5ejKoQYQ1D51NI1IsTd8XIaiGrzak1WeUGudL92 LcPaOApGOf8OKCVx97nr+1NlNoIQJ624sxLrwvW7xsOW1BoDCFhtLVnNi5O/cWOsG2st HaWKfOA5o7j+gaSh6ukFMLnuJdrtHwAbSa8gmBJsFED5bPEXM/nQlOrrhVWAGxElM2kB F6UgscBEF12b3yHi39vst1EbjCLZFPhoPhHiphYXTRQDLCWoAUQyFGaYWhs9OxB5c2ZH Bvzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745380735; x=1745985535; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=656WZrBz+FIpAR6KZtZCDALi5NK0NjR44Tl6eTvLanM=; b=iJ8SzivNByK+m53o5EDGJ6/MGeCan7x6/db5Wjy47j2rbDJ7gwYX39SiInXKK059Xy eifXqOfOsbXrrmr+fuxTsrazQFshovOUpN5IUV2yH8/+FhyEyaecRAvrPgzmbY5DdiPX P0VaHb3ZPeFCgZ1FxqbhjTqGtGDwCzbtURwRzGLetSNib0KHWsScYrUt135P8oOSu+af jgAXeHKtUx5R/cep2BNrllZbjLTjrtl7ZDrCg2/TQ6XYnMZQHPJAGp0xFAoJ2WAzozY5 K3fbMwQzNkRyeLLndyffYsym52BleUivSmcAzd1KXU8H6rhwT5QpXfrpbFTuQIEmweUc w3tg== X-Forwarded-Encrypted: i=1; AJvYcCUjLbJ6mLojaYvDwcnaatdL9QW60iCAnw0qwrbx96RYiOCTtnvGMVV6vvpJJtHiXoyYlNgvnQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwuzFapn4uhkyd1te0uSZVAoo8Y0bQdpjkGojCIMl2Cf3phgn2c Cjnxyz6cC/f/36K7IX9zzVjRRoUucrUzHLClt0L8BbEJ7oDa+eX+uzCXBVnB95Z94ZOTzAaRIDx RqG00EnnRhVNDEW1cqJT3Hix9Ro3Ln3+0 X-Gm-Gg: ASbGncsy29wGPNE+n1VrNLRAswsrXAkyzcixMh18P/l26hdjKOENr+Jh/+4MjX7kC0x IQ0JNBX53Ia7Eh4N4durpqsyLh2nJVcCCsdZZ89FIwY5axyE/jnr1f3T9Qw2FuJxsHRu7e3+D1R P5+lRij05+vNxonD7EAUaDeojBN4WUHblhWheUx+jBmsmAJBE67T6H X-Google-Smtp-Source: AGHT+IFHDQfk+nEoyx8fvOXzufV8WDXwUotqP0QC6fjZs3eYYDWMGXywn6QGDGZ75Yr66rKb1x1fr0C3Couwru6cGPE= X-Received: by 2002:a05:6214:250b:b0:6e6:6699:7e58 with SMTP id 6a1803df08f44-6f2c4500bbemr292256236d6.1.1745380734733; Tue, 22 Apr 2025 20:58:54 -0700 (PDT) MIME-Version: 1.0 References: <87v7r5slzj.fsf@melete.silentflame.com> <86bjsxh8gw.fsf@gnu.org> <87fri9rllx.fsf@melete.silentflame.com> <87mscgkjqh.fsf@gmail.com> <87lds0ri2x.fsf@melete.silentflame.com> <87ldryq75s.fsf@melete.silentflame.com> <87ecxpm1xs.fsf@melete.silentflame.com> <87ecxog6ed.fsf@gmail.com> <87ecxne7sl.fsf@gmail.com> <87fri2fty2.fsf@gmail.com> <871ptkgzhh.fsf@melete.silentflame.com> <87jz7c9nql.fsf@mail.linkov.net> In-Reply-To: From: Elijah Gabe =?UTF-8?Q?P=C3=A9rez?= Date: Tue, 22 Apr 2025 21:58:43 -0600 X-Gm-Features: ATxdqUHToWL2K3Gouk3K_N2afasyX65qlp7VVmm0wsYfLXJeqsguyHrhI8L3_PQ Message-ID: Content-Type: multipart/alternative; boundary="000000000000b1104e06336a1e5d" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000b1104e06336a1e5d Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: > Another issue if we want to expand the scope of electric-pair is that > when the users type `case` maybe they're just yping `case` but cases > they're actually on their way to typing `cases` or `cased` or `case_nb` > or god knows what else: for those matched thingies that can be prefixes of > arbitrary identifiers, we'd probably want to wait for the user to hit > SPC (like abbrev does) before inserting the closing element. Fine, but i think that some parens from alist should specify if must expand after inserting an space, something like: '(("/*" . "*/") ("case" "esac" t)... ^ any non-nil value --000000000000b1104e06336a1e5d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stefan Monnier writes:
Another issue if we want to expand the scope of electric-pair is that
when the users type `case` maybe they're just yping `case` but cases they're actually on their way to typing `cases` or `cased` or `case_nb`=
or god knows what else: for those matched thingies that can be prefixes of<= br> arbitrary identifiers, we'd probably want to wait for the user to hit SPC (like abbrev does) before inserting the closing element.

Fine, but i think t= hat some parens from alist should specify if must expand after inserting an= space, something like:

= '(("/*" . "*/") ("case" "esac" = t)...
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ any non-nil va= lue
--000000000000b1104e06336a1e5d--