GNU bug report logs - #77802
[PATCH] gnu: Add pay-respects.

Previous Next

Full log

View this message in rfc822 format

From: Hilton Chain <hako <at> ultrarare.space>
To: Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
Cc: 77802 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>, Gabriel Santos <gabrielsantosdesouza <at> disroot.org>, Divya Ranjan Pattanaik <divya <at> subvertising.org>, Efraim Flashner <efraim <at> flashner.co.il>
Subject: [bug#77802] [PATCH] gnu: Add pay-respects.
Date: Mon, 14 Apr 2025 23:06:13 +0800

Hi Gabriel Santos,

Thanks for the first patch using the new workflow :)

On Mon, 14 Apr 2025 21:43:18 +0800,
Gabriel Santos wrote:
>
> * gnu/packages/rust-apps.scm (pay-respects): New variable.
> * gnu/packages/rust-crates.scm (pay-respects-cargo-inputs): New variable.
>
> Change-Id: Ic1d49812ba469873eab13da941e5ed0ba15ee52e
> ---
>  gnu/packages/rust-apps.scm   |  32 +++-
>  gnu/packages/rust-crates.scm | 298 +++++++++++++++++++++++++++++++++++
>  2 files changed, 329 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/rust-apps.scm b/gnu/packages/rust-apps.scm
> index 02de57bea4..2168d847ed 100644
> --- a/gnu/packages/rust-apps.scm
> +++ b/gnu/packages/rust-apps.scm
> @@ -38,7 +38,7 @@
>  ;;; Copyright © 2025 Andrew Wong <wongandj <at> icloud.com>
>  ;;; Copyright © 2024 Danny Milosavljevic <dannym <at> friendly-machines.com>
>  ;;; Copyright © 2024 David Elsing <david.elsing <at> posteo.net>
> -;;; Copyright © 2025 Gabriel Santos <gabriel.santos.smtp <at> gmail.com>
> +;;; Copyright © 2025 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -4878,3 +4878,33 @@ (define-public matugen
>       "@command{matugen} generates a 'Material You' color palette based on a
>  specified image or color, easing the process of theme creation.")
>      (license license:gpl2)))
> +
> +(define-public pay-respects
> +  (package
> +    (name "pay-respects")
> +    (version "0.7.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (crate-uri "pay-respects" version))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "0slwj5s53s0vpfvj2hsimaicgyv75av318z6hi1knpqf6adynk1w"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +     (list
> +      #:install-source? #f))
> +    (inputs (cargo-inputs 'pay-respects))
> +    (home-page "https://codeberg.org/iff/pay-respects")
> +    (synopsis "Correct mistyped console command by pressing f")

When describing a keybinding, use @kbd.  But it's actually a command, right?
"pressing" is not accurate here.

> +    (description
> +     "@command{pay-respects} is a program that either corrects mistyped commands,
> +or suggests a correction after the user inputs @command{f}.  This is similar to
> +the @command{thefuck} program.

Installing this package doesn't brings you a @command{thefuck} program, you may
refer to it as @code{thefuck} package.

> +Additional support for instaling packages adding missing binaries is available.
> +For Guix, a user just has to index their store with the @command{guix locate}
> +command.  Additional support for Nix is also available, but that requires the
> +instalation of @command{nix-index} from Nix for it to work (and it also has
> +a lower priority, as package managers are checked in alphabetical order).")

Can you rephrase these sentences without the "For Guix"?  Also Nix isn't
relevant here I think?

> +    (license license:agpl3+)))
> diff --git a/gnu/packages/rust-crates.scm b/gnu/packages/rust-crates.scm
> index 9c40134008..b9bab15e09 100644
> --- a/gnu/packages/rust-crates.scm
> +++ b/gnu/packages/rust-crates.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2025 Hilton Chain <hako <at> ultrarare.space>
> +;;; Copyright © 2025 Gabriel Santos <gabrielsantosdesouza <at> disroot.org>

I personally won't accept a copyright line unless you have made modifications to
the generated content.

I think in practice committers should import dependencies again and check all
added sources after applying the patch locally, so not sure about how to count
copyright for this module.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.