GNU bug report logs - #77800
grep-3.12: write-error-msg test failure on fedora rawhide (f43)

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Grisha Levit <grishalevit <at> gmail.com>
Cc: Jaroslav Škarvada <jskarvad <at> redhat.com>, Paul Eggert <eggert <at> cs.ucla.edu>, jackson <at> fastmail.fm, 77800 <at> debbugs.gnu.org
Subject: bug#77800: grep-3.12: write-error-msg test failure on fedora rawhide (f43)
Date: Tue, 15 Apr 2025 20:32:21 -0700

On Tue, Apr 15, 2025 at 7:26 PM Grisha Levit <grishalevit <at> gmail.com> wrote:
> On Tue, Apr 15, 2025 at 9:54 PM Jim Meyering <jim <at> meyering.net> wrote:
> > Whoa. Thanks. It looks like this is a >19-year-old bug in stream-close.c
> > Here's a tentative fix -- the ChangeLog entry still lacks details of
> > when it was introduced:
>
> -      if (! fclose_fail)
> +      if (!fclose_fail && !prev_fail)
>          errno = 0;
>
> I wonder if this was intentional? Since close_stdout seems to be mostly used
> as an atexit function, errno may well have been set for some unrelated
> reason by the time this runs -- but errno will be relevant to this stream
> if fclose has just failed.

I retract that patch. It was obviously wrong: it would render the
errno=0 statement unreachable.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.