GNU bug report logs - #77770
[PATCH 0/2] Update Dino to 0.5.0

Previous Next

Full log

Message #32 received at 77770 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: vivien <at> planete-kraus.eu, 77770 <at> debbugs.gnu.org,
 Frank Pursel <frank.pursel <at> gmail.com>
Subject: Re: [PATCH v2 1/2] gnu: Add libomemo-c.
Date: Sun, 20 Apr 2025 22:06:10 +0900

Hi Liliana,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> * gnu/packages/messaging.scm (libomemo-c): New variable.
> ---
>  gnu/packages/messaging.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index d127b90..6f9cca2 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -586,6 +586,30 @@ (define-public libsignal-protocol-c
>  end-to-end encryption.")
>     (license license:gpl3+)))
>  
> +(define-public libomemo-c
> +  (package
> +    (inherit libsignal-protocol-c)
> +    (name "libomemo-c")
> +    (version "0.5.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/dino/libomemo-c")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "1xszd4cjrlwwsy19ri2ymqr676qpqqhxv3cw5zwch3lms68p51hy"))
> +              (modules '((guix build utils)))
> +              (snippet

I always like a comment to explain why we prune the source.

> +               #~(for-each delete-file
> +                           (find-files "." "\\.pb-c\\.[ch]$")))))
> +    (build-system meson-build-system)
> +    (arguments (list #:configure-flags #~(list "-Dtests=true")))
> +    (propagated-inputs (list protobuf-c))
> +    (home-page "https://github.com/dino/libomemo-c")
> +    (description "This package provides a fork of libsignal-protocol-c, used
> +by Dino to provide OMEMO support.")))

Otherwise LGTM.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.