GNU bug report logs - #77752
[PATCH] gnu: fwupd: Add elogind input

Previous Next

Full log

Message #16 received at 77752-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> chbouib.org>
To: Rutherther <rutherther <at> ditigal.xyz>
Cc: Vagrant Cascadian <vagrant <at> debian.org>, 77752-done <at> debbugs.gnu.org,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#77752] [PATCH v2 1/2] gnu: fwupd: Add elogind input
Date: Tue, 15 Apr 2025 10:10:01 +0200

Rutherther <rutherther <at> ditigal.xyz> writes:

> The fwupd package doesn't contain the dbus service in
> share/dbus-1/system-service, that is because it is installed only
> conditionally when elogind is available.
>
> This will introduce the service in the output, so user's won't have to start
> fwupd themselves, it will get started by dbus on demand.
>
> I don't think this should break anything for systems that do not use elogin,
> the only places this is used will fall back to error:
> - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L242,
> - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L287
> Meaning users without elogind will get error either way, just a different kind
> of error.
>
> * gnu/packages/firmware.scm: (fwupd)[inputs]: Add elogind
>
> Change-Id: Id44001de6950bb6b39f1b3bba316a08ce6640fc0

[...]

> The polkit rules check in fwupdmgr doesn't make sense with Guix packaging, as
> it's checking if there is fwupd policy files in the polkit's store path.
> This will never be true, and the check will always fail.
>
> One fix would be to skip the check completely. But that seems unnecessary as
> the polkit actions are always in /etc/polkit-1/actions on the Guix system.
> On foreign distros, it will be necessary to turn the check off manually by
> FWUPD_POLKIT_NOCHECK=1. But it's important to note that this was the case even
> till now, there is no new breakage. I think it's unlikely someone will be
> using fwupd package from Guix on foreign distros anyway.
>
> * gnu/packages/firmware.scm (fwupd)[arguments]{phases}: substitute polkit
> actions directory to point to /etc/polkit-1/actions
>
> Change-Id: Ia29d7a32f68a3da7951f45fe823e3ab8059cb670

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.