From unknown Fri Sep 19 16:07:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#77752] [PATCH] gnu: fwupd: Add elogind input Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: efraim@flashner.co.il, vagrant@debian.org, guix-patches@gnu.org Resent-Date: Fri, 11 Apr 2025 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77752 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77752@debbugs.gnu.org Cc: Rutherther , Efraim Flashner , Vagrant Cascadian X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Efraim Flashner , Vagrant Cascadian Received: via spool by submit@debbugs.gnu.org id=B.174439388832060 (code B ref -1); Fri, 11 Apr 2025 17:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Apr 2025 17:51:28 +0000 Received: from localhost ([127.0.0.1]:51674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3IXH-0008L0-2u for submit@debbugs.gnu.org; Fri, 11 Apr 2025 13:51:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34484) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3IXB-0008Ka-9s for submit@debbugs.gnu.org; Fri, 11 Apr 2025 13:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u3IX5-0004s0-4R for guix-patches@gnu.org; Fri, 11 Apr 2025 13:51:15 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1u3IX2-0001a0-KZ for guix-patches@gnu.org; Fri, 11 Apr 2025 13:51:14 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id b58b7973 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 11 Apr 2025 17:51:07 +0000 (UTC) From: Rutherther Date: Fri, 11 Apr 2025 19:50:56 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1744393867; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=pzv2yzLHeRGxR74licUO9GQIIyDEjwa6SXISqporA1Y=; b=Lyy+6GlfzOFRwsN9IJBx/oPl3ifSuwDLsoHVDpfoXZ9NQf0fFP2Eie0ssjjk6aZEgR1kS MiXrrRSS+dgzSr5luCIC7kX5zMQYBQ2+W5o7ftNQjXLm5+9SVYAEbiFG7fqhUA/P6Z+O+5O D1bTsI0a9dZtWkBYXNwYqiUIb/m1ztM= Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::; envelope-from=rutherther@ditigal.xyz; helo=mail.ditigal.xyz X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. Content analysis details: (3.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=rutherther%40ditigal.xyz; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ditigal.xyz (xyz)] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. I don't think this should break anything for systems that do not use elogin, the only places this is used will fall back to error: - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L242, - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L287 Meaning users without elogind will get error either way, just a different kind of error. * gnu/packages/firmware.scm: (fwupd)[inputs]: Add elogind Change-Id: Id44001de6950bb6b39f1b3bba316a08ce6640fc0 --- gnu/packages/firmware.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm index f04edefafe..5e89edc621 100644 --- a/gnu/packages/firmware.scm +++ b/gnu/packages/firmware.scm @@ -65,6 +65,7 @@ (define-module (gnu packages firmware) #:use-module (gnu packages embedded) #:use-module (gnu packages flashing-tools) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gawk) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) @@ -289,6 +290,7 @@ (define-public fwupd gettext-minimal)) (inputs (append (list bash-completion + elogind libgudev libxmlb sqlite base-commit: 13aeb3abf9a8f4a4db1afaacdac275b5b564afdc prerequisite-patch-id: e39a216cb0ec18caa634a73b5ea378912d61ef7c -- 2.49.0 From unknown Fri Sep 19 16:07:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#77752] [PATCH v2 1/2] gnu: fwupd: Add elogind input References: In-Reply-To: Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: rutherther@ditigal.xyz, efraim@flashner.co.il, vagrant@debian.org, guix-patches@gnu.org Resent-Date: Fri, 11 Apr 2025 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77752 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77752@debbugs.gnu.org Cc: Rutherther , Rutherther , Efraim Flashner , Vagrant Cascadian X-Debbugs-Original-Xcc: Rutherther , Efraim Flashner , Vagrant Cascadian Received: via spool by 77752-submit@debbugs.gnu.org id=B77752.174440125723115 (code B ref 77752); Fri, 11 Apr 2025 19:55:02 +0000 Received: (at 77752) by debbugs.gnu.org; 11 Apr 2025 19:54:17 +0000 Received: from localhost ([127.0.0.1]:51857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3KS9-00060k-BY for submit@debbugs.gnu.org; Fri, 11 Apr 2025 15:54:17 -0400 Received: from ditigal.xyz ([78.46.201.50]:49944 helo=mail.ditigal.xyz) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3KS7-00060N-Mn for 77752@debbugs.gnu.org; Fri, 11 Apr 2025 15:54:16 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id 5cb893ca (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 11 Apr 2025 19:54:06 +0000 (UTC) From: Rutherther Date: Fri, 11 Apr 2025 21:54:00 +0200 Message-ID: <7e059e76336daf44b6808bda4d87a922553cdb5d.1744401028.git.rutherther@ditigal.xyz> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1744401246; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=ZOBDaz9xml5FuYExtJ6Y+wQptyN6rLFfC29HOWAt/RI=; b=I2NSMWCQLPBLrlWynwGrhFB+cXg/qgWRZsrOzi/CVgM4zcKTp6zu3F2+IaYlItOZ+adbG 5w9Vcm9dWYq4X8CFPY2PnF03PckYJHASsZZRjycP4Nyv2VjmN2oQLLwrRnf1n2r6EIU0OMf L9QbdhEsl5ffNiC6X9LQH+UPg1pK4TY= X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [78.46.201.50 listed in bl.score.senderscore.com] 0.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ditigal.xyz (xyz)] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [78.46.201.50 listed in sa-accredit.habeas.com] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. I don't think this should break anything for systems that do not use elogin, the only places this is used will fall back to error: - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L242, - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L287 Meaning users without elogind will get error either way, just a different kind of error. * gnu/packages/firmware.scm: (fwupd)[inputs]: Add elogind Change-Id: Id44001de6950bb6b39f1b3bba316a08ce6640fc0 --- gnu/packages/firmware.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm index f04edefafe..5e89edc621 100644 --- a/gnu/packages/firmware.scm +++ b/gnu/packages/firmware.scm @@ -65,6 +65,7 @@ (define-module (gnu packages firmware) #:use-module (gnu packages embedded) #:use-module (gnu packages flashing-tools) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gawk) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) @@ -289,6 +290,7 @@ (define-public fwupd gettext-minimal)) (inputs (append (list bash-completion + elogind libgudev libxmlb sqlite base-commit: 13aeb3abf9a8f4a4db1afaacdac275b5b564afdc -- 2.49.0 From unknown Fri Sep 19 16:07:42 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#77752] [PATCH v2 2/2] gnu: fwupd: Check polkit actions at correct location Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: rutherther@ditigal.xyz, efraim@flashner.co.il, vagrant@debian.org, guix-patches@gnu.org Resent-Date: Fri, 11 Apr 2025 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77752 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77752@debbugs.gnu.org Cc: Rutherther , Rutherther , Efraim Flashner , Vagrant Cascadian X-Debbugs-Original-Xcc: Rutherther , Efraim Flashner , Vagrant Cascadian Received: via spool by 77752-submit@debbugs.gnu.org id=B77752.174440126223126 (code B ref 77752); Fri, 11 Apr 2025 19:55:02 +0000 Received: (at 77752) by debbugs.gnu.org; 11 Apr 2025 19:54:22 +0000 Received: from localhost ([127.0.0.1]:51859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3KSD-00060w-NN for submit@debbugs.gnu.org; Fri, 11 Apr 2025 15:54:21 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::]:34906 helo=mail.ditigal.xyz) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3KS8-00060M-9P for 77752@debbugs.gnu.org; Fri, 11 Apr 2025 15:54:16 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id c067db04 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 11 Apr 2025 19:54:10 +0000 (UTC) From: Rutherther Date: Fri, 11 Apr 2025 21:54:01 +0200 Message-ID: <8957beb35218528cc1b4a27c7a29f151a53caccb.1744401028.git.rutherther@ditigal.xyz> X-Mailer: git-send-email 2.49.0 In-Reply-To: <7e059e76336daf44b6808bda4d87a922553cdb5d.1744401028.git.rutherther@ditigal.xyz> References: <7e059e76336daf44b6808bda4d87a922553cdb5d.1744401028.git.rutherther@ditigal.xyz> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1744401250; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : from; bh=wwYZcu4v0Vqn+mLKV1kDN0hKYSqDBIwHtIRmxrLkats=; b=KWuLo9IYn4goLL3BCmbxcG30iA8LWBXZdQVa5LbKDEC5CLBK39/83eYgsvRH4RWlr3vHM Skr4Q0lj34aDbZIRe88zocFgSfgsvuvUk7hakpWhSqkaG/TpTn3xOlt71mKmQkuM+g/5aT+ pzbEJIWqXbXid6wUAFLwuuyn+tLc4e8= X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) The polkit rules check in fwupdmgr doesn't make sense with Guix packaging, as it's checking if there is fwupd policy files in the polkit's store path. This will never be true, and the check will always fail. One fix would be to skip the check completely. But that seems unnecessary as the polkit actions are always in /etc/polkit-1/actions on the Guix system. On foreign distros, it will be necessary to turn the check off manually by FWUPD_POLKIT_NOCHECK=1. But it's important to note that this was the case even till now, there is no new breakage. I think it's unlikely someone will be using fwupd package from Guix on foreign distros anyway. * gnu/packages/firmware.scm (fwupd)[arguments]{phases}: substitute polkit actions directory to point to /etc/polkit-1/actions Change-Id: Ia29d7a32f68a3da7951f45fe823e3ab8059cb670 --- gnu/packages/firmware.scm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm index 5e89edc621..715b9ab132 100644 --- a/gnu/packages/firmware.scm +++ b/gnu/packages/firmware.scm @@ -250,7 +250,19 @@ (define-public fwupd (find-files ".")) (substitute* "src/fu-self-test.c" (("/bin/sh") - (which "sh"))))) + (which "sh"))) + ;; fwupdmgr checks for missing polkit actions, prints + ;; error message and exits if the polkit actions are + ;; not found. + ;; The path points to gnu store path of polkit and + ;; there are no actions there. Point this to the actual + ;; location used on Guix System. This will still fail on + ;; foreign distros as /usr/share/polkit-1 is used mostly. + (substitute* "src/fu-util.c" + (("g_autofree gchar \\*directory = NULL;") + "") + (("directory = fu_path_from_kind\\(FU_PATH_KIND_POLKIT_ACTIONS\\)") + "const gchar* directory = \"/etc/polkit-1/actions\"")))) ;; These two files are zipped by Python, so need a newer timestamp. (add-after 'unpack 'newer-timestamps-for-python-zip (lambda _ -- 2.49.0 From unknown Fri Sep 19 16:07:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Rutherther Subject: bug#77752: closed (Re: [bug#77752] [PATCH v2 1/2] gnu: fwupd: Add elogind input) Message-ID: References: <87y0w1kfqe.fsf@chbouib.org> X-Gnu-PR-Message: they-closed 77752 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 77752@debbugs.gnu.org Date: Tue, 15 Apr 2025 08:25:08 +0000 Content-Type: multipart/mixed; boundary="----------=_1744705508-27869-1" This is a multi-part message in MIME format... ------------=_1744705508-27869-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77752: [PATCH] gnu: fwupd: Add elogind input which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77752@debbugs.gnu.org. --=20 77752: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77752 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1744705508-27869-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77752-done) by debbugs.gnu.org; 15 Apr 2025 08:24:48 +0000 Received: from localhost ([127.0.0.1]:50494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4bb6-0007Cg-AM for submit@debbugs.gnu.org; Tue, 15 Apr 2025 04:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36218) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4bb0-0007Bl-NJ for 77752-done@debbugs.gnu.org; Tue, 15 Apr 2025 04:24:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4bau-0003X8-0F; Tue, 15 Apr 2025 04:24:36 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Rutherther Subject: Re: [bug#77752] [PATCH v2 1/2] gnu: fwupd: Add elogind input In-Reply-To: <7e059e76336daf44b6808bda4d87a922553cdb5d.1744401028.git.rutherther@ditigal.xyz> (rutherther@ditigal.xyz's message of "Fri, 11 Apr 2025 21:54:00 +0200") References: <7e059e76336daf44b6808bda4d87a922553cdb5d.1744401028.git.rutherther@ditigal.xyz> Date: Tue, 15 Apr 2025 10:10:01 +0200 Message-ID: <87y0w1kfqe.fsf@chbouib.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: 77752-done Cc: Vagrant Cascadian , 77752-done@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Rutherther writes: > The fwupd package doesn't contain the dbus service in > share/dbus-1/system-service, that is because it is installed only > conditionally when elogind is available. > > This will introduce the service in the output, so user's won't have to start > fwupd themselves, it will get started by dbus on demand. > > I don't think this should break anything for systems that do not use elogin, > the only places this is used will fall back to error: > - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L242, > - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L287 > Meaning users without elogind will get error either way, just a different kind > of error. > > * gnu/packages/firmware.scm: (fwupd)[inputs]: Add elogind > > Change-Id: Id44001de6950bb6b39f1b3bba316a08ce6640fc0 [...] > The polkit rules check in fwupdmgr doesn't make sense with Guix packaging, as > it's checking if there is fwupd policy files in the polkit's store path. > This will never be true, and the check will always fail. > > One fix would be to skip the check completely. But that seems unnecessary as > the polkit actions are always in /etc/polkit-1/actions on the Guix system. > On foreign distros, it will be necessary to turn the check off manually by > FWUPD_POLKIT_NOCHECK=1. But it's important to note that this was the case even > till now, there is no new breakage. I think it's unlikely someone will be > using fwupd package from Guix on foreign distros anyway. > > * gnu/packages/firmware.scm (fwupd)[arguments]{phases}: substitute polkit > actions directory to point to /etc/polkit-1/actions > > Change-Id: Ia29d7a32f68a3da7951f45fe823e3ab8059cb670 Applied, thanks! ------------=_1744705508-27869-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Apr 2025 17:51:28 +0000 Received: from localhost ([127.0.0.1]:51674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3IXH-0008L0-2u for submit@debbugs.gnu.org; Fri, 11 Apr 2025 13:51:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34484) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3IXB-0008Ka-9s for submit@debbugs.gnu.org; Fri, 11 Apr 2025 13:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u3IX5-0004s0-4R for guix-patches@gnu.org; Fri, 11 Apr 2025 13:51:15 -0400 Received: from ditigal.xyz ([2a01:4f8:1c1b:6a1c::] helo=mail.ditigal.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1u3IX2-0001a0-KZ for guix-patches@gnu.org; Fri, 11 Apr 2025 13:51:14 -0400 Received: by cerebrum (OpenSMTPD) with ESMTPSA id b58b7973 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Fri, 11 Apr 2025 17:51:07 +0000 (UTC) From: Rutherther To: guix-patches@gnu.org Subject: [PATCH] gnu: fwupd: Add elogind input Date: Fri, 11 Apr 2025 19:50:56 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Efraim Flashner , Vagrant Cascadian Content-Transfer-Encoding: 8bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ditigal.xyz; i=@ditigal.xyz; q=dns/txt; s=20240917; t=1744393867; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : from; bh=pzv2yzLHeRGxR74licUO9GQIIyDEjwa6SXISqporA1Y=; b=Lyy+6GlfzOFRwsN9IJBx/oPl3ifSuwDLsoHVDpfoXZ9NQf0fFP2Eie0ssjjk6aZEgR1kS MiXrrRSS+dgzSr5luCIC7kX5zMQYBQ2+W5o7ftNQjXLm5+9SVYAEbiFG7fqhUA/P6Z+O+5O D1bTsI0a9dZtWkBYXNwYqiUIb/m1ztM= Received-SPF: pass client-ip=2a01:4f8:1c1b:6a1c::; envelope-from=rutherther@ditigal.xyz; helo=mail.ditigal.xyz X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.498, FROM_SUSPICIOUS_NTLD_FP=1.997, PDS_OTHER_BAD_TLD=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.4 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. Content analysis details: (3.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=rutherther%40ditigal.xyz; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: ditigal.xyz (xyz)] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD X-Debbugs-Envelope-To: submit Cc: Rutherther X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) The fwupd package doesn't contain the dbus service in share/dbus-1/system-service, that is because it is installed only conditionally when elogind is available. This will introduce the service in the output, so user's won't have to start fwupd themselves, it will get started by dbus on demand. I don't think this should break anything for systems that do not use elogin, the only places this is used will fall back to error: - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L242, - https://github.com/fwupd/fwupd/blob/1.8.14/src/fu-util-common.c#L287 Meaning users without elogind will get error either way, just a different kind of error. * gnu/packages/firmware.scm: (fwupd)[inputs]: Add elogind Change-Id: Id44001de6950bb6b39f1b3bba316a08ce6640fc0 --- gnu/packages/firmware.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/firmware.scm b/gnu/packages/firmware.scm index f04edefafe..5e89edc621 100644 --- a/gnu/packages/firmware.scm +++ b/gnu/packages/firmware.scm @@ -65,6 +65,7 @@ (define-module (gnu packages firmware) #:use-module (gnu packages embedded) #:use-module (gnu packages flashing-tools) #:use-module (gnu packages flex) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages gawk) #:use-module (gnu packages gcc) #:use-module (gnu packages gettext) @@ -289,6 +290,7 @@ (define-public fwupd gettext-minimal)) (inputs (append (list bash-completion + elogind libgudev libxmlb sqlite base-commit: 13aeb3abf9a8f4a4db1afaacdac275b5b564afdc prerequisite-patch-id: e39a216cb0ec18caa634a73b5ea378912d61ef7c -- 2.49.0 ------------=_1744705508-27869-1--