GNU bug report logs - #77746
[PATCH] sh-mode: Fix incorrect word syntax for punctuation in sh-mode

Previous Next

Package: emacs;

Reported by: James Cherti <contact <at> jamescherti.com>

Date: Fri, 11 Apr 2025 14:56:02 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #128 received at 77746 <at> debbugs.gnu.org (full text, mbox):

From: James Cherti <contact <at> jamescherti.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, juri <at> linkov.net, 77746 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#77746: [PATCH] sh-mode: Fix incorrect word syntax for
 punctuation in sh-mode
Date: Mon, 28 Apr 2025 15:28:24 -0400
[Message part 1 (text/plain, inline)]
Thank you for your prompt confirmation that the patch can be
merged, Stefan. This change will enhance the convenience of
editing bash and sh scripts.

While awaiting any objections, I am attaching v3 of the
patch, which includes all the characters we discussed. I am
sending it again in case the previous email was overlooked,
given the high volume of emails exchanged.

Attached: fix-sh-mode-syntax-table-v3.patch

--
James Cherti
GitHub: https://github.com/jamescherti
Website: https://www.jamescherti.com/

On 2025-04-28 13:41, Stefan Monnier via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
>> commit f6277911eb2c520aec8f0efd80c91999226e3322
>> Author: Dmitry Gutov <dgutov <at> yandex.ru>
>> Date:   2020-10-02 07:11:56 +0200
>>      Make xref work better on variables in shell-script-mode
>>      * lisp/progmodes/sh-script.el (sh-mode-syntax-table): Classify "/"
>>      as punctuation so that `M-.' on $foo/bar works on the $foo part
>>      (bug#25585).
>>
>> The above patch was accepted.
>>
>> @Stefan @Juri: Have you been able to perform any checks that
>> would allow this patch to be merged?
> 
> Yeah, based on my experimentation with `/`, I'm now thinking it might be
> safe enough to give punctuation syntax to those other characters.
> 
> Any remaining objection to pushing this to `master`?
> 
> 
>          Stefan
> 
> 
> 
> 
[fix-sh-mode-syntax-table-v3.patch (text/x-patch, attachment)]

This bug report was last modified 107 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.