From unknown Wed Jun 18 23:15:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77718 <77718@debbugs.gnu.org> To: bug#77718 <77718@debbugs.gnu.org> Subject: Status: 31.0.50; completion styles substring and flex are broken Reply-To: bug#77718 <77718@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:15:58 +0000 retitle 77718 31.0.50; completion styles substring and flex are broken reassign 77718 emacs submitter 77718 Stephen Berman severity 77718 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 18:22:38 2025 Received: (at submit) by debbugs.gnu.org; 10 Apr 2025 22:22:39 +0000 Received: from localhost ([127.0.0.1]:47442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u30IA-0001NA-2a for submit@debbugs.gnu.org; Thu, 10 Apr 2025 18:22:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42598) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u30I6-0001M6-AK for submit@debbugs.gnu.org; Thu, 10 Apr 2025 18:22:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u30Hm-0001vZ-KI for bug-gnu-emacs@gnu.org; Thu, 10 Apr 2025 18:22:22 -0400 Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u30Hh-0006ay-Ez for bug-gnu-emacs@gnu.org; Thu, 10 Apr 2025 18:22:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744323724; x=1744928524; i=stephen.berman@gmx.net; bh=l0QdhmYqhcvJBYMX9h2HghfuQ5lyUT2gs6vHtxRUs60=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=XHCr6T3T2Wl0t5wMrWEsf/V1FAt7vcxjphTln8t+XjOylpEdOROyWiwI/fiztRgG J04T7oKpPDADuZSsJUE0L+itj5xE6N+WYnwBGr8A6bGKoIJ8ee7Etl5h/IZo8IXa2 kKsjD/YVtEn24tPWivlBLg6qEP1vJPVeq2n/PH7s0r4HkDrR8cGNaewmIQY33e9kQ tdV4ze44CP0NBNJ2E7UO0nKgWEIs+pKIhv/FughPXvISa9TEPThrOAZEE7Z07bdRE 919sSOClpaDupTLR7XuxRPeXx8M7/rrvVV2GHZcsWlv/9HABENewjiFelXvsJ277Y ioucTAIjtMW0FH34BQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.12]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MowKc-1tGFfu2qX0-00oChA for ; Fri, 11 Apr 2025 00:22:04 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 31.0.50; completion styles substring and flex are broken Date: Fri, 11 Apr 2025 00:22:01 +0200 Message-ID: <87y0w7ejxy.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:MowRBtdUMBpN1HDiqagIyU9xgd5jhlPvGM8z+vQ8nkFRcVSQ5Ct gTWp5ffQt4iMh4hGetCOvUjfsJhzjecTtkeOFwAm0qBsrNbPY7BzHdH2UIgpPgctTnOAMqd lfuyKpTvg/7ACBB0nH9R6NpReujzI/iHoX6GkPDovxHepTpVOJyYrxuc2vxauyTJuOYoZj2 5eIhvXkbSaT27ZHZfTawA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HEC1wKt1kgg=;t+pTiJGrtGK0RGKCOlgbLDEsm30 dzMLwRNVvf32RKaiKYwrszKCSAOBfIf2hzFQw7XSKQKTtw8ItsDrnMagTJRy4PXm25Jd053us 1OTDsJlhZmmZMLMzQLZN9v24TqDL7uoXQDy6r2tM8fZfpNOlhXH5+UEqfjYA0uHUoys/ayfwm H3uQ7KscvoWMtx5NAagrNMY40vfOMaLXQ9E595Ncm04OMj5qyFNJtrBg1zj4Viogb8W6PhTuB R04nFKmEWZM7stIgWVF5DsyJ7bmzRI6VpZGU2XsQnxB/GO1QA7mwbMkMU1ERORLnOYx0oPE+x CbFxhKYRK8NxlobGYypUzcWU2ZGqVtFPW4Ly/B8hV1/LyWpB9KF8DLuUFdMpMhnhUTXYwtYUb jgT6uSFRh6eOb6J+SSKh3jvN3ZS7gbLJ010DQljeJmgTPlzSxdJhzduoQVBW0xhT6j4/6ZolM wMoiFrL9g9jRLjGeYAzmCayBeUJnyn68mIE4oKAHYke/J0mikx06iwjkT6puQ9tyVUKuUWi7k J0R8W/PaCoZ8ydU/7aKaRhED2V9mJlUwGqbNQm/zKrRbYbEOP6OArJe8p7Mp0ivho6dI4hBWd 6Rdz1tEd/oDrkaVFdYQ6geaQb/pqGzXFUCu1FimkQOyty/W/uDNAJdyJGWSpHivzm81CjrGsw JPCFux1PIFzrsbPnhSnYATZCxWCt3+w5o009WukCPBe/un+x7g6Zzo2DSH1ZeLFEYoLyLijtO 5jiA91Rm8WApHBf6WzH8mZ6bQqPKhMNr8U3VgcnLYwkSz9eL9q7fynGN8ihARGZmumCIOgW01 //VVouAdd1B83KjYQJD5ct95pGYzzA6ats2y2ZMCVB6wt5Tli9bSemSXDcd63kysrRcGS7285 QMILxSOczb5Z68am7bRjbnw0lYjnhYreOn/oZLGQpt3T41e6aXwIGW5oScnJ8jbmnqj3KmyFo HlH3QqkYqVvVNuSF9yCKx80qzM1ZFl/4nKpSx6WxsuPF1uJ0h2WxjsSOlR7FveSFEcf3ChrQu WYudsHVTvjD/GZPe9w3PRPTUtLe+oJcFEQ3QIgKMFTBRZCw+ohaaAHQVbPt4hENfSdwNe/D1J eVD3wSoz1wh/bZ4utuOSka8oS6eWtCG2mR3AC49KEFb7Og2VHv0ylw4xxPqW2ki4zdhV71TNU JVM3aNHoFDOZJfVAckbAoGP+eldzuw/rnayn+d2U6enik4Ot+vzHigYeRA+bkRc+hX+knBCF/ omMtKT5ASyuVr/6dpj0N/Tbpe59FTOUejPC7u21TClXAqD/k6svW3JsySPJwc0l8fHFJTiBwN /4V6tUNkzLp3tt5+lTthaPf6Jnvobr/qCFfyg7N+yQM3uP+GhdygR9nd/pCsj+4l6XS+JrWuh u6eo+J5vLGLwKlu6nqQ9yMsdwNy6oT1WfqECc7G2lV/bgWq4d10n1Bqxdy+sXx7B+kJFUTvjh UGnkW7KTx5AFzG4HwSMP3nH5k1LViRYzcTH/QryDsGyDidPsgTwYuRDvXs5lnL3YiWm+/v4lh gcIF2SE8oPgVVJYjOwRHZqVTIBwozs6+nqnegwvJugWVuJkonQ+zw9iuV2LKsZvEM1AZHedlu JpBwe/tKU2mlIm+afhcyxz47PxVbLAHWb0X9p2HDfQj/r5VheTWLnCvQTDraCYBo1lIjhJK/5 eX0RCGmalaGYZGDf2OaWDn5yROsDT8yBnkdTjEYUuM9yDwFkCjbFida3tUE90ZQnnodxY2XbS nzwIrBIkPAcKupohQEOi5ZiXEIS336S6IlAeG9jTs3YYOoplZLwMFVyG4tV2NfJoPJGgNXULX VwvkhjL1E42eBjnVzXhz1JBwK7D95NoRVWeUtz2zU32Q7SRJ8qASY8SPu9t1GHERcexvpuZ5b MtXj1cAEIxTAmurqVCkanlIRyTI3/ddGpYBaYuWzFx5IgK+j+aP3oIKq2EGPqOhsgGRigmy0W EvpAg4VLact+/vSB3/UG6oGifd0QjIx3FQ6gamLzpuH4yQE7XtOqlLbZsxm8lk+S8XDLusbaN 7MT0wMjPzuFqlHDVcFh0Zlk8huZj97uG1t5iPCuK/SPvWuZ1RTbf/XZVVG3OOAxRLlEcrTAfP ZkGWgvlhz/qJYB2mSsM9plzq392uGR7AnIAu7/+/Ynb0kVdfBBalgBudW3W1AnZqiEB59Hz/M X9jYAQL3Xq8/vPqp9toVIKzGmhliu/Ouwjj1QrtjKbR7J2oEGetf03pL+ARpabCABdLEOUqjg ZNT4BQfPnqLeBNuOPPgL3OpqrlBpX7dDKqwDk6PteHFzjv37q32+RsV+ByKDUCrDZGXjh8bDi svXXpS1GuRXEOhIrLY6HLH+NQE0HVP6ecGTZ5nHLaXGJnyxQdmnZWCnRA9unnIRXddzR6jQOe CdGB/kmCBw5AiurBMuqDZ2FrR+v4OqH7m+m2fW/QvPxSzMmj0juN4KxKICuUDDW1c9yqDYcSj 8xcqzRIT6TBODS3YXBxHdQOrzQ42Y6PRXvVx5nXxfcFITxVBIp2EQg4C/T1ngzUDa6y+XJmT8 8qbV41g6O/lo6Ik8GyB4y4GJxARD/4zi4HkfYeREt3Hl3RCXofbKlLub+qvZLADJSzsUTspFk WaZ/VruvXh/gXxlayOnquamuRLpfAioItasWVKa2lbvGtGd+sNLUQK2CjIOZRbUZNpiP8AyH4 mVF4l05dSSOM3jD/bfm53ZfNvPQdUvLXDMv6cLRyAgpfWtYB7t037BF1tjCqQa9TI/EALuUGv O5312jWvqeyw0Pun0kyu6myqjmLnFlLERsdOePqpdwdrXRBbKVK4PQoIOngjrN4fAXKqcO59G 4il2uHn2kv+Y2YA7uhawjGObjlkmS7S30nXNXQTAbnbPYXMLUHvjY3ns+dgvEZf07iOHI5O25 FvZ3TL6mFWnOh07ufag3gbi84g1chNDTqsozYXsZ1zQimYnl4S/gD1m3J56hZ2E3GcUaPmcSo x75ZvA8+XPEv0PdEQXhRwzGSdFcZTb3y36oww2LLnO8nBcdHJjdLJNzM8UiBTyh8TEqA5hZX9 Wv+eZd0EcSQOMuZssBsx2ybCjyKbutcvDT4gMEXllF6 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.17.20; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 0. Start Emacs like this: emacs -Q --eval "(custom-set-variables '(completion-category-overrides = '((file (styles substring)))))" or like this: emacs -Q --eval "(custom-set-variables '(completion-category-overrides = '((file (styles flex)))))" 1. Type `C-x d' and at the prompt enter: `/usr/ TAB'. =3D> Now the text following the prompt is this: "/usr//" and "/usr/" is fontified with face file-name-shadow. 2. Type `TAB' again. =3D> Now the text following the prompt is this: "//" and the first forward slash is fontified with face file-name-shadow. 3. Type `TAB' again. =3D> Now a *Completions* buffer pops up listing all the directories directly under root (dev/, etc/, home/ and so on). This only happens with the substring and flex completion styles; with any of the other completion styles (basic, partial-completion, emacs22, initials), or if Emacs is started just with -Q, then after step 1 as expected a *Completions* buffer pops up listing the directories under /usr (bin/, include/, lib/ and so on). The broken behavior with the substring and flex styles is due to the change in completion-pcm--merge-completions in this commit: commit 0fbba16387513e7692b46885833e4a9c218251f0 Author: Spencer Baugh Commit: Stefan Monnier CommitDate: Tue Apr 8 14:36:30 2025 -0400 Preserve an explicit * in pcm-try-completion [...] * lisp/minibuffer.el (completion-pcm--merge-completions): Don't drop important wildcards. (bug#74420) In GNU Emacs 31.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) of 2025-04-10 built on strobelfs2 Repository revision: c0ea954d0f650227dc518f02a292daeb27cf0c37 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101016 System Description: Linux From Scratch r12.3-20 Configured using: 'configure -C 'CFLAGS=3D-Og -g3' PKG_CONFIG_PATH=3D/opt/qt6/lib/pkgconfig= ' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR GTK3 ZLIB From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 03:23:03 2025 Received: (at 77718) by debbugs.gnu.org; 11 Apr 2025 07:23:03 +0000 Received: from localhost ([127.0.0.1]:48420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u38j8-0007MP-MU for submit@debbugs.gnu.org; Fri, 11 Apr 2025 03:23:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38292) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u38j5-0007Lp-3V for 77718@debbugs.gnu.org; Fri, 11 Apr 2025 03:23:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u38ix-0006kB-Hn; Fri, 11 Apr 2025 03:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xSksW5hxieoxbyzZsRSfeizWKGzxY3vIWb/J84izhT4=; b=q5btHb0POv49 f2IlaRKOG2bzOGRu0KQT3cnDmP6NnuPmntSSjzfdnRMkUEi1+ahC571rYbbdKiBpv+PfG2X/ADo7p GCu9LaeE/2wUQllv2dChg+e7vrAoitohcPL1dqVZhll46YkA8g1RymUVvKUFxp1why0MlvKLsXYOZ RF1+wcDnSshsixiqc+fh5Fh+ljvX4nVryeWY+NxhVnRKa9bYlu0IQ4gHXpFYCZe/TdO/WNHlt6A0w BIDyF+aBas+WK9Iie7xucjpg7B1YTigBpt21SoTDJVT0JklZqHB/ANHTY/aBSUyLzMRC+d5xMUNdb yG+rSSFRBzEQKNAkN+6/QQ==; Date: Fri, 11 Apr 2025 10:22:46 +0300 Message-Id: <86semfp3g9.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman , Stefan Monnier , Spencer Baugh In-Reply-To: <87y0w7ejxy.fsf@gmx.net> (bug-gnu-emacs@gnu.org) Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken References: <87y0w7ejxy.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 11 Apr 2025 00:22:01 +0200 > From: Stephen Berman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > 0. Start Emacs like this: > > emacs -Q --eval "(custom-set-variables '(completion-category-overrides '((file (styles substring)))))" > > or like this: > > emacs -Q --eval "(custom-set-variables '(completion-category-overrides '((file (styles flex)))))" > > 1. Type `C-x d' and at the prompt enter: `/usr/ TAB'. > => Now the text following the prompt is this: "/usr//" and "/usr/" is > fontified with face file-name-shadow. > > 2. Type `TAB' again. > => Now the text following the prompt is this: "//" and the first forward > slash is fontified with face file-name-shadow. > > 3. Type `TAB' again. > => Now a *Completions* buffer pops up listing all the directories > directly under root (dev/, etc/, home/ and so on). > > This only happens with the substring and flex completion styles; with > any of the other completion styles (basic, partial-completion, emacs22, > initials), or if Emacs is started just with -Q, then after step 1 as > expected a *Completions* buffer pops up listing the directories under > /usr (bin/, include/, lib/ and so on). > > The broken behavior with the substring and flex styles is due to the > change in completion-pcm--merge-completions in this commit: > > commit 0fbba16387513e7692b46885833e4a9c218251f0 > Author: Spencer Baugh > Commit: Stefan Monnier > CommitDate: Tue Apr 8 14:36:30 2025 -0400 > > Preserve an explicit * in pcm-try-completion > [...] > * lisp/minibuffer.el (completion-pcm--merge-completions): Don't drop > important wildcards. (bug#74420) Thanks, adding the guilty parties to the discussion. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 09:03:21 2025 Received: (at 77718) by debbugs.gnu.org; 11 Apr 2025 13:03:21 +0000 Received: from localhost ([127.0.0.1]:49490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3E2S-00044I-Ky for submit@debbugs.gnu.org; Fri, 11 Apr 2025 09:03:21 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:55185) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3E2P-000443-KL for 77718@debbugs.gnu.org; Fri, 11 Apr 2025 09:03:18 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <86semfp3g9.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Apr 2025 10:22:46 +0300") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> Date: Fri, 11 Apr 2025 09:03:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744376592; bh=cUg2T6YtXqy6vhR7N0OeEwM4x63joJL9Lp5RoIC2qw0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=tx4kXTqnHPONaIn6DTQYq+/rPeTwa85rlb94e9QNVdvem5VFkUaknp+I9Fv7vjgZj 8MwzWlTDU2XZMqOl7g2FWMYqA1ZwTHeN1ekSMDCGJgKGibjCYKV8M8JbgJXXXwMRgv PoR1CihO4GH/PZ/aUmWGSO0ai1Kz5rM7WURcuM3mGuwJl+b14t7w9Vug2xpYp/cHVC g+vEmo4T7SD+rQU6H3e9vZdaRANasC7/z3E/mw7d864qB/YGNf7wbrJNApFAMfKkQm HrImVE0r9bLa1yKZ10GiiiFkklNlDSROhb3pRZaFGlJ9A+h5p+ySAo47uK8e4Z3k6v IGSUUaHXZcEvw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Stephen Berman , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Date: Fri, 11 Apr 2025 00:22:01 +0200 >> From: Stephen Berman via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> 0. Start Emacs like this: >> >> emacs -Q --eval "(custom-set-variables '(completion-category-overrides '((file (styles substring)))))" >> >> or like this: >> >> emacs -Q --eval "(custom-set-variables '(completion-category-overrides '((file (styles flex)))))" >> >> 1. Type `C-x d' and at the prompt enter: `/usr/ TAB'. >> => Now the text following the prompt is this: "/usr//" and "/usr/" is >> fontified with face file-name-shadow. >> >> 2. Type `TAB' again. >> => Now the text following the prompt is this: "//" and the first forward >> slash is fontified with face file-name-shadow. >> >> 3. Type `TAB' again. >> => Now a *Completions* buffer pops up listing all the directories >> directly under root (dev/, etc/, home/ and so on). >> >> This only happens with the substring and flex completion styles; with >> any of the other completion styles (basic, partial-completion, emacs22, >> initials), or if Emacs is started just with -Q, then after step 1 as >> expected a *Completions* buffer pops up listing the directories under >> /usr (bin/, include/, lib/ and so on). >> >> The broken behavior with the substring and flex styles is due to the >> change in completion-pcm--merge-completions in this commit: >> >> commit 0fbba16387513e7692b46885833e4a9c218251f0 >> Author: Spencer Baugh >> Commit: Stefan Monnier >> CommitDate: Tue Apr 8 14:36:30 2025 -0400 >> >> Preserve an explicit * in pcm-try-completion >> [...] >> * lisp/minibuffer.el (completion-pcm--merge-completions): Don't drop >> important wildcards. (bug#74420) Thanks for the detailed bug report. Reduced slightly, the issue is that (completion-pcm--merge-completions '("x/" "y/") '(prefix)) now returns ("/" any prefix "" "") when it used to return (any "" "") I think this may be related to the implict "any" added by completion-pcm--merge-completions. I'll look into it and find a fix (and add a test covering this case). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 15:43:27 2025 Received: (at 77718) by debbugs.gnu.org; 11 Apr 2025 19:43:27 +0000 Received: from localhost ([127.0.0.1]:51833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3KHe-0005Uc-SJ for submit@debbugs.gnu.org; Fri, 11 Apr 2025 15:43:27 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:41145) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3KHc-0005UI-Ce for 77718@debbugs.gnu.org; Fri, 11 Apr 2025 15:43:24 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Spencer Baugh's message of "Fri, 11 Apr 2025 09:03:12 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> Date: Fri, 11 Apr 2025 15:43:18 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744400598; bh=GxA76DkoznxhbDcdZQ8VePv5IYzWl0ptkngY09Wq8ys=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=rHoI0GwM3U8JFgClphp30/9YWZBSZu7PrpDnjoAPBVr7yR1EhEEbFKjv4YiWFhMer BOHqQp2VDZwc2HRGgb9aA2MT2RLE8UCIsKLYiV/xIGd5H/bk6scuF23J1Hjc9Y1ZV4 BicfNTYn2Lg+Nw4gfaxBLFHy5/v0k+O2aa6lUTlMQxKWrBFHLafsNti67Hpjp1vZ/m QAIeCzf5vuXrTyXPhEAu5hHVS/p/oZv+pBtXMhAno/GNuxly8BWe056KhO+EieCpiE uj3oOT0VHG88IGftiSM21rwxmKzfzOd6rovzVicwc1YC9Swvou4mK5I997f+wHphaa NiqK9n2GSvVyw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Stephen Berman , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Spencer Baugh writes: > Reduced slightly, the issue is that > (completion-pcm--merge-completions '("x/" "y/") '(prefix)) > now returns > ("/" any prefix "" "") > when it used to return > (any "" "") > > I think this may be related to the implict "any" added by > completion-pcm--merge-completions. I'll look into it and find a fix > (and add a test covering this case). Update: That's not the issue; this new return value for completion-pcm--merge-completions is actually correct, it's a desirable consequence of my bugfix patch. The issue is actually in completion-table-with-quoting, with filename completion and substitute-in-file-name; it doesn't handle // properly. I'm trying to fix it; it may be a somewhat large change to completion-table-with-quoting. Stefan, a related question: do you think it would be reasonable to split completion-table-with-quoting into two functions, separating the substitute-in-file-name and comint-quote-filename cases? It seems to me that the comint-quote-filename case is way simpler than the substitute-in-file-name case, and it would be a lot easier to understand if the two cases were done separately, without the abstraction of requote and unquote functions. I can do that if that seems reasonable. It would make fixing this issue a lot easier. (I don't think we need to maintain the same interface for completion-table-with-quoting - I see no usage in the 200 packages used at my site - I strongly suspect, given the complexity, that the only users are in Emacs core) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 17:38:03 2025 Received: (at 77718) by debbugs.gnu.org; 11 Apr 2025 21:38:03 +0000 Received: from localhost ([127.0.0.1]:52037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3M4Y-0002f8-MK for submit@debbugs.gnu.org; Fri, 11 Apr 2025 17:38:03 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:4081) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3M4W-0002eJ-Cw for 77718@debbugs.gnu.org; Fri, 11 Apr 2025 17:38:00 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B1CA68075E; Fri, 11 Apr 2025 17:37:54 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744407473; bh=r9i1LWPK5N1G6jVJYfib4X6wJtYt716XZmv0dGQDMkg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=pQLGH9GgDJE2TqCYe0NbkZ8OHCQiuVutem7Bw96NEG+qeBVA+V3ipZU/rFFIUyC8J jlpx6uhvxEvzmrAXo5YwiPU20RGjcdTwpMKndpuS6Ecf1011CpCLcclhS8nW2VZ5v9 otMFQcIBz/L80myoWgHdDzIlupW6ZPjS3nmYfTDhmZ3kXYPQxtMI5vX1G/iR9ENiWj F+AXvNaZmhJAgB0uO1a1Hu4koUaBPM3YcxgWrEkKo1pLFm0aN7Ewf8s9ee7opxpxXA JBCNJxllsOWmz4IX8V3+ZmJnOQINrlfxe6Sa/cPRL7DaoIa056JLYxLpaxtThm3uJU V//jhSngLDG/Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E8662804C9; Fri, 11 Apr 2025 17:37:53 -0400 (EDT) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B9CCF120491; Fri, 11 Apr 2025 17:37:53 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> Date: Fri, 11 Apr 2025 17:37:52 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.363 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, a related question: do you think it would be reasonable to split > completion-table-with-quoting into two functions, separating the > substitute-in-file-name and comint-quote-filename cases? It seems to me > that the comint-quote-filename case is way simpler than the > substitute-in-file-name case, and it would be a lot easier to understand > if the two cases were done separately, without the abstraction of > requote and unquote functions. I can do that if that seems reasonable. > It would make fixing this issue a lot easier. It's worth a try. The system we have is the best I could come up with back then but is hideous, so I'm interested in a simpler solution. > (I don't think we need to maintain the same interface for > completion-table-with-quoting - I see no usage in the 200 packages used > at my site - I strongly suspect, given the complexity, that the only > users are in Emacs core) It's definitely not worth worrying about that while designing a replacement. Maybe we'll want to preserve backward compatibility, but let's first get a good replacement. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 14 16:30:18 2025 Received: (at 77718) by debbugs.gnu.org; 14 Apr 2025 20:30:18 +0000 Received: from localhost ([127.0.0.1]:49214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4QRd-0000Ce-UZ for submit@debbugs.gnu.org; Mon, 14 Apr 2025 16:30:18 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:48551) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4QRa-0000B1-Vf for 77718@debbugs.gnu.org; Mon, 14 Apr 2025 16:30:15 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Fri, 11 Apr 2025 17:37:52 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> Date: Mon, 14 Apr 2025 16:30:09 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744662609; bh=fTifyt80EbSPRduNoqRshB/oGomZMswTa9QmFWbqIIk=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=SXwCLNtfiMvDBJFOSucm/7wcw2FUYCJ2OpbPJlnsoXVVLC9JpajDQv1cwQdI1icCj 1WqzmTKQCu+7dwua42LP4wdC0gA2hwW+PWlqpwNR6BpwK7+7UOM8TVb5t92pUDUvc2 7u1t4fbwOqW2JFE4QhimF6pVYdW9Z6XXU5XYH28Xn0usSfa7RpSHoNLMkf3MytTkMB 92MVeZ0LnyoNrCUzv8OSmG+Na+FsuKGJgXq3U0APSy5VFGkr39fKS9fOIRS/A34DLP gT3vELZlHKqWG6An0tRNdvR+s+ODFQEMD8LTsxTsADbD+Suh/Z0L6U7UoTWy1oGier rDOCtRnkwKdUg== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> Stefan, a related question: do you think it would be reasonable to split >> completion-table-with-quoting into two functions, separating the >> substitute-in-file-name and comint-quote-filename cases? It seems to me >> that the comint-quote-filename case is way simpler than the >> substitute-in-file-name case, and it would be a lot easier to understand >> if the two cases were done separately, without the abstraction of >> requote and unquote functions. I can do that if that seems reasonable. >> It would make fixing this issue a lot easier. > > It's worth a try. The system we have is the best I could come up with > back then but is hideous, so I'm interested in a simpler solution. OK, here is a rework of just the substitute-in-file-name side. This fixes this bug (by making completion continue to work when point is at /usr/|/), and fixes another FIXME in a test (partial completion now preserves environment variables!). And I don't think it loses anything important, but I may be missing something. (completion--sifn-requote can now be deleted and there are probably other cleanups possible after this patch, but I didn't do them here to keep the patch smaller. Also, rfn-eshadow needs to be updated, but that's just a visual issue.) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Improve-env-var-handling-in-read-file-name.patch >From 48653fd0b22739f6d836bbe121989f5051502d81 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Mon, 14 Apr 2025 16:01:38 -0400 Subject: [PATCH] Improve env var handling in read-file-name Fix various bugs, including bug#77718, by rewriting the way file name completion handles environment variable expansion. Instead of using completion-table-with-quoting to manipulate the string being completed on, simply make the completion table itself understand substitute-in-file-name. The completion table first tries to complete without substituting environment variables; this allows completion to work on file names which contain things which look like environment variables. If that fails, we call substitute-in-file-name and then complete again. Tests are updated: we no longer duplicate $s in file names, since that's not necessary. And partial-completion now preserves unexpanded environment variables. However, partial-completion no longer works across environment variables containing delimiters; that's an acceptable sacrifice. * lisp/minibuffer.el (completion--replace-prefix): Add. (completion--file-name-table): Rewrite to use substitute-in-file-name explicitly. (bug#77718) * test/lisp/minibuffer-tests.el (completion-table-test-quoting) (minibuffer-next-completion): Update. --- lisp/minibuffer.el | 43 +++++++++++++++++++++++++++++++---- test/lisp/minibuffer-tests.el | 16 ++++++------- 2 files changed, 45 insertions(+), 14 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index c0ccfc00ce5..4ccf3a1d2f9 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3596,13 +3596,46 @@ completion--sifn-requote (setq qpos (1- qpos))) (cons qpos #'minibuffer-maybe-quote-filename))))) -(defalias 'completion--file-name-table - (completion-table-with-quoting #'completion-file-name-table - #'substitute-in-file-name - #'completion--sifn-requote) +(defun completion--replace-prefix (s old new) + "Replace prefix OLD of string S with prefix NEW." + (concat new (substring s (length old)))) + +(defun completion--file-name-table (orig pred action) "Internal subroutine for `read-file-name'. Do not call this. This is a completion table for file names, like `completion-file-name-table' -except that it passes the file name through `substitute-in-file-name'.") +except that it passes the file name through `substitute-in-file-name'." + (let ((table #'completion-file-name-table)) + (cond + ((eq (car-safe action) 'boundaries) + ;; Boundaries are always computed on the original string. + (complete-with-action action table orig pred)) + (;; Ensure we discard text before // by always using sifn in that case. + (unless (string-search "//" orig) + (complete-with-action action table orig pred))) + (t ;; On a nil result, complete again after sifn and adjust the result. + (let* ((expansion (substitute-in-file-name orig)) + (result (complete-with-action action table expansion pred))) + (cond + ((null action) + (if (stringp result) + (completion--replace-prefix result expansion orig) + result)) + ((eq action t) + ;; Find the part of EXPANSION which is inside the boundaries, and + ;; replace it with the part of ORIG which is inside the boundaires. + (let* ((expansion-bounds (completion-boundaries expansion table pred "")) + (expansion-in-bounds (substring expansion (car expansion-bounds))) + (orig-bounds (completion-boundaries orig table pred "")) + (orig-in-bounds (substring orig (car orig-bounds)))) + (if (and (string-empty-p expansion-in-bounds) + (string-empty-p orig-in-bounds)) + ;; Nothing to replace, so avoid doing unnecessary work. + result + (mapcar + (lambda (s) + (completion--replace-prefix s expansion-in-bounds orig-in-bounds)) + result)))) + (t result))))))) (defalias 'read-file-name-internal (completion-table-in-turn #'completion--embedded-envvar-table diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 59ac5ab9578..38c005bd1b5 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -91,20 +91,18 @@ completion-table-subvert-test (ert-deftest completion-table-test-quoting () (let ((process-environment - `("CTTQ1=ed" "CTTQ2=et/" ,@process-environment)) + `("CTTQ1=ed" ,@process-environment)) (default-directory (ert-resource-directory))) (pcase-dolist (`(,input ,output) '( - ;; Test that $ in files is properly $$ quoted. - ("data/m-cttq" "data/minibuffer-test-cttq$$tion") - ;; Test that $$ in input is properly unquoted. - ("data/m-cttq$$t" "data/minibuffer-test-cttq$$tion") + ;; Test that files containing $ can be completed + ("data/m-cttq" "data/minibuffer-test-cttq$tion") + ;; Test that $ can be completed + ("data/m-cttq$" "data/minibuffer-test-cttq$tion") ;; Test that env-vars are preserved. ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") - ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") ;; Test that env-vars don't prevent partial-completion. - ;; FIXME: Ideally we'd like to keep the ${CTTQ}! - ("lis/c${CTTQ1}/se-u" "lisp/cedet/semantic-utest") + ("lis/c${CTTQ1}/se-u" "lisp/c${CTTQ1}et/semantic-utest") )) (should (equal (completion-try-completion input #'completion--file-name-table @@ -690,7 +688,7 @@ minibuffer-next-completion (completing-read-with-minibuffer-setup #'read-file-name-internal (insert "d/") (execute-kbd-macro (kbd "M- M- M-")) - (should (equal "data/minibuffer-test-cttq$$tion" (minibuffer-contents)))))) + (should (equal "data/minibuffer-test-cttq$tion" (minibuffer-contents)))))) (provide 'minibuffer-tests) ;;; minibuffer-tests.el ends here -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 02:25:52 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 06:25:52 +0000 Received: from localhost ([127.0.0.1]:50210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4Zjz-0006qp-OF for submit@debbugs.gnu.org; Tue, 15 Apr 2025 02:25:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60386) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4Zjx-0006qd-VM for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 02:25:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4Zjr-00046R-AQ; Tue, 15 Apr 2025 02:25:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JxWHBPSUROWuyT5AtBA6sddYMc7CNqXNAy2ycosiE40=; b=BKKHKrIX0GOW HMRBc0e2lmegXcw8ZG7DTIp0Esp7pQXVtnOY0I7YHccQAWYwonHlIo7nsnB9d4zcJ66f4QqsrU5Y6 UM+1lYZ5tLKedCIY2M9aXwjWaKd1PWxgrEl/IAv3xxpQK1D/dlC8EPbVf5gVvqPAssBZaQMDaRGVB B+ozqPB+/PPhEq/GJKtEuIUffO0ecJHE6P4yMNWkQACEfHizhNBUmh0eyCui47PMEFjHTKUMBJm8l ZkwpPjDQLwVXsXHit6PFaZyQrls7y+hMWyn7xRtHNSwrOR7PzZGEKWjlAmXgz9InzvWEud3x0yBnn tH1fB6aaxm7UCluSALbgNg==; Date: Tue, 15 Apr 2025 09:25:39 +0300 Message-Id: <86a58ihrfg.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Mon, 14 Apr 2025 16:30:09 -0400) Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman > > Date: Mon, 14 Apr 2025 16:30:09 -0400 > > + (;; Ensure we discard text before // by always using sifn in that case. > + (unless (string-search "//" orig) > + (complete-with-action action table orig pred))) AFAIU, this ignores the case of UNC file names, which begin with "//", and other complications with file names on Windows. Emacs on Windows reacts differently to "//" than it does on Posix systems, and it does so for very good reasons. Please don't break file-name completion on Windows. It took us many iterations to get it right, and the result is fragile. Be sure to test each change on Windows as well before installing. For the same reasons, please test thoroughly with remote file names of different formats. Given the fragility of this, I'd tend to suggest to define a new style with these changes, and leave alone the existing styles, even if you consider them "broken". From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 04:22:28 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 08:22:28 +0000 Received: from localhost ([127.0.0.1]:50467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4bYq-00076V-5G for submit@debbugs.gnu.org; Tue, 15 Apr 2025 04:22:28 -0400 Received: from mout.gmx.net ([212.227.17.20]:40819) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4bYm-00076D-Fr for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 04:22:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744705337; x=1745310137; i=stephen.berman@gmx.net; bh=AIg4QSqgHd86vPxGLPUi3gjkx90vQK559n603F+O2Eg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=c7tNQZ2GINn7zoPsk4lpbRV1ut7BfqM6GpFqrgOjQIqJjDmuR1015Uxjo6YLXwM8 X79TSevtJ1L5F6b6/jAEDAxwPI7h8HI6jhv9eGryyHCU17vSEJj3KwmFsRV+lhLZM Ub9eQyGs+sRpOT7ey+T6MBE70DtoZM2KD4uQF9RpJtH+aQ7RN2k4IUrJr5GFBEzBr p3uJ3rt5v/FIT2FjfSuCf7IRjNXUuq4YIHNDdaRl18VqOv6bIywaL1Mhjshq8Dr49 2yidmKSlYp/9qjAG/DTJmW9aT6nM5K6DVYTvqRO2ouquXx7s6eySE104uhVe0TyHC /yykP2wJx14+E5DbrA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.70]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N8obG-1szB1D2etK-016HTW; Tue, 15 Apr 2025 10:22:17 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> Date: Tue, 15 Apr 2025 10:22:15 +0200 Message-ID: <87a58hal6w.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:21YslgaZfUCYz0FtfqJkVKBWYYCDA9O0SFmYPPyRR3BpGpD0My3 IbCw3mXykaSjgWsm6noy6mz1sUxlkomyVHp8Zd8ab+YunPVkLtE1CnTJKXdc7BCZT70k1t4 Yfe0H0htGVSxCVm9U2cGypkGsSq7M52f0mYBoxr1+5WCwa+rq2sHp8NdlCTmpTnNgRgRy0w LzTKLf/4ZwIg8o/HgZ0fw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:TAJrj4/+fCU=;OeyqPfdw/esiTJP5koFtFLe5dT1 LHNlAS0Z0Xa5BBE7r7vhw5w8+cMRKw8+M1p5WY89Ebsc9FiBAGtlmtxi4Ybj3zAlJtXjJpCQX lY2AYZbd2ZYPX/CsN/DSZFkHG8pQ1ghcOLqIvz1FJpDgseL/B7N7b5kBHK9fOFH/WxJJZ68D3 LScyADwajKvCz+0MlWJYtci8+Lnra8/3gBWbZYgS2ZnwwBgBCbPy+jtlI+2F6KhNylSYweSr+ ByAJV4IvXzIFaQ2uHCpZyVwdSvM+wTpSJ99jQv6xnz/q7bAU69T2agBRf4JNHmh3FTO/tc2ic Tfuz2Rt90cFq6Qkzw3/bBqCG/mhrZHI6QHXoPBFPP8auUgikpMtdj+l4czL3jQVG9fi4iXv2Z YBet36cSD99z93aJ9w6OHIF8KIEyE8qoS2Iz+lNXEE4gZ/0Wzhmish2+Mhw8STPMxYwLao4vz amFqfxyEp/wtymdhiGNE0EsS9EyV3+tnlEhkr8n+yVXDdbUmP1WCHOMe+lWkZLzWnm0WdYBKd VuueEDZyyHxJVbCOQd9KUvdocIVC6wLMYPbTQkFXzP7KVeE/43b4DMnCteHpB8nCAb2Bq0Idm HjYne0YiDVX2D8eLpqWuSlSdf6IwlgcPU7INJoaSNl0ZQQuiaKj+c7hrSd4ev7V4BtxlalHAU Xfl79lSBZIy4NAN+4gGpzdAlj+89b2Xk1/OKfWgC/sINXN7XF8ZQszalsJSoQuvvgRZbsEZ6E uv4JOIhNhBLg1x5dP7tl27tdtYjX+e2jGbIdZUY+IlQNaEu88rHcdzdgytZx2VmEtZeEcoohF XGFiK4bViY7spjH/xVqfWDMPRnelGHeX0XyTUj3tWkkdhA+3JME5QImT8Fd0D/dfvy3J8T4UZ 7MaLaJbZlshCCyLSSP/JPqL/5mJfiJgERmvMvkP2guQM2JxUsTXePrLCl9mnTcKc94cpzJy8E XAh4BSc0Ct9ujzbX+442htYZGsZpe5aeAkPZpgwt8gV2n8qa+ZpT4q3vbosFHkQH1SSJ0jcFS 4CihImAvr+urqn6hqEa/WQiH8yoLNjjnq1+FMutJdWwlnbTAYipgyMKnnUVSkgI+i2V7U4K6v 0uSLjfybo5sZDx7tt4A3uzKagPVNVZwLd/VrOGZ3n26I/gU1OUWR2SFQBQ4m8rohd3V5/G+Ec P+wuCO9uhFgaQaPllzrd79rcsCvTArcnSxsRk2awSz/1izsPkaUZjxqg1Of1NeiNKfOmr/5I4 cy/MVH4jvM1ZMSjfRg8jZqdsF2jYPRPbyYWRLsdOS12iMYGKqcwyosyB2XnhqqaGMBqNDxLhL MeOLVpUvYW3Pzn1P8uKTvqo6vzjpOBgD3zwsnZZ5mBxcXYKHtQLcpicGQhzRyZcqhgR7F6X2X GMzzpGhB18yQmZhkqXnZEe68RbzYyAZ6bhg9RNS8xMc4mGOu+Df9/MI2sDgQjKUEMOmBiuTYz REq6ccbD1aHaftIOhSiq+eHL5D/c= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 14 Apr 2025 16:30:09 -0400 Spencer Baugh wrote: > Stefan Monnier writes: > >>> Stefan, a related question: do you think it would be reasonable to split >>> completion-table-with-quoting into two functions, separating the >>> substitute-in-file-name and comint-quote-filename cases? It seems to me >>> that the comint-quote-filename case is way simpler than the >>> substitute-in-file-name case, and it would be a lot easier to understand >>> if the two cases were done separately, without the abstraction of >>> requote and unquote functions. I can do that if that seems reasonable. >>> It would make fixing this issue a lot easier. >> >> It's worth a try. The system we have is the best I could come up with >> back then but is hideous, so I'm interested in a simpler solution. > > OK, here is a rework of just the substitute-in-file-name side. This > fixes this bug (by making completion continue to work when point is at > /usr/|/), and fixes another FIXME in a test (partial completion now > preserves environment variables!). And I don't think it loses anything > important, but I may be missing something. > > (completion--sifn-requote can now be deleted and there are probably > other cleanups possible after this patch, but I didn't do them here to > keep the patch smaller. Also, rfn-eshadow needs to be updated, but > that's just a visual issue.) Thanks, I applied your patch and rebuilt emacs, and now completion with the substring style works, but it's still different from the behavior before you previous change, as your comments above seem to acknowledge: now when I enter "/us" and hit TAB, it completes to "/usr/" and when I hit TAB again it becomes "/usr//" with point on (i.e. just before) the last slash and "/usr/" displayed with the file-name-shadow face. Hitting TAB again pops up a *Completions* buffer with the correct completions (immediate subdirectories of /usr) and typing part of a candidate in the minibuffer correctly expands the file name. This behavior obtains with any directory whose immediate children are all directories; if at least one child is a non-directory file, the *Completions* buffer up on hitting the TAB the second time (and the part of the file name up to the final slash has the default face); so here the completion works also visually as before. So your patch only partially fixes the regression. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 07:17:20 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 11:17:20 +0000 Received: from localhost ([127.0.0.1]:50918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4eI3-0001ul-LJ for submit@debbugs.gnu.org; Tue, 15 Apr 2025 07:17:20 -0400 Received: from mail-vk1-xa2c.google.com ([2607:f8b0:4864:20::a2c]:46235) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u4eI0-0001uU-1a for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 07:17:17 -0400 Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-523ffbe0dbcso5419767e0c.0 for <77718@debbugs.gnu.org>; Tue, 15 Apr 2025 04:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744715830; x=1745320630; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=QktqLxyydQitrCFKMWc0EeoLzzYxHzWvIsgmxnjpVm0=; b=MELblFVThWQCUm1mmTjK9UYo25RXUwmA64KPl6S98l4rtGRRqZs4kuymBE5sQXnyC4 NTc8Q/YHwS4Udtk2ePiGQJMszl6EFqViOZL/jDNhzQEokZck/Y1J73nidh3E0jQ0Lm7R kCiLTghZwxUssaYdpBmfD+HpIlMRwctktTlmsXKBTf50ZHYnZqD0E9QTsWN8W3MjpR2t IctPF7ZDLNTTz3MMVGfre51sQCwBh/ZLp7QQAtTEMt+XVypPWbP8GKvUZXzC+yTLKvMR FB/A3W4AgTCWrBpC2dd1XXkTMDcR1cyT1s0MHY1+sy/0NQ8j9suZJvcCoI2k7id+34D/ 7lsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744715830; x=1745320630; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QktqLxyydQitrCFKMWc0EeoLzzYxHzWvIsgmxnjpVm0=; b=p726uarFWjLv5NCutKAE5piKhC8ihvJcHbzOqDB2nU3QNxCw9skowlggQ3z430bAPK GHvRAokHdpA2u6ZBZu7WJSnW2zJSBfpYVnyfXjTiWsjYgWOD7//PaLk4pv4KrOtx4Ezy hda2x6uxqsBL6NA/Zk5kjXdrRDuh4L3keKWqwzOrymc7JE0gASEzGIhNtU0sae27lkfJ R39LGjjLOpOUiyE7q93BM5F/aCSlBQA8mj34DKqbe0r52gp+BNlvHKfyKs4uYMJQPz9G vYXKME4qJzRSJDVUykI7Gr7KHveIFHFo8qv16LhCkOQSRd5dmp9+RS0a/lI2/gyo7PLH l1WQ== X-Forwarded-Encrypted: i=1; AJvYcCXzq1Jtg1xAF5jzfyDvzQfDGUbab8XMqBErqVpJOnVBuAB/G7Aq/bnsUQb0+L3nYhB8cLV2Vg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzXBZDu65+PHnaXlw+c1cQH0Lqqh4jFQ+7wIbg3SNuowQ10UgWJ MGRyJ3AkPzL6q6iCg0F48/LOtiYr69aaKRRwWNJpZ4vIMXv1oUs2+AgC/tKInmmtY/KF1Vm/WQK CWh0sUy9xKW/YLC9E1EdC/AUnQak= X-Gm-Gg: ASbGnctRV4LAIN8w7gLCsQu3GmmT/8uXUoyOCG3eV0s6Cff/ofQ1Uz4z4CY1NkiTfME 7DNY5tk7a+I/Df7rre+r93GuzVusk3iTanxCjacCMQ6uj4incR+xifHgPzt8atIDXsWfq0gJ+vW GJOpPcYiF+Q4wknkw6G8V12A== X-Google-Smtp-Source: AGHT+IEvDhpvfKNCtB59T86/RauzjJqWghjBHXvwjmJPNltAF4JR0DpCOMbH/ry3kq97+IWhzbqs2vVS90rwSPY75PU= X-Received: by 2002:a05:6122:d95:b0:520:61ee:c7f9 with SMTP id 71dfb90a1353d-527c35b020amr9368100e0c.7.1744715830253; Tue, 15 Apr 2025 04:17:10 -0700 (PDT) MIME-Version: 1.0 References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> In-Reply-To: <86a58ihrfg.fsf@gnu.org> From: Ship Mints Date: Tue, 15 Apr 2025 07:16:58 -0400 X-Gm-Features: ATxdqUE62sVXKdUeAK2k1cqVTdxRdvt8G6C4wGOeAaEhl09PokgSlalywbN8Oro Message-ID: Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000004be0220632cf4f2d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , stephen.berman@gmx.net, monnier@iro.umontreal.ca, 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004be0220632cf4f2d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 15, 2025 at 2:26=E2=80=AFAM Eli Zaretskii wrote: > > From: Spencer Baugh > > Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen > Berman > > > > Date: Mon, 14 Apr 2025 16:30:09 -0400 > > > > + (;; Ensure we discard text before // by always using sifn in that > case. > > + (unless (string-search "//" orig) > > + (complete-with-action action table orig pred))) > > AFAIU, this ignores the case of UNC file names, which begin with "//", > and other complications with file names on Windows. Emacs on Windows > reacts differently to "//" than it does on Posix systems, and it does > so for very good reasons. > > Please don't break file-name completion on Windows. It took us many > iterations to get it right, and the result is fragile. Be sure to > test each change on Windows as well before installing. > > For the same reasons, please test thoroughly with remote file names of > different formats. > > Given the fragility of this, I'd tend to suggest to define a new style > with these changes, and leave alone the existing styles, even if you > consider them "broken". > The POSIX standard allows "pathnames" that start with "//" and Emacs, for sure, should respect file names that begin with //. "A pathname that begins with two successive slashes may be interpreted in an implementation-defined manner, although more than two leading slashes shall be treated as a single slash." "A pathname may optionally contain one or more trailing slashes." "Multiple successive slashes are considered to be the same as one slash." For mailing list posterity: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#ta= g_03_271:~:text=3Din%20Filename.-,3.273,-Path%20Prefix https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#ta= g_03_271:~:text=3Din%20their%20execution.-,3.40,-Basename https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#:~= :text=3DIf%20a%20pathname%20begins%20with%20two%20successive%20%3Cslash%3E%= 20characters%2C%20the%20first%20component%20following%20the%20leading%20%3C= slash%3E%20characters%20may%20be%20interpreted%20in%20an%20implementation%2= Ddefined%20manner%2C%20although%20more%20than%20two%20leading%20%3Cslash%3E= %20characters%20shall%20be%20treated%20as%20a%20single%20%3Cslash%3E%20char= acter. https://pubs.opengroup.org/onlinepubs/007904875/basedefs/xbd_chap03.html#ta= g_03_266:~:text=3DA%20pathname%20may%20optionally%20contain%20one%20or%20mo= re%20trailing%20slashes.%20Multiple%20successive%20slashes%20are%20consider= ed%20to%20be%20the%20same%20as%20one%20slash. -Stephane --0000000000004be0220632cf4f2d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Tue, Apr 15, 2025 at 2:26=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Spencer Baugh <sbaugh@janestreet.com>
> Cc: 77718@d= ebbugs.gnu.org,=C2=A0 Eli Zaretskii <eliz@gnu.org>,=C2=A0 Stephen Berman
>=C2=A0 =C2=A0<stephen.berman@gmx.net>
> Date: Mon, 14 Apr 2025 16:30:09 -0400
>
> +=C2=A0 =C2=A0 =C2=A0(;; Ensure we discard text before // by always us= ing sifn in that case.
> +=C2=A0 =C2=A0 =C2=A0 (unless (string-search "//" orig)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (complete-with-action action table orig p= red)))

AFAIU, this ignores the case of UNC file names, which begin with "//&q= uot;,
and other complications with file names on Windows.=C2=A0 Emacs on Windows<= br> reacts differently to "//" than it does on Posix systems, and it = does
so for very good reasons.

Please don't break file-name completion on Windows.=C2=A0 It took us ma= ny
iterations to get it right, and the result is fragile.=C2=A0 Be sure to
test each change on Windows as well before installing.

For the same reasons, please test thoroughly with remote file names of
different formats.

Given the fragility of this, I'd tend to suggest to define a new style<= br> with these changes, and leave alone the existing styles, even if you
consider them "broken".

The POSIX standard allow= s "pathnames" that start with "//" and Emacs, for sure,= should respect file names that begin with //.

"A pathname that begins with two succes= sive slashes may be interpreted in an implementation-defined manner, althou= gh more than two leading slashes shall be treated as a single slash."<= /div>
"A= pathname may optionally contain one or more trailing slashes."
<= div class=3D"gmail_default" style=3D"font-family:monospace">
"Multiple succ= essive slashes are considered to be the same as one slash."

For mailing list posterity:
<= /div>

https://pubs.opengrou= p.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_271:~:text=3Din%= 20Filename.-,3.273,-Path%20Prefix
https://pubs.opengroup.org/onlinepubs/969991979= 9/basedefs/V1_chap03.html#tag_03_271:~:text=3Din%20their%20execution.-,3.40= ,-Basename
https://pubs.opengroup.org/onlinepubs/96999197= 99/basedefs/V1_chap04.html#:~:text=3DIf%20a%20pathname%20begins%20with%20tw= o%20successive%20%3Cslash%3E%20characters%2C%20the%20first%20component%20fo= llowing%20the%20leading%20%3Cslash%3E%20characters%20may%20be%20interpreted= %20in%20an%20implementation%2Ddefined%20manner%2C%20although%20more%20than%= 20two%20leading%20%3Cslash%3E%20characters%20shall%20be%20treated%20as%20a%= 20single%20%3Cslash%3E%20character.
https://pubs.opengroup.org/onlinepubs/007904875/basedefs/= xbd_chap03.html#tag_03_266:~:text=3DA%20pathname%20may%20optionally%20conta= in%20one%20or%20more%20trailing%20slashes.%20Multiple%20successive%20slashe= s%20are%20considered%20to%20be%20the%20same%20as%20one%20slash.

-Stephane
<= /div>
--0000000000004be0220632cf4f2d-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 15:24:55 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 19:24:55 +0000 Received: from localhost ([127.0.0.1]:55706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4ltu-0005My-Hk for submit@debbugs.gnu.org; Tue, 15 Apr 2025 15:24:55 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:58309) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4ltq-0005Mb-UG for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 15:24:52 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <86a58ihrfg.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Apr 2025 09:25:39 +0300") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 15 Apr 2025 15:24:45 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744745085; bh=jjwNR9O0+q+/+Zz1h45Vi0nweIsN9uqlz88uWmPkZIg=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Jpzq30K3/jAfUbjCa+ZVPTepy3Ls4Ew+LuQhhciCueqRj9g1zsHyPxixY7OE/PA0r yvzUrqIpvhJjAexoUnwiuaHGuHyKzODYPM0WIGgzCtJHIbHfobUXLhskSedSTGjY29 FqKSml9moQknmQcDZxUTf9xtRD0tiM56Tl6JHMj58nSPdn2W4QzGaIYao/tX/UTmdl 9J9A45FDZdQeRrxWz9saUVxCBjA7K8EXgk7PkKXSC1EU6huN3J1RiGGyaDT2aKc1LM AKfmApEH7u6M84U67UaAQes/igH2IuYG5zOR9cjcSwXK9HaKDEeStbjB4ucyQHlyEo UHTGE++TDAMhA== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman >> >> Date: Mon, 14 Apr 2025 16:30:09 -0400 >> >> + (;; Ensure we discard text before // by always using sifn in that case. >> + (unless (string-search "//" orig) >> + (complete-with-action action table orig pred))) > > AFAIU, this ignores the case of UNC file names, which begin with "//", > and other complications with file names on Windows. Emacs on Windows > reacts differently to "//" than it does on Posix systems, and it does > so for very good reasons. Ah, thanks, good point. I updated it to remove this hardcoded handling of //, and instead defer to substitute-in-file-name, which will behave right on Windows. Updated patch attached. > Please don't break file-name completion on Windows. It took us many > iterations to get it right, and the result is fragile. Be sure to > test each change on Windows as well before installing. Can do, I'm working on setting up a test Windows system right now. Is there any way to approximately test the behavior of Windows file name completion while still on GNU/Linux? It might be useful to have tests which can run on GNU/Linux but test the Windows behavior. > For the same reasons, please test thoroughly with remote file names of > different formats. Will do - I'll make some additions to tramp-tests as well. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Improve-env-var-handling-in-read-file-name.patch >From d35a5068cb9d9a75a19914fb624da5b0bd461937 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Mon, 14 Apr 2025 16:01:38 -0400 Subject: [PATCH] Improve env var handling in read-file-name Fix various bugs, including bug#77718, by rewriting the way file name completion handles environment variable expansion. Instead of using completion-table-with-quoting to manipulate the string being completed on, simply make the completion table itself understand substitute-in-file-name. The completion table first tries to complete without substituting environment variables; this allows completion to work on file names which contain things which look like environment variables. If that fails, we call substitute-in-file-name and then complete again. Tests are updated: we no longer duplicate $s in file names, since that's not necessary. And partial-completion now preserves unexpanded environment variables. However, partial-completion no longer works across environment variables containing delimiters; that's an acceptable sacrifice. * lisp/minibuffer.el (completion--replace-prefix) (completion--complete-on-expansion): Add. (completion--file-name-table): Rewrite to use substitute-in-file-name explicitly. (bug#77718) * test/lisp/minibuffer-tests.el (completion-table-test-quoting) (minibuffer-next-completion): Update. --- lisp/minibuffer.el | 57 ++++++++++++++++++++++++++++++++--- test/lisp/minibuffer-tests.el | 16 +++++----- 2 files changed, 59 insertions(+), 14 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index ab00395a850..e53bd673df9 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3565,13 +3565,60 @@ completion--sifn-requote (setq qpos (1- qpos))) (cons qpos #'minibuffer-maybe-quote-filename))))) -(defalias 'completion--file-name-table - (completion-table-with-quoting #'completion-file-name-table - #'substitute-in-file-name - #'completion--sifn-requote) +(defun completion--replace-prefix (s old new) + "Replace prefix OLD of string S with prefix NEW." + (concat new (substring s (length old)))) + +(defun completion--file-name-table (orig pred action) "Internal subroutine for `read-file-name'. Do not call this. This is a completion table for file names, like `completion-file-name-table' -except that it passes the file name through `substitute-in-file-name'.") +except that it passes the file name through `substitute-in-file-name'." + (let ((table #'completion-file-name-table)) + (or + ;; First try completing without expanding environment variables; we still + ;; call `substitute-in-file-name' to handle // and other constructs. + (let ((sifned (let ((process-environment nil)) (substitute-in-file-name orig)))) + ;; Fall through to the second case if `substitute-in-file-name' expanded + ;; something anyway. + (when (string-suffix-p sifned orig) + (let ((discarded (string-remove-suffix sifned orig)) + (result (complete-with-action action table sifned pred))) + (cond + ((eq (car-safe action) 'boundaries) + (cons 'boundaries (cons (+ (length discarded) (cadr result)) (cddr result)))) + ((null action) + (if (stringp result) (concat discarded result) result)) + (t result))))) + ;; Try again, this time expanding environment variables. + (cond + ((eq (car-safe action) 'boundaries) + ;; Compute the boundaries on ORIG; boundaries created by expanding + ;; environment variables can't be used. + (complete-with-action action table orig pred)) + ((let* ((sifned (substitute-in-file-name orig)) + (result (complete-with-action action table sifned pred))) + (cond + ((null action) + (if (stringp result) + (completion--replace-prefix result sifned orig) + result)) + ((eq action t) + (when result + ;; Find the part of SIFNED which is inside the boundaries, and + ;; replace it with the part of ORIG which is inside the boundaries. + (let* ((expansion-bounds (completion-boundaries sifned table pred "")) + (expansion-in-bounds (substring sifned (car expansion-bounds))) + (orig-bounds (completion-boundaries orig table pred "")) + (orig-in-bounds (substring orig (car orig-bounds)))) + (if (and (string-empty-p expansion-in-bounds) + (string-empty-p orig-in-bounds)) + ;; Nothing to replace, so avoid doing unnecessary work. + result + (mapcar + (lambda (s) + (completion--replace-prefix s expansion-in-bounds orig-in-bounds)) + result))))) + (t result)))))))) (defalias 'read-file-name-internal (completion-table-in-turn #'completion--embedded-envvar-table diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 59ac5ab9578..38c005bd1b5 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -91,20 +91,18 @@ completion-table-subvert-test (ert-deftest completion-table-test-quoting () (let ((process-environment - `("CTTQ1=ed" "CTTQ2=et/" ,@process-environment)) + `("CTTQ1=ed" ,@process-environment)) (default-directory (ert-resource-directory))) (pcase-dolist (`(,input ,output) '( - ;; Test that $ in files is properly $$ quoted. - ("data/m-cttq" "data/minibuffer-test-cttq$$tion") - ;; Test that $$ in input is properly unquoted. - ("data/m-cttq$$t" "data/minibuffer-test-cttq$$tion") + ;; Test that files containing $ can be completed + ("data/m-cttq" "data/minibuffer-test-cttq$tion") + ;; Test that $ can be completed + ("data/m-cttq$" "data/minibuffer-test-cttq$tion") ;; Test that env-vars are preserved. ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") - ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") ;; Test that env-vars don't prevent partial-completion. - ;; FIXME: Ideally we'd like to keep the ${CTTQ}! - ("lis/c${CTTQ1}/se-u" "lisp/cedet/semantic-utest") + ("lis/c${CTTQ1}/se-u" "lisp/c${CTTQ1}et/semantic-utest") )) (should (equal (completion-try-completion input #'completion--file-name-table @@ -690,7 +688,7 @@ minibuffer-next-completion (completing-read-with-minibuffer-setup #'read-file-name-internal (insert "d/") (execute-kbd-macro (kbd "M- M- M-")) - (should (equal "data/minibuffer-test-cttq$$tion" (minibuffer-contents)))))) + (should (equal "data/minibuffer-test-cttq$tion" (minibuffer-contents)))))) (provide 'minibuffer-tests) ;;; minibuffer-tests.el ends here -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 17:04:57 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 21:04:57 +0000 Received: from localhost ([127.0.0.1]:56642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4nSj-00027a-6U for submit@debbugs.gnu.org; Tue, 15 Apr 2025 17:04:57 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43992) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4nSg-00027H-L9 for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 17:04:55 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 54E7C1002EC; Tue, 15 Apr 2025 17:04:49 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744751084; bh=sM28nVOhI4rawcAA8ah7o/vUeQqx0KSBWzdM84UGqCo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PMdPfJDWR2oxnW1WzzbzhScRt95fY/QdtokIOoO/fSHUtxpgT9+7y1vuEqc68omUX IG0q3Z9bkO9S/lds/kPBzZJV5F7yB+EwZo1wekDE8EkIcrWpVpoJQO1199KO9NQEh3 h34ZZnMG1MQVFlMCuducGJyztFeB3xlPDDobPfLLAXT7tCYOofGTJgwXIMdTYI6qaO BrT8ZMpN9bfIPNQf8A7TM2idg/287HY+WSdJhphHZ/yODjTsnEFT7c6HOJbTxG6TnT IC/DA63TdW3TXkL+Sk4atEh+A9/jkficenE/v1Mzy+ovkJMWmVu/LxKOLdjRBY3l0U YdVNzkTsJvQMA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 82ABA100034; Tue, 15 Apr 2025 17:04:44 -0400 (EDT) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 527D61201DD; Tue, 15 Apr 2025 17:04:44 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 15 Apr 2025 17:04:43 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.372 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Fix various bugs, including bug#77718, by rewriting the way file > name completion handles environment variable expansion. Instead > of using completion-table-with-quoting to manipulate the string > being completed on, simply make the completion table itself > understand substitute-in-file-name. OK. > The completion table first tries to complete without > substituting environment variables; this allows completion to > work on file names which contain things which look like > environment variables. If that fails, we call > substitute-in-file-name and then complete again. Why? `substitute-in-file-name` presumably already takes care of that: (substitute-in-file-name "/foo/$NOTAVAR/bar") => "/foo/$NOTAVAR/bar" > Tests are updated: we no longer duplicate $s in file names, > since that's not necessary. AFAIK it is still needed for the (null action) case. > And partial-completion now > preserves unexpanded environment variables. However, > partial-completion no longer works across environment variables > containing delimiters; that's an acceptable sacrifice. Agreed. > * lisp/minibuffer.el (completion--replace-prefix) > (completion--complete-on-expansion): Add. > (completion--file-name-table): Rewrite to use > substitute-in-file-name explicitly. (bug#77718) I think you can also delete `completion--sifn-requote` while at it. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 17:21:23 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 21:21:23 +0000 Received: from localhost ([127.0.0.1]:56762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4nia-0004ZH-Oa for submit@debbugs.gnu.org; Tue, 15 Apr 2025 17:21:22 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:46077) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4niW-0004Xg-Ts for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 17:21:18 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Tue, 15 Apr 2025 17:04:43 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 15 Apr 2025 17:21:11 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744752071; bh=XX5oq4MANuuNQzdcxG1hKhW0Nuz4pGYbXDBshuAVvyw=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=gFFnFhbpMGh7PEdkRkF0y4h6igGWTdZLiY+9eRhwY6Km8pzn7x07uI2eL/uPj5OTK gIojjldytE2qKoZ7DDI3p17lffYwZ9iROXPChJFWPoBntA3LTgmgPgo860NWBSpbpX 9Uc1paDzBt+NvsmxhgKh+YYYybe+uEikDr5pnpH5EJW6usqZEQ1xvQQi/cOutsxIkD eWO1elaZUIG1LrFn9H9tlCaHtFGCXnNA9p68ptrzfO1ipzPCBDInynBqhPOs2yusJO PJXIALxMzCsDX54n3+PFQNAVUGZFINmhZH2CsvRw9CkU7q2mo31JTmyYv+N+vsNm0B /+bqHJm1hlgPA== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> The completion table first tries to complete without >> substituting environment variables; this allows completion to >> work on file names which contain things which look like >> environment variables. If that fails, we call >> substitute-in-file-name and then complete again. > > Why? `substitute-in-file-name` presumably already takes care of that: > > (substitute-in-file-name "/foo/$NOTAVAR/bar") > => "/foo/$NOTAVAR/bar" To support completing file names that look like environment variables, without the need to quote $ by duplicating it. >> Tests are updated: we no longer duplicate $s in file names, >> since that's not necessary. > > AFAIK it is still needed for the (null action) case. Why would that be? I believe quoting $ should no longer be necessary. >> * lisp/minibuffer.el (completion--replace-prefix) >> (completion--complete-on-expansion): Add. >> (completion--file-name-table): Rewrite to use >> substitute-in-file-name explicitly. (bug#77718) > > I think you can also delete `completion--sifn-requote` while at it. Indeed, I will, just avoiding that for now while iterating on the patch. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 15 17:50:58 2025 Received: (at 77718) by debbugs.gnu.org; 15 Apr 2025 21:50:59 +0000 Received: from localhost ([127.0.0.1]:57048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4oBF-0008Hc-HX for submit@debbugs.gnu.org; Tue, 15 Apr 2025 17:50:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19165) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4oBB-0008G4-8n for 77718@debbugs.gnu.org; Tue, 15 Apr 2025 17:50:55 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 32F721002EC; Tue, 15 Apr 2025 17:50:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744753845; bh=KRj4T068n8siW85JqOVTvY3k98exu8oeJ/CDJiarxmI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iN7qWm9M9LexculLCUAX0pPDPjby5RVWEZ43vYLhvLd0lfiy/ejgnOSqxnl1yZKeu hmue7+RcjxYw6smYYfBoTigkAMHBxMy6G9stTqS62XHYrN/P2HFrFNkP75ZMXlj50J 7LgbnP31LaVJwpQEauSiQXrPA96ff0CamcezePE9TeKFDu1xfpkG8hD28VINGcwENJ aCVoaDYot0qwnqeVyMoBnxX+O/rhp0muJF6PnX7sp3w1mF7KUOwutEb97BmOTeYRDT ThMhbG92kkStIHpCp+2lmNeCJN2HIll/q2Xult+yDsJzuNZcmGXO/XcZN9ZqH5OyPY 9HHACelfT8oCQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id BFA66100034; Tue, 15 Apr 2025 17:50:45 -0400 (EDT) Received: from pastel (unknown [104.247.242.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 891A31201DD; Tue, 15 Apr 2025 17:50:45 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 15 Apr 2025 17:50:44 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.369 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Why? `substitute-in-file-name` presumably already takes care of that: >> >> (substitute-in-file-name "/foo/$NOTAVAR/bar") >> => "/foo/$NOTAVAR/bar" > > To support completing file names that look like environment variables, > without the need to quote $ by duplicating it. I don't understand: the example I show above suggests you can do that without doing anything special. [ Also, I'm not sure it's worth the trouble anyway: dollars in file names are fairly rare, so having to double them in those rare cases where they occur is not a big deal. In any case, it seems orthogonal to the problem at hand. ] >>> Tests are updated: we no longer duplicate $s in file names, >>> since that's not necessary. >> AFAIK it is still needed for the (null action) case. > Why would that be? I believe quoting $ should no longer be necessary. Say I have a file ~/tmp/foo$HOME.txt and I do C-x C-f ~/tmp/foo TAB AFAIK it needs to complete to ~/tmp/foo$$HOME.txt otherwise the file name returned by `read-file-name` will be ~/tmp/foo/home/monnier.txt > Indeed, I will, just avoiding that for now while iterating on the patch. +1 Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 03:31:44 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 07:31:44 +0000 Received: from localhost ([127.0.0.1]:34173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4xFF-0002u3-0e for submit@debbugs.gnu.org; Wed, 16 Apr 2025 03:31:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36852) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4xFA-0002sU-Uz for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 03:31:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4xF4-0004xs-L8; Wed, 16 Apr 2025 03:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tyc4eJ9e/gHPFAwTNrKTFeLUmUv/tCJel6R6uel2+os=; b=LKDhesOS4QR9 Ca54XWGNbyUkP9tXYV0YC/Jb6Fi63k1rYRGlOGZzEAaNfISoMIBfeQJWsSUcCaU8dy/c0Zwurfzef kBu+E1OIAhXGPepHuRRr1oH0/UdY7eoaSwwVw522l/rVXSlvLB3ZjKCRgDC88Z5T1cTDP+D1EOvcp k5jFYxmdiB2de4S5pIzGSNowCt1FSvqEPAE8t3lVMzdN8CwWrgthsyNCZakt4FAyXZ7dTzOvF+FhE 9fYwFsUViTU8n69Xl2CCnfA7fVRtBS3pq3c8v6dIy0QiU5vubmwyL/QXJ6KlKi3h4TM8qp2570S1s 5AI0aW0+3/NyBnX+FsLB5Q==; Date: Wed, 16 Apr 2025 10:31:25 +0300 Message-Id: <86sem8ftpu.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Tue, 15 Apr 2025 15:24:45 -0400) Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: 77718@debbugs.gnu.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca > Date: Tue, 15 Apr 2025 15:24:45 -0400 > > Eli Zaretskii writes: > > >> From: Spencer Baugh > >> Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman > >> > >> Date: Mon, 14 Apr 2025 16:30:09 -0400 > >> > >> + (;; Ensure we discard text before // by always using sifn in that case. > >> + (unless (string-search "//" orig) > >> + (complete-with-action action table orig pred))) > > > > AFAIU, this ignores the case of UNC file names, which begin with "//", > > and other complications with file names on Windows. Emacs on Windows > > reacts differently to "//" than it does on Posix systems, and it does > > so for very good reasons. > > Ah, thanks, good point. I updated it to remove this hardcoded handling > of //, and instead defer to substitute-in-file-name, which will behave > right on Windows. Updated patch attached. > > > Please don't break file-name completion on Windows. It took us many > > iterations to get it right, and the result is fragile. Be sure to > > test each change on Windows as well before installing. > > Can do, I'm working on setting up a test Windows system right now. Thanks. > Is there any way to approximately test the behavior of Windows file name > completion while still on GNU/Linux? It might be useful to have tests > which can run on GNU/Linux but test the Windows behavior. Unfortunately, this is not possible, because portions of the relevant code in C are only compiled into the Windows build of Emacs. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 13:10:59 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 17:11:00 +0000 Received: from localhost ([127.0.0.1]:41240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u56Hn-0007lR-4w for submit@debbugs.gnu.org; Wed, 16 Apr 2025 13:10:58 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:50879) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u56Hg-0007jQ-Ok for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 13:10:52 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Tue, 15 Apr 2025 17:50:44 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 13:10:42 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744823442; bh=kGyoe+6z0eQxk2NaNiWfs/T9/iHuz65oHpJ4nrCh4As=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=nO7on/pRpL4UEMKbJp5JNhuic/KC3YLDqCHHGzO/azgclQsHrkKi8vC19fn19fD6M w4150l6ZpQkPP9NDc78QlpZq2GfFPIlH4+Tev5ZE6URJYtAVzUx4f9T2oDOcT1qBhh z1Owo9nYUD0jQVs4vuhUfQU48PSi4NWHklKQ+oLrbIAy3de2poxg1c8ns1D8fyAWlT 3Uk+eNmfssKBQioaANRLR9d9RwV35B21YISpV461Fe9fA8W37rhaLpx/zmZtMtwscT NhYubWE9OKCk5V6YmYNyWSzIJtlaktU3pRmGY9Ut/oFqXc2E7EfoZo3NHqjjolTydb c6G508lPj4Nfw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >>> Why? `substitute-in-file-name` presumably already takes care of that: >>> >>> (substitute-in-file-name "/foo/$NOTAVAR/bar") >>> => "/foo/$NOTAVAR/bar" >> >> To support completing file names that look like environment variables, >> without the need to quote $ by duplicating it. > > I don't understand: the example I show above suggests you can do that > without doing anything special. That only works for completing file names that contain $ and which *aren't* currently environment variables. My code supports completing on ~/$HOME/foo where "$HOME" is the literal name of a directory. > [ Also, I'm not sure it's worth the trouble anyway: dollars in file names > are fairly rare, so having to double them in those rare cases where they > occur is not a big deal. In any case, it seems orthogonal to the > problem at hand. ] That's fair - so you think it might be OK to, basically, not support completion on file names containing substrings like "$HOME"? That could make things simpler, if we think that's acceptable. >>>> Tests are updated: we no longer duplicate $s in file names, >>>> since that's not necessary. >>> AFAIK it is still needed for the (null action) case. >> Why would that be? I believe quoting $ should no longer be necessary. > > Say I have a file > > ~/tmp/foo$HOME.txt > > and I do > > C-x C-f ~/tmp/foo TAB > > AFAIK it needs to complete to > > ~/tmp/foo$$HOME.txt > > otherwise the file name returned by `read-file-name` will be > > ~/tmp/foo/home/monnier.txt Ah, I see. I didn't realize that read-file-name calls substitute-in-file-name on the result; so a file name containing literally "$HOME" would be erroneously expanded by my code, right now. I'll add some tests for this case in the next version of my patch. This TAB behavior doesn't help if I manually type $HOME though, right? The $ is only automatically duplicated if you tab-complete. So, if the user manually types foo$HOME.txt then $HOME would be incorrectly expanded. So here's one idea: Since this only works if I tab-complete, that means it only works for files which actually exist. So, instead, I could have read-file-name check if the file (e.g. "~/tmp/foo$HOME.txt") exists before expanding environment variables; if the file exists, don't expand environment variables. This avoids the need to duplicate $s. Do you think that might suffice? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 14:30:08 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 18:30:08 +0000 Received: from localhost ([127.0.0.1]:41873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u57WR-0007c7-Cd for submit@debbugs.gnu.org; Wed, 16 Apr 2025 14:30:08 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15252) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u57WO-0007aP-3V for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 14:30:05 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E5ABB10033A; Wed, 16 Apr 2025 14:29:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744828197; bh=baKTdLHrhA0GkFHSW8/Qd8Put6bzPq1Gx8nv8vGRGsg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Qntbvlyn2DAkuNnlKdsyU2TYGHzpxhjS5Qz0KWaOfDdLyVpFMxljcFvQO05PVHot6 OfQMsc4cspVPvgGyjD019Q9vwlVlq6mwJQY6/XCkV+n+Zg1cu+EqNLhwc4TLCK3sto 0yNT3H4jToAMR40X6BdfpGczLoCdCzNPR/gh9D58/nJUSYuxHT4jaBUY2ZcYyDHH8a mY/A9XQrwV0KZ73hxIZTU9D8Y55nl38OSAnjwn+uee1/yWaiLNXww/WXN/cw6MmeFe xjCnt4UZOrqiWltlEUi47cRs/G4vCTy06UJWcu2GRRl/CMU/IP9LUu6HG6gGDealZQ 0FYJVm+YP4oKw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1196410007A; Wed, 16 Apr 2025 14:29:57 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0306B120691; Wed, 16 Apr 2025 14:29:57 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 14:29:56 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.097 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> [ Also, I'm not sure it's worth the trouble anyway: dollars in file names >> are fairly rare, so having to double them in those rare cases where they >> occur is not a big deal. In any case, it seems orthogonal to the >> problem at hand. ] > That's fair - so you think it might be OK to, basically, not support > completion on file names containing substrings like "$HOME"? Of course we support it, but we require the use of `$$HOME` to state clearly which interpretation you want. > This TAB behavior doesn't help if I manually type $HOME though, right? Presumably if you type `$HOME` it means you want the value of the HOME envvar. If you want the file named `$HOME` you need to type `$$HOME`. When the typing is done by the completion code, it's up to the completion code to apply that same rule. > So here's one idea: Since this only works if I tab-complete, that means > it only works for files which actually exist. So, instead, I could have > read-file-name check if the file (e.g. "~/tmp/foo$HOME.txt") exists > before expanding environment variables; if the file exists, don't expand > environment variables. This avoids the need to duplicate $s. But then we'd need to add some way for the user to say "I really want this $HOME to be expanded even though there is also a file by that funny name". [ In any case, this is not a question of completion but of `read-file-name`. ] Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 15:15:55 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 19:15:55 +0000 Received: from localhost ([127.0.0.1]:42269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u58Ek-0004nt-8j for submit@debbugs.gnu.org; Wed, 16 Apr 2025 15:15:54 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:58493) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u58Eg-0004n1-Ct for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 15:15:51 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Wed, 16 Apr 2025 14:29:56 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 15:15:44 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744830945; bh=Yd0awvQBoax71P8CngRNgcYhsGOtL/c1NrK/yzlsxME=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FfrHAO5MPGuaTNqj4WQ+8zipp/vsqwMnmTHjBXRjW3Hysnn1rer7y0TmtSCXkd8yv 88fz7KjrU+1xWgkuqfCkwA4H7u/NzKfU7mv6gDs0KlHi5KeDEfF9gZtTefr9vL7IH/ DftyalTdZ+TRJk/UzD7185c6RsWCyGL9SZ7Np+WFNCefrNYvICm6sAtso+0h/aHFZs jZpzmURsRbLQv0PfAYvfZ7kq61y1Bx2anP2nMIxZQzlTUytAPvOgqWVgP3f7IcJ7aa zkNPFDs0Tzq1hn4MB2GLST3uWzO1xXritL0jEEGQ6D2UC6pLDdZeaimaWolD7e/OU/ J1uPS4JnpdhTg== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >>> [ Also, I'm not sure it's worth the trouble anyway: dollars in file names >>> are fairly rare, so having to double them in those rare cases where they >>> occur is not a big deal. In any case, it seems orthogonal to the >>> problem at hand. ] >> That's fair - so you think it might be OK to, basically, not support >> completion on file names containing substrings like "$HOME"? > > Of course we support it, but we require the use of `$$HOME` to state > clearly which interpretation you want. Ah, sure. But my code supports completion on file names containing "$HOME" without the user of "$$HOME", which seems even nicer. >> This TAB behavior doesn't help if I manually type $HOME though, right? > > Presumably if you type `$HOME` it means you want the value of the HOME > envvar. If you want the file named `$HOME` you need to type `$$HOME`. > > When the typing is done by the completion code, it's up to the > completion code to apply that same rule. Sure, that's fair. Though, a user might not know that they can type $$HOME to get the file named '$HOME'; it's not that obvious. It seems like it would be nice to automatically DTRT, where possible, without requiring them to know that. >> So here's one idea: Since this only works if I tab-complete, that means >> it only works for files which actually exist. So, instead, I could have >> read-file-name check if the file (e.g. "~/tmp/foo$HOME.txt") exists >> before expanding environment variables; if the file exists, don't expand >> environment variables. This avoids the need to duplicate $s. > > But then we'd need to add some way for the user to say "I really want > this $HOME to be expanded even though there is also a file by that funny > name". True. Although, this situation seems likely to be quite rare. Perhaps we could support it by adding some new command minibuffer-substitute-in-file-name or something, which explicitly expands environment variables found in the current minibuffer. Then read-file-name does the right thing automatically in every case except this one, without the user needing to insert $$; and in this case, the user can just use minibuffer-substitute-in-file-name explicitly. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 16:00:18 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 20:00:18 +0000 Received: from localhost ([127.0.0.1]:42582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u58vi-0001rC-7i for submit@debbugs.gnu.org; Wed, 16 Apr 2025 16:00:18 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36793) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u58vg-0001o9-EW for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 16:00:17 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A53A1000BC; Wed, 16 Apr 2025 16:00:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744833609; bh=a4AaIHte6/d1mX+O5OlnZlKuMnvoAMSe+OewyyoUm84=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Nus87hk/1CQorY+py/I+tCqT63/ZXLUVkIi4n6xZDH9qouGwqGO6aWWgRZyzBu8wI dEdhp3WOn7oi0prUAh+bXnRBFb6KyBNLl+4ZaV6CdVi7P6u5fX+oRNJPZHucf7ZieH 9DI4m9dR3YkyFvx327SU8Yceu6I0KcQqbjeuFY8l8LR5g2fUlNN9e2pmAp2gxBcQaQ OMYExY8C5hUtySQN+lQErl0100/4UFowe1kVTllGjuHgO6YKA4Le7/7SRZ0h01k7vs kNxsw/Trv9Z8TIObN6MwpEp+NAAB77G2MvmPz/QV+E2HhzEFnyylDm6+LGtKVRRVzG nx6Xw4Zwj98Eg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D0093100027; Wed, 16 Apr 2025 16:00:09 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BD1B9120748; Wed, 16 Apr 2025 16:00:09 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 16:00:09 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I suggest we focus on the immediate completion issue. If you want to refine the treatment of $$, let's do that in a separate bug report. Stefan Spencer Baugh [2025-04-16 15:15:44] wrote: > Stefan Monnier writes: > >>>> [ Also, I'm not sure it's worth the trouble anyway: dollars in file names >>>> are fairly rare, so having to double them in those rare cases where they >>>> occur is not a big deal. In any case, it seems orthogonal to the >>>> problem at hand. ] >>> That's fair - so you think it might be OK to, basically, not support >>> completion on file names containing substrings like "$HOME"? >> >> Of course we support it, but we require the use of `$$HOME` to state >> clearly which interpretation you want. > > Ah, sure. But my code supports completion on file names containing > "$HOME" without the user of "$$HOME", which seems even nicer. > >>> This TAB behavior doesn't help if I manually type $HOME though, right? >> >> Presumably if you type `$HOME` it means you want the value of the HOME >> envvar. If you want the file named `$HOME` you need to type `$$HOME`. >> >> When the typing is done by the completion code, it's up to the >> completion code to apply that same rule. > > Sure, that's fair. Though, a user might not know that they can type > $$HOME to get the file named '$HOME'; it's not that obvious. It seems > like it would be nice to automatically DTRT, where possible, without > requiring them to know that. > >>> So here's one idea: Since this only works if I tab-complete, that means >>> it only works for files which actually exist. So, instead, I could have >>> read-file-name check if the file (e.g. "~/tmp/foo$HOME.txt") exists >>> before expanding environment variables; if the file exists, don't expand >>> environment variables. This avoids the need to duplicate $s. >> >> But then we'd need to add some way for the user to say "I really want >> this $HOME to be expanded even though there is also a file by that funny >> name". > > True. Although, this situation seems likely to be quite rare. Perhaps > we could support it by adding some new command > minibuffer-substitute-in-file-name or something, which explicitly > expands environment variables found in the current minibuffer. > > Then read-file-name does the right thing automatically in every case > except this one, without the user needing to insert $$; and in this > case, the user can just use minibuffer-substitute-in-file-name > explicitly. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 16:20:28 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 20:20:28 +0000 Received: from localhost ([127.0.0.1]:42809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u59FE-00040S-94 for submit@debbugs.gnu.org; Wed, 16 Apr 2025 16:20:28 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:47027) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u59FB-000408-Ug for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 16:20:26 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Wed, 16 Apr 2025 16:00:09 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 16:20:20 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744834820; bh=25LHA2rKhLlZEofrq6INU2Ky4BHMak8cLXRldYXHN20=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=rOcQsNZ6Zrl9R2c6Z1Um4mJmoJ+NE3KfdOu4ziW0Ymtcvfxa0bUXwnNti5G9ZYPev /ANp2qHLYx4GLsePpncGV6w3WsgEeaYknIg9MsIwhhgn0kBTtEGRMdIHWEhD5ShdrX NKv0prfh6m2q0fPnVnzzMtakbvXguyC670sV9Vq8bnMLwIMk5JSmGMqtG3v9ZSvl5F F4Vt7OUq/9Mj3SVrzD1eghI3hkSv2QqeqOmV7rXgFCB5fdmvHj/zrREhpKqoCd+nMS E5OfXsXa3mRlv7UJaXWCbsJAkP3Zmd0EIViaEk5XBGMeYAepledd0CJbpCkNYFqE+b eI2HzHmpW3HzA== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > I suggest we focus on the immediate completion issue. > If you want to refine the treatment of $$, let's do that in a separate > bug report. OK, that's fair. But to be clear, the issue is in completion-table-with-quoting, so it's quite tied together with the treatment of $$. My new version of completion--file-name-table fixes the bug by taking a much simpler approach than completion-table-with-quoting, but that approach depends on avoiding the need for $$. I will try to think of another approach which is more similar to how completion-table-with-quoting does things, but it will be more complicated. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 16 16:38:06 2025 Received: (at 77718) by debbugs.gnu.org; 16 Apr 2025 20:38:06 +0000 Received: from localhost ([127.0.0.1]:43016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u59WH-000601-RU for submit@debbugs.gnu.org; Wed, 16 Apr 2025 16:38:06 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:42240) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u59WF-0005zL-9j for 77718@debbugs.gnu.org; Wed, 16 Apr 2025 16:38:04 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CB0871000BC; Wed, 16 Apr 2025 16:37:56 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744835876; bh=0bxrBQ3IBZO0E49PstB2vh85yMbBVMbaVLouJ7+bDMw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VPv9+wCFMIlWnYJCRL1e9sCDtmC1E6w3nEghgrjh3knnVdebSwhAa+O+KqMXYcbOu Pj98T+o/2Eb3z/NBsXhSeO5Zls2pA09Ytm8IpBfSWKTM+npTk2G4i4BRSdplGOBu5z 8wAFzDYHkBVQYNcQiZmNZQm6+3lhP4O/+Fs7TcgdqNxpvs+XeCy6uFX7R0tgWXwsKf tNfnDAXyMSLtYvN7jPnf4GBQ4FruAdSnuvEwp05MmPstEFWSc3EcRmvOO44YaFsJol G9XHoB0m8De7QYXCi2AQGPovtRtU89upMy+0YB2AWulFFHeqM1L7ANMIulfiqRAv9h o3bW8mEaE3OPA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2DF28100027; Wed, 16 Apr 2025 16:37:56 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 1D036120588; Wed, 16 Apr 2025 16:37:56 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Wed, 16 Apr 2025 16:37:55 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.094 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I suggest we focus on the immediate completion issue. >> If you want to refine the treatment of $$, let's do that in a separate >> bug report. > > OK, that's fair. > > But to be clear, the issue is in completion-table-with-quoting, so it's > quite tied together with the treatment of $$. Yes, I know. > My new version of completion--file-name-table fixes the bug by taking > a much simpler approach than completion-table-with-quoting, but that > approach depends on avoiding the need for $$. I think I missed some of that, then. Can you clarify how they interact? > I will try to think of another approach which is more similar to how > completion-table-with-quoting does things, but it will be more > complicated. I thought all that's missing is to double the $$ in the text we append during completion. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 17 02:00:18 2025 Received: (at 77718) by debbugs.gnu.org; 17 Apr 2025 06:00:18 +0000 Received: from localhost ([127.0.0.1]:45469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5IIL-0005HB-J0 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 02:00:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60572) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5IIJ-0005BC-HX for 77718@debbugs.gnu.org; Thu, 17 Apr 2025 02:00:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5IID-0002Hg-5b; Thu, 17 Apr 2025 02:00:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mX7fjN0DNA8krtsr2wcGItZUvTpxJw9BLXk2+DJJx5o=; b=cBtjVc8G+KeU fUGv029l+vzn7wXLJqQCmzLKBvt1VU/nl8SDA8YItY1Sz2PxvMUMUWAD5o69mMUtOPDiW8z4Sqe97 oNBpkcUgNZMg3tEXKUuU/iBzg4FTBeMOJfRDvsVdUOgHFWJe2NfYw8KfDoLGuS66CdMRQ8RjPnM57 FIxn1NpXg6Lf5wUUY/PwDxb1qsuOxzkVgKd730C5ka1CEPOrqA/acVxXSzk5kvZyf7rL97IqBjgyJ l+FHv/2inaBvDp3QHrqqH1FEBMHtIXt8HEFD2Y7etoItagjmPKj7Fpo9x74MYkjs4f+EyUIPDFUSL Eyk0JLAtbqEiF+4LSLC8Uw==; Date: Thu, 17 Apr 2025 09:00:04 +0300 Message-Id: <86zfgfe3a3.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Wed, 16 Apr 2025 15:15:44 -0400) Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: 77718@debbugs.gnu.org, Eli Zaretskii , > stephen.berman@gmx.net > Date: Wed, 16 Apr 2025 15:15:44 -0400 > > Stefan Monnier writes: > > >>> [ Also, I'm not sure it's worth the trouble anyway: dollars in file names > >>> are fairly rare, so having to double them in those rare cases where they > >>> occur is not a big deal. In any case, it seems orthogonal to the > >>> problem at hand. ] > >> That's fair - so you think it might be OK to, basically, not support > >> completion on file names containing substrings like "$HOME"? > > > > Of course we support it, but we require the use of `$$HOME` to state > > clearly which interpretation you want. > > Ah, sure. But my code supports completion on file names containing > "$HOME" without the user of "$$HOME", which seems even nicer. IMO, it's confusing, because it's inconsistent with the rest of Emacs's behavior regarding file names with embedded "$". > >> This TAB behavior doesn't help if I manually type $HOME though, right? > > > > Presumably if you type `$HOME` it means you want the value of the HOME > > envvar. If you want the file named `$HOME` you need to type `$$HOME`. > > > > When the typing is done by the completion code, it's up to the > > completion code to apply that same rule. > > Sure, that's fair. Though, a user might not know that they can type > $$HOME to get the file named '$HOME'; it's not that obvious. It seems > like it would be nice to automatically DTRT, where possible, without > requiring them to know that. What do you mean by "where possible"? The behavior should be consistent across all Emacs interfaces that accept file names, so "where possible" should be common to all of them. It would be wrong for some UIs to use rules and exhibit behaviors that are different from other UIs in this regard, since then the users will have much harder time knowing what is right and what to expect. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 17 12:39:58 2025 Received: (at 77718) by debbugs.gnu.org; 17 Apr 2025 16:39:59 +0000 Received: from localhost ([127.0.0.1]:48235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5SHO-0003t8-32 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 12:39:58 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:37901) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5SHJ-0003s8-Mv for 77718@debbugs.gnu.org; Thu, 17 Apr 2025 12:39:55 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Wed, 16 Apr 2025 16:37:55 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Thu, 17 Apr 2025 12:39:48 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1744907988; bh=hqqxNq6O5hXe4zSlQdJSb72TR167XIyLxUOYvr3n/vA=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=kmw4824bQiUhPwwuar2tNayfSHBZkb80P+3aMwIbyJbBWliwKGTat5YhK+aD7lrr7 JOBNor2hDKQB7eMnb19orw3ODjEfuIXp/dCGpoVCFoTmN1dP9prGoQ5roUKd49yp3Q Nj7yaMiU1o5K+Q5GJDpQZTVpZeQtsF9GmZqnlrT6+HMLVM1+lUBmb1/dbiSJwg/+6D V+frDku1w5gZvVeuyQ+Yrj1IgdoiDPOrmRy+YGL5pkRpy5MRhmFm3cAQa46uGEIA4n 0TsIFKVJAsiIGNuZD7SZqHoafygNYz07HV6K8WXU8XrelYOmOt7UkGTTBeqNoKvlUm ZNb7IyLwo+Zgw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> I will try to think of another approach which is more similar to how >> completion-table-with-quoting does things, but it will be more >> complicated. > > I thought all that's missing is to double the $$ in the text we append > during completion. Yes, actually you're right, that turns out to be relatively simple. And now the quoting behavior doesn't change at all. Updated patch attached. The $ doubling also needs to happen in all-completions, not just try-completion. But, with sufficiently robust logic for figuring out the completion boundaries, that's straightforward: just double the $ in the newly added text. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Improve-env-var-handling-in-read-file-name.patch >From 6a8685edc22cba617ddced1f2b2e1b6c4e1c9de2 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Mon, 14 Apr 2025 16:01:38 -0400 Subject: [PATCH] Improve env var handling in read-file-name Fix various bugs, including bug#77718, by rewriting the way file name completion handles environment variable expansion. Instead of using completion-table-with-quoting to manipulate the string being completed on, simply make the completion table itself understand substitute-in-file-name. Tests are updated: partial-completion now preserves unexpanded environment variables. However, partial-completion no longer works across environment variables containing delimiters; that's an acceptable sacrifice. * lisp/minibuffer.el (completion--sifn-boundaries): Add. (completion--file-name-table): Rewrite to use substitute-in-file-name explicitly. (bug#77718) * test/lisp/minibuffer-tests.el (completion-table-test-quoting): Update. --- lisp/minibuffer.el | 59 ++++++++++++++++++++++++++++++++--- test/lisp/minibuffer-tests.el | 6 ++-- 2 files changed, 56 insertions(+), 9 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index c0ccfc00ce5..8edeba1fba9 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3596,13 +3596,62 @@ completion--sifn-requote (setq qpos (1- qpos))) (cons qpos #'minibuffer-maybe-quote-filename))))) -(defalias 'completion--file-name-table - (completion-table-with-quoting #'completion-file-name-table - #'substitute-in-file-name - #'completion--sifn-requote) +(defun completion--sifn-boundaries (string table pred suffix) + "Return completion boundaries on file name STRING. + +Runs `substitute-in-file-name' on STRING first, but returns completion +boundaries for the original string." + (let* (;; Calculate the completion boundaries without expanding env vars. + (unquoted + (let ((process-environment nil)) (substitute-in-file-name string))) + (bounds (completion-boundaries unquoted table pred suffix)) + ;; This is the part of UNQUOTED inside the completion boundaries. + (unquoted-suffix (substring unquoted (car bounds))) + ;; Each $ in UNQUOTED-SUFFIX is either $ or $$ in STRING. + (regex + (concat (replace-regexp-in-string "\\$" "\\$\\$?" unquoted-suffix t t) "$"))) + (cl-assert (string-match regex string) t) + (cons (match-beginning 0) (cdr bounds)))) + +(defun completion--file-name-table (orig pred action) "Internal subroutine for `read-file-name'. Do not call this. This is a completion table for file names, like `completion-file-name-table' -except that it passes the file name through `substitute-in-file-name'.") +except that it passes the file name through `substitute-in-file-name'." + (let ((table #'completion-file-name-table)) + (if (eq (car-safe action) 'boundaries) + (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) + (let* ((sifned (substitute-in-file-name orig)) + (result + (let ((completion-regexp-list + ;; Regexps are matched against the real file names after + ;; expansion, so regexps containing $ won't work. Drop + ;; them; we'll return more completions, but callers need to + ;; handle that anyway. + (cl-remove-if (lambda (regexp) (string-search "$" regexp)) + completion-regexp-list))) + (complete-with-action action table sifned pred)))) + (cond + ((null action) ; try-completion + (if (stringp result) + ;; Extract the newly added text, quote any dollar signs, and + ;; append it to ORIG. + (let ((new-text (substring result (length sifned)))) + (concat orig (minibuffer--double-dollars new-text))) + result)) + ((eq action t) ; all-completions + (mapcar + (let ((orig-prefix + (substring orig (car (completion--sifn-boundaries orig table pred "")))) + (sifned-prefix-length + (- (length sifned) + (car (completion-boundaries sifned table pred ""))))) + ;; Extract the newly added text, quote any dollar signs, and append + ;; it to the part of ORIG inside the completion boundaries. + (lambda (compl) + (let ((new-text (substring compl sifned-prefix-length))) + (concat orig-prefix (minibuffer--double-dollars new-text))))) + result)) + (t result)))))) (defalias 'read-file-name-internal (completion-table-in-turn #'completion--embedded-envvar-table diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 59ac5ab9578..9e28077026c 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -91,7 +91,7 @@ completion-table-subvert-test (ert-deftest completion-table-test-quoting () (let ((process-environment - `("CTTQ1=ed" "CTTQ2=et/" ,@process-environment)) + `("CTTQ1=ed" ,@process-environment)) (default-directory (ert-resource-directory))) (pcase-dolist (`(,input ,output) '( @@ -101,10 +101,8 @@ completion-table-test-quoting ("data/m-cttq$$t" "data/minibuffer-test-cttq$$tion") ;; Test that env-vars are preserved. ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") - ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") ;; Test that env-vars don't prevent partial-completion. - ;; FIXME: Ideally we'd like to keep the ${CTTQ}! - ("lis/c${CTTQ1}/se-u" "lisp/cedet/semantic-utest") + ("lis/c${CTTQ1}/se-u" "lisp/c${CTTQ1}et/semantic-utest") )) (should (equal (completion-try-completion input #'completion--file-name-table -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 11:59:40 2025 Received: (at 77718) by debbugs.gnu.org; 18 Apr 2025 15:59:40 +0000 Received: from localhost ([127.0.0.1]:52583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5o7w-0004ql-4L for submit@debbugs.gnu.org; Fri, 18 Apr 2025 11:59:40 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:13469) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5o7u-0004pf-8E for 77718@debbugs.gnu.org; Fri, 18 Apr 2025 11:59:38 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 75CC1442370; Fri, 18 Apr 2025 11:59:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1744991971; bh=RLqAqlvbgTnaH7bJOFsVCMWfcvtlTw1SmtxGmR73y/o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XiKu5O2tBJVIjwSWEjPPQoLKcZMR4nrAYLMjglc8d0kmZ63hwhmYEk0FuHCj92Kkq MX5rOZj3Hilly+8dz0zC0hWaghepPuda6FpKT9HzOPWBRdM+fru+xO//OT1g1OZAlO WHjBjrmY9tL/SjRJsOIOs4+WggydqvDJrtZYLZgeqpap6GGE874yGBFDOaH4fQjynt RO42Muw7YNd18gh6PpQkkAy06zSvquh/NX9kDUmhmGgpechTNURjBVN4qMlv2I3xoF SDKvsWtN42wKFYqre5oXSthNdlSBaou6KppLf+p7oUPaf/2TrGHiCAv2K/HimGZMTk Iv59Zqr36jrXA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 53DB1441625; Fri, 18 Apr 2025 11:59:31 -0400 (EDT) Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2F2961201DE; Fri, 18 Apr 2025 11:59:31 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Fri, 18 Apr 2025 11:59:30 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.228 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index c0ccfc00ce5..8edeba1fba9 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -3596,13 +3596,62 @@ completion--sifn-requote > (setq qpos (1- qpos))) > (cons qpos #'minibuffer-maybe-quote-filename))))) > > -(defalias 'completion--file-name-table > - (completion-table-with-quoting #'completion-file-name-table > - #'substitute-in-file-name > - #'completion--sifn-requote) > +(defun completion--sifn-boundaries (string table pred suffix) > + "Return completion boundaries on file name STRING. > + > +Runs `substitute-in-file-name' on STRING first, but returns completion > +boundaries for the original string." > + (let* (;; Calculate the completion boundaries without expanding env vars. > + (unquoted > + (let ((process-environment nil)) (substitute-in-file-name string))) > + (bounds (completion-boundaries unquoted table pred suffix)) > + ;; This is the part of UNQUOTED inside the completion boundaries. > + (unquoted-suffix (substring unquoted (car bounds))) > + ;; Each $ in UNQUOTED-SUFFIX is either $ or $$ in STRING. > + (regex > + (concat (replace-regexp-in-string "\\$" "\\$\\$?" unquoted-suffix t t) "$"))) > + (cl-assert (string-match regex string) t) > + (cons (match-beginning 0) (cdr bounds)))) What makes us think that the `cl-assert` will always be satisfied? Won't it fail in `/blabla/foo-$BAR.c` when `BAR=bash` ? > @@ -101,10 +101,8 @@ completion-table-test-quoting > ("data/m-cttq$$t" "data/minibuffer-test-cttq$$tion") > ;; Test that env-vars are preserved. > ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") > - ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") Why do we remove this test? Maybe it's OK that it doesn't return the same value (e.g. that it behaves less well), but if so, we should probably keep this commented out with an explanation of what's going on. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 22 14:52:27 2025 Received: (at 77718) by debbugs.gnu.org; 22 Apr 2025 18:52:27 +0000 Received: from localhost ([127.0.0.1]:49883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7IjK-0002LU-Br for submit@debbugs.gnu.org; Tue, 22 Apr 2025 14:52:27 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:39209) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7IjG-0002LA-AL for 77718@debbugs.gnu.org; Tue, 22 Apr 2025 14:52:24 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Fri, 18 Apr 2025 11:59:30 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 22 Apr 2025 14:52:16 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1745347936; bh=Vb9tcModWG14s/YoZsViJC4okNcyIpR2trkby2rCLGo=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=RTiSGCCEVCui83lNx5T5yrN2CJDJhXTS7UQt/g8WoiEozYYXbz73KA3VZwFegPxIQ Av34/NA4aDgk6RNW9blo53Zq2i7cJG/J0Qyn330XVeeADbXoD1DpCGb64eb/YPauIJ wW5h2fFWxeHufPRVm3imCkXdHac7h6u4T53IOnCwatMRn0ggHDL4Br3pJTUD3ZGBMo ZZXQhZKoemCcn7V6nvpv90WWifKY1jlt+4mTxrYdwjYAdLwcjqpg1cK1WiSmJS2ZAa D/1uOKgkNVmawVz1s+vsGyl+/uGFAaJjVS5PfmMCwWRcN75xtb5BDMLiYjIejOSNjG TKrVAQpfeyjDg== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index c0ccfc00ce5..8edeba1fba9 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -3596,13 +3596,62 @@ completion--sifn-requote >> (setq qpos (1- qpos))) >> (cons qpos #'minibuffer-maybe-quote-filename))))) >> >> -(defalias 'completion--file-name-table >> - (completion-table-with-quoting #'completion-file-name-table >> - #'substitute-in-file-name >> - #'completion--sifn-requote) >> +(defun completion--sifn-boundaries (string table pred suffix) >> + "Return completion boundaries on file name STRING. >> + >> +Runs `substitute-in-file-name' on STRING first, but returns completion >> +boundaries for the original string." >> + (let* (;; Calculate the completion boundaries without expanding env vars. >> + (unquoted >> + (let ((process-environment nil)) (substitute-in-file-name string))) >> + (bounds (completion-boundaries unquoted table pred suffix)) >> + ;; This is the part of UNQUOTED inside the completion boundaries. >> + (unquoted-suffix (substring unquoted (car bounds))) >> + ;; Each $ in UNQUOTED-SUFFIX is either $ or $$ in STRING. >> + (regex >> + (concat (replace-regexp-in-string "\\$" "\\$\\$?" unquoted-suffix t t) "$"))) >> + (cl-assert (string-match regex string) t) >> + (cons (match-beginning 0) (cdr bounds)))) > > What makes us think that the `cl-assert` will always be satisfied? > Won't it fail in `/blabla/foo-$BAR.c` when `BAR=bash` ? Because I bound process-environment to nil around the substitute-in-file-name call, with the goal of preventing environment variable expansion. But actually there's a simpler and better way to do that: just duplicate all the $s to $$, then substitute-in-file-name turns all the $$ back to $ without expanding environment variables. So I did that in the attached updated patch. >> @@ -101,10 +101,8 @@ completion-table-test-quoting >> ("data/m-cttq$$t" "data/minibuffer-test-cttq$$tion") >> ;; Test that env-vars are preserved. >> ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") >> - ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") > > Why do we remove this test? Maybe it's OK that it doesn't return the > same value (e.g. that it behaves less well), but if so, we should > probably keep this commented out with an explanation of what's going on. Fixed - actually, this test doesn't need to change at all, it still works, just an oversight on my part. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Improve-env-var-handling-in-read-file-name.patch >From c2773fbc301ef0b6eb34b84da181e916d563c490 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Mon, 14 Apr 2025 16:01:38 -0400 Subject: [PATCH] Improve env var handling in read-file-name Fix various bugs, including bug#77718, by rewriting the way file name completion handles environment variable expansion. Instead of using completion-table-with-quoting to manipulate the string being completed on, simply make the completion table itself understand substitute-in-file-name. Tests are updated: partial-completion now preserves unexpanded environment variables. However, partial-completion no longer works across environment variables containing delimiters; that's an acceptable sacrifice. * lisp/minibuffer.el (completion--sifn-boundaries): Add. (completion--file-name-table): Rewrite to use substitute-in-file-name explicitly. (bug#77718) * test/lisp/minibuffer-tests.el (completion-table-test-quoting): Update. --- lisp/minibuffer.el | 63 ++++++++++++++++++++++++++++++++--- test/lisp/minibuffer-tests.el | 3 +- 2 files changed, 59 insertions(+), 7 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index c0ccfc00ce5..efe2eba9539 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3596,13 +3596,66 @@ completion--sifn-requote (setq qpos (1- qpos))) (cons qpos #'minibuffer-maybe-quote-filename))))) -(defalias 'completion--file-name-table - (completion-table-with-quoting #'completion-file-name-table - #'substitute-in-file-name - #'completion--sifn-requote) +(defun completion--sifn-boundaries (string table pred suffix) + "Return completion boundaries on file name STRING. + +Runs `substitute-in-file-name' on STRING first, but returns completion +boundaries for the original string." + ;; We want to compute the start boundary on the result of + ;; `substitute-in-file-name' (since that's what we use for actual completion), + ;; and then transform that into an offset in STRING instead. We can't do this + ;; if we expand environment variables, so double the $s to prevent that. + (let* ((doubled-string (replace-regexp-in-string "\\$" "$$" string t t)) + ;; sifn will change $$ back into $, so the result is a suffix of STRING + ;; (in fact, it's the last absolute file name in STRING). + (last-file-name (substitute-in-file-name doubled-string)) + (bounds (completion-boundaries last-file-name table pred suffix))) + (cl-assert (string-suffix-p last-file-name string) t) + ;; BOUNDS contains the start boundary in LAST-FILE-NAME; adjust it to be an + ;; offset in STRING instead. + (cons (+ (- (length string) (length last-file-name)) (car bounds)) + ;; No special processing happens on SUFFIX and the end boundary. + (cdr bounds)))) + +(defun completion--file-name-table (orig pred action) "Internal subroutine for `read-file-name'. Do not call this. This is a completion table for file names, like `completion-file-name-table' -except that it passes the file name through `substitute-in-file-name'.") +except that it passes the file name through `substitute-in-file-name'." + (let ((table #'completion-file-name-table)) + (if (eq (car-safe action) 'boundaries) + (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) + (let* ((sifned (substitute-in-file-name orig)) + (result + (let ((completion-regexp-list + ;; Regexps are matched against the real file names after + ;; expansion, so regexps containing $ won't work. Drop + ;; them; we'll return more completions, but callers need to + ;; handle that anyway. + (cl-remove-if (lambda (regexp) (string-search "$" regexp)) + completion-regexp-list))) + (complete-with-action action table sifned pred)))) + (cond + ((null action) ; try-completion + (if (stringp result) + ;; Extract the newly added text, quote any dollar signs, and + ;; append it to ORIG. + (let ((new-text (substring result (length sifned)))) + (concat orig (minibuffer--double-dollars new-text))) + result)) + ((eq action t) ; all-completions + (mapcar + (let ((orig-prefix + (substring orig (car (completion--sifn-boundaries orig table pred "")))) + (sifned-prefix-length + (- (length sifned) + (car (completion-boundaries sifned table pred ""))))) + ;; Extract the newly added text, quote any dollar signs, and append + ;; it to the part of ORIG inside the completion boundaries. + (lambda (compl) + (let ((new-text (substring compl sifned-prefix-length))) + (concat orig-prefix (minibuffer--double-dollars new-text))))) + result)) + (t result)))))) (defalias 'read-file-name-internal (completion-table-in-turn #'completion--embedded-envvar-table diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index 57c7cc2ae1a..00a2055e602 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -103,8 +103,7 @@ completion-table-test-quoting ("lisp/c${CTTQ1}et/se-u" "lisp/c${CTTQ1}et/semantic-utest") ("lisp/ced${CTTQ2}se-u" "lisp/ced${CTTQ2}semantic-utest") ;; Test that env-vars don't prevent partial-completion. - ;; FIXME: Ideally we'd like to keep the ${CTTQ}! - ("lis/c${CTTQ1}/se-u" "lisp/cedet/semantic-utest") + ("lis/c${CTTQ1}/se-u" "lisp/c${CTTQ1}et/semantic-utest") )) (should (equal (completion-try-completion input #'completion--file-name-table -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 28 14:01:36 2025 Received: (at 77718-done) by debbugs.gnu.org; 28 Apr 2025 18:01:36 +0000 Received: from localhost ([127.0.0.1]:34513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9SnQ-0005x4-2M for submit@debbugs.gnu.org; Mon, 28 Apr 2025 14:01:36 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32460) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9SnF-0005vA-Su for 77718-done@debbugs.gnu.org; Mon, 28 Apr 2025 14:01:28 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 061C84425D2; Mon, 28 Apr 2025 14:01:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1745863279; bh=Ime6tkHKmTLQydv13wY4vhxxPbfG2HdKy2FOUwVuXJc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VawYYxQpHsI6uQHL5kwuuNQhwvsUR+w6DE2zD7MtizU58U/YpJ9gUpXyqmkqTc8QZ qoQiIC697/xnxqGqee2ZlDXBID1wskBDvvcqfoqYaq/fZnKZAGJ+DUx/icSZHy8For 9ZXBht3X/Pf/ZbQRN45QXA4ebL9PG0Rgt8EeuIyHZ5ZBOVBEAnWpWFJ3Z/PL9BdO37 lTEYFHo97vFCkXwxwcs5T2Iq/++Um1gBik7nJiJsUsB1ri1D8zlcmxISIhg0PnhVXy PUZIJckTH7DrR0d+9YT5GK4wzhXEiwwTZPCHOoLznlULeZTyt5a3pH9ySpGLHN7X+f G4p0beTOMacaQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 0C0094425C6; Mon, 28 Apr 2025 14:01:19 -0400 (EDT) Received: from pastel (104-195-232-56.cpe.teksavvy.com [104.195.232.56]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CE45E1201DD; Mon, 28 Apr 2025 14:01:18 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Mon, 28 Apr 2025 14:01:18 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.019 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718-done Cc: Eli Zaretskii , 77718-done@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > But actually there's a simpler and better way to do that: just duplicate > all the $s to $$, then substitute-in-file-name turns all the $$ back to > $ without expanding environment variables. So I did that in the > attached updated patch. LGTM, pushed to `master`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 29 06:19:23 2025 Received: (at 77718-done) by debbugs.gnu.org; 29 Apr 2025 10:19:23 +0000 Received: from localhost ([127.0.0.1]:50239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u9i3e-000638-Nf for submit@debbugs.gnu.org; Tue, 29 Apr 2025 06:19:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:51935) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u9i3b-00062r-Ao for 77718-done@debbugs.gnu.org; Tue, 29 Apr 2025 06:19:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1745921953; x=1746526753; i=stephen.berman@gmx.net; bh=j4zOBevuaMcSP5zihvdxpW4aSuieVxpFKFT/Zg+8Aac=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=RylpZM4ZdH59h/gbiJ64wS1GyDSrrz9uqLGpvfNZC+ya+lw05IT5jDc99/lM0GHW 8zTvqEtnWkftKhErL7tHacmx9/HfhAjkNJG1BPiCx44zPkBfqu4kD+8ED3I1dGbYV M88msrX02iuhBHCo8z5Ruyhjlw4VRuyvOWZeKOlOdUH4VZuDO5qVivSBJQmxBogrI xsL+GW3jhXSUAFbOcE0LemkLpVTfNQHg/SjAibFFFkM5eLlyRRSTx5+ddTj9QqV5h 0POHCkl2lVWXHV7cEPDgnszh0A1X/9pSC+b35iqiGOh3QnH28VXTeWwWur991V3na 7LZqLzNRkP5GMschUA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.126]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTRQq-1udRkL0b7c-00Iqbm; Tue, 29 Apr 2025 12:19:13 +0200 From: Stephen Berman To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <86semfp3g9.fsf@gnu.org> <86a58ihrfg.fsf@gnu.org> Date: Tue, 29 Apr 2025 12:19:11 +0200 Message-ID: <87v7qnp8ww.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:NeD8HzxyMnQGtlklgVSOK59Riaj05U/+XFYBbfqoJKidLeFZ9JL JthEnzbxxsAtkjeDOXEjP6sDwaNd7PVqKcS1d2NKU9QXr7dkM+KI4Ct/Jz99AOY/rrmMjq2 ioo3q1H16e3JpQK/RWYAIWfLODa9wEcP8fqtYk6toO/IGkzLp1VobDBoo0dmsKcBa+sdpVJ SYRtIb1xoAMb5oQh9LH4Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:GYqtlGX2euE=;YFBfxhN+84NVYowwCneBK61GMoA OvDNq3PixOxPCcGGEonV65zRRGxhdu84ZJzOvcjzr5v+phLMm82GlGVlIbQo9j6IscKuHByLw b/EaacZouSa6Fnj4lHTKMgQfQIROZn2zhvq4jxycbTr1kc21N0rDRbXi37rMF+sygiw+GwtjI D1xPwDiGAW3uaspcmZ1t50wuGUe/UeUws/KbaBc2yVlDGFd1Sw45+qnPujsIvB7rc/GpPWV8e SP72Y9OI5/YeJhUBmUdNKACKXyLUKkkV9BZefCntU3dpqD9g42UQHyqKTfdO8e15WE+0KHhLO 1wUZ4CGb6zH6gC6tv6cq3S81AsHhs/ctqkDzAFZl7zCP8Vsha/ghUOkSSa4zYjC8yFlde4/0e IsbyVnPdV1icgNbFG+saW/QdImo0KtdbVa05zI6k7ErKgyj1ZvyJaCa4hkYB2SENN6XuMugdT 01y9qr0tUsRRkARUJnAuIyNrthybVmavOsirgELlapdRUuDD3xw5+FpvOFuUe2v7K+MIykD1R lp3HuFJvwRqVO9NJFg5BUyDP88xY/LvpYTIRm/SQdQr/TUSBq36/uZxZGTHQHUtoje1eXGInq g7nDitY5Emnzw/4fWWucDlgTN0F4RwKyoBJEa1IFPpLzJYAYE/mi85snbWpYRu3aGYxTuhnDv oLXvaHJKTKAWFhAX4F/0cQAIqKO2vmCzaxIQtwKHMC9ObDdT9Dt7h89jPV4FXc9lwHD4wg+Nx q+hpelqnYyuTsphRQZWtV18CC8LWV1jRKIlG9P9mc+cB3Drx0Umx0OY7LbMtY3eDMTP3wdtgw 4plSNau9eQ3XSrwUyvt/3eUK3f3wRx74JPr+5R+GlMNYkPs5YLJYPB2TeuGTntqYVDTROnL0e BckcfFl4px3JMP27NYWFbz78AdMd4uwRf9tYw/vAL1rcqM4p4D3QfpGOkpA3w7b6y0wI7M4lI PhejAX5uscGP6OAITfZBU28MTBotrfbgupyKXYgn4YyYWwxI3sVjqM5QmfP2zM5hvuR0LLBnM tL0eCru+HHAUBqb2I/MHfFm8s9B0ZKhpCQxSeCgnzBBpgkCfMIijdxnYD6kKIsWLmd547EaM0 vv5xMueOKZzUDd6yCOxUtreJec+x8wZkF3VBzt0IpSNQFcQsJudOECNbG+olWp5ku8t/aw7Xm w/pwt/cz7GtcddUYq9/lLGaqy2052ProTy72u4pNNnfOR7IS/isD/jAP4vckrEZvGX5+RNV31 X9Zdkvs34NalaqpjXrrsfWzwVngnSIwDeR6bHFtfh1kD9BjmWQ00JxgDsTa17h7qHYaBHbt46 vg0l5xWr1gjq+Y6MskJDXcoCrKS7+BH80tSD4yQGgUCstHCSv1Niystb1lHo7Sv3PJENhPudY DrmrXVvKLmIoGpiVSrjrfhcaMadvkEOcYnlGf33pBT5ckjL/mcb/4KSXq9Z5ISWH2T3UcqEdP 0L9OdHqImMp5NPQBbmwNIMjX9zx4SmN+AmfcC5CmxFWhSasAFfoZPG+Bcd2AeNXxsUgDDt7nW HwhbltA9z+ZYRshXSZH6Q535bJ1fjqAvIaO0YcobXBH/sAQdATu9PPpzBtCzJMndUakzntxLJ zcD+wRgfH58HJEBez694W3vGzs8HZf8wYrHIwuWMLdhQboH7rP/BRnX0JqOXZBCL/HHXal1Xb MpYNT5ZIPa6PJ3GYrD1453BFWoiPTJtk1dGaGNlc/FKnBhWQZtooVhK88Uf3xcDrEaW+hLO/k gZpYxCTjmuNRp2ivCT35l50g/XBkHlnV6t2AxTKQgFbRxyPU6iJ7f1LDlJRFqe28Puu6dQd5F fIQu8Gj80r/zyWkcKRp09SviPTD/3TgdkwKQOECfLtZvX3JVcMU+GS53ZByBDKVS9JgIrTdbX 0SgwluTw9IaV180Q8wmVztQP5ewbDObFXT7aQOlBOAM36rUS3slLY6wTFrLJn5a27AlOwraVn lhAz+vVfOzoyg15BlRVMaCtzQ9Lb8d/G48TXA3x0ArPX1Xv6rkwzKLkR/Mu4+ZKLWX0M8TdL3 8W2R1bEMAMyBGNi5ccw91eR+MGEkJcgO59Uizn1ZjMmCRuvbhCh9t/e1vWwzc8Lw5h6JUIYBF EMGpv5usKTbe9oePSMS5Hi7fITAPVMH4mN67DtxSqOhqdXdou7vSU8/4kNOJIjmxAxE+PkDJX cSTG2aJc0pupw5zUTT5KVF/Ceyi03Vo553rWeUATjMnzqQwdmXRii3u3LkERc7GuWcggto859 3o+XgkAjV1rDliFdRMl7wxTJSF8PlFruwYj5lrVzI5yw/4osf5lJWDWj3ckwF4QkjW6p4WidV KNDbGlrkODHRL2kGrQGEASTp38RdGbBu1IzKiXcOzeqenxxW3hy2vUklIoQSfHDt/XD98E4HS XT9vtNDlOS5qqqJqMPeA9hDhEzxUZieXDcezPRqUPURYz0QDbWoq/fjlGrUIgD2sDLcVac5dO NZH/8omRylvqeq0GGrIpWwtilrhuX9smrjixDE22EsmOry3yZuUzyPW9l0uq9JcNzEbkW50sA VOjzLLTIr/I5Q59O/8817fuexdRa29Pn1feetn0RIbwWSojmkgYcksrlNdWD7XSUifjZVB6t8 ZXW2KhftDJw3BPe/Aus6L5BWaKe/2N99ydrL8f3PSLiPLc3zitZusKOfqQpskpQY34x13YQax pmt13T4YHgeEektKQ98sGCygPGPPTNjsvNE4OuJpd5GvbpbrZdmnAfD8c80YnOBaiN6+4mEIC oLuYjvMEgoXsK4xHsTIY0CZR4aCNPKoppOLn2m5Dof8SxbeDNBlrCaqLjnZXDRcLsrkmUXPdx Lcmj6UYrosT7sxlEaSkkjeJl6yumTURSV6vBz70Vdf/e8aeN9xApqQVJHctq+k2kWt9aIfd09 eSzvq+xcwUERB/jI7d5eO0XkoRVZJf96iWjufL+4KmbfjKhkzD+kJfaWSnlg2fmmjSuYrouxn C6fGLcTtu5QmbQbtDbHIrpI3xr45rkYImC7gtaKiA503mRWuOGbbvFX/A6j+raik6FS9o6dG9 rrVoRnZ8B2a9SArey8cMaYJ+aUj8JCLpCYJreUkei5HQElH2/L6z2RNWH5c9+MLLunmcKswsi 5q1XvInW11avTHCNaBinwSfTx69fQifL7U3i2oy0pJdXSvAwgQLvZR3qRc7wHV7NOrlqCQVAl 1T92Bd7w2lVA7iKe5zKQxmqi35KQPhd54EIMP2elNx+voOjXWgtPCrLrBh1Txh9+Gg0o= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 28 Apr 2025 14:01:18 -0400 Stefan Monnier wrote: >> But actually there's a simpler and better way to do that: just duplicate >> all the $s to $$, then substitute-in-file-name turns all the $$ back to >> $ without expanding environment variables. So [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.17.20 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.17.20 listed in bl.score.senderscore.com] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [94.134.95.126 listed in zen.spamhaus.org] X-Debbugs-Envelope-To: 77718-done Cc: Spencer Baugh , Eli Zaretskii , 77718-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, 28 Apr 2025 14:01:18 -0400 Stefan Monnier wrote: >> But actually there's a simpler and better way to do that: just duplicate >> all the $s to $$, then substitute-in-file-name turns all the $$ back to >> $ without expanding environment variables. So [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.17.20 listed in sa-accredit.habeas.com] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [94.134.95.126 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [212.227.17.20 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stephen.berman[at]gmx.net) -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain On Mon, 28 Apr 2025 14:01:18 -0400 Stefan Monnier wrote: >> But actually there's a simpler and better way to do that: just duplicate >> all the $s to $$, then substitute-in-file-name turns all the $$ back to >> $ without expanding environment variables. So I did that in the >> attached updated patch. > > LGTM, pushed to `master`. This patch causes two regressions wrt emacs-30. One I pointed out upthread (<87a58hal6w.fsf@gmx.net>, ). For this, the following patch fixes the regression according to my testing: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: completion-pcm--merge-completions patch diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index f8593fde0f7..cf5ab39bfb2 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -4609,7 +4609,7 @@ completion-pcm--merge-completions (mapcar (lambda (str) (substring str skip)) comps)))))) (cl-assert (stringp suffix)) - (unless (equal suffix "") + (unless (member suffix '("" "/")) (push suffix res)))) ;; We pushed these wildcards on RES, so we're done with them. (setq wildcards nil)) --=-=-= Content-Type: text/plain For the other regression, here is a reproducer: 0. mkdir /tmp/{Test,retest} 1. emacs -Q --eval "(custom-set-variables \ '(completion-category-overrides '((file (styles substring)))) \ '(read-file-name-completion-ignore-case t))" 2. Type `C-x d /tmp/tes TAB': this completes to /tmp/test/ 3. Type TAB again: Emacs dings and shows "[no match]" If you repeat this recipe in emacs-30, then after the TAB in step 3, this completion is shown: /tmp/Test/. and typing TAB again pops up the *Completions* buffer displaying the two completions ../ and ./ While the result in emacs-30 seems suboptimal, since it omits the possible completion /tmp/retest/, still it's better than "[no match]". A workaround for both emacs-30 and master is to enter at step 2 `C-x d /tmp/*tes TAB'. This shows the completion /tmp/*test/, then hitting TAB again shows /tmp/*test/., and hitting TAB a third time pops up the *Completions* buffer showing the four completions Test/../, Test/./, retest/../, and retest/./ Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 01 13:59:58 2025 Received: (at 77718) by debbugs.gnu.org; 1 May 2025 17:59:58 +0000 Received: from localhost ([127.0.0.1]:53039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAYCT-0001nG-UI for submit@debbugs.gnu.org; Thu, 01 May 2025 13:59:58 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:38891) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAYCP-0001mk-Mh for 77718@debbugs.gnu.org; Thu, 01 May 2025 13:59:55 -0400 From: Spencer Baugh To: Stephen Berman Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87v7qnp8ww.fsf@gmx.net> (Stephen Berman's message of "Tue, 29 Apr 2025 12:19:11 +0200") References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> Date: Thu, 01 May 2025 13:59:48 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1746122388; bh=azTYLfh7LTG8HmdFkUViu33mzxPoIXG4noQXwPcBW54=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=tnQEaFAZ15NbElMOtW4n506TS3QheluOijRJ9nG9Z7gwLwAkzHLFtZVG3bRZ8Rznu crWMVf8aGg0c3g40S96M9ctiZAxMKvMQFkjo9l+Ig00QO+ok9mhhrRy13wKrs2B87U brX3/l+tEpg0VBkff6FKMD5bEj8WcAvkLQZiqMSPJfSMHd/ImZF4m8Eqy+gxit+tz6 umzNvN2eaZ7bxQa7ZTZuLGfJ1etQWvD5FDy6s+mBuoqjn3H6Pku7e609Cyf3dAsncr zdjb+dOTPlSZRGBLu9EyQcbc05lbeZR+gDGSSXPE2oLWo6jPNMjPaV2welm4DrofML QzIF127XPLvBg== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , 77718-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Stephen Berman writes: > For the other regression, here is a reproducer: > > 0. mkdir /tmp/{Test,retest} > 1. emacs -Q --eval "(custom-set-variables \ > '(completion-category-overrides '((file (styles substring)))) \ > '(read-file-name-completion-ignore-case t))" > 2. Type `C-x d /tmp/tes TAB': this completes to /tmp/test/ > 3. Type TAB again: Emacs dings and shows "[no match]" > > If you repeat this recipe in emacs-30, then after the TAB in step 3, this > completion is shown: /tmp/Test/. and typing TAB again pops up the > *Completions* buffer displaying the two completions ../ and ./ > > While the result in emacs-30 seems suboptimal, since it omits the > possible completion /tmp/retest/, still it's better than "[no match]". > > A workaround for both emacs-30 and master is to enter at step 2 `C-x d > /tmp/*tes TAB'. This shows the completion /tmp/*test/, then hitting TAB > again shows /tmp/*test/., and hitting TAB a third time pops up the > *Completions* buffer showing the four completions Test/../, Test/./, > retest/../, and retest/./ > > Steve Berman Thanks for the prompt and detailed report. Does the attached patch fix this issue for you? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-completion-ignore-case-with-completion-file-name.patch >From 2619db58b2f3bdaeed0ea077b3292d93621e15d8 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Thu, 1 May 2025 13:56:37 -0400 Subject: [PATCH] Fix completion-ignore-case with completion--file-name-table 509cbe1c35b3d "Improve env var handling in read-file-name" caused try-completion and all-completion operations with completion--file-name-table to no longer update the case of text which was already present in the input string. That is, completions would be returned ignoring case, but the completions would have letter-casing which matched the input string rather than matching the actual file names. Fix this by always using text from the file name completions whenever it might have changed case. Also, fix a related bug where mixing completion-ignore-case and expanding environment variables would cause `read-file-name' to return the wrong result; do this by suppressing completion-ignore-case in the problematic case. * lisp/minibuffer.el (completion--file-name-table): Use text from the completions, not the input string. (bug#77718) * test/lisp/minibuffer-tests.el (completion-table-test-quoting): Test with completion-ignore-case as well. --- lisp/minibuffer.el | 42 +++++++++++++++++++++++------------ test/lisp/minibuffer-tests.el | 18 ++++++++++++++- 2 files changed, 45 insertions(+), 15 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 7b2b986aa1d..e35db9dad64 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3597,8 +3597,18 @@ completion--file-name-table (if (eq (car-safe action) 'boundaries) (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) (let* ((sifned (substitute-in-file-name orig)) + (orig-start (car (completion--sifn-boundaries orig table pred ""))) + (sifned-start (car (completion-boundaries sifned table pred ""))) + (orig-in-bounds (substring orig orig-start)) + (sifned-in-bounds (substring sifned sifned-start)) + (did-expansion-in-bounds (not (string-equal orig-in-bounds sifned-in-bounds))) (result - (let ((completion-regexp-list + (let ((completion-ignore-case + ;; If we expanded an environment variable in the completion + ;; bounds, don't ignore-case, otherwise `read-file-name' + ;; can return the wrong filename. + (and (not did-expansion-in-bounds) completion-ignore-case)) + (completion-regexp-list ;; Regexps are matched against the real file names after ;; expansion, so regexps containing $ won't work. Drop ;; them; we'll return more completions, but callers need to @@ -3606,26 +3616,30 @@ completion--file-name-table (seq-remove (lambda (regexp) (string-search "$" regexp)) completion-regexp-list))) (complete-with-action action table sifned pred)))) + ;; For each completion, quote dollar signs in newly added text. If sifn + ;; changed text within the completion boundaries, replace that with text + ;; from ORIG; otherwise, use text from the completion (it may differ if + ;; `completion-ignore-case' is non-nil) (cond ((null action) ; try-completion (if (stringp result) - ;; Extract the newly added text, quote any dollar signs, and - ;; append it to ORIG. (let ((new-text (substring result (length sifned)))) - (concat orig (minibuffer--double-dollars new-text))) + ;; Unconditionally replace the text outside the + ;; completion boundaries with text from ORIG. + (concat (substring orig nil orig-start) + (if did-expansion-in-bounds + orig-in-bounds + (substring result sifned-start (length sifned))) + (minibuffer--double-dollars new-text))) result)) ((eq action t) ; all-completions (mapcar - (let ((orig-prefix - (substring orig (car (completion--sifn-boundaries orig table pred "")))) - (sifned-prefix-length - (- (length sifned) - (car (completion-boundaries sifned table pred ""))))) - ;; Extract the newly added text, quote any dollar signs, and append - ;; it to the part of ORIG inside the completion boundaries. - (lambda (compl) - (let ((new-text (substring compl sifned-prefix-length))) - (concat orig-prefix (minibuffer--double-dollars new-text))))) + (lambda (compl) + (let ((new-text (substring compl (length sifned-in-bounds)))) + (concat (if did-expansion-in-bounds + orig-in-bounds + (substring compl nil (length sifned-in-bounds))) + (minibuffer--double-dollars new-text)))) result)) (t result)))))) diff --git a/test/lisp/minibuffer-tests.el b/test/lisp/minibuffer-tests.el index bed797bdb14..5e013668a2e 100644 --- a/test/lisp/minibuffer-tests.el +++ b/test/lisp/minibuffer-tests.el @@ -108,7 +108,23 @@ completion-table-test-quoting (should (equal (completion-try-completion input #'completion--file-name-table nil (length input)) - (cons output (length output))))))) + (cons output (length output))))) + ;; Everything also works with `completion-ignore-case'. + (let ((completion-ignore-case t)) + (pcase-dolist (`(,input ,output) + '( + ("data/M-CTTQ" "data/minibuffer-test-cttq$$tion") + ("data/M-CTTQ$$t" "data/minibuffer-test-cttq$$tion") + ("lisp/c${CTTQ1}et/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + ;; `completion-ignore-case' is suppressed when an + ;; environment variable is in the completion bounds. + ("lisp/ced${CTTQ2}SE-U" nil) + ("lis/c${CTTQ1}/SE-U" "lisp/c${CTTQ1}et/semantic-utest") + )) + (should (equal (car (completion-try-completion input + #'completion--file-name-table + nil (length input))) + output)))))) (ert-deftest completion--insert-strings-faces () (with-temp-buffer -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 04:30:27 2025 Received: (at 77718) by debbugs.gnu.org; 2 May 2025 08:30:28 +0000 Received: from localhost ([127.0.0.1]:56259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAlmt-0000dK-I0 for submit@debbugs.gnu.org; Fri, 02 May 2025 04:30:27 -0400 Received: from mout.gmx.net ([212.227.17.21]:39815) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAlmq-0000cy-AT; Fri, 02 May 2025 04:30:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1746174617; x=1746779417; i=stephen.berman@gmx.net; bh=w98HOSKCbPCkibJxibl47yNCQbf45iT8o+80vFzx0vE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=XpeIAeNSqeFDWwCbGzApu1NQl9oZiYyodbzJi/jnpa2d8j4IHobAKKx94kP887fG jMjadSUk7H4NA/fJP6oDQlzFRQmOoS66i1yGbrKwrbJzMbmIorFpP9NMgAw3CsimX Ne+DDJg1rrWN2SGjGgBvNMYfyaUcU3sfqe2LTFAqCwufiZ/xBAVhDZpUxBgoy+BZk +HkEGidm+UCYx5kKxElqLWAiuoMxQR5qGZsXHAAPkOYQYiJQK8boajwAMVdkHqQeh F669ukqzg/QHye1VM1+b/KB5JUmnO7TfYV3KeZ1N+yLtNNpwYeCLR0uSlc7pY/EuO 9rYiBjwbizrcS5PinA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.219]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MRTRN-1uNEey2D0n-00Woue; Fri, 02 May 2025 10:30:17 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> Date: Fri, 02 May 2025 10:30:15 +0200 Message-ID: <87bjsbquso.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:faSer93x4I42gAdv/ubwDNoT2OrU3BAcd/SOV4o4hU3vVfuk8Hg g2rN9hA7bsITe0zI2qtNbI72HFizk6+xUkVMsyoXPfp/31olLTFU2nF7uTeMv6SIsLKWMkq so8/PL9jPSTuXgipwzGk9UyWUHm/ZfXirYG8XuzyRns01uxCFGKDwEAqkzsqIysIS80l4pr RmjLBDglud2BF+TGR4FHw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9gVJxcdjuAM=;5ZiGGspxd4sABycqv8FjoHM7GCc KgAQM/yhnYEmyX8cjeg5mZVnchx0jXgF7fkFdFywNH+S1qgJskKOMCOWtfCzXNoEyMh8v3fkO GHK9PGnSPd91rrdq9H0T7wplU/4kZzxNz53rVdoR3CQMUXcyig8c4OnzhcpLjFX4hVJgKciL9 tZmtypi70N3bZCq7V43EoP47bmk8ZVBOyoNWt2FKYKvLUDoZQirY1njXCGypFArakcCbPNg5U 8ITtPn6OPiDfMZy5SJWgrYDFfrA/4P7879g20CEPMxOkCtqbFR6sTw519AnqSLPLdMd/HUL4k Srx7i+8aFzecTsC/PEq/ZBokLeApTJNE3ljvy5Yo1UoWXdxTZjYn8i8l6gbkjcFg3N9ffGW2W 7Ekx/06tccnXW2Czr9Ym3vO9ATvHfzLOUi/uWMqvUvZzO1gslyp6qn8lJoxDQwQMaDQnKRxH7 7Ga0dRvo9py1SpdrBPjiiJZrMYtQm1CFeOVTr+25A5QCKxOId0iD6k7gO+Py/4y87ms44nlGM z2pQPBQ5FWPdFUb/QyGqlC2E3c3oTFyqV80c2iNKhG1rhe0SWTAZTPAuOh1fH/b6/IBYfgfec QrTw6F62YwWhOQ+1NPFqUbWo2XhNw/ZqI8Y7BsRNjFu/Z+h0kv7gYN8FIpfN0MpPSRw8sWQAv vamm/bNHhdvY5HrTAAUMIR8G6VseDHkeoLOQH3R428GO2y79dCnkIvlEMklwLajGwQacH4Uxe LNX0VTqg+CpI9jy0oI6LIC6kvNhPTRvgbyAqaV3HLIX8dlDHjCb8E4Fp+gpNSEqUrM6WQoLNJ WGkxWS6b6yoHR0NseBwpd2km9ZAaxHj3NP2E2YqIX+Pg+JppUyqXZesZvmCiwD+8xUN2tOE63 kyO5QPfu8gQYPyiTCYNjwHThujjjNe2fJMWQPxLku35NWnIy6n4sjmuutHtSJGNAMcDyrvFnN df0Sg8HihTxHAPz8puy9+TLjTmq3Vbt5Ru0sQikJTgf6JDm+nLGHFpC7ZDICiic/Jt5Pr8hOk SYIYcdn+PJYaVTDod6U2OhrJ7fS77AGQEOQRvsq8nGIRFIrwRsI3yMst5e1yKJ0iUGXSYKQx5 0+uniO2aL1UhFODY542icLcwQedUxx3cDxQjONurSV/3XozOtsrxjenYP8NZamtBZonZKAN8e 4dAPiPSmKY/8yCxIjMhGbyv06V+cNT8bl+fzrPkFoUN2ZBgBWSsS71gl8tD5Z4uucjhggENgs SycXhNdWFPpvXoPe8gk7TORI0+RiHAAThw/nct+2HIpwNn4q3nu48GZvZ9C/tFmoJM80ZM9Nq KMhl+l2j6VuNZGXQNjgRK0r7z6KX3LvGbu4Au3coZ1uiXmqOSnJfsUhzPK3+2GvF1rb39tdak ys+1U4iOhce5TBmYf3pQJClWEffk5H2cn93wNyoQndxr1avAz3U8RXnRDjJERVlvDFMFjC9CB oS1kFhq42s4yycf7Ep7Zg8Qj8IbpFauoYNCLZ6KFfvfFL15rd16leSs2jIBg5fVBTayOT7MQ3 Mrjt4CnuPl88H1eX58t8VeMFfkzivpxkq7o1UnoxOo5ho6yXtOjqTLZG58Pi5D+SdEDuIB3EW O26C6WiuOuSDBgxidr+zkgHj37sak4kfirMQHPOjmYWWLnpEEJdauUPRIyzT6qH/3MDDYVzbD GEnRtqiEYgeyed/ZxSsRhMM+weaX8R3LL8KbtCAZKRM9SGje1njpzFbMew24W1rlclqE6OXfg yGc3LI1M21QMH1kyn97jzcBvVQAJKMvr6wBKp9+HqxaMLSZhLlvAuVeUDAPCDGKrUQxRDmWzE 3X/eBa6+HGcign645cx4bpN0Yy5fqYWkylcLwRJEMd1EtVM1WAs8FiOu/e1TLboq18iYbfLfP RqvwODqMdB4sTLtFBCxsX3PfwiGvz2CkUFGDjk31EGasaXevrV5kCbJiHyh15umWP0368XjcL Fqy9v8uLA5x/V1G6IJV/MpjHxb0fOr3qIXwzZoPS3ZvPGzNnWeW9fku50mVsQlDCwsC7TQbmz TzF8yujYpdYQn/nEhLdTWCKH5MO4IqGCPDCP0CLFW3/UB59JJpWfIHqcZD1rFb+UQvU6z/UnG qv9Rc4KiJ7POsEQmG7kjRX9eBBHv572RthTd0hTDI4w0M4j0QBi9b2OK/VymefsCzGRbCEkVm Shw3NwiSV8klQeYIamTvbwnllRvS05TBSALCtOu0FZ55OpdL6/aYgU3ZqeMD8qpy3Ktcw8K9z TgO6FKaxlsomQDkwg2uQzcfU0n2lRbbrED7fBoq/eRwfgKTstr7fNfdqF8hR7Gysn2eKP43+w Ww1p5tp6BOGptIqf6GhpUdPnLeHVaZ4lp2qg7nO+pMbT7JUJ59fMg6OmWx3WrWqiJQZqM38Er kbmkVSB1nD6Sd6Ddcr7ZP/QkSLBOhdlYKXXr0nABRrhWwOwrX6bp1cVgv258ivOGNizFumXk4 /WC1NRBEdgWY8F2DeK2X3P76pjrfRJTtHHeYo/WJnRtVWL6cPFszRjIbhs3dOfQ93kS4lOg23 CQ7tibqyxNiVBtF+bLvo3bKihprGveqLL3bgkl+lgiO9xEPHV8Dmq3VQTO9TILBdnuCcqELdZ oECuUFgQEQhcDml/EBILXXdgW8yrIgCBpre7TmXBJ2Sbj9vyAsYzYkpAEhuU9VeyETXni0QD3 YNS+GWTD2VKa4LobNCsHfdsOEoIJPxNK7eiPrNsN9yXEgSWjKFdjjC+ZGueIRJukOitlkTi72 YUUxSp0I+Zfjz1zpVhURjg1vlNiieHLSaH6tJlIgNn4Jift6sAUf7AI5TFXq2K28LKXWuYLm2 8PLAOnPkhHvzjNYDLGQBNsjVdeIUtaRmL+YfkYcHqcdiV6MFoR+DBCGASXHurw3AWpt3WUap+ N0iOxaYA4PtlXQ/ORAXMcJFdvhwGszReAuP0SCU0wm4KuX/zl1V9r0vWnKOwm9SDKaI5nVPSS iEOD0N0ceokNbE22xrWBCL/7GuULb2CnS4iUm1OogWZgifqJhf76h2XhCCXJpdEzFTltjypwd 44Zk9AiD4GpXBPigO3ibIoYmbl0ZkTdMFY9cnzrkgJmF4sH8KV5pWvpVKoZYx4gA7G/VKn8b+ 22miSrX+FvVRU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , 77718-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, 01 May 2025 13:59:48 -0400 Spencer Baugh wrote: > Stephen Berman writes: >> For the other regression, here is a reproducer: >> >> 0. mkdir /tmp/{Test,retest} >> 1. emacs -Q --eval "(custom-set-variables \ >> '(completion-category-overrides '((file (styles substring)))) \ >> '(read-file-name-completion-ignore-case t))" >> 2. Type `C-x d /tmp/tes TAB': this completes to /tmp/test/ >> 3. Type TAB again: Emacs dings and shows "[no match]" >> >> If you repeat this recipe in emacs-30, then after the TAB in step 3, this >> completion is shown: /tmp/Test/. and typing TAB again pops up the >> *Completions* buffer displaying the two completions ../ and ./ >> >> While the result in emacs-30 seems suboptimal, since it omits the >> possible completion /tmp/retest/, still it's better than "[no match]". >> >> A workaround for both emacs-30 and master is to enter at step 2 `C-x d >> /tmp/*tes TAB'. This shows the completion /tmp/*test/, then hitting TAB >> again shows /tmp/*test/., and hitting TAB a third time pops up the >> *Completions* buffer showing the four completions Test/../, Test/./, >> retest/../, and retest/./ >> >> Steve Berman > > Thanks for the prompt and detailed report. Does the attached patch fix > this issue for you? Yes, with that patch my reproducer now gives the same results on master as on emacs-30, i.e., the patch fixes the regression; thanks! What about the other regression I mentioned? Have you looked at that and tried the fix for it I included? If there are no objections to that patch, I'd like to install it on master. Or if there are problems with it, I'd welcome a better fix. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 08:27:07 2025 Received: (at 77718) by debbugs.gnu.org; 2 May 2025 12:27:07 +0000 Received: from localhost ([127.0.0.1]:57202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uApTu-0007hD-HD for submit@debbugs.gnu.org; Fri, 02 May 2025 08:27:07 -0400 Received: from mxout1.mail.janestreet.com ([38.105.200.78]:59389) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uApTq-0007gN-CP for 77718@debbugs.gnu.org; Fri, 02 May 2025 08:27:03 -0400 Received: from mail-ej1-f69.google.com ([209.85.218.69]) by mxgoog2.mail.janestreet.com with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) (Exim 4.98.2) id 1uApTk-00000001aWR-2yEm for 77718@debbugs.gnu.org; Fri, 02 May 2025 08:26:56 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ac3db5469fbso156062866b.0 for <77718@debbugs.gnu.org>; Fri, 02 May 2025 05:26:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=google; t=1746188816; x=1746793616; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pr8vLHCYo6oKy1YWuHt5rRIVQGVwN7v21APZ31sVpTc=; b=HpHDwq0ChKHz09nSa3IFsjRYPWddZoFkBB1LlrJUChjzwxD/0ASvuJovcIqvzN9gBf BRR40Oz4JzCQVX+aXX60rDWetHYRX5fZSTL9KcKuydtzeAXiuGqss4Yhc3iybO9detWV JUzZGgYDaAYbCOeaoLyL3/PITGulfZhgmzseI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1746188817; bh=pr8vLHCYo6oKy1YWuHt5rRIVQGVwN7v21APZ31sVpTc=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=L9FlGJZkZauDE6RzFwmiBCQjrkYIpraRe4JWDE6d91DQVVQyhUHAqr+H2S9DxEUON 6L2pjk7NqBSrClL786R1UI2vDG6uHFSGb7tH9SPqkn++fU92qrW4B2jQi68i7cC15g RabKP1vco0k4xLJLO65zD41CX/c78drRsp2y+DX4HLXs89N0mbrYvnoeeq5fqlYfoZ PFgX3btkGAHTtlKUupxnPxDayo/gs/g9ezv/nea/KpLd4UA0OA0NXO8n3adh7Yfzm/ FYtwUHxAwDY2sCXfgrpFsl7eKAWYX8v2z6Isgfrd6uutNQo7qWdbbfiqMZDYZ0HBrK NISsJy+69wnVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746188816; x=1746793616; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pr8vLHCYo6oKy1YWuHt5rRIVQGVwN7v21APZ31sVpTc=; b=dOw7nOJhya69TutTpJORHHTWW+jolG+nVNqeKfBfgYSgSTAD2gsShysoD5kc0TeGEU nMHYEzuknHduOzU8Oxrn9sAESHivlmBqsBiHEArdazQ/gdxxlTsQ3/VKYvXgTQrIKUXc joOlNhqRlMAPi3lw//TFzTujtr5GagEyp6+wrAFs3wjnUtg9NVcTcejR1s0EjDLSwgJW c9Kl1PUEAlUjfaK0/VFTsQWTR6pC4CmQMqmjjBfgcz/++RuhMrMKRp1eNeJCzdGgZZen osM51SaXxmfH1bihqWLNM9ktKXmnLkVURDbPxkNb68Ljx+eJTYm+uJStlIkU9gDGN/rw G1dw== X-Forwarded-Encrypted: i=1; AJvYcCXxvcxHxL5ujOobK+oo9s1s3zh2naUbkGBRmo9RZyq2HexMj/Grss2vfni3bCJ3vixv9uH4fg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxiCJ1r66WNWYYBXsnjP75g+wB8iIjC8txfiys18GyO1xAlwoHR 5tBqSKyz8M0J/RSPVVO/cm27VWJj8CtScQBlnMIBxSwSo2XHzxkQ1bGLzFa64Q55kS1LcjAeTLS MyAOAnqSOnRi+3ucWg4sLqaS9ATS9lqUIctaQsCjZ4EJzbNLAZi8Qy6p5ESCDEyhNy1f8DPNyVz fU+dTLCxPt56AeuiyBxG5k/bU4uQ== X-Gm-Gg: ASbGncuCryLSTPOePk0An1VeXAD0mtteLkwpp4KDAqZQhTKf2Yh9qQQiaNJfBImXDCF fVdRin4D2EWJD8aKtLAKWVTpm7o0oCHqg8wSgt45afiQ/A86FhTxVz3T71s9y2f/wcWWc X-Received: by 2002:a17:907:1999:b0:acb:b966:3a8f with SMTP id a640c23a62f3a-ad17af47f9fmr251265966b.39.1746188816045; Fri, 02 May 2025 05:26:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9oIQIcAwBKrN8ghyf3VMhO5bn30U805oGghLb+NJPzy+cyd2mPT82EF4JCWIX7cGTiZ1WPs/H94EkYVCpflE= X-Received: by 2002:a17:907:1999:b0:acb:b966:3a8f with SMTP id a640c23a62f3a-ad17af47f9fmr251263566b.39.1746188815745; Fri, 02 May 2025 05:26:55 -0700 (PDT) MIME-Version: 1.0 References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> In-Reply-To: <87bjsbquso.fsf@gmx.net> From: Spencer Baugh Date: Fri, 2 May 2025 08:26:44 -0400 X-Gm-Features: ATxdqUEZ96M3RXIpU8w2JvYJ5ceCOyiShwtb8BbJpghs4oYClnpEx6BIu5bKwuw Message-ID: Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken To: Stephen Berman Content-Type: multipart/alternative; boundary="00000000000012d7ec06342644c1" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , 77718-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --00000000000012d7ec06342644c1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: > On Thu, 01 May 2025 13:59:48 -0400 Spencer Baugh > wrote: > > > Stephen Berman writes: > >> For the other regression, here is a reproducer: > >> > >> 0. mkdir /tmp/{Test,retest} > >> 1. emacs -Q --eval "(custom-set-variables \ > >> '(completion-category-overrides '((file (styles substring)))) \ > >> '(read-file-name-completion-ignore-case t))" > >> 2. Type `C-x d /tmp/tes TAB': this completes to /tmp/test/ > >> 3. Type TAB again: Emacs dings and shows "[no match]" > >> > >> If you repeat this recipe in emacs-30, then after the TAB in step 3, > this > >> completion is shown: /tmp/Test/. and typing TAB again pops up the > >> *Completions* buffer displaying the two completions ../ and ./ > >> > >> While the result in emacs-30 seems suboptimal, since it omits the > >> possible completion /tmp/retest/, still it's better than "[no match]". > >> > >> A workaround for both emacs-30 and master is to enter at step 2 `C-x d > >> /tmp/*tes TAB'. This shows the completion /tmp/*test/, then hitting TA= B > >> again shows /tmp/*test/., and hitting TAB a third time pops up the > >> *Completions* buffer showing the four completions Test/../, Test/./, > >> retest/../, and retest/./ > >> > >> Steve Berman > > > > Thanks for the prompt and detailed report. Does the attached patch fix > > this issue for you? > > Yes, with that patch my reproducer now gives the same results on master > as on emacs-30, i.e., the patch fixes the regression; thanks! > Great! It should be good to install if no one has any objections > What about the other regression I mentioned? Have you looked at that > and tried the fix for it I included? If there are no objections to that > patch, I'd like to install it on master. Or if there are problems with > it, I'd welcome a better fix. > That fix is not right and would cause other issues. I will look at it soon; it's lower priority since completion still works fine. Part of what is needed is just to update rfn-eshadow. > --00000000000012d7ec06342644c1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, May 2, 2025, 4:30=E2=80= =AFAM Stephen Berman <stephen.= berman@gmx.net> wrote:
On Th= u, 01 May 2025 13:59:48 -0400 Spencer Baugh <sbaugh@janestreet.com> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>> For the other regression, here is a reproducer:
>>
>> 0. mkdir /tmp/{Test,retest}
>> 1. emacs -Q --eval "(custom-set-variables=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 \
>>=C2=A0 =C2=A0 '(completion-category-overrides '((file (styl= es substring)))) \
>>=C2=A0 =C2=A0 '(read-file-name-completion-ignore-case t))"=
>> 2. Type `C-x d /tmp/tes TAB': this completes to /tmp/test/
>> 3. Type TAB again: Emacs dings and shows "[no match]" >>
>> If you repeat this recipe in emacs-30, then after the TAB in step = 3, this
>> completion is shown: /tmp/Test/. and typing TAB again pops up the<= br> >> *Completions* buffer displaying the two completions ../ and ./
>>
>> While the result in emacs-30 seems suboptimal, since it omits the<= br> >> possible completion /tmp/retest/, still it's better than "= ;[no match]".
>>
>> A workaround for both emacs-30 and master is to enter at step 2 `C= -x d
>> /tmp/*tes TAB'. This shows the completion /tmp/*test/, then hi= tting TAB
>> again shows /tmp/*test/., and hitting TAB a third time pops up the=
>> *Completions* buffer showing the four completions Test/../, Test/.= /,
>> retest/../, and retest/./
>>
>> Steve Berman
>
> Thanks for the prompt and detailed report.=C2=A0 Does the attached pat= ch fix
> this issue for you?

Yes, with that patch my reproducer now gives the same results on master
as on emacs-30, i.e., the patch fixes the regression; thanks!

Great! It shou= ld be good to install if no one has any objections=C2=A0


What about the other regression I mentioned?=C2=A0 Have you looked at that<= br> and tried the fix for it I included?=C2=A0 If there are no objections to th= at
patch, I'd like to install it on master.=C2=A0 Or if there are problems= with
it, I'd welcome a better fix.

That fix is not right and would cause othe= r issues.=C2=A0 I will look at it soon; it's lower priority since compl= etion still works fine.=C2=A0 Part of what is needed is just to update rfn-= eshadow.
--00000000000012d7ec06342644c1-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 08:44:19 2025 Received: (at 77718) by debbugs.gnu.org; 2 May 2025 12:44:19 +0000 Received: from localhost ([127.0.0.1]:57278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uApkY-00007I-Un for submit@debbugs.gnu.org; Fri, 02 May 2025 08:44:19 -0400 Received: from mout.gmx.net ([212.227.17.21]:33291) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uApkS-00006o-OI; Fri, 02 May 2025 08:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1746189846; x=1746794646; i=stephen.berman@gmx.net; bh=4VFUsFyqvSOt/sLNkoEbOXu7PhLMV4wQl2/l+7C2ZKU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=aiQwLaozYNfL2z9zxrqsG+GBT0IoBiNx9yScWE6V2PPv11+9S1GFhfYhJPRSxLx9 EUs89MPFQuPqf9aHYJelRKKafSULNPTLy5L634Mq22MsEBjWi9glWlTVzMIrgm7FC 15BStbevEmSga83y1oiXCgHoIay2ChmgFbz9gNwx4RF45b8DPdQ6RMpGhWCWaxUb6 yILO6tsr2zFf8L+A7meuMOE5zGC4n9cAIeC/CaAzUme7NdxLfOaPXJKtkM2QZruYc 1wDULUh4FQY/8yLjwZawemjSgomDEIs6Oz3PmyyDAIb4sZkT2iMvfJpiFwdNCSIE/ w/g1UfXFPk3pBXLthw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.219]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MjS9C-1uvOma0nvO-00Zp3v; Fri, 02 May 2025 14:44:06 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> Date: Fri, 02 May 2025 14:44:04 +0200 Message-ID: <87o6wbp4h7.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:dbtloCO5HUEbhCyoCOW8+Tlj/YSuc/6bGwLd/RQzd/F89meaOFb ojh/8/LNy3DWFlTcNga4eeO0aFuRwIe1MlUkfavtceDT6O+9YiQaxRDt2eM3ePNG3lVUx4j ohfugXKVXyfPoh9EiYdi0n0+jWL0w0ifFu1sLGdb2QFEcxWH3TGtoA4Zn1DS5GNG0vfl92N DM8Tt0Le+6X3OLBm0vEXw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9Kxk4baQTTA=;fVfWvagJCL9J+t85yexHcFlCoc0 zVIIXvpjhk+hE1j/QpwF70+BlWQcRpsQ1qn+niT3ATcMcQZJ1q6MRRd8aJ+4d5NSveDbtKSqc O2NAcwwgyo+r8QMpVJqbP1T+1zoiSOt/FhbfpIhqip0oYRlAJ6eqoAL9hDbZOMqmBdEDl/UQt gv9AURuoaKrP/fQRsfN4cqaRFgdZAS/ekrjuH5cLoK8iAFjhXyxH0FDWtinUqsS8EAemzj8+u MS8otjol7xF5ypF6t2DYZWx8lrPKl4k0k/D561m/XLyrmo0+usUWHWDm19tmIlzzXRU0kOnXo ihTcjcNrdtX6bN5x2qgrVTUI++K3bcuw7oKEKxNaobOADiQXMLW/wxTTFvRr5+7PRba5O3uQx eZUilhNlkosdpRFAcLpg2W7eOSiUDUChJNGZrdNigimlCyKWOVJNWT/Mywq2i3Y82fTSt1upD nvg3xWQMZovBpMKtU9erhx9+oCpCiitYEqG/JlvQyOR2ruuDk5Ai5pbJfj5UGCeU+G5vG0KqD 1RHyqJ3rTkP9pzMHIK2pi7wTaRAjLbA/UHvRXYj50nBJ7g3BA3Cp7VE2D6TtPMd61hHdVNwoi mVKUeu2KCJUErj7Oi6zsOUbR1Ty6iWZbWogb9wNidGXijrRy2m0Ru0Q5hL6oz9WQd4ubr9Chb GusZBVq36QJYT4duQw7JFJ9Qe7zuUFuS+in1QwKg9tU8990TJCc19Wn297UujcUA1yzpxx/+9 537Zx5qmgP10cs3QSnOW6guQXZ6BhHz2dtVq0ZARfWCqTqG/sNY0TM8kvprJonpVTr+K8QKuk HAWzWNnezusNIwFYMtbmkFUF8iXN0S9pM44+JoyktsF29FJbMgnEDGrBaoWBLYFNPwq6LTTip NH6vIBIKWKA+McEG89NHehJ3x5pSY1/YulV940n1tBaSEl497rHK8OCFKSMYeWghM6QtnZIlW 7ARq9y/jth06EpfpCfOuOpbW+rjf4xLTyCWpMEexJY0VVK3RTuace3jxJP9AOdp9Nx1z4E9Wk jXJoj/dfYQOgpcQy0qGOYCE9lsbU7gfLVmj5rTOnweShUTQkP0Xz8A6BjKf5SWRhubKHa1c5m L6t3FMLri+cti6aYkZY4mG7Q3RA1mlWnuFCPhtgks/9ZbOh4Odq505zVMfNszgqkU1ffL/HWq rCVpe5OgbyWQvpuLYozJhuLsqVxth0K9Yt/SgnHkVE9dpgMvg9Z6D7CdhrDMeeBTmU8d4GJ3A gCuH6HpfPPd9kNoTbPwG1/tUmJQ3SsKFFNISOB4xQWf2dDi0EIc5VJrlMDZvOdbs2O9fNVJbA oAzIwu3SvyVQCnohG13Krw6Mbxk8YzxlQ8r2DwugnHrdBMbev5pY+oWN5Prifod/1GKpBZ7Sb 4rnvyMGExKR0DIQHWtPNs2CyF1ayC1q3l9bhqJQNsFG261jzoWQHkFr4Ptvp2SXaxo4GDO8Lo TR+db1z1pTeXFPV+Fw30xiKXxAem3vAbUQmtawwtJ1VPasmj3AArBGbuv+d24RAoX7BOBbZUl brOguoo7du6CUTviEgMmMwLp9e/AlaERXnRcVGlMrRVhhI0Qmc6P31cfjn52SFKB1ZZ3EJFCB QWNKx+v8SfgYKSMcUt1KOFghR66f8NC+04gYb81uggGKL01Mzg8Y8j6FRrOT9cIDImRouf5uM rl/T3G1cf9CDAwa3NiLoj9UY4wUUV5bzUM++etV+lOHdz6bW8PWPG7ewpATc4DFYE2hlZOEEJ p2DOymlEy0TsBY/m+ZpskkPXdT99ZjKVPatlmLrVRI55xuVjD3XYv8N664+BrDiI5kNKGeBVn 8IX3U0AkdGjJfVu1MTm6sJKG3ir8eEzVAs3qnhJfu165B2PyVCPwUI43M0Lj1K7M4+JaFUvz4 PO/zIB2UJEINNiJv6D2uqILZziD8/FM0LW47utNYDpmt/y8G2GqyWTpSJoK71jIumFPs8HZms LOMNgdkT2Kv90Rpxe/yxwq4kj9nqCk39tgFXCNMymKpRAwHW0V/t4JsO17ZmF9nGxI9WmtRe+ 94Rlg8R5hw8xfT68SUt47gCB/7UgQgZj16Y1ZBxC6ecADaRiHZLBxElMp+wf9IObYH7ZXLLu1 K8d8fXISVh97rjeGfYikgmHUIAA8L+ee7FvO8dt/CgvYSlVW8xm+eL73jAXb39mJh+AZKho8m UR3dYXLJIVgfzMPioGxbaiw6X/RrX/4CHdyDOWdTM7MFRH0SGX/9h3gLgR0VZQv1hlqY46UYs hqGRUrgdnKXk++YzynjgiSZzJyOAdiiQgOvJAiHpD2PrDiRguGd4b7i6n2PXZaw05bEfMJSgN Ze3YGz4fmQUjbzQ/iXR57SHbiItu8s1FQchQNWgEqQG/Je2W+KxRZP8sPY/i19CpKouQ8K6T1 yC8CP6FQ73NlJviOXHTLqoqPHYTiRGpDtlUmSIcwkBpYEzULBU6t+DRQnpBqSM8ycKtFrI2Of 1OeAsSRgRhAySEV2FklhgPhseRQkDavkp50lAv7jQz0yEZdWgPXo6obi/zgJvo8HbuBe5dfKt ffTubfNGzZsKLlypzLgUQIMpZiMYk4+trjpJqPeLWbj+iGDEYLOT4VJFjMGbkdgJOcOXnekoL aa4cyoG4YAHkUzD5OQBNrL8AtBuN3StYusoFTNnjhwusHtqWjswWhN+kWWXdGxuNrQmlkod2K NuwQwVviX99wnLzEcBnJVvc+KCrZ6n3cayEfSPauEcfvEhwmTd45vlC9kKcACuEhlCJkMsiF9 gvrYvbMIQqZq2RIj/5RulUdHKApQXaRI1bWSsyKi6z+2HHGTIy9AyX9vCMP5pVxetFPFqZzD8 q1txushL2hj6VSNfh9rsy4YMgBUeuHsR78dANnbSn6b1Q2zd6T4dp/5IMM8ryIn/uXCah6j9d 94SD5C4McGuMb6zDVoj+vW+kjIal2wYDMLl6w9OJFRUVhvce6XWxZYKJ2mtn5aUffETD087yr fc0dmyazs9O0LsxXko4NnY1k8sZQ4vYQQ+TsinrSLt37cuOaiJHsA0kq3Xx/khwQnasF6v+hd uTkXmFwp1weLEtt8Az+rB3/2BhWDpNubcItvArmZ3WfvQm89Hqw+vigRrRVcZXqbQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , 77718-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh wro= te: > On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: >> What about the other regression I mentioned? Have you looked at that >> and tried the fix for it I included? If there are no objections to that >> patch, I'd like to install it on master. Or if there are problems with >> it, I'd welcome a better fix. >> > > That fix is not right and would cause other issues. When you have the opportunity, please say what those issues are; I have been using my patch since the first version of your changes that introduced this regression and don't recall any issues with it with my setup, but admittedly I haven't extensive testing with -Q or other configurations. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri May 02 12:05:13 2025 Received: (at 77718) by debbugs.gnu.org; 2 May 2025 16:05:13 +0000 Received: from localhost ([127.0.0.1]:60777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uAssy-0003sE-8S for submit@debbugs.gnu.org; Fri, 02 May 2025 12:05:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54721) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uAssq-0003ms-Ll; Fri, 02 May 2025 12:05:05 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E71E68089D; Fri, 2 May 2025 12:04:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1746201898; bh=X8cmfO0mipnHpAeqx8ZG1NBirHQgcb4xltgzG1W21dA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Mv3RiI/LIS336I935oYXU0wemMLtAEiq87gCN0sOFN21v0VnuLIdVMcMrTdv4Bhfb mtT3fWK1aqguheRvwHrgMDgRabUkHh4Kca6bnGiqCjpZ3JQ/vqpsJjIjhBgdVWMHaN lJ0/IULAJbibU9Cg+TGpHcubWYBpvQViQ5/CIOmkk6sTPgYtagN4R2znYUOaHhDJce gkNKVv9LdH6bdc2Mjd6SGxHJfr/1MWCayu5lraRrLECXARPkWm233LlFnqC8s9IvPV m4t9vn2dHln2FmzJbvYmUrMBNLia32+fJrLOQFxW8vKr9EuLO1abRTvdo6ZGW+/v3O CceJVD49n5THw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 07E1E806F8; Fri, 2 May 2025 12:04:58 -0400 (EDT) Received: from alfajor (unknown [23.233.149.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C5EA512023C; Fri, 2 May 2025 12:04:57 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> Date: Fri, 02 May 2025 12:04:57 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman , 77718-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index 7b2b986aa1d..e35db9dad64 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -3597,8 +3597,18 @@ completion--file-name-table > (if (eq (car-safe action) 'boundaries) > (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) > (let* ((sifned (substitute-in-file-name orig)) > + (orig-start (car (completion--sifn-boundaries orig table pred ""))) > + (sifned-start (car (completion-boundaries sifned table pred ""))) > + (orig-in-bounds (substring orig orig-start)) > + (sifned-in-bounds (substring sifned sifned-start)) > + (did-expansion-in-bounds (not (string-equal orig-in-bounds sifned-in-bounds))) Doesn't this set `did-expansion-in-bounds` to non-nil if there was a $$ in `orig`? > (result > - (let ((completion-regexp-list > + (let ((completion-ignore-case > + ;; If we expanded an environment variable in the completion > + ;; bounds, don't ignore-case, otherwise `read-file-name' > + ;; can return the wrong filename. > + (and (not did-expansion-in-bounds) completion-ignore-case)) AFAICT we're not "doing The Right Thing" here but falling back to a suboptimal behavior that favors not returning bogus completions at the cost of missing some completions. And we do this because doing TRT is a lot more complicated. I'm not opposed to this trade-off, but the comment should make it more clear. And it should come with a good example of the wrong thing we're trying to avoid. > + ;; For each completion, quote dollar signs in newly added text. If sifn > + ;; changed text within the completion boundaries, replace that with text > + ;; from ORIG; otherwise, use text from the completion (it may differ if > + ;; `completion-ignore-case' is non-nil) Here also, clarify that we choose between those two because just don't want to write the code that correctly merges the capitalization changes back into the non-env-var part of the original string. An example is probably the easier way to illustrate the difficulty. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue May 06 11:39:09 2025 Received: (at 77718) by debbugs.gnu.org; 6 May 2025 15:39:09 +0000 Received: from localhost ([127.0.0.1]:59817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uCKNw-0007YW-RP for submit@debbugs.gnu.org; Tue, 06 May 2025 11:39:09 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:47233) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uCKNu-0007Xd-C2 for 77718@debbugs.gnu.org; Tue, 06 May 2025 11:39:07 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Fri, 02 May 2025 12:04:57 -0400") References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> Date: Tue, 06 May 2025 11:39:00 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1746545940; bh=QeHRzLXjQDOZfKSeXBahYN8idE+7yZ5npeP805cpxjU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=UH50K+vDl/1jqvNLp471lqj0JKgGeH80dAR1ADAxgpuae3X+UBjZgiCqvh91Ay31u RN0bjpWMY+0P/eSqnvnInCMemxnHQQRUsZ612Sys7k3G4mZywQ3RQf13OxfD/7es8O HQYZYB1hcQ9hM9zPbDNd+TQrTHMbi+cX1dzhxMTsRrBUvlqC5H8NUW+sXcQB15FEpE znNsmHrsK/ZTQZIyhoCPEBnUYxBS1WLTMA7Faa+v1nUlws826EWqWvytQfEUgwgwYp jMuQK03jvRUGJBNxKCRt2ZfD6MnASP1uT+ub2tYF1bqQr8aT/xVk6JDHXEDh69evHP ap8yn6ZhdGLaw== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman , 77718-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index 7b2b986aa1d..e35db9dad64 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -3597,8 +3597,18 @@ completion--file-name-table >> (if (eq (car-safe action) 'boundaries) >> (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) >> (let* ((sifned (substitute-in-file-name orig)) >> + (orig-start (car (completion--sifn-boundaries orig table pred ""))) >> + (sifned-start (car (completion-boundaries sifned table pred ""))) >> + (orig-in-bounds (substring orig orig-start)) >> + (sifned-in-bounds (substring sifned sifned-start)) >> + (did-expansion-in-bounds (not (string-equal orig-in-bounds sifned-in-bounds))) > > Doesn't this set `did-expansion-in-bounds` to non-nil if there was a $$ > in `orig`? Good point, I didn't think about that. That's probably not acceptable... fixed in the latest version at the end. >> (result >> - (let ((completion-regexp-list >> + (let ((completion-ignore-case >> + ;; If we expanded an environment variable in the completion >> + ;; bounds, don't ignore-case, otherwise `read-file-name' >> + ;; can return the wrong filename. >> + (and (not did-expansion-in-bounds) completion-ignore-case)) > > AFAICT we're not "doing The Right Thing" here but falling back to > a suboptimal behavior that favors not returning bogus completions at the > cost of missing some completions. And we do this because doing TRT is > a lot more complicated. > > I'm not opposed to this trade-off, but the comment should make it more > clear. And it should come with a good example of the wrong thing we're > trying to avoid. Yes, that's true. I'll try to include a nice example in later versions. >> + ;; For each completion, quote dollar signs in newly added text. If sifn >> + ;; changed text within the completion boundaries, replace that with text >> + ;; from ORIG; otherwise, use text from the completion (it may differ if >> + ;; `completion-ignore-case' is non-nil) > > Here also, clarify that we choose between those two because just don't > want to write the code that correctly merges the capitalization changes > back into the non-env-var part of the original string. An example is > probably the easier way to illustrate the difficulty. That's fair. Though to be clear, at this point the issue isn't really the capitalization changes. I have what I think is a pretty much correct approach for that, where we just give up on preserving the environment variables if the capitalization changes can't be merged into the original string. That approach works great if the text inside the completion boundaries in ORIG (the original string) "matches up" with the text inside the completion boundaries in SIFNED (the string after s-i-f-n). But, when the last component of ORIG contains an environment variable which contains a slash, then the completion boundaries on ORIG and SIFNED don't "match up". The completions returned from the underlying table will be for the boundaries on SIFNED, and need to be adjusted for the boundaries on ORIG (by adding additional text in front), since those are the boundaries our table returns. e.g., supposing SLASH_B=/b orig: /foo/bar${SLASH_B}az orig split on the completion boundaries we returned: /foo/ bar${SLASH_B}az sifned: /foo/bar/baz sifned split on the underlying table's completion boundaries: /foo/bar/ baz underlying table returns completions like: baz1 baz2 we need to return completions like: bar${SLASH_B}az1 bar${SLASH_B}az2 This is easy if we ignore case completely, and that's what we do in the version currently in the master branch: Simply replace "baz" (the text in the underlying table's completion boundaries) with "bar${SLASH_B}az" (the text in our completion in each completion, and we're good. But if we want to preserve case, then even if we don't care about preserving environment variables at all, this becomes difficult. e.g. if the underlying table returns completions like: baz1 Baz2 Suppose we're okay with returning completions like: bar/baz1 bar/Baz2 It's still unclear how to compute that "bar/" is the text which we should prefer in front of each completion. It's hard to even figure out that this ${SLASH_B} scenario is happening; I haven't yet thought of a robust way to figure out that there's a / inside the completion boundaries in ORIG. So instead I'm trying to side-step this problem by identifying the simple common scenario where the text inside the completion boundaries doesn't contain any environment variables, and then behaving right in that scenario, and just blindly preserving environment variables heedless of case when not in that scenario. Here's an attempt at that, do you think it might be fine? diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 7b2b986aa1d..6f9e6c67541 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3597,6 +3597,16 @@ completion--file-name-table (if (eq (car-safe action) 'boundaries) (cons 'boundaries (completion--sifn-boundaries orig table pred (cdr action))) (let* ((sifned (substitute-in-file-name orig)) + (orig-start (car (completion--sifn-boundaries orig table pred ""))) + (sifned-start (car (completion-boundaries sifned table pred ""))) + (orig-in-bounds (substring orig orig-start)) + (sifned-in-bounds (substring sifned sifned-start)) + (only-need-double-dollars + ;; If true, sifn only un-doubled $s in ORIG, so we can fix a + ;; completion to match ORIG by just doubling $s again. This + ;; preserves more text from the completion, behaving better with + ;; non-nil `completion-ignore-case'. + (string-equal orig-in-bounds (minibuffer--double-dollars sifned-in-bounds))) (result (let ((completion-regexp-list ;; Regexps are matched against the real file names after @@ -3611,21 +3621,21 @@ completion--file-name-table (if (stringp result) ;; Extract the newly added text, quote any dollar signs, and ;; append it to ORIG. - (let ((new-text (substring result (length sifned)))) - (concat orig (minibuffer--double-dollars new-text))) + (if only-need-double-dollars + (concat (substring orig nil orig-start) + (minibuffer--double-dollars (substring result sifned-start))) + (let ((new-text (substring result (length sifned)))) + (concat orig (minibuffer--double-dollars new-text)))) result)) ((eq action t) ; all-completions (mapcar - (let ((orig-prefix - (substring orig (car (completion--sifn-boundaries orig table pred "")))) - (sifned-prefix-length - (- (length sifned) - (car (completion-boundaries sifned table pred ""))))) + (if only-need-double-dollars + #'minibuffer--double-dollars ;; Extract the newly added text, quote any dollar signs, and append ;; it to the part of ORIG inside the completion boundaries. (lambda (compl) - (let ((new-text (substring compl sifned-prefix-length))) - (concat orig-prefix (minibuffer--double-dollars new-text))))) + (let ((new-text (substring compl (length sifned-in-bounds)))) + (concat orig-in-bounds (minibuffer--double-dollars new-text))))) result)) (t result)))))) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 02 06:38:38 2025 Received: (at 77718) by debbugs.gnu.org; 2 Jun 2025 10:38:38 +0000 Received: from localhost ([127.0.0.1]:48982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uM2Yw-0001BN-8G for submit@debbugs.gnu.org; Mon, 02 Jun 2025 06:38:38 -0400 Received: from mout.gmx.net ([212.227.17.21]:47309) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uM2Yu-0001B9-KC for 77718@debbugs.gnu.org; Mon, 02 Jun 2025 06:38:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1748860689; x=1749465489; i=stephen.berman@gmx.net; bh=1XjFd/4ej38YvSvJKI6RizbxEXki87YQD7c3Sj8YpCg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=KKzUpYQ/jWsGMsqSYrfrFfntN73IITLG5/2knypJer9xxm3Cxpf8cphRelfZnGRr p6P02QJABzBnVewBzTMeYsMfNyzVl+5i+zRnzXyv3Nsq0hamHabG2FWFcrqHan1tf zINX7cNQnG03uoIy+IEHXlMAgldvBXTxlh2aSZOSx8z+ZlS6C7VqQ8lgyXZa+yDCB +JXsWk30utZOI9RkkOiOp/iDbANAYAgWl2qFJPLxdeMReyrfV4j6ktqDXdv7Vx+ZZ QQJtEHm+Pm0JxclmCBj4JoR95LZ/5DjlAkyLA5fsf42zLrSz0KmhUYso6vVgBBWGG n8XP7j9qLNRj/SBYcw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.95.182]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M8QS8-1uHchd1Xpw-002X3P; Mon, 02 Jun 2025 12:38:09 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87o6wbp4h7.fsf@gmx.net> References: <87y0w7ejxy.fsf@gmx.net> <86a58ihrfg.fsf@gnu.org> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> Date: Mon, 02 Jun 2025 12:38:06 +0200 Message-ID: <87cybm2zu9.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IrtU0s8pMHekMuxe+XlqqpEgcXvF+m+Kf9cAZvSaaVJH76Tpgjv ZQgeTwjdM6TAMsDEf6SfjQGnmBTOEMQ7gcDKU3LrqvXRLKLt5F3NvnfkcxgbrNiDaHlXJFe 8TEEQQLN/2+GjBlpEbUcub/sLyxfjvT+UBiuqFp/gcKN5Y7Sb71YmBEwLl9dnZPwFhp/rvf 6ialoAQyMTV+KtvHNoeYg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:pysWxhx3/Gg=;DJIrQkwKIpCbjy6e/jpGl3hoXw3 bFnvIIuFfiGEiVdZ8VO8/4sge3jPRmVW5SbOY8Q6vU0iBAMlAC5Mjr7k0dkMDem1uM63qNdHA CYCtpMc5cekUEBEl+qc+6ATmyTvB91mj4xF0+14BvcmfNviEiAUjNDNGn8o5eBk2+LPgEAYOw 8f8adjfCaBzuVUu4pij+h6VNQEqgg/aw8EeIUmzQwZcuJCgXX9zBM/JySyfQZKQUaBv916Tz9 x9pi1RVWMkFk/qdCsgR2w2oKa2DoBBkrd93+aoyQVRzBilwHvUP8zbJOI77/2WWyPWoF0Dns7 iRvGg29flif8987FtTo425nWtPbGkLpC+DODw7ah2T8TRVoC0IjPkEy9J9EXJi7Inzk5mYDVT bQkvHeqMAEuEBr9Tur96gwI6IwSPu3n+G3IVRSlVMmBqoEJD5HbY0Tifx5+70unltMBwjrNW4 P16D5szLXxGliN5VeKYkQfvKMSpZ8VBcUx4qNfsWXAMzkbbpgtHKH8xi32785MK/Dwpsf99ze 95OHqr0TwT8w2N92f+vsDL4jfgGojnHWD8LGxUfp/9SePjynfeF6a72jUlLOwTG+bc1MNO0NM oCaZm/PcJZwd93E4LTSTUEGqkQp+HC0S7mtV695ciBPsvDXZ7a6DsmPuuJWuC2l+DSulcmKQs iLw+f5EKzSx3DCTKSKiX0VazXUrYHUitfvp5UIkZHVkMZMfBJV/sLkNnR4XEgN6Q1x8Rdz1ko fNml5OsvnXAeaNmO0mhDu4gDWbokFCGGMql7GH4Ww1UDRhh9yYjPTX8bxrcemH1e4ON1E/tSN wU6DAEnYwppcCofacj7yNO4zpW9jppcSm7xYgf5Dn8GI3RofdMduyPdKm4lLKJp+WQ6/AXbmg sHszf0L7XkD6CvN5XPyvFRaO/KgIbk2FvLkGMInSRRmyPTVjfyw1oTbZSz15mzDrxArpgbY4Q Z39UmUETbs6NVqWtD90ivxkOrWXjUlWxR0RaNtFPQlaCRum6AS5ydpWIpmLOK6Y5s36xFzht9 QNcTyuuo1jOQ//rlMRZFtvoRCpBbb3g4wLTjU2Z3UaFA1QU3g5wwv6QHtw4KpqZkzetkB+ZLl Q4eqpXuS3AEVdVFwYwuPCCbMC06DYIWJ1EDKuHxo6JeJo3sBAtUt6/JPwb68sXBXxwNElkVKE shWgdhQgPCz5vGipuxp4TPLwKnmQX11VrkEMibuU8jzkXK61kcUjCJQxT5bLb5tC5h3HcOOFu icCkQwEeQioVNjYMaBg4aNyuSOrYuCTe8ZMA8Q2AoYooKJUQijFIDxA/uSkg6Y8aii6GjOz6s hUaDcTKB6NdI0r4KIQfZNJrfD8PYsrPqoMZ8CAy6l2s0ZELBrYlP/N6mCbRXdY7DhwiT1RglK kO9/3JFvgIB4yQo1QUehgaqWBuw/zk/fKsUEM9ktA7T5k/y9sp31OuoP+eczBEs2IdRNbv8Dx iQLdtBX4YFmjP4eHSiVF2/X/WRUNPy/jrKq1BKtiqFuf9DCP7k+7wU0wbaGuInsZcm6LWbbIk H8ktuPjgFuv4pIAwCmLgeG4gTnygSFQXBprwOKU2Fkdjdr+nojGtG+sCJt0oYowcdECLSGNo8 HOy0IZ1RiJGHsMtIVTGSRIX6F8y4L1AA8C31xrnKDq3NeIoFS5LN7FvI09j/zaxnsOBBIPTKt 2u0FpsDNiXRmmaauAtTjSkojFRQq0RQlxyUWM7qZQHUwtpMN/h3dhcyZ8SOcmrKjaDjf97Fpa Ix35+ugGieRempn+egHz4N/5HBcUYplfxnmemjbcC8oF8V50V6cHhKFoDXIszgNriPk7i4Ng6 Niff5qsNZsWB70iRaM/i5pUzeNeKALqdjb0J5GcREFlEDX6ZzwWjOUqeqX/RMycO8QJzGKI7D yUYAovL9/hlHHvY0PTchuV3vdqigC7N9i/CaWEdZbsCo6iE8M2SCTkOCPrUbJoBvTgpGnkNkl BRrubRNmH6/Gd2NkAGyfQ5iaI274G6bc4+j1q5Uv/snHc4bDe/TKkh1KpmRI76SYxhGRnmCG0 HN2s5VU3grREVYWbZPeW9Y3Ao+EOSKjPnpygWKJ9zTULuATbSbA1X8XfBofsQ0ANOXaZJmZwF O53huiT6pwJSCOfNjRtuGjksf0Z3XvAPQRM1r4HwqJkSxHroRny475if0Bj1+lRfDMDIGjA3H 4tZ+3bRzQXdP8OMMXBixu3zZihOhdoS+UsxQqFEt+xF4/V7L3b9lMg0kSDnbMrflC4cCC5HX/ +HOtUwWVom2TDJ3lKJ5k9oRTvMZv2KLDKvdNl87XDbkhp5GIgpQmKsN0Km3P4ORjgDS6J88c2 nDocniTqJ/dnVevARha+UmzAYTNpNc000ZIwz4sJNADKiGdcO/N4aeiucs4LfTDJIe/jiSuS2 xbGnpWNyPgY5IzlyJFNRmmvvbrLGsi7JoUWJXkmkbfvTzTkcYR00y2BNveF/pAHJQncmusVxs Vh2keJnuFX1IFauEYGaK3fnoQMayEzvleBqX2H8Q4xIGWHtg5a8ZsDmxjNQhJiWnBXl8u4fwR WSOU05Wv3i9asdjjvSjUVMVy9pQQJZ22PGJA7v9AV7Q1JtSHHOXyb9kGRq4NPCUwwGX6jSTUR TE1+Xld+a3gjCX6zpMLUaEoq6CYE0JKi2Z1bkuELzBL2YFonC1NQxhHE73dv6FEwz9TplwTFG lqkp2tK5aujmtfK3V1VqRWZdEcKXtybFOkFk0QThZA55qFjs/DE8D9Mp/ffVCTJtXcpWsmDqf 6CzQwFOhDmHy1aoei1kAjc/zNSonhe01U9T2m1p2w+ApJz8HEi64DCMfCzwObByLQfslkc+KP lUv6o2rtdqLQVI5CDVr058+n8rZcS7/YSQu/m4EgzbKlWTXSOV96E2JG8BQ/wnoZE1/oMQlee NUdWO7x0pVlmJW1CzYEAsC4U0kWX/J6f0LEq6zngyu1jA9kiTse/nSYSqSH56hm5YWaSedXAd zWxlMYS1mWsf5oSDI1QQ7b3UX/hobKfe/Lrvw0jg3+C6vbNWfGUXLaVRYlik3pHplLXOFSKdH TXOk/4JKbfO9IZl2Z1oT0pFGOwBfY0KgynSiMAS58ZAk3nhvQoarrVLzzNE67Pr0hColrJmwF Wzk6mSb/sZa3B3E6an8eyXgUCuXK2Uwnwk0lK7AWJ97A0xlHCMrHb8CmL58zVoFQM+J1q3qo0 Pu48TWSJ3sqZyANsxEgFSZJpuj6iGUzobHSe4pUL9DipuvzkLCmxdFaOp4rs1JmTPOKYo5W5Q dfUNte+1/+1XiH33 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 02 May 2025 14:44:04 +0200 Stephen Berman = wrote: > On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh w= rote: > >> On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: > >>> What about the other regression I mentioned? Have you looked at that >>> and tried the fix for it I included? If there are no objections to that >>> patch, I'd like to install it on master. Or if there are problems with >>> it, I'd welcome a better fix. >>> >> >> That fix is not right and would cause other issues. > > When you have the opportunity, please say what those issues are; I have > been using my patch since the first version of your changes that > introduced this regression and don't recall any issues with it with my > setup, but admittedly I haven't extensive testing with -Q or other > configurations. Do you have a rough ETA for fixing this regression? And again, can you please explain what's wrong with my fix? Thanks. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 03:50:39 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 07:50:39 +0000 Received: from localhost ([127.0.0.1]:52838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRR5b-0000iJ-5p for submit@debbugs.gnu.org; Tue, 17 Jun 2025 03:50:39 -0400 Received: from mout.gmx.net ([212.227.17.20]:53955) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRR5W-0000hQ-CV for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 03:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750146617; x=1750751417; i=stephen.berman@gmx.net; bh=wnSbYjR4bvpG7pwP52u1eYaYGOtp4+zVlqV1VGFg36k=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=T1VhQRUbUTd70FhHaX+1GVsK3v0ZlJz5Hoq93fUYXifV7EtIzuOA4Cx2b2wMt065 hnUOBTyiFuFDSNnwVfqPLK9NTTtKEpBPALUKWXUffev/UoUnYzj+oHqRf8Tr0kxE9 egkkKAGgnf67jJ3OgdIUBXRSM8gx1WvQCLWSpxFlp5TxVkhPNs9Xy91h08PeP5RYq USX2TlZpFfcHtNR47QGoZ+zBsqPXQzptFkbGIlj0b2LZvvYw5anGNHANit9wAIEGY VvbZ6cH0SJQKJfyeosjmT9EiYlyfvRqEUWcMGhmmYAT8prClSWHgAcHNOIRNlY7Tw CdpfZA7nyxBuNQIdlg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.38]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6KYb-1upZlA0xKr-00ys0r; Tue, 17 Jun 2025 09:50:17 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87cybm2zu9.fsf@gmx.net> References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> Date: Tue, 17 Jun 2025 09:50:15 +0200 Message-ID: <87ecviolhk.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:aGZytq2JBjMIkebLZvM1saFg/J2YbNgDSOlyXqsoMJuLP6RvB0b tVzW34kwcXwvPG+/RguOI4rifyjSoaGvzAJKVHvZmhVVbWHxI3wgZP6kScZzJX7r8q7+v4d EZ70nvOEpf7CbxumgRQI07tbKA3byGas12rAo6z8CKlToluHaRpTvtOtCMcDSSatj1p40L+ Eritttjus4y1hVzav/GfQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/pMo1HWDNSk=;GlpxI94dbytMQp/b5Eac/e4O7XE f5wKAZD57NkrHgHpTUENXzYE9q5prpAjg68s3nrSyK8hdbkSUDFqOBvamS5LS+gVA3K8x/Q0x e6xHSde+7i7DgZlAufWbtshzBmLr3XPygC1TfaZzPJwZxmMWwwaSxRXjVanNyq4i8KOmY4JWi jiXKe86a176nhswVJbA5GHt29Fx2G4kHPCs88L9+8gzgIaZIyqt/TkhhOBkGwQtb2mbXjVgMt 63VhPcLoViZHYIkikNBDHq3TxaT73fF/QAyE62PUBnpnXAMjdDvhIxO6jZBFOG1ZQ8njwotKG 9BEwjxJEBOor20okUvOMoG+2DN+vzzgYcPVQwGf7K99czOPYTHbf+X2PBk+7uxvyQ9pmGhisu zh0ttusxZtywTEoNxfvpezlTK0Z/kLiZn2DSEBVbPB3b1ibXwIzrQ1QilbdtO4hcSbmqftope JMbUkXCOd9Jyc/z6NsqF86wA/Z2iuVCO/kQOCkU4J+gsUTN+eOch1G3NWJeLxlE07bJ2pfQDM TK4CiDiauDCUamzH28IXI79i7H5anR8LZc7cGID1oVodmrpmr5ZeaO81eYQySdKxrJxwQiS0I CMnXsyM5UVabtrgjTtrXE7b0z5ysAj4a9EcFD2xLE9Lme7Y2ev7o/2/w1jFQMVncwWdy4R4hI X3ww/DFuH11JOboC8ScKCGn5PUTH6tnKbVetaIqO2RfIZPR7Ex6S9AzsjIVYw8DXKO2W7wxaR JnqPhZd8qpD0a/Kd9p8ig9vssBO6D31qmsLJqNwO0MYtqUKj7QkoA6SWSgOBd2fNNEPuTmn+X xgogJgBFjwc22LtnkwYBZrGD/u9TV43WwYVIyL/VgNhgLe8GBYfPIj/uhin8IMwsTsBiBd/7U SMBVgQMVofmeC1FWrsFB0IUU1aVmvOFDR/3gdTnJf6vJohGMqt3b1OwPZKTIC5RvRLY/rgvGA yZrMJs4jRS5Ke0An3b4P1DIZLLCTggnO3/KzYhuRWLAdIkTSdWfCjrSv/TdnbW9pdGhjoW5+l sSUzmC+OYjDQQi9recismk7/s5LrA+V7vCoc1P/DQjzgA1G20vmzg5aVCZ1KXZ2DzB4eZ6nOf w0e52nnxIrm3m8ao8BKPewxxeoxNJtooLzXW0Onbn6NAzQdGTnFAKIz4rNqVELCFYQ7E22d4y ykFhPwaSYpjOBm39XhfNZbUMehhz/s4UJcpJ6hr44lnACtCDzXEaVQBCC7yoJ47wecRlIkuMs A1zdLY+AbTnUsknLhLDqBpvYPQ/DiAl4WvPIi+SUPYNXVSLLWeaLuKz4W9XgehLoH03QRIsN6 FXZ3kmX3d3GMVzCUM8CgL2H4b1Xr4AeUWSha+IeQxNB797nanXihATQj4ojEwC1k73u8kJtUp F58bwbnJvn7wxOaffXACA5Dgj9VHo1SFwotiNVwCmdLjpKV5vzy6FUyHAcVBqZVJoFuynhRzE 6TlwzvmMIxwqJIHk8GavBTQ4Crm+zE6/UY4CVC/a6+rQGrZJV8RVvDwLBOTFp8C2qhReM8w/0 NI7kosKP5st6QO01hOEc4CcqqtANscyEuMsJeRV7+clOC3rAQRxgSpw6s8sNIIF5UxGpIxxYZ 4LqGse5MoHW7ggxtbOysZrwdfO/l9QE1VwiL2ErPM/Q3pXz8ZaXV/olacHq0MBjAUv7A3WndO 4hcsxZGnAn3d1iAZtYDymts1HAS63m3tIaSuTAEMygglFQGqRxR4Y5YUPEcMEXrCM0XAMm341 0O+DlgoMVucdL+NPoFvRURyBnv7ue6vU/Inzn0E7bSwgWbso0n0/v0e+XGAJ+YCiVHRU8ZQYc t7BOdxEuwqmR6YQPzeSSEMj4PvvdW7/FGLasOTJXOOw4sKnGsYzMjPGYcM+PXiomAu930yqVT zMjLy4n8mDrb4Xog94VEGz/UnD81MDTUxWZdw12KV5CJe0kbBRomlMR5iHD+8ALOXvkhgwj8X HLPF+x8x8j1a8nFmOiXN1feD/XEo+cJSI1vmCwXIiFROlU9O0JWCoCPUh/OqAPUELLmvH/dKO SSgNtJN/3HN4E2TkVx/4wU1bJSPtgO8FbWRDtYat90cxKRJKuvBoxBh+xnf15XHJP4plF8CmO zffVGVDa69lPcxhG5q8ecI4Kr+1pnypBJ2W6MPQZNpcKLUnyYAnY9Bz7mPfe6wolEMPb/hjG1 z+rVycYr/EMty5fLyUTcSJ113j9boKPlTT1Xk7XSJPI5BQqdo7oUdVC55ATGprpkKPyKvPMC5 lt3+Y0dUHtNerfBcX0wooO/L5eU0RrYoW15b9cJGFWIoEKNRNr4lGNv8wjJKlLLz5zeFpkMwy egORqfOsSCZgn9YrEEdMKOHG0jBMbQGnvvKVgkzJgtuWEjF3GOlZBwzIL4dwDYEVuoR7E/FJ1 /vjEjCQ+gejIY+IxFLjZkABy67WNTzt+0N9sdofZ+zZn+mBwLkQ65IMmohWNPpl27S60gA9kC HsaOmhiX+lb0oX7FmqaSUtB6unBt46OcTb3kQo/RgSS8WhgWieYbDzbxyA2rZi0RvLJ5A5/Gb fIVY2Ara3+8tWjAysFyFms+fQk7lgRjjTN0csAdSn1iSWxSMwd6U5gvFpkGHqdBHk29Xpujpy +ITovDrq+q1j1gqIsOU+Ao4sSdQEMjAVggIgZQPQ/WetuXpWH4kPNHfsN6g/Pf7ugFIYWmWOm N3F67YcoICWXL12T6cJX7tPVZMM5tSuGyTjcBwpMiwjuateXM+39Tagw2Mc8eltygABYW9+1p z7ikiYNB9EO0g7ho9jfYh4aoIdbxnTyTdXPT5OdE3rj/mP9SfRbUDpI+KdIO/1Ad9JEir6I8L EEANf/0C9Kxy4X+kBP80Bahds3LVyTifk4kCbjvzCWs/Q2r+MFTejB/X+YeGOWSA8ZqYFVGB8 iQr7m1e/8TJv02Q1cH1vSEdzbrywILraNDq2vpuJuHI73/Sd32PuGQ87FtmS16JHhDSOlTfG4 XnBNGtFLUyFd74SumgQPy/o6EFYA5zv5qhc2K7nV2G6CvLg6ZnUCH5OeW/A3i3ewWAolUZ0mr j0RdespdRv4UERZcNbt0itsJPSy71X1rYLlZMOPK8IUGMg/wgo+nTTgcG4gCwdZDmKj/X8V5s A1+mAFRbF+BUEAR9oYTZzlzJoDJMnigKCeCvLP8k82p2yEYsB7nEG0S1jJrrCVWZIUmpbhOfx CtGKKqiQrjaOw6gLdvar07C+bpRbKw6bgUfTBgxhCoulbKHGfx5msftu3O+v6WQE+FGI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 02 Jun 2025 12:38:06 +0200 Stephen Berman = wrote: > On Fri, 02 May 2025 14:44:04 +0200 Stephen Berman wrote: > >> On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh = wrote: >> >>> On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: >> >>>> What about the other regression I mentioned? Have you looked at that >>>> and tried the fix for it I included? If there are no objections to th= at >>>> patch, I'd like to install it on master. Or if there are problems with >>>> it, I'd welcome a better fix. >>>> >>> >>> That fix is not right and would cause other issues. >> >> When you have the opportunity, please say what those issues are; I have >> been using my patch since the first version of your changes that >> introduced this regression and don't recall any issues with it with my >> setup, but admittedly I haven't extensive testing with -Q or other >> configurations. > > Do you have a rough ETA for fixing this regression? And again, can you > please explain what's wrong with my fix? Progress on this issue seems to be stalled. I have no reason to doubt my fix may be problematic for use cases I haven't encountered, but I don't know what these are, so I cannot reasonably investigate further. If my patch is installed, those who encounter any problems due to it can report them, which hopefully will facilitate finding a better fix. Therefore, I request permission to install my patch. If it causes serious problems for which there is no quick fix, it can be reverted. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 11:00:09 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 15:00:10 +0000 Received: from localhost ([127.0.0.1]:60037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRXnB-000456-T5 for submit@debbugs.gnu.org; Tue, 17 Jun 2025 11:00:09 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:40379) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRXn8-00042k-6m for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 11:00:03 -0400 From: Spencer Baugh To: Stephen Berman Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87ecviolhk.fsf@gmx.net> (Stephen Berman's message of "Tue, 17 Jun 2025 09:50:15 +0200") References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> Date: Tue, 17 Jun 2025 10:59:56 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1750172396; bh=wkFWWblm4Ju116K14H2hCsYvnd5PaoKR7UsqV641Kr8=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=PQoqWQPw3xPHi8zz+WVExaVF0wi0F+zmArTne65ryJnQvBz47OcnvXcbogg/XN/uW QpQnNuofkKelVcPd392hVfYQp2TGYjK1A0gP3j71uKyh2glvA6g3tsLedGoEnpwGZ9 Fe+hbMR1bnBOwthaRaGF8Jabtw7RoEIDeAgnovW6EhaON/G38DWthGU5jq0/ONE7XE KaDlXD+zxynF3mOqPlW2GqPZ8UwbSi8t6ZMf3kWMF+Yjn6r5TgUfXcWl8ScO3XddaA 9QzYdq83+/BzVQYpOcETwjmZu4PhY7Dx7HxH+/L2RuO1tLL/FPQ/rOu59XhetqB783 OUfjvTt5ibkgA== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Berman writes: > On Mon, 02 Jun 2025 12:38:06 +0200 Stephen Berman wrote: > >> On Fri, 02 May 2025 14:44:04 +0200 Stephen Berman wrote: >> >>> On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh = wrote: >>> >>>> On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: >>> >>>>> What about the other regression I mentioned? Have you looked at that >>>>> and tried the fix for it I included? If there are no objections to t= hat >>>>> patch, I'd like to install it on master. Or if there are problems wi= th >>>>> it, I'd welcome a better fix. >>>>> >>>> >>>> That fix is not right and would cause other issues. >>> >>> When you have the opportunity, please say what those issues are; I have >>> been using my patch since the first version of your changes that >>> introduced this regression and don't recall any issues with it with my >>> setup, but admittedly I haven't extensive testing with -Q or other >>> configurations. >> >> Do you have a rough ETA for fixing this regression? And again, can you >> please explain what's wrong with my fix? > > Progress on this issue seems to be stalled. I have no reason to doubt > my fix may be problematic for use cases I haven't encountered, but I > don't know what these are, so I cannot reasonably investigate further. > If my patch is installed, those who encounter any problems due to it can > report them, which hopefully will facilitate finding a better fix. > Therefore, I request permission to install my patch. If it causes > serious problems for which there is no quick fix, it can be reverted. There is no other regression. rfn-eshadow works correctly, graying out the section of the minibuffer text which will be removed by substitute-in-file-name when read-file-name returns, even if point is in that section of the text. This has always been the case. Likewise, the pcm-based completion styles sometimes move point into that text on try-completion. This has also always been the case. So there is no other regression. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 11:43:13 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 15:43:14 +0000 Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRYSv-0000BZ-EK for submit@debbugs.gnu.org; Tue, 17 Jun 2025 11:43:13 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:60425) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRYSs-0000An-EV for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 11:43:11 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B0CCE10013E; Tue, 17 Jun 2025 11:43:04 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1750174984; bh=eBnymM5tVkoK7w0JU2/jR5QuUm8y9V4vr7UBnnjR2Io=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ehGtwbvx8DT9xEjP5G681IAeaX8+JT8VYehkgztPRi9x8+PftJGvt1zfvVJ4yY+A9 eGUVW4F8gWioAhbI3I94lfQHuE2YSdwpTwgPSKC/SuGie0nVwHslci4D3XAcsib8bM 9H2gNVe5pJ21fE1I52L4GurGwLqDIfOtWwop0zHVm64d7zPxhzv5jltXIBI6R413AX 5p4txlBlN02hm+IT4bKh0KLms5G7Ki7L51xWtaMag/N6ziOf0yxpZtmPqjheSW4p50 2tXBwDyjUmOFPrqHY0FFMj4YGEAY4TKsz98VCDE3j4tGC6KS0dqeAwP2cO7VZy7TUw Ds1hdoNF/Z+vQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 00A7010002E; Tue, 17 Jun 2025 11:43:04 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E20391200CC; Tue, 17 Jun 2025 11:43:03 -0400 (EDT) From: Stefan Monnier To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> Date: Tue, 17 Jun 2025 11:43:03 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > There is no other regression. rfn-eshadow works correctly, graying out > the section of the minibuffer text which will be removed by > substitute-in-file-name when read-file-name returns, even if point is in > that section of the text. This has always been the case. Likewise, the > pcm-based completion styles sometimes move point into that text on > try-completion. This has also always been the case. So there is no > other regression. So, can we close this? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 11:49:22 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 15:49:22 +0000 Received: from localhost ([127.0.0.1]:60833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRYYr-0000mU-OY for submit@debbugs.gnu.org; Tue, 17 Jun 2025 11:49:22 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:58351) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRYYn-0000lc-L8 for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 11:49:19 -0400 From: Spencer Baugh To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: (Stefan Monnier's message of "Tue, 17 Jun 2025 11:43:03 -0400") References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> Date: Tue, 17 Jun 2025 11:49:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1750175352; bh=y7nMxaF2kAQ/khsQFOCGRJFJReBRZyAW0cYVDLGFF5k=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=UuQt1+vsJVu7GBn3fSv4qhlXp9r1nXDQGYqVl9qS9uUqPOwnL1inyhB8ITY2Tetku 5GHOnJ6d59TFr4tLCHiCgDVqqPepjvmfE1RmHxbns1FmIib6YPxJ5ngpp1bhoFn9ib Dn+6MmQdP3SBk6CWkqKzYEyLqOFg4siFkncjCwxESG2J8iCdv5ehX2OMghm3f4k7Xo hNv0S72MIsJ+0Vz2rCVXf08osNEBx0RSz+LLOnM8dByXt+X+eH1/aD3MYDwqGNV/X/ jeESoXWEU04iRN6Vwnl37ZuADpc2HehPujP6cpyStFCOF28hHp0yXOmG7CtE3MxO5+ QGya9lLdj6K0A== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> There is no other regression. rfn-eshadow works correctly, graying out >> the section of the minibuffer text which will be removed by >> substitute-in-file-name when read-file-name returns, even if point is in >> that section of the text. This has always been the case. Likewise, the >> pcm-based completion styles sometimes move point into that text on >> try-completion. This has also always been the case. So there is no >> other regression. > > So, can we close this? I believe it is already closed :) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 11:52:37 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 15:52:37 +0000 Received: from localhost ([127.0.0.1]:60874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRYc0-0001Di-HS for submit@debbugs.gnu.org; Tue, 17 Jun 2025 11:52:37 -0400 Received: from mout.gmx.net ([212.227.15.18]:35643) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRYbx-0001D2-VX for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 11:52:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750175540; x=1750780340; i=stephen.berman@gmx.net; bh=sg8HwSlRB201bTDPhskJQ7r6iIziVPtN7ZXwcwAKOW4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Ls/DTLnj9bzRzjSnVAqmTj4t32yKYAIv+D+ButdXQQq/GxT4Wd+y2oY2glmgG/A7 jqOlXow8d2R9lYEbF5JmAsfYKepQqE6peRhq270JXxo59PJbQ0cYozZPP1liufSh9 R7fCEBYOSMxj8tJa6XrPcKED9IlBgjfofJ2cQD/KyAUiEUpy7qMcjR/Py1DEXOIDE e8SQJ2N+gMZBPVlgKFuOs7WP44W12RzJXtLMD6kRWIC+8O6ecG3vJtooK/kJ8dUZX nh/PlpY7rrhRym2lo3PeKTwawfvM1Qnd8oII2vdSVQ4HjD993HfrdX4+Rzer1v7ck qJLSheu10fDhFjRKXA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.38]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MxDkw-1ugtfH2mbo-00wDMF; Tue, 17 Jun 2025 17:52:19 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> Date: Tue, 17 Jun 2025 17:52:16 +0200 Message-ID: <87zfe6mklr.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:PbJoxg2Hsr9xYwocX3AkiLYMRuB+Ips6NNx2XXko1G1a8XJP3qP ug7CA9x1RkYlkWbmgKIPjvIkGQ9F3meiVleLrrZhRo+46iP8JzzXfhIsOnZZA67sL52wbr4 MiY3rUOcWX6w68xWT7EJr6rGUdwLZ901mcuzo31CW2Wn1UIRfwbZ/E7D+Bh3A3iXmkVL7mt vTnz2F+8iKs2TSlaIrwEA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gCndo1RqW/s=;XhPJVL2mE7UBBM6CRrvR6wzYH8C 0f8JGPthbsWJnmyBVbXS7lgdskjIk599M8O+1wBy3yecagxqSuZPy1aRD/dDjqIdZdW7LbM19 1Nld6ouUScstWbCvjHNWergXfHVFfiQOkzICk8X0LMMop4OtkzUmiQ4/aa1CyiDbJywHNxuO1 jtVWm/LaSFMkW84FtfTyllbeOg9T0Uu/lV30gaehARD7PPcvOhu7sXjC1qQdPAVuTa9591wBF gLJpq4619Aj41yc3j7o1sgk7DrI2QqNzRWBkxiXTDOO3hG4D/eeJLlfLVC2i19dcdQUUhUhjp UeJRSodG3U92oTuErpt1ZIV/Qp2wplMm87lU610d+kRJRyc24IjHdo8XtGXNizChoF7piqrJZ 8+ixTpQWD2xDRrXq3Vfn+gwXI4NEmb86cvnH/hga5aZv/V5uzXynuOYKJAqVYmsTbMAYKmhPR K3BNr5VB/kx3Cf5FsD72QHNQgfDLFVhuVH9+52QmNeJa170oZqckxfRWqUtaeI0X3QmDl4oOf nWAPmhHC3oGD+gE2e6TXs4rUbWZE2Y3W0hnjPxZzcUEuBfyD1zq+mQldIE4ZSRKVxajq2IETI 3iVMlDV1TuCk7Ne9EmDwLB+7Toa8ZmAggkgryrZhV8r1QqnKKIT3N0FlsoFup1Ju+sSodfhY6 1KeKss2QCJ+xWI5i2J/9+xFlYHxNmij2u0BJb72KNN4ivx1o3W9fvmv9Zt5xFlrb0GdCdjRid KEJpUGTvhHA08pnzYtIvPG54CK/m48Wg1TAhcEKb3UR3jYRkHZ79EsVffeZdDoibQSt/GSqjD p1Uy76XhvEaDzzci6Dz0h8oq8NcjMKoIgixOoP5aMV/+E6WwPPNEMpSaTZGDV7fKv8RpkxeEj LzbnKWjoxWVRMXqoUmdgpbdZUjmJppChEwHxTeB95w3E0lpo1uYe0DuDCu+yKYWbClPJRKtVL ZebXrRkVDxBoFEhC1JB+FucAqybKxYeSNgvS5j4/VIEHHc9HZ8ajNtAo73zRpi17JMmcy48oV W5JaRYBHLaHyY5UqwgOCnYZT41iJ+dcEKUhKobHMACnlhW56Rti05HVzIC0h4xVjWw4HdNc3X R19hHgypWXVMnwt0vzNKq5STW1EOZ4EC1cWOvBpDEbyEZPUwmCDsyC/i0wipw3qVdqP8x2Vpz a1yf5aSfZ0qU2ghT1R1Q4fHhqxXyFEcFcVTvVP/pvFtdW6F7Dq3GtEQ/IZc/YA5aTe+wJBsql 76ZHSrGapuPH3VBP4JhEexepXSk1Seht2XgD82VQJKd2eXQLHSIvZ00Pp3hmkb7q9aeNFEVsi YJh//yKOXkz7pmqd0STWA31eV5JUIuc07K0SwPD0qJiFRnuDM26xCTvnaXwG4xbMSG2B3JGXE aReFX3xQdHZOieEVS2iMhd+qzot0ffLYMf7b/AzY/MRrzX3M6k+VM1cXzda3Fdht3s4ZmVupl lOaEvwUi4dYzE52T6PHqiBLaVRq8hfY8FIbn788M6E1YZG1FM0Uptw2EpQ3NNuPNUCC3osmlG 0EOG5d17OABUyR1/qJqqW+7pKiee4MwrCz+ARIVemZ/b6gH9xFe3SLEeK+HqwGpYZpXwq7vaA aKCCGp5sETzK/HRFCswo63lO9nHd3x7HraDhF6E4atOJb8lS9DcBUUiVBbWE6fjixHyFmCGZo q5uF9J19fxahwpFjfMnPvW/8RYht5gPS18/w+PWAHSPNjfCmkXChoXEWy04ccfWzXzb8dPAAr cDDy12kOmDUOBcl+gPDONvCUlPLt5pyr79xoCrvD2EnsTvCLDTq23M4JiSkc+CJXb0ddIIogO KiCvDGef0/NExKx0O3FaV/sl1npXfLOme8UucTWf54GR5tGq7+F/ix7hO6Brs4bf7QvFbDuXx GDQovKku5uaulPEgzeldIw898Hx7lYhJIXr4++Fi9N9q5VMsq+H0Lv1mxm3GxGHnvczAyVd+Q OyJTzUqAEZp0QnOFS3YLT65GTV9TtSWbQCO/Y4cBB6aF9UdvXBKC9evgq+0Oq2jsy/FA7+Vi/ x17FiSeDNM3sbzWII48cKreSO6ez0k+xwtaOeIB9fpACcaxhu1I0Ua6o4KOLdj8UtJcEmNdQj kkQbOP2uRNZJKs6bfIDeJueswxjjYGw6Kl0Z4OJJDqpC/dyO4HhJjD9Mg6bnWH7wyujQ104TA cLZ6Q0iGpYzNZO1NF/LJORXmnSHkVAx6SWW2TRgcy0FNgHHCy5gOxq2iv6ejVO2Tlal75KFC0 qQP+gbQXtr4AouP2V7FNXFMufQbPvlLeewO5nsKiUynf+QJvrAu1uOVfFHYWkFvegwuI9hLON AcQfkviip0sIfqk/Vmxzpbnxu6dNA10S/7lK1Sci9k+GPMX1aOanzJPeAF22yBah4Y/U6X3H7 UFOf9Q/wSUkfKmQiwZdOra8fKgqwHdu8I016gYk9+++u+LDQU4PzrO5SsFUNFNYpH+R0MqZdz HWYa8UpNQG/DqmSb/2kvgjmOkoEI360t84Oln7zFVA5VlJWyoBfe63Cb2nrbmiB4FtUhUFfTm wvEMCjLgf0T19A5iFc5KJY0QVx495rJbdhKb/YTvG0PueOHL/W/cv7ILcKjl921Gyc7cj+Oca kxsDOmwaI22YQC7lp4ndvbY/VmXlE64CW/ZsMEEIbPQQDcJq/PZC7iAJWsklhCQZQo91zAcG3 5Gqky6TGnNccdGzRo69vsiBIKgIE3ajet9D+Fnbl5f7NOz1BxdEmzxPYZxiamJ4f82p3Blg81 N5pPMNkT6O8xt+xi20+1uR16KCJcnnn2gFml/XgA3UmvGASkL3NydLbb1pLHdWuTA1juWZV5O LouLQC7kZxIEy+Bl8M+MEGi6FDY0YHuf/PnY5es2+vlzQpgOWIgi/SW8lu4f3BYlT31o2zG7N uEGDlAh9UIq5/4kQ0/d8HK20EYeASjlvjsDvuZSzsvsqBnkufeCFA4BQzFyZ5F6/MBxTBceFC 4fBIsp+F0YoL66Jq9rXswG5zOKPxN20fnVQqPC0kTZbPwU28wsHJSDt4cWzo0EpWvk1dUGVTC bciVQUUcRSNOREd6A9zUfStEALeqXFViwm/UV3/ybLquPFXPdrbH/1Nl3oHnp0vDpbStHFbW9 lzk6rTMD7lZ4RfYOKFUEhdOYwl3EAO9p6nwkBwdC3Wz4cEB1jpuwqdXKNe5dLCQFV64J8WU2D brVgF/daU+sfIu4avmcgNKA7WOKiyj2GNNq4/zVFq5QeCYMXDfoI2wWfE5n4mcTsB7C2KllMt pmDVBhjh/Q0BFir2EeHTXSXd8r1crYJyD6LeRLP/9jnHGzZ/0rUE2feTYFDfqfcjMwWDy6aJR fdnht3+ln/lHYXq2jHwofja42Gy1yJNtjPkcbCkq7p2P4l3VHS/Roq5rEi1Mt/RrjBY9SQT X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 17 Jun 2025 10:59:56 -0400 Spencer Baugh wr= ote: > Stephen Berman writes: >> On Mon, 02 Jun 2025 12:38:06 +0200 Stephen Berman wrote: >> >>> On Fri, 02 May 2025 14:44:04 +0200 Stephen Berman wrote: >>> >>>> On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh wrote: >>>> >>>>> On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: >>>> >>>>>> What about the other regression I mentioned? Have you looked at that >>>>>> and tried the fix for it I included? If there are no objections to = that >>>>>> patch, I'd like to install it on master. Or if there are problems w= ith >>>>>> it, I'd welcome a better fix. >>>>>> >>>>> >>>>> That fix is not right and would cause other issues. >>>> >>>> When you have the opportunity, please say what those issues are; I have >>>> been using my patch since the first version of your changes that >>>> introduced this regression and don't recall any issues with it with my >>>> setup, but admittedly I haven't extensive testing with -Q or other >>>> configurations. >>> >>> Do you have a rough ETA for fixing this regression? And again, can you >>> please explain what's wrong with my fix? >> >> Progress on this issue seems to be stalled. I have no reason to doubt >> my fix may be problematic for use cases I haven't encountered, but I >> don't know what these are, so I cannot reasonably investigate further. >> If my patch is installed, those who encounter any problems due to it can >> report them, which hopefully will facilitate finding a better fix. >> Therefore, I request permission to install my patch. If it causes >> serious problems for which there is no quick fix, it can be reverted. > > There is no other regression. rfn-eshadow works correctly, graying out > the section of the minibuffer text which will be removed by > substitute-in-file-name when read-file-name returns, even if point is in > that section of the text. This has always been the case. Likewise, the > pcm-based completion styles sometimes move point into that text on > try-completion. This has also always been the case. So there is no > other regression. I'm not sure what you mean by "no other regression", but what I reported upstream still holds in current master. That is, start Emacs like this: emacs -Q --eval "(custom-set-variables '(completion-category-overrides '((f= ile (styles substring)))))" After typing `C-x d / TAB', I see this on master: --=-=-= Content-Type: image/png Content-Disposition: attachment; filename=master-1.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAOAAAAAlCAIAAADUanKxAAAAA3NCSVQICAjb4U/gAAAOcUlEQVR4 nO2cfVBTV/rHn5CE8B4IEkQKKIJgcUSrK76NaJy6i4BF3e3qogtbtdbFXae+zLq+FQdRHEQ7ZZaZ ioq7WK1Mi3bVWnwbxRBlLcjILyAvSkNCiHkjIbmXhNzk7B/XjSFAuLwJ/iafv8j3nPOcb26ee+65 954DDcf0egwXCoXgxMn4wwUACIIYaxtOnPSNi+Nik8lUXFysVCrJj83NzaWlpaPvauhcvXq1srLy LXeKYZhMJuvq6qJS+bPPPtu0aVN/pWPifwiUlJTcunXLVlmzZs1HH32UkJCAYRgVnSIDJKjRaDx3 7pxcLic/NjQ0XLp0aQjdjDYIoR9++MFoNAqFQrFYrFar7Q7fqFJaWrp+/foHDx5QqSyXy1+9emUn jq3/wSISic6ePXvq1Knu7m6rWFpaeubMGYPBgBCyrdyfThHGcM2OD3Acr6mpuXDhgru7u0QiKS4u TkhIsJZiGPbLL78AQHBwsK+vr21DpVIpFos5HE5YWBipmM1mtVrNYrE8PDyeP3/u4eERHh5OFsnl cplMRqPRpkyZ4uXlBQDd3d1arRbHcQDQ6XQKhYLJZNp20Tu+tZf6+noul8vlcgf0P96oqKhYsGBB U1NTdXX1/PnzR7Wv4SZoZmZmcHDwli1bRsTNkPH09Ny/f/+XX35548YNANi+ffvatWvJovLy8pyc HOv1Nzc3d+7cuQBAEERubq51oOLxeAcPHgSAtra2tLS0mJgYvV4vEokAIDs7e+HChcePH//pp5/I ykwmc+/evTwer6qqat++faRYUFBQUFAwderUM2fOOIgPAAihHTt2CIVCOp2enZ0dFxfnwP84RCAQ JCQk+Pn5VVRUjPcEFQqFRqNxRKwMB71ev2XLloiIiNjY2ICAgDt37ggEgry8PAA4f/48nU4/e/Ys i8V69uwZm80mm1y+fPnWrVsxMTGpqak6na6lpcU2oFAoXLJkycaNGxUKBTlYhoWFZWZmTp06Va/X 7969u6ioiMfjRUdHZ2Vl3b9//+7du2vWrJk9e7anp+eA8XEcnzVr1rx584qKiq5duxYXF+fA/3hD o9HU19cfOnSIw+Hk5eUhhGg02uh1N9wEPXnyJIvFshNxHDeZTADAYrHc3NyGrFPHy8srJycnLCws Ozs7Kipq3759ra2tZBGLxcIwrKSkZPHixTwez+q2vLwcAA4cODBx4sTeAUNCQg4fPmyrxMfHl5WV CQQCg8EAAG1tbRaLxc/Pb/HixWTyRUZGLl682FrfQXwGg/HJJ5/gOF5UVKRSqRz7H28IBIKQkBAu l+vj49PZ2dnQ0BAdHT163Q2QoC4u9ndRdkpISEjvVkeOHHn69CkApKSkbN26dcj6oCAneYmJib6+ vjQazTrn27lz54kTJ8rKysrKyry9vY8dOxYTEwMAKpWKTqf3mZ0AMGnSJNuPKpVq69atOp0uJiYm ICAAABBCBEG4urr258dBfBaL5eLiQqfTAcBisTj2P96oqKhgMBjnz58HAG9vbz6fP5YJ6urqSqPR rAfRbDa7u7sPGPTo0aMjog+BWbNm2SmRkZFff/21Uqm8ffv26dOnL126dOTIEQAICAhQqVStra2h oaG949hdtmpqanQ6XXx8fGZmJkJo7dq1tg9NyJPWbDbbNnEcn7r/cYXRaKyqquLxeOT9+7Rp0wQC webNm8lSJpMJvY6DA50KAyQog8GIiIgoLy+fMWMGQRAVFRURERG2FdLT08PDww8dOjSEvt8O+fn5 UVFRoaGhgYGB8L+DBQAffvjh8+fPv/jii9WrV+M4LhaL9+zZ018QcuYqlUpFIhGfz+/o6LAtJcfU a9euGY1GPz+/ZcuWDTb+u8LPP/9Mo9F27tzJYDAAQCQSpaent7e3BwUFAQCbzWaz2ZWVlStWrLBt 1Z9OhQGegwLAnj17BAJBUlJSUlIShmGffvqpbSmGYRQfUI8VarU6Jydn27ZtWVlZgYGBqamppJ6S kvLxxx+LxeJTp06dPn3awcUaAObMmcPj8ZqamtLT0588eUL+Hlbi4+Pj4uJEIlF+fv4333wzhPjv ChUVFbNnzyazEwDCwsICAwMrKirIjzQabdeuXYWFhcuXLy8oKLC26k+nAg3H9BptZ0NDg4NKCCG5 XM5gMPz9/Qf5jcYFOI6rVCpXV9eAgAC7OTRBEDKZjM1me3t7Dxino6ODIAhyvKTIoOI76Q2lBHXi ZKxwAZtpmRMn4w0GAHh6elZXV0ul0rE248SJPTQc0xNmS59lzmmTkzFn4Lt4J07GEGeCOhnXOEpQ rdZ85IgsO1uWn6949KiP1aZHj8r27m0bKSuDirZ7d9u333b0WdQ7zsj6tMNgsEgkplEKDgCHD7cX FipHL74VsVhcW1tLXRcIBBcvXhxtV44StKPDfPCgtK7OcO+eLjGxOSGh2WDoMVuNjGRNnz6UtR19 olablUpKm0/q6gzffqtOSWFTjDOyPu3g87H585+PUnAASEvzP3BA2tk5lPeEg+L69et9bv7pT9+2 bRu5bmZUGfgSf/DgxCtXwuvr329oMOTlvV5aj+MWicS0YIHXqlW+dvVVKkKnMxuNiM/X19e/+QIE gZ48wZ88wY3GHiurtVozn6+XywexL+qrr+Tr1nHc3HqY7zPOCPoEgI4Os0CA1dUZrDUlEpNSSZjN IJGYJBKTVvsmjYxGVFWFC4UGs7lHnN79dnVZ2tt7jMFSqck6Fkye7Bob61FcrKZ8eIZCU1NTV1fX zJkzKeo//vijSqXasGHDqLoC6svtAgOZGzb4X77csX//RAC4d0+XmdkukZiSknzOnOmx7iYtTTR5 smtZWaeLC8jlxL/+NTk5md3UZExMbHZ1pXl60pVK4saNqdHRbgBw967ut799OX26W3u7KSiI+f77 A49zCMF332m++26KrdhfnJHyCQCHD7efPCmfOdNdoSA++MD94sUpIlH373/fotOZVSoiJeUFAGzc yNmxgwsAtbVdSUkvJkxg6HRmNpt+40YEl8vor9/YWPepU4VNTTGTJ7sCQEODYcaMerF4xsSJr8/A 5GT25csdGRn2b7B+97uXERFux45NgmHD5/Pnz59PLrCioufk5Hz++edv4/0tjuk7+6GlxQhQVV/f hRBCCP3znyoWqxrZsGuXZNOmX1BPEhOb/fxqampwhJDBYHn1yoQQWrq0cccOMVkhM1P66183IYQs FjRt2v/l5soQQnK5yc+vpne03tTVdQFUabWEVRkwzjB9IoT+/W+Nt3dNY6OB/Ei2Irl9uzM4+Jld 8KVLGzMyWhFCBGHh8Rq3b2913G9CQlNmppSs8Pe/t61a1Wwbjc/XsVjVBGGx6yU4+FliYjMaNq2t rceOHTMajRR1gUDg6+ur0+mG3/WADOIunsWidXcjKjuf1qzxjY11J5twuQylkrh/X7d8uXdNTVdN TVdMjHt5uR4haGszNTYa16/nAEBAAOM3v/GhYkMqNbm5ufj4vDmnhxaHuk8A+P57zbp1fpGRrxc7 k636w2RC5eW6tDR/AKDTaampnHv3dA76BYDNmyecP69CCCwWKC5Wbdo0wbZ+YCDTaEQqlf009O7d yIKCPtbj2qFUKouLi3Nzc4uKiqqrqyUSycOHD8VisbUCn8+fN29e7+GwPz0nJycjI4PcaDDaDGJF vVpN+PszqCzvnzKlxxp7qdQEAP/4h8KqLFniheMW8laGw3mdahMmMHC871cGttDpYDerG1oc6j49 PV2kUtOiRZ5UYgKASkVYLODv/8aP3czYrl8ASE5m//nP4vv3dSYTIghYubLHOUZ+316XWYiKonTn p1AoZs+eHRQUJJPJamtrHz9+HBYWZl3yolAoXr58uWrVqt6t+tTr6uru3LlTWFhIpevhM4gEffhQ v2ABpR/J7lCGhroCQGFhaEhIj3MxKIgBAK9eEeTcSyYjfHwGHtFDQ11NJqRUEhMmMIYTh7pPAAgJ Yb582ffWKxcXsLuqBAQwGAyaTEaEh7MAQCYzBQX1WO3QO9WYTFpaGufcOZXFAn/8I4fB6DEMSKUm Ly8XDmeI+3OmT59O/uHv70/uJrCFz+fPmjXLupVqQP348ePp6enkZtS3wMA/JIZZGhuNWVnt33+v +dvfAofQh68vfeVK9v790u5uBAB6veXmzU4ACAxkfvCBB/mQr6Wl++ZNLZVo4eGs4GDmf/7z5rns 0OJQ9wkAGzZwSko0lZUYACAEDx7ora2Cg5lyOfHixZv0pdNpK1b4FBQoEIKuLsvZsyq7EbFPNm+e cOWK5upVjd31HQAqK7FFi7x6X7tiYurWrWuxVweDVqsVCoULFy6kqIvF4pKSkl27dg2n00Ex8Ek5 d+5zb2/6nDkeN29GLFr0etrxq189F4tNOp0ZIbh+vZPNdmlosD81bSksDP3Tn0Rc7jMulyGVmlJT OQkJPgBw+nRocvKLCxfULi6wdCnVV/8bNnCuXNGuXPnmOWh/cUbK57Jl3idOBK9Y0ezvT+/oMP/h D5z4+NeHIirKLSMjIC6ugSDQX/4SkJU1CQC++uq91atfTppUazBY5s3z3Lu3751PtkRGsubO9SAI mDbNfgJQWqr561/7GLG0WrNeT2ky0x+PHj2Kjo728/OjqOfl5aWkpFj/UcDbwMFd/IjfkWm1REOD AcPMtqLZjJqaDDhu7q9Vb8Ti7sDAZ2o1YSsOIc6gfCKECMLS3GxQKEzUfVKvbLGg6GjhuXNKO726 GgsLqzUY7G/hhw+GYdnZ2e3t7RR1pVLp6en59OnTEXfigHd1NVN+vuK995irV9s/fn9HefwYu3JF U1ysbm6O8fDoMe86dUoeEcFKTu77tdlwMBgMGo2m977T/nSNRiMSiWJjY0fciQPe1QT9f0ZGhri7 G+3cyR29V7LvKM4EdTKuoeGYfuBaTpyMEc71oE7GNc4EdTKucSaok3HNfwEwm/auD9j7YQAAAABJ RU5ErkJggg== --=-=-= Content-Type: text/plain and after continuing typing `us TAB TAB', I see this: --=-=-= Content-Type: image/png Content-Disposition: attachment; filename=master-2.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAOgAAAAjCAIAAAAR5NFYAAAAA3NCSVQICAjb4U/gAAAPpklEQVR4 nO2ce1ATWfbHT0hCeIcEAYEBFEFgsERHV0StQWKNuwg4oK6riy7siOO4uGuNj1rX12ApioXo1FBL 1YgILj4GykFn1VFUHMUQZRmQkuWNOiEkxDwgIUmTRyf9+6P9xZCQBw9H2Mrnr+5z7/2eQ+f07du3 74XA4/E6OjrAjp0phYOFMo1GU1ZWJhKJ8NPu7u7KyspfJaoxcv369bq6ul/ZqUKh4PP5Q0NDtlT+ 4osvtmzZYq70vcQ/BioqKu7evWtoWbNmzaeffpqQkKBQKGyxjx9LiatSqc6fPy8QCPDTjo6OK1eu TKz7CQHDsB9++EGlUrW0tHA4nP7+fqPL+k6prKzcuHHjo0ePbKksEAhev35tZHy/8Y8WNptdXFx8 5swZtVqtN1ZWVp47d06pVGIYZljZnH38kCZW7r2AIEhTU9PFixednZ17e3vLysoSEhL0pQqF4pdf fgGAgIAAT09Pw4YikYjD4dDp9ODgYNyi1Wr7+/spFIqLi0t7e7uLi0tISAheJBAI+Hw+gUCYOXOm m5sbAKjVaqlUiiAIAMhkMqFQSCaTDV2Y6uu9tLW1+fj4+Pj4WI1/slFbWxsbG9vV1dXY2Lh48eL3 Fca4Ejc7OzsgIGDr1q0TFc3YcHV1PXDgwNdff33r1i0A2LFjx9q1a/Gimpqa3Nxc/XM8Ly9v4cKF AICiaF5enr5jYzAYhw4dAgAul5uenh4VFSWXy9lsNgDk5OQsWbLk5MmTd+7cwSuTyeR9+/YxGIyG hob9+/fjxsLCwsLCwlmzZp07d86CPgBgGLZz586WlhYikZiTkxMTE2Mh/kkIi8VKSEig0Wi1tbVT NXFbWlpUKtVEhTJm5HL51q1bQ0NDo6Ojvb2979+/z2Kx8vPzAaC0tJRIJBYXF1MolOfPn1OpVLxJ eXn53bt3o6Ki0tLSZDLZq1evDAVbWlo+/vjjzZs3C4VCvHMNDg7Ozs6eNWuWXC7fs2dPSUkJg8GI iIg4evTow4cPq6ur16xZM3/+fFdXV6v6CILMmzdv0aJFJSUlN27ciImJsRD/ZEMikbS1tR0+fJhO p+fn52MYRiAQ3ksk40rc06dPUygUIyOCIBqNBgAoFIqTk9OY7bbj5uaWm5sbHByck5MTHh6+f//+ np4evIhCoSgUioqKimXLljEYDH20NTU1AHDw4MHp06ebCgYGBh45csTQEhcXV1VVxWKxlEolAHC5 XJ1OR6PRli1bhidlWFjYsmXL9PUt6JNIpM8++wxBkJKSErFYbDn+yQaLxQoMDPTx8fHw8BgcHOzo 6IiIiHgvkVhKXAcH41c3I0tgYKBpq2PHjj179gwAUlJStm3bNmb7qMAHkYmJiZ6engQCQT+m3LVr 16lTp6qqqqqqqtzd3U+cOBEVFQUAYrGYSCSOmLUA4O/vb3gqFou3bdsmk8mioqK8vb0BAMMwFEUd HR3NxWNBn0KhODg4EIlEANDpdJbjn2zU1taSSKTS0lIAcHd3ZzKZkzFxHR0dCQSC/uJqtVpnZ2er isePH58Q+xiYN2+ekSUsLOzbb78ViUT37t07e/bslStXjh07BgDe3t5isbinpycoKMhUx+jx19TU JJPJ4uLisrOzMQxbu3at4eQOfjNrtVrDJpb1bY9/UqFSqRoaGhgMBj6fMHv2bBaLlZmZiZeSyWQw uQ4W7OPEUuKSSKTQ0NCampo5c+agKFpbWxsaGmpYISMjIyQk5PDhwxMb0wRSUFAQHh4eFBTk6+sL /38RAeCTTz5pb2//6quvUlNTEQThcDh79+41J4KPjHk8HpvNZjKZAwMDhqV4H3zjxg2VSkWj0eLj 40erP1X4+eefCQTCrl27SCQSALDZ7IyMjL6+Pj8/PwCgUqlUKrWurm7lypWGrczZx4mleVwA2Lt3 L4vFSkpKSkpKUigUn3/+uWGpQqGwceL9fdHf35+bm7t9+/ajR4/6+vqmpaXh9pSUlPXr13M4nDNn zpw9e9bCQx8AFixYwGAwurq6MjIy6uvr8d9JT1xcXExMDJvNLigouHTp0hj0pwq1tbXz58/HsxYA goODfX19a2tr8VMCgbB79+6ioqIVK1YUFhbqW5mzjxOC1U++GIYJBAISieTl5TVRXn9NEAQRi8WO jo7e3t5GY3QURfl8PpVKdXd3t6ozMDCAoijev9rIqPTtjArriWvHziTEQT/ss2NnCkFydXVtbGzk 8XjvOxI7dkYBYXBwcMQC+7DMzmTGyqyCHTuTE3vi2pmSmE1cqVR77Bg/J4dfUCB88mSEVcDHj/P3 7eNOVByjUtuzh/vddwMjFpnqTGycRiiVut5ezTsSB4AjR/qKikTvTl8Ph8Npbm623f6u/bJYrMuX L1toaDZxBwa0hw7xWluVDx7IEhO7ExK6lUqdYYWwMEpk5FjWxIxIf79WJEJtqdnaqvzuu/6UFKqN OhMbpxFMpmLx4vZ3JA4A6eleBw/yBgcn+HupKTdv3kTREa6/Ofu79rt9+3Z8PZM5rAwVDh2afu1a SFvbhx0dyvz8N1shEETX26uJjXVbvdrTqL5YjMpkWpUKYzLlbW1vHaMoVl+P1NcjKtWwlfBSqZbJ lAsEo7g033wj2LCB7uQ0LPIRdSYwTgAYGNCyWIrWVqW+Zm+vRiRCtVro7dX09mqk0rfppVJhDQ1I S4tSqx2mY+p3aEjX1zesz+bxNPo+YsYMx+hol7Kyfpsvz1jo6uoaGhqaO3euZfvQ0BC+jg8A1Gq1 YWKhKMrlcnt6eoy+pCIIolKpUBTt6ekRCoU2+v3xxx/FYvGmTZssxGzTskZfX/KmTV7l5QMHDkwH gAcPZNnZfb29mqQkj3Pnhq1jSk9nz5jhWFU16OAAAgH6r3/NSE6mdnWpEhO7HR0Jrq5EkQi9dWtW RIQTAFRXy9atexkZ6dTXp/HzI3/4ofV+EcPg6lXJ1aszDY3mdCYqTgA4cqTv9GnB3LnOQiH60UfO ly/PZLPVf/jDK5lMKxajKSkvAGDzZvrOnT4A0Nw8lJT0Yto0kkympVKJt26F+viQzPmNjnaeNaul qytqxgxHAOjoUM6Z08bhzJk+/c2dmZxMLS8fyMoy/mL3+9+/DA11OnHCH8YNk8lcvHgxvmDNgv3K lStz587FV+KzWCyBQLB+/XoAEIlEFy5c8PDwIJFIAoEgMzNT/5H1+vXrnp6e3d3dBAJBoVCkpqaG h4db9Zubm/vll19a+U4+aIZXr1QADW1tQxiGYRh24YKYQmnEDNi9u3fLll+w4SQmdtNoTU1NCIZh SqXu9WsNhmHLl3fu3MnBK2Rn83772y4Mw3Q6bPbs/+bl8TEMEwg0NFqTqZopra1DAA1SKaq3WNUZ Z5wYhv373xJ396bOTiV+irfCuXdvMCDguZH48uWdWVk9GIahqI7B6Nyxo8ey34SEruxsHl7hH//g rl7dbajGZMoolEYU1Rl5CQh4npjYjY2bnp6eEydOqFQqq/bi4uL6+nr8+KeffiovL8eP79y5c/Xq VfxYqVSq1Wp9k0uXLuXm5vb19WEYptFo5HK5Vb8sFsvT01Mmk1kO29ZZBQqFoFZjtux4W7PGMzra GW/i40MSidCHD2UrVrg3NQ01NQ1FRTnX1MgxDLhcTWenauNGOgB4e5N+9zsPW8Lg8TROTg4eHm/v 0bHp2B4nAHz/vWTDBlpY2JtF6Hgrc2g0WE2NLD3dCwCIREJaGv3BA5kFvwCQmTmttFSMYaDTQVmZ eMuWaYb1fX3JKhUmFhsPc6urwwoLR1gPbYRIJCorK8vLyyspKWlsbOzt7X38+DGHw9FXYDKZixYt Mu3ezNlNcXZ25nK5nZ2dSqWSQqEYfYuNjIzE1yWTSCT9DhEL+rm5uVlZWfjGEwvYugOivx/18iLZ sk1j5sxheyJ4PA0A/POfb8c3H3/shiA6/BWKTn+TgtOmkRBk2MvfiBCJYDRqHJuO7XG6ujrweJql S12N25tBLEZ1OvDyehuP0cjbyC8AJCdT//IXzsOHMo0GQ1FYtWrYvYf/vSaPUwgPt+mNUygUzp8/ 38/Pj8/nNzc3P336NDg4WL9USCgUvnz5cvXq1aatRrSPSGxsrFarra6uFgqFISEh69atM9zJYrRB 1bJ+a2vr/fv3i4qKrDq1NXEfP5bHxtr04xld4qAgRwAoKgoKDBx2b/n5kQDg9WsUH9vx+aiHh/Xu PyjIUaPBRCJ02jTSeHRsjxMAAgPJL1+OvLXOwQGMnkLe3iQSicDnoyEhFADg8zV+fsN6INMUJJMJ 6en08+fFOh386U90EmlY98DjadzcHOj0MW6yioyMxA+8vLzw3R+GMJnMefPmGXaEFuxEIlG/Htzw JYxMJsfHx8fHx0skkrKyssbGxiVLluhLTffRWPB78uTJjIwMfPOzZaz8xgqFrrNTdfRo3/ffS/7+ d1+rcqZ4ehJXraIeOMBTqzEAkMt1t28PAoCvL/mjj1zwScpXr9S3b0ttUQsJoQQEkP/zn7fzymPT sT1OANi0iV5RIamrUwAAhsGjR3J9q4AAskCAvnjxNq2JRMLKlR6FhUIMg6EhXXGx2KgHHZHMzGnX rkmuX5cYjRMAoK5OsXSpm+mzLiqqdcOGV8bW0SCVSltaWgyTzLKdRqPhO58RBGlvfzsJyOVy8T0R 7u7ujo6OVpdtmdPncDgVFRW7d++2JXgr9/HChe3u7sQFC1xu3w5duvTNsOM3v2nncDQymRbD4ObN QSrVoaPD+FY2pKgo6M9/Zvv4PPfxIfF4mrQ0ekKCBwCcPRuUnPzi4sV+BwdYvtzWpRGbNtGvXZOu WvV2HteczkTFGR/vfupUwMqV3V5exIEB7R//SI+Le3MpwsOdsrK8Y2I6UBT761+9jx71B4Bvvvkg NfWlv3+zUqlbtMh1376Rd7YZEhZGWbjQBUVh9mzjgURlpeRvfxuhB5JKtXK5TYMiczx58iQiIoJG o9loj4mJKS0tzc/Pp1AoQUFB+t63ra3twoULVCpVoVD4+/tb3YBkTj8/Pz8lJUX/jyysYG5Wwea3 UluRStGODqVCoTU0arVYV5cSQbTmWpnC4ah9fZ/396OGxjHojCpODMNQVNfdrRQKNbbHaXtlnQ6L iGg5f15kZG9sVAQHNyuVxlMK40ehUOTk5ODv+7bYcdRqtVAoRFHUyK5SqYRCoeGkwWj9ikQiV1fX Z8+e2Rj/lFwdVlAg/OADcmrqCKP+qcjTp4pr1yRlZf3d3VEuLsMGb2fOCEJDKcnJI38mHA9KpVIi kZjuQzZnf9d+JRIJm82Ojo62UWdKJu7/GFlZHLUa27XL5919mv7fw564dqYkBEQht17Ljp1Jhn09 rp0piT1x7UxJ/g9GlrG7/yG6dQAAAABJRU5ErkJggg== --=-=-= Content-Type: text/plain In contrast, starting emacs-30 as above and making the same input, I see the following: --=-=-= Content-Type: image/png Content-Disposition: attachment; filename=emacs-30-1.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAOQAAAAkCAIAAAAW3QFuAAAAA3NCSVQICAjb4U/gAAAOMElEQVR4 nO2ce1BTVx7HfyEJUd4EQ4oUUOTlplugsCCKonHqLqIWdaeji13YqrUu7jrjY5b1VRxEcZDqyCwz FQV3sLVlpmirrcVHVzGJshbMgiG8Kg2BEEMSEvIgITc5+8d1YwgQAkQNO/n8xf2dc76/X05+99xz T86BIJFIeDweuHDh9LhhGPa6Y3Dhwi7cbJQZDIaqqiqpVIpfdnZ21tTUvJKoHMzVq1fr6+tfsVON RiMWi4eGhuyp/PHHH2/dunW80tcS/xSorq6+efOmpWXDhg3vvfdeenq6RqOxx24bW8mq1+srKiok Egl+2dbWdvnyZfulXzsIoW+++Uav1/N4PKFQKJfLrbrypVJTU7N58+Z79+7ZU1kikTx79szK+Hrj nywCgeDChQunT58eHh42G2tqas6fP6/T6RBClpXHs9uG5LBgnQ+tVsvlci9dujR79uyenp6qqqr0 9HRzqUaj+eWXXwAgODjYz8/PsqFUKhUKhVQqNSwsDLcYjUa5XE6hUDw8PFpbWz08PMLDw/EiiUQi FosJBML8+fO9vLwAYHh4WKlUarVaAFCpVP39/WQy2dLFaH2zFz6fHxgYGBgYOGH8zgabzU5JSeno 6GhsbFy0aNHLcDGtZM3Pzw8ODt6+fbujonEsnp6eBw8ePHPmzHfffQcAu3bt2rhxI15UV1dXVFRk fkYXFxcnJiYCAIZhxcXF5gGMyWQePnwYAHp7e7OzsxkMhlqtFggEAFBYWLh48eKTJ0/+8MMPeGUy mZyXl8dkMhsaGg4cOIAby8rKysrKFixYcP78eRv6AIAQ2r17N4/HIxKJhYWFycnJNuJ3QjgcTnp6 ur+/P5vNdsZk5fF4er3eUaE4HLVavX379oiIiNjYWBqNdvv2bQ6HU1JSAgAXL14kEokXLlygUChN TU2+vr54k6+++urmzZsMBiMrK0ulUnV1dVkK8ni8ZcuWffDBB/39/fggGhYWlp+fv2DBArVavW/f vsrKSiaTGRMTU1BQcPfu3Tt37mzYsCE+Pt7T03NCfa1WGxcXl5SUVFlZee3ateTkZBvxOxsKhYLP 5x85coRKpZaUlCCECASCw71MK1k//fRTCoViZdRqtQaDAQAoFMqsWbOmbJ8+Xl5eRUVFYWFhhYWF 0dHRBw4c6O7uxosoFIpGo6murk5NTWUymeZPUVdXBwCHDh164403RguGhIQcPXrU0pKWllZbW8vh cHQ6HQD09vaaTCZ/f//U1FQ8ESMjI1NTU831beiTSKQPP/xQq9VWVlbKZDLb8TsbHA4nJCQkMDDQ x8dncHCwra0tJibG4V5sJaubm/Xrl5UlJCRkdKtjx449fvwYADIzM3fs2DFlu0PAJ4UZGRl+fn4E AsE8R9yzZ8+pU6dqa2tra2u9vb1PnDjBYDAAQCaTEYnEMTMVAObOnWt5KZPJduzYoVKpGAwGjUYD AIQQhmHu7u7jxWNDn0KhuLm5EYlEADCZTLbjdzbYbDaJRLp48SIAeHt7s1isV52s7u7uBALB3HFG o3H27NkTKh4/ftwhdgcSFxdnZYmMjPzss8+kUumtW7fOnTt3+fLlY8eOAQCNRpPJZN3d3aGhoaN1 rB5tXC5XpVKlpaXl5+cjhDZu3Gi5EIPf2Eaj0bKJbX3743cq9Hp9Q0MDk8nE1wGioqI4HM62bdvw UjKZDKP6wYbdBraSlUQiRURE1NXVvfXWWxiGsdnsiIgIywo5OTnh4eFHjhyx35+TUFpaGh0dHRoa SqfT4X8dBwDvvvtua2vrJ598sn79eq1WKxQK9+/fP54IPtMViUQCgYDFYg0MDFiW4mPttWvX9Hq9 v7//ihUrJqs/U/jpp58IBMKePXtIJBIACASCnJycvr6+oKAgAPD19fX19a2vr1+1apVlq/HsNrC1 zgoA+/fv53A4a9asWbNmjUaj+eijjyxLNRqNnYvezoZcLi8qKtq5c2dBQQGdTs/KysLtmZmZ77// vlAoPH369Llz52w80AEgISGByWR2dHTk5OQ8evQI/27MpKWlJScnCwSC0tLSzz//fAr6MwU2mx0f H49nKgCEhYXR6XQ2m41fEgiEvXv3lpeXr1y5sqyszNxqPLsNCCKRqK2tzUYNhJBEIiGRSAEBAVP9 OM6IVquVyWTu7u40Gs1qLo5hmFgs9vX19fb2nlBnYGAAwzB8HLWTSem7MDNxsrpw4SS4madrLlw4 OSRPT8/GxkaRSPS6I3HhYgIIg4ODYxa4plMunI0JVgNcuHAeXMnqYsYwbrIqlcZjx8SFheLS0v4H D8bYIXv8uDgvr9dRcUxKbd++3i+/HBizaLSOY+O0Qqcz9fQYXpI4ABw92ldeLn15+maEQmFzc/No O4fD+eKLL15BAPYwbrIODBgPHxa1tOh+/FGVkdGZnt6p05ksK0RGUhYudNi+E7ncKJXadcCmpUX3 5ZfyzExfO3UcG6cVLJZm0aLWlyQOANnZAYcOiQYHJ/Gb5NS4fv36mAecdu7cie/RcQYmmAYcPvzG lSvhfP6v2tp0JSXPjwxotaaeHkNKite6dX5W9WUyTKUy6vWIxVLz+S8+JIahR4+0jx5p9foRO8OV SiOLpZZIJnEO7OxZyaZN1FmzRkQ+po4D4wSAgQEjh6NpadGZa/b0GKRSzGiEnh5DT49BqXyRUno9 amjQ8ng6o3GEzmi/Q0Omvr4RY7NIZDCPC/PmucfGelRVye3unqnQ0dExNDT09ttvW9m///57mUy2 ZcuWl+p9EgyOQ1eXHqCBzx9CCCGEDh8W/frXLfjf164pEhL4dHrT1q2/oJFkZHTm5nZHRDyJinri 58f99lsFQqi9XRcZ+YTB4CUltYaHPzFr3r496OfHTUlpnTevOSWldbTaaEwmFBDwn3/9a9DSOJ6O o+JECOXni3x8uKmpbdHRvM2bnyKEOjt1CQn8qKgnZHJjQgI/IYF/5swzvHJTkzY0tPmdd/iRkU8S E/nPnhls+BUI9CRSY1eXHq/Q2jpEIjX29Q2bm5w9K1m6tG10V/z+9z/n5fVO2GP2UFFRwWazR9uX Ll166tQph7hwCPYm6z//KaNQGi1b7t3bM2YS+PtzuVwtQkinM+Hf0/Ll7bt3C/EK+fmi3/62AyFk MqGoqCfFxWKEkERi8Pfn2pOsLS1DAA1KJWa2TKgzzTgRQt9+q/D25ra36/BLvBXOrVuDwcFNVuLL l7fn5nYjhDDMxGS279rVbdtvenpHfr4Ir/D3v/euW9dpqcZiqSiURgwzWXkJDm7KyOhE06a7u/vE iRN6vd7KzuFw/Pz8VCrV9F04CntXAygUwvAwsud014YNfrGxs/EmgYEkqRS7e1e1cqU3lzvE5Q4x GLPr6tQIQW+vob1dv3kzFQBoNNLvfudjTxgikWHWLDcfH6LZMjUd++MEgK+/Vmza5B8Z+XyDNt5q PAwGVFenys4OAAAikZCVRf3xR5UNvwCwbducixdlCIHJBFVVsq1b51jWp9PJej2SyaynrXfuRJaV jbGf2AqpVFpVVVVcXFxZWdnY2NjT03P//n2hUGiuwGKxkpKSRm+pKSoqys3NxQ9EOAn2nhSQy7GA AJI9RxXmzx9xdkAkMgDAP/7Rb7YsW+al1Zrw1yAq9XnazZlD0mpHvMCNCZEIVrPAqenYH6enp5tI ZFiyxNMeTQCQyTCTCQICXsRjNZO28gsAa9f6/vnPwrt3VQYDwjBYvXrE/YZ/XiLRqhFER9v11tjf 3x8fHx8UFCQWi5ubmx8+fBgWFmbedtPf3//06dN169ZZtWppabl9+3Z5ebk9Ll4Z9ibr/fvqlBS7 vjCrbg0NdQeA8vLQkJAR925QEAkAnj3D5s1zBwCxGPPxmXiYDw11NxiQVIrNmUOajo79cQJASAj5 6dOxj5q5uYHV04ZGI5FIBLEYCw+nAIBYbAgKGrH7YnTakcmE7GxqRYXMZII//pFKIo0YEkQig5eX G5U6xQNICxcuxP8ICAjAT0NYwmKx4uLizEfEzJw8eTInJwc/ZOs8TPC9ajSm9nZ9QUHf118r/vY3 +hQc+PkRV6/2PXhQNDyMAECtNt24MQgAdDr5nXc88EXErq7hGzeU9qiFh1OCg8n//veLdd+p6dgf JwBs2UKtrlbU12sAACG4d09tbhUcTJZIsJ9/fpHKRCJh1SqfsrJ+hGBoyHThgsxqpByTbdvmXLmi uHpVYTUHAID6es2SJV6jn2kMRsumTV3W1smgVCp5PN7ixYut7EKhsLq6eu/evdMRfxlMcL8mJrZ6 exMTEjxu3IhYsuT59OU3v2kVCg0qlREhuH590NfXra3N+pa1pLw89E9/EgQGNgUGkkQiQ1YWNT3d BwDOnQtdu/bnS5fkbm6wfLm9WxG2bKFeuaJcvfrFOut4Oo6Kc8UK71Onglet6gwIIA4MGP/wB2pa 2vOuiI6elZtLS05uwzD0l7/QCgrmAsDZs2+uX/907txmnc6UlOSZlzf2iS5LIiMpiYkeGAZRUdaT hJoaxV//OsYIp1Qa1Wq7Jjzj8eDBg5iYGH9/fyt7SUlJZmam+R8jOBHjrQY4/FVOqcTa2nQajdHS aDSijg6dVmscr9VohMJhOr1JLscsjVPQmVScCCEMM3V26vr7DWO2GjNO+yubTCgmhldRIbWyNzZq wsKadTrrpYDpo9FoCgsL+/r6rOxSqdTT0/Px48cO9zh9ZuSuq9LS/jffJK9fb73UP0N5+FBz5Yqi qkre2cnw8BgxMTt9WhIRQVm7duyf66aDTqdTKBSjz9kqFAqBQBAbG+twj9NnRibr/xm5ucLhYbRn T+DL+1n4/wNXsrqYMRC0GvXEtVy4cAJc+1ldzBhcyepixvBfbpZskqJWHuYAAAAASUVORK5CYII= --=-=-= Content-Type: image/png Content-Disposition: attachment; filename=emacs-30-2.png Content-Transfer-Encoding: base64 iVBORw0KGgoAAAANSUhEUgAAAO8AAAAkCAIAAADuPfqZAAAAA3NCSVQICAjb4U/gAAAPi0lEQVR4 nO2ce1RTV/bHd0gg8iYgUKSAIC9/dIoWFFEUxeoMohZ1VpcMdmSq1jo4uoq6xrdURHEh1SVr6KoI OAtbLWsVrI9aXx3FJIoUzA8M4VVpCISQFwl5kJCbnN8f14khQIgQFPzl81fuPud8z87Nvueee+7Z IfD5fCaTCVasTH5sMAx70z5YsWIZbEyUaTSa0tJSoVCIH7a2tpaXl78WryzMlStXqqqqXnOnCoWC x+P19fWZU/nzzz/ftGnTcKVvxP9RUFZWdvv2bUPL2rVrP/roo8TERIVCYY59jJiKZrVaXVxczOfz 8cOmpqZLly5ZsO/xBiH0448/qtVqJpPJ4XDEYrHRuR5XysvLU1JSHjx4YE5lPp/f3d1tZHyz/r8q bDa7qKjo9OnT/f39emN5efn58+dVKhVCyLDycPYxQrKg1kRDqVQyGIyLFy/a29t3dHSUlpYmJibq SxUKxe+//w4Avr6+bm5uhg2FQiGHw3F3dw8ICMAtWq1WLBaTyWQHB4fGxkYHB4egoCC8iM/n83g8 AoEQGBjo5OQEAP39/VKpVKlUAoBMJhMIBLa2toZdDNbX98Jisby8vLy8vEb0f6JBo9FiY2NbWlpq a2vnzZv3RnwYUzRnZmb6+vpu2bLFUt5YFkdHxwMHDpw5c+bGjRsAsH379nXr1uFFlZWVOTk5+mlA bm5udHQ0AGAYlpubqx8CExISDh06BACdnZ0bN26MiIiQy+VsNhsAsrOz58+ff/LkyZ9//hmvbGtr u3fv3oSEhJqamv379+PGgoKCgoKCGTNmnD9/3oQ+ACCEdu7cyWQyiURidnZ2TEyMCf8nIHQ6PTEx kUKh0Gi0SRnNTCZTrVZbyhWLI5fLt2zZEhwcHBkZ6enpeffuXTqdnpeXBwAXLlwgEolFRUVkMrmu rs7V1RVv8v3339++fTsiIiI1NVUmk7W1tRkKMpnMRYsWffLJJwKBAB+GAwICMjMzZ8yYIZfLd+/e XVJSkpCQEB4enpWVdf/+/Xv37q1du3b27NmOjo4j6iuVylmzZs2dO7ekpOTatWsxMTEm/J9oSCQS Fot1+PBhd3f3vLw8hBCBQHj9bowpmr/66isymWxkVCqVGo0GAMhk8pQpU0ZtHztOTk45OTkBAQHZ 2dlhYWH79+9vb2/Hi8hkskKhKCsri4uLS0hI0H+LyspKADh48OA777wzWNDPz+/LL780tMTHx9+6 dYtOp6tUKgDo7OzU6XQUCiUuLg6P1JCQkLi4OH19E/okEunTTz9VKpUlJSUikci0/xMNOp3u5+fn 5eXl4uLS29vb1NQUHh7++t0wFc02NsbPiEYWPz+/wa2OHTv29OlTAEhOTt66deuo7RYBn5gmJSW5 ubkRCAT9PDUjI+PUqVO3bt26deuWs7PziRMnIiIiAEAkEhGJxCFDGQCmTZtmeCgSibZu3SqTySIi Ijw9PQEAIYRhmJ2d3XD+mNAnk8k2NjZEIhEAdDqdaf8nGjQajUQiXbhwAQCcnZ2pVOqEi2Y7OzsC gaA/s1qt1t7efkTF48ePW8RuQWbNmmVkCQkJ+eabb4RC4Z07d86dO3fp0qVjx44BgKenp0gkam9v 9/f3H6xjdPdkMBgymSw+Pj4zMxMhtG7dOsP1JvzK12q1hk1M65vv/4RCrVbX1NQkJCTgqxmhoaF0 On3z5s14qa2tLQw6DybsY8FUNJNIpODg4MrKyvfeew/DMBqNFhwcbFghLS0tKCjo8OHDFnTo9ZCf nx8WFubv7+/t7Q3/PbMAsGzZssbGxiNHjqxZs0apVHI4nD179gwngs+2uVwum82mUqk9PT2Gpfho fe3aNbVaTaFQlixZ8qr6k4Vff/2VQCBkZGSQSCQAYLPZaWlpXV1dPj4+AODq6urq6lpVVbV8+XLD VsPZx4Kp9WYA2LNnD51OX7ly5cqVKxUKxWeffWZYqlAozHw7MNEQi8U5OTnbtm3Lysry9vZOTU3F 7cnJyR9//DGHwzl9+vS5c+dMzBkAICoqKiEhoaWlJS0trbq6Gv/x9MTHx8fExLDZ7Pz8/G+//XYU +pMFGo02e/ZsPJQBICAgwNvbm0aj4YcEAmHXrl2FhYVLly4tKCjQtxrOPhYIXC63qanJRA2EEJ/P J5FIHh4eFulygqBUKkUikZ2dnaenp9HzAIZhPB7P1dXV2dl5RJ2enh4Mw/CR2ExeSd+K+YwczVas TBZs9FNGK1YmOyRHR8fa2loul/umPbFiZawQent7hyywTumsTDpGWNOwYmUSYY1mK28Pw0azVKo9 doyXnc3Lzxc8ejTElurjx3l793Zayo9XUtu9u/Py5Z4hiwbrWNZPI1QqXUeHZpzEAeDLL7sKC4Xj p6+Hw+HU19cPttPp9O+++278+rWs/rDR3NOjPXSI29Cg+uUXWVJSa2Jiq0qlM6wQEkKeOdNim4TE Yq1QaFZOV0OD6vJlcXKyq5k6lvXTCCpVMW9e4ziJA8DGjR4HD3J7ey35+ndIrl+/PmRO3bZt2/AN VeOEZfVHmGkcOvRORUUQi/U/TU2qvLwXSShKpa6jQxMb67R6tZtRfZEIk8m0ajWiUuUs1ksvMQxV Vyurq5Vq9YBcA6lUS6XK+fxXyE08e5a/fr37lCkDPB9Sx4J+AkBPj5ZOVzQ0qPQ1Ozo0QiGm1UJH h6ajQyOVvow5tRrV1CiZTJVWO0BncL99fbqurgGjO5er0Q8c06fbRUY6lJaKzT49o6GlpaWvr+/9 9983sv/0008ikWjDhg34oVgs1r/6lcvlEolEX1OlUj158oRKpYrFA1wViUQymUytVlOpVBaLZVrf AvQOQ1ubGqCGxepDCCGEDh3i/uEPDfjna9ckUVEsb++6TZt+RwNJSmpNT28PDn4WGvrMzY1x9aoE IdTcrAoJeRYRwZw7tzEo6Jle8+7dXjc3Rmxs4/Tp9bGxjYPVBqPTIQ+P//3Pf3oNjcPpWMpPhFBm JtfFhREX1xQWxkxJeY4Qam1VRUWxQkOf2drWRkWxoqJYZ85045Xr6pT+/vUffMAKCXkWHc3q7taY 6JfNVpNItW1tarxCY2MfiVTb1dWvb3L2LH/hwqbBp+LPf/5t797OEc+YORQXF9NotMH2hQsXnjp1 Sn+4YMGCr7/+Gv985MiRdevW/dfnxmnTps2ZM2fRokUUCqWp6aW3SUlJ6enpwcHBoaGhbm5uV69e NaE/dsyN5n//W0Qm1xq23LWrY8gooVAYDIYSIaRS6fAfcvHi5p07OXiFzEzuH//YghDS6VBo6LPc XB5CiM/XUCgMc6K5oaEPoEYqxfSWEXXG6CdC6OpVibMzo7lZhR/irXDu3On19a0zEl+8uDk9vR0h hGG6hITm7dvbTfebmNiSmcnFK+zb17l6dauhGpUqI5NrMUxn1Iuvb11SUisaM+3t7SdOnFCr1UZ2 Op3u5uYmk8n0luGi+YsvvkhJScE/9/b2KhQKfZOkpCQKhcJgMBBCKpWqu7vbhP7YMXdNg0wm9Pcj c1IS1651i4y0x5t4eZGEQuz+fdnSpc4MRh+D0RcRYV9ZKUcIOjs1zc3qlBR3APD0JP3pTy7muMHl aqZMsXFxIeoto9Mx308A+OEHyfr1lJCQFzv68VbDodGgykrZxo0eAEAkElJT3X/5RWaiXwDYvHnq hQsihECng9JS0aZNUw3re3vbqtVIJDKeOt+7F1JQMMT+ciOEQmFpaWlubm5JSUltbW1HR8fDhw85 HI6+ApVKnTt37uD9Tzk5Oenp6XiKjWk8PDyqq6tv3LghlUqdnZ0dHBwGft+1kZGRAEAmk/F8x1fV Nx9zc0/EYszDg2ROdkxg4IBsFC5XAwD/+pdAb1m0yEmp1OHPau7uL+Jy6lSSUjngKXNIiEQwmomO Tsd8Px0dbbhczYIFjuZoAoBIhOl04OHx0h+j2bxRvwCwapXr3//OuX9fptEgDIMVKwZckPj3JRKN GkFYmFmPtgKBYPbs2T4+Pjwer76+/vHjxwEBAfo9UgKB4Pnz56tXrzZq1dDQcPfu3cLCQnO6yMjI UKvV+/bta2ho+PDDDy9fvmyY0hsYGDi4ySvpm4+50fzwoTw21qxf1Oi8+/vbAUBhob+f34Cr38eH BADd3dj06XYAwONhLi4j3yj8/e00GiQUYlOnksaiY76fAODnZ/v8+dDpjzY2YHS/8vQkkUgEHg8L CiIDAI+n8fEZsBNmcFza2hI2bnQvLhbpdPDXv7qTSAPGDC5X4+Rk4+4+ypy3mTNn4h88PDzw/BpD qFTqrFmz9GmLek6ePJmWlmY4lAIAmUzGc94AwHAzt729/dGjR48ePcpms5ctW1ZUVLRr1y59KXHw Fx5Gf+yM8MMrFLrmZnVWVtcPP0j++U/vUXTg5kZcscL1wAFufz8CALlcd/NmLwB4e9t+8IEDvpja 1tZ/86bUHLWgILKvr+2TJy/Xv0enY76fALBhg3tZmaSqSgEACMGDB3J9K19fWz4f++23l7FOJBKW L3cpKBAgBH19uqIikdFYOySbN0+tqJBcuSIxmmYAQFWVYsECp8F3xYiIhvXr24ytr4JUKmUymfPn zzeyczicsrIyw4jECQwMxP8eRCgUXrlyRW9/8uSJXC4HAB8fHycnpxETlIbTHzsjXPHR0Y3OzsSo KIebN4MXLHgxxZkzp5HD0chkWoTg+vVeV1ebpibji96QwkL/v/2N7eVV5+VF4nI1qanuiYkuAHDu nP+qVb9dvCi2sYHFi83dFrJhg3tFhXTFipfrzcPpWMrPJUucT53yXb681cOD2NOj/ctf3OPjX5yK sLAp6emeMTFNGIb+8Q/PrKxpAHD27Ltr1jyfNq1epdLNneu4d+/QWYaGhISQo6MdMAxCQ43nIeXl kh07hhjDpFKtXG7WnGo4Hj16FB4eTqFQjOx5eXnJycn6PwzRs2PHjiVLlvj6+rq4uMTFxenT9Ssq KpYuXern5ycQCKKjo9PS0kz3O5y+BRhuTcOCT5o4UinW1KRSKLSGRq0WtbSolErtcK0Gw+H0e3vX icWYoXEUOq/kJ0IIw3StrSqBQDNkqyH9NL+yTofCw5nFxUIje22tIiCgXqUyXtAYOwqFIjs7u6ur y8guFAodHR2fPn06ZCulUtnY2Njf329kl8lkLBbLcMliOEzrj5FJuYcuP1/w7ru2a9YYvxOZpDx+ rKiokJSWiltbIxwcBsz9Tp/mBweTV60a+sXnWFCpVBKJZHD2uEQiYbPZ+CrEeDCu+pMymt8y0tM5 /f0oI8Nr/N7A/z/BGs1W3h4ISoV85FpWrEwGrPubrbw9WKPZytvD/wFTHiBWEEBEUAAAAABJRU5E rkJggg== --=-=-= Content-Type: text/plain And these last two results are also what I see when I repeat the test on master with my patch applied. Steve --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 11:57:01 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 15:57:01 +0000 Received: from localhost ([127.0.0.1]:60949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRYgG-0001eG-W8 for submit@debbugs.gnu.org; Tue, 17 Jun 2025 11:57:01 -0400 Received: from mout.gmx.net ([212.227.15.19]:38391) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRYgC-0001db-O9 for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 11:56:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750175799; x=1750780599; i=stephen.berman@gmx.net; bh=vrHxR9qZnj4ZmrpkBERC/TgHwAXrUbO3P+Y/jSQUdI0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=lJW8VOgfnhSS9j0X2gluWxUywDHwVX8e+wNh5dD66Fb2LyJUpxERJK5ThPHgxK2g jhrKdXbnaILVexg02TA/W6N5uJTOjlgfR9/btqHsuMfr8ee9pM6//TAuY+T9Zd8FW VMMHIgw8sx95ZfFaD/1pxTZ3y5Nw7+Vmvj461tJf+TNnMaoG0L0SyrQ3dpqx9aiUh i6pnM9t7SRBDBW4eyuttplnPB+9tyQaPbAhj0Elvu1WtTc773efv1gbwx0q62MNAh 2F5vnlBcV5pQHNk3JVPy3lLvgf5iD5JA6ulaFycNhGRYXBgTkWBe3cZ/TlWOB/wNO xuLphItsMt1030OP7Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.38]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N63Vi-1upiM302au-014gRr; Tue, 17 Jun 2025 17:56:39 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> Date: Tue, 17 Jun 2025 17:56:38 +0200 Message-ID: <87v7oumkeh.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ms4CvJtOAJexkn2X3rH4+f73UO7quGhUTRCIZEnpDvrL7kS4Cek QY7sHC1gBkPm0g4ojFdYD2MViQBBra2OWsIIJuvTPcBo6pe0bTtB5RpsYiThIm1bwhHNlem UOoTpIbY5bP9mjUc+wtsG3wBzCllY56vF+nJ88dF+FWjJ4yR8+A87LI35mJYPe50acJebFM 3TJJzOm+UDdWRPYN/s88g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:xifpVtJO97E=;99BaZ/ot6avc9fJRAEgUmaueM0M 9gsbfpfz7zyCRE3PGlZGE7s+VxjtR2yXsVgbJSXYhJAjkhgMrjmphjHr/0xqf9EhwYX52Y41r EoZzYaQJQMMDK6VoWAkrRqpP8F38qQDjo13nZwr6/p3vy3VQ4Km+ir7FEn9OnO8oKMZf6M1Ou L2/YHUjr5WfLpAATsfAoBlDNepNK4DhWExPtEO+XlPUbg9UN92vtrL5cR7Jwc/dgDONcdqwwZ PHFO/Ttc46DSkv38F81E5r47zXvFNKH8NHyZzPLg6H3mVP+xfgtqO/k4HkW1GsfBtMi25ThfM d8QmdU3NWQQkgQkwjNm70dAWXHRAcAsxdExstynszswjf7hq1kXgtPaojmJL/T7MQB+6mRgE/ VXmHbLk2yt2W1sokioNdABPAykrF3L0Z/I4ILeTUx/nbaDYfwRJwvms2CuMFfDdrqH3yBqp6s /IItdeVREK4BiKEDij0BIaARn61FMwVsEZuVtCOhpUIctTeDE0xwm7SEJ3Dk2WSgkRMk/3qc0 v4d7SHuVz7gbxeI+ldOEPIC/o8xt0WAbEa1z7DZva7jEpioRuCM5A3FWINruP9NIFIacvirzt 6umYCXpmjjAfMcTgOeiY95c/5fLJrndbN4kJKoXcJCjLhDfaWBgCcVvkYCwEEqa2vg/9nMgFv ZVEnw50VK1s/B5oiv2tYW1T8p1niZdqiGJbYOuAXuQQb3dGd7WPb4oaGciQg2r1eXEc+5dDNZ pw2OEmtmbU/xpso2lV0rfyHMxxctAPvjSb/Enzat5lecsD7z5OL4rxhKctHp+QIMil+FBlTsx n7e2/j5icqTvsNMmFAHymXEuz0VnZs2fECaJJwJzUI0vR0tDivp4QXq4+uVEGxERbd4Ko5AXn S0LNXMl8Kqc1N5ZGMTC6vkut2UA2shaOKTbIOwv4RpVuLoPR5d3xGebAOwHPD3khei+qLmHU4 pfMAxC8Smdu08rPP0M/X0avXiC4rcZ10v7U/mpoub3WIouvQ3+KCklGM5lGbNW5VaDLjWpm3b 1f0sY9JlcpB+m94QA0/zC/ZncNGj2ZKrPoQxuVeVXsYAdtFuqLHhwCrrYyuSjAB2xKgtsB1MF 0bisv+EPi+rrYfj8R6o4OwBFIOVvruhBl+8e+Mk37mc/BUDOhvrFwOunm7n14VsoLjo3gFo83 1m2Xa83fFN0aBFDgr8ojhX6RN3Cs1NwoIh2yfX/lA1FBBClb7qLYqOeloIya4AD0QrqMkgfiD TQfsoMhSA2NqrG73bveO6u6Wqb4uU0epke0CGrO7X3Wlm3iRHIZy1eZowA74kWzKJAZVTrbXr iM6OG5iQ/5bG5PsUM8qU/mQIOyefHqHqhTE2AUGgethLPvQEpZy5FqNhmIad1ynjapXKOo1ie eh4Y7V8KJUORwB5wnlkLBawNswyFJCQZN/OzefoKlrc8+Dt0ATDN0Fb5ilDQZrqIZppRnAjFX ABbXo3JaNb2S0iSPbJPqoX23lm9kkJKrH1luJ3PvpHSbJjakB3mmDdS6ZbkqI6CJCpKBzwijY WT7/Yxub1A3+gmuIqE8kdAGCCW8mYZ0B90wYtNyQsEs+elTV0HIp0gRJpoVc70nnpymxqGhKB 4gMFazkhiEOaPGlXq4aFuXh19I2QeNXRKv0xAHc1aFi/E+HUja41Ys2b5Pwk3/dmwYHRi7kKE vwK7KpMKya/9/MhnF1WQ170seWrlfIB1PWoIVoxjZz8O6K09eFBZ+rnw2xkso5lOIGL00fK7k GTcmqX8kuQwHHEGSChj490HxJdm8jXWzjJ3n2z1O2wZ7FvxbsdzcT+hr7QfXD3fl0XDDon2ep GQi5cceTer6NeEMQHxOBYQ8ZPxamrbvsWMmac4MJfge8nxMxKA7fkpK9Wiid8RWmsAmQIzUDq +tRzCGkyCGeHR5xsT3HXKZToZ04595JEXU/4l3SnBCvwqfRrOYCfMpNMaydH0LnekNO79ZUvf GIH6p2AyOOdjkroemAmRMoeHCSYTIpV16uccDt17U70W7nte9/Wk2LTwxMAlEz7WTdMvPfnmk AsDkDX9oXb4i9iIW5FlQVBIMBry8b6Uj9igOjjy8nwky8txZ5ViqUCIeFortiK0gUugPtNsnU dnijhAKl80JwCg1GjHQMbiI6ZyE4tYa9DPvTLgYuVA7VKQk7UyNNN1zC+suKZIOs7dlOTbGs0 x+7vipRouqnPLeGUOjHFYL0qhJ9dVV3h3L0pP6Kg9q32C1PjQrd9VUGTchxr5HZWyPatoAoUG T+PcnmWbhotnM7ZjdP9Vpf8w6/B/pxrc/3wZ5khV48ZQ+X6/TwWgkPcj+g9a92HAkcZFVxtwB VGnL6/CeQCcu1hvTkCiDaCwP3eC5N43ns+4SfFCJmzvwpRXiD2gDCj+fRd+3tpbU6jRt8YhPj JZvtbwzR6jjVpbDPjKXVLHIpNuBDyOUYWHi7qtpKLssvqrii+9J6DDR/vq5ORjoJPxwg3lDwM YNKOOGOsF5eLbHiWaXlGiwgcxs68WFKRnhad9JIktaZJZJ6E5GeOxOSe/wjuffWdaf725aPJH es1wVHiYT2CMI7LGWK/w+hgp592zf7Pc6d4iyD3RibfX1AYgv+yyV426WQUmVD004cSRWaGRh y31rUeFxpYof9NHRynFqzdyh9Z8qrU2ukVEX+F/y526qLvvWv3CQRFpYrzAk/t/uvAsfIlmRe kq9/dTEQSzlPk41MzNaJ3WD7/o0wk/baHSOJ/EEZymnYyV/NwVk4BW0kyuvJ780Bn4hofBJUa 3sYN+UXh0n1WNzvCkkCk/7BaoY0jbthUluY8QCIa7VchPxGoFrDbsfWe7rHPQ9UmJ+1qK4y2u Lnn9kKrlPKCuyz6pXyWfcOboDorZXbL4SV/+RdxFOCXI8bNIEihAbqmRLZzh99RKSnDOOt68M Kxfz0vC3UO1CunyLjArn8kG8ws077pvD96RBOofgPSNdxcHtaVTn0EPpML9QPP/RHyEWeN25D fJYHBZhswuRDvuFMOpk8YHeDJhQeXGhxcQjbVZfspEJsUXmTw8DfTuvsIULgnQr+Mcm8L2XrL i1vQ190NeYipJkXptsGwksxsPD9TaGIwlkEyqKey4ohHoJHGfhcq9hAMZj+kttlL3sQkV0i9Y J4xWuhLeYhpR9JQD/kP7X+gvM5EYCVjRUGk1PfbhNsBxXMK+882XFQOhG5wL/GHamLTde+ulF kVyeDbm9+4s2+SNM5tGKpEL8KMcGS3bYYMc9+ro7+CYU0cDVoo3b4B2xSm+rd0/RvBXw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 17 Jun 2025 11:49:12 -0400 Spencer Baugh wrote: > Stefan Monnier writes: >>> There is no other regression. rfn-eshadow works correctly, graying out >>> the section of the minibuffer text which will be removed by >>> substitute-in-file-name when read-file-name returns, even if point is in >>> that section of the text. This has always been the case. Likewise, the >>> pcm-based completion styles sometimes move point into that text on >>> try-completion. This has also always been the case. So there is no >>> other regression. >> >> So, can we close this? > > I believe it is already closed :) Nevertheless, I hope the followup I just posted convinces you both that the regression still obtains. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 15:26:45 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 19:26:45 +0000 Received: from localhost ([127.0.0.1]:35314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRbxE-0006CL-R3 for submit@debbugs.gnu.org; Tue, 17 Jun 2025 15:26:45 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:60275) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRbxC-0006Bk-0J for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 15:26:42 -0400 From: Spencer Baugh To: Stephen Berman Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87zfe6mklr.fsf@gmx.net> (Stephen Berman's message of "Tue, 17 Jun 2025 17:52:16 +0200") References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> Date: Tue, 17 Jun 2025 15:26:36 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1750188396; bh=GFFS4A4/GLBS4twcnaTvKUKpIzRMptLl8FGXCui/2AY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=qUIekXZIqAyjv4VNGHfSGPrOfjmSEsu9jOz4TlmHxk9VPElP8ZzBS7nR7+THUOBYi yKWrTrHIzidBaiN/xnfChlujnCOfYKvUNKUDgP/OoeetGPezrhIRcMQ77L+xX9c6It 6d3ENVBg+64qtElQ4S/ZY7vdAtnjSdFfeWWBVX8ueLixJf6ma72bA/seXwRp4m/wSW gVvWtFPoJwTMWHNMiJJJmUtjHZbpvFytPYi9Ukkc5gRsHWUokkIY0yz3k7ijzKzMrn gMLzerAhovna8dFWVqUKSG/B4np8Vpp/nc8o9IYsABJdJlOGv/68nEI5UUjdgYBjku uvtqigmwqVqqQ== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Berman writes: > On Tue, 17 Jun 2025 10:59:56 -0400 Spencer Baugh = wrote: > >> Stephen Berman writes: >>> On Mon, 02 Jun 2025 12:38:06 +0200 Stephen Berman wrote: >>> >>>> On Fri, 02 May 2025 14:44:04 +0200 Stephen Berman wrote: >>>> >>>>> On Fri, 2 May 2025 08:26:44 -0400 Spencer Baugh wrote: >>>>> >>>>>> On Fri, May 2, 2025, 4:30=E2=80=AFAM Stephen Berman wrote: >>>>> >>>>>>> What about the other regression I mentioned? Have you looked at th= at >>>>>>> and tried the fix for it I included? If there are no objections to= that >>>>>>> patch, I'd like to install it on master. Or if there are problems = with >>>>>>> it, I'd welcome a better fix. >>>>>>> >>>>>> >>>>>> That fix is not right and would cause other issues. >>>>> >>>>> When you have the opportunity, please say what those issues are; I ha= ve >>>>> been using my patch since the first version of your changes that >>>>> introduced this regression and don't recall any issues with it with my >>>>> setup, but admittedly I haven't extensive testing with -Q or other >>>>> configurations. >>>> >>>> Do you have a rough ETA for fixing this regression? And again, can you >>>> please explain what's wrong with my fix? >>> >>> Progress on this issue seems to be stalled. I have no reason to doubt >>> my fix may be problematic for use cases I haven't encountered, but I >>> don't know what these are, so I cannot reasonably investigate further. >>> If my patch is installed, those who encounter any problems due to it can >>> report them, which hopefully will facilitate finding a better fix. >>> Therefore, I request permission to install my patch. If it causes >>> serious problems for which there is no quick fix, it can be reverted. >> >> There is no other regression. rfn-eshadow works correctly, graying out >> the section of the minibuffer text which will be removed by >> substitute-in-file-name when read-file-name returns, even if point is in >> that section of the text. This has always been the case. Likewise, the >> pcm-based completion styles sometimes move point into that text on >> try-completion. This has also always been the case. So there is no >> other regression. > > I'm not sure what you mean by "no other regression", but what I reported > upstream still holds in current master. That is, start Emacs like this: > > emacs -Q --eval "(custom-set-variables '(completion-category-overrides '(= (file (styles substring)))))" > > After typing `C-x d / TAB', I see this on master: > > x More simply, even with -Q,=20 (let ((file-name-handler-alist nil) (completion-styles '(substring)) (default-directory "/")) (read-file-name ":")) gives you a minibuffer containing "/" Hitting ? will show all the possible completions, all of which (on your system) contain a "/" as a suffix since they are directories. Hitting TAB will make the minibuffer contain "//", with point in between the two slashes. You can then continue to type more characters contained in the directory names to further narrow down the completions. This is the behavior of the substring completion style. When there's a common substring between all the completions, completion-substring-try-completion inserts that substring. Since the substring is a common suffix, it positions point before that common suffix. If there are any other completion styles before substring, this doesn't happen. e.g. with: (let ((file-name-handler-alist nil) (completion-styles '(basic substring)) (default-directory "/")) (read-file-name ":")) Hitting TAB will do nothing. To have only "substring" configured as a completion style implies you want the behavior of the "substring" completion style, and only that behavior. You are indeed getting that behavior. What's the problem? substring has always behaved like this, so improved consistency in edge cases like this one should not be a surprise. Is there some problem with this behavior, some reason it doesn't work right for you? A more concrete complaint about what doesn't work would be helpful. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 15:55:36 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 19:55:36 +0000 Received: from localhost ([127.0.0.1]:35614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRcP9-0000lK-NO for submit@debbugs.gnu.org; Tue, 17 Jun 2025 15:55:36 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2472) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRcP6-0000kh-KF for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 15:55:34 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9E3ED10013E; Tue, 17 Jun 2025 15:55:26 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1750190125; bh=pQU1p2CcaR3nPR2BEyjI3hLS5SgyBS/2sd79AmcJTHM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Uf6fFROPqTUfFvXBhFA4SWiMbXVhl/ZPvxmQR6AyhC+JhOZVBYZ4tZdT5fBIxYpQ4 rhci7slqcHs0i2Qca4NJvwxAPXAxBZzC+Uj/zziDRMNxdaNTmZWyN8c8Dscy1NeOfe h+Y/TbYb+Z9GlyhMaBYMlVcrlaB5oBtblovI4udaTwKS4+6vCkfMhjE/g0KnUYkeS8 yzUF6Q0c46K+nHyjWkqPH1oJCjvK9QwuY93B/CFvE90XDOUt/xbL9w6Q5n1Wg9BlyH ldBd1uQHmg8PCIln66E9Joi0itTKP8Rs3VAGUZOeUVDUeaXqO6BUZVKbmFJPEr15+v zoPkJ5a/Z3gcg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C200410002E; Tue, 17 Jun 2025 15:55:25 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE83F120524; Tue, 17 Jun 2025 15:55:25 -0400 (EDT) From: Stefan Monnier To: Stephen Berman Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87zfe6mklr.fsf@gmx.net> Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> Date: Tue, 17 Jun 2025 15:55:25 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.084 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , Eli Zaretskii , 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I'm not sure what you mean by "no other regression", but what I reported > upstream still holds in current master. That is, start Emacs like this: > > emacs -Q --eval "(custom-set-variables '(completion-category-overrides > '((file (styles substring)))))" > > After typing `C-x d / TAB', I see this on master: > > Dired (directory): ~/// > > and after continuing typing `us TAB TAB', I see this: > > Dired (directory): ~//usr// When I try your recipe I see something very similar, but my cursor is positioned right *before* the last `/`, so in terms of completion, it seems like an acceptable behavior (I'm not sure it's very useful, but it's the result of the generic attempt to insert the longest common substring, which happens to be just "/"). I do see one problem which is that the whole `~//usr/` prefix is greyed out by the rfn-shadow. It's not strictly incorrect since "/" is indeed the filename that would be returned if I were to hit RET to exit the minibuffer, but given that point is *before* it, we could argue that the `rfn-shadow` could/should presume that I'm about to type something in there, which will immediately bring the `/usr` back to life. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 19:01:04 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 23:01:04 +0000 Received: from localhost ([127.0.0.1]:37441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRfIc-0002EB-H3 for submit@debbugs.gnu.org; Tue, 17 Jun 2025 19:01:03 -0400 Received: from mout.gmx.net ([212.227.15.15]:47553) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRfIW-0002CH-Rt for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 19:00:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750201248; x=1750806048; i=stephen.berman@gmx.net; bh=ll3keq2Quf9QqV8dkKMVqh39yTzDps/CR4osB00OyLk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=VFAyZRgCMqoy0eC7A1t6WDGpDpYUoflkYAek1Y9FXOCmnJp/V30M2old0qDCHo4K +5FlYv83CKhmyeA2oW66YMo8SbKznbMtEe1rJ3togjawxtPV+BTey2ncskAdqzaRv Wl/YxZyUF+ProkfhiQdZtiKdflwSdt7uGtS9cQKU8px5bFaV50BTDFc9jacRIKajL 7pX3BPkK4v8NPkUBS3R9MaOmfEudEftU+LC2pXef6YdH7+YSL5I3+eKryrQ5SzbAj 2Jei24+lobpbGj0VnCHonYs+Ditie1thO7FkjD0pgaj9i5hnUG7q3MJ+lDEidlehg pkngzBiO3PtTiwtuzQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.38]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MLiCo-1u9zv61pZ2-00KP9m; Wed, 18 Jun 2025 01:00:48 +0200 From: Stephen Berman To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> Date: Wed, 18 Jun 2025 01:00:48 +0200 Message-ID: <87jz5am0rj.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:YK0Ft0lxxq0iZlhlc7gHwl3L0YknIm8QsSOG+x68ICuNcUnW9tq it6eh1VfNlWGx9cG1GFajawf/O41FW/m5yduTYkWf5Js7QNFMnTSCHKKvsPQssfm1oCbEsz eLA0TW/31v8mJpLGFH7Xq71lzq5EdR1UuxFPTs3P9z2/AgbxMbE92MzR0hkva5PYPnEwF0B X+ffAR39UTIt8+USgVSCQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:uwLCtrXZ+ng=;kF5p9M2fxSYQXwc2bTn4YpjMN5S vwCFsPe+FFWUeworVf9XqaT9X4iApKHtygqt+NEOOvuqoFE5/SilK2zPNwcI65YZlPPvOsJGY mf+twHNpEWU4aG26p/aSPVpgx1hNb5OfM7905P0H7pWdswlJLGyb5GBcNVqV9OUD7nvS2G2lj uEstC6s/AzEvj7UEJbEfxwWd2s0rGWD3jRHyZhVoqKljI9QPbD5dCN/opWgf0iRk1h2+bv1H5 xvJhBNCbrn7LW490jRKqLCfYWn6c3K9Jqay7ALA7UaC67PHXFNscHXZz3nVCfEPNOeUfJmncl FxHvGza2G7VtOTppkigJGnufgNS2p80c35CduqqeQvGzEy0tinXiYptYmfizIkYvoSWC3nP0Z 0AkyKxO6GIwazUMjJwANKfB9Ipf9wflVylPQu+2O4F9wjU20EvWllWiilpHQREUreeBHEcytP rnZ+sSyhTzgsvA6kFg5MLXC94aYEwFb8KikP7zi1KQvmtPfGIeMB6uOq/L/+YcsyqdO6aDk/g hrXnivc81Glw1wbbmrB9xwRWX4KXQtUqf5k1hLoZF01BzFicUgVXo5S4QAqtC7VGYT9YV2SMC kLryG8MAJfN0U4FAgtYd5iBazO6eBsu6wDECAjAQj4BbCt4p5u9Xu5IY5ma0GD6GeByAcwTiP XcrDCcxklpqaPtR0GZklyYI0uuxZiRzSHqqtZwUGEpDvMcBdjGeQUWm7sxMCk0zpmQFtAUG4y Tt94/q/+RFk1kqjq1VqoZai3Eum/vrhfaLzVGskH/C3vQ7/Qw1MPqGneFMAvWTgiIt6ttGvza WpaI2v1g8gssNvYHh9xtDXxs+KWNc0TXGP7fTNhisxcnkxSkEEjyHz5CwDGOkxIocMsGnUU4H O378+0Am0c0RVIgZEgBCexW8FXD6rr6RNg0HJenjymy1NX5NeS5dZ76gRWqRWKijOxWUv5Hd/ v1MfvD7nkOxd0R4rdXnVsNfOtHWNTNttvm/rfOGsdE/8sn0bPcNWylHbsQmIXQFJXgysQwTtj gY//2UYD28ZLdFhqRsKE5EdebhfboYXUV438KCbz/4RmHseR+rwQDWEmjhiekf1lRzg+o+cL9 FGF/RF6Z8FIo3vC7tB5DqXSQPHUnE+jqPpuDswxWwt8SMz5GisRyHx3Dax6gy5bsO0dunkybq zISinhGTf1ejv0aPHqxsB8UkCxEVrwyRE5O8dd9bST1rLWEMitRMoz8T0AM4yeHzYdTf6l/eC Y83Yuwrjx/hZxFdrzX5uBeKptPBAenG+sQ8OsBPz0zE/uTp5uuOMN0G0CE0fPL/NWwFQ7V+z6 fXJy8RdJ4wrpdlZGHaqkKkKnPaOydsq1+rLEcAfCI1S4Y1kToVaYMTt/qwBQfIRSsfn6NancP 5uWT5ng4UA/h0UcXlqkzPzwmQ/xzrsuQZWjzjrYd0u+J8s/FpLfvgZE9F4b1/QFL2EdQmwMZD T//K8RYsec88K6A00P2NDFQonru7ScBWMyPgW6LIVUQibgpf5gNBJrDEZZwsQsYlu3Dj4Efnj VZYhNADO7sxK2TtJ8w75neVu1swiTiufoLBgGubrsxAvsdFc2rYM6uf7k+aaqksgHc5+jIZoI 399zfGDqIxg/PCnnrO6LNeYUZ32JOojTrGYZWmFBtaLXHmkhr4vL7cvEN+Ap44/UJVQt6bAW3 TJrNhzIybdSNn2Q4Je35x7dRmw8IiWt1y5qYmgiBej+6ZK4ROi+tAQ34gH25Ft7EB/rSfczPt l8xNs+9hWmgIKZxSr7/rhrvZU22j8TvHHubMEufFW7QkT4kbnxSg6y6tNjTTHYSKbADkGRVZI /JwK9h5uQ7NfgYX4LdE1Ya0mP8CGCinroVzalWK7i9aRFA3+BjLYAkrdYJXNAD1dAljdd0of3 /6lbU3klZu8MQZkFEkt3fIP6O2MgUk4VYcIG2SuP0QYq14FPs3I+qlPHuqFEOM1Sin8ZoVgx6 SwB5dCDwf1jG1JNXanSTggnRyZdnBCHsQH/t6VsghmLR0u7eYaxcJZjubzO6RGx26364yWDe6 2jaAjUyHBY+gdji2AoH+zP3gysQEC/mnbV8kJzTyFM12BhlHFLzdwFO+TG4Kfc2RUUGMq4GQ6 MlWq7NA61KJImyg0a4kbmhDbo4/k+2PgupqR20h3wGEYJPOrOoLCpxntxTEzBr7thmBVKXlRg grwDAEeWdzg7Z+Lo319W5/VOU/fBWHMIcWerttOkPnmzr4k2cuov+ZGjQj0MczT1KDCN8Re9S Hl2mSQh1LiyxSTZajGVrjUjU7BnhGDy5jfQ0Uo9Q6hmjSI4dBoAp55DEt/DpMtqogJ4opZRia wJcvzLZuaRn/p1nCPcR2kwhpIwqmKRiC59G7UNV1rS+d5faxLfbsJ2TQ72OmHlrV/CkUSfQpx T+xx1kDZ2a4B/nLwkkkaEV8zz49O9p5YKURctn83rZWH0175xmVy0FPVEF2BXMFL8sX6p5mVk wGPkYBy6moG1izRxuCEVxPRgAA9jx+DQ616eLjopxvfj3dRStAvLw5Y/Xdtp/f0ct3OWHbOib G47NwIznd5Y6HFPGf2gXy3a+qz5KBCjQ1rpK3aJIy/QyQf1aMNt1mt08gdg7Hg4gHU3AAAvOp Bs/22WWW3k4W1wwu3je9hi0jBXmISosZxlK+n8WgfCpG+i89dEwkkq7uHJVeoW3AN6ZYPlRoN RZAtj3bLS3giTcpEmzJA2iDT2WrckEWnl/ufA75bS4gQOtb0pz90Z1GayVei0g431aS9cc0Gu s6N5idP7KoIl2PJF5GapwFqK3AP9Erw3E6B8A4IhxYasyaPRr8pMH+q6paekNBHXlBnDZbWrG mOynYlDL8hQD3qg6Nyqaamvn4JHISMTynpzii87vuYP/JtEpWl/6W+Srlx5kqoB+owZdUAFOP fswcCX4HbwCmyNhVe3HEIPWkBtbrXJXNUcFWedJOUSf6PeYb4iMLcEKOC9XgCIoSvtLXwGWRJ waVyo9zECikjlnEwoT++p5nrHNZ1Hb0t/v6C9QLBpvr9nsEOlQj/xJ+OESE4qx3E+M8049h9m ZdjZ2kNpL8hQSuiAODBSVEAK8UJZsFLidR0tAOfuIUsd910aEnt0wfw/xdRJewJ6W1kJJKSts pf4TdolJPKpl+QpRqqbHQ7t0kBq1QwFx+TeMNYhKAPCNUfNh7yXr9ayCizVUhPR/nDURyl500 Nu392NlJj1+1q3drHQe0fuvcYqqGiF6kW6HYqk76r5RsI8/OAIFwYjNaVmXBzc/2TEPHkL8Ae OKXXVaIbLGc4LpeB X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , Eli Zaretskii , 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 17 Jun 2025 15:55:25 -0400 Stefan Monnier wrote: >> I'm not sure what you mean by "no other regression", but what I reported >> upstream still holds in current master. That is, start Emacs like this: >> >> emacs -Q --eval "(custom-set-variables '(completion-category-overrides >> '((file (styles substring)))))" >> >> After typing `C-x d / TAB', I see this on master: >> >> Dired (directory): ~/// >> >> and after continuing typing `us TAB TAB', I see this: >> >> Dired (directory): ~//usr// > > When I try your recipe I see something very similar, but my cursor is > positioned right *before* the last `/`, Yes, that's what I see, too; the screen shots failed to capture the cursor and I failed to mention that. > so in terms of completion, it > seems like an acceptable behavior (I'm not sure it's very useful, but > it's the result of the generic attempt to insert the longest common > substring, which happens to be just "/"). Yes, Spencer pointed this out too, and I can appreciate the desire to strive for more consistency (whether this is an edge case or not), as long as the resulting behavior is no worse than before; however... > I do see one problem which is that the whole `~//usr/` prefix is greyed > out by the rfn-shadow. > It's not strictly incorrect since "/" is indeed the filename that would be > returned if I were to hit RET to exit the minibuffer, but given that > point is *before* it, we could argue that the `rfn-shadow` could/should > presume that I'm about to type something in there, which will > immediately bring the `/usr` back to life. That, and also the points I mentioned in my reply to Spencer (extra TAB, failure of `M-DEL'). Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 17 19:01:40 2025 Received: (at 77718) by debbugs.gnu.org; 17 Jun 2025 23:01:40 +0000 Received: from localhost ([127.0.0.1]:37457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRfJD-0002Gn-7n for submit@debbugs.gnu.org; Tue, 17 Jun 2025 19:01:40 -0400 Received: from mout.gmx.net ([212.227.15.15]:46833) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRfJ9-0002Fw-8U for 77718@debbugs.gnu.org; Tue, 17 Jun 2025 19:01:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750201234; x=1750806034; i=stephen.berman@gmx.net; bh=mZ/WQ5ZhG4i5hQEZIpUtHF6kBURakSOkwacls4FVxZI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ddKdmhQjcxjCKE5EQGi1Q9FjE98RQmLeRu+bL5Wcotde1N3pifrjabpCyzDlKNhl yEqPFkpuBp6keB8abTrFMls/rWtbIkK1YXp172SpV2OPxQpQYf22gbjUprJVFu1pQ BOK7qtpzOIASmYJUr+QvZlh6EampuODrV+yLT2mMo6QzWDLwE1eD6jdpPEagh6KHq Tf6UrCZCsGP9P4Dee1okGwquHqCTKX0kG9VabpTJuaABA0FK1BkouZPneKjYIC0JH pKIrRw5pkj45Kz+ZDIDK7DISEkKkMROjht5h1iynZPKjQDfxh6KH51La2oDhxNQie eZnUIOPbQ5JZ5C8Y6g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([94.134.94.38]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6UZv-1uPBFY2QmX-005KR2; Wed, 18 Jun 2025 01:00:33 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> Date: Wed, 18 Jun 2025 01:00:31 +0200 Message-ID: <87ldpqm0s0.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:g2QQXZBSS2jEDIANvfZ6XJfNCjPaoZ/9khVGxnGUb72SPZ03JMd HPynNIVBpFi3SG5K99QTDowHevLyAdVwBfwTI+qDFUpM6IrpsB7W2Vzelh99SUb26LKaUns Ljh09HF5AiXSYMo5e6dRHlQKSQOwvpIUQ6dqmmQr3pEB6aaFWWCpH46uM89QgFgjAX6ruhK cfK990IR/EruS8eD4GNzA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tOVTDGCp/eY=;GgSxQUBRAKi62npG1eZdlbte3eh CxBSYprqwtq42JKa7pYeyvBEPS69W3ksLJSYxnY7pWPuU6MKwhNvNR9fvf3YpFlnh43hQHRUU R2RzjgXrjR+dFM+vHs64QdG5Fz8OfU2R2tTjtZPhZk0fZuGyPcXl4FSCbnfg1qiLqIb35k9+Z cBWZdYyyI+l8Lx4pFmFPlaTfLKar+ox8TYjLOnhwyTtYsj11uJqtpTFqjMRZV/B8zi5x+GWVg uXY0/5o7pHADXiOdR8ZldqDhH56jedAReg2zOVY3kZMSuy9YjesIYdhLpn/wMkpaugC3RvSmS WMNN3gvelh/W1OHWkcsuoXbMYtOzWf9umr3ybpymf1pvmCuFytteNZR50o73Ol4aTMF9E+k0b KBik4fBT2lNBq1LEyYglpCTdsdM+JFH8hxl30GtSr6sAPGCbsiLM+/4fm4GLTiaDa3Jz0Tzg9 VDGKK6A6SgZ0J99I8179yXVGq/PJwCCcn/FqZ1+Su4vYwbd0AnHNdKtEiKBQDGV5SZqp5vhco wDe+QLy/uiCG28wjaQOtwsl9TGTs1FPE7nrATHGLOTU7ZBlklNhQwXIcomCp0Eyd7PXqgjoYi maERw7gBJEfNucmUEdNUSLl/iccPGbAZRxBDtqeClxeahdj1moSULV3TkHR4dnBWkWZb0D1of KCBhqzVWjSwWoOQdWzswiX3it57lGs+NBVaptofBTX7TrxZOM+Zl1X9L2v58ozxuRH5wftR4K PXXGvPCAVnFSsGnpnAuCU8tDEfN72kR1g5zxoFTP7+jUUMSCJlrQA361w8aKBP1Gtov4Z6m21 gcD6dVnytQophMT4cHPtWJ/rCW2JOq4BSNyQDb+yIesQh9DHdqW6HwVGlsWv7quaTZ31125z3 HJ7kRhXNl63Lvu52EIN23NxsWR4VadJFJBmqC9CpFNBfpNVWd9XfdMnXf59UZycFkzLl58rou YouU1N8u9T8ZNJX/KIhbt0BF5+rrjlKp4zyC5orEvKXDQSGU3Y9trWEm9bm2mPSPemUfsCqCh wVHmXCNBmRGPcFH67UNVKZTeNuk52cvrq+qCWi4viZN910Ocwm47S2WbTDJFkAskvS+ZCdwdP XoSfqyuqKjO82Hclbpe5TkkxYuKTpQKuDfdcFdl5Ve9A3PjzCg/btTiNijug/g5npSGTNT5ZJ 2xKNNkrHfnE+BpO+KJfx8i1MowLwCP53SPCEipvnExlBnRJLMnROJlpR4qujV8toJGDRKCRZ9 5uWvvLwYwakC0e9Rf6oZZSgBZcaqtvlL1+9PVbIIwiXbC8ERTxMS1fhAKSC0Ls759sMZbtVwi t5mwbPYQOhgXHvsf7CBiLYBrAx/Z8YGjb3cjQpxcb1IjYRbZ8kKFLQmY3kHDRks5iF9He25YW jWAYfOYqXILhVER02Gn7qo/aA6BVkKNIb9atAi2Abqo6Z6A4C8aa0OmRJCGsX0oXOk7+/ZzGU LWrqFoiWTfNscMppJv8S9YaQ31veoU/esLdAvs07vZbJcEy4EA4ec25GNzi5JnTvS1Q/3E+HD YoQGdwSw27IueLip/I88VpDfiCqt2+2KFheKk+aeH57JkfS4Y/vB1HVZKxcPjA9jpVJisAyH9 jqqKgWwNFzrFGjxAMDCOryLZYFIoGqEwvjD0e5Qd11HqPeRlI0hU3y8fpZCOhFANhESGw4BrZ H1oPcv5hR+L9+LiXlt/JAPq3j9ozptr2LEow4jxH2tHSx+Ci0flfWBZGii4P+9hqQVTwIKOw6 9g2f1dQDkLKjVovRhn79YRbBYj4flxq1kiK6EtKcAyK/rT+eSNYJdJHlOP5C9ZLekMg97hrKG HxgQX5pjGIZQtOc5IFkQlvvxxCppuPjNwCwh7e+rVU3YNumI1cEcRadwZGBpQWbVtnHM5gGt/ hb879JV1fyugKtSnzssT/ef4wkoYxva9vChCqtRrX7sBvUyywDHNlK6hmNKr9b2VaFRXgI+Po F1eK5zg8ht7nuKBELwUt9uK+MEnxNE8PjeO86nfeTTLXJlpyf1+nMY5cfvFWyKQRgJiOufdY4 FucbPVDt9jshs8utsogdHHK60u1WUXyZGkgXT8rf0/MS3IWt+urUSb0YQc37HFm1DSsgNm2/c qZeeKUotTqdEVgShngFie3DDICfeemrlC7xM+sqBBeUdpYp/7a19/McnBzS+MrPzd4q2m+8De 2CZymxbq7rHaf6vWmEAAwt7zAaBZol3Bex33G0nOphNed8DCARvF7++eFnbt/BRikWcwjMHGv V1qs86qN7dbdcMMGxJcDUfjfzYRld7aEMNMc2/q10SdcSgjIPTryu5PX8cT863OMlByh3guVs u4N6RfKiF9VNQBIT3Oq3o3F8kSH+yDtHc8hAcv3ClHENxMNmkUT+5KJE6Id+fMejHJ4SyBbUb 9PhEhd6CkCm2SIFZhxeRoFzahjzIN0kFI6U/y9gJEHKsn4CkzcpP4hcyERzfXk5028iaU3nYE m1gB6xkfgipb9bPV/1vrOIv93HzyBA7EAeG0kwOaG04SOqh6eHdbtdDg7TEmKlin9wIeP6sGs kiBz7Xs8XhrMELpQdCNEn0yuQ7M7Fs3eN70akuYXqIzflvdoF60ua5+v6t1MrqsMQIm05h7ia qbCGlDXjGZKUKQIOmBLLjqnXh8LckfD02tl0Y9/EwnClJOsWTaK/RtorEANhJ+HEhqvg5h9rA rXs1QgEEBsgrkMHFksjwoLQnPEnz6ZLDNl/zkxgAijiIrBBHEs3dJ3oRKZj2ifFX30oyeNmfs 3yr+TnAfI5LDfhRpqv0+FWlHN17IX0LtgNTTzn5gmOnToAy7v+0mZElf62U52txl0kTSjtEHj Bo5Qya6lma/mZPrOBBga0aVnn8/vtD3ET2/LhtVO+ShHKFZ4NDhOSO4JYlXsd7BPR814DNGKZ Tx91juefFIZGNIwg/w9YVx+y1nRoaELKPMbQstIEusbJOm2j4wpJrYAMVTaN5fux5o6xpwx8k KZhDHjYIynyYgLYSrIPS3N1cncI9soogHOevadbzL9Rz7CCKpmYDcwY7jp3XPucTIWd2pLpk5 K0jMu2Nx63WZtbih1Ly4HgPUSlQntsT2rQ8T5zuvE+KaPQd8ZkOKMBjnSC6T9odbdAs8oam7J aBDUCnL8pO3eCwNkm5wqBpSfa42X6r4LF5cH2+fIjQyzNpqCfaS5+35YD1CtxPrP1y56qxYx2 f4E5mlcokpvMCU0YY1A87dXIfzZ+EYyoIp8eellEqGScfEe3Tn2c2mFp2nXBEm6uNIZ2evuSP prKwyI7c0az7fqPY Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 17 Jun 2025 15:26:36 -0400 Spencer Baugh w= rote: > Stephen Berman writes: > >> On Tue, 17 Jun 2025 10:59:56 -0400 Spencer Baugh wrote: [...] >>> There is no other regression. rfn-eshadow works correctly, graying ou= t >>> the section of the minibuffer text which will be removed by >>> substitute-in-file-name when read-file-name returns, even if point is = in >>> that section of the text. This has always been the case. Likewise, t= he >>> pcm-based completion styles sometimes move point into that text on >>> try-completion. This has also always been the case. So there is no >>> other regression. >> >> I'm not sure what you mean by "no other regression", but what I reporte= d >> upstream still holds in current master. That is, start Emacs like this= : >> >> emacs -Q --eval "(custom-set-variables '(completion-category-overrides >> '((file (styles substring)))))" >> >> After typing `C-x d / TAB', I see this on master: >> >> x > > More simply, even with -Q,=20 > (let ((file-name-handler-alist nil) > (completion-styles '(substring)) > (default-directory "/")) > (read-file-name ":")) > > gives you a minibuffer containing "/" > > Hitting ? will show all the possible completions, all of which (on your > system) contain a "/" as a suffix since they are directories. > > Hitting TAB will make the minibuffer contain "//", with point in between > the two slashes. You can then continue to type more characters > contained in the directory names to further narrow down the completions. Yes, I noted this upthread, where I pointed out that this differs from the previous behavior, which is why I called it a regression (https://lists.gnu.org/archive/html/bug-gnu-emacs/2025-04/msg00884.html). > This is the behavior of the substring completion style. When there's a > common substring between all the completions, > completion-substring-try-completion inserts that substring. Since the > substring is a common suffix, it positions point before that common > suffix. > > If there are any other completion styles before substring, this doesn't > happen. e.g. with: > > (let ((file-name-handler-alist nil) > (completion-styles '(basic substring)) > (default-directory "/")) > (read-file-name ":")) > > Hitting TAB will do nothing. > > To have only "substring" configured as a completion style implies you > want the behavior of the "substring" completion style, and only that > behavior. You are indeed getting that behavior. What's the problem? > substring has always behaved like this, so improved consistency in edge > cases like this one should not be a surprise. You may consider this an edge case, but it is proof that the substring style has not "always behaved like this". I don't recall that the goal of "improved consistency in edge cases" was previously cited in this thread; if it had been, I might have viewed the issue in a different light, though I still find the current behavior problematic... > Is there some problem with this behavior, some reason it doesn't work > right for you? A more concrete complaint about what doesn't work would > be helpful. ...to wit: Before your change, when using substring style, typing `C-x d /us TAB TAB' completes to "/usr/" and pops up the *Completions* buffer. If I want to change the input, e.g. to "/var/", I can type `M-DEL va TAB'. After your change, when using substring style, typing `C-x d /us TAB TAB' completes to "/usr//" and only after typing TAB a third time does the *Completions* buffer pop up. If I want to change the input, typing `M-DEL' has no effect, though e.g. `C-f / va TAB' works (the minibuffer then displays "~//usr//var/" with "~//usr/" in file-name-shadow face). It works, but it's a bit more cumbersome than previously (an extra TAB to get the *Completions* buffer) and visually confusing (at least given familiarity with the previous behavior). And again, with my patch (posted in https://lists.gnu.org/archive/html/bug-gnu-emacs/2025-04/msg01860.html) I get the behavior and appearance I'm used to, and for my usage have encountered no problems with it. I ask you once again: please tell me specifically what problems that patch causes. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:02:33 2025 Received: (at 77718) by debbugs.gnu.org; 18 Jun 2025 12:02:34 +0000 Received: from localhost ([127.0.0.1]:48252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRrUu-0007HV-MY for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:02:33 -0400 Received: from mout.gmx.net ([212.227.17.22]:58739) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRrUr-0007GP-S7 for 77718@debbugs.gnu.org; Wed, 18 Jun 2025 08:02:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750248116; x=1750852916; i=stephen.berman@gmx.net; bh=Kd/T6QKTykXnTHE59i/hQqKGvzIEiagYJlfWsNfqFPk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=CsoPvyeJMLQyMLexy9Nv1zubmZGl7QO+JmmRzdbubIfWKKXVO0fSbdQLBCvH4riG K4uf0RHYMxF6b49klwE09G36dEIGKgAi527QGp0i30RgQvilSpt0CIbQPIYrrvR/E 3W9K0w3lwTLKsugrGe5YXY50g3kE3vFTu+2ye5NMHqH6DiMrnsg3M+2Mu9ZGgthM7 OR3dCLoXUKHPsU/Z1Ix6fwrKrh6INTQSkfGciJM5uF5tvpPNQhyZFCL3ppobuyvPZ 8UGm2T0iKRjWWzRLmKTyi+17y2MUnXS3jyWupolw8Q/S0ayelW6XLtpsfrwHt8CHv 87hjRwbmnNBbKcSBXQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.50.166]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MF3DM-1uYR3M0D8K-007rto; Wed, 18 Jun 2025 14:01:56 +0200 From: Stephen Berman To: Spencer Baugh Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <87ldpqm0s0.fsf@gmx.net> References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> <87ldpqm0s0.fsf@gmx.net> Date: Wed, 18 Jun 2025 14:01:54 +0200 Message-ID: <875xgtdzrh.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:rA1tb3g4sH2EFbNuQYdVZnCVd1BRdbUq+iPKyNMDOxZQMOUFekl H6yMm8ZO5qIdUoUpJYdTZeDsY07kMULmXFm7bxbx9fvpoRCru1uEaMdSrMlUyfpoRc3Ul0+ jRXCRaZlB5Fbzrh+DvsstfCI0MEntavaMMKt9lt7OMdJ2a3N3X9GxgaWT26ADvbR51q9NNH NmBWvO8Qf3CdGmJ+04l8A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ZXHh2YKM3d8=;W0jMeQBiprsz+pdH9ECAB9CMCoW /WbDRWJTRgfsJOR/EpOjSQQ5JaSBj+LYoOIC7tupz44v444ZX+5wYuP9BKHZ8kc7ssm2Es6KN yakCqHS2kuZrxI0S6yhaE4v9e3BCaTbtLnUcAKSABacC5OzKd5jFfVFenLq/ZuHrQqERfMpVO 67FiWLzD6rdcNUJvvFVfDY19KqSub66HgJeLBMbkmGeMncGGUeQx8XnEv6sLvHz5zX3eSmjIn updi3F9xlkrUB62W3YhU0VZ2Ry84ZfZZHPOqF7c72JfGaLQKPH1wBmInAjPrzYtPgcufucc/j U3VpavSLafh4TW+KoU7i6CZiXDJPIXlQt3heqKLECEzX5xPjMTL4eCmJWC6N4rTFa+9cN5YID he3nOh5Iq4/BHOJa+CalMqdWXLo+FJHHGc9XQz1U3NFEe0+HLokFpo7aKZVjLzRobXrEjqRa7 f/PPc5IqfZqiEb7n/KYxcusSPK5wQl/sDUriOtU2t9Vun7juSJ1mPhv47nyPEXBT9LkwZiUu1 qO5A/nOuj3yF35sxMe+E4Jxd6mP6+f/Qu2N05KJWwbB5HWvUIF/MYIMddjW8Y8uDxD7udC1RT neStmQBcsAdGrYx97iI8y/8XuqgS2jRBIufpwk+ozyrcPOmrQ/6ITQIZ9q1xXAueNUGZ0YKZj 8NDl85h+LWh3a/tjIOUhRZwPIWEx87OeO2DU5hL/+v/SgJ8l5GEGgAjSXNiCZei6hn7z2nlDP Xi+MtjloAn/kFHIsMBmxPWyD4FOXIQcwbz/sH4uFG/+kSz0Em5JkFeIXOEvaMSuGt0uAWHtrw oWLfgcZZjAqmH3y8Q+fT2WhOV/dXHkymBEKsbotfKhYtGMbtSdQR+rBKNBJORjn06ga4DlmM9 MXfGg3wB+AvuWEjSoG/SDrmoffA3Zg9ItNAZ6RJ1TU53VU0fA1PNPxITMy7BAUy2nIwdrTpFF iFi0nCvvTfKEY0QW9wsp7yFIrbleBzwYdwf99jXGN5MavgwCtca7uDPRpEheGFbubQqpOD5VB TdgqlxJ4MePNvIkPH33zf9H2C9s2eQ3xmhmQnf+D+0RXWYXBK+Xqp7eTnXuqaplSPkuIS06aI aaw5Zs4U/IKJ9S6LLfroe1zh55waRyMyX3UFppOy+WBBirpm04XN0vhTMaBzswvsxyzkyAjeE kfSfISBHaFaCHk6B5dg2VJQZ42wdXFxTUPzzNmUxQ2+VusZqiYr/+834q16qpICkEz1pYWOwW dHv7iuMHOLLeh7m2q0JFYbZmEoeqEt5k7Iu+IdeZKxg4aPqwXp5bLqr9zUl2UqrXgXNWPAyRJ Xf7NxP6NgXv2lUfMXDTQA9FNszVOM/nXPDSzOiSaGrzoxK9bFxpTQKHygsnCy68anVRNBk7xg 0kEFWZXrbvbc7cFkxfrpgotPml/UqayAI3BgLKDtMHBsl202hPF2jPrIc2133W0O1dxbYn0eR 5hWUTeaYr/Gl8DkYA2Z7SwEK+fH9Wrx/lyd/9yvlc4mTS4keAlDyHZhcUgT9HgAQwSYYfFRRj uf5uJxstqFMWoNlM2Ur7vz9ao9Y9KXGliajpOS1pkQzSQ8SeGGETb6y7vTrcZIgt/5mqy56Hn 2ULDkPPi/umy6SsBhUUJFD0+TMk1BaFVrNyxZOLaWOuGhqj6pX7hZVtVxK5KnMDjTmhGFyqz+ XepadDP9AdS44x2tqkS93DEUZFI8JjYEz38nrdEcJbdHhUsoPqAGYBFssBFyt/NBPIiKtr4SK vnFTCRGt76IyRops8rTRKNjJB99/Od+45gEG5InWeos6dsnHP4gveQ5MgNmOXKo6D8FNudU/M hEK2ONGMrGP76B+EesrKhKO5a2IKf/uOji8RXyympuPOsAm2ydLWDqQPpqvuxX9X4HdLTI/4+ DezcQhqPNSAZJRnLBjROyzHhqbhaU03piAWkdD3goiPyWDwB9MfwX5VUTgU00ZzrznkUJmicj +PlG1x2Zs5uwkpKyEyFfxdleupxlhdM2sAzpreXdAvMXoBKklP5EJZyj0pgixcDfbp+YeLQq4 jJdm7CbzpGzJ/oi9ZQH4hDno3jyMte2UfyBDQdDYDVPbPAiLORfsdpbq3pjlp4WluZRGrTRdw QDtjLOCW40o8/kGyUsEmUvpq/hJdjzOImKks+jip6K/9JhDYkDWcJ7xhPRQ87mrS5Ch3uzEy8 ZxXSO6KCwzRSfY4K2983zISdSnUitJtoSogDYPDtt16hcTlzLTR0cj+2DUzjbIeL0mASSft8U +nmsoF4lU39QSYKKiH+Vz9h01ar4OIKgOtjLkznDvPjYN6IuSDBbyZ5rFg3dgAyzZeQHNiI0o whnGWDYs+QjJaaRz4Wiz/Rth+QJiYySrMs55ZCP0gEEtuhp/a5YM4xMTQQOeyGFOmWbiJ+5Cz 371amfBXQOxDWwzz2LkkPimRYXoWsh4v70cjZlCTwIH5a4CM7k2yqMfEFSDLiT/7LUYyEFN2w pRpq/zNOpV/YSkfHuIXSmUK4fSgvJbvHTVXweu85cUZKS8AXcDZ1tyQ2WYOqJOupz0+V3LCAC JWxDszm6BZNXuIVxWaczyZcXYpWSb2hzXc5IElwqG2CmL0/gZnfpKZAzW4EYHytTVgycOLI4r um2lG38VYw1/INdRZ7wgSsNNPNOx6nMnZNWK/7/4xi5HSeL47KRKt5t3icNIlZJmDxle9ACgE kqa39LzthEIWIX0+emUQsjPKd5F7rlxKEXJY2KBNVcV6P1ICGgl6agCsdc7sVWJkPihQ/huba YVcG2yK6+41Dv8N6kz9a5gOOyRJTLBozOHU9EtSdWuFbbF3RnC+noiqEmhuknT0U0BWoD0lps ItLmlLxiZDrklFdUU43Yj/eAAnv7B2JKNDIkAT9EguG/OXJQyGBDEFDLb70eLVB0w7oYUVhp2 tDz6XOQXYx7Y1DA2YNksMlPQAfnAYpwlBdapiYvvigH2pp9xCzqjrYnrW95AKLz2kKSSLd8sD gt+hqXW4jFO3eKrKQgfV+NpI7AhC0NJ2qbfOCVjT2OV2DMvtk0Ytx8Ze166rDx6JGrRm11A18 AT+cuQJnpfqNpEJVSXsAiU1R/PzpPox/mG2qMemNX/Ef+6Os8D7H6YvouVGFj51Kpo6siXZ8m Nf/UzdZWyhugkvTwWgW1HK3FkB52Q7Mw43DRJRp9Z88mPQiX0KSyS3Q/zpO5djlmubkG5UGCs q3CATZGOQeo20PWgabR7L0UkflSaFlbhhDLwykjvYcon54QCYXhfhs74plQ2npYi/JkoVDRnd J3u16dVSh/jqkQ67oszI+9bMB2MnzkeFmPGK4wPh0wIScXdqEbTG3ky3XcfooWL/rhW7whTSw arCJqVg X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: 77718@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On Wed, 18 Jun 2025 01:00:31 +0200 Stephen Berman wrote: > On Tue, 17 Jun 2025 15:26:36 -0400 Spencer Baugh wrote: > >> Stephen Berman writes: >> >>> On Tue, 17 Jun 2025 10:59:56 -0400 Spencer Baugh wrote: > [...] >> This is the behavior of the substring completion style. When there's a >> common substring between all the completions, >> completion-substring-try-completion inserts that substring. Since the >> substring is a common suffix, it positions point before that common >> suffix. > [...] >> To have only "substring" configured as a completion style implies you >> want the behavior of the "substring" completion style, and only that >> behavior. You are indeed getting that behavior. What's the problem? >> substring has always behaved like this, so improved consistency in edge >> cases like this one should not be a surprise. > > You may consider this an edge case, but it is proof that the substring > style has not "always behaved like this". I don't recall that the goal > of "improved consistency in edge cases" was previously cited in this > thread; if it had been, I might have viewed the issue in a different > light, though I still find the current behavior problematic... > >> Is there some problem with this behavior, some reason it doesn't work >> right for you? A more concrete complaint about what doesn't work would >> be helpful. > > ...to wit: > > Before your change, when using substring style, typing `C-x d /us TAB > TAB' completes to "/usr/" and pops up the *Completions* buffer. If I > want to change the input, e.g. to "/var/", I can type `M-DEL va TAB'. > > After your change, when using substring style, typing `C-x d /us TAB > TAB' completes to "/usr//" and only after typing TAB a third time does > the *Completions* buffer pop up. If I want to change the input, typing > `M-DEL' has no effect, though e.g. `C-f / va TAB' works (the minibuffer > then displays "~//usr//var/" with "~//usr/" in file-name-shadow face). > It works, but it's a bit more cumbersome than previously (an extra TAB > to get the *Completions* buffer) and visually confusing (at least given > familiarity with the previous behavior). > > And again, with my patch (posted in > https://lists.gnu.org/archive/html/bug-gnu-emacs/2025-04/msg01860.html) > I get the behavior and appearance I'm used to, and for my usage have > encountered no problems with it. I ask you once again: please tell me > specifically what problems that patch causes. Assuming the current behavior of substring completion in master is not a bug/regression but the intended "improved consistency", I would like to propose a different patch (attached) to make the completion behavior conditional on a user option, defaulting to the current behavior in master. Steve Berman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: substring completion patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index 122459be062..598383e7b51 100644 =2D-- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -4516,6 +4516,14 @@ completion--common-suffix "Return the common suffix of the strings STRS." (nreverse (try-completion "" (mapcar #'reverse strs)))) =20 +(defcustom completion-/-not-common-suffix nil + "If non-nil, ignore \"/\" as common suffix. +With the substring completion style enabled, this prevents displaying +\"/\" as the common substring suffix when all completion candidate end +in \"/\" (that was the only dispay prior to Emacs 31)." + :version "31.1" + :type 'boolean) + (defun completion-pcm--merge-completions (strs pattern) "Extract the commonality in STRS, with the help of PATTERN. PATTERN can contain strings and symbols chosen among `star', `any', `poin= t', @@ -4622,7 +4630,9 @@ completion-pcm--merge-completions (mapcar (lambda (str) (substring str skip= )) comps)))))) (cl-assert (stringp suffix)) - (unless (equal suffix "") + (unless (if completion-/-not-common-suffix + (member suffix '("" "/")) + (equal suffix "")) (push suffix res)))) ;; We pushed these wildcards on RES, so we're done with= them. (setq wildcards nil)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 08:17:57 2025 Received: (at 77718) by debbugs.gnu.org; 18 Jun 2025 12:17:57 +0000 Received: from localhost ([127.0.0.1]:48455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRrjn-0000Vd-HW for submit@debbugs.gnu.org; Wed, 18 Jun 2025 08:17:57 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:40513 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRrjk-0000UF-Jn for 77718@debbugs.gnu.org; Wed, 18 Jun 2025 08:17:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uYSmxkryTuv+C3jdTMqlDoUjqRcgtKJmj9L3e20v9h0=; b=eV8eRM/3tUqnkQt1xmug1n/vcp KfeSVkI6PVkJ3lYierrC+MWUNzy1eBpE9jYLrFKxBXsDhvfbnb98bkiM9xjf0axhL3iJDveXc5IG1 D6Ow+uyWDcUGAz4ZqsRGcQ2vmI4PnyZqdcjjSK4kM7Tuuxxsqd+mPY0QpFJNa3WrqmOk=; From: Daniel Mendler To: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <875xgtdzrh.fsf@gmx.net> References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> <87ldpqm0s0.fsf@gmx.net> <875xgtdzrh.fsf@gmx.net> Date: Wed, 18 Jun 2025 14:17:43 +0200 Message-ID: <87ldppdz14.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , Eli Zaretskii , Stephen Berman , Stefan Monnier , 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > On Wed, 18 Jun 2025 01:00:31 +0200 Stephen Berman wrote: > >> On Tue, 17 Jun 2025 15:26:36 -0400 Spencer Baugh wrote: >> >>> Stephen Berman writes: >>> >>>> On Tue, 17 Jun 2025 10:59:56 -0400 Spencer Baugh wrote: >> [...] >>> This is the behavior of the substring completion style. When there's a >>> common substring between all the completions, >>> completion-substring-try-completion inserts that substring. Since the >>> substring is a common suffix, it positions point before that common >>> suffix. >> [...] >>> To have only "substring" configured as a completion style implies you >>> want the behavior of the "substring" completion style, and only that >>> behavior. You are indeed getting that behavior. What's the problem? >>> substring has always behaved like this, so improved consistency in edge >>> cases like this one should not be a surprise. >> >> You may consider this an edge case, but it is proof that the substring >> style has not "always behaved like this". I don't recall that the goal >> of "improved consistency in edge cases" was previously cited in this >> thread; if it had been, I might have viewed the issue in a different >> light, though I still find the current behavior problematic... >> >>> Is there some problem with this behavior, some reason it doesn't work >>> right for you? A more concrete complaint about what doesn't work would >>> be helpful. >> >> ...to wit: >> >> Before your change, when using substring style, typing `C-x d /us TAB >> TAB' completes to "/usr/" and pops up the *Completions* buffer. If I >> want to change the input, e.g. to "/var/", I can type `M-DEL va TAB'. >> >> After your change, when using substring style, typing `C-x d /us TAB >> TAB' completes to "/usr//" and only after typing TAB a third time does >> the *Completions* buffer pop up. If I want to change the input, typing >> `M-DEL' has no effect, though e.g. `C-f / va TAB' works (the minibuffer >> then displays "~//usr//var/" with "~//usr/" in file-name-shadow face). >> It works, but it's a bit more cumbersome than previously (an extra TAB >> to get the *Completions* buffer) and visually confusing (at least given >> familiarity with the previous behavior). >> >> And again, with my patch (posted in >> https://lists.gnu.org/archive/html/bug-gnu-emacs/2025-04/msg01860.html) >> I get the behavior and appearance I'm used to, and for my usage have >> encountered no problems with it. I ask you once again: please tell me >> specifically what problems that patch causes. > > Assuming the current behavior of substring completion in master is not a > bug/regression but the intended "improved consistency", I would like to > propose a different patch (attached) to make the completion behavior > conditional on a user option, defaulting to the current behavior in > master. Can we please avoid adding absurd user options like `completion-/-not-common-suffix'? The completion machinery is already complex with many options. Adding options for minor details does not seem like a good direction. Daniel From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 16:10:23 2025 Received: (at 77718) by debbugs.gnu.org; 18 Jun 2025 20:10:23 +0000 Received: from localhost ([127.0.0.1]:56176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uRz70-0004d0-I2 for submit@debbugs.gnu.org; Wed, 18 Jun 2025 16:10:22 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:25433) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uRz6x-0004c6-Id for 77718@debbugs.gnu.org; Wed, 18 Jun 2025 16:10:20 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 0C05780962; Wed, 18 Jun 2025 16:10:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1750277412; bh=TAMBcr2hzEOGt2UPhldHlWXI7TB2JBONqAcqZtVf2Lw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BuQ/q1ZuoHxpzp3bVmy3OFp7ZGrFROG5AENHhm1EPmO9B7DAnBd6geTO2tp1Umz0E BEcEnFxVguyrZ8Yc98IxLde6MF9tPNYuwWyTAAj6PkHzfDPyxOOS5ilrDnafeIyIbJ C6F59N1xz3YkfG7mpZPRv0jd19yeVXTM4Ed+Qs/eWNs49NHVtejEunoUuqPenfMDIz X/+1euqXDkpElesjuYgADv2bPE2LTVXe+yE0n2ziehrCEE3rvbryvaoJxrqy2ZJXC0 dkKGbEPOhoDX7wBcztAJ/Eu7ZaySxAE1YvCGl/LPpBUpnxVRt4mHxvnnYqfg5o6/lt s3sdSIpAMo97A== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8C01C80925; Wed, 18 Jun 2025 16:10:12 -0400 (EDT) Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 65392120642; Wed, 18 Jun 2025 16:10:12 -0400 (EDT) From: Stefan Monnier To: Stephen Berman Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: <875xgtdzrh.fsf@gmx.net> Message-ID: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> <87ldpqm0s0.fsf@gmx.net> <875xgtdzrh.fsf@gmx.net> Date: Wed, 18 Jun 2025 16:10:11 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , Eli Zaretskii , 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index 122459be062..598383e7b51 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -4516,6 +4516,14 @@ completion--common-suffix > "Return the common suffix of the strings STRS." > (nreverse (try-completion "" (mapcar #'reverse strs)))) > > +(defcustom completion-/-not-common-suffix nil > + "If non-nil, ignore \"/\" as common suffix. > +With the substring completion style enabled, this prevents displaying > +\"/\" as the common substring suffix when all completion candidate end > +in \"/\" (that was the only dispay prior to Emacs 31)." > + :version "31.1" > + :type 'boolean) Like Daniel, I'd much rather find a solution that doesn't involve a user config. > (defun completion-pcm--merge-completions (strs pattern) > "Extract the commonality in STRS, with the help of PATTERN. > PATTERN can contain strings and symbols chosen among `star', `any', `point', > @@ -4622,7 +4630,9 @@ completion-pcm--merge-completions > (mapcar (lambda (str) (substring str skip)) > comps)))))) > (cl-assert (stringp suffix)) > - (unless (equal suffix "") > + (unless (if completion-/-not-common-suffix > + (member suffix '("" "/")) > + (equal suffix "")) > (push suffix res)))) > ;; We pushed these wildcards on RES, so we're done with them. > (setq wildcards nil)) Comments: - We shouldn't hardcode "/" here, since this code is not specific to file names. IOW we should use the `completion-boundaries` functionality instead to detect if the suffix is equal to the boundary separator. - Maybe we can/should limit this "/" special case to the situation where `prefix` is empty (or where the string before "suffix" also ends in a boundary-separator). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 18 18:40:52 2025 Received: (at 77718) by debbugs.gnu.org; 18 Jun 2025 22:40:52 +0000 Received: from localhost ([127.0.0.1]:57889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uS1Sd-0003sH-T9 for submit@debbugs.gnu.org; Wed, 18 Jun 2025 18:40:52 -0400 Received: from mout.gmx.net ([212.227.17.22]:59191) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uS1Sa-0003rA-70 for 77718@debbugs.gnu.org; Wed, 18 Jun 2025 18:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1750286439; x=1750891239; i=stephen.berman@gmx.net; bh=oOTDAA971rIsyj/nmQVsQxbrG5KJKoKcYDuiP2QYZs8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=pCVPO3AJOggfQoHWogCIE+cVI/5KpiiXKyuHG4wk7T7nHAPS1BNBVZjBKPEnFSYB d5TmPTZ0uSsVfjNt+v9eXeaeucUjU/NXn2+eqVPZ7ATqyivYEpC1rv6Vok0EJeMnd Vlla8Zv+lVxlvWahQmOje3dmxl9hGiwEJydJwIgTJ14JVsvyFJUBY1YJ38MF6tNrs ptcXVZHKYLGh6/cEZT57xORVWExxRPn6x5EaHkE48nlmV32iC0SNLJ3DEP19Kno+9 g1yYk9zk2F8ici6nho0V3S/coDYhhqhnYgiiCSlrCfB1NNTITezYJGgZkqFJRfouB JqHCa0CkulcdK3pepQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.50.166]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MdefJ-1v15IE2IDZ-00jPbz; Thu, 19 Jun 2025 00:40:39 +0200 From: Stephen Berman To: Stefan Monnier Subject: Re: bug#77718: 31.0.50; completion styles substring and flex are broken In-Reply-To: References: <87y0w7ejxy.fsf@gmx.net> <87v7qnp8ww.fsf@gmx.net> <87bjsbquso.fsf@gmx.net> <87o6wbp4h7.fsf@gmx.net> <87cybm2zu9.fsf@gmx.net> <87ecviolhk.fsf@gmx.net> <87zfe6mklr.fsf@gmx.net> <87ldpqm0s0.fsf@gmx.net> <875xgtdzrh.fsf@gmx.net> Date: Thu, 19 Jun 2025 00:40:37 +0200 Message-ID: <87plf0d66y.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:AREerZxbBV5MHLy/bZllsd7VS2xJVxRgJ3OSuNpn8UXWRlYwK4W Lb5t9mdkQ3rufISC4qYbJQDUAkFkIHsceaF4CY2k6k47U+GF2sBD0UpuDtK5k99hqU3SHvl /Us7cMqaG3lFPvforcBbIRq9My4pLAs62VTam4BD79dfNtAOxCJJ/eSJHAbP7Pq1a/SOQrU imsNPRAHqzRq5OL1HKCTQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:gTZJ3vYEac8=;Aa11tWxePSPA+opsiuRXsQYzl7e m5fYCn08mgfYU04Ys/fHQM50q/Xupgo0BteprDWgcmd7r0PRXtDj3198utjQHf/Da7seFeXDX Y9U2AFh8XPlNroSafTItLSRnX4z5rfTEbP+c5WnDWXY8neGj2AdGU+eDc1JNtDTVUctBIksCo b39uzOGflZrDJ7N5dEUOwoo7Iq9M5vES0eD6qtix392OVgaPBc0GqAhKUV6MklMKP/JjUtN82 Iefj+Dq2Lrea9pW/ISVgsH7oeO6LTxTZwVQCoWf8+oZi8AAQuh60IRExNJbehNQO32V6vi2WF nefYL8nNWEgu8vei/Vd1BF/0ojCULlUnruPXVShQOeOO0Kw+g6uxpMYUy14P7Hy5fGOFPb563 dXUzb5V+5zyvqOLX1naLBQUL2GM4IIf6BpcC4gl0cSm+1TfOh6av7kuzQFK2LT1CgLap4uXLT 95IUK6ylFmItk5qECosbbT9KfAKD5I3kImLYvWQsk4xO2Uj8ldricmlFN+Z6WGiAh5ExjgkRW eb8hjGpOVaz2xU4pSa/dXO59yI+0oOtyOP/bYyxdslTeHWQA4TW5KpMdACf8PH5tVMwNsB3wy EQ2sHq5Iej5vv4hk2w+elwrRrQAyT7TxZZAra7yAgrn8nVABEagk69lnk1Xw+iQx6m63MHfyO BasgjBft02AhhmXyBfLz/IE07H2c5SlZtq6YP0+GaR8qT7Q9D/tUIpCG7Zou9CbHPukO9YS6I mdaPkSmiqTpK9/JyUaFXemf03poZm6LusRViXYODJjYPi1lA8hsJqtvPP10zgjglPKvS+k5n/ RCVNSTUodoQ0LbPqcRSUiXK4nLymt4he4HniLy4j1ZudK6yIwU0xH9Jru3wI3zoPhU3vMYm8s fRl/ssFRxg+BXbsBHewSuKUBli6Q57j3nJnhc9zLuUHmmQEmJN491YF2Wr66wscOm83DCvd9r XvJLiTuz3YBwoU5Cc+KuYWMZedz3ZjYCnmpa6W6foKTFuLj+n5tIAyrkMsXFbNcWRtyz4mWXe x0+3NRoEicG74CKEJw2krG7Ke3iaUqI9hOqM4Gveo+5v5/tXni2oHkkpo7Dvpy/py0CAt5OUG DAmXOsswkTcQq4vxU+OqzYfMY07x2W41Bwg6lAaSnTgtjIvIyNHkNQ30UhpKFs57l0wOBpJg/ MQuKoc6ZU+1hUFG+UjECJCzbWr5GyNZ8FvR/P0kzr/2AViyplkNA38XEDDZuqJ6dwHgEt9XQo JY5voZD+2onQ5Anxw9O26JVzqdpqzRW+lU2HCtAw9jQgICBERFGv3jmAyQOxJvCSgPtVxuuOn vpWPh6Xz1ueAcMiCqN+MWqHjEUo2SQs1VMqe4tldNfh9PoCy/BNsa/Deab/Q4JOfEh6ueVQZe TkbfV8HGpioo2Cm3fBTu/LgP1TXwqGxiIgsKaVSNqrIzmLaOpiNXbJA7xJyAlLRnNqQcX5th0 NQZCYZkQYhPWPHX//xySHytVs97ys1sTifepyYKx3DKOXRJvuQJdbKeqV6ayR55J5tR/WBJHR UPMIqr+lOgt8WiXkVHz5R5fM/ecPYTg3E2cwLQG66ErYC1tZrmlc5YXh87dlOo7Zzv51Aapse 9iQ9B+cjbuYIzjIchh/GU/BJTggRYtKwl0fTusfqe3uY+s3/KosgydAWPlORpbFLdRvQV9Sd/ eEqPF+PpmRCg+4prBbZi5dOHl6LO9pxLny9V2BcepYhQuaYCTBnRqJyNdEYmOZEun/KLPyqbN WqvPXaYmHdVYW9jOIpDPg5PVybE51ttl0/9vdZ7rvQCw0ph4SfFA9W29g17rmmK8vAlyKttzA ycMEtReWt1TOJ1TnsB7qFQOmK+IZn58ZtRChl37VCpvvhlYUwbiF48iwEUOJ8JR+ZTVKtIegy XkIxO8bw2hB8DN73NsR43na6K/F10jCGH/q1LrdIMUiahcKy1D+UDC1BkvO/aTPhsvAZDcTVv Z1TZkZsxKE/5peddBc+agp7wz7czY2WnsGJGozDpiQYNVXq6Y0oR+8gX6MRH+m25gvPDpVBEo TTvILQKRynRdTVPd7ehJvnmM+cOHqXQ3xUjeEegXGt2eN9dHVa6TOlqXEthB81jgISyomP6kh 65SGuA/xEg2eD2hPAxWhxB7k3TBhiiP5CUhS2ZnWaZns/ZflB0vHNvZ8+WOCToKf8pIGVnsJb r5QBaoBfXdvZF6Tz7AABm8nCjyOiN+IJ5gGfFRwDYpnYq2C5DJzCK1FElLGddEVMegRZtYdGe Fnmayj52KwNx5cddxc1UkE4ZWGHq1KI1/j6anySuSgiuZE8tV0E/2rxP78WqUnk+gkIw9LXA7 HUXlhqfGXBzE54K+kwGZaUDkAaTBsGxhBiuma8QfAXOgVVjvNbfcZxXAcwtzd9+xp/qOoFfSX Q6qIXGpA1oe81zL4kjmKWTprXAO9Hqv0zvYxlaFFgBBZVny7OhwnGgUyA/AVEP+Q/iE/PKKFt IBtcSBKyUoMByDl1wRjIuvxXRYzos5EcKpGAw8+r8rbstw5YdFOs5oDK0A8zhLl5QG0xA6jBf +QJoGbP/dFL54vadslXDAU2ZvI9efB1LCHe8i23/4iTOM7L+WU2uiP43sWWcz9KGBxYEo4aIn r4Lv2yzfVCS5ZnPo9VfIp2dXfutW/ddm85X7a0scLhmUenzloSu2m+z9bBTVOxtLcDcZGaRHa ISAR/LdchuT8esyJUASNMLnJMjhWfMeM1vqMH9W3iy0GzNutLvGN7mT97PZXK8Y8DrMp0Iztr rh2euSTpc+Q4yZK1Obd4EY3XCqicpRPzvI7UncvPYfj0r5d1rbcy9bbEBM7myPGCI4YS4Vpt4 JbIgSmF/cuxQV+5ktY21WLp5P6Dm/U0tCweEgddFD/5qPU8Cz0wh1cJzm725wAx5seHJdyfL7 I+awI+hsY34TFGrM01kZ5utKnpMtDTEdngEbv1v3/UaCT05mSfigPNwfbzznDx04asK6wc0VQ IlXxCIKVb+C8ANf3uU9nMpVf7oJElenZiic3NFUZgfdwBUr6xi6P02Kxds1RcmCl64pT1K572 iYpbvqr5fy5oKnECNHDbkJr6tSjGmlG2yUmXLgupXSCMPpvdWV84Rl2IPyHeo5BoC/yH+suGR WRnU1QH1p6cy8rdonIpnjb9yzCVNd610QMaYPfX+4MoqZKODhfxrOvHz5IquO5UdyMnH391fI 89GVNiF+a8B/fsymJ4BwFAw4f/iqHoFXkxmFevMMwaBHao6Xi4BPjdBS4xf8mhQzufiFFjsQ5 5Hytk7bnLQpOjoCv/GErc9/fXIcRyKIw6/AdBA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77718 Cc: Spencer Baugh , Eli Zaretskii , 77718@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 18 Jun 2025 16:10:11 -0400 Stefan Monnier wrote: >> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el >> index 122459be062..598383e7b51 100644 >> --- a/lisp/minibuffer.el >> +++ b/lisp/minibuffer.el >> @@ -4516,6 +4516,14 @@ completion--common-suffix >> "Return the common suffix of the strings STRS." >> (nreverse (try-completion "" (mapcar #'reverse strs)))) >> =20 >> +(defcustom completion-/-not-common-suffix nil >> + "If non-nil, ignore \"/\" as common suffix. >> +With the substring completion style enabled, this prevents displaying >> +\"/\" as the common substring suffix when all completion candidate end >> +in \"/\" (that was the only dispay prior to Emacs 31)." >> + :version "31.1" >> + :type 'boolean) > > Like Daniel, I'd much rather find a solution that doesn't involve > a user config. > >> (defun completion-pcm--merge-completions (strs pattern) >> "Extract the commonality in STRS, with the help of PATTERN. >> PATTERN can contain strings and symbols chosen among `star', `any', `p= oint', >> @@ -4622,7 +4630,9 @@ completion-pcm--merge-completions >> (mapcar (lambda (str) (substring str s= kip)) >> comps)))))) >> (cl-assert (stringp suffix)) >> - (unless (equal suffix "") >> + (unless (if completion-/-not-common-suffix >> + (member suffix '("" "/")) >> + (equal suffix "")) >> (push suffix res)))) >> ;; We pushed these wildcards on RES, so we're done w= ith them. >> (setq wildcards nil)) > > Comments: > > - We shouldn't hardcode "/" here, since this code is not specific to > file names. IOW we should use the `completion-boundaries` > functionality instead to detect if the suffix is equal to the > boundary separator. > - Maybe we can/should limit this "/" special case to the situation where > `prefix` is empty (or where the string before "suffix" also ends in > a boundary-separator). Thanks for the constructive feedback. I can try and see if I can implement your suggestions, but it would probably take me some time, if I succeed at all, since I have little familiarity with the completion code, so I hope you or someone else who knows the code well is interested enough to do this. Steve Berman