GNU bug report logs - #77717
[PATCH] Add row-properties to 'vtable'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stéphane Marks <shipmints <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77717: closed ([PATCH] Add row-properties to 'vtable')
Date: Thu, 19 Jun 2025 20:20:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 19 Jun 2025 16:19:18 -0400
with message-id <CAN+1Hbr5uMN+wKeedXSWXWFVD1rx1j+2UN5=AR0HiMGQomQkcg <at> mail.gmail.com>
and subject line Re: bug#77717: [PATCH] Add row-properties to 'vtable'
has caused the debbugs.gnu.org bug report #77717,
regarding [PATCH] Add row-properties to 'vtable'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77717: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77717
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ship Mints <shipmints <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add row-properties to 'vtable'
Date: Thu, 10 Apr 2025 18:10:11 -0400

[Message part 3 (text/plain, inline)]

This is useful for adding 'cursor-face or 'mouse-face to each row.  I've
been advising 'vtable--insert-line' with an after advice.  This is better.

Example:

          (make-vtable
           :columns
           '(( :name "Foo"
               :primary ascending
               ))
           :allow-other-keys t ; backward compatibility for :row-properties
           :row-properties '( mouse-face highlight
                              cursor-face region)

-Stephane

[Message part 4 (text/html, inline)]

[0001-Add-row-properties-to-vtable.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stéphane Marks <shipmints <at> gmail.com>
To: 77717 <at> debbugs.gnu.org, 77717-done <at> debbugs.gnu.org
Subject: Re: bug#77717: [PATCH] Add row-properties to 'vtable'
Date: Thu, 19 Jun 2025 16:19:18 -0400

[Message part 7 (text/plain, inline)]

Closing. Superseded by a forthcoming bug.

On Mon, Apr 21, 2025 at 4:19 PM Ship Mints <shipmints <at> gmail.com> wrote:

> On Sat, Apr 12, 2025 at 8:44 AM Ship Mints <shipmints <at> gmail.com> wrote:
>
>> On Sat, Apr 12, 2025 at 7:51 AM Ship Mints <shipmints <at> gmail.com> wrote:
>>
>>> On Fri, Apr 11, 2025 at 4:02 PM Ship Mints <shipmints <at> gmail.com> wrote:
>>>
>>>> On Thu, Apr 10, 2025 at 6:11 PM Ship Mints <shipmints <at> gmail.com> wrote:
>>>>
>>>>> This is useful for adding 'cursor-face or 'mouse-face to each row.
>>>>> I've been advising 'vtable--insert-line' with an after advice.  This is
>>>>> better.
>>>>>
>>>>> Example:
>>>>>
>>>>>           (make-vtable
>>>>>            :columns
>>>>>            '(( :name "Foo"
>>>>>                :primary ascending
>>>>>                ))
>>>>>            :allow-other-keys t ; backward compatibility for
>>>>> :row-properties
>>>>>            :row-properties '( mouse-face highlight
>>>>>                               cursor-face region)
>>>>>
>>>>
>>>> Revised patch attached with the bug number and with 'keymap now applied
>>>> to the whole row vs. just the row text.  This ensures that keys (e.g., "q"
>>>> to quit) operate correctly if point is at the newline.
>>>>
>>>
>>> While I have vtable cracked open, this revised patch now includes
>>> unsort.  vtable is nice.  Now, a bit nicer.
>>>
>>
>> Now with a complete sentence in 'vtable-unsort' docstring.
>>
>
> I've expanded the scope of this bug to include additional enhancements,
> all intended to be backwardly compatible, yet provide some very nice
> customization features.
>
> The biggest issues I wanted to address were that display-line-numbers was
> not correctly supported when using the header-line, and that
> text-scale-mode did not work well.
>
> Along the way, I added custom faces for the header, column names,
> column-width computation optionally includes column name width, an unsort
> command, skipping the divider on the last column (this one was an outright
> bug), an option to make the divider intangible, an option to not produce
> dividers on the header, customizable sort indicators and faces.
>
> As test jigs, I've been using some code I wrote for tab-bar that presents
> all open tabs from across all frames and in a useful way for frame/tab
> switching (discussed in a few open bugs with Juri), and a project-list tool
> (discussed in an open bug with Dmitry).  vtable is great for these use
> cases.  I will share those for feedback after the vtable work.
>
> I have a couple more minor vtable things to do, and I figured if anyone is
> interested in vtable as the wonderful addition to Emacs it is (thanks
> Lars!), I wanted to share the work in process for feedback.  I will update
> the documentation and I might go through flymake noise and add docstrings
> while I'm at it.
>
> Patch attached.
>
> -Stephane
>

[Message part 8 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.