GNU bug report logs - #77715
[PATCH] Add ring-bell functions for mode line and header line.

Previous Next

Full log

Message #86 received at 77715 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: eg642616 <at> gmail.com, 77715 <at> debbugs.gnu.org, drew.adams <at> oracle.com
Subject: Re: bug#77715: [PATCH] Add ring-bell functions for mode line and
 header line.
Date: Wed, 30 Apr 2025 10:09:36 -0400

[Message part 1 (text/plain, inline)]

On Wed, Apr 30, 2025 at 10:06 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Wed, 30 Apr 2025 09:52:44 -0400
> > Cc: eg642616 <at> gmail.com, 77715 <at> debbugs.gnu.org, drew.adams <at> oracle.com
> >
> > On Wed, Apr 30, 2025 at 9:41 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >  > From: Ship Mints <shipmints <at> gmail.com>
> >  > Date: Wed, 30 Apr 2025 09:10:05 -0400
> >  > Cc: Eli Zaretskii <eliz <at> gnu.org>, 77715 <at> debbugs.gnu.org,
> drew.adams <at> oracle.com
> >  >
> >  > Face flashing isn't a feature of bell ringing, it's the opposite.
> >
> >  ??? Then why is ring-bell-functions being mentioned?
> >
> >  > I'd consider putting the face flashing code with
> >  > face-related code so it's clear faces can be flashed anywhere for any
> reason the users want.
> >
> >  But this code is not general enough for that.  It was written
> >  explicitly for additional optional values for ring-bell-functions, as
> >  the doc strings say.
> >
> > The prototype was derived from private code used in this narrow case but
> if we're going to adopt the
> > functionality in core, I think we go the extra mile to make it
> appropriately general.
>
> But then the entire implementation should be revisited and reviewed
> with that generality in mind.  So please let's talk about that.  Could
> you or someone else please describe what general features are meant to
> be implemented based on this functionality?
>

I think of face flashing as the face equivalent to '
pulse-momentary-highlight-region'.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.