GNU bug report logs - #77715
[PATCH] Add ring-bell functions for mode line and header line.

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 77715 <at> debbugs.gnu.org, shipmints <at> gmail.com, drew.adams <at> oracle.com
Subject: bug#77715: [PATCH] Add ring-bell functions for mode line and header line.
Date: Sat, 10 May 2025 13:01:07 +0300

> From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
> Cc: 77715 <at> debbugs.gnu.org,  shipmints <at> gmail.com,  drew.adams <at> oracle.com
> Date: Tue, 29 Apr 2025 18:07:06 -0600

Thanks, a few comments related to English grammar and wording in the
documentation part of this patch:

> +---
> +*** New function 'flash-face-bell-function'.
> +This function flash a face briefly.
                 ^^^^^
"flashes"

> +Intended to be used in 'ring-bell-function'.
   ^^^^^^^^
"It is intended"

> +---
> +*** New function 'flash-echo-area-bell-function'.
> +This function flash current echo area briefly.
> +Intended to be used in 'ring-bell-function'.

Same here.

> +---
> +*** New user option 'flash-face-duration'.
> +This option controls flash duration for 'flash-face-bell-function' and
                        ^^^^^^^^^^^^^^
"the flash duration"

> +*** New user option 'flash-face-attributes'
> +This option tells 'flash-face-bell-function' and
> +'flash-echo-area-bell-function' which face attributes should use
> +for flash.                                            ^^^^^^^^^^

"should be used"

> +This is intended to be used in any function from `ring-bell-fns' such as
> +`flash-face-bell-function' and `flash-echo-area-bell-function' for make
> +the flash face more noticeable."                               ^^^^^^^^

"to make"

> +(defun flash-echo-area-bell-function ()
> +  "Flash echo area as ring a bell.

Suggest to rephrase:

  "Indicate ringing the bell by flashing the echo area."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.