Subject: bug#77715: [PATCH] Add ring-bell functions for mode line and header line.

From: Eli Zaretskii <[email-masked]>
Date: Sat, 10 May 2025 13:01:07 +0300

> From: Elijah Gabe Pérez <[email-masked]>
> Cc: [email-masked],  [email-masked],  [email-masked]
> Date: Tue, 29 Apr 2025 18:07:06 -0600

Thanks, a few comments related to English grammar and wording in the
documentation part of this patch:

> +---
> +*** New function 'flash-face-bell-function'.
> +This function flash a face briefly.
                 ^^^^^
"flashes"

> +Intended to be used in 'ring-bell-function'.
   ^^^^^^^^
"It is intended"

> +---
> +*** New function 'flash-echo-area-bell-function'.
> +This function flash current echo area briefly.
> +Intended to be used in 'ring-bell-function'.

Same here.

> +---
> +*** New user option 'flash-face-duration'.
> +This option controls flash duration for 'flash-face-bell-function' and
                        ^^^^^^^^^^^^^^
"the flash duration"

> +*** New user option 'flash-face-attributes'
> +This option tells 'flash-face-bell-function' and
> +'flash-echo-area-bell-function' which face attributes should use
> +for flash.                                            ^^^^^^^^^^

"should be used"

> +This is intended to be used in any function from `ring-bell-fns' such as
> +`flash-face-bell-function' and `flash-echo-area-bell-function' for make
> +the flash face more noticeable."                               ^^^^^^^^

"to make"

> +(defun flash-echo-area-bell-function ()
> +  "Flash echo area as ring a bell.

Suggest to rephrase:

  "Indicate ringing the bell by flashing the echo area."