GNU bug report logs - #77680
[PATCH 0/4] Avoid 'fdatasync' calls for cache files

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/4] Avoid 'fdatasync' calls for cache files
Date: Wed,  9 Apr 2025 16:21:27 +0200

Hello,

As Chris found out, calling ‘fdatasync’ for each and every narinfo
cache file created by ‘guix substitute’ (and likewise for other caches)
is too expensive and pointless.  This patch series fixes that.

Thoughts?

Ludo’.

Ludovic Courtès (4):
  cache: Remove unused import.
  utils: Add #:sync? parameter to ‘with-atomic-file-output’.
  substitutes: Ignore corrupt cached narinfos.
  guix: Avoid ‘fdatasync’ call for caches and regular files.

 guix/cache.scm            |  1 -
 guix/git-authenticate.scm |  5 +++--
 guix/http-client.scm      |  5 +++--
 guix/scripts/discover.scm |  3 ++-
 guix/scripts/style.scm    |  5 +++--
 guix/substitutes.scm      |  8 +++++---
 guix/utils.scm            | 14 ++++++++++----
 7 files changed, 26 insertions(+), 15 deletions(-)


base-commit: c88f98bb3ca2616baea6b1e452cc900cc9c87503
-- 
2.49.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.