GNU bug report logs - #77663
[PATCH 1/3] gnu: Add python-configshell-fb.

Previous Next

To reply to this bug, email your comments to 77663 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Grigory Shepelev <shegeley <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Grigory Shepelev <shegeley <at> gmail.com>
Subject: [PATCH 1/3] gnu: Add python-configshell-fb.
Date: Wed,  9 Apr 2025 09:35:48 +0300

---
 gnu/packages/python-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index dd5648a9d5..5351b1fdc9 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16849,6 +16849,31 @@ (define-public python-cram
 output.")
     (license license:gpl2+)))
 
+(define-public python-configshell-fb
+  (package
+    (name "python-configshell-fb")
+    (version "1.1.30")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "configshell-fb" version))
+       (snippet #~(begin
+                    (use-modules (guix build utils))
+                    (delete-file "setup.py")
+                    (delete-file-recursively "configshell_fb")
+                    (rename-file "configshell" "configshell_fb")))
+       (sha256
+        (base32 "1zkhf62qsfcbxwzlc62r6qx37wwyscppc469rlm45zy9lzmbgxj1"))))
+    (arguments (list #:tests? #f))
+    (build-system pyproject-build-system)
+    (propagated-inputs (list python-pyparsing))
+    (native-inputs (list python-wheel python-setuptools python-hatch-vcs python-hatchling))
+    (home-page "https://github.com/open-iscsi/configshell-fb")
+    (synopsis "A framework to implement simple but nice CLIs.")
+    (description
+     "This package provides a framework to implement simple but nice CLIs.")
+    (license license:asl2.0)))
+
 (define-public python-crccheck
   (package
     (name "python-crccheck")
-- 
2.48.1

Message #8 received at 77663 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77663 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add python-configshell-fb.
Date: Sun, 13 Apr 2025 22:04:45 +0100

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch.

Some review points as the patch does not look nice for me ;-)

--8<---------------cut here---------------start------------->8---
+       (snippet #~(begin
+                    (use-modules (guix build utils))
+                    (delete-file "setup.py")
+                    (delete-file-recursively "configshell_fb")
+                    (rename-file "configshell" "configshell_fb")))
--8<---------------cut here---------------end--------------->8---
May you explain the reason behind this snippet?

--8<---------------cut here---------------start------------->8---
+    (arguments (list #:tests? #f))
+    (build-system pyproject-build-system)
--8<---------------cut here---------------end--------------->8---
Please follow example for some other packages in the module e.g.
build-system comes first then arguments, then inputs etc.
Why no tests?

--8<---------------cut here---------------start------------->8---
+    (propagated-inputs (list python-pyparsing))
+    (native-inputs (list python-wheel python-setuptools python-hatch-vcs python-hatchling))
--8<---------------cut here---------------end--------------->8---
Please apply list stile and sort alphabetically, some nice touch.

--8<---------------cut here---------------start------------->8---
+    (synopsis "A framework to implement simple but nice CLIs.")
--8<---------------cut here---------------end--------------->8---
No article in the begining (check with "guix lint") and no "." in the
end.

--8<---------------cut here---------------start------------->8---
+    (description
+     "This package provides a framework to implement simple but nice CLIs.")
--8<---------------cut here---------------end--------------->8---
"simple but nice" sound like a selling point but having n+ similar
packages available in Buix it's not clear, please try to extract info from
README or describe functionality more precise.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 77663-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77663-done <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: Add python-configshell-fb. 
Date: Sun, 27 Jul 2025 14:34:05 +0100

[Message part 1 (text/plain, inline)]

Hi,

Pushed as c245020b541dfcf8a190b72816431589690d8f44 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.