GNU bug report logs - #77649
[PATCH] Add support for updating *Completions* as you type

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: sbaugh <at> catern.com, 77649 <at> debbugs.gnu.org, mail <at> daniel-mendler.de, juri <at> linkov.net
Subject: bug#77649: [PATCH] Add support for updating *Completions* as you type
Date: Sat, 26 Jul 2025 12:42:02 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: sbaugh <at> catern.com,  77649 <at> debbugs.gnu.org,  juri <at> linkov.net,
>    mail <at> daniel-mendler.de
> Date: Tue, 22 Jul 2025 15:27:53 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> From: Spencer Baugh <sbaugh <at> janestreet.com>
> >> Cc: sbaugh <at> catern.com,  77649 <at> debbugs.gnu.org,  mail <at> daniel-mendler.de,
> >>    juri <at> linkov.net
> >> Date: Tue, 22 Jul 2025 12:32:18 -0400
> >> 
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> 
> >> >> Cc: sbaugh <at> catern.com, 77649 <at> debbugs.gnu.org,
> >> >>  Daniel Mendler <mail <at> daniel-mendler.de>
> >> >> Date: Mon, 21 Jul 2025 12:43:56 -0400
> >> >> From:  Spencer Baugh via "Bug reports for GNU Emacs,
> >> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> >> 
> >> >> +*** New user option 'completion-eager-update.
> >> >                                                ^
> >> > Closing quote missing there.
> >> >
> >> >> +This option configures whether typing should update the contents of the
> >> >                ^^^^^^^^^^
> >> > We normally use "controls".
> >> >
> >> >> +"*Completions*" buffer, if it is shown.  When the option is set to t,
> >> >> +typing will always update the "*Completions*" buffer.  Note that for
> >> >> +large or inefficient completion tables, this can slow down typing.  The
> >> >> +default setting enables eager updating only if requested by the command.
> >> >> +For more fine-grained control you can also toggle this feature by
> >> >> +category using the symbol 'eager-update in the user option
> >> >> +'completion-category-overrides'.
> >> >
> >> > IMO, the last two sentences are too vague/mysterious to be useful
> >> > (this is a user option, remember?)
> >> 
> >> These two sentences are just copied (with a minor change) from the
> >> announcement for the very similar option completion-eager-display, just
> >> above.  Should I reword that one as well in this commit?
> >
> > If you wish, yes.
> 
> Updated and fixed your feedback.

Thanks.

> +*** Support for immediate display of the "*Completions*" buffer
> +Whenever a minibuffer with completion is opened, the "*Completions*"
> +buffer will now be displayed immediately if the completion property
> +'eager-display', set by the completion table, is non-nil.  This property
> +can be overridden for different completion categories by customizing
> +'completion-category-overrides'.  Alternatively, the new user option
> +'completion-eager-display' can be set to t to force eager display of
> +"*Completions*" for all minibuffers, or nil to suppress this for all
> +minibuffers.
> +
> ++++
> +*** Support for updating "*Completions*" as you type
> +If the "*Completions*" buffer is displayed, it will now be updated as
> +you type if the completion property 'eager-update', set by the
> +completion table, is non-nil.  This property can be overridden for
> +different completion categories by customizing
> +'completion-category-overrides'.  Alternatively, the new user option
> +'completion-eager-update can be set to t to make "*Completions*" always
> +be updated as you type, or nil to suppress this always.  Note that for
> +large or inefficient completion tables this can slow down typing.

The two heading lines still don't end in a period.

No further comments, once those nits are fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.