GNU bug report logs - #77649
[PATCH] Add support for updating *Completions* as you type

Previous Next

Full log

View this message in rfc822 format

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: sbaugh <at> catern.com, 77649 <at> debbugs.gnu.org, juri <at> linkov.net, mail <at> daniel-mendler.de
Subject: bug#77649: [PATCH] Add support for updating *Completions* as you type
Date: Tue, 22 Jul 2025 12:32:18 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: sbaugh <at> catern.com, 77649 <at> debbugs.gnu.org,
>>  Daniel Mendler <mail <at> daniel-mendler.de>
>> Date: Mon, 21 Jul 2025 12:43:56 -0400
>> From:  Spencer Baugh via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> +*** New user option 'completion-eager-update.
>                                                ^
> Closing quote missing there.
>
>> +This option configures whether typing should update the contents of the
>                ^^^^^^^^^^
> We normally use "controls".
>
>> +"*Completions*" buffer, if it is shown.  When the option is set to t,
>> +typing will always update the "*Completions*" buffer.  Note that for
>> +large or inefficient completion tables, this can slow down typing.  The
>> +default setting enables eager updating only if requested by the command.
>> +For more fine-grained control you can also toggle this feature by
>> +category using the symbol 'eager-update in the user option
>> +'completion-category-overrides'.
>
> IMO, the last two sentences are too vague/mysterious to be useful
> (this is a user option, remember?)

These two sentences are just copied (with a minor change) from the
announcement for the very similar option completion-eager-display, just
above.  Should I reword that one as well in this commit?

>> +If `auto', only update if the completion table has requested it or
>> +`eager-update' is set in in `completion-category-defaults'.
>
> This should at least hint how would a completion table request the
> update, or mention some function or variable whose doc string explains
> that.
>
> The doc string should also describe what happens when the value is nil.
>
>> +  :type '(choice (const :tag "Do nothing when you type" nil)
>
> "Do nothing" is incorrect.  I think you mean "Do not update
> completions" or somesuch.
>
> Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.