From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 02:43:56 2025 Received: (at submit) by debbugs.gnu.org; 8 Apr 2025 06:43:56 +0000 Received: from localhost ([127.0.0.1]:58504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u22ge-00050i-4x for submit@debbugs.gnu.org; Tue, 08 Apr 2025 02:43:56 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58646) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u22ga-00050B-PJ for submit@debbugs.gnu.org; Tue, 08 Apr 2025 02:43:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u22gV-0000wa-Dt for guix-patches@gnu.org; Tue, 08 Apr 2025 02:43:47 -0400 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u22gT-0005aC-Ic for guix-patches@gnu.org; Tue, 08 Apr 2025 02:43:47 -0400 Received: by mail-lj1-x243.google.com with SMTP id 38308e7fff4ca-30c44a87b9cso41639321fa.3 for ; Mon, 07 Apr 2025 23:43:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744094622; x=1744699422; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zpAA4jnYEYy8l2RHUFCKvDKE3h5r8H222eKXgrgTjBg=; b=UtUvPxUpsmOYyLuo5BkYbPAKLdS/qkQ3FzRVn/HQ+745XuDb54dfGO5oEVkkX4XlXL ePP6iEbptosZKswifhZ98D5oX/xxUCw6jcxt32iDYEoJ4w+F7o82qPJNXH/hZ9dWhYWb x234GzqD3cnj6RgOQVNOqJGiBYms18SwqrM6qqEt8JZ79LF0WUkE+WKsM3VDq3hq2xdm DsuwKSojEjz4gYGvmu7FqseuWXfkKcHaqMFKT3GbmwdU4rMNmUWtcPz258VljVdHPF4Y heMAgluOqUjnRBarVEzSU+KW6w/V6yTkrMvxXNns7RovbqNzNc0D8ieFcktMroCH/i6C Vj1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744094622; x=1744699422; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zpAA4jnYEYy8l2RHUFCKvDKE3h5r8H222eKXgrgTjBg=; b=RSZnVULqOnlmZf6EA0KSA1Rop+xsbXVYdUzNsX9A8++4tzOL+WrIRcTGP1/v/QTYfF kohbef6oaj51cOA9KjkpL9msr5R74jd6eauqsbCR46cUtqPIWhwW1hlog5qWi0S4VmsW bGX5iTyM+4GDgEU3zPEc6mSrY7dNXI4SAXaFI/zt0mnO5H7vp4NJ3bHIVzZt9JaOOk+h c3abGZbHxlh7L5Q81axZxvBqEazXCsMuIiHtxPHOaRt3UgVxWAow7XwCStPNqhM39Kh7 RPkh34sd3YbX8O+A3qrb31C+TqQYX8obxI8XKzaSj0JY0ME8dqKWhFyfc0elZ57JIgtZ DKbw== X-Gm-Message-State: AOJu0YxGzjAiz/1KCm98SMYZIwKzv2rhgDzlBkX9qaQlFeTCD/7Jm0XB VVNPlC0E8C5jxEKRwFubLSH+en71i6ZlTW4Ab7ao3iFV5wT+4AdzNwcKkj7h X-Gm-Gg: ASbGnctCseHGiT2YwSBHggD8jQaJt12fd2jGzS2uoZCm9ru/l2qi2QOYQNNpvxwU+28 46lg3J46NbKQl4TUJ8lcyiXphhh/QToAmNcu/Kch2wNJMxYnr9UDIre/vet1ei5kjvkCVdqXkcW 4x5HwnlZL4tlEit9bwREDSXv2dkgVq3VlME8mkqemhPlqoHIAolaNQlrXnTNyb2dg5HE9YCs9B5 JSV8hvSzcq0h5/wwuoKcS//G7xRqJujZnOLmdtqqKe8ZaUUb1TJguuSLJ3jmu7GTy98owoi7jAH ZAPBuSt3FIaG58LFqEgaBDcZo0XRQFau+Vi4j060gYKvOW1A0u3vaDsU2ujhiw== X-Google-Smtp-Source: AGHT+IFhxq7ig1GWuJ7DevAkJeAmQ1F+Grl/2Rspng2b/zZtu2XDrqr1T+YNeMi8GFxBLBNOZylHeQ== X-Received: by 2002:a05:651c:1465:b0:30c:aae:6d4e with SMTP id 38308e7fff4ca-30f0bf4fb8amr49458091fa.23.1744094622187; Mon, 07 Apr 2025 23:43:42 -0700 (PDT) Received: from localhost.localdomain ([188.68.137.215]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30f031ce924sm17787401fa.106.2025.04.07.23.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 23:43:41 -0700 (PDT) From: Nigko Yerden To: guix-patches@gnu.org Subject: [PATCH] services: tlp: Make destructor return #f on success. Date: Tue, 8 Apr 2025 11:30:24 +0500 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::243; envelope-from=nigko.yerden@gmail.com; helo=mail-lj1-x243.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Nigko Yerden X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * gnu/services/pm.scm (tlp-shepherd-service): Make destructor return #f on success. Destructor "should return #f if it is now possible again to start the service at a later point" (shepherd manual). Change-Id: Ic0d21d32af158da1ae940d9c32c05a3471767764 --- Without this patch tlp service brings annoying messages "Service tlp might have failed to stop" to the system log. Thanks to lfam and Rutherther on IRC for mentioning in relation to other service that the destructor of a shepherd service should return #f on success. gnu/services/pm.scm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/gnu/services/pm.scm b/gnu/services/pm.scm index e022437748..12f05b4b33 100644 --- a/gnu/services/pm.scm +++ b/gnu/services/pm.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2017 Mathieu Othacehe ;;; Copyright © 2024 Dariqq ;;; Copyright © 2024 Ian Eure +;;; Copyright © 2025 Nigko Yerden ;;; ;;; This file is part of GNU Guix. ;;; @@ -459,15 +460,17 @@ (define-configuration tlp-configuration (define (tlp-shepherd-service config) (let* ((tlp-bin (file-append (tlp-configuration-tlp config) "/sbin/tlp")) - (tlp-action (lambda args + (tlp-action (lambda (return-value-on-success . args) #~(lambda _ - (zero? (system* #$tlp-bin #$@args)))))) + (if (zero? (system* #$tlp-bin #$@args)) + #$return-value-on-success + (not #$return-value-on-success)))))) (list (shepherd-service (documentation "Run TLP script.") (provision '(tlp)) (requirement '(user-processes)) - (start (tlp-action "init" "start")) - (stop (tlp-action "init" "stop")))))) + (start (tlp-action #t "init" "start")) + (stop (tlp-action #f "init" "stop")))))) (define (tlp-activation config) (let* ((config-str (with-output-to-string base-commit: c9524b5841a057b5e64abf0dca75261e741949c5 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 11:29:22 2025 Received: (at 77629-done) by debbugs.gnu.org; 8 Apr 2025 15:29:22 +0000 Received: from localhost ([127.0.0.1]:34744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2At7-0008Cr-UO for submit@debbugs.gnu.org; Tue, 08 Apr 2025 11:29:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38062) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2At5-0008C9-Ot for 77629-done@debbugs.gnu.org; Tue, 08 Apr 2025 11:29:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2At0-0001q6-B8; Tue, 08 Apr 2025 11:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7AH1lBNt4zIA84p/Ng8f4lixjB6x+DWp8d4hufhVJhM=; b=NdPUYbFHM0r8T5reqRaI ygrYer00lOf5riVyvkxjCRPa1yVL7VGMlNa2tsDZgAN+NrM+XvAfkhhntrS5xuAFbNnSGK/wxqPnp aKbk0FSVCJHzoldECrsQjhADK91YAuQAiFaKfou3JlKWDpTZI8AHwanXmkGJJqoqh2DzPep35jKl4 1/Ne4M254aigs9ENqvoVg5rnfX2+15zdqS8ZR72GsRYw9msKmZOGbqcwg2ycMezX0kN0jkkZ2LkFp eIZYXz7kRwxkmdzjS8vikISj50t6JFBmNTsujvTVthCjVFo2RAxY2UvPfMr3pp8dsRMyhhcsPcXJF Fy5HOXDlIdAo6g==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Nigko Yerden Subject: Re: [bug#77629] [PATCH] services: tlp: Make destructor return #f on success. In-Reply-To: (Nigko Yerden's message of "Tue, 8 Apr 2025 11:30:24 +0500") References: Date: Tue, 08 Apr 2025 17:07:07 +0200 Message-ID: <874iyy66as.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77629-done Cc: 77629-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Nigko Yerden skribis: > * gnu/services/pm.scm (tlp-shepherd-service): Make destructor > return #f on success. Destructor "should return #f if it is > now possible again to start the service at a later point" > (shepherd manual). > > Change-Id: Ic0d21d32af158da1ae940d9c32c05a3471767764 Applied, thanks! From unknown Thu Aug 14 21:45:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 May 2025 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator