GNU bug report logs - #77600
[PATCH] import/pypi: Improve renaming procedure.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77600 in the body.
You can then email your comments to 77600 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] import/pypi: Improve renaming procedure.
Date: Mon,  7 Apr 2025 16:20:29 +0900

A package named upstream like 'tmdb-python' now gets named 'python-tmdb'
instead of 'python-tmdb-python', which is ugly and doesn't match our
convention (info "(guix) Python Modules").

* guix/import/pypi.scm (python->package-name): Turn a -python suffix into a
python- prefix.

Change-Id: I7c0227d569c0afe6b16329d7cedb51728e4365b0
---
 guix/import/pypi.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index dd43ebdcf3..5e2c6ec9ff 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -179,6 +179,8 @@ (define (python->package-name name)
 package."
   (cond
    ((string-prefix? "python-" name) (snake-case name))
+   ((string-suffix? "-python" name)
+    (string-append "python-" (string-drop-right name 7)))
    ((or (string=? "trytond" name)
         (string-prefix? "trytond-" name)) (snake-case name))
    (else (string-append "python-" (snake-case name)))))

base-commit: e2f37229e5e7f6e73806d8087faf9e1e94ea9acf
-- 
2.49.0

Message #8 received at 77600 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77600 <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH] import/pypi: Improve renaming procedure.
Date: Mon, 7 Apr 2025 17:35:24 +0100

[Message part 1 (text/plain, inline)]

Hi,

The change looks reasonable.

Some side note on PyPI source archive naming, they started forcing
users to rename them to lower case only and _

https://packaging.python.org/en/latest/discussions/package-formats/

VCS: https://github.incerto.xyz/; https://git.sr.ht/~hellseher/
GPG: 9847 81DE 689C 21C2 6418 0867 76D7 27BF F62C D2B5

… наш разум - превосходная объяснительная машина которая способна найти
смысл почти в чем угодно, истолковать любой феномен, но совершенно не в
состоянии принять мысль о непредсказуемости.

[Message part 2 (text/html, inline)]

Message #13 received at 77600-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sharlatan Hellseher <sharlatanus <at> gmail.com>
Cc: 77600-done <at> debbugs.gnu.org
Subject: Re: [bug#77600] [PATCH] import/pypi: Improve renaming procedure.
Date: Mon, 14 Apr 2025 15:40:33 +0900

Hi,

Sharlatan Hellseher <sharlatanus <at> gmail.com> writes:

> Hi,
>
> The change looks reasonable.
>
> Some side note on PyPI source archive naming, they started forcing
> users to rename them to lower case only and _

OK, thanks for looking.  About the later naming, that's something to
handle in `guix-package->pypi-name', right?  I'm not sure this happens
*everywhere* for new releases now, on only in packages using modern
packaging tools such PEP 517 builders, though?

I've now applied this one.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.