GNU bug report logs - #77582
[PATCH] services: Make the urandom-seed-service-type return success.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77582 in the body.
You can then email your comments to 77582 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: Make the urandom-seed-service-type return success.
Date: Sun,  6 Apr 2025 13:41:38 -0400

Reported by nigko on #guix:

https://logs.guix.gnu.org/guix/2025-04-05.log#201718

* gnu/services/base.scm (urandom-seed-shepherd-service): Return #f when
stopped.

Change-Id: I8212508e4a017270e4e9284b43170cd17999e8b4
---
 gnu/services/base.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 9a9dfdb3045..411a2247622 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -673,7 +673,8 @@ (define (urandom-seed-shepherd-service _)
                              (lambda (seed)
                                (put-bytevector seed buf)))
                            (umask previous-umask))
-                         #t)))))
+                         )))
+                   #f))
          (modules `((rnrs bytevectors)
                     (rnrs io ports)
                     ,@%default-modules)))))

base-commit: ada14197fb465c1c90efbc450308c14f077ff167
-- 
2.48.1

Message #8 received at 77582 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 77582 <at> debbugs.gnu.org
Subject: Re: [bug#77582] [PATCH] services: Make the
 urandom-seed-service-type return success.
Date: Tue, 08 Apr 2025 17:07:45 +0200

Leo Famulari <leo <at> famulari.name> skribis:

> Reported by nigko on #guix:
>
> https://logs.guix.gnu.org/guix/2025-04-05.log#201718
>
> * gnu/services/base.scm (urandom-seed-shepherd-service): Return #f when
> stopped.
>
> Change-Id: I8212508e4a017270e4e9284b43170cd17999e8b4

LGTM!

Message #13 received at 77582-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 77582-done <at> debbugs.gnu.org
Subject: Re: [bug#77582] [PATCH] services: Make the urandom-seed-service-type
 return success.
Date: Tue, 8 Apr 2025 20:25:49 -0400

On Tue, Apr 08, 2025 at 05:07:45PM +0200, Ludovic Courtès wrote:
> LGTM!
 
Thanks for taking a look! Pushed as
bb4ce5cc4701ddaa08f4b3d9528a4a665c22b4bc

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.