From unknown Fri Aug 15 22:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7758: 24.0.50; doc string and args of `dired-revert' Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2010 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7758 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7758@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.12936495042830 (code B ref -1); Wed, 29 Dec 2010 19:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Dec 2010 19:05:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PY1KZ-0000ja-M4 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 14:05:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PY1KY-0000j9-Ox for submit@debbugs.gnu.org; Wed, 29 Dec 2010 14:05:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PY1RD-000549-PV for submit@debbugs.gnu.org; Wed, 29 Dec 2010 14:11:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:34503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PY1RD-000542-ML for submit@debbugs.gnu.org; Wed, 29 Dec 2010 14:11:55 -0500 Received: from [140.186.70.92] (port=38261 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PY1RC-0002kS-52 for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 14:11:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PY1RA-00052t-Nm for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 14:11:54 -0500 Received: from rcsinet10.oracle.com ([148.87.113.121]:17606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PY1RA-00052M-Ic for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 14:11:52 -0500 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oBTJBnpA026198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Dec 2010 19:11:51 GMT Received: from acsmt354.oracle.com (acsmt354.oracle.com [141.146.40.154]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oBTIRp62029192 for ; Wed, 29 Dec 2010 19:11:49 GMT Received: from abhmt009.oracle.com by acsmt354.oracle.com with ESMTP id 914442641293649827; Wed, 29 Dec 2010 11:10:27 -0800 Received: from dradamslap1 (/10.159.216.195) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 Dec 2010 11:10:26 -0800 From: "Drew Adams" Date: Wed, 29 Dec 2010 11:10:31 -0800 Message-ID: <4C083E1AA7374145BE4DE04F8E028E11@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcunjA/CwHTFH9mnR+W3EPpDoNObMg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) (defun dired-revert (&optional arg noconfirm) "Reread the dired buffer. Must also be called after `dired-actual-switches' have changed. Should not fail even on completely garbaged buffers. Preserves old cursor, marks/flags, hidden-p." ...) The doc string should say that there are two optionl arguments and they are never used. And it should say explicitly that this is because this function is used as a value of `revert-buffer-function'. The last part is important - users should be able to see the connection easily. And it would be better to name the args for this function IGNORE1 and IGNORE2 or some such. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-12-20 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include' From unknown Fri Aug 15 22:18:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7758: 24.0.50; doc string and args of `dired-revert' Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jan 2011 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7758 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 7758@debbugs.gnu.org Received: via spool by 7758-submit@debbugs.gnu.org id=B7758.129581273416213 (code B ref 7758); Sun, 23 Jan 2011 19:59:01 +0000 Received: (at 7758) by debbugs.gnu.org; 23 Jan 2011 19:58:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ph65O-0004DS-0r for submit@debbugs.gnu.org; Sun, 23 Jan 2011 14:58:54 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ph65L-0004DH-Lj for 7758@debbugs.gnu.org; Sun, 23 Jan 2011 14:58:51 -0500 Received: from furball (162.254.218.209.transedge.com [209.218.254.162]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0NK6okc015809 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 23 Jan 2011 15:06:51 -0500 Received: by furball (Postfix, from userid 1000) id E248E16075F; Sun, 23 Jan 2011 15:06:47 -0500 (EST) From: Chong Yidong References: <4C083E1AA7374145BE4DE04F8E028E11@us.oracle.com> Date: Sun, 23 Jan 2011 15:06:47 -0500 In-Reply-To: <4C083E1AA7374145BE4DE04F8E028E11@us.oracle.com> (Drew Adams's message of "Wed, 29 Dec 2010 11:10:31 -0800") Message-ID: <87pqrn75bc.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) "Drew Adams" writes: > The doc string should say that there are two optionl arguments and they > are never used. And it should say explicitly that this is because this > function is used as a value of `revert-buffer-function'. The last part > is important - users should be able to see the connection easily. Fixed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 23 14:59:06 2011 Received: (at control) by debbugs.gnu.org; 23 Jan 2011 19:59:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ph65Z-0004E7-SG for submit@debbugs.gnu.org; Sun, 23 Jan 2011 14:59:06 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ph65X-0004Dd-KG for control@debbugs.gnu.org; Sun, 23 Jan 2011 14:59:03 -0500 Received: from furball (162.254.218.209.transedge.com [209.218.254.162]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p0NK72xS027550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 23 Jan 2011 15:07:03 -0500 Received: by furball (Postfix, from userid 1000) id 0F69216075F; Sun, 23 Jan 2011 15:06:59 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 7758 Date: Sun, 23 Jan 2011 15:06:59 -0500 Message-ID: <87vd1ffkpo.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.4 (--) close 7758 thanks