GNU bug report logs - #77571
[PATCH] gnu: emacs-magit-stgit: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77571 in the body.
You can then email your comments to 77571 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-magit-stgit: Fix build.
Date: Sun,  6 Apr 2025 10:55:30 +0200

* gnu/packages/emacs-xyz.scm (flightgear): Fix build.

Package is broken.

- fix wrong sha256
- remove unused propagated dependency
- disable tests

Change-Id: I61fdfb276ba49b0d4b712cba2221189f3adc6e8e
---
 gnu/packages/emacs-xyz.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7c290d0833..8bf1c23349 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2002,10 +2002,12 @@ (define-public emacs-magit-stgit
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1z2dhc1m510iyrks5lxp3jlqg4n7qwwirbmxg4c4ll0xngfhnalc"))))
+        (base32 "10ql7gi586w65vds6wsh8bw5nr444xqhgh87khzcpfaglnw2lyaf"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-magit emacs-transient emacs-llama
-                             emacs-dash))
+    (arguments
+     (list
+      #:tests? #f)) ;no tests
+    (propagated-inputs (list emacs-magit emacs-transient emacs-llama))
     (home-page "https://github.com/stacked-git/magit-stgit")
     (synopsis "StGit extension for Magit")
     (description

base-commit: f658cd17b6ee599eaed03d10eacded9709343ea1
-- 
2.49.0

Message #8 received at 77571 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>, Hilton Chain <hako <at> ultrarare.space>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>, 77571 <at> debbugs.gnu.org
Subject: Re: [bug#77571] [PATCH] gnu: emacs-magit-stgit: Fix build.
Date: Sun, 06 Apr 2025 10:28:04 -0700

Hi Cayetano,

Cayetano Santos <csantosb <at> inventati.org> writes:

> * gnu/packages/emacs-xyz.scm (flightgear): Fix build.
>
> Package is broken.
>
> - fix wrong sha256
> - remove unused propagated dependency
> - disable tests

Same as in #77561, this needs to be in the expected changelog 
format, ex:

[base32]: Correct hash
[propagated-inputs]: Remove emacs-dash

etc.

Could you send a v2, please?

Thanks,
 -- Ian

Message #11 received at 77571 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77571 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: emacs-magit-stgit: Fix build.
Date: Sun,  6 Apr 2025 20:32:02 +0200

* gnu/packages/emacs-xyz.scm (flightgear): Fix build.

[base32]: Correct hash
[propagated-inputs]: Remove emacs-dash
[arguments]: Disable tests explicitely

Change-Id: I61fdfb276ba49b0d4b712cba2221189f3adc6e8e
---
 gnu/packages/emacs-xyz.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7c290d0833..8bf1c23349 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2002,10 +2002,12 @@ (define-public emacs-magit-stgit
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1z2dhc1m510iyrks5lxp3jlqg4n7qwwirbmxg4c4ll0xngfhnalc"))))
+        (base32 "10ql7gi586w65vds6wsh8bw5nr444xqhgh87khzcpfaglnw2lyaf"))))
     (build-system emacs-build-system)
-    (propagated-inputs (list emacs-magit emacs-transient emacs-llama
-                             emacs-dash))
+    (arguments
+     (list
+      #:tests? #f)) ;no tests
+    (propagated-inputs (list emacs-magit emacs-transient emacs-llama))
     (home-page "https://github.com/stacked-git/magit-stgit")
     (synopsis "StGit extension for Magit")
     (description

base-commit: 90279af10615cd74e4c52851f7fec797d4d0f682
-- 
2.49.0

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 77571-done <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>,
 Ian Eure <ian <at> retrospec.tv>
Subject: Re: [bug#77571] [PATCH v2] gnu: emacs-magit-stgit: Fix build.
Date: Mon, 07 Apr 2025 21:17:14 +0100

[Message part 1 (text/plain, inline)]

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (flightgear): Fix build.
>
> [base32]: Correct hash
> [propagated-inputs]: Remove emacs-dash
> [arguments]: Disable tests explicitely
>
> Change-Id: I61fdfb276ba49b0d4b712cba2221189f3adc6e8e
> ---
>  gnu/packages/emacs-xyz.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Thanks both, I've pushed this to master as
f888993243f3f9361bee1a2e91e496dc7e369960.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.