GNU bug report logs - #77566
[PATCH] Add option for automatically delete non-existent projects.

Previous Next

To reply to this bug, email your comments to 77566 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add option for automatically delete non-existent projects.
Date: Sat, 05 Apr 2025 17:50:56 -0600

[Message part 1 (text/plain, inline)]

Tags: patch

This feature automatically remove from project list projects that were
deleted, only when `project-switch-project' is being used.

This acts similar to `projectile-auto-cleanup-known-projects' from
projectile.el

[Message part 2 (text/html, inline)]

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #8 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Sun, 06 Apr 2025 08:29:15 +0800

Hello,

Thanks, though why do this only when switching projects?
Why not do it proactively whenever fetching the list of projects?
Performance concerns?

-- 
Sean Whitton

Message #11 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Sat, 05 Apr 2025 18:52:11 -0600

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Hello,
>
> Thanks, though why do this only when switching projects?
> Why not do it proactively whenever fetching the list of projects?
> Performance concerns?

Yes, but depends on how many projects one has.
(and because i forgot to add it)

-- 
                                          - E.G via GNU Emacs and Org.

Message #14 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: eg642616 <at> gmail.com
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Sat, 05 Apr 2025 19:38:27 -0600

[Message part 1 (text/plain, inline)]

Sending a better patch.

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #17 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Sun, 6 Apr 2025 07:26:18 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 5, 2025 at 9:39 PM Elijah Gabe Pérez <eg642616 <at> gmail.com> wrote:

> Sending a better patch.
>

I think we need to call zombies something else and also consider that
remote files may need to be ignored by the zombie checker to reduce the
costs of checking project paths, to avoid tramp prompts for an internal
function, and to accommodate that not all tramp connections are available
all the time and those may not be reachable and should not be considered
zombies.

Setting aside the zombie name for now, hHow about calling
'project-auto-forget-zombie-projects' 'project-prune-zombie-projects' and
rather than boolean, accept symbols that could include something like
'list-read 'list-write nil so users can decide when pruning happens.  In
long-lived Emacs sessions just doing it at list read time seems
insufficient.

Could we rename report-message to no-message and change when to unless to
keep it uniform?  The word report suggests things other than merely
allowing messages.

++++
*** New user option 'project-auto-forget-zombie-projects'.
- This user option automatically remove projects from 'project-list-file'
+ This user option automatically removes projects from 'project-list-file'
- that have been deleted.
+ that cannot be accessed. [this language accommodates remote projects]

- "Automatically remove from project list projects that were deleted.
- If non-nil, remove automatically projects that doesn't exist anymore
- from the project list."
+ "Remove inaccessible project list entries.
+ If \\='list-read...etc.
+ If \\='list-write...etc.
+ [whatever other conditions seem reasonable]
+ If nil, no pruning is performed."

-Stephane

[Message part 2 (text/html, inline)]

Message #20 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Ship Mints <shipmints <at> gmail.com>
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Sun, 06 Apr 2025 18:39:28 -0600

[Message part 1 (text/plain, inline)]

Ship Mints <shipmints <at> gmail.com> writes:

> I think we need to call zombies something else and also consider that remote files may need to be
> ignored by the zombie checker to reduce the costs of checking project paths, to avoid tramp prompts for
> an internal function, and to accommodate that not all tramp connections are available all the time and
> those may not be reachable and should not be considered zombies.

Something like to this patch?

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

I don't have a remote project so I can't test it.

> Setting aside the zombie name for now, hHow about calling 'project-auto-forget-zombie-projects'
> 'project-prune-zombie-projects' and rather than boolean, accept symbols that could include something
> like 'list-read 'list-write nil so users can decide when pruning happens.

I've added them and also an `all' option which mix `list-read' and
`list-write'.

> Could we rename report-message to no-message and change when to unless to keep it uniform?  The
> word report suggests things other than merely allowing messages.

I've added it as an additional optional argument.

-- 
                                          - E.G via GNU Emacs and Org.

Message #23 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: dmitry <at> gutov.dev, 77566 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 07 Apr 2025 09:40:40 +0300

> +(defcustom project-dont-prune-remote-zombie-projects nil
> +  "If non-nil, remote files will no be pruned by `project-forget-zombie-projects'."
> +  :type 'boolean
> +  :version "31.1"
> +  :group 'project)

Maybe it's possible to do with one option like there is
remote-ignoring 'recentf-keep-default-predicate'
in the default value of 'recentf-keep'.

> I don't have a remote project so I can't test it.

'sudo' counts as a remote project too.
So you can just type 'C-x x @' and the current project
will be added as remote.

Message #26 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: dmitry <at> gutov.dev, Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 09:19:53 -0400

[Message part 1 (text/plain, inline)]

On Mon, Apr 7, 2025 at 2:41 AM Juri Linkov <juri <at> linkov.net> wrote:

> > +(defcustom project-dont-prune-remote-zombie-projects nil
> > +  "If non-nil, remote files will no be pruned by
> `project-forget-zombie-projects'."
> > +  :type 'boolean
> > +  :version "31.1"
> > +  :group 'project)
>
> Maybe it's possible to do with one option like there is
> remote-ignoring 'recentf-keep-default-predicate'
> in the default value of 'recentf-keep'.
>
> > I don't have a remote project so I can't test it.
>
> 'sudo' counts as a remote project too.
> So you can just type 'C-x x @' and the current project
> will be added as remote.
>

Indeed, and you can also open a local project via ssh to get the same thing
if you want to test other remote methods.

I think this is backwards

+    (unless (or (and no-remote (file-exists-p proj) (not (file-remote-p
proj)))

and should be

+    (unless (or (and no-remote (not (file-remote-p proj) (file-exists-p
proj)))

to avoid the cost of a remote file-exists-p.

[Message part 2 (text/html, inline)]

Message #29 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Sean Whitton <spwhitton <at> spwhitton.name>,
 Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 77566 <at> debbugs.gnu.org
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 20:34:50 +0300

On 06/04/2025 03:29, Sean Whitton wrote:
> Thanks, though why do this only when switching projects?
> Why not do it proactively whenever fetching the list of projects?
> Performance concerns?

I'm concerned about performance, yes. With my SSD, it takes about 4ms to 
"clean up" ~70 projects. The number could be higher, and the hard drive 
could be spinning media.

So could someone point out what will we get by proactively cleaning up 
the list, rather than doing that only when a project is being prompted for?

Message #32 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 Ship Mints <shipmints <at> gmail.com>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 20:36:11 +0300

On 07/04/2025 03:39, Elijah Gabe Pérez wrote:
> +(defcustom project-prune-zombie-projects nil
> +  "Automatically remove from project list projects that were deleted.
> +If set to `all', remove projects when project list file
> +is being read or written.
> +If set to `list-read', only remove projects when project list file
> +is being read.
> +If set to `list-write', only remove projects when project list file is
> +being written.

That's a lot of alternatives. Do we have a picture of the users who 
would use each of the values?

And speaking of remote projects, maybe we should add a prefix argument 
to project-forget-zombie-projects instead of an option.

Message #35 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Ship Mints <shipmints <at> gmail.com>, Elijah Gabe Pérez
 <eg642616 <at> gmail.com>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 20:40:12 +0300

On 06/04/2025 14:26, Ship Mints wrote:
> I think we need to call zombies something else and also consider that 
> remote files may need to be ignored by the zombie checker to reduce the 
> costs of checking project paths, to avoid tramp prompts for an internal 
> function, and to accommodate that not all tramp connections are 
> available all the time and those may not be reachable and should not be 
> considered zombies.

Speaking of remote projects, even when a connection is available, 
checking all of the projects for existence might create a large latency, 
simply because of the lag to the remote host.

So I'm not sure what's the best approach here. Though we could just add 
the option as off by default and say that if you turned it on, you 
accept the consequences.

Message #38 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77566 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 07 Apr 2025 21:33:31 +0300

>> +(defcustom project-prune-zombie-projects nil
>> +  "Automatically remove from project list projects that were deleted.
>> +If set to `all', remove projects when project list file
>> +is being read or written.
>> +If set to `list-read', only remove projects when project list file
>> +is being read.
>> +If set to `list-write', only remove projects when project list file is
>> +being written.
>
> That's a lot of alternatives. Do we have a picture of the users who would
> use each of the values?

Instead of desperately cleaning zombies that are popping up again and again,
I'd prefer an option with a list of directories that should be never added
to the project list.  Or maybe improve 'project-forget-projects-under' to
remember what projects it forgot to not add them again, e.g.
by a new property in ~/.emacs.d/projects file:

(("/dir1" (forgotten . t))
 ...)

Message #41 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Juri Linkov <juri <at> linkov.net>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77566 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Tue, 8 Apr 2025 00:48:55 +0300

On 07/04/2025 21:33, Juri Linkov wrote:
> Instead of desperately cleaning zombies that are popping up again and again,
> I'd prefer an option with a list of directories that should be never added
> to the project list.

I think we have that in the recently added option project-list-exclude.

Message #44 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 19:25:33 -0600

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 06/04/2025 03:29, Sean Whitton wrote:
> > Thanks, though why do this only when switching projects?
> > Why not do it proactively whenever fetching the list of projects?
> > Performance concerns?
>
> I'm concerned about performance, yes. With my SSD, it takes about 4ms to
> "clean up" ~70 projects. The number could be higher, and the hard drive
> could be spinning media.
>

Yeah, that is why i originally added it only when switching projects,
projectile does the same.

So could someone point out what will we get by proactively cleaning up
> the list, rather than doing that only when a project is being prompted for?


Maybe for ensure that the zombies were removed?

For example, packages that use project--list for read the projects.

Instead what about purge it once after emacs startup?

>

[Message part 2 (text/html, inline)]

Message #47 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77566 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Mon, 7 Apr 2025 19:34:12 -0600

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 07/04/2025 03:39, Elijah Gabe Pérez wrote:
> > +(defcustom project-prune-zombie-projects nil
> > +  "Automatically remove from project list projects that were deleted.
> > +If set to `all', remove projects when project list file
> > +is being read or written.
> > +If set to `list-read', only remove projects when project list file
> > +is being read.
> > +If set to `list-write', only remove projects when project list file is
> > +being written.
>
> That's a lot of alternatives. Do we have a picture of the users who
> would use each of the values?
>

AFAIK, no, I would honestly prefer just a booelan, this can be confused.

And speaking of remote projects, maybe we should add a prefix argument
> to project-forget-zombie-projects instead of an option.
>

The patch already provides this, should the option be removed?:

@@ -2117,12 +2148,17 @@ project-remember-projects-under
                          count) count))
     count))

-(defun project-forget-zombie-projects ()
-  "Forget all known projects that don't exist any more."
-  (interactive)
+(defun project-forget-zombie-projects (&optional no-remote no-message)
+  "Forget all known projects that don't exist any more.
+If NO-REMOTE is non-nil, don't forget remote projects.
+If NO-MESSAGE is non-nil, don't display a message about projects removed."
+  (interactive "P")
   (dolist (proj (project-known-project-roots))
-    (unless (file-exists-p proj)
-      (project-forget-project proj))))
+    (unless (or (and no-remote (file-exists-p proj) (not (file-remote-p
proj)))
+                (and project-dont-prune-remote-zombie-projects
+                     (file-exists-p proj) (not (file-remote-p proj)))
+                (file-exists-p proj))
+      (project-forget-project proj no-message))))

>

[Message part 2 (text/html, inline)]

Message #50 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77566 <at> debbugs.gnu.org
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Tue, 08 Apr 2025 10:33:00 +0800

Hello,

On Mon 07 Apr 2025 at 08:34pm +03, Dmitry Gutov wrote:

> On 06/04/2025 03:29, Sean Whitton wrote:
>> Thanks, though why do this only when switching projects?
>> Why not do it proactively whenever fetching the list of projects?
>> Performance concerns?
>
> I'm concerned about performance, yes. With my SSD, it takes about 4ms to
> "clean up" ~70 projects. The number could be higher, and the hard drive could
> be spinning media.
>
> So could someone point out what will we get by proactively cleaning up the
> list, rather than doing that only when a project is being prompted for?

I see, yes.  Doing it only when switching projects seems good to me.

-- 
Sean Whitton

Message #53 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Elijah Gabe Pérez <eg642616 <at> gmail.com>,
 77566 <at> debbugs.gnu.org, Ship Mints <shipmints <at> gmail.com>,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Tue, 08 Apr 2025 09:20:22 +0300

>> Instead of desperately cleaning zombies that are popping up again and again,
>> I'd prefer an option with a list of directories that should be never added
>> to the project list.
>
> I think we have that in the recently added option project-list-exclude.

Ok, this works nicely:

(define-advice project-forget-projects-under (:after (dir &optional _recursive) remember)
  (add-to-list 'project-list-exclude dir))

Message #56 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Tue, 08 Apr 2025 22:23:29 -0600

[Message part 1 (text/plain, inline)]

Elijah Gabe Pérez <eg642616 <at> gmail.com> writes:

> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>
>  On 06/04/2025 03:29, Sean Whitton wrote:
>  > Thanks, though why do this only when switching projects?
>  > Why not do it proactively whenever fetching the list of projects?
>  > Performance concerns?
>
>  I'm concerned about performance, yes. With my SSD, it takes about 4ms to 
>  "clean up" ~70 projects. The number could be higher, and the hard drive 
>  could be spinning media.
>
> Yeah, that is why i originally added it only when switching projects, projectile does the same.
>
>  So could someone point out what will we get by proactively cleaning up 
>  the list, rather than doing that only when a project is being prompted for?
>
> Maybe for ensure that the zombies were removed?
>
> For example, packages that use project--list for read the projects.
>
> Instead what about purge it once after emacs startup?

Something like this patch(?), it now clean up when
project-prompt-project-name or project-prompt-project-dir are being
called and after project--list was initialized:

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #59 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Wed, 9 Apr 2025 15:51:14 +0300

On 09/04/2025 07:23, Elijah Gabe Pérez wrote:
> Instead what about purge it once after emacs startup?

I think a concern was voiced that during a long-running session 
directories can get removed at any time.

+        (project-forget-zombie-projects nil t))))

Are we sure that we want to suppress the messages about the removals in 
this case? Personally, I'd just print it in any case (if some were 
removed anyway).

+(defun project-forget-zombie-projects (&optional no-remote no-message)
> +  "Forget all known projects that don't exist any more.
> +If NO-REMOTE is non-nil, don't forget remote projects.

Maybe NO-REMOTE should be called INCLUDE-REMOTE instead?

Right now it sounds like the opposite of its actual meaning.

Message #62 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Wed, 09 Apr 2025 13:28:05 -0600

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 09/04/2025 07:23, Elijah Gabe Pérez wrote:
>> Instead what about purge it once after emacs startup?
>
> I think a concern was voiced that during a long-running session directories can get removed at any time.
>
> +        (project-forget-zombie-projects nil t))))
>
> Are we sure that we want to suppress the messages about the removals in this case? Personally, I'd just print it in any case (if some were removed anyway).

It would display the message after `startup-echo-area-message'.
I think it would be intrusive.

I've changed it to `inhibit-message' instead, which will include
the message into *Messages* buffer but will not be displayed.

> +(defun project-forget-zombie-projects (&optional no-remote no-message)
>> +  "Forget all known projects that don't exist any more.
>> +If NO-REMOTE is non-nil, don't forget remote projects.
>
> Maybe NO-REMOTE should be called INCLUDE-REMOTE instead?
>
> Right now it sounds like the opposite of its actual meaning.

I think EXCLUDE-REMOTES would be a better name,
the INCLUDE-REMOTE name would give the impression that it does not
delete remote projects by default.  `project-forget-zombie-projects' by
default includes remote and no remote projects.

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Message #65 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Elijah Gabe Pérez <eg642616 <at> gmail.com>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Thu, 10 Apr 2025 02:54:27 +0300

On 09/04/2025 22:28, Elijah Gabe Pérez wrote:
> Dmitry Gutov <dmitry <at> gutov.dev> writes:
> 
>> On 09/04/2025 07:23, Elijah Gabe Pérez wrote:
>>> Instead what about purge it once after emacs startup?
>>
>> I think a concern was voiced that during a long-running session directories can get removed at any time.
>>
>> +        (project-forget-zombie-projects nil t))))
>>
>> Are we sure that we want to suppress the messages about the removals in this case? Personally, I'd just print it in any case (if some were removed anyway).
> 
> It would display the message after `startup-echo-area-message'.
> I think it would be intrusive.

Do we read the project list at startup?

Even so, the message might only be there if there are projects to clean 
up. So it won't show up every time.

> I've changed it to `inhibit-message' instead, which will include
> the message into *Messages* buffer but will not be displayed.

That's fine too, although we probably do want to show it when called 
interactively.

>> +(defun project-forget-zombie-projects (&optional no-remote no-message)
>>> +  "Forget all known projects that don't exist any more.
>>> +If NO-REMOTE is non-nil, don't forget remote projects.
>>
>> Maybe NO-REMOTE should be called INCLUDE-REMOTE instead?
>>
>> Right now it sounds like the opposite of its actual meaning.
> 
> I think EXCLUDE-REMOTES would be a better name,
> the INCLUDE-REMOTE name would give the impression that it does not
> delete remote projects by default.  `project-forget-zombie-projects' by
> default includes remote and no remote projects.

Don't we want to avoid remote projects by default? It might take a long 
time. Does it here in my testing anyway.

Having the "fast" path to be the default and the "thorough" as the 
prefix command alternative seems to be a common approach.

Message #68 received at 77566 <at> debbugs.gnu.org (full text, mbox):

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77566 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#77566: [PATCH] Add option for automatically delete
 non-existent projects.
Date: Wed, 09 Apr 2025 22:07:45 -0600

[Message part 1 (text/plain, inline)]

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 09/04/2025 22:28, Elijah Gabe Pérez wrote:
>> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>> 
>>> On 09/04/2025 07:23, Elijah Gabe Pérez wrote:
>>>> Instead what about purge it once after emacs startup?
>>>
>>> I think a concern was voiced that during a long-running session directories can get removed at any time.
>>>
>>> +        (project-forget-zombie-projects nil t))))
>>>
>>> Are we sure that we want to suppress the messages about the removals in this case? Personally, I'd just print it in any case (if some were removed anyway).
>> It would display the message after `startup-echo-area-message'.
>> I think it would be intrusive.
>
> Do we read the project list at startup?

Apparently no, I didn't notice it's just my configuration
that does it.

>> I've changed it to `inhibit-message' instead, which will include
>> the message into *Messages* buffer but will not be displayed.
>
> That's fine too, although we probably do want to show it when called interactively.

Sure.  I've added it as an user option.

>>> +(defun project-forget-zombie-projects (&optional no-remote no-message)
>>>> +  "Forget all known projects that don't exist any more.
>>>> +If NO-REMOTE is non-nil, don't forget remote projects.
>>>
>>> Maybe NO-REMOTE should be called INCLUDE-REMOTE instead?
>>>
>>> Right now it sounds like the opposite of its actual meaning.
>> I think EXCLUDE-REMOTES would be a better name,
>> the INCLUDE-REMOTE name would give the impression that it does not
>> delete remote projects by default.  `project-forget-zombie-projects' by
>> default includes remote and no remote projects.
>
> Don't we want to avoid remote projects by default? It might take a long time. Does it here in my testing anyway.
>
> Having the "fast" path to be the default and the "thorough" as the prefix command alternative seems to be a common approach.

You are right, I've change it for exclude remote projects by default.

[0001-Add-option-for-automatically-delete-non-existent-pro.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.