From unknown Tue Jun 17 01:48:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77560: The guix style command deletes #; comments. Resent-From: Yuval Langer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Apr 2025 18:57:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77560 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 77560@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1743879422459 (code B ref -1); Sat, 05 Apr 2025 18:57:03 +0000 Received: (at submit) by debbugs.gnu.org; 5 Apr 2025 18:57:02 +0000 Received: from localhost ([127.0.0.1]:44840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u18hS-00007C-2v for submit@debbugs.gnu.org; Sat, 05 Apr 2025 14:57:02 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46146) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u18hQ-00006o-4h for submit@debbugs.gnu.org; Sat, 05 Apr 2025 14:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u18hK-0002K6-QM for bug-guix@gnu.org; Sat, 05 Apr 2025 14:56:54 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u18hJ-00058V-45 for bug-guix@gnu.org; Sat, 05 Apr 2025 14:56:54 -0400 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-30beedb99c9so28606661fa.3 for ; Sat, 05 Apr 2025 11:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743879411; x=1744484211; darn=gnu.org; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WjpukuwmBpm5jL5BVageAx5VVHHysRs9QuBWBoRGbw0=; b=Fn6eyxfOdnAYXFqOxvqnvfp3dVPi/l9q3v1fo6OGWsxJN0HcfkeOdALj+KOKhIg31D YdDmBuQ1IuyMW0lpQ4XNU6Ho7ybbbBUYncmAF/2jcP4Jf9gWTAbOnBhAxszL8TGXG0Gc E4FJMx+85rUexR/8fo5/pYgV2u+Gl0Afih067A0brjplJoaJnQRuf6NhEhygDDSdstiU ctcqxo3hrPeW7gilb8AB9lklzQ6xVenSBrXDL8s6H+qbrRd2l4kvWWRgCMH9bc7mv6Ks mXaLSZr03m+x0sTvzxFYzinqKbjfOqloSEhju/dRPthSue8gepRYsoiSx9BBPMH8pE9P cUDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743879411; x=1744484211; h=content-transfer-encoding:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WjpukuwmBpm5jL5BVageAx5VVHHysRs9QuBWBoRGbw0=; b=LddXhAK7EpHMELLldjLEMp2fqQAfgIkE969mMJUzwUqS6YHrCF7KlZzNsg20lfJohJ epWbTmENBCnB0ob1Y4YYPAMpseKcrw6V/iT9fuVHPYVBBEH/r9gWbgn2mEG8EMcrQp8E 73D1vTnRvVArF0QOg8fOje7Hz/9Z02E04EU1L7F5dig7liyeYTOQe+7V/GdcqlnAVxps Lx6IFVFbApo+MxvaGEsHy6Yicw61Pzegil3qks/EQ35zl3SOGBm45Um/fhqQXi41DW6M t9ZMZtWGuS8Ir+GPGI2uPImkQ8Ji9LHdmJcdFyPw1MJeUgs9GBRVeKjJOxy4Gg/BVn2G i+ZA== X-Gm-Message-State: AOJu0YyAMGTEy+xRhGgKS2m97Eq5ddm/fm5sNlwnbCPaVVy3JAkonLYh 8dbGiDKKqXxlZD6VpeGQuyfbJiYbDfIi/1Nb4p3o0eKowxxa9vlQ+pD7BNOT0FnjlIXUOxSC8Iv wlj4jWK9q+6uaPwS7N/YM5epAs9h764rX5lI= X-Gm-Gg: ASbGncuZL037FINvIRGjhsltLokGk2F4g5lO0TxTEFlQUy6gTonOl+ZpTieNrGCCw6Z ycUVwXNf78R5YxufbEz+49Qd5XdB7ivj9aA4ch4pKlxWBQJy22pNsNoHNofTtEJbqF2fHIMEewo +2f2kZjiThFmyGl7DxJQ+bi7bDsxvOciFz2V4HJFTM7/FEcMSbUVru827lHgxy X-Google-Smtp-Source: AGHT+IHUnNFUUgrF+R0Ltg3AKs7lOQvFq1Du+lUT97f9I2kuFIa4E+wD6O0GaFI5fbsdTt19z46IGdB2no5XkC5MQMg= X-Received: by 2002:a2e:a553:0:b0:30c:160b:c76c with SMTP id 38308e7fff4ca-30f1652a43amr8988991fa.17.1743879410417; Sat, 05 Apr 2025 11:56:50 -0700 (PDT) MIME-Version: 1.0 From: Yuval Langer Date: Sat, 5 Apr 2025 21:56:14 +0300 X-Gm-Features: ATxdqUFLjEsDhxYVh4WQL7_1HtcPWcA8-k1eYbT4hA9dB1_1MWjlRmAzIPq9JuI Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::234; envelope-from=yuval.langer@gmail.com; helo=mail-lj1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) [ed: this bug report is written in the style of a rant, please do not take it personally, I just find rant styled prose very funny. It may also demonstrate some of my frustration with the bug=E2=80=A6=E2=80=A6=E2= =80=A6] You know what I hate? guix style command deleting my #;ed up exploratory bits of code. I hate it! You are at the exploratory stages of a bit of coding, you write one or two extra version of the same functionality, so you comment them out with #;, right? Then just so that things look nicer you guix style... and then your code is GONE! It's all GONE! Maybe put this #; comments deletion functionality behind a flag with a very visible warning and change the code submission guidelines to reflect that? Many thanks, Yuval Langer. From unknown Tue Jun 17 01:48:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77560: The guix style command deletes #; comments. References: In-Reply-To: Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 29 May 2025 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77560 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 77560@debbugs.gnu.org Received: via spool by 77560-submit@debbugs.gnu.org id=B77560.17485204969320 (code B ref 77560); Thu, 29 May 2025 12:09:01 +0000 Received: (at 77560) by debbugs.gnu.org; 29 May 2025 12:08:16 +0000 Received: from localhost ([127.0.0.1]:34919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uKc3S-0002QC-6g for submit@debbugs.gnu.org; Thu, 29 May 2025 08:08:16 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21128) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uKc3N-0002PZ-DW for 77560@debbugs.gnu.org; Thu, 29 May 2025 08:08:12 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1748520485; cv=none; d=zohomail.com; s=zohoarc; b=U2dMmgsQm+Pzep2fW6WnnRKS+bBKzzPgkwuSpf/6VTSA9L7FV7jYOUC44JnzoINBRjbrhuJOp6OAttzUAQEUuwno5Ykl2zEIWNhFsP6jxvZd/xHCl9CkGcPzIQG/hWrgf831TjUroVfgo4qXh/CUEqgdGpjZgZzo/wHgolUPUqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748520485; h=Content-Type:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=58WqpOU3jlytQOc9iNX/supSFkUkg9C/D08n/QgmWvI=; b=aYIZMqvmjflEmCQRft/1b64mk9IHzcxJoITvRbGpEXjM7gy23l+S48+0OGOxssaSQBc+9cKt2VdTUeV4verodkHdGY0dwdilkVv3bXNBYJSb8Ar0HHBTID92htQtBUSoBirTcIvEQkxV58P+QdFZhBFIHcDqFLYHp3/4wM4QvLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1748520485; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=58WqpOU3jlytQOc9iNX/supSFkUkg9C/D08n/QgmWvI=; b=ENgSRj2rBsi0GfEJo1MGn5I2l5KZDrMv4ReMyHvbOR7YOP6cwVxXiDl4gxUuyD+z wj1VMeVqpaSMCidIcifJF5vWkrGWddZTAFLQsIdEx4M9erzJ8a7hsCYVrrhda6xlzws rJ5bey3OqRJ7FOVvZqv6crT5cOPXoEs9kLJeyO5Y= Received: by mx.zohomail.com with SMTPS id 1748520483417786.6841851383934; Thu, 29 May 2025 05:08:03 -0700 (PDT) From: Ricardo Wurmus User-Agent: mu4e 1.12.9; emacs 29.4 Date: Thu, 29 May 2025 14:08:00 +0200 Message-ID: <87ldqfhb6n.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I think this is because READ-WITH-COMMENTS in (guix read-print) does not have a clause for reading expressions that start with #;. It explicitly handles single line comments, and it knows about G-expressions (starting with #), but it does not handle #;, so it cannot preserve them. -- Ricardo