GNU bug report logs - #7756
24.0.50; enhancements to package.el

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 7756 <at> debbugs.gnu.org, Richard Kim <emacs18 <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#7756: 24.0.50; enhancements to package.el
Date: Sat, 23 Nov 2019 14:35:43 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> -       ;; FIXME: should we delete PKG-DIR if it exists?
> +       (when (and (file-directory-p pkg-dir)
> +                  (yes-or-no-p
> +                   (format "Package directory already exists: `%s'.  Delete it?"
> +                           (directory-file-name pkg-dir))))
> +         (delete-directory pkg-dir 'recursive))

I'm a bit uneasy about doing a recursive deletion of the directory, even
after prompting (the developer may have put, well, anything in that
directory), so I wonder whether the right fix here is to just remove the
FIXME.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.