From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 29 13:37:45 2010 Received: (at submit) by debbugs.gnu.org; 29 Dec 2010 18:37:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PY0u9-00008e-FB for submit@debbugs.gnu.org; Wed, 29 Dec 2010 13:37:45 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PY0u7-00008T-A6 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 13:37:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PY10i-0007qy-D2 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 13:44:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST, T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:57224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PY10i-0007qu-7s for submit@debbugs.gnu.org; Wed, 29 Dec 2010 13:44:32 -0500 Received: from [140.186.70.92] (port=47335 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PY0zG-0001kI-3Q for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 13:44:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PY0xN-0007N8-EC for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 13:41:06 -0500 Received: from mail-pz0-f41.google.com ([209.85.210.41]:43757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PY0xN-0007Mr-3y for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2010 13:41:05 -0500 Received: by pzk27 with SMTP id 27so2515805pzk.0 for ; Wed, 29 Dec 2010 10:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:from:to:subject:reply-to :date:message-id:mime-version:content-type; bh=9zGKKIv5nkOxS/8vU+GI46PFaxYPDn9SgfMuCe0g13w=; b=u1q09ZxJmwB/2IdHypqZWw2dqCIiB5fE87IN2XsELBDl2rZdQIgLagtN1ekzU0Dw6M XTMrJ1s2ieX6D+teMB+byqRHZVPhkF/MVfCQsElHHfQqIu6PQYnU0Jq0TJzVsqFIsM6P zeeSJxx/izdtW0TgtWRq8LzG4LtF2bFx7gqoo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:reply-to:date:message-id:mime-version:content-type; b=jFuDMOTg3d8s0o+RcxWr9DAvYzXHN5BKm//PN2ZfUB+b3weeP3/b6qRQvrv5/O+sTz kBDGO6FkjVKHo/qZv5PZ5TMdjTJw6i5BLOk1MeJ8EE+VMUX06+LUVrslVmxN3xPhFPS4 cbgc6P4c/IV9ixM26bLVwRWk8ebH7RIp8dIYk= Received: by 10.142.217.10 with SMTP id p10mr12256702wfg.181.1293648063460; Wed, 29 Dec 2010 10:41:03 -0800 (PST) Received: from dad-laptop (pool-96-225-218-44.ptldor.fios.verizon.net [96.225.218.44]) by mx.google.com with ESMTPS id v19sm21219636wfh.12.2010.12.29.10.41.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 29 Dec 2010 10:41:02 -0800 (PST) From: emacs18@gmail.com From: Richard Kim To: bug-gnu-emacs@gnu.org Subject: 24.0.50; enhancements to package.el Date: Wed, 29 Dec 2010 10:40:56 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: emacs18@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) I would like to suggest the following two sets of changes. The reason for the changes are explained in the diffs. === modified file 'lisp/emacs-lisp/package.el' --- lisp/emacs-lisp/package.el 2010-11-10 21:35:06 +0000 +++ lisp/emacs-lisp/package.el 2010-12-29 18:38:08 +0000 @@ -338,9 +338,14 @@ (pkg-file (expand-file-name (concat (package-strip-version package) "-pkg") pkg-dir))) - (when (and (file-directory-p pkg-dir) - (file-exists-p (concat pkg-file ".el"))) - (load pkg-file nil t)))) + ;; When one is creating a package and testing it out, it is easy + ;; to forget to add the -pkg.el file. When that happens, it would + ;; be useful to provide feedback to the user rather than silently + ;; failing. That is what (error ...) below is for. + (when (file-directory-p pkg-dir) + (if (file-exists-p (concat pkg-file ".el")) + (load pkg-file nil t) + (error "'%s' file is missing!"))))) (defun package-load-all-descriptors () "Load descriptors for installed Emacs Lisp packages. @@ -569,8 +574,16 @@ (defun package-unpack (name version) (let ((pkg-dir (expand-file-name (concat (symbol-name name) "-" version) package-user-dir))) + ;; Delete the package directory if it exists already. This may + ;; not be useful to the end users. However this is extremely + ;; important for package developers as they experiment with which + ;; files to include in a package. If a file is removed from one + ;; iteration to the next, then the presence of the unwanted elisp + ;; file could cause problems by polluting the generated autoload + ;; file. + (if (file-directory-p pkg-dir) + (delete-directory pkg-dir 'recursive)) (make-directory package-user-dir t) - ;; FIXME: should we delete PKG-DIR if it exists? (let* ((default-directory (file-name-as-directory package-user-dir))) (package-untar-buffer) (package-generate-autoloads (symbol-name name) pkg-dir) From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 10:25:46 2010 Received: (at 7756) by debbugs.gnu.org; 30 Dec 2010 15:25:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYKNu-0002XO-Bb for submit@debbugs.gnu.org; Thu, 30 Dec 2010 10:25:46 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYKNs-0002X9-3x for 7756@debbugs.gnu.org; Thu, 30 Dec 2010 10:25:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AoAFADc1HE1FpZcL/2dsb2JhbACWH44bdL53hUoEhGWOGw X-IronPort-AV: E=Sophos;i="4.60,249,1291611600"; d="scan'208";a="86791929" Received: from 69-165-151-11.dsl.teksavvy.com (HELO pastel.home) ([69.165.151.11]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 30 Dec 2010 10:32:28 -0500 Received: by pastel.home (Postfix, from userid 20848) id 88FDE5934F; Thu, 30 Dec 2010 10:32:27 -0500 (EST) From: Stefan Monnier To: emacs18@gmail.com Subject: Re: bug#7756: 24.0.50; enhancements to package.el Message-ID: References: Date: Thu, 30 Dec 2010 10:32:27 -0500 In-Reply-To: (emacs's message of "Wed, 29 Dec 2010 10:40:56 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > @@ -338,9 +338,14 @@ > (pkg-file (expand-file-name > (concat (package-strip-version package) "-pkg") > pkg-dir))) > - (when (and (file-directory-p pkg-dir) > - (file-exists-p (concat pkg-file ".el"))) > - (load pkg-file nil t)))) > + ;; When one is creating a package and testing it out, it is easy > + ;; to forget to add the -pkg.el file. When that happens, it would > + ;; be useful to provide feedback to the user rather than silently > + ;; failing. That is what (error ...) below is for. > + (when (file-directory-p pkg-dir) > + (if (file-exists-p (concat pkg-file ".el")) > + (load pkg-file nil t) > + (error "'%s' file is missing!"))))) I agree with the intention, but I wonder: why do we pass the `noerror' parameter to `load' in the first place? > @@ -569,8 +574,16 @@ > (defun package-unpack (name version) > (let ((pkg-dir (expand-file-name (concat (symbol-name name) "-" version) > package-user-dir))) > + ;; Delete the package directory if it exists already. This may > + ;; not be useful to the end users. However this is extremely > + ;; important for package developers as they experiment with which > + ;; files to include in a package. If a file is removed from one > + ;; iteration to the next, then the presence of the unwanted elisp > + ;; file could cause problems by polluting the generated autoload > + ;; file. > + (if (file-directory-p pkg-dir) > + (delete-directory pkg-dir 'recursive)) Here, I also agree with the intention, but I'm a little uneasy blindly removing a whole subdirectory without warning: I'd add a confirmation prompt. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 30 12:20:35 2010 Received: (at 7756) by debbugs.gnu.org; 30 Dec 2010 17:20:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYMB1-0004yT-1u for submit@debbugs.gnu.org; Thu, 30 Dec 2010 12:20:35 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYMAy-0004yH-Gx for 7756@debbugs.gnu.org; Thu, 30 Dec 2010 12:20:33 -0500 Received: by iyi42 with SMTP id 42so9996226iyi.3 for <7756@debbugs.gnu.org>; Thu, 30 Dec 2010 09:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :reply-to:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=gVKKu8RlXVzquyiEFuFMhPk9qeSkxErumZXmfOKvIL4=; b=IVVIL4bYn0ERVmlyJlODetGpG0pp1ftOJTUv9cVDg5aQqWQrsCH02CrAtFQjorQoPp xdLaIThancgurWyGEiQyu0alxVOvrinTFBJKSZbesA021CORmR5/if+652zalRy5TrHQ 5SDogSzOJD8AIjviwgxFPS1+gs3FmnnO74rxQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:reply-to:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=mpp12CapNW0J7uxRjdvXKOnGtnicoit+XfaebFR4FUmYUKqQYjKL3w9yYpU2utPRnW QxiOWKQ19FHvkW6KnN+GgfxAtC13zOi3Nj6rWbeoig9Yl07aoRvKcnnB4oqZ7jj7A/CP OAJYMEj3+04jeUMsD7px5dNwceTf/VtHGhCVE= Received: by 10.42.178.73 with SMTP id bl9mr16715752icb.448.1293730048420; Thu, 30 Dec 2010 09:27:28 -0800 (PST) Received: from dad-laptop (pool-96-225-218-44.ptldor.fios.verizon.net [96.225.218.44]) by mx.google.com with ESMTPS id z4sm14481063ibg.1.2010.12.30.09.27.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 30 Dec 2010 09:27:27 -0800 (PST) From: Richard Kim To: Stefan Monnier Subject: Re: bug#7756: 24.0.50; enhancements to package.el References: Date: Thu, 30 Dec 2010 09:27:24 -0800 In-Reply-To: (Stefan Monnier's message of "Thu, 30 Dec 2010 10:32:27 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: emacs18@gmail.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Stefan Monnier writes: >> @@ -338,9 +338,14 @@ >> (pkg-file (expand-file-name >> (concat (package-strip-version package) "-pkg") >> pkg-dir))) >> - (when (and (file-directory-p pkg-dir) >> - (file-exists-p (concat pkg-file ".el"))) >> - (load pkg-file nil t)))) >> + ;; When one is creating a package and testing it out, it is easy >> + ;; to forget to add the -pkg.el file. When that happens, it would >> + ;; be useful to provide feedback to the user rather than silently >> + ;; failing. That is what (error ...) below is for. >> + (when (file-directory-p pkg-dir) >> + (if (file-exists-p (concat pkg-file ".el")) >> + (load pkg-file nil t) >> + (error "'%s' file is missing!"))))) > > I agree with the intention, but I wonder: why do we pass the `noerror' > parameter to `load' in the first place? Hi Stefan, Thanks for looking into this. I was focused in adding the error message and neglected to re-examine the arguments to `load', i.e., I just kept the existing code. I suppose it was used before my proposed change to prevent signalling error if the file was not found. With the proposed change, since we check for the existence of the file prior to calling `load', I suppose it is appropriate to no longer pass `noerror'. Good catch. Also I'm sure you have noticed that I forgot to add `pkg-file' argument to (error ...) expression above. >> @@ -569,8 +574,16 @@ >> (defun package-unpack (name version) >> (let ((pkg-dir (expand-file-name (concat (symbol-name name) "-" version) >> package-user-dir))) >> + ;; Delete the package directory if it exists already. This may >> + ;; not be useful to the end users. However this is extremely >> + ;; important for package developers as they experiment with which >> + ;; files to include in a package. If a file is removed from one >> + ;; iteration to the next, then the presence of the unwanted elisp >> + ;; file could cause problems by polluting the generated autoload >> + ;; file. >> + (if (file-directory-p pkg-dir) >> + (delete-directory pkg-dir 'recursive)) > > Here, I also agree with the intention, but I'm a little uneasy blindly > removing a whole subdirectory without warning: I'd add a confirmation prompt. I agree with your concern. A confirmation prompt seems to be a good idea. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 31 11:39:16 2010 Received: (at 7756) by debbugs.gnu.org; 31 Dec 2010 16:39:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYi0Z-0003Q9-2C for submit@debbugs.gnu.org; Fri, 31 Dec 2010 11:39:15 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PYi0X-0003Pv-D7 for 7756@debbugs.gnu.org; Fri, 31 Dec 2010 11:39:14 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmkFAB+XHU3O+Lc+/2dsb2JhbACWII4cdL5vhUoEhGWOGw X-IronPort-AV: E=Sophos;i="4.60,255,1291611600"; d="scan'208";a="86841610" Received: from 206-248-183-62.dsl.teksavvy.com (HELO pastel.home) ([206.248.183.62]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 31 Dec 2010 11:46:11 -0500 Received: by pastel.home (Postfix, from userid 20848) id 86D6758A74; Fri, 31 Dec 2010 11:46:11 -0500 (EST) From: Stefan Monnier To: emacs18@gmail.com Subject: Re: bug#7756: 24.0.50; enhancements to package.el Message-ID: References: Date: Fri, 31 Dec 2010 11:46:11 -0500 In-Reply-To: (Richard Kim's message of "Thu, 30 Dec 2010 09:27:24 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) >>> @@ -338,9 +338,14 @@ >>> (pkg-file (expand-file-name >>> (concat (package-strip-version package) "-pkg") >>> pkg-dir))) >>> - (when (and (file-directory-p pkg-dir) >>> - (file-exists-p (concat pkg-file ".el"))) >>> - (load pkg-file nil t)))) >>> + ;; When one is creating a package and testing it out, it is easy >>> + ;; to forget to add the -pkg.el file. When that happens, it would >>> + ;; be useful to provide feedback to the user rather than silently >>> + ;; failing. That is what (error ...) below is for. >>> + (when (file-directory-p pkg-dir) >>> + (if (file-exists-p (concat pkg-file ".el")) >>> + (load pkg-file nil t) >>> + (error "'%s' file is missing!"))))) >> >> I agree with the intention, but I wonder: why do we pass the `noerror' >> parameter to `load' in the first place? > Thanks for looking into this. > I was focused in adding the error message and neglected to re-examine > the arguments to `load', i.e., I just kept the existing code. I suppose > it was used before my proposed change to prevent signalling error if the > file was not found. With the proposed change, since we check for the > existence of the file prior to calling `load', I suppose it is > appropriate to no longer pass `noerror'. Good catch. Also I'm sure you > have noticed that I forgot to add `pkg-file' argument to (error ...) > expression above. Right, so a simpler way to make the change is to not add an explicit check but instead just remove the `noerror' argument. So your patch is apparently changing a consciously made decision to ignore errors. I tend to agree with the change, but I'd first understand why someone decided to ignore those error. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 19:56:29 2019 Received: (at 7756) by debbugs.gnu.org; 14 Sep 2019 23:56:29 +0000 Received: from localhost ([127.0.0.1]:47225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Hu0-0008TY-Mx for submit@debbugs.gnu.org; Sat, 14 Sep 2019 19:56:29 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:35943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Htx-0008TH-Ul for 7756@debbugs.gnu.org; Sat, 14 Sep 2019 19:56:26 -0400 Received: by mail-pg1-f196.google.com with SMTP id m29so927147pgc.3 for <7756@debbugs.gnu.org>; Sat, 14 Sep 2019 16:56:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=TGumVwVs11QROVYhgNxCWG+fCb3fk7XlFDlyM93oyoo=; b=JfGBEKbPLFr/empatBamZcDt/epF4l2qbpCLOUm/Yss4fTcYQVsDDtP/Ujl20zzHiL qr1YgzVvUChBTWW4Jkni3m8nvUIK/TYX3z6BSP3La5l1Sp1lcthZWg7OVOea+dpV/gU1 BcsWB2GedIbxdadb4I60fph/xNyv1+0qRklY6FWivH4KsKzVfPvkf3SI6MdzVtLWDiEM Mt+CVjw8llytMWoTaWfPFJW64Ieadd8h8bc9kuQn7kpTSFmqhJsLchSOy6sovvMhN9wO hoOMrH5tDLnt8VUqxjvT049UzWtJlTxRqAZxcDXM0RzLxO+6BiQ5LYQNpJuLV3Df+J1L 8hWQ== X-Gm-Message-State: APjAAAVLxzqXlUlL+KUGk8JPZxE7zLLn3y0DUK5T+W+iy/4mJcF1zXnq AoKBR4gkq3MAKR24xVjzOdW7xG3mEiD0FVvU3z0= X-Google-Smtp-Source: APXvYqyMGTcm6svs2meKFL7pwW5V6spba0R4jfuVglndOE5lvBicgX3eWUxAnUzPc9eEL2ZSe7VbIabvSo9xN8BPdgw= X-Received: by 2002:aa7:8156:: with SMTP id d22mr37006132pfn.190.1568505379922; Sat, 14 Sep 2019 16:56:19 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 15 Sep 2019 01:56:08 +0200 Message-ID: Subject: Re: bug#7756: 24.0.50; enhancements to package.el To: Stefan Monnier Content-Type: multipart/mixed; boundary="000000000000ffd60e05928c1df2" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org, Richard Kim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ffd60e05928c1df2 Content-Type: text/plain; charset="UTF-8" Stefan Monnier writes: >> @@ -338,9 +338,14 @@ >> (pkg-file (expand-file-name >> (concat (package-strip-version package) "-pkg") >> pkg-dir))) >> - (when (and (file-directory-p pkg-dir) >> - (file-exists-p (concat pkg-file ".el"))) >> - (load pkg-file nil t)))) >> + ;; When one is creating a package and testing it out, it is easy >> + ;; to forget to add the -pkg.el file. When that happens, it would >> + ;; be useful to provide feedback to the user rather than silently >> + ;; failing. That is what (error ...) below is for. >> + (when (file-directory-p pkg-dir) >> + (if (file-exists-p (concat pkg-file ".el")) >> + (load pkg-file nil t) >> + (error "'%s' file is missing!"))))) > > I agree with the intention, but I wonder: why do we pass the `noerror' > parameter to `load' in the first place? This code seems to have changed substantially since this patch was proposed in 2010. Having looked at it now, I think naively raising an error here would risk breaking things. I therefore suggest to do nothing here for now. >> @@ -569,8 +574,16 @@ >> (defun package-unpack (name version) >> (let ((pkg-dir (expand-file-name (concat (symbol-name name) "-" version) >> package-user-dir))) >> + ;; Delete the package directory if it exists already. This may >> + ;; not be useful to the end users. However this is extremely >> + ;; important for package developers as they experiment with which >> + ;; files to include in a package. If a file is removed from one >> + ;; iteration to the next, then the presence of the unwanted elisp >> + ;; file could cause problems by polluting the generated autoload >> + ;; file. >> + (if (file-directory-p pkg-dir) >> + (delete-directory pkg-dir 'recursive)) > > Here, I also agree with the intention, but I'm a little uneasy blindly > removing a whole subdirectory without warning: I'd add a confirmation prompt. I have attached a patch which does the same but adds a confirmation prompt. I've also added a test case for this particular case. WDYT? Best regards, Stefan Kangas --000000000000ffd60e05928c1df2 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Prompt-to-delete-duplicate-package-directory-on-inst.patch" Content-Disposition: attachment; filename="0001-Prompt-to-delete-duplicate-package-directory-on-inst.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0k7jkxo0 RnJvbSBiMTk2Mjg5OGRhYzRjODljNThkYjA2NmY1OThiNjU2YmE0MmY4ODA3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTdW4sIDE1IFNlcCAyMDE5IDAxOjQ5OjM3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UHJvbXB0IHRvIGRlbGV0ZSBkdXBsaWNhdGUgcGFja2FnZSBkaXJlY3Rvcnkgb24gaW5zdGFsbAoK KiBsaXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCAocGFja2FnZS11bnBhY2spOiBQcm9tcHQgdG8g ZGVsZXRlCnBhY2thZ2UgZGlyZWN0b3J5IGlmIGl0IGFscmVhZHkgZXhpc3RzLiAgKEJ1ZyM3NzU2 KQoKKiB0ZXN0L2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLXRlc3RzLmVsCihwYWNrYWdlLXRlc3Qt aW5zdGFsbC1tdWx0aS1maWxlL3BrZy1kaXItYWxyZWFkeS1leGlzdHMpOiBOZXcgdGVzdApjYXNl IGZvciBpbnN0YWxsYXRpb24gd2hlbiBwYWNrYWdlIGRpcmVjdG9yeSBhbHJlYWR5IGV4aXN0cy4K KHdpdGgtcGFja2FnZS10ZXN0KTogU3VwcG9ydCBhYm92ZSB0ZXN0IGNhc2UuCi0tLQogbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwgICAgICAgICAgICB8ICA2ICsrKysrLQogdGVzdC9saXNwL2Vt YWNzLWxpc3AvcGFja2FnZS10ZXN0cy5lbCB8IDEyICsrKysrKysrKysrLQogMiBmaWxlcyBjaGFu Z2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av ZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKaW5kZXgg ZWYwYzUxNzFkZS4uMmFjMDdiYzA1NSAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL3BhY2th Z2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAgLTg4OCw3ICs4ODgsMTEg QEAgcGFja2FnZS11bnBhY2sKICAgICAgICAgICAgICAgIChpZiAoPiAobGVuZ3RoIGZpbGUtbGlz dCkgMSkgJ3RhciAnc2luZ2xlKSkpKQogICAgICAgKCd0YXIKICAgICAgICAobWFrZS1kaXJlY3Rv cnkgcGFja2FnZS11c2VyLWRpciB0KQotICAgICAgIDs7IEZJWE1FOiBzaG91bGQgd2UgZGVsZXRl IFBLRy1ESVIgaWYgaXQgZXhpc3RzPworICAgICAgICh3aGVuIChhbmQgKGZpbGUtZGlyZWN0b3J5 LXAgcGtnLWRpcikKKyAgICAgICAgICAgICAgICAgICh5ZXMtb3Itbm8tcAorICAgICAgICAgICAg ICAgICAgIChmb3JtYXQgIlBhY2thZ2UgZGlyZWN0b3J5IGFscmVhZHkgZXhpc3RzOiBgJXMnLiAg RGVsZXRlIGl0PyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlY3RvcnktZmlsZS1u YW1lIHBrZy1kaXIpKSkpCisgICAgICAgICAoZGVsZXRlLWRpcmVjdG9yeSBwa2ctZGlyICdyZWN1 cnNpdmUpKQogICAgICAgIChsZXQqICgoZGVmYXVsdC1kaXJlY3RvcnkgKGZpbGUtbmFtZS1hcy1k aXJlY3RvcnkgcGFja2FnZS11c2VyLWRpcikpKQogICAgICAgICAgKHBhY2thZ2UtdW50YXItYnVm ZmVyIGRpcm5hbWUpKSkKICAgICAgICgnc2luZ2xlCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZW1h Y3MtbGlzcC9wYWNrYWdlLXRlc3RzLmVsIGIvdGVzdC9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS10 ZXN0cy5lbAppbmRleCBjNzU3YmNjZjY3Li5mZmUwNGU4ZmU3IDEwMDY0NAotLS0gYS90ZXN0L2xp c3AvZW1hY3MtbGlzcC9wYWNrYWdlLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lbWFjcy1saXNw L3BhY2thZ2UtdGVzdHMuZWwKQEAgLTEwOSw3ICsxMDksOCBAQCB3aXRoLXBhY2thZ2UtdGVzdAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluc3RhbGwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NhdGlvbgogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVwZGF0ZS1uZXdzCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdXBsb2FkLWJhc2UpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdXBsb2FkLWJhc2UKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjcmVhdGUtZGlyZWN0b3J5KQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAmcmVzdCBib2R5KQogICAiU2V0IHVwIHRlbXBvcmFy eSBsb2NhdGlvbnMgYW5kIHZhcmlhYmxlcyBmb3IgdGVzdGluZy4iCiAgIChkZWNsYXJlIChpbmRl bnQgMSkgKGRlYnVnICgoWyZyZXN0IGZvcm1dKSBib2R5KSkpCkBAIC0xMzgsNiArMTM5LDkgQEAg d2l0aC1wYWNrYWdlLXRlc3QKICAgICAgICAgICAgLChpZiBiYXNlZGlyIGAoY2QgLGJhc2VkaXIp KQogICAgICAgICAgICAodW5sZXNzIChmaWxlLWRpcmVjdG9yeS1wIHBhY2thZ2UtdXNlci1kaXIp CiAgICAgICAgICAgICAgKG1rZGlyIHBhY2thZ2UtdXNlci1kaXIpKQorICAgICAgICAgICAsKGlm IGNyZWF0ZS1kaXJlY3RvcnkKKyAgICAgICAgICAgICAgICBgKG1ha2UtZGlyZWN0b3J5IChleHBh bmQtZmlsZS1uYW1lICxjcmVhdGUtZGlyZWN0b3J5CisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYWNrYWdlLXRlc3QtdXNlci1kaXIpIHQpKQogICAg ICAgICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ3llcy1vci1uby1wKSAobGFtYmRh ICgmcmVzdCByKSB0KSkKICAgICAgICAgICAgICAgICAgICAgICgoc3ltYm9sLWZ1bmN0aW9uICd5 LW9yLW4tcCkgICAgKGxhbWJkYSAoJnJlc3QgcikgdCkpKQogICAgICAgICAgICAgICxAKHdoZW4g aW5zdGFsbApAQCAtMzQ0LDYgKzM0OCwxMiBAQCBwYWNrYWdlLXRlc3QtaW5zdGFsbC1tdWx0aWZp bGUKICAgICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQogICAgICAgICAgIChzaG91bGQg KHJlLXNlYXJjaC1mb3J3YXJkIHJlIG5pbCB0KSkpKSkpKQogCisoZXJ0LWRlZnRlc3QgcGFja2Fn ZS10ZXN0LWluc3RhbGwtbXVsdGktZmlsZS9wa2ctZGlyLWFscmVhZHktZXhpc3RzICgpCisgICJJ bnN0YWxsIG11bHRpLWZpbGUgcGFja2FnZSBvdmVyIGFscmVhZHkgZXhpc3RpbmcgZGlyZWN0b3J5 LiIKKyAgKHdpdGgtcGFja2FnZS10ZXN0ICg6YmFzZWRpciAicGFja2FnZS1yZXNvdXJjZXMiIDpp bnN0YWxsICcobXVsdGktZmlsZSkKKyAgICAgICAgICAgICAgICAgICAgICA6Y3JlYXRlLWRpcmVj dG9yeSAibXVsdGktZmlsZS0wLjIuMyIpCisgICAgKHNob3VsZCAocGFja2FnZS1pbnN0YWxsZWQt cCAnbXVsdGktZmlsZSkpKSkKKwogKGVydC1kZWZ0ZXN0IHBhY2thZ2UtdGVzdC11cGRhdGUtbGlz dGluZyAoKQogICAiRW5zdXJlIGluc3RhbGxlZCBwYWNrYWdlIHN0YXR1cyBpcyB1cGRhdGVkLiIK ICAgKHdpdGgtcGFja2FnZS10ZXN0ICgpCi0tIAoyLjIwLjEKCg== --000000000000ffd60e05928c1df2-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 19:56:36 2019 Received: (at control) by debbugs.gnu.org; 14 Sep 2019 23:56:36 +0000 Received: from localhost ([127.0.0.1]:47228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Hu8-0008Tr-4C for submit@debbugs.gnu.org; Sat, 14 Sep 2019 19:56:36 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:46327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i9Hu5-0008TX-Sp for control@debbugs.gnu.org; Sat, 14 Sep 2019 19:56:34 -0400 Received: by mail-pg1-f179.google.com with SMTP id m3so17163274pgv.13 for ; Sat, 14 Sep 2019 16:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=GC9UJ1Bi7n8K+JXu1apcJyB4Heb2hjt3qRWDCasdUYY=; b=phsnlphEAF5MhIFYmIrs7iVuTNuHyinb1ifKY04S6BZi41oVddB26iTsTAStPkqD6X e25Pzgy53TFCZsK/axJIb/MaPywX1r1Qim+pjp/IqIBZfJbkSTTQUK5OQ8rvVLbh99eR XNCa89YmoRhbQ+BOttfrr0Ac7h/eU2JpoLsq6rRK5ZFsoTTAn4Rc/OlUZaEF9j3i6Zjd mpHP7p8gktFSowrEtZBxfSECuyOFyAqqcq3n1AEqqr7dDXzSRUG/ZbAWcckbNz+5R7El bTeUmJmaqOxhLuDpIlDmqTHLy+NdXj5aNcb8TEOVYcOld/j8kNtMK9eZhPOLnpLNTsk0 DILg== X-Gm-Message-State: APjAAAVTknDGhXnPWK547b+5C6N6AyKBYRhaKPky8MTfKuEeAg3C3fuk T8tBjA0aO5rn4/TjJMejmVkbRsuSMFNUmg/9vr+dnrcV X-Google-Smtp-Source: APXvYqyATcrHX5b3/y8vPIZTawrZA1oDSXQHpwr1zzRR011qqgBkBr7kn37eDp1FxxO/g6qBisXTKeP0TdT2GuOgpQQ= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr52352591pgl.333.1568505387945; Sat, 14 Sep 2019 16:56:27 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sun, 15 Sep 2019 01:56:17 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 7756 + patch quit Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.215.179 listed in list.dnswl.org] 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.215.179 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 BLANK_SUBJECT Subject is present but empty 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 7756 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 08:35:56 2019 Received: (at 7756) by debbugs.gnu.org; 23 Nov 2019 13:35:56 +0000 Received: from localhost ([127.0.0.1]:55992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVZr-0004hY-NN for submit@debbugs.gnu.org; Sat, 23 Nov 2019 08:35:55 -0500 Received: from quimby.gnus.org ([95.216.78.240]:36266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVZo-0004hJ-IG for 7756@debbugs.gnu.org; Sat, 23 Nov 2019 08:35:52 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iYVZg-0005l4-8D; Sat, 23 Nov 2019 14:35:46 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#7756: 24.0.50; enhancements to package.el References: Date: Sat, 23 Nov 2019 14:35:43 +0100 In-Reply-To: (Stefan Kangas's message of "Sun, 15 Sep 2019 01:56:08 +0200") Message-ID: <87imnan2a8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > - ; ; FIXME: should we delete PKG-DIR if it exists? > + (when (and (file-directory-p pkg-dir) > + (yes-or-no-p > + (format "Package directory already exists: `%s'. Delete it?" > + (directory-file-nam [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org, Richard Kim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > - ;; FIXME: should we delete PKG-DIR if it exists? > + (when (and (file-directory-p pkg-dir) > + (yes-or-no-p > + (format "Package directory already exists: `%s'. Delete it?" > + (directory-file-name pkg-dir)))) > + (delete-directory pkg-dir 'recursive)) I'm a bit uneasy about doing a recursive deletion of the directory, even after prompting (the developer may have put, well, anything in that directory), so I wonder whether the right fix here is to just remove the FIXME. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 08:45:58 2019 Received: (at 7756) by debbugs.gnu.org; 23 Nov 2019 13:45:58 +0000 Received: from localhost ([127.0.0.1]:56005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVjX-0004w8-KI for submit@debbugs.gnu.org; Sat, 23 Nov 2019 08:45:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYVjQ-0004vq-OT for 7756@debbugs.gnu.org; Sat, 23 Nov 2019 08:45:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iYVjL-0006Ya-5F; Sat, 23 Nov 2019 08:45:43 -0500 Received: from [176.228.60.248] (port=2627 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iYVjJ-0003zG-JO; Sat, 23 Nov 2019 08:45:42 -0500 Date: Sat, 23 Nov 2019 15:45:38 +0200 Message-Id: <8336eevh8d.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87imnan2a8.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 23 Nov 2019 14:35:43 +0100) Subject: Re: bug#7756: 24.0.50; enhancements to package.el References: <87imnan2a8.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 7756 Cc: emacs18@gmail.com, 7756@debbugs.gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Sat, 23 Nov 2019 14:35:43 +0100 > Cc: 7756@debbugs.gnu.org, Richard Kim , > Stefan Monnier > > I'm a bit uneasy about doing a recursive deletion of the directory, even > after prompting (the developer may have put, well, anything in that > directory), so I wonder whether the right fix here is to just remove the > FIXME. FWIW, I'm fine with deleting the FIXME. But I'm not a package developer, so perhaps my opinion isn't worth much. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:01:24 2019 Received: (at 7756) by debbugs.gnu.org; 26 Nov 2019 15:01:24 +0000 Received: from localhost ([127.0.0.1]:52702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZcLE-0002DJ-2D for submit@debbugs.gnu.org; Tue, 26 Nov 2019 10:01:24 -0500 Received: from mail-pl1-f171.google.com ([209.85.214.171]:32948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZcLC-0002D6-2V for 7756@debbugs.gnu.org; Tue, 26 Nov 2019 10:01:22 -0500 Received: by mail-pl1-f171.google.com with SMTP id ay6so8286202plb.0 for <7756@debbugs.gnu.org>; Tue, 26 Nov 2019 07:01:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pfC3gSW+Mb8HDa2WjPWG7hTSNmdUEsAaDun+31xOqSE=; b=qbSXgV7wmaE+PlG9Y0W89j6VpKg7zQoCdoWcF2NEbOkmH8Fm2HQWt6r1UFHbfOQs7q T3AC1S0e4FYpNYy3OQNor068j7Ol4OSnOIMmOC4dPjrg3EtJUWd/5vaRwgH3+GZjiTS9 BMkkzfPlSWA1eavwA3oeDFdABueL3k7r1ZtGe3Zjwjyn4wlKDTl8neNauMdpTiSwoNiG +c0Dwvm3b/jz59r16lyKTbZp090pfiTWPNM1QIlMOxuxTJDmvRrt4JxAeXHVzCusnS92 yhFYIE1R5AV592Q8kZgG6ZDntNNcwuz/l+qUhYXvqo1M/sR1IMT/koVa6U7e3s6r2uay PDXg== X-Gm-Message-State: APjAAAWP6zrP4SJQ/yS2a6IyjnIP50coQnH5It23SR/ump+wwXv+FniL wnlYbfu0ZsHEBeMArfkKjT7pU1HYI1YkgvxwjwE= X-Google-Smtp-Source: APXvYqz3JuG0apdVc/JzM6AYNlDqQr4J1mz7rZGBiXc9KanG6f5HTNwXUV8zOGfs97uvPthsyKHbeAizrobl2GtFhSY= X-Received: by 2002:a17:90a:a40f:: with SMTP id y15mr7639861pjp.106.1574780475943; Tue, 26 Nov 2019 07:01:15 -0800 (PST) MIME-Version: 1.0 References: <87imnan2a8.fsf@gnus.org> <8336eevh8d.fsf@gnu.org> In-Reply-To: <8336eevh8d.fsf@gnu.org> From: Stefan Kangas Date: Tue, 26 Nov 2019 16:01:04 +0100 Message-ID: Subject: Re: bug#7756: 24.0.50; enhancements to package.el To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 7756 Cc: 7756@debbugs.gnu.org, Lars Ingebrigtsen , Richard Kim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > > I'm a bit uneasy about doing a recursive deletion of the directory, even > > after prompting (the developer may have put, well, anything in that > > directory), so I wonder whether the right fix here is to just remove the > > FIXME. > > FWIW, I'm fine with deleting the FIXME. But I'm not a package > developer, so perhaps my opinion isn't worth much. Sounds good to me. I'll go ahead and do that in a couple of days if I see no objections. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 16 18:49:45 2020 Received: (at 7756-done) by debbugs.gnu.org; 16 Jan 2020 23:49:45 +0000 Received: from localhost ([127.0.0.1]:38607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isEtV-0001JZ-AQ for submit@debbugs.gnu.org; Thu, 16 Jan 2020 18:49:45 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:42072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1isEtT-0001JM-V3 for 7756-done@debbugs.gnu.org; Thu, 16 Jan 2020 18:49:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KkYuBcjxb/o5VBjx0BHV3bvGMjsRpmeBBuEbCRSCPy4=; b=OqlK/4t89wWFHDxSQIzT0kQAQD cD54z2bxw8PnYWY+6aOJvy7UxgNCsjZrQ7Fpx1RDnfXws2a+1kQ/eFM1n86Cw+RXUVCeJfVuokcik 4bGJW8vhrIwqH4hyUAf1ZeNLqAFuEa52vjBSz6bAYy16tkIy2Gz45g7F8hzojAfIbfA9XOVSoADLj De0PS2kWBa2jb5mAR4uu4dVohmyn7sIvZ8Ux9PC7C3TSnX7rj6K2x2dl0ifALyitNvyXH25RRsGxs n9/sQgnJ2vM3X+JWNJmKdR9KSI4Mhue3EHe/ocLrSsyLaO7bM/pxlGscqguuVi2QIpGr76nDeW2s/ wAmDCQ4Q==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:49482 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1isEtN-000Rtq-T1; Thu, 16 Jan 2020 18:49:38 -0500 From: Stefan Kangas To: Eli Zaretskii Subject: Re: bug#7756: 24.0.50; enhancements to package.el In-Reply-To: (Stefan Kangas's message of "Tue, 26 Nov 2019 16:01:04 +0100") References: <87imnan2a8.fsf@gnus.org> <8336eevh8d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Fri, 17 Jan 2020 00:49:36 +0100 Message-ID: <878sm72c8f.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 7756-done Cc: Lars Ingebrigtsen , 7756-done@debbugs.gnu.org, Richard Kim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Eli Zaretskii writes: > >> > I'm a bit uneasy about doing a recursive deletion of the directory, even >> > after prompting (the developer may have put, well, anything in that >> > directory), so I wonder whether the right fix here is to just remove the >> > FIXME. >> >> FWIW, I'm fine with deleting the FIXME. But I'm not a package >> developer, so perhaps my opinion isn't worth much. > > Sounds good to me. I'll go ahead and do that in a couple of days if I > see no objections. Now done on the master branch in commit f18c78e611. I see nothing more to do here, so I'm also closing this bug. Best regards, Stefan Kangas From unknown Fri Aug 15 04:07:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 14 Feb 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator