GNU bug report logs - #77552
[PATCH 0/5] gnu: cbqn: Update to 0.9.0.

Previous Next

Full log

Message #23 received at 77552 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: Lee Thompson <lee.p.thomp <at> gmail.com>
Cc: lee.p.thomp <at> gmail.com, 77552 <at> debbugs.gnu.org
Subject: Re: [bug#77552] [PATCH 5/5] gnu: cbqn: Update to 0.9.0.
Date: Wed, 09 Apr 2025 18:00:23 +0200

[Message part 1 (text/plain, inline)]

Please, use changelog format for changes in commit message.

See:

https://www.gnu.org/prep/standards/html_node/Change-Logs.html

-     (substitute-keyword-arguments (strip-keyword-arguments
-                                    (list #:tests?)
-                                    (package-arguments cbqn-bootstrap))
-       ((#:make-flags flags #~(list))
-        #~(cons* "shared-o3" "o3" #$flags))
-       ((#:phases phases #~%standard-phases)
+     (substitute-keyword-arguments (strip-keyword-arguments (list #:tests?)
+                                                            (package-arguments
+                                                             cbqn-bootstrap))
+       ((#:make-flags flags
+         #~(list))
+        #~(cons* "shared-o3" "o3"
+                 #$flags))
+       ((#:phases phases
+         #~%standard-phases)

Try to avoid unnecessary modifications in original code, this makes hard
to follow the contributions.

-                                         #+bqn-sources
-                                         "/test/this.bqn\""))
+                                         #+bqn-sources "/test/this.bqn\""))

Idem

-                (let* ((bin (string-append (assoc-ref outputs "out")
-                                           "/bin"))
-                       (lib (string-append (assoc-ref outputs "lib")
-                                           "/lib"))
+                (let* ((bin (string-append (assoc-ref outputs "out") "/bin"))
+                       (lib (string-append (assoc-ref outputs "lib") "/lib"))
                        (include (string-append (assoc-ref outputs "lib")
-                                           "/include")))
+                                               "/include")))

Again. You get the idea.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.