From unknown Thu Jun 19 16:24:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77551: Regression in macroexpand from a4ec9ca (April 1) Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2025 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ship Mints Cc: 77551@debbugs.gnu.org, stefankangas@gmail.com, monnier@iro.umontreal.ca X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Stefan Kangas , Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.174386037822597 (code B ref -1); Sat, 05 Apr 2025 13:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Apr 2025 13:39:38 +0000 Received: from localhost ([127.0.0.1]:42074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u13kI-0005sO-3W for submit@debbugs.gnu.org; Sat, 05 Apr 2025 09:39:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42790) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u13kF-0005s5-3J for submit@debbugs.gnu.org; Sat, 05 Apr 2025 09:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u13k7-0006yw-PX for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2025 09:39:28 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u13k5-0007o6-PT for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2025 09:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=53DRKeGKs1ader+l5tfzFWKCLenVBjWsu31BcHSlsQo=; b=wcVve7euHdx2vU8kdF1EfjH30e ESo0KZy0n31rklFXdJ3TS8SoBHllqQ0JULB/cviePHw2AEq5EAjpYOKRWlJQxVoAc6qCm+exqlDaW TTV5ppLmQWDle89nIZ/uYzl434YaF21lAYFo/Jpa770uPCtlVBDHAJHG0X60cLOR7oaA=; From: Daniel Mendler In-Reply-To: (Ship Mints's message of "Sat, 5 Apr 2025 09:23:41 -0400") References: Date: Sat, 05 Apr 2025 15:39:04 +0200 Message-ID: <87r026enif.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Ship Mints writes: > Below found in the wild expanding a macro from Daniel's marginalia package. > > Emacs 30 > (macroexpand-all '(foo bar)) -> (foo bar) > (macroexpand-all '((foo) bar)) -> ((foo) bar) > > master > (macroexpand-all '(foo bar)) -> (foo bar) > (macroexpand-all '((foo) bar)) -> signals an error > > Debugger entered--Lisp error: (wrong-type-argument symbolp (foo)) > signal(wrong-type-argument (symbolp (foo))) > function-get((foo) compiler-macro) > > Whether this is an intended or unintended consequence, I can't say, not > being a macro expert. To give some context - `function-get' and `function-put' have recently been changed to signal an error on non-symbol arguments in commit 4ec9ca12969018cdf15b8cc713b3ba054326f99 by Stefan Kangas. The problem is that the macro expander calls `function-get' on arbitrary values in function position. Daniel From unknown Thu Jun 19 16:24:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Daniel Mendler Subject: bug#77551: closed (Re: bug#77551: Regression in macroexpand from a4ec9ca (April 1)) Message-ID: References: <87a58uafap.fsf@daniel-mendler.de> <87r026enif.fsf@daniel-mendler.de> X-Gnu-PR-Message: they-closed 77551 X-Gnu-PR-Package: emacs Reply-To: 77551@debbugs.gnu.org Date: Sat, 05 Apr 2025 13:51:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1743861062-25044-1" This is a multi-part message in MIME format... ------------=_1743861062-25044-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #77551: Regression in macroexpand from a4ec9ca (April 1) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 77551@debbugs.gnu.org. --=20 77551: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D77551 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1743861062-25044-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 77551-done) by debbugs.gnu.org; 5 Apr 2025 13:50:15 +0000 Received: from localhost ([127.0.0.1]:42107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u13uY-0006TE-TV for submit@debbugs.gnu.org; Sat, 05 Apr 2025 09:50:15 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:43043 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u13uW-0006Oh-9r for 77551-done@debbugs.gnu.org; Sat, 05 Apr 2025 09:50:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yzjIMFbFwO/OB6n1Y0ld5AcZy5sJ+r0tBQE4+EdHJzs=; b=IrkbbguzmXgsL+yNW0moB3MOyR PU5P/QBd6tBLPBp4sh4a23YhK4+uO0AA+vgwVuNWCAEJgP2tLAoVhGlLVkH6JMZlvZmBt4iEVkKts zhHMy8eXUiBpG0nrtK1Bi6mgqsry0mSNKrE09y+gDVWRaIRaVyHHq1hlzf/8McMynRIs=; From: Daniel Mendler To: 77551-done@debbugs.gnu.org Subject: Re: bug#77551: Regression in macroexpand from a4ec9ca (April 1) In-Reply-To: <87r026enif.fsf@daniel-mendler.de> (Daniel Mendler's message of "Sat, 05 Apr 2025 15:39:04 +0200") References: <87r026enif.fsf@daniel-mendler.de> Date: Sat, 05 Apr 2025 15:50:06 +0200 Message-ID: <87a58uafap.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77551-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Daniel Mendler writes: > Ship Mints writes: > >> Below found in the wild expanding a macro from Daniel's marginalia package. >> >> Emacs 30 >> (macroexpand-all '(foo bar)) -> (foo bar) >> (macroexpand-all '((foo) bar)) -> ((foo) bar) >> >> master >> (macroexpand-all '(foo bar)) -> (foo bar) >> (macroexpand-all '((foo) bar)) -> signals an error >> >> Debugger entered--Lisp error: (wrong-type-argument symbolp (foo)) >> signal(wrong-type-argument (symbolp (foo))) >> function-get((foo) compiler-macro) >> >> Whether this is an intended or unintended consequence, I can't say, not >> being a macro expert. > > To give some context - `function-get' and `function-put' have recently > been changed to signal an error on non-symbol arguments in commit > 4ec9ca12969018cdf15b8cc713b3ba054326f99 by Stefan Kangas. The problem is > that the macro expander calls `function-get' on arbitrary values in > function position. > > Daniel The second bug report has been created accidentally. Closing. See bug#77550 instead. Daniel ------------=_1743861062-25044-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Apr 2025 13:39:38 +0000 Received: from localhost ([127.0.0.1]:42074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u13kI-0005sO-3W for submit@debbugs.gnu.org; Sat, 05 Apr 2025 09:39:38 -0400 Received: from lists.gnu.org ([2001:470:142::17]:42790) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u13kF-0005s5-3J for submit@debbugs.gnu.org; Sat, 05 Apr 2025 09:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u13k7-0006yw-PX for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2025 09:39:28 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u13k5-0007o6-PT for bug-gnu-emacs@gnu.org; Sat, 05 Apr 2025 09:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=53DRKeGKs1ader+l5tfzFWKCLenVBjWsu31BcHSlsQo=; b=wcVve7euHdx2vU8kdF1EfjH30e ESo0KZy0n31rklFXdJ3TS8SoBHllqQ0JULB/cviePHw2AEq5EAjpYOKRWlJQxVoAc6qCm+exqlDaW TTV5ppLmQWDle89nIZ/uYzl434YaF21lAYFo/Jpa770uPCtlVBDHAJHG0X60cLOR7oaA=; From: Daniel Mendler To: Ship Mints Subject: Re: Regression in macroexpand from a4ec9ca (April 1) In-Reply-To: (Ship Mints's message of "Sat, 5 Apr 2025 09:23:41 -0400") References: Date: Sat, 05 Apr 2025 15:39:04 +0200 Message-ID: <87r026enif.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a01:4f8:c012:9177::1; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Stefan Kangas , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Ship Mints writes: > Below found in the wild expanding a macro from Daniel's marginalia package. > > Emacs 30 > (macroexpand-all '(foo bar)) -> (foo bar) > (macroexpand-all '((foo) bar)) -> ((foo) bar) > > master > (macroexpand-all '(foo bar)) -> (foo bar) > (macroexpand-all '((foo) bar)) -> signals an error > > Debugger entered--Lisp error: (wrong-type-argument symbolp (foo)) > signal(wrong-type-argument (symbolp (foo))) > function-get((foo) compiler-macro) > > Whether this is an intended or unintended consequence, I can't say, not > being a macro expert. To give some context - `function-get' and `function-put' have recently been changed to signal an error on non-symbol arguments in commit 4ec9ca12969018cdf15b8cc713b3ba054326f99 by Stefan Kangas. The problem is that the macro expander calls `function-get' on arbitrary values in function position. Daniel ------------=_1743861062-25044-1--