GNU bug report logs - #7754
24.0.50; easy-menu: fix misnamed keywords

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7754 in the body.
You can then email your comments to 7754 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; easy-menu: fix misnamed keywords
Date: Wed, 29 Dec 2010 07:26:08 -0800

Easy-menu uses a non-standard :active keyword to mean what :enable means
in regular menus.  Similarly, it used to use :included to mean what
:visible means.  The latter inconsistency was fixed long ago, by
aliasing.  The former has never been fixed.
 
I see no conflict in the code - no reason not to just use :enable
(e.g. alias :active to :enable and ultimately deprecate :active).
 
From the `easy-menu-define' doc string (in two places, one for a "menu",
the other for an "item":
 
 :visible INCLUDE
 
 INCLUDE is an expression; this (menu|item) is only visible if this
 expression has a non-nil value.  `:included' is an alias for `:visible'.
 
 :active ENABLE
 
 ENABLE is an expression; the (menu|item) is enabled for selection
 whenever this expression's value is non-nil.
 
I see no reason to treat the misnamed :active any different from the
misnamed :included.
 
Note: I sent this request to emacs-devel on 2009-05-22, but got no
response.  Here is that mail:
 
> From: Drew Adams Sent: Friday, May 22, 2009 3:07 PM
> 
> Why does easymenu.el use :active instead of :enable? This 
> inconsistency just makes things more complex for users, without
> any gain (that I can see).
> 
> The code even translates :active to :enable! Why not just 
> accept :enable? And then perhaps we could sooner or later
> deprecate :active.
> 
> Shouldn't we just choose one or the other, :enable or 
> :active, and stick to it consistently?
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-12-20 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
 

Message #8 received at 7754 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <7754 <at> debbugs.gnu.org>
Subject: RE: bug#7754: 24.0.50; easy-menu: fix misnamed keywords
Date: Wed, 29 Dec 2010 09:02:10 -0800

Further browsing indicates that :active is a leftover from XEmacs.
E.g., this code in vhdl-mode.el:

["Rescan Directory" vhdl-speedbar-rescan-hierarchy
 :active (save-excursion (beginning-of-line) (looking-at "[0-9]+:"))
 ,(if (featurep 'xemacs) :active :visible) (not vhdl-speedbar-show-projects)]
      ^^^^^^^^^^^^^^^^^^^^^^^^^^

Message #11 received at 7754 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 7754 <at> debbugs.gnu.org
Subject: Re: bug#7754: 24.0.50; easy-menu: fix misnamed keywords
Date: Thu, 13 Jan 2011 21:14:00 -0500

close 7754
thanks

> Easy-menu uses a non-standard :active keyword to mean what :enable means
> in regular menus.  Similarly, it used to use :included to mean what
> :visible means.  The latter inconsistency was fixed long ago, by
> aliasing.  The former has never been fixed.
 
Fixed, thanks,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.