Subject: Re: [bug#77525] [PATCH v4 2/6] system: /etc/profile: Rearrange to avoid search path duplication.

From: Ludovic Courtès <[email-masked]>
Date: Mon, 14 Apr 2025 17:12:12 +0200

Hi Hilton,

(Cc: 宋文武.)

Hilton Chain <[email-masked]> writes:

> * gnu/system.scm (operating-system-etc-service)[profile]: Set umask first.
> Group environment variables setup with profile sourcing to avoid duplication.
> Export $GUILE_LOAD_PATH and $GUILE_LOAD_COMPILED_PATH for ‘guix pull’ profile.
> * gnu/system/shadow.scm (%default-bash-profile): Remove duplicated exports.

The last item does not say the whole story:

> +++ b/gnu/system/shadow.scm
> @@ -179,16 +179,6 @@ (define %default-bash-profile
>  
>  # Honor per-interactive-shell startup file
>  if [ -f ~/.bashrc ]; then . ~/.bashrc; fi
> -
> -# Merge search-paths from multiple profiles, the order matters.
> -eval \"$(guix package --search-paths \\
> --p $HOME/.config/guix/current \\
> --p $HOME/.guix-home/profile \\
> --p $HOME/.guix-profile \\
> --p /run/current-system/profile)\"
> -
> -# Prepend setuid programs.
> -export PATH=/run/setuid-programs:$PATH
>  "))

I am the one who suggested to not invoke ‘guix package’ from shell
startup files:

  https://issues.guix.gnu.org/77035#8-lineno17

However, I hadn’t realized that this had previously been introduced by
宋文武 in commit 40310efde9b4a4f2cf98081d6cd10f843685ebb6.

Since this patch essentially reverts this commit, could you share your
thoughts on this, 宋文武?

Thanks,
Ludo’.