From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 23:23:57 2025 Received: (at submit) by debbugs.gnu.org; 4 Apr 2025 03:23:57 +0000 Received: from localhost ([127.0.0.1]:36548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0Xev-0002bP-9Z for submit@debbugs.gnu.org; Thu, 03 Apr 2025 23:23:57 -0400 Received: from lists.gnu.org ([2001:470:142::17]:32952) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0Xes-0002aK-15 for submit@debbugs.gnu.org; Thu, 03 Apr 2025 23:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0Xem-0006tY-NZ for guix-patches@gnu.org; Thu, 03 Apr 2025 23:23:48 -0400 Received: from mx.boiledscript.com ([88.99.243.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0Xel-0002is-0o for guix-patches@gnu.org; Thu, 03 Apr 2025 23:23:48 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1743737025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Klkhi6hIObdEXUoc1WrSi6YuLCRK/lw5odfrGdGnLQ=; b=iJeElmZWjhtwr0uefZ0SmUGJ5X7lpagswx4NJ0VJPGHbXmsPrJ/Fx9Q5G4aoRjK/Hi+JG4 RjOF1yewbHXGCRTPcaLe0/kwcLVSIrzJMpH5aCDB+I23dyqRpy4xZIEJ30CcQuHaAS2/Lx LZO6eAsq2TgVc8AoRGMZ1DM9KwNYcW9gdJSEuT0sQ0VqzPG6v4UlhxBq6atXMwQsh39y2H 9B78nh3h+wdS2/gvSaAXKhwWmQYZu+P8u8j3+F01kcOALU751SLTVH7sbPaVYiGBdb6Phi TeNJxIweAPXpF4WCYJiIx0CUlEs+NbHcOwfVpxxTSq+da8CbxTF7YYcNrzpCdg== To: guix-patches@gnu.org Subject: [PATCH v4 5/6] guix-install.sh: Group profile sourcing. Date: Fri, 4 Apr 2025 11:23:02 +0800 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=88.99.243.112; envelope-from=hako@ultrarare.space; helo=mx.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * etc/guix-install.sh (sys_create_init_profile): Group sourcing of all default profiles. Change-Id: Ia443b78a5ba656b7d03e1abbba53c4bf1240e338 --- etc/guix-install.sh | 69 +++++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 31 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index b5d833cd64..f0d37bc384 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -749,47 +749,54 @@ export XDG_CONFIG_DIRS="${XDG_CONFIG_DIRS:-/etc/xdg}" export XDG_CACHE_HOME="${XDG_CACHE_HOME:-$HOME/.cache}" # no default for XDG_RUNTIME_DIR (depends on foreign distro for semantics) -# `guix pull` profile -GUIX_PROFILE="$HOME/.config/guix/current" -export PATH="$GUIX_PROFILE/bin${PATH:+:}$PATH" -# Add to INFOPATH and MANPATH so the latest Guix documentation is available to -# info and man readers. When INFOPATH is unset, add a trailing colon so Emacs -# searches 'Info-default-directory-list'. When MANPATH is unset, add a -# trailing colon so the system default search path is used. -export INFOPATH="$GUIX_PROFILE/share/info:$INFOPATH" -export MANPATH="$GUIX_PROFILE/share/man:$MANPATH" -# Expose the latest Guix modules to Guile so guix shell and repls spawned by -# e.g. Geiser work out of the box. -export GUILE_LOAD_PATH="$GUIX_PROFILE/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH" -export GUILE_LOAD_COMPILED_PATH="$GUIX_PROFILE/lib/guile/3.0/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH" - -# User's default profile, if it exists -GUIX_PROFILE="$HOME/.guix-profile" -if [ -L "$GUIX_PROFILE" ]; then - . "$GUIX_PROFILE/etc/profile" - - # see info '(guix) Application Setup' - export GUIX_LOCPATH="$GUIX_PROFILE/lib/locale${GUIX_LOCPATH:+:}$GUIX_LOCPATH" - - # Documentation search paths may be handled by $GUIX_PROFILE/etc/profile if - # the user installs info and man readers via Guix. If the user doesn’t, - # explicitly add to them so documentation for software from ‘guix install’ - # is available to the system info and man readers. +# Set up environment for all default profiles. +for GUIX_PROFILE in "$HOME/.guix-home/profile" \ + "$HOME/.guix-profile" \ + "$HOME/.config/guix/current" +do + if [ -f "$GUIX_PROFILE/etc/profile" ]; then + . "$GUIX_PROFILE/etc/profile" + if [ ! \"$GUIX_PROFILE\" = \"$HOME/.config/guix/current\" ]; then + # See info '(guix) Application Setup'. + case $GUIX_LOCPATH in + *GUIX_PROFILE/lib/locale*) ;; + *) export GUIX_LOCPATH="$GUIX_PROFILE/lib/locale${GUIX_LOCPATH:+:}$GUIX_LOCPATH" ;; + esac + fi + fi + if [ \"$GUIX_PROFILE\" = \"$HOME/.config/guix/current\" ]; then + # Expose the latest Guix modules to Guile so guix shell and repls spawned by + # e.g. Geiser work out of the box. + case $GUILE_LOAD_PATH in + *$GUIX_PROFILE/share/guile/site/3.0*) ;; + *) export GUILE_LOAD_PATH=\"$GUIX_PROFILE/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH\" ;; + esac + case $GUILE_LOAD_COMPILED_PATH in + *$GUIX_PROFILE/lib/guile/3.0/site-ccache*) ;; + *) export GUILE_LOAD_COMPILED_PATH=\"$GUIX_PROFILE/lib/guile/3.0/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH\" ;; + esac + fi + # Make basic things just work when the user installs their first package. + case $PATH in + *$GUIX_PROFILE/bin*) ;; + *) export PATH="$GUIX_PROFILE/bin${PATH:+:}$PATH" ;; + esac + # Add to INFOPATH and MANPATH so the latest Guix documentation is available to + # info and man readers. When INFOPATH is unset, add a trailing colon so Emacs + # searches 'Info-default-directory-list'. When MANPATH is unset, add a + # trailing colon so the system default search path is used. case $INFOPATH in *$GUIX_PROFILE/share/info*) ;; *) export INFOPATH="$GUIX_PROFILE/share/info:$INFOPATH" ;; esac case $MANPATH in *$GUIX_PROFILE/share/man*) ;; - *) export MANPATH="$GUIX_PROFILE/share/man:$MANPATH" + *) export MANPATH="$GUIX_PROFILE/share/man:$MANPATH" ;; esac -fi +done # NOTE: Guix Home handles its own profile initialization in ~/.profile. See # info '(guix) Configuring the Shell'. - -# Clean up after ourselves. -unset GUIX_PROFILE EOF } -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 23:27:03 2025 Received: (at control) by debbugs.gnu.org; 4 Apr 2025 03:27:04 +0000 Received: from localhost ([127.0.0.1]:36580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0Xhv-0002oo-Bz for submit@debbugs.gnu.org; Thu, 03 Apr 2025 23:27:03 -0400 Received: from mx.boiledscript.com ([2a01:4f8:10b:392::42]:47190) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0Xhr-0002oL-Ek for control@debbugs.gnu.org; Thu, 03 Apr 2025 23:27:00 -0400 Date: Fri, 04 Apr 2025 11:26:02 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1743737217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=1cb6Pxl7vmZdVWKjwiEtbTf2vtKoBRAoWds+NG/Amsw=; b=LkIp6WkNK5NOiyZhomWJTqWD6aHdo7i/tJW1qI40rFJ8dTTeeydesXZTyT5zMNiEJCBvpZ 8TFSzdwfiZqPT+Hjp1cVB2p9YdCLNxn2BFoUJohIMhtqtVnBQVsBpoHRO5FIAnq9xZ+JoV 4glte2IjroLB7xg2E12QlgY23cOauNUvRPakKeRI6KgEtJ9hMbpWrbGHBaMU37pWKvFMqR zKC+Ut6PRH6rw6IfBs4wmDGOCaaxCJtwEuLstPS+TcO9ubmaoQMk0oUO0rdk7CUkXi2sf8 8k7rcfdCenQkmSS81LKAgfFtGOH3fMvirUDtiNHOzJ4gIwDE2F710GQJIFZpbQ== Message-ID: <87plhsppyt.wl-hako@ultrarare.space> From: Hilton Chain To: control@debbugs.gnu.org Subject: Control message MIME-Version: 1.0 X-MS-Reactions: disallow Content-Type: text/plain; charset=US-ASCII X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 77035 77522 77523 77524 77525 77526 77527 77528 quit From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 18 22:40:46 2025 Received: (at 77527) by debbugs.gnu.org; 19 Apr 2025 02:40:47 +0000 Received: from localhost ([127.0.0.1]:54283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5y8K-0003E7-3D for submit@debbugs.gnu.org; Fri, 18 Apr 2025 22:40:46 -0400 Received: from mail.envs.net ([5.199.136.28]:41716) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5y8F-0003D9-VR for 77527@debbugs.gnu.org; Fri, 18 Apr 2025 22:40:41 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 7628B38A409F; Sat, 19 Apr 2025 02:40:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1745030438; bh=eLsOvB0g81otifzmDFi+waVky7WTw87oflkh5FDYLis=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=eSyv5+yQe0O9WTn9zeBn9plKQL/6xaFYzY7KE5yZsj8vMg+77DnfsT7t6ZrgkGcfX G7fcsjFvVuBh5Jy+s5nHB/k2MVb72Igx8VOn8Nm2D9R/XA6CdnA7SoEAjLxEB1d03i qLMwIGhTf7VX2KjTK+nm8ZT5uwIxlYsYf716VtdDq9aMHGF+phlOI8yZ3/CSvh13M1 MqP3m4CTurfuBmlGGnHnAIiemfmaLNVScwexombGnZ7T/2zIMBQ39or9v4wDaDL2U8 iN2r1sdr0XOuBKrUMnra+NfJiCb69lMKWlgpY1c3oULy2t07sjvGlgOVAxs+gNg5xS qd1hINFS62dU3NJWG8DXLuGJ1Ve6q9vXasqgTEiN4qyyCdQW0qPeGt3DmbENQJYy1j XWau2zkKzUCXieA3bbIwFBMbTpH3XewYGLB/jAOGcbPpvlDoEudvyFqmxqtEDgW+ZN xgkVwGj5EqlorZ+mBOdm4fSZxutYUc3avpTGVK+fOObhUMI69qlBsZ1iajc8foYpiz uzlJOv4SzRQrF87FrThRRYWYaHxf/rD0Y8tlnQDo/B7QajA/nUDXDdVTOIyXwtm7Wh 3acTLhbrWzGzuNOlh/l4g3z+kpFmHtd3denoFBGCNF9fL6ZtEE142RXYCj8NYGKiV9 5AvDTxUb55QLbZ0VSTGAxvUk= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AE4_Qun86Scb; Sat, 19 Apr 2025 02:40:35 +0000 (UTC) Received: from localhost (unknown [112.44.73.128]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 19 Apr 2025 02:40:35 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b4fe7395; Sat, 19 Apr 2025 02:45:22 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Hilton Chain Subject: Re: [bug#77527] [PATCH v4 5/6] guix-install.sh: Group profile sourcing. In-Reply-To: (Hilton Chain's message of "Fri, 4 Apr 2025 11:23:02 +0800") References: Date: Sat, 19 Apr 2025 10:45:22 +0800 Message-ID: <87a58chnst.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77527 Cc: 77527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hilton Chain writes: > [...] > + if [ \"$GUIX_PROFILE\" = \"$HOME/.config/guix/current\" ]; then > + # Expose the latest Guix modules to Guile so guix shell and repls spawned by > + # e.g. Geiser work out of the box. > + case $GUILE_LOAD_PATH in > + *$GUIX_PROFILE/share/guile/site/3.0*) ;; > + *) export GUILE_LOAD_PATH=\"$GUIX_PROFILE/share/guile/site/3.0${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH\" ;; > + esac > + case $GUILE_LOAD_COMPILED_PATH in > + *$GUIX_PROFILE/lib/guile/3.0/site-ccache*) ;; > + *) export > GUILE_LOAD_COMPILED_PATH=\"$GUIX_PROFILE/lib/guile/3.0/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH\" > ;; Maybe not needed, since 'guix repl' handle this. > [...] > -# Clean up after ourselves. > -unset GUIX_PROFILE I think it's still needed, since after the for loop the variable is still visible. Otherwise look good to me, thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 16:35:11 2025 Received: (at 77527) by debbugs.gnu.org; 19 Apr 2025 20:35:11 +0000 Received: from localhost ([127.0.0.1]:38406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6Eu6-0004Sk-R8 for submit@debbugs.gnu.org; Sat, 19 Apr 2025 16:35:11 -0400 Received: from out-174.mta0.migadu.com ([2001:41d0:1004:224b::ae]:47266) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6Eu3-0004QG-6u for 77527@debbugs.gnu.org; Sat, 19 Apr 2025 16:35:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1745094897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JC39lz6s87nDP70B5Bvquw/qnMW/p0BDMys/scmSkUY=; b=iyLVnz3bsL1mWjtrqSc5pELIfxTag96LtgpEvreRNApqBwgrcO/4BvX8eML+yg5BPNy0lE QBJYLp6GhS9QqWeXrKxzLt+MKXfme61/hTdtBiFD1gL0muNQvHWlIYLcIQv/fwcXjyrTS4 PPnvD55gX+Ky3jOi3T/d9LElosElZgYX8SXQD+2xTcPjHzWEO5JraEMys5T1z84+OJ0UE0 P1VzpNCkUHLvPbBMSIQijj7LhOw319OkTycR7xvTLInATODUBn1lGUSL+AYBt30Nro87oN qgMbLzTAxT+7cLOEi3BegrdxlkfnKFS4jttDE/ABn73KWTYG8E+wWVv2RiZeGg== From: Liam Hupfer To: Hilton Chain , 77527@debbugs.gnu.org Subject: Re: [bug#77527] [PATCH v4 5/6] guix-install.sh: Group profile sourcing. In-Reply-To: References: Date: Sat, 19 Apr 2025 15:34:47 -0500 Message-ID: <87cyd7houw.fsf@hpfr.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77527 Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Hilton! I recently removed Guix Home profile initialization from the system-level shell profile in bug#76082 (), hence the explicit comment. The rationale is provided in the cover letter, [[bug#76082] [PATCH 0/9] Improve profile initialization on foreign distros plus misc improvements], and commit [[bug#76082] [PATCH 4/9] guix-install.sh: Remove system-level Guix Home initialization.]. I would advocate against attempting to initialize the Guix Home profile in the system =E2=80=98/etc/profile/=E2=80=99 files (or in Guix System=E2= =80=99s equivalent system-level shell initialization). Guix Home is capable of initializing itself entirely at the user level. This is the default behavior and documented in the manual at =E2=80=98(guix) Configuring the Shell=E2=80=99.= Guix Home users retain more control over fine-tuning shell initialization this way. It also keeps search path variables tidy by preventing duplicating Guix Home initialization at the system and user level. WDYT? Thanks! PS: maybe not so useful if/when the Codeberg migration happens, but =E2=80=98(guix) Multiple Patches=E2=80=99 documents handy workarounds for D= ebbugs=E2=80=99s rather subpar handling of patch series. =E2=80=94Liam [[bug#76082] [PATCH 0/9] Improve profile initialization on foreign distros plus misc improvements] [[bug#76082] [PATCH 4/9] guix-install.sh: Remove system-level Guix Home initialization.] --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 20:16:24 2025 Received: (at 77527) by debbugs.gnu.org; 20 Apr 2025 00:16:24 +0000 Received: from localhost ([127.0.0.1]:40442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6IMB-0006lZ-2L for submit@debbugs.gnu.org; Sat, 19 Apr 2025 20:16:24 -0400 Received: from mail.boiledscript.com ([49.12.134.184]:41384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u6IM6-0006kR-6a for 77527@debbugs.gnu.org; Sat, 19 Apr 2025 20:16:20 -0400 Date: Sun, 20 Apr 2025 08:15:53 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=mail; t=1745108176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a6w7VBDGHWb9mYzDC1itxdTlD1bAVKxMk8TkJNu5Kok=; b=LR0lhY4E0JGOAAw9Oh9EceCEU6Qd+9OSP8IyultOmNhEYTFnSGM6iX23EAS+b7ZtUTRUfK QA90ZtxgmMNqtGgr81UWR9Wovx/a43JHmM7ceys63t/Gut4030eVK6zWU8VBwtljPa3TjT BJQ+IFNDZwoS1SfAAnQVKKqTtmpbYiIvPOuRqdM3R3bbfYw1MEKAauQhTCgG5rCfYYlSf2 Z0pHX8CJX0ByVS+4Ul5izXHUZA0zvGJ2YbpnOCNtTx77ph2vSjysr5eUjrVBI5i3fTXslD zFlHc4k4PjpzefeDBGrr8Z/IJ8RpGbvKBx3JppIz/KuBxmYhime/YuQqLKHmRg== Message-ID: <875xizads6.wl-hako@ultrarare.space> From: Hilton Chain To: Liam Hupfer Subject: Re: [bug#77527] [PATCH v4 5/6] guix-install.sh: Group profile sourcing. In-Reply-To: <87cyd7houw.fsf@hpfr.net> References: <87cyd7houw.fsf@hpfr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77527 Cc: 77527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 20 Apr 2025 04:34:47 +0800, Liam Hupfer wrote: > > [1 ] > Hi Hilton! > > I recently removed Guix Home profile initialization from the > system-level shell profile in bug#76082 > (), hence the explicit comment. The > rationale is provided in the cover letter, [[bug#76082] [PATCH 0/9] > Improve profile initialization on foreign distros plus misc > improvements], and commit [[bug#76082] [PATCH 4/9] guix-install.sh: Remove > system-level Guix Home initialization.]. > > I would advocate against attempting to initialize the Guix Home profile > in the system $B!F(B/etc/profile/$B!G(B files (or in Guix System$B!G(Bs equivalent > system-level shell initialization). Guix Home is capable of initializing > itself entirely at the user level. This is the default behavior and > documented in the manual at $B!F(B(guix) Configuring the Shell$B!G(B. Guix Home > users retain more control over fine-tuning shell initialization this > way. It also keeps search path variables tidy by preventing duplicating > Guix Home initialization at the system and user level. > > WDYT? This patch series is for avoiding search path duplication, and search paths for Guix Home won't be initialized again if it's already done (see [PATCH v4 3/6]). If initializing Guix Home separately, search path ordering can't be ensured, and on Guix System ~/.guix-home/profile/bin has higher precedence than /run/privileged/bin. > Thanks! > > PS: maybe not so useful if/when the Codeberg migration happens, but > $B!F(B(guix) Multiple Patches$B!G(B documents handy workarounds for Debbugs$B!G(Bs rather > subpar handling of patch series. I forget it sometimes if I'm dealing with other things :) > $B!=(BLiam > > > [[bug#76082] [PATCH 0/9] > Improve profile initialization on foreign distros plus misc > improvements] > > [[bug#76082] [PATCH 4/9] guix-install.sh: Remove > system-level Guix Home initialization.] From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 22 19:29:46 2025 Received: (at 77527) by debbugs.gnu.org; 22 Apr 2025 23:29:46 +0000 Received: from localhost ([127.0.0.1]:50584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7N3i-0007nc-1j for submit@debbugs.gnu.org; Tue, 22 Apr 2025 19:29:46 -0400 Received: from out-170.mta0.migadu.com ([2001:41d0:1004:224b::aa]:21585) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7N3b-0007n9-US for 77527@debbugs.gnu.org; Tue, 22 Apr 2025 19:29:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpfr.net; s=key1; t=1745364571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XJGbMIgS0ErKdBRW3SFwyXirW57L14sGGYc1MQRyGDM=; b=mwhZW4xYFznSNUiNhBF5g5tRXgWXR5M6X7cwaXH3SmvDQirpEESLCNW2tiaOciKs8V+0nV vnWaPK0IcmtqbjRANGQOLuryOEb0AR1cXDBHCNJse59DHxhAMio1BImeOFSjT/YUUTl/yR /Kl2iPy10okJDvwj4Z25snTlhW6iuNOvC6fyKk1aoed3KGYw8Zqllx4sABYbvJ0wdq7WQo zVh+B2hcol6JitLYQ1IigWuK7cSUVFRSFkQQxMZ/8vsRwjTveYfkc6gnNsHOXJQ2H9DbPO kXAI9sCYDX11suQPLk+Oj4HbRM2Qmvh1H6T5k1MHg7GyORPKie8CaOJmf2EJ/w== From: Liam Hupfer To: Hilton Chain Subject: Re: [bug#77527] [PATCH v4 5/6] guix-install.sh: Group profile sourcing. In-Reply-To: <875xizads6.wl-hako@ultrarare.space> References: <87cyd7houw.fsf@hpfr.net> <875xizads6.wl-hako@ultrarare.space> Date: Tue, 22 Apr 2025 18:29:25 -0500 Message-ID: <87wmbbsrl6.fsf@hpfr.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77527 Cc: 77527@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hilton Chain writes: > This patch series is for avoiding search path duplication, and search pat= hs for > Guix Home won=E2=80=99t be initialized again if it=E2=80=99s already done= (see [PATCH v4 3/6]). > > If initializing Guix Home separately, search path ordering can=E2=80=99t = be ensured, and > on Guix System ~/.guix-home/profile/bin has higher precedence than > /run/privileged/bin. Hmm, IMO Guix Home should own the initialization of system paths if such an ordering is desirable rather than vice versa, but I=E2=80=99m fine with = this approach too. Thanks! =E2=80=94Liam --=-=-=--