From unknown Thu Jun 19 13:56:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77510 <77510@debbugs.gnu.org> To: bug#77510 <77510@debbugs.gnu.org> Subject: Status: 31.0.50; help-customize fails with multiply defined symbols Reply-To: bug#77510 <77510@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:56:31 +0000 retitle 77510 31.0.50; help-customize fails with multiply defined symbols reassign 77510 emacs submitter 77510 Stephen Berman severity 77510 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 18:17:01 2025 Received: (at submit) by debbugs.gnu.org; 3 Apr 2025 22:17:01 +0000 Received: from localhost ([127.0.0.1]:36061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0Srt-0007vT-7Z for submit@debbugs.gnu.org; Thu, 03 Apr 2025 18:17:01 -0400 Received: from lists.gnu.org ([2001:470:142::17]:38890) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0Srr-0007v8-Ew for submit@debbugs.gnu.org; Thu, 03 Apr 2025 18:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0Srh-0005MF-TP for bug-gnu-emacs@gnu.org; Thu, 03 Apr 2025 18:16:50 -0400 Received: from mout.gmx.net ([212.227.17.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0Srf-0005eF-Sq for bug-gnu-emacs@gnu.org; Thu, 03 Apr 2025 18:16:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1743718605; x=1744323405; i=stephen.berman@gmx.net; bh=hZvCuqQAa4XD9A4rGV3nm0irGcY+uFgMw57Eb2tBr5I=; h=X-UI-Sender-Class:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=k0pKls7OnKgFGxAUq4cIob0giTaIIaBnHJjEG4vYH3ezETir2TyltHeMvHKjRnvA LPHk+udsIoHUi1dv23a+irccLpaOSdWaxAjwVCMDTFAN9WEvkLk50lLul99fVbXW1 GxeRu0GEklHW6qaFxogv8/R3WPN6GWQYgSWVVyxQOmW16Hz937YONP2Kvjt9qaImX P/eecuytlxUvOZf3pwpxDpcqwIAVAimkvqaV7WkIEMTLJkH96Aof11OlgOLWEEj5g Q39QIPUSkubKdC53QMEiLidtamf67fig/vOgVoifP3xDy9j1svJ0fg6fJFwi2fq0M 3JFRh+muTResZQlqlw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.50.216]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MuUnK-1t9KFL2rX0-00tnPt for ; Fri, 04 Apr 2025 00:16:45 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 31.0.50; help-customize fails with multiply defined symbols X-Debbugs-Cc: Date: Fri, 04 Apr 2025 00:16:45 +0200 Message-ID: <87v7rkoppu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:huuxLRq3hCLTgJVwACN0pufemblEQWSE/MOYnzAwbyjs1JNMv3W 6I9upWrBVgGT8ZcxZIVB9vfb6r98RniJcn0cPJm/VXz9BW3GmH+nMZgtEIs5Vxc1kGzDkrq mi4vr9qpgwvrQji0NPr00b5Ddmr31KXyP6whmYjCPpdHvAKk4FhIA+WksscAir+Kb3u9u2F Dg1fkPSx60U+4yjKyAT0g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/ssdIMYGIaE=;NTGJzgBaUYPssCcKGGuFyIbyfYS aC/TBcnnZ4OwzSUmJNSlEJ8RzPCoR/qNsJA0ia7zEmQ6FbFOVCW3kmGvTMaq2eqBZ94WTtxSl FhzVMeuuHrkSM5sccF/4xxawMXqdFKLiWil4pNDF5SiDO7cCPQN2hRDjVkftlR5KqY7Depaxy RxqZ/eEAkBWCAUi3rp1fHzBWswbcqB06M1ex5EDbfK1mpO52ywTA0cy5cNbEhSinf+qa2Uz6H qwISOpEV+ImP8Uku5Lfl6IR65RAkmUXZKmGQposjzT1ndGGYr9nTL7vES54i/tCj0sYxqxLx0 TVAEB6xFvzXwA9V8yfAANgGLpk4yspcG3sFeIhLGvKpVlm2Kd0jf1S6ck4coQmy2ltNs3oHDG AmbqPKozOuIW6nHwpwoEbgEMwudVlMSOGO0kFcEMw+S8ix6l8dgrlNSJrNC308lx5FvNNkF0Y IhnlHrlLxjP+fJkMLEIdI7r4Xe2eHOoK49uN513YUyHw8GuPxmUfm+sjCdebTSRMdzlHnFIJN MI2FGgn5JG6sZwSxIgpd7JvoHzlc6GX2PKMiAlme6xINfzx+gLAL3rz8B+g/2iEi5eLHBuz4m gSk4hNIAqaPHL4UBeRW9GdI+yi/IklSTeU3KOO1WnXmygiapMfYZWjg/OKf+zmbAggCBcuQRy QU83pFkdTescl8q19elIje5WD5BIL8GsxFjxPbdEK5ezPJBy06mX0KmxWnqM4ia2OUeltFJx/ DP3CzJDsM34S2wq6Xb7L7zZDxdOEdZu+/qQC+3inva4F6Dn8ic/pHxX8WzrtyOe6QJ773aG2y taqVYQ4uRSQyCtFAPKmOXxEQMd0v/Hb9YMoGgnXA1eytLvEOHqCzFwmA1ttPurHjv1lgwTVBI MdIlNQ1UGul1fEPYeCwJf71/92HVU//wpiWjiRscdojyh27xI3d6/Zue8VkMWXiNJjdVbYbzJ Y7GZo04wGoAcub09a/Mkt1ighdCkF0T7tS1BC51iRgNvymqu9o8njmKUSvsFiveWXJGcAjRn5 pl4GUjRN2mvIFqIxAnOjXooE3sEIbd/grevkqJVj5IE/rjV2+YyiQ8FSvvtBYK1ZOukMM9CT9 Pvar7JFnTdpb9coysN2SGmmXw6eQi7F4WapZV0mmIZMBYg5gYJUxpOMzMtHRXxeRjrEftOQfB L27NttrodkDsaPRd6QuDgO6yPdpKRnuakBGHeoCOQIR9X2wVCN/YypJMRdu6ivu0TJCxguuCY k8unu8ej9sNpXVXeAL6eY1DR8h2o3q3wexdIdXHObThIkfa5oTP3WVjJnjk0kVXAQ/ZF9O32L EFWgjcuWq0ZnRWiUcpXZGQjuHYXM9As8NAWjy/2DQbk1MHEH52KVaEWSY4vmY5UVXZhHMa+Vh RY7ohz1tAxA0vBEq/JDyvjJx9t2R40sMbfWZ5mTMEt/nR6AvyA6Ei5Vmdh+Z5qHugOUQm7Fe0 6wxFBZmKH1iZ0rt7jxqYI+bdfHZw= Received-SPF: pass client-ip=212.227.17.22; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying help for both the function fringe-mode and the variable fringe-mode. 2. In the *Help* buffer type `c'. =3D> Emacs dings and displays the message "No variable or face to customiz= e" When executing this recipe in emacs-30, after step 2 Emacs switches to a *Customize* buffer for the variable fringe-mode, which is the expected behavior after typing `c' (help-customize) in *Help*. This is broken in master. The breakage is due to this commit: commit e776df2a3eae0454ea85287e15ebba649bf8e918 Author: Dmitry Gutov Commit: Dmitry Gutov CommitDate: Sun Oct 6 04:32:00 2024 +0300 help-setup-xref: Keep the local values only of some variables * lisp/help-mode.el (help-setup-xref): Kill all local variables, saving ones that are known to need to be preserved (bug#73637). and the breakage remained after the two followup commits, which is the current code state. According to my debugging, calling help-setup-xref at the end of describe-symbol after the function definition help has been added to the *Help* buffer nullifies the property list of help-mode--current-data (this happens on evaluating `(funcall major-mode)' in help-setup-xref when the value of major-mode is 'help-mode), which renders help-customize a noop. The following patch fixes the breakage according to my brief testing, though I'm not sure it doesn't have unwanted side-effects (but at least I get the same test results on running make check with the patch as without it). --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: help-setup-xref patch diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 7f272de790e..102c92fbb04 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -506,7 +506,7 @@ help-setup-xref restore it properly when going back." (with-current-buffer (help-buffer) ;; Re-enable major mode, killing all unrelated local vars. - (funcall major-mode) + (unless (eq major-mode 'help-mode) (funcall major-mode)) (when help-xref-stack-item (push (cons (point) help-xref-stack-item) help-xref-stack) (setq help-xref-forward-stack nil)) --=-=-= Content-Type: text/plain In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.49, cairo version 1.18.4) of 2025-04-04 built on strobelfs2 Repository revision: 37262eac0525562ac03fe84e6f657de908808245 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101016 System Description: Linux From Scratch r12.3-10 Configured using: 'configure -C 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt6/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINERAMA XINPUT2 XPM XRANDR GTK3 ZLIB --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 04:20:26 2025 Received: (at 77510) by debbugs.gnu.org; 11 Apr 2025 08:20:26 +0000 Received: from localhost ([127.0.0.1]:48577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u39cf-0001pw-Id for submit@debbugs.gnu.org; Fri, 11 Apr 2025 04:20:25 -0400 Received: from mout.gmx.net ([212.227.17.21]:53189) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u39cc-0001pd-PR for 77510@debbugs.gnu.org; Fri, 11 Apr 2025 04:20:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744359616; x=1744964416; i=stephen.berman@gmx.net; bh=gdVzv/ILRXhJYxeKzdFD2glqn+WXuP2FqMIY0O/5GZI=; h=X-UI-Sender-Class:From:To:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=H5uNv3Ukoq/v0YLoUqCcxHX2EjzQHf82Bz3ldUj8h5XG6MsVWFGHZ3j1IhDIAhtK VltscRQHrYnz638iGggoGy2qWO6ORcMa9snYnE2roqBUySAXoSGK2eyoJFp8nwVQ1 Zwk/j+KyfkvEkIfzOUxPEtf0/4l3PhcmvHCC4+NqWTij5VyDqdlDpcfAVncud7Pq9 qKg/phJiBKjeEVTUkF20fEefzhFx0pdjOsEY3OmeAh1JQGotA8lnrrE7xbBF0ujD2 wA3YYAbuQBnTpBQq9BCSUzPN1kutO7zlkxo5IDBE9Wj1ccf3nphXZ0Wt5GKgmnqgU 3uCbvAneJeF87ZiQQQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.255]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWASY-1tWfJt3xm6-00VQzh for <77510@debbugs.gnu.org>; Fri, 11 Apr 2025 10:20:16 +0200 From: Stephen Berman To: 77510@debbugs.gnu.org Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols In-Reply-To: <87v7rkoppu.fsf@gmx.net> References: <87v7rkoppu.fsf@gmx.net> Date: Fri, 11 Apr 2025 10:20:13 +0200 Message-ID: <87semfm7nm.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:X1hAAF6BF533uyjj6FZ3InH5iMCzYqwJR2Fj4Q4hXFQQZptrwUo toRVPLMxpmOEkFL7x4QTLPXAud3CChsO7XzY1eTmi/2s618pqpvx2iakNDTuMQgRIG58C5Y I40Szqrz1++iL2+vt3bH/2GZuw+9+GMRRb9b0GJayEn/oqmITTcYrfTO7ZeKTtXBmi9I0X3 UABzORoeqo9QrhtGP+jUA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:SjDUbRRBMow=;zFw/dIDlSS57zovsUGkJ8ZctKCr hd84ykwhy780i8wNZGJuwy3wcHE2NkwGnqWmS+jei+KSH2jHCLWxB/cLbm7T45CZFC1SIx3iX H2I82Rm1nEuBgY6KCfjOGdkH0x0u+26ryY2BpbBz1uC4gKkmNGVNFOGoXuNG6bJlFhfAB/iWD Wzyhi1j6PwRXRRJs3ByKmsrnc47z2oJWt0tPMvQqDpO3CfZG75tcFpMO1f38VDBqtYBXEVVUf L4XeKTHIBJHDnvVY3SNhV5E9eUMuXPiNfamw09IMPqUwGCufdbLujmhVWwpcpESzbS6zpHaic 0jDPKE+RS3cEU1XNx6Gb9CI2fmPlzBIZ3gND4bsqp6Ky3bcU57SeVS8gawvpRj6xkzWKHnSHT uSO0AuAmgZGrCQXl51fV74oRAW/vV2T3qawxNUrE3ovlidnA5DcmF2pYXT5BSTuON00WsVyJA So107NrVZgrYlyBGfiqnxz0c7FA7fUbXaFmlz3She5O5vvWtrhhF7AFxOtsjHsUKHcnWC30vT YKEsz7DqTk0FFTiUPJP7F4yyJsi0vscFEny/siZ/NomgtF9KClxYD3PSKt4dKdfkeEU8xf4vC PaBfR8ph7TFDlHhdwIsCVfXS6BrrWYTDp0wk/ADgrpvE8b2LLW6JZy1vSmBqTujrztXmpmvZT t7IcRvHkH2oBjrxNHDleTZjFoqnQiZbcqVT6MR9g40fQpJTjgNpbIvoqNZI3FRyH34T2RcjNG Jl/6cUADpeUYmwcq3w4NXWEUdd8HO4rZ5DQOP/gbZ1NYAocW7EkaBoF4qUwMDQpGALIZnzOUi j4fMEjKHv6d7SfFKgeJwAqtTdnVuFTAYy3XafmnZWiG0+UEHq/DyDnWs4um3JVbng9sce8k+s kDnbGLNsYfYLEwsM8lag0LESVThgAsAXxHnCrnb37wUlN380Zea+udQgzV/3C4Inav8S9xYwE mOOqnXdJ05Kglij7DTIkbUvmG1bcs6gqWAhlklgP4h951v+THdtezt/oS1PjQkO+RGF96uIQT +xtEKlBLZxh+vtpFghMsPBnbLOqo5uav4yq+LhRREbtfz7bzDz7kwPH91a5SINeYirxyf0VrI FAc42AC4ExnCd70EyY3RP5YJq1hnr93Sdlit/bC3Mj9N2rciP5AMluHJ+QTb7rRYKj1oIG0O+ b28FSIt7SVOldT/98HEVcZ1viFWF307jrhI9uf5WxCrG3+69CGdrmt6fXInQI8oy8ByUT+E17 mqGtUz0gxYcIv28BJP4xBRLR2woDToRhgqrOT730d6Bom44uzvLd56huciLFuwav1Y+QvcE+g 7o2+UnmqkcPqmGuYCkjpEE1q3j+Xx1TcpRM5QRsgkA7CNAlcxhIZbym3OdwjuX6Y9aN60Zklm CrWgGMGBa7A7N8LSgm6w/2FXxsyNWslEKrPc+MIjdZeHUL5MrXVKaBUosCzzdvc4q6Kqtb6S9 HJDQMY8+FzLBY4y3clLDhmLulR9u+QEGETua9PIxWEl/kuWQXDyUgM2hR86GGv3x+BxutZ0WG 7qoaXE5vhPlWTw9W46l9Ae5LVpliD+FYX4s5fJM3/Fdb0wUKWigPJ5CEF82w/kF+8103HTlB8 ZQO31NdOjcIG7/NJp1OIHuLSwGnN3hKmdLkWYVSc7RfPpkbHrcxn0G2jBSKqkRBPyPsrMuSBw V1pbzjY3OPDflki1+t9nQjsXCVOZfuuqr1OlvhoayT8EASLPZdpw58wHDGBUgENmUQtEm0y2n Zd6NfxDQuwnTARMxNW5qSZvhBd2h5oAMV63SskdSs8eEayWhJAKx3g611IsAcXyylcJAcYakp bQrmrniRZ15CQmLzdd1/JWo1H8yazw3y0+1r6+wavMFGa9QzamidtgBXM4eldfDmzZs5zgyNi 6c7hwz/XNiCNYt8jyonWwZ2rXrBA4bDTvqvU3Y6b3ooqF3P1C62KqpUFUdYCrKF63U6agzgak KG6DgYUwqKFKLnIu+tLQTx0Vq5gtAwmFR+T+1mgiu4SO01ligip8SJZHdbEj+Sh/2ae+JfcNj AX9YzxT98xUh5RX7S6PU6CiH3hgFKr2oRHi2Ae9tNS/KxnaRrdBC59Vo+dBTwYOQpwCqG1QvX YwOOrzVr34q1WRoZyNuXm326oRBHqVtHFi9+5b6M27n78hoDmLTE6btjrmZ0fBCu1SHjyXjmh 1wD3pspjjr3jzoa6Ba1/32cSCDyMXNvdXt24qimiQ9fKPSDXMEZO3fWpQJUcMw+FJodswAdka DCGnaTKff/15A4G8c94syai2ZDPJw3mRaYBAaPSEanSspBvT5riMFHEC/a9tTpEnAqWhNUTgZ dEtp1s1ln1Iw2CvfbThx5dpwELn7B6Zc99L1/3k+qzbHl3Jcug9HENXGlbiCWyWmQ6U2CH9pg pU8Zmy6/umwQe+Slq3OOZolGc8Rt/0I0a/pzytqxnJdrMq5gXbC3vnZa/jJeDZTtYdsDuJsOc dWB9JFt98YU82hmKaZ+v5vsrNbukfiWEfZe+yaxMiyGsqxnWpYF8tZR6hzJdnhu+jD+cI//vf ajSAlEiMyYpPtHTnIohks8q3i7ajynyrykU4YkgTfD4ZI7BI392CGup0egxrbYkd1CRzLhHM0 rkNG/kXM6RGbkLoWF58BZp53FFKyOM7B7j69agBD5PZLsi2XRNQjUaVBB7M4A0PtkJldqd7cT 3xhl/IHqp0P398C4/s4oN47RR560GJ86bPxbxpUqfbkC2eF/HhPCft8cZulooo3SikP2KDemw 8X76DwO9cSpwnHpI1v6ZR9/8ja5GC2VI2Ymi09O9GTsL6/EcOuTB4uYEpOFtXsOwuirt5GEZs f0Gm77kaMGBhr7MIwaqkay/oYqQVg0NPkH/bR7VOgjmoP6n0Vm/rjso1kLaF2q8Sya14uVFw7 cddmoPl/m+v8xON1HTybJC6nuUsHscEyDoCYwGXEh9YlqRY1v8uDQFDTssgco6vnAqfyTa3e0 h+uy/qaEBDbP4igMSym+ppn5yPdn8LqKb+hcNx1llXH5PW/RjtF+EtObS8oxG9V4bP+Tvrx2K o4HO3ciu9V2VSMx/YkRukEgtQCId0GfokUVKY2xwtO1+ou7BHtxjn3P69QwtCVo0Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77510 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 04 Apr 2025 00:16:45 +0200 Stephen Berman wrote: > 0. emacs -Q > 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying > help for both the function fringe-mode and the variable fringe-mode. > 2. In the *Help* buffer type `c'. > => Emacs dings and displays the message "No variable or face to customize" > > When executing this recipe in emacs-30, after step 2 Emacs switches to a > *Customize* buffer for the variable fringe-mode, which is the expected > behavior after typing `c' (help-customize) in *Help*. This is broken in > master. The breakage is due to this commit: > > commit e776df2a3eae0454ea85287e15ebba649bf8e918 > Author: Dmitry Gutov > Commit: Dmitry Gutov > CommitDate: Sun Oct 6 04:32:00 2024 +0300 > > help-setup-xref: Keep the local values only of some variables > > * lisp/help-mode.el (help-setup-xref): Kill all local variables, > saving ones that are known to need to be preserved (bug#73637). > > and the breakage remained after the two followup commits, which is the > current code state. > > According to my debugging, calling help-setup-xref at the end of > describe-symbol after the function definition help has been added to the > *Help* buffer nullifies the property list of help-mode--current-data > (this happens on evaluating `(funcall major-mode)' in help-setup-xref > when the value of major-mode is 'help-mode), which renders > help-customize a noop. The following patch fixes the breakage according > to my brief testing, though I'm not sure it doesn't have unwanted > side-effects (but at least I get the same test results on running make > check with the patch as without it). > > diff --git a/lisp/help-mode.el b/lisp/help-mode.el > index 7f272de790e..102c92fbb04 100644 > --- a/lisp/help-mode.el > +++ b/lisp/help-mode.el > @@ -506,7 +506,7 @@ help-setup-xref > restore it properly when going back." > (with-current-buffer (help-buffer) > ;; Re-enable major mode, killing all unrelated local vars. > - (funcall major-mode) > + (unless (eq major-mode 'help-mode) (funcall major-mode)) > (when help-xref-stack-item > (push (cons (point) help-xref-stack-item) help-xref-stack) > (setq help-xref-forward-stack nil)) Is there any objection to installing this patch to fix the regression? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 05:03:06 2025 Received: (at 77510) by debbugs.gnu.org; 11 Apr 2025 09:03:07 +0000 Received: from localhost ([127.0.0.1]:48694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3AHy-0003vx-Es for submit@debbugs.gnu.org; Fri, 11 Apr 2025 05:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59164) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3AHv-0003vP-Os for 77510@debbugs.gnu.org; Fri, 11 Apr 2025 05:03:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u3AHq-0003cP-Dz; Fri, 11 Apr 2025 05:02:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Tvr3WTRvw7yIIQwPn6kWcE2SkCCIOVSgjH1k1aohrQs=; b=dcgRp4kb1ORR uVLablRQ/zLSPi4Vp/CUTPuTO6aIHKX4DpR2Sl6lAI2X2k7iiWjSgWubLoSExVNkbPsrOBiJPnp7O rdKmEgc4wIl4LDKg+dw07DAg/gILlkmnG5V+VX4Rwo7icMbkhDzc1tybbzGTEWT6vzndXDeRtdg75 +9z1b4BX6+N0q0ne/YrpTOzox/cn7Jlv4owLd74neYsdURQ0zX4q0iHB1Urp5H3DfpUkUDydapG00 A/OCLPntlDCzudoNvFnk2nOZeVypQ2hTi4UpAh7hwUKyR5D450+06jSUIw4fCL7RAWb63U37gU75G PWT0axBpMuaHLbDDRTeX3Q==; Date: Fri, 11 Apr 2025 12:02:22 +0300 Message-Id: <864iyvoyu9.fsf@gnu.org> From: Eli Zaretskii To: Stephen Berman , Dmitry Gutov In-Reply-To: <87semfm7nm.fsf@gmx.net> (bug-gnu-emacs@gnu.org) Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols References: <87v7rkoppu.fsf@gmx.net> <87semfm7nm.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77510 Cc: 77510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 11 Apr 2025 10:20:13 +0200 > From: Stephen Berman via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > On Fri, 04 Apr 2025 00:16:45 +0200 Stephen Berman wrote: > > > 0. emacs -Q > > 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying > > help for both the function fringe-mode and the variable fringe-mode. > > 2. In the *Help* buffer type `c'. > > => Emacs dings and displays the message "No variable or face to customize" > > > > When executing this recipe in emacs-30, after step 2 Emacs switches to a > > *Customize* buffer for the variable fringe-mode, which is the expected > > behavior after typing `c' (help-customize) in *Help*. This is broken in > > master. The breakage is due to this commit: > > > > commit e776df2a3eae0454ea85287e15ebba649bf8e918 > > Author: Dmitry Gutov > > Commit: Dmitry Gutov > > CommitDate: Sun Oct 6 04:32:00 2024 +0300 > > > > help-setup-xref: Keep the local values only of some variables > > > > * lisp/help-mode.el (help-setup-xref): Kill all local variables, > > saving ones that are known to need to be preserved (bug#73637). > > > > and the breakage remained after the two followup commits, which is the > > current code state. > > > > According to my debugging, calling help-setup-xref at the end of > > describe-symbol after the function definition help has been added to the > > *Help* buffer nullifies the property list of help-mode--current-data > > (this happens on evaluating `(funcall major-mode)' in help-setup-xref > > when the value of major-mode is 'help-mode), which renders > > help-customize a noop. The following patch fixes the breakage according > > to my brief testing, though I'm not sure it doesn't have unwanted > > side-effects (but at least I get the same test results on running make > > check with the patch as without it). > > > > diff --git a/lisp/help-mode.el b/lisp/help-mode.el > > index 7f272de790e..102c92fbb04 100644 > > --- a/lisp/help-mode.el > > +++ b/lisp/help-mode.el > > @@ -506,7 +506,7 @@ help-setup-xref > > restore it properly when going back." > > (with-current-buffer (help-buffer) > > ;; Re-enable major mode, killing all unrelated local vars. > > - (funcall major-mode) > > + (unless (eq major-mode 'help-mode) (funcall major-mode)) > > (when help-xref-stack-item > > (push (cons (point) help-xref-stack-item) help-xref-stack) > > (setq help-xref-forward-stack nil)) > > Is there any objection to installing this patch to fix the regression? Thanks for the ping, but it's too early for you to assume this fell through the cracks, as today is just 1 week since your OP. Some people take more than that to respond. I added Dmitry to the discussion (it is generally a good idea to do that in the OP, by means of the X-Debbugs-Cc header). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 05:23:44 2025 Received: (at 77510) by debbugs.gnu.org; 11 Apr 2025 09:23:45 +0000 Received: from localhost ([127.0.0.1]:48738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3Abw-0004wF-Gq for submit@debbugs.gnu.org; Fri, 11 Apr 2025 05:23:44 -0400 Received: from mout.gmx.net ([212.227.15.18]:41369) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3Abs-0004vu-ST for 77510@debbugs.gnu.org; Fri, 11 Apr 2025 05:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744363407; x=1744968207; i=stephen.berman@gmx.net; bh=lpA/ZGgfToQHPdYWhj+ykYEqb8TMSSe1F08SO1v/g7Q=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=Z+84NZGN6dpxMLWkNyLZ9CBivWYlEGNRT37vq1YMlw314Ee93BhoEQ2yKK1XGGJo dGXFcuiIP/JFS7Oh5pUlC9qLH4/ioa9zXBMyf817Lwi9Fh1EASHGXXk4gHCyhpI51 gcLbIbN7boHT4/bX7V0Fc6k4+L7Qw3RS7+kYLw71PWhPpzf7kCU2Mm5Ka7cjjF9sA IclOyTll5fJR6A1M7aPP6rCE1C/WWpmQeEWvFWz8ba2LSAJ0x4mTYZ2sLWjJgVkIz +a4A5pSJVNl7d9+gQ6aTAq/Dtp5FsZMK1OwMVk4C1XUxlmrxcZRszpv21eROnigIV hsc+0mf5QL5DjqrsHQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.255]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Msq2E-1t9xUF2cPo-010ekE; Fri, 11 Apr 2025 11:23:27 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols In-Reply-To: <864iyvoyu9.fsf@gnu.org> References: <87v7rkoppu.fsf@gmx.net> <87semfm7nm.fsf@gmx.net> <864iyvoyu9.fsf@gnu.org> Date: Fri, 11 Apr 2025 11:23:26 +0200 Message-ID: <87o6x3m4q9.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:1dq+gNSbJiWPLcLH0lXpbJ/BVXfLOkmODEY6x/NZe4beLfiZNqs PBu8qUy0G8Grd3FI7xPIZoKSkgE28o49NHBu2YDfxCn6KZLGNvB38YkdWduqVMnY1nO9Qa2 zf7iICr0DfAHJd2YydNzczHy5+36rq0onG5CZ06RWwhnd9MABHyojzTxkwhO0SAqiQT3bEb XVMRn5kWrdZemvyQkxzcQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:YxiOfNSC7vQ=;Vo6jZCB9cLSNoH0NETlSAb4cgrN mjLRScQKAt62y2RxgJDZtJP11TyXzMP3X424oSzIRZLVxaagWSJBXYsUwxD3Y2PUecpWZ/lJl B9ZU9VNJXgieyknFBMIIMicbiY3ZXBY5i7o6ByGmQtPxC9zPy8EBQ9AH54ZYnYm3VnXcNudk/ RLX/SN6Fl8Xvv+YE1022Gs7OdiHV4zcugv/Kmbvymb9PyLM54F+gY1z3abC5hvXW+MbJxt+eC cH1rYGiFcBYdocAKaL03NZkL/I98AI1DuzLnGnc+kvp1R/M07Wvxhf6391Dq7yPUbGMhVFZEA 1eXxn2GysSTawyxD5X9AXukkr4F7nAA8I9M2khoQw0mM/UnoRSyRbhuXY93U+HzAbu6GgtiJw SQ0wrXd9NmtsxxAUmdHJ/BeufzLEPs7sgQGGaU1FdvGJCr4g92rt7CgiAFhhfONIciv3VRkAy hPLrSL3UHbaPtzXBm2pGchYk+1ojl3f77Nd7R4nU+IMFQ9L8k7nFQSlUUNL8BWl4n9+1I2G3U wmu3N93kbWI4TI4xL9w+HLMyWq4EGimlijgaFCHx8b2vLlGcS/64ZBVxl2e7cKEgiJyQ9D6JL I0LTnmSZWnsaySUPjWeZo7gWmiYDa2RyJI6eO7+4heo0gg0dRDx2gY8TBovIt0006fDH3iNPK ad1RD9uME4g7GnJU9GQaRvBPEKkw5xuYe9bJC0wsK3COMo/B3hDG8w2dHof8XhkjOK8Nlk5/j AKj2gLM1wD9L2yYRhRISOGCvdsLkZMyNn3m3zoVJHaPJuhCikVlSiAVTFj3MyG5Oh+iTkHn6h Kif24u7JxvbxCCGTQPZEg5PjiT8dU+eW22exMGNWOCISm2CDKIMB9IaBkERSbjGqgmqhIJqok L+rp+ltcIPn37Hs1IsWJwaLW7bwKDTsUHpymmafExlJuyn/khHXcixicME/I0dAvIuWQ4G2UZ DG0tQO0/Mfk5+fY3sNfx/zjjBdhEjPlmpQgpbou5EJk+dbgRgszpMlc9AaxNiWekmWkV7Lb5J XjVaPh+LKqRWdB/UlWm2AImlEsZ96Jhl2YVoqjYGdjuwKl2VjU/OcWO0olXBsuujNeM9y9f4n +FQPSKd8D+d0js28lh4uik2Bgd9RQ5KO5gD469IJD0t5E+LVmInxg8+3XHhvDMAJcR2XlSBFS 33dTduM7o0vIMOICtydwrIM+5VAWsUborlRuBIhFK+zwoa7Ick+igjt1Ij1v5rhemScEcrprm dFd+kBh4TkhNR0JH0CO5vevihEdBC6FAiMqxACw2mjwGbjmWH2nz7bLVvd55mZNfAT3lEuhQ9 XKgMqmK4haL9TIQjzDDkTp+BVMG7Si4K+4UiwUEmWxfxenqa6N72nYN91XG2b1UH91slfwlh+ XAyFiy8HyEIvmfVFFJdw9W/WHoYfwuo9Hp3YxAs/3tUNm1VQSNiEH5i4A6WjPCDtHqnLuw/dR ezsvk34p2inB+JzVydIRQvxogojKyOx5Pcq/UT26zDQqL8Fg7ZHdNaSECNiZUr8j+IHD+NJPf qszUAya6ZtqFbpbHk+nHf7pVd20Uc24LANokuQWxhwbzD3rLf3/kOtvNZe3N6Ya8mMKHC5uu6 MuJIcNrnvk8C6SuaWRsrCRHmOwTiT66yNLda9yDfwRiu/u5HqBjFgfsrGWd3CQWn9g1iHRF12 CgSkfJoMVSyWZ1dbLdKCOYh82rXUvbvRiZDkOld8jSukgfBU/3Gxlh77nrCh29Ej5j2GXMtYW gI2y7t71XRjwFvj3q609YU49VJ/9Ar0g1OPyFkMgEQHV6MBG/m717mf0ogSNi3OncZbNQeUAw 8T1kF3amA7QSD5WqHQm0Fn64NhWJOOR9hRTUoxG0iVOjgsXufabKiPjXfFZErcPQCkpzrgdlp ISBJIDe/KqpBK2Ljnu1wMR9n12TyXSYSqQWni78M5cUpFMPzlv420nVzckw/DkeYJiT705hRC S56ffNsj/dSmjFTcsfMFCZJsnR6vC4gGxdKtSZIOjXW/GogiAXjlCQ8sPJdrtz+XEIvStrjuS rrqZW3lveGyJylJIYIQkUpX6DYOKdXlS16po6PnTsAgEFWYaBxB6evpwOLerUDuKBi/NgF2DE YIDkxVDUn3DFT65UZ27yJLJRzFq0+UrNOfjp+2J9XGaQFpGtpjdAMekT5mmxntFBZwB6pwThf KnYuTPXLuniCej7A6lrkPauem7Tdm8OCfaVAm3xfvdKdOMc5f23KErGuhtUpK9tM9Oo5isCea 0RyVCG73hMYg5i1mrXFKTteljl38/6EgDNSJjCdJ0PpO23RuECvFxMeni5iKxMg30rDVUCf9O l+rSaHJTr0VgUN9rhxkUpIyV1sJ7zX57pa6ZmsuaZ7xd7oqM1ixbjrxIpvvBXHNm6dY0Tt/rY hw24DEo6PKWrM5QJV3pJM+SqrPeXRd/TSRKtutXZ0AhGiG+sJW9u/T/fAQygiPf3ZtQ+tzsbA An9BhrIsvSqS2CXRMiNa9qPBuTzVFKDCHzvrRnVM7M3KcAK2I1l0LJ02C6XErbTk9fsuoGDFv J8yHrg6wUEjkduQLs2iqG1ofyuNCXAMu7BOh2zJ4dQJ3fiyxKVNqjyYbxnaI+vCaT0ZgH/+2M bavb0QMLsI0nW22UYFPVD/8ZMXPYlxwrVTRrKHTc7US8XB7lIv3a9V792ZL5G9yAC9VFtUl5P fJmoUHxuPLaaW1eqo9rkfomasjak3sWButbhe9EIz+L9Fs+iuDFac8P1JY8cHjWKfc2+UjfSe Ysc2lZNBuWCWHRXAQan/If7ekMa7vnVxYtw1QZb8srCdrcNBQPP1EJpDPmwdYTYQqjame53ei S7dxKErLCTrpvFjB9zy88ALjiGUBMXTsP68SpVTMC9P9Svyy6l9BODr7JcUhxThw8t8R/e8PL Cq6h5Gi6H9qoaMU6b1wzVXSNJVtl7a8zHx3fW87mrx2f4C/2RCgGlzcl5vFdPI91kmt1Beh/X s428tQeS5uxKGf5NaCXHZ7A5hfd+qLoCKXEFpgOftaoemM2qbRiLrHUDywocdgnI8Lsu9947B ASJpIwfq2XGk7hD2GH41xo= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77510 Cc: Dmitry Gutov , 77510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, 11 Apr 2025 12:02:22 +0300 Eli Zaretskii wrote: >> Date: Fri, 11 Apr 2025 10:20:13 +0200 >> From: Stephen Berman via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> On Fri, 04 Apr 2025 00:16:45 +0200 Stephen Berman wrote: >> >> > 0. emacs -Q >> > 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying >> > help for both the function fringe-mode and the variable fringe-mod= e. >> > 2. In the *Help* buffer type `c'. >> > =3D> Emacs dings and displays the message "No variable or face to cus= tomize" >> > >> > When executing this recipe in emacs-30, after step 2 Emacs switches t= o a >> > *Customize* buffer for the variable fringe-mode, which is the expecte= d >> > behavior after typing `c' (help-customize) in *Help*. This is broken= in >> > master. The breakage is due to this commit: >> > >> > commit e776df2a3eae0454ea85287e15ebba649bf8e918 >> > Author: Dmitry Gutov [...] >> Is there any objection to installing this patch to fix the regression? > > Thanks for the ping, but it's too early for you to assume this fell > through the cracks, as today is just 1 week since your OP. Some > people take more than that to respond. Sure, no sweat. > I added Dmitry to the discussion (it is generally a good idea to do > that in the OP, by means of the X-Debbugs-Cc header). Thanks. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 12 20:45:02 2025 Received: (at 77510) by debbugs.gnu.org; 13 Apr 2025 00:45:02 +0000 Received: from localhost ([127.0.0.1]:34163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3lT3-0006XB-Gu for submit@debbugs.gnu.org; Sat, 12 Apr 2025 20:45:02 -0400 Received: from fout-b8-smtp.messagingengine.com ([202.12.124.151]:53283) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3lT1-0006WK-2J for 77510@debbugs.gnu.org; Sat, 12 Apr 2025 20:44:59 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id 4BDC2114016D; Sat, 12 Apr 2025 20:44:53 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Sat, 12 Apr 2025 20:44:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1744505093; x=1744591493; bh=Xg3VETDS5brIIgzl929OAJurAJ2CrtECvrE4NExla3I=; b= UmQsdjnr1wmLO3xZNLDAf8Mgs4FGiGI0QNt+2Gyme++qq7Toqr7KdEYqhYtSqHwE /JZRuJGlsg86PE1Z/yVbPSRaRskI0s93usL9hdEvhefqNiL+BFQOxvcywl7QTQwd L1Jso/cSfNyy8uT/istWKZzXhdBshA7VzwW3LSM8vs5nkw973GoUF05jKbASNYn5 rPL6x1cei2B0VKfK6Cum2gHUIFhoE2FfJKxtaGhi4nTXr+QBn7+NcgUYXFEUraAO J04Pe1KMEB3sQqfN7gm9Cc5l9XFFQGRSdd+5b1b6W1b6W5MeoZ4Kx12gL2rfTBkS iTFhdQSJSfWegY3mAKXDnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1744505093; x=1744591493; bh=X g3VETDS5brIIgzl929OAJurAJ2CrtECvrE4NExla3I=; b=lzSISe11UbCS4h6PV Nm3cyF9YGsrEaulo+QLRbOcAfjnktjL8VW3FCk/BcQz6zXLEs74YuJV++a0uNQAQ 7QE9Vvv/JYJt0Z7wVVZifNCkkofWJy1qFcMrnocGruhRg36OP6da1DQHEXtl5Nig Xl2TDCwJVsFC8TThraxraMk0D41j+n9dQFRMTa7SVZi1ms1wVZdzR9qw/vEFrKAI RnLAF+3TZK/ApsncRUe1zHkuFKZm6rEABTndPb8+vgCAmHOE8nb5o7TzkWo3fSPo zotiRewEbCASy8yJQYBmBg2AZLKAmdlgaSpk18/w8JKFTmfjnnPWS0nU4Ypr4cfJ GIIpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvudeivddvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddv jeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrd guvghvqeenucggtffrrghtthgvrhhnpedthfeuvddtveelgeeuleevvdejveehffevveeh vdeuffdtfefhvdeugefgtefgtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvhdpnhgspghrtghpthht ohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepshhtvghphhgvnhdrsggvrh hmrghnsehgmhigrdhnvghtpdhrtghpthhtohepjeejhedutdesuggvsggsuhhgshdrghhn uhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Apr 2025 20:44:51 -0400 (EDT) Message-ID: <9ee5a03d-2db8-453c-80de-a62eeb8cae30@gutov.dev> Date: Sun, 13 Apr 2025 03:44:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols To: Stephen Berman , 77510@debbugs.gnu.org References: <87v7rkoppu.fsf@gmx.net> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87v7rkoppu.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77510 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! Thanks for reporting. On 04/04/2025 01:16, Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > 0. emacs -Q > 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying > help for both the function fringe-mode and the variable fringe-mode. > 2. In the *Help* buffer type `c'. > => Emacs dings and displays the message "No variable or face to customize" > > When executing this recipe in emacs-30, after step 2 Emacs switches to a > *Customize* buffer for the variable fringe-mode, which is the expected > behavior after typing `c' (help-customize) in *Help*. This is broken in > master. The breakage is due to this commit: > > commit e776df2a3eae0454ea85287e15ebba649bf8e918 > Author: Dmitry Gutov > Commit: Dmitry Gutov > CommitDate: Sun Oct 6 04:32:00 2024 +0300 > > help-setup-xref: Keep the local values only of some variables > > * lisp/help-mode.el (help-setup-xref): Kill all local variables, > saving ones that are known to need to be preserved (bug#73637). > > and the breakage remained after the two followup commits, which is the > current code state. > > According to my debugging, calling help-setup-xref at the end of > describe-symbol after the function definition help has been added to the > *Help* buffer nullifies the property list of help-mode--current-data > (this happens on evaluating `(funcall major-mode)' in help-setup-xref > when the value of major-mode is 'help-mode), which renders > help-customize a noop. The following patch fixes the breakage according > to my brief testing, though I'm not sure it doesn't have unwanted > side-effects (but at least I get the same test results on running make > check with the patch as without it). It seems like your proposal would regress the bug report that's referenced in the above commit message. The change has the goal to reset some buffer-local variables, and the current means to do that is to call the major mode function again. If the major-mode function is not called, the vars are not reset. What are the other options we could use? help-setup-xref's docstring says it should be called very early - perhaps before the value of help-mode--current-data is assigned? Making help-mode--current-data would also be an option, but it won't work alone because help-mode function sets it to nil explicitly as well. I wonder what will happen if we remove that assignment. Finally, if 'describe-symbol' is the only main exception (where help-setup-xref is called late), we could save and restore the current value of help-mode--current-data just there. Like this: diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 6c4c3f4da97..fa7241d3e9d 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -1965,7 +1965,8 @@ describe-symbol (unless single ;; Don't record the `describe-variable' item in the stack. (setq help-xref-stack-item nil) - (help-setup-xref (list #'describe-symbol symbol) nil)) + (let ((help-mode--current-data help-mode--current-data)) + (help-setup-xref (list #'describe-symbol symbol) nil))) (goto-char (point-max)) (help-xref--navigation-buttons) (goto-char (point-min)))))) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 13 04:59:20 2025 Received: (at 77510) by debbugs.gnu.org; 13 Apr 2025 08:59:21 +0000 Received: from localhost ([127.0.0.1]:38587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3tBP-0003QH-OZ for submit@debbugs.gnu.org; Sun, 13 Apr 2025 04:59:20 -0400 Received: from mout.gmx.net ([212.227.17.20]:58229) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3tBL-0003Oh-An for 77510@debbugs.gnu.org; Sun, 13 Apr 2025 04:59:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744534746; x=1745139546; i=stephen.berman@gmx.net; bh=PpPUrBs6AAQMMekS+/Pux/9vrnJDnklUOkLaUgSeRLU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=dqsyN7hqGrngisyLG3Pjxz4YBcOW97c9vS1jAiVZGXMYpaE7nh6Z8RUwZMbZfAFW 7ah4T4/uKp8M6JgQT4/QG8jy/nXQ1xyp/GzN5jxpHRR8ftg0XgQKEQAkceqa8fnB+ oYOR5KMgMtrEVnJOOE7dQkWkfrrfKCmphzYCUYnNduKP8mc+48bY1P8kUJg06/R6Z OHrzI6Kk41TVLeBUuuRO8VlHf2rP2xWRwRI1fgsujJlPiUUo1zeli+Rz2S9pfqnEK IjuImqEhdnEm9c8M/lEcjWl8EZ40pGi3zbpR0ntZj85oya4qKEXMCRey8ufhnDjBM A/vXdHfMPx+xjGA3+w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs2 ([88.130.49.192]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4s0t-1u4AA901CR-004AeO; Sun, 13 Apr 2025 10:59:06 +0200 From: Stephen Berman To: Dmitry Gutov Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols In-Reply-To: <9ee5a03d-2db8-453c-80de-a62eeb8cae30@gutov.dev> References: <87v7rkoppu.fsf@gmx.net> <9ee5a03d-2db8-453c-80de-a62eeb8cae30@gutov.dev> Date: Sun, 13 Apr 2025 10:59:05 +0200 Message-ID: <87v7r85teu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:12nEFFYm1445tFbGfo+O1DNzvm3fzQmYpCQIdbiPbqSS/L1rnwT PI6FNU7h/GrF4zJbtec8ISSy3tETduCIcWjdFitHEBUnN8b1iuToYC9E/7ChIzhNSMvdsmz X5H3dRxj8dOP25obGZnAfp89pizHKRlNb9ptHaFKluRoqJZ9c9R0RIjbQtC9Wn/LVNrEH4x TVPLgdJoMqMTry9aroyGQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hYtmCteex/w=;NqdHqBgUOVb4ENmqv09yOEz20Q+ vkyUn6JDNCiIyjlyBPGIuRX4nNEDc6BmhniSyKT5f6f4GOKBR0OrQuyeYzFTCeULvPbzV+SGF LA3ZyQig3qhD7h/qpoHEpQgj2rLShlCdvvogiXVGflxCIxGrT3ZzRMpc1MDEjaDPDyeWcXyX0 yT/ShcU+heAZkbShHxbBAL4GAE1iBuXXP3fAtRRJB63odm3KeYfwgKing6c2lcPG7wY8vTX2E MN6MaxzY6qjrTmdrlAF3mzu1JePzpbsutFZM9kic+y6m8wHrSiInPupiXwC+5azrHsXvQew2f 5zykw+O8brILEu7uxr7uqsM4oclMcbmYSylfp3wG5CxBP5jp0HgmgDNX5xHcfmKWAq1i57Qfz 7pyn5YS3vSiCfiXnGPv4744ktuuEXQR+gu3neqaV10XB7MkZixi1WKTQtArjGZdyoPIkcm9IL 6biWnaFZLVpsNs12jv3xIbaaZOJUwiU95aC7zkDLjIdL9jxLqkfYATjI/FiMHPzl8OsdfelOd ax+FwAdfJECpkt0C+KpJCV+jROeJvI1S3RIlW9D0IBtoMky9xmJoI7zQSjce/8R7T6Fk6HH+z mrb8mHiermHkE4tKukX9MX/Eor/kezFv9iqfshNTiU52AhN3YC9wGfjh7uIQHE4Up/7d54wiy Uc+choz0TqqDS+Ag4iyL/Py+U7HSociMKQu6iCedpijel5cmY+RmubkBeN2lloZqd7ksqSwI8 bcDWRxKMb2ANqymSEqeq0ufMnWwL0L82zsmc5Uv9RAab6G28aUDbc4/CvX/rNpYFqvshVzx4E PZk4FETTWKJEMK4z3qM9YEh0seBc5ufucrbdtguiV/GNVtoarYedF1uQOjJ9qpymoweeD+ZdR TckgiHeuhjrqo076TBY5q89hyOaVG+IL4VyCYb1IleuUDN48LUNnS1yIa+SdQ12K1O2kQd788 4SOIls/HXBOY8jX/VvGz3Rk8zSwlHO3+HHqX9w2SajuEYN191qaauCTlBuMh13OrvgYgmPva3 PxsmxM5BYZ8lZ9DvNf51V0nlSIiOAI33he9602V0GiTMOhBuCII4rbcayzGy7kPwryR9TYg71 bFTTXJujTCiHi7+r0lKrIOzwEhf94uOz04RZ8kYCTlgMylCpyH+IMn048tHvdefGkyG8+HdeN 4v6tZtFQSC6U4hZGsCFFVIRZ5+BPvT383CJ/W8dlc36dc9TQyxGdqUT2vnrMg4VfAHP8M4XY/ ZzMdE/EYNjA7iC5OYPVbA8MO9P/vrqOGaDPdIhywAXLmQGVUn2lhxV83FdEsIG7Yw0E4GrRvY Kp8B+oIwlNIwlBXhCvS4hIhCHPapWoOw8r61JZoRo6TT/SdJTD8l44ZnOdEiMxi96O7CXMis8 Bzvy3zKwQ3Q650q3G8vnxOvMiZGHpOwGHjeYeQoG55Qd+QD9woQNb2fFxBvHS+cdjnj0INwbr F3yn+vcErHAz9K/uFuDaFF9bhVrg= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77510 Cc: 77510@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sun, 13 Apr 2025 03:44:49 +0300 Dmitry Gutov wrote: > Hi! Thanks for reporting. > > On 04/04/2025 01:16, Stephen Berman via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> 0. emacs -Q >> 1. Type `C-h o fringe-mode RET' to pop up a *Help* buffer displaying >> help for both the function fringe-mode and the variable fringe-mode= . >> 2. In the *Help* buffer type `c'. >> =3D> Emacs dings and displays the message "No variable or face to custo= mize" >> >> When executing this recipe in emacs-30, after step 2 Emacs switches to = a >> *Customize* buffer for the variable fringe-mode, which is the expected >> behavior after typing `c' (help-customize) in *Help*. This is broken i= n >> master. The breakage is due to this commit: >> >> commit e776df2a3eae0454ea85287e15ebba649bf8e918 >> Author: Dmitry Gutov >> Commit: Dmitry Gutov >> CommitDate: Sun Oct 6 04:32:00 2024 +0300 >> >> help-setup-xref: Keep the local values only of some variables >> >> * lisp/help-mode.el (help-setup-xref): Kill all local variables, >> saving ones that are known to need to be preserved (bug#73637). >> >> and the breakage remained after the two followup commits, which is the >> current code state. >> >> According to my debugging, calling help-setup-xref at the end of >> describe-symbol after the function definition help has been added to th= e >> *Help* buffer nullifies the property list of help-mode--current-data >> (this happens on evaluating `(funcall major-mode)' in help-setup-xref >> when the value of major-mode is 'help-mode), which renders >> help-customize a noop. The following patch fixes the breakage accordin= g >> to my brief testing, though I'm not sure it doesn't have unwanted >> side-effects (but at least I get the same test results on running make >> check with the patch as without it). > > It seems like your proposal would regress the bug report that's > referenced in the above commit message. The change has the goal to reset > some buffer-local variables, and the current means to do that is to call > the major mode function again. > > If the major-mode function is not called, the vars are not reset. > > What are the other options we could use? > > help-setup-xref's docstring says it should be called very early - > perhaps before the value of help-mode--current-data is assigned? > > Making help-mode--current-data would also be an option, but it won't > work alone because help-mode function sets it to nil explicitly as well. > I wonder what will happen if we remove that assignment. > > Finally, if 'describe-symbol' is the only main exception (where > help-setup-xref is called late), we could save and restore the current > value of help-mode--current-data just there. > > Like this: > > diff --git a/lisp/help-fns.el b/lisp/help-fns.el > index 6c4c3f4da97..fa7241d3e9d 100644 > --- a/lisp/help-fns.el > +++ b/lisp/help-fns.el > @@ -1965,7 +1965,8 @@ describe-symbol > (unless single > ;; Don't record the `describe-variable' item in the stack. > (setq help-xref-stack-item nil) > - (help-setup-xref (list #'describe-symbol symbol) nil)) > + (let ((help-mode--current-data help-mode--current-data)) > + (help-setup-xref (list #'describe-symbol symbol) nil))) > (goto-char (point-max)) > (help-xref--navigation-buttons) > (goto-char (point-min)))))) I confirm this fixes the issue I reported, so if my patch is problematical, I'm fine with yours. Thanks! Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 13 20:38:57 2025 Received: (at 77510-done) by debbugs.gnu.org; 14 Apr 2025 00:38:57 +0000 Received: from localhost ([127.0.0.1]:44612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u47qi-0005ts-MU for submit@debbugs.gnu.org; Sun, 13 Apr 2025 20:38:57 -0400 Received: from fhigh-a3-smtp.messagingengine.com ([103.168.172.154]:55353) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u47qf-0005tX-Bv for 77510-done@debbugs.gnu.org; Sun, 13 Apr 2025 20:38:55 -0400 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id B607311401E2; Sun, 13 Apr 2025 20:38:47 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sun, 13 Apr 2025 20:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1744591127; x=1744677527; bh=A3MxpJP7hXyOuvtpmpoXs9uL4AV4d6y8a8cfnNgFzBw=; b= QMkNj4+7FNEb4rBIcrbzH0czbMM6b7cEjTueuzsTJy6allNf3PqKA0jF1QYXV8BR 65kB3n2MHMk1R0atLJCcDbrDkEk6oPe1f0pnJQeoBeTL9Oz1xU6BzWvhx+LrveOS nq8OD+74ljvx1fThbyLJsdWPOJyrmOxrOHorKqeu4vao7oL4KbGGgWOOfvZzHDX1 8LQQN+c/BnnAzSZCqAwZSqySFVE2ABRZokm41fGH6fFGKnGE9dc/Lnw5FYICKSIj 6Xi5vByuXrqZdJBhyM8RoDNFAAwFIak6v+7ZTynnQBArvahlU5IfBa+kfR7g3R5y 4cmyD6w3mJ6B/qpTWZoHmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1744591127; x= 1744677527; bh=A3MxpJP7hXyOuvtpmpoXs9uL4AV4d6y8a8cfnNgFzBw=; b=n x5vl3sEgqH0I5sm9dYFHq5hoEQN/19hzd98b8cYBb4FJCQqfHbltsGfBOiM1Mf9d bN19V3O0IZCbhdWUo4c7dNvoUfPRnSdcSGJtXFVMAQ6hOuc88rwWy17Y/4rk9SVA gj3AoWHbWNMhnrvsXM+Bo+NtB4MN6dVNfMxrtlKgJb52k6eHGCk2fTptKz1jNIRQ Qnswpz2AV+QMa+M6hS0MmjR9okwrvlMwctzA2jtT5OcG+KgCJo8BIYbvYOSnWiHY BnA6q+S8lGxasf1tXf8F6dO6tUm4ZARys1DMoBJXu1mLQqnfpeLULuxjkOPDbZ2t Z9H6gQTNZPrbI3yeIbSiQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvudeludegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovh druggvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieek ueeftddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphht thhopedvpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsthgvphhhvghnrdgsvg hrmhgrnhesghhmgidrnhgvthdprhgtphhtthhopeejjeehuddtqdguohhnvgesuggvsggs uhhgshdrghhnuhdrohhrgh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Apr 2025 20:38:46 -0400 (EDT) Message-ID: <27aebfb3-06bf-4b5c-81c3-2872c31276ec@gutov.dev> Date: Mon, 14 Apr 2025 03:38:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols To: Stephen Berman References: <87v7rkoppu.fsf@gmx.net> <9ee5a03d-2db8-453c-80de-a62eeb8cae30@gutov.dev> <87v7r85teu.fsf@gmx.net> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87v7r85teu.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77510-done Cc: 77510-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 13/04/2025 11:59, Stephen Berman wrote: >> Like this: >> >> diff --git a/lisp/help-fns.el b/lisp/help-fns.el >> index 6c4c3f4da97..fa7241d3e9d 100644 >> --- a/lisp/help-fns.el >> +++ b/lisp/help-fns.el >> @@ -1965,7 +1965,8 @@ describe-symbol >> (unless single >> ;; Don't record the `describe-variable' item in the stack. >> (setq help-xref-stack-item nil) >> - (help-setup-xref (list #'describe-symbol symbol) nil)) >> + (let ((help-mode--current-data help-mode--current-data)) >> + (help-setup-xref (list #'describe-symbol symbol) nil))) >> (goto-char (point-max)) >> (help-xref--navigation-buttons) >> (goto-char (point-min)))))) > I confirm this fixes the issue I reported, so if my patch is > problematical, I'm fine with yours. Thanks! Great! I've pushed this patch to master, thanks for testing. We can return to other options if some other drawbacks are reported. From unknown Thu Jun 19 13:56:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 May 2025 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator