GNU bug report logs - #77501
[PATCH] Restore logging of OpenSMTPd to /var/log/maillog.

Previous Next

Package: guix-patches;

Reported by: Felix Lechner <felix.lechner <at> lease-up.com>

Date: Thu, 3 Apr 2025 18:07:01 UTC

Severity: normal

Tags: patch

Done: Andreas Enge <andreas <at> enge.fr>

Bug is archived. No further changes may be made.

Full log


Message #29 received at 77501 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Felix Lechner <felix.lechner <at> lease-up.com>
Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki <gabriel <at> erlikon.ch>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 77501 <at> debbugs.gnu.org,
 Andreas Enge <andreas <at> enge.fr>
Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a
 configurable option. (Closes: #77501)
Date: Wed, 09 Apr 2025 23:22:58 +0200
Hi,

Felix Lechner <felix.lechner <at> lease-up.com> skribis:

> Please also see this thread:
>
>     https://lists.gnu.org/archive/html/help-guix/2025-04/msg00009.html
>
> Change-Id: I485e040d680ccb39fa62e49d2e6ea916f047972c

Could you add a conventional commit log?


[...]

>                      #~(make-forkexec-constructor
> -                       (list #$smtpd "-f" #$config-file)
> -                       #:pid-file "/var/run/smtpd.pid")))
> +                       (list #$smtpd
> +                             "-d"
> +                             "-f" #$config-file)
> +                       #:log-file #$log-file)))

I believe #:pid-file should be kept, no?

I would also keep the (list …) bit on a single line.

Thanks,
Ludo’.




This bug report was last modified 31 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.